Re: [PR] Use infinite scroll select [cloudstack]
sureshanaparti merged PR #11991: URL: https://github.com/apache/cloudstack/pull/11991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
sureshanaparti commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3815668152 Verified the domain selection with keyword search (after the page size set), in the following views: - Add Host - Add User (from all users view) - Create Template from Volume Snapshot - Upload Volume from Local - Upload Volume from URL - Create Webhook -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
blueorangutan commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3803885294 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11991 (QA-JID-855) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
blueorangutan commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3803805568 @DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
DaanHoogland commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3803803860 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
blueorangutan commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3803568210 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
sureshanaparti commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3803277924 @vishesh92 check the ui build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
blueorangutan commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3803138109 Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 16545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
blueorangutan commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3803066539 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
sureshanaparti commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3803063667 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
blueorangutan commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3771653803 Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 16444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
blueorangutan commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3771504837 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
DaanHoogland commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3771501154 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
blueorangutan commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3768171053 Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 16418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
blueorangutan commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3768014090 @RosiKyu a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
RosiKyu commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3768006984 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
blueorangutan commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3766998250 Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 16412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
blueorangutan commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3766995053 @RosiKyu a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
RosiKyu commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3766992665 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
github-actions[bot] commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3760938225 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
blueorangutan commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3742527956 @vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
blueorangutan commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3742620046 UI build failed: :heavy_multiplication_x: (SL-JID-844) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
vishesh92 commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3742520905 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
vishesh92 commented on code in PR #11991:
URL: https://github.com/apache/cloudstack/pull/11991#discussion_r2681301800
##
ui/src/components/widgets/InfiniteScrollSelect.vue:
##
@@ -166,6 +178,19 @@ export default {
},
formattedSearchFooterMessage () {
return `${this.$t('label.showing.results.for').replace('%x',
this.searchQuery)}`
+},
+selectableOptions () {
+ const currentValue = this.$attrs.value
+ // Only filter out null/empty options when the current value is also
null/undefined/empty
+ // This prevents such options from being selected and allows the
placeholder to show instead
+ if (currentValue === null || currentValue === undefined || currentValue
=== '') {
+return this.options.filter(option => {
+ const optionValue = option[this.optionValueKey]
+ return optionValue !== null && optionValue !== undefined &&
optionValue !== ''
+})
+ }
+ // When a valid value is selected, show all options
+ return this.options
Review Comment:
I added this to maintain consistency with the existing behavior in UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Use infinite scroll select [cloudstack]
blueorangutan commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3718611614 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11991 (QA-JID-840) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
shwstppr commented on code in PR #11991:
URL: https://github.com/apache/cloudstack/pull/11991#discussion_r2668166079
##
ui/src/components/widgets/InfiniteScrollSelect.vue:
##
@@ -246,6 +274,44 @@ export default {
this.preselectedOptionValue = null
this.successiveFetches = 0
},
+getApiOptionsCount () {
+ // Return count of options excluding the locally added defaultOption
+ if (this.defaultOption) {
+const defaultOptionValue = this.defaultOption[this.optionValueKey]
+return this.options.filter(option => option[this.optionValueKey] !==
defaultOptionValue).length
+ }
+ return this.options.length
+},
Review Comment:
this can be under computed?
##
ui/src/components/view/DedicateDomain.vue:
##
@@ -72,59 +64,49 @@ export default {
},
data () {
return {
- domainsLoading: false,
domainId: null,
- accountsList: null,
- domainsList: null,
+ selectedAccount: null,
domainError: false
}
},
+ computed: {
+domainsApiParams () {
+ return {
+listall: true,
+details: 'min'
+ }
+},
+accountsApiParams () {
+ if (!this.domainId) {
+return {
+ listall: true,
+ showicon: true
+}
+ }
+ return {
+showicon: true,
+domainid: this.domainId
+ }
+}
+ },
watch: {
error () {
this.domainError = this.error
}
},
created () {
-this.fetchData()
},
methods: {
-fetchData () {
- this.domainsLoading = true
- api('listDomains', {
-listAll: true,
-details: 'min'
- }).then(response => {
-this.domainsList = response.listdomainsresponse.domain
-
-if (this.domainsList[0]) {
- this.domainId = this.domainsList[0].id
- this.handleChangeDomain(this.domainId)
-}
- }).catch(error => {
-this.$notifyError(error)
- }).finally(() => {
-this.domainsLoading = false
- })
-},
-fetchAccounts () {
- api('listAccounts', {
-domainid: this.domainId
- }).then(response => {
-this.accountsList = response.listaccountsresponse.account || []
-if (this.accountsList && this.accountsList.length === 0) {
- this.handleChangeAccount(null)
-}
- }).catch(error => {
-this.$notifyError(error)
- })
-},
-handleChangeDomain (e) {
- this.$emit('domainChange', e)
+handleChangeDomain (domainId) {
+ this.domainId = domainId
+ this.selectedAccount = null
+ this.$emit('domainChange', domainId)
this.domainError = false
- this.fetchAccounts()
+ // InfiniteScrollSelect will auto-reload accounts when apiParams changes
Review Comment:
do we really need these comments?
##
ui/src/components/widgets/InfiniteScrollSelect.vue:
##
@@ -166,6 +178,19 @@ export default {
},
formattedSearchFooterMessage () {
return `${this.$t('label.showing.results.for').replace('%x',
this.searchQuery)}`
+},
+selectableOptions () {
+ const currentValue = this.$attrs.value
+ // Only filter out null/empty options when the current value is also
null/undefined/empty
+ // This prevents such options from being selected and allows the
placeholder to show instead
+ if (currentValue === null || currentValue === undefined || currentValue
=== '') {
+return this.options.filter(option => {
+ const optionValue = option[this.optionValueKey]
+ return optionValue !== null && optionValue !== undefined &&
optionValue !== ''
+})
+ }
+ // When a valid value is selected, show all options
+ return this.options
Review Comment:
What is the benefit of this differentiation? Maybe we can show the
null/empty option always or is it beneficial when using the value from route?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Use infinite scroll select [cloudstack]
blueorangutan commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3718544748 @shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
shwstppr commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3718541037 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
DaanHoogland commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3718488915 I think it can go on a LTS, it is an improvement on the UI only and does not change any functionality, nor add DB or API interfaces. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
abh1sar commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3718479894 This looks more suitable for a major release. Thoughts? @vishesh92 @DaanHoogland -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
daviftorres commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3542477764 Dear @vishesh92 , this is a very welcome feature. Thank you. As our organization grows, the filters and pages take time to load and the UI becomes more and more sluggish. I would say, pagination is could be applied to more parts of the UI. Keep up with the good work! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
DaanHoogland commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3532930928 @vishesh92 the default option when creating a webhook is only shown whilst another option is chosen. And also still the last shown option is the last but one domain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
vishesh92 commented on code in PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#discussion_r2523250010 ## ui/src/views/infra/UsageRecords.vue: ## @@ -121,15 +121,20 @@ ref="domain" name="domain" > -
Re: [PR] Use infinite scroll select [cloudstack]
vishesh92 commented on code in PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#discussion_r2523250010 ## ui/src/views/infra/UsageRecords.vue: ## @@ -121,15 +121,20 @@ ref="domain" name="domain" > -
Re: [PR] Use infinite scroll select [cloudstack]
blueorangutan commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3525288824 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11991 (QA-JID-799) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
blueorangutan commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3525223935 @shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
shwstppr commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3525220505 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
shwstppr commented on code in PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#discussion_r2497967556 ## ui/src/components/widgets/InfiniteScrollSelect.vue: ## @@ -58,6 +58,7 @@ :filter-option="false" :loading="loading" show-search +allowClear Review Comment: @vishesh92 please do check if this doesn't creates any issue for existing usages (esp global project selection) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use infinite scroll select [cloudstack]
Copilot commented on code in PR #11991:
URL: https://github.com/apache/cloudstack/pull/11991#discussion_r2497642823
##
ui/src/views/storage/CreateTemplate.vue:
##
@@ -73,42 +73,30 @@
-
-
-
-
-
-{{ opt.path || opt.name || opt.description }}
-
-
-
+@change-option-value="handleDomainChange" />
-
-
- {{ acc.name }}
-
-
+api="listAccounts"
+:apiParams="accountsApiParams"
+resourceType="account"
+optionValueKey="name"
+optionLabelKey="name"
+defaultIcon="team-outlined"
+:placeholder="apiParams.account.description" />
Review Comment:
Missing `@change-option-value` event handler for account changes. In the
original code, `handleAccountChange` was called to update the `account`
variable. Without this handler, the `account` variable will not be updated when
the user selects a different account, potentially breaking functionality that
depends on this value.
##
ui/src/views/compute/wizard/OwnershipSelection.vue:
##
@@ -36,218 +36,161 @@
-
-
-
-
-
-{{ domain.path || domain.name || domain.description }}
-
-
-
+api="listDomains"
+:apiParams="domainsApiParams"
+resourceType="domain"
+optionValueKey="id"
+optionLabelKey="path"
+defaultIcon="block-outlined"
+@change-option-value="handleDomainChange" />
-
-
-
-
-
- {{ account.name }}
-
-
-
+ api="listAccounts"
+ :apiParams="accountsApiParams"
+ resourceType="account"
+ optionValueKey="name"
+ optionLabelKey="name"
+ defaultIcon="team-outlined"
+ @change-option-value="handleAccountChange" />
-
-
-
-
-
- {{ project.name }}
-
-
-
+ api="listProjects"
+ :apiParams="projectsApiParams"
+ resourceType="project"
+ optionValueKey="id"
+ optionLabelKey="name"
+ defaultIcon="project-outlined"
+ @change-option-value="handleProjectChange" />
Re: [PR] Use infinite scroll select [cloudstack]
codecov[bot] commented on PR #11991: URL: https://github.com/apache/cloudstack/pull/11991#issuecomment-3492287585 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11991?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 4.02%. Comparing base ([`d53b6db`](https://app.codecov.io/gh/apache/cloudstack/commit/d53b6dbda42f56c6f67f4452647e93f4b7ad35a8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`10b60c2`](https://app.codecov.io/gh/apache/cloudstack/commit/10b60c27a0d5c4621127b71d6ecede178caef0a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (d53b6db) and HEAD (10b60c2). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (d53b6db) | HEAD (10b60c2) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.20 #11991 +/- ## = - Coverage 16.19%4.02% -12.17% = Files 5657 402 -5255 Lines49846732548 -465919 Branches 60491 5780-54711 = - Hits 80702 1309-79393 + Misses 40878331086 -377697 + Partials 8982 153 -8829 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/11991/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/11991/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.02% <ø> (+0.01%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/11991/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/11991?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
