Re: [PR] api,server,ui: support tags for domains [cloudstack]
harikrishna-patnala merged PR #11964: URL: https://github.com/apache/cloudstack/pull/11964 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] api,server,ui: support tags for domains [cloudstack]
blueorangutan commented on PR #11964: URL: https://github.com/apache/cloudstack/pull/11964#issuecomment-3803558208 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] api,server,ui: support tags for domains [cloudstack]
blueorangutan commented on PR #11964: URL: https://github.com/apache/cloudstack/pull/11964#issuecomment-3803402209 @harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] api,server,ui: support tags for domains [cloudstack]
harikrishna-patnala commented on PR #11964: URL: https://github.com/apache/cloudstack/pull/11964#issuecomment-3803396548 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] api,server,ui: support tags for domains [cloudstack]
blueorangutan commented on PR #11964: URL: https://github.com/apache/cloudstack/pull/11964#issuecomment-3803113307 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 16544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] api,server,ui: support tags for domains [cloudstack]
blueorangutan commented on PR #11964: URL: https://github.com/apache/cloudstack/pull/11964#issuecomment-3802977719 @harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] api,server,ui: support tags for domains [cloudstack]
harikrishna-patnala commented on PR #11964: URL: https://github.com/apache/cloudstack/pull/11964#issuecomment-3802972683 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] api,server,ui: support tags for domains [cloudstack]
github-actions[bot] commented on PR #11964: URL: https://github.com/apache/cloudstack/pull/11964#issuecomment-3768255802 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] api,server,ui: support tags for domains [cloudstack]
blueorangutan commented on PR #11964: URL: https://github.com/apache/cloudstack/pull/11964#issuecomment-3646582993 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] api,server,ui: support tags for domains [cloudstack]
blueorangutan commented on PR #11964: URL: https://github.com/apache/cloudstack/pull/11964#issuecomment-3646144980 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] api,server,ui: support tags for domains [cloudstack]
shwstppr commented on PR #11964: URL: https://github.com/apache/cloudstack/pull/11964#issuecomment-3646138128 Addressed comments from Copilot @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] api,server,ui: support tags for domains [cloudstack]
shwstppr commented on PR #11964: URL: https://github.com/apache/cloudstack/pull/11964#issuecomment-3646134607 Addressed comment from Copilot @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] api,server,ui: support tags for domains [cloudstack]
blueorangutan commented on PR #11964: URL: https://github.com/apache/cloudstack/pull/11964#issuecomment-3644953896 [SF] Trillian test result (tid-14970) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 55598 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11964-t14970-kvm-ol8.zip Smoke tests completed. 147 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_uservm_host_control_state | `Failure` | 16.96 | test_host_control_state.py test_02_unsecure_vm_migration | `Error` | 333.76 | test_vm_life_cycle.py test_02_unsecure_vm_migration | `Error` | 333.77 | test_vm_life_cycle.py test_08_migrate_vm | `Error` | 20.27 | test_vm_life_cycle.py test_01_migrate_vm_strict_tags_success | `Error` | 71.61 | test_vm_strict_host_tags.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] api,server,ui: support tags for domains [cloudstack]
blueorangutan commented on PR #11964: URL: https://github.com/apache/cloudstack/pull/11964#issuecomment-3641788999 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] api,server,ui: support tags for domains [cloudstack]
DaanHoogland commented on PR #11964: URL: https://github.com/apache/cloudstack/pull/11964#issuecomment-3641782714 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] api,server,ui: support tags for domains [cloudstack]
blueorangutan commented on PR #11964: URL: https://github.com/apache/cloudstack/pull/11964#issuecomment-3641143411 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16002 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] api,server,ui: support tags for domains [cloudstack]
blueorangutan commented on PR #11964: URL: https://github.com/apache/cloudstack/pull/11964#issuecomment-3640631663 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] api,server,ui: support tags for domains [cloudstack]
DaanHoogland commented on PR #11964: URL: https://github.com/apache/cloudstack/pull/11964#issuecomment-3640630098 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] api,server,ui: support tags for domains [cloudstack]
Copilot commented on code in PR #11964:
URL: https://github.com/apache/cloudstack/pull/11964#discussion_r2488600739
##
server/src/main/java/com/cloud/api/query/dao/DomainJoinDaoImpl.java:
##
@@ -110,6 +115,16 @@ public DomainResponse newDomainResponse(ResponseView view,
EnumSet tags =
ApiDBUtils.listResourceTagViewByResourceUUID(domain.getUuid(),
+ResourceTag.ResourceObjectType.Domain);
+if (CollectionUtils.isNotEmpty(tags)) {
+Set tagResponses = new HashSet<>();
+for (ResourceTagJoinVO tag : tags) {
+ResourceTagResponse tagResponse =
ApiDBUtils.newResourceTagResponse(tag, true);
+tagResponses.add(tagResponse);
+}
+domainResponse.setTags(tagResponses);
+}
Review Comment:
This tag retrieval and population logic is duplicated in
ApiResponseHelper.createDomainResponse(). Consider extracting this into a
shared helper method to avoid code duplication and maintain consistency.
```suggestion
ApiResponseHelper.populateDomainTags(domain.getUuid(),
domainResponse);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] api,server,ui: support tags for domains [cloudstack]
codecov[bot] commented on PR #11964: URL: https://github.com/apache/cloudstack/pull/11964#issuecomment-3480451684 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11964?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 3.58%. Comparing base ([`bfc4f60`](https://app.codecov.io/gh/apache/cloudstack/commit/bfc4f60e1da8f2c4e686d07a35b213b8cd659ec2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d94ad99`](https://app.codecov.io/gh/apache/cloudstack/commit/d94ad99d746f9f03e46d99e59c5a74de4808b2b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 5 commits behind head on main. > :exclamation: There is a different number of reports uploaded between BASE (bfc4f60) and HEAD (d94ad99). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (bfc4f60) | HEAD (d94ad99) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #11964 +/- ## = - Coverage 17.56%3.58% -13.98% = Files 5909 445 -5464 Lines52904537532 -491513 Branches 64615 6901-57714 = - Hits 92933 1346-91587 + Misses 42565736022 -389635 + Partials 10455 164-10291 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/11964/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/11964/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.58% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/11964/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/11964?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
