Re: [PR] kvm: do not add disk cache mode from an empty string [cloudstack]
Pearl1594 merged PR #12248: URL: https://github.com/apache/cloudstack/pull/12248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] kvm: do not add disk cache mode from an empty string [cloudstack]
DaanHoogland commented on PR #12248: URL: https://github.com/apache/cloudstack/pull/12248#issuecomment-3758701990 > code lgtm > > I will test it will you still see a chance to test this, @weizhouapache ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] kvm: do not add disk cache mode from an empty string [cloudstack]
blueorangutan commented on PR #12248: URL: https://github.com/apache/cloudstack/pull/12248#issuecomment-3758299333 [SF] Trillian test result (tid-15190) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 49704 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12248-t15190-kvm-ol8.zip Smoke tests completed. 141 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] kvm: do not add disk cache mode from an empty string [cloudstack]
DaanHoogland commented on PR #12248: URL: https://github.com/apache/cloudstack/pull/12248#issuecomment-3755364216 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] kvm: do not add disk cache mode from an empty string [cloudstack]
blueorangutan commented on PR #12248: URL: https://github.com/apache/cloudstack/pull/12248#issuecomment-3755367383 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] kvm: do not add disk cache mode from an empty string [cloudstack]
blueorangutan commented on PR #12248: URL: https://github.com/apache/cloudstack/pull/12248#issuecomment-3754200822 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] kvm: do not add disk cache mode from an empty string [cloudstack]
blueorangutan commented on PR #12248: URL: https://github.com/apache/cloudstack/pull/12248#issuecomment-3753930047 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] kvm: do not add disk cache mode from an empty string [cloudstack]
DaanHoogland commented on PR #12248: URL: https://github.com/apache/cloudstack/pull/12248#issuecomment-3753924402 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] kvm: do not add disk cache mode from an empty string [cloudstack]
blueorangutan commented on PR #12248: URL: https://github.com/apache/cloudstack/pull/12248#issuecomment-3688124980 [SF] Trillian Build Failed (tid-15053) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] kvm: do not add disk cache mode from an empty string [cloudstack]
blueorangutan commented on PR #12248: URL: https://github.com/apache/cloudstack/pull/12248#issuecomment-3688124462 @weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] kvm: do not add disk cache mode from an empty string [cloudstack]
weizhouapache commented on PR #12248: URL: https://github.com/apache/cloudstack/pull/12248#issuecomment-3688121698 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] kvm: do not add disk cache mode from an empty string [cloudstack]
blueorangutan commented on PR #12248: URL: https://github.com/apache/cloudstack/pull/12248#issuecomment-3688010690 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] kvm: do not add disk cache mode from an empty string [cloudstack]
blueorangutan commented on PR #12248: URL: https://github.com/apache/cloudstack/pull/12248#issuecomment-3687852559 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] kvm: do not add disk cache mode from an empty string [cloudstack]
DaanHoogland commented on PR #12248: URL: https://github.com/apache/cloudstack/pull/12248#issuecomment-3687850612 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] kvm: do not add disk cache mode from an empty string [cloudstack]
blueorangutan commented on PR #12248: URL: https://github.com/apache/cloudstack/pull/12248#issuecomment-3648716513 [SF] Trillian test result (tid-14976) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 52497 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12248-t14976-kvm-ol8.zip Smoke tests completed. 132 look OK, 9 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_uservm_host_control_state | `Failure` | 16.77 | test_host_control_state.py ContextSuite context=TestHostControlState>:teardown | `Error` | 32.21 | test_host_control_state.py test_01_sys_vm_start | `Failure` | 0.10 | test_secondary_storage.py ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 4.71 | test_service_offerings.py test_04_nonsecured_to_secured_vm_migration | `Error` | 392.49 | test_vm_life_cycle.py test_08_migrate_vm | `Error` | 46.90 | test_vm_life_cycle.py test_01_migrate_vm_strict_tags_success | `Error` | 332.34 | test_vm_strict_host_tags.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 104.10 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | `Error` | 102.02 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 112.62 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | `Error` | 113.27 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Error` | 62.45 | test_vpc_redundant.py test_01_VPC_nics_after_destroy | `Error` | 57.44 | test_vpc_router_nics.py test_02_VPC_default_routes | `Error` | 58.15 | test_vpc_router_nics.py test_01_redundant_vpc_site2site_vpn | `Failure` | 58.43 | test_vpc_vpn.py test_01_vpc_site2site_vpn_multiple_options | `Failure` | 56.38 | test_vpc_vpn.py test_01_cancel_host_maintenance_ssh_enabled_agent_connected | `Failure` | 1.14 | test_host_maintenance.py test_03_cancel_host_maintenance_ssh_disabled_agent_connected | `Failure` | 0.14 | test_host_maintenance.py test_04_cancel_host_maintenance_ssh_disabled_agent_disconnected | `Failure` | 1.13 | test_host_maintenance.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] kvm: do not add disk cache mode from an empty string [cloudstack]
blueorangutan commented on PR #12248: URL: https://github.com/apache/cloudstack/pull/12248#issuecomment-3645791746 @weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] kvm: do not add disk cache mode from an empty string [cloudstack]
weizhouapache commented on PR #12248: URL: https://github.com/apache/cloudstack/pull/12248#issuecomment-3645784979 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] kvm: do not add disk cache mode from an empty string [cloudstack]
blueorangutan commented on PR #12248: URL: https://github.com/apache/cloudstack/pull/12248#issuecomment-3645650561 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] kvm: do not add disk cache mode from an empty string [cloudstack]
blueorangutan commented on PR #12248: URL: https://github.com/apache/cloudstack/pull/12248#issuecomment-3645374263 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] kvm: do not add disk cache mode from an empty string [cloudstack]
weizhouapache commented on PR #12248: URL: https://github.com/apache/cloudstack/pull/12248#issuecomment-3645366056 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] kvm: do not add disk cache mode from an empty string [cloudstack]
codecov[bot] commented on PR #12248: URL: https://github.com/apache/cloudstack/pull/12248#issuecomment-3645341886 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/12248?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 4.00%. Comparing base ([`79ebf69`](https://app.codecov.io/gh/apache/cloudstack/commit/79ebf6959e174ef8d366f4770d136be46fc46ba4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6aada70`](https://app.codecov.io/gh/apache/cloudstack/commit/6aada70c4af26716fe6e8287046c44eb82674666?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (79ebf69) and HEAD (6aada70). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (79ebf69) | HEAD (6aada70) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.20 #12248 +/- ## = - Coverage 16.21%4.00% -12.22% = Files 5657 402 -5255 Lines49864232677 -465965 Branches 60520 5812-54708 = - Hits 80868 1309-79559 + Misses 40875431213 -377541 + Partials 9020 155 -8865 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/12248/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/12248/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.00% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/12248/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/12248?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
