Re: [PR] server: allow adding non-overlapping ipv6 ranges in same vlan [cloudstack]
DaanHoogland merged PR #11556: URL: https://github.com/apache/cloudstack/pull/11556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: allow adding non-overlapping ipv6 ranges in same vlan [cloudstack]
weizhouapache commented on PR #11556: URL: https://github.com/apache/cloudstack/pull/11556#issuecomment-3270525446 > lgtm, do we also need to test overlapping ranges? good point tested it just now, got an exception https://github.com/user-attachments/assets/ff97280c-3620-4b06-9a93-ae87981caa49"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: allow adding non-overlapping ipv6 ranges in same vlan [cloudstack]
weizhouapache commented on PR #11556: URL: https://github.com/apache/cloudstack/pull/11556#issuecomment-3270490037 Tested OK Steps - add public IPv6 range fd00:2025:9:9::1/64, vlan=1000 - add public IPv6 range fd00:2025:9:10::1/64, vlan=1000 Without this change https://github.com/user-attachments/assets/f9028dd2-6449-46b1-bd51-e9441a786ea6"; /> With this change, new range is added https://github.com/user-attachments/assets/96722077-0a4b-40c6-8a97-324b1f8d5785"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: allow adding non-overlapping ipv6 ranges in same vlan [cloudstack]
blueorangutan commented on PR #11556: URL: https://github.com/apache/cloudstack/pull/11556#issuecomment-3267996437 [SF] Trillian test result (tid-14234) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 54523 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11556-t14234-kvm-ol8.zip Smoke tests completed. 141 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: allow adding non-overlapping ipv6 ranges in same vlan [cloudstack]
blueorangutan commented on PR #11556: URL: https://github.com/apache/cloudstack/pull/11556#issuecomment-3264605808 @shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: allow adding non-overlapping ipv6 ranges in same vlan [cloudstack]
shwstppr commented on PR #11556: URL: https://github.com/apache/cloudstack/pull/11556#issuecomment-3264602956 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: allow adding non-overlapping ipv6 ranges in same vlan [cloudstack]
blueorangutan commented on PR #11556: URL: https://github.com/apache/cloudstack/pull/11556#issuecomment-3255364416 @weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: allow adding non-overlapping ipv6 ranges in same vlan [cloudstack]
blueorangutan commented on PR #11556: URL: https://github.com/apache/cloudstack/pull/11556#issuecomment-3257476836 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: allow adding non-overlapping ipv6 ranges in same vlan [cloudstack]
weizhouapache commented on PR #11556: URL: https://github.com/apache/cloudstack/pull/11556#issuecomment-3257153422 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: allow adding non-overlapping ipv6 ranges in same vlan [cloudstack]
blueorangutan commented on PR #11556: URL: https://github.com/apache/cloudstack/pull/11556#issuecomment-3257154774 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: allow adding non-overlapping ipv6 ranges in same vlan [cloudstack]
weizhouapache commented on PR #11556: URL: https://github.com/apache/cloudstack/pull/11556#issuecomment-3255356570 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: allow adding non-overlapping ipv6 ranges in same vlan [cloudstack]
blueorangutan commented on PR #11556: URL: https://github.com/apache/cloudstack/pull/11556#issuecomment-3255472351 [SF] Trillian Build Failed (tid-14214) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: allow adding non-overlapping ipv6 ranges in same vlan [cloudstack]
blueorangutan commented on PR #11556: URL: https://github.com/apache/cloudstack/pull/11556#issuecomment-3255338857 Packaging result [SF]: ✔️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 14855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: allow adding non-overlapping ipv6 ranges in same vlan [cloudstack]
weizhouapache commented on PR #11556: URL: https://github.com/apache/cloudstack/pull/11556#issuecomment-3254505123 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: allow adding non-overlapping ipv6 ranges in same vlan [cloudstack]
blueorangutan commented on PR #11556: URL: https://github.com/apache/cloudstack/pull/11556#issuecomment-3254510171 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: allow adding non-overlapping ipv6 ranges in same vlan [cloudstack]
codecov[bot] commented on PR #11556: URL: https://github.com/apache/cloudstack/pull/11556#issuecomment-3244317987 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11556?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 3.63%. Comparing base ([`8756be5`](https://app.codecov.io/gh/apache/cloudstack/commit/8756be5c18796469f6d480d3bebdde983e6a2a53?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb97ad0`](https://app.codecov.io/gh/apache/cloudstack/commit/bb97ad071807bd273298018bf395dfdef3c1b23d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 53 commits behind head on 4.20. > :exclamation: There is a different number of reports uploaded between BASE (8756be5) and HEAD (bb97ad0). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (8756be5) | HEAD (bb97ad0) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.20 #11556 +/- ## = - Coverage 16.16%3.63% -12.53% = Files 5656 441 -5215 Lines49788437019 -460865 Branches 60378 6785-53593 = - Hits 80463 1345-79118 + Misses 40846635513 -372953 + Partials 8955 161 -8794 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/11556/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/11556/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.63% <ø> (-0.38%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/11556/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/11556?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
