Re: [PR] server: remove extra chars when template status is error string [cloudstack]
weizhouapache merged PR #11329: URL: https://github.com/apache/cloudstack/pull/11329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: remove extra chars when template status is error string [cloudstack]
blueorangutan commented on PR #11329: URL: https://github.com/apache/cloudstack/pull/11329#issuecomment-3137893399 [SF] Trillian test result (tid-13965) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 58832 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11329-t13965-kvm-ol8.zip Smoke tests completed. 130 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_12_destroy_cpvm | `Error` | 3.29 | test_ssvm.py ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py test_disable_oobm_ha_state_ineligible | `Error` | 1519.30 | test_hostha_kvm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: remove extra chars when template status is error string [cloudstack]
blueorangutan commented on PR #11329: URL: https://github.com/apache/cloudstack/pull/11329#issuecomment-3134813901 @shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: remove extra chars when template status is error string [cloudstack]
shwstppr commented on PR #11329: URL: https://github.com/apache/cloudstack/pull/11329#issuecomment-3134811531 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: remove extra chars when template status is error string [cloudstack]
shwstppr commented on PR #11329: URL: https://github.com/apache/cloudstack/pull/11329#issuecomment-3132565554 @OlegChuev that can be a separate change. Adding a new response param with this behaviour would need change in UI too which relies on status field -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: remove extra chars when template status is error string [cloudstack]
OlegChuev commented on PR #11329: URL: https://github.com/apache/cloudstack/pull/11329#issuecomment-3132464898 Hi @shwstppr. Maybe it would be cleaner to return `state` as `failed` and include the exact reason in the `error_details`? Wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: remove extra chars when template status is error string [cloudstack]
blueorangutan commented on PR #11329: URL: https://github.com/apache/cloudstack/pull/11329#issuecomment-3132102778 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: remove extra chars when template status is error string [cloudstack]
blueorangutan commented on PR #11329: URL: https://github.com/apache/cloudstack/pull/11329#issuecomment-3131838574 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: remove extra chars when template status is error string [cloudstack]
codecov[bot] commented on PR #11329: URL: https://github.com/apache/cloudstack/pull/11329#issuecomment-3131869317 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11329?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 4.28%. Comparing base ([`ca6d2dc`](https://app.codecov.io/gh/apache/cloudstack/commit/ca6d2dc57ecca52d3a0847038bc9c6e8c7a0c00a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`81a12a6`](https://app.codecov.io/gh/apache/cloudstack/commit/81a12a6eca876366d09d445e6f93249ca37d2780?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on 4.19. > :exclamation: There is a different number of reports uploaded between BASE (ca6d2dc) and HEAD (81a12a6). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (ca6d2dc) | HEAD (81a12a6) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #11329 +/- ## = - Coverage 15.17%4.28% -10.90% = Files 5415 372 -5043 Lines47603029738 -446292 Branches 58115 5227-52888 = - Hits 72246 1274-70972 + Misses 39570128319 -367382 + Partials 8083 145 -7938 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/11329/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/11329/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.28% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/11329/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/11329?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: remove extra chars when template status is error string [cloudstack]
shwstppr commented on PR #11329: URL: https://github.com/apache/cloudstack/pull/11329#issuecomment-3131835779 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
