Re: [PR] [Enchancement](memory) avoid pass nullptr arena [doris]
BiteThet merged PR #52996: URL: https://github.com/apache/doris/pull/52996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enchancement](memory) avoid pass nullptr arena [doris]
github-actions[bot] commented on PR #52996: URL: https://github.com/apache/doris/pull/52996#issuecomment-3059325301 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enchancement](memory) avoid pass nullptr arena [doris]
hello-stephen commented on PR #52996: URL: https://github.com/apache/doris/pull/52996#issuecomment-3057843699 # BE UT Coverage Report Increment line coverage `41.28% (220/533)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/45a0307859013441cd2f6a702cbf76d0a627b27d_45a0307859013441cd2f6a702cbf76d0a627b27d/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/45a0307859013441cd2f6a702cbf76d0a627b27d_45a0307859013441cd2f6a702cbf76d0a627b27d/report/index.html) | Category | Coverage | |---|| | Function Coverage | 57.06% (15507/27179) | | Line Coverage | 45.89% (138398/301600) | | Region Coverage | 35.30% (103494/293188) | | Branch Coverage | 37.77% (45573/120646) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enchancement](memory) avoid pass nullptr arena [doris]
BiteThet commented on PR #52996: URL: https://github.com/apache/doris/pull/52996#issuecomment-3057329190 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enchancement](memory) avoid pass nullptr arena [doris]
xinyiZzz commented on code in PR #52996:
URL: https://github.com/apache/doris/pull/52996#discussion_r2197598264
##
be/src/olap/memtable.cpp:
##
@@ -177,7 +177,8 @@ MemTable::~MemTable() {
}
if (_is_flush_success) {
// If the memtable is flush success, then its memtracker's consumption
should be 0
-if (_mem_tracker->consumption() != 0 &&
config::crash_in_memory_tracker_inaccurate) {
+if (_mem_tracker->consumption() != _arena.size() &&
Review Comment:
上面都已经 arena.clear(true) 了，arena size应该就归0了吧
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [Enchancement](memory) avoid pass nullptr arena [doris]
hello-stephen commented on PR #52996: URL: https://github.com/apache/doris/pull/52996#issuecomment-3056711210 # BE UT Coverage Report Increment line coverage `41.50% (222/535)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/4cf32f1b365fd9ba8448f20009a95b3a71d202db_4cf32f1b365fd9ba8448f20009a95b3a71d202db/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/4cf32f1b365fd9ba8448f20009a95b3a71d202db_4cf32f1b365fd9ba8448f20009a95b3a71d202db/report/index.html) | Category | Coverage | |---|| | Function Coverage | 57.02% (15500/27182) | | Line Coverage | 45.86% (138301/301554) | | Region Coverage | 35.28% (103426/293163) | | Branch Coverage | 37.74% (45523/120633) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enchancement](memory) avoid pass nullptr arena [doris]
BiteThet commented on PR #52996: URL: https://github.com/apache/doris/pull/52996#issuecomment-3055960437 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enchancement](memory) avoid pass nullptr arena [doris]
BiteThet commented on code in PR #52996:
URL: https://github.com/apache/doris/pull/52996#discussion_r2196672093
##
be/src/olap/memtable.cpp:
##
@@ -177,7 +177,8 @@ MemTable::~MemTable() {
}
if (_is_flush_success) {
// If the memtable is flush success, then its memtracker's consumption
should be 0
-if (_mem_tracker->consumption() != 0 &&
config::crash_in_memory_tracker_inaccurate) {
+if (_mem_tracker->consumption() != _arena.size() &&
Review Comment:
_arena自己的内存在对象析构后就会释放，有一个基础size，clear了也不会是0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [Enchancement](memory) avoid pass nullptr arena [doris]
BiteThet commented on PR #52996: URL: https://github.com/apache/doris/pull/52996#issuecomment-3055723138 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enchancement](memory) avoid pass nullptr arena [doris]
yiguolei commented on code in PR #52996:
URL: https://github.com/apache/doris/pull/52996#discussion_r2196650644
##
be/src/olap/memtable.cpp:
##
@@ -177,7 +177,8 @@ MemTable::~MemTable() {
}
if (_is_flush_success) {
// If the memtable is flush success, then its memtracker's consumption
should be 0
-if (_mem_tracker->consumption() != 0 &&
config::crash_in_memory_tracker_inaccurate) {
+if (_mem_tracker->consumption() != _arena.size() &&
Review Comment:
不能这么改，他确实 如果不是0，就得挂掉，这说明内存没释放完
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [Enchancement](memory) avoid pass nullptr arena [doris]
BiteThet commented on PR #52996: URL: https://github.com/apache/doris/pull/52996#issuecomment-3055139240 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enchancement](memory) avoid pass nullptr arena [doris]
BiteThet commented on PR #52996: URL: https://github.com/apache/doris/pull/52996#issuecomment-3052633770 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enchancement](memory) avoid pass nullptr arena [doris]
BiteThet commented on PR #52996: URL: https://github.com/apache/doris/pull/52996#issuecomment-3051651684 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enchancement](memory) avoid pass nullptr arena [doris]
BiteThet commented on PR #52996: URL: https://github.com/apache/doris/pull/52996#issuecomment-3051609107 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enchancement](memory) avoid pass nullptr arena [doris]
github-actions[bot] commented on PR #52996: URL: https://github.com/apache/doris/pull/52996#issuecomment-3051499324 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enchancement](memory) avoid pass nullptr arena [doris]
github-actions[bot] commented on PR #52996: URL: https://github.com/apache/doris/pull/52996#issuecomment-3051499214 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enchancement](memory) avoid pass nullptr arena [doris]
Thearas commented on PR #52996: URL: https://github.com/apache/doris/pull/52996#issuecomment-3051385454 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[PR] [Enchancement](memory) avoid pass nullptr arena [doris]
BiteThet opened a new pull request, #52996: URL: https://github.com/apache/doris/pull/52996 ### What problem does this PR solve? avoid pass nullptr arena ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [ ] No. - [ ] Yes. - Does this need documentation? - [ ] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
