Re: [PR] [Fix](s3tables)Adapt NEED_OVERRIDE_ENDPOINT for Iceberg S3Tables catalog type [doris]
morningman closed pull request #54374: [Fix](s3tables)Adapt NEED_OVERRIDE_ENDPOINT for Iceberg S3Tables catalog type URL: https://github.com/apache/doris/pull/54374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](s3tables)Adapt NEED_OVERRIDE_ENDPOINT for Iceberg S3Tables catalog type [doris]
doris-robot commented on PR #54374: URL: https://github.com/apache/doris/pull/54374#issuecomment-3157388722 ClickBench: Total hot run time: 33.42 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 42564fca2918c4d2b1964f1d18dabfeaba961c32, data reload: false query1 0.040.040.04 query2 0.080.040.04 query3 0.250.070.07 query4 1.660.100.10 query5 0.410.410.39 query6 1.140.660.65 query7 0.020.020.02 query8 0.050.040.04 query9 0.550.480.47 query10 0.540.530.53 query11 0.150.100.10 query12 0.140.100.11 query13 0.640.640.64 query14 0.891.071.06 query15 0.970.890.91 query16 0.400.390.40 query17 1.021.061.07 query18 0.220.200.20 query19 1.951.831.78 query20 0.010.010.01 query21 15.40 0.830.58 query22 0.771.150.81 query23 14.87 1.190.59 query24 6.672.100.91 query25 0.520.310.10 query26 0.580.150.13 query27 0.050.060.05 query28 10.08 0.830.46 query29 12.61 3.873.32 query30 3.103.042.97 query31 2.820.560.40 query32 3.240.590.50 query33 2.993.253.19 query34 16.17 5.294.94 query35 4.895.035.06 query36 0.710.510.50 query37 0.100.080.07 query38 0.060.050.05 query39 0.030.030.03 query40 0.180.130.13 query41 0.080.030.03 query42 0.040.030.02 query43 0.040.030.04 Total cold run time: 107.13 s Total hot run time: 33.42 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](s3tables)Adapt NEED_OVERRIDE_ENDPOINT for Iceberg S3Tables catalog type [doris]
doris-robot commented on PR #54374: URL: https://github.com/apache/doris/pull/54374#issuecomment-3157381038 TPC-DS: Total hot run time: 170357 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 42564fca2918c4d2b1964f1d18dabfeaba961c32, data reload: false query1 1003380 425 380 query2 6512181017181718 query3 6742224 219 219 query4 26836 23714 22909 22909 query5 4356625 501 501 query6 312 239 225 225 query7 4645531 296 296 query8 275 240 242 240 query9 8617293329062906 query10 479 344 299 299 query11 15893 14952 14715 14715 query12 190 135 135 135 query13 1674552 424 424 query14 8458582457365736 query15 209 192 165 165 query16 7150677 473 473 query17 1223773 643 643 query18 2154452 333 333 query19 222 211 188 188 query20 157 149 143 143 query21 226 126 119 119 query22 4162404839433943 query23 34738 34352 34585 34352 query24 7511243624642436 query25 525 516 442 442 query26 732 286 157 157 query27 2413498 352 352 query28 3083231323022302 query29 720 607 494 494 query30 288 233 189 189 query31 875 800 718 718 query32 89 73 79 73 query33 538 424 364 364 query34 830 858 525 525 query35 779 866 755 755 query36 10591048949 949 query37 130 108 97 97 query38 3917390139113901 query39 1426136513771365 query40 236 138 133 133 query41 67 59 55 55 query42 142 122 126 122 query43 514 531 482 482 query44 1424858 896 858 query45 199 191 179 179 query46 961 1083686 686 query47 1798183917851785 query48 408 425 314 314 query49 679 506 424 424 query50 669 697 430 430 query51 4157414941564149 query52 126 131 116 116 query53 254 284 208 208 query54 660 648 553 553 query55 95 90 91 90 query56 367 358 360 358 query57 1176123111561156 query58 336 333 331 331 query59 2615260525882588 query60 414 388 403 388 query61 143 123 120 120 query62 803 718 656 656 query63 247 208 208 208 query64 25631063775 775 query65 4229413441374134 query66 955 449 344 344 query67 query68 16662 895 862 862 query69 1097293 302 293 query70 1442113711141114 query71 715 319 321 319 query72 9213228221372137 query73 3279692 367 367 query74 9073895688628862 query75 7472310426722672 query76 88171240796 796 query77 1160408 357 357 query78 963310518 93999399 query79 14586 657 630 630 query80 1723553 505 505 query81 547 268 222 222 query82 435 160 120 120 query83 380 297 271 271 query84 300 93 79 79 query85 985 375 400 375 query86 366 300 319 300 query87 4141419241694169 query88 5597228222612261 query89 491 367 321 321 query90 2585238 232 232 query91 147 138 112 112 query92 84 73 66 66 query93 6293981 654 654 query94 975 413 281 281 query95 412 348 321 321 query96 503 600 288 288 query97 2728272526542654 query98 281 240 227 227 query99 1467142612681268 Total cold run time: 300974 ms Total hot run time: 170357 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo
Re: [PR] [Fix](s3tables)Adapt NEED_OVERRIDE_ENDPOINT for Iceberg S3Tables catalog type [doris]
doris-robot commented on PR #54374: URL: https://github.com/apache/doris/pull/54374#issuecomment-3157364559 TPC-H: Total hot run time: 33689 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 42564fca2918c4d2b1964f1d18dabfeaba961c32, data reload: false -- Round 1 -- q1 17589 528851775177 q2 1919296 186 186 q3 10295 1333719 719 q4 10250 1003522 522 q5 8017239622992299 q6 197 165 132 132 q7 901 761 628 628 q8 9322130211041104 q9 6777507551355075 q10 6900235119911991 q11 490 278 271 271 q12 353 367 227 227 q13 17781 348529622962 q14 264 231 213 213 q15 548 463 468 463 q16 421 421 367 367 q17 586 832 356 356 q18 7427702469746974 q19 2287979 569 569 q20 321 305 209 209 q21 3587318122572257 q22 10551018988 988 Total cold run time: 107287 ms Total hot run time: 33689 ms - Round 2, with runtime_filter_mode=off - q1 5530530953355309 q2 236 304 222 222 q3 2096254521882188 q4 1351172613101310 q5 4153446344314431 q6 224 176 136 136 q7 1983199817561756 q8 2468265425802580 q9 7381732774097327 q10 3313334029492949 q11 549 505 489 489 q12 809 777 658 658 q13 3410364832133213 q14 314 315 281 281 q15 511 439 446 439 q16 454 486 460 460 q17 1172150713641364 q18 8063815177187718 q19 12132 809 794 794 q20 1906188917441744 q21 14405 424342754243 q22 1006101410041004 Total cold run time: 73466 ms Total hot run time: 50615 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](s3tables)Adapt NEED_OVERRIDE_ENDPOINT for Iceberg S3Tables catalog type [doris]
Thearas commented on PR #54374: URL: https://github.com/apache/doris/pull/54374#issuecomment-3157300338 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](s3tables)Adapt NEED_OVERRIDE_ENDPOINT for Iceberg S3Tables catalog type [doris]
CalvinKirs commented on PR #54374: URL: https://github.com/apache/doris/pull/54374#issuecomment-3157300661 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[PR] [Fix](s3tables)Adapt NEED_OVERRIDE_ENDPOINT for Iceberg S3Tables catalog type [doris]
CalvinKirs opened a new pull request, #54374: URL: https://github.com/apache/doris/pull/54374 #50238 ### What problem does this PR solve? … This PR introduces a special case handling for the Iceberg S3Tables catalog type: In the S3Tables scenario, the endpoint must not be overridden. Therefore, the NEED_OVERRIDE_ENDPOINT backend property is explicitly set to "false" when iceberg.catalog.type = s3_tables. For all other catalog types, the default behavior is to set it to "true". Problem Summary: ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [ ] No. - [ ] Yes. - Does this need documentation? - [ ] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
