Re: [PR] [Fix][Function] Support 0 or negative max_limit for split_by_regexp function [doris]
github-actions[bot] commented on PR #64086: URL: https://github.com/apache/doris/pull/64086#issuecomment-4645057592 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix][Function] Support 0 or negative max_limit for split_by_regexp function [doris]
github-actions[bot] commented on PR #64086: URL: https://github.com/apache/doris/pull/64086#issuecomment-4645057460 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix][Function] Support 0 or negative max_limit for split_by_regexp function [doris]
hello-stephen commented on PR #64086: URL: https://github.com/apache/doris/pull/64086#issuecomment-4612704231 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[PR] [Fix][Function] Support 0 or negative max_limit for split_by_regexp function [doris]
XnY-wei opened a new pull request, #64086: URL: https://github.com/apache/doris/pull/64086 …it is applied ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: According to the official Apache Doris documentation, for the split_by_regexp function: "If max_limit is 0 or negative, no limit is applied." However, the previous FE analyzer implementation strictly required the third parameter (max_limit) to be a positive constant. Passing 0 or a negative value threw an error: the third parameter of split_by_regexp function must be a positive constant.This PR relaxed the validation logic in the FE analyzer to allow 0 and negative constants for the max_limit parameter, aligning the implementation with the official documentation and expected behavior. ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [ ] No. - [ ] Yes. - Does this need documentation? - [ ] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
