Re: [PR] [chore](BE) make MutableBlock's to_block only accept rvalue [doris]
github-actions[bot] closed pull request #47176: [chore](BE) make MutableBlock's to_block only accept rvalue URL: https://github.com/apache/doris/pull/47176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [chore](BE) make MutableBlock's to_block only accept rvalue [doris]
github-actions[bot] commented on PR #47176: URL: https://github.com/apache/doris/pull/47176#issuecomment-3094903229 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [chore](BE) make MutableBlock's to_block only accept rvalue [doris]
BiteThet commented on code in PR #47176:
URL: https://github.com/apache/doris/pull/47176#discussion_r1923067357
##
be/src/vec/sink/vdata_stream_sender.cpp:
##
@@ -175,7 +175,7 @@ Status Channel::_send_current_block(bool eos) {
Status Channel::_send_local_block(bool eos) {
Block block;
if (_serializer.get_block() != nullptr) {
-block = _serializer.get_block()->to_block();
+block = std::move(*_serializer.get_block()).to_block();
_serializer.get_block()->set_mutable_columns(block.clone_empty_columns());
Review Comment:
use mutable block after moved seems a bit tricky. better use a new object
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [chore](BE) make MutableBlock's to_block only accept rvalue [doris]
doris-robot commented on PR #47176: URL: https://github.com/apache/doris/pull/47176#issuecomment-2598269187 TeamCity be ut coverage result: Function Coverage: 41.52% (10821/26061) Line Coverage: 31.92% (91432/286482) Region Coverage: 31.07% (46853/150794) Branch Coverage: 27.16% (23730/87358) Coverage Report: http://coverage.selectdb-in.cc/coverage/6f7f0c1ef5816901db1ff359f9c38709beafb8f7_6f7f0c1ef5816901db1ff359f9c38709beafb8f7/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [chore](BE) make MutableBlock's to_block only accept rvalue [doris]
doris-robot commented on PR #47176: URL: https://github.com/apache/doris/pull/47176#issuecomment-2598246967 ClickBench: Total hot run time: 31.3 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 6f7f0c1ef5816901db1ff359f9c38709beafb8f7, data reload: false query1 0.040.030.03 query2 0.070.040.04 query3 0.240.070.06 query4 1.640.100.10 query5 0.420.440.42 query6 1.170.660.65 query7 0.020.020.02 query8 0.040.040.03 query9 0.600.520.50 query10 0.560.570.56 query11 0.140.100.11 query12 0.140.100.11 query13 0.610.610.60 query14 2.832.822.74 query15 0.890.840.84 query16 0.380.400.38 query17 1.001.041.01 query18 0.230.210.21 query19 1.871.831.98 query20 0.010.010.01 query21 15.36 0.890.59 query22 0.760.760.73 query23 15.25 1.430.56 query24 3.331.821.54 query25 0.200.100.21 query26 0.250.140.14 query27 0.040.050.06 query28 13.83 0.990.45 query29 12.58 3.923.27 query30 0.250.080.06 query31 2.850.620.40 query32 3.220.550.47 query33 3.122.993.00 query34 16.82 5.124.49 query35 4.524.454.57 query36 0.650.500.48 query37 0.090.060.05 query38 0.050.040.04 query39 0.030.020.02 query40 0.160.140.13 query41 0.080.030.02 query42 0.030.020.02 query43 0.040.030.02 Total cold run time: 106.41 s Total hot run time: 31.3 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [chore](BE) make MutableBlock's to_block only accept rvalue [doris]
doris-robot commented on PR #47176: URL: https://github.com/apache/doris/pull/47176#issuecomment-2598237640 TPC-DS: Total hot run time: 187224 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 6f7f0c1ef5816901db1ff359f9c38709beafb8f7, data reload: false query1 978 391 389 389 query2 6519205119981998 query3 6789220 215 215 query4 33475 23100 23006 23006 query5 4299594 438 438 query6 270 204 180 180 query7 4609474 316 316 query8 276 234 223 223 query9 9575256425692564 query10 471 311 250 250 query11 18071 15165 14935 14935 query12 155 105 106 105 query13 1656525 411 411 query14 10230 690869816908 query15 229 197 193 193 query16 8007589 492 492 query17 1620750 572 572 query18 2068406 309 309 query19 227 202 165 165 query20 163 107 110 107 query21 207 121 99 99 query22 4289449541694169 query23 34114 32816 33214 32816 query24 6448223222912232 query25 499 448 375 375 query26 1196273 152 152 query27 1988455 320 320 query28 5416240523842384 query29 710 564 430 430 query30 232 185 156 156 query31 962 855 804 804 query32 85 62 56 56 query33 524 359 274 274 query34 746 838 494 494 query35 789 843 737 737 query36 992 1018938 938 query37 118 99 75 75 query38 4193416041384138 query39 1425140614151406 query40 209 118 110 110 query41 52 52 53 52 query42 125 102 104 102 query43 503 523 485 485 query44 1248788 799 788 query45 174 170 165 165 query46 850 1056631 631 query47 1829181418041804 query48 388 386 313 313 query49 780 481 400 400 query50 654 652 393 393 query51 6796703368906890 query52 98 100 94 94 query53 226 254 185 185 query54 486 494 413 413 query55 81 79 81 79 query56 251 265 238 238 query57 1161112811061106 query58 250 233 242 233 query59 3050316728302830 query60 278 273 249 249 query61 116 113 120 113 query62 800 687 662 662 query63 222 192 182 182 query64 44461020656 656 query65 3255312531923125 query66 1056452 313 313 query67 15924 15675 15438 15438 query68 4572825 525 525 query69 470 293 257 257 query70 1185114611091109 query71 373 289 296 289 query72 5923384037823782 query73 645 754 363 363 query74 10150 910989218921 query75 3166319026612661 query76 31921187761 761 query77 468 353 274 274 query78 10008 988993689368 query79 3070823 588 588 query80 668 524 425 425 query81 512 273 234 234 query82 453 150 128 128 query83 169 175 159 159 query84 247 93 72 72 query85 778 412 313 313 query86 397 307 306 306 query87 4387449244694469 query88 4902214021142114 query89 380 323 293 293 query90 1852191 190 190 query91 134 134 108 108 query92 73 58 57 57 query93 2379892 525 525 query94 706 409 306 306 query95 334 320 262 262 query96 484 615 283 283 query97 2740289327622762 query98 230 212 194 194 query99 1270136612461246 Total cold run time: 286245 ms Total hot run time: 187224 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [chore](BE) make MutableBlock's to_block only accept rvalue [doris]
doris-robot commented on PR #47176: URL: https://github.com/apache/doris/pull/47176#issuecomment-2598216721 TPC-H: Total hot run time: 32434 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 6f7f0c1ef5816901db1ff359f9c38709beafb8f7, data reload: false -- Round 1 -- q1 17602 554153925392 q2 2058297 165 165 q3 10433 1282724 724 q4 10228 974 524 524 q5 7571243322162216 q6 194 168 134 134 q7 926 764 614 614 q8 9230139411471147 q9 5386498649764976 q10 6831236018961896 q11 464 278 260 260 q12 343 352 223 223 q13 17800 370730903090 q14 226 242 210 210 q15 528 477 478 477 q16 624 620 599 599 q17 566 878 318 318 q18 7483646664876466 q19 2174973 529 529 q20 310 325 183 183 q21 2841221619801980 q22 360 329 311 311 Total cold run time: 104178 ms Total hot run time: 32434 ms - Round 2, with runtime_filter_mode=off - q1 5533552754915491 q2 238 332 234 234 q3 2262267023442344 q4 1384182113421342 q5 4324477547224722 q6 181 166 130 130 q7 2052197718311831 q8 2682279927322732 q9 7323731872087208 q10 2981330428422842 q11 596 506 506 506 q12 653 760 592 592 q13 3499380832933293 q14 292 302 276 276 q15 529 482 477 477 q16 675 662 647 647 q17 1225176412651265 q18 7752742973767376 q19 790 118410921092 q20 2035204518861886 q21 5715519050185018 q22 598 569 556 556 Total cold run time: 53319 ms Total hot run time: 51860 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [chore](BE) make MutableBlock's to_block only accept rvalue [doris]
zclllyybb commented on PR #47176: URL: https://github.com/apache/doris/pull/47176#issuecomment-2597977143 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[PR] [chore](BE) make MutableBlock's to_block only accept rvalue [doris]
zclllyybb opened a new pull request, #47176: URL: https://github.com/apache/doris/pull/47176 ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: It's good for coding behaviors. use rvalue will make coder cleaner to know it's moved. ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [x] No need to test or manual test. Explain why: - [x] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [x] No. - [ ] Yes. - Does this need documentation? - [x] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [chore](BE) make MutableBlock's to_block only accept rvalue [doris]
zclllyybb commented on PR #47176: URL: https://github.com/apache/doris/pull/47176#issuecomment-2597965086 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [chore](BE) make MutableBlock's to_block only accept rvalue [doris]
hello-stephen commented on PR #47176: URL: https://github.com/apache/doris/pull/47176#issuecomment-2597962656 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
