Re: [PR] [enhance](memtable) speed up cancel memtable [doris]
sollhui commented on PR #53481: URL: https://github.com/apache/doris/pull/53481#issuecomment-3086508959 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](memtable) speed up cancel memtable [doris]
hello-stephen commented on PR #53481: URL: https://github.com/apache/doris/pull/53481#issuecomment-3084834411 # BE Regression && UT Coverage Report Increment line coverage `93.33% (14/15)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/53481_9c065f65f3b9145bfd3de8de037e3aab570cdf1f_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/53481_9c065f65f3b9145bfd3de8de037e3aab570cdf1f_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 81.13% (21854/26936) | | Line Coverage | 73.63% (225722/306555) | | Region Coverage | 61.27% (188086/306957) | | Branch Coverage | 65.02% (81130/124777) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](memtable) speed up cancel memtable [doris]
hello-stephen commented on PR #53481: URL: https://github.com/apache/doris/pull/53481#issuecomment-3084811346 # BE UT Coverage Report Increment line coverage `86.67% (13/15)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/9c065f65f3b9145bfd3de8de037e3aab570cdf1f_9c065f65f3b9145bfd3de8de037e3aab570cdf1f/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/9c065f65f3b9145bfd3de8de037e3aab570cdf1f_9c065f65f3b9145bfd3de8de037e3aab570cdf1f/report/index.html) | Category | Coverage | |---|| | Function Coverage | 57.40% (15760/27456) | | Line Coverage | 46.17% (141741/307025) | | Region Coverage | 35.64% (106651/299226) | | Branch Coverage | 38.17% (47096/123387) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](memtable) speed up cancel memtable [doris]
doris-robot commented on PR #53481: URL: https://github.com/apache/doris/pull/53481#issuecomment-3084213900 ClickBench: Total hot run time: 32.52 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 9c065f65f3b9145bfd3de8de037e3aab570cdf1f, data reload: false query1 0.040.040.04 query2 0.080.040.05 query3 0.240.070.06 query4 1.620.110.11 query5 0.450.410.42 query6 1.150.660.66 query7 0.030.020.01 query8 0.040.030.04 query9 0.600.520.52 query10 0.590.570.59 query11 0.160.110.11 query12 0.150.120.11 query13 0.630.610.60 query14 0.800.820.82 query15 0.900.850.88 query16 0.370.400.40 query17 1.021.041.08 query18 0.220.210.22 query19 1.911.851.86 query20 0.010.000.01 query21 15.42 0.890.54 query22 0.761.220.67 query23 14.87 1.390.62 query24 6.811.060.85 query25 0.500.220.09 query26 0.620.170.15 query27 0.080.060.06 query28 9.400.930.44 query29 12.60 4.003.26 query30 3.093.042.99 query31 2.820.590.39 query32 3.240.590.46 query33 3.053.133.06 query34 16.13 5.444.86 query35 4.824.824.89 query36 0.680.500.48 query37 0.090.070.07 query38 0.050.040.03 query39 0.020.020.02 query40 0.170.160.13 query41 0.080.030.03 query42 0.030.020.02 query43 0.040.040.04 Total cold run time: 106.38 s Total hot run time: 32.52 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](memtable) speed up cancel memtable [doris]
doris-robot commented on PR #53481: URL: https://github.com/apache/doris/pull/53481#issuecomment-3084195218 TPC-DS: Total hot run time: 187078 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 9c065f65f3b9145bfd3de8de037e3aab570cdf1f, data reload: false query1 1001381 402 381 query2 6509173917771739 query3 6749222 227 222 query4 26995 23793 23423 23423 query5 4339579 425 425 query6 316 216 205 205 query7 4629489 290 290 query8 271 221 210 210 query9 8606258626182586 query10 491 360 289 289 query11 15767 14950 14837 14837 query12 172 112 106 106 query13 1648526 404 404 query14 9489592658485848 query15 208 201 170 170 query16 7619627 448 448 query17 1225686 568 568 query18 2023412 294 294 query19 184 176 152 152 query20 118 113 111 111 query21 217 121 108 108 query22 4378413043014130 query23 34205 33078 32962 32962 query24 8448238423852384 query25 536 456 393 393 query26 1239261 149 149 query27 2757503 340 340 query28 4277214321402140 query29 715 541 442 442 query30 287 220 194 194 query31 947 852 778 778 query32 80 70 65 65 query33 567 364 321 321 query34 799 845 518 518 query35 794 814 734 734 query36 949 989 915 915 query37 112 121 74 74 query38 4187420041194119 query39 1474141614331416 query40 212 115 106 106 query41 57 59 52 52 query42 118 105 111 105 query43 510 521 500 500 query44 1315824 819 819 query45 177 170 165 165 query46 840 1006636 636 query47 1746183717231723 query48 370 430 307 307 query49 732 488 380 380 query50 631 683 413 413 query51 5533560954745474 query52 112 108 96 96 query53 228 253 176 176 query54 574 584 509 509 query55 84 82 82 82 query56 292 315 283 283 query57 1175122011541154 query58 262 259 278 259 query59 2594267526182618 query60 329 329 300 300 query61 126 140 123 123 query62 822 718 685 685 query63 224 194 187 187 query64 43261019662 662 query65 4338417041734170 query66 1069418 330 330 query67 16023 15720 15424 15424 query68 7860867 523 523 query69 475 310 280 280 query70 1205110511531105 query71 428 317 298 298 query72 5726470948244709 query73 654 592 360 360 query74 9230912587048704 query75 3411318726882688 query76 33461190716 716 query77 617 395 309 309 query78 983410110 94189418 query79 2243832 576 576 query80 599 509 455 455 query81 479 260 242 242 query82 466 131 102 102 query83 276 254 237 237 query84 302 116 101 101 query85 885 442 415 415 query86 469 317 300 300 query87 4556447443634363 query88 3525230122962296 query89 386 331 296 296 query90 1901216 214 214 query91 156 145 112 112 query92 75 64 59 59 query93 1851936 583 583 query94 717 410 300 300 query95 366 300 284 284 query96 493 580 282 282 query97 2702273926462646 query98 245 207 208 207 query99 1410139012701270 Total cold run time: 277034 ms Total hot run time: 187078 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [enhance](memtable) speed up cancel memtable [doris]
doris-robot commented on PR #53481: URL: https://github.com/apache/doris/pull/53481#issuecomment-3084151918 TPC-H: Total hot run time: 33775 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 9c065f65f3b9145bfd3de8de037e3aab570cdf1f, data reload: false -- Round 1 -- q1 17617 518650485048 q2 1925273 186 186 q3 10319 1272727 727 q4 10220 981 530 530 q5 7504234923222322 q6 179 163 127 127 q7 886 743 609 609 q8 9286129110491049 q9 6724512050975097 q10 6870239019461946 q11 468 279 270 270 q12 333 353 213 213 q13 17748 370530713071 q14 220 227 210 210 q15 549 473 490 473 q16 419 430 377 377 q17 563 863 350 350 q18 7570728971307130 q19 1209949 562 562 q20 350 333 216 216 q21 3604251822952295 q22 1053978 967 967 Total cold run time: 105616 ms Total hot run time: 33775 ms - Round 2, with runtime_filter_mode=off - q1 5076511850755075 q2 240 334 225 225 q3 2190268622852285 q4 1392175913681368 q5 4210426845474268 q6 212 171 127 127 q7 2119199218201820 q8 2609251424812481 q9 7355735271547154 q10 3105328428502850 q11 563 516 517 516 q12 676 778 607 607 q13 3604400234183418 q14 310 318 283 283 q15 543 477 454 454 q16 472 495 469 469 q17 1191155213911391 q18 7843774176577657 q19 778 806 912 806 q20 2018211218431843 q21 4725436842884288 q22 1056996 978 978 Total cold run time: 52287 ms Total hot run time: 50363 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](memtable) speed up cancel memtable [doris]
sollhui commented on PR #53481: URL: https://github.com/apache/doris/pull/53481#issuecomment-3084082987 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](memtable) speed up cancel memtable [doris]
hello-stephen commented on PR #53481: URL: https://github.com/apache/doris/pull/53481#issuecomment-3084081739 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[PR] [enhance](memtable) speed up cancel memtable [doris]
sollhui opened a new pull request, #53481: URL: https://github.com/apache/doris/pull/53481 ### What problem does this PR solve? https://github.com/user-attachments/assets/f27ae512-ef80-497e-a9b7-d527392775bc"; /> At present, if load is cancelled, it needs to wait for all submitted memtable task to be completed, included: - flush task wait in thread pool queue - ongoing flushing task It is not need wait flush task still in the thread pool queue which can speed up cancel load. ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [ ] No. - [ ] Yes. - Does this need documentation? - [ ] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
