Re: [PR] [fix](be) Guard datelike cast input columns [doris]
BiteThet closed pull request #63238: [fix](be) Guard datelike cast input columns URL: https://github.com/apache/doris/pull/63238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) Guard datelike cast input columns [doris]
hello-stephen commented on PR #63238: URL: https://github.com/apache/doris/pull/63238#issuecomment-4447457912 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[PR] [fix](be) Guard datelike cast input columns [doris]
BiteThet opened a new pull request, #63238: URL: https://github.com/apache/doris/pull/63238 ### What problem does this PR solve? Issue Number: None Related PR: #63166 Problem Summary: Datelike cast implementations assert the concrete input column type before dereferencing it. If runtime-filter or scan common-expression evaluation passes an unexpected or null input column, the cast path can crash instead of returning an error. ### Release note Fix BE crash when datelike cast receives an unexpected input column in scan/runtime-filter expression evaluation. ### Check List (For Author) - Test: Manual test - BE format check: build-support/check-format.sh --files be/src/exprs/function/cast/cast_to_date.h - Behavior changed: Yes, invalid datelike cast input columns now return a runtime error instead of crashing - Does this need documentation: No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
