Re: [PR] [fix](mv) Fix sync mc could not be chosen by cbo stable because stats upload from be not in time [doris]

2025-12-04 Thread via GitHub


seawinde commented on PR #58720:
URL: https://github.com/apache/doris/pull/58720#issuecomment-3611299852

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](mv) Fix sync mc could not be chosen by cbo stable because stats upload from be not in time [doris]

2025-12-04 Thread via GitHub


hello-stephen commented on PR #58720:
URL: https://github.com/apache/doris/pull/58720#issuecomment-3611299630

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting 
information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it 
now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and 
after the optimization?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



[PR] [fix](mv) Fix sync mc could not be chosen by cbo stable because stats upload from be not in time [doris]

2025-12-04 Thread via GitHub


seawinde opened a new pull request, #58720:
URL: https://github.com/apache/doris/pull/58720

   ### What problem does this PR solve?
   
   This PR introduces two key modifications to improve the reliability of the 
optimizer (CBO) and the testing pipeline concerning materialized views:
   1. Fixes unstable selection of synchronous materialized views in the 
pipeline:​ The root cause was that the statistical information of the base 
table was not reported promptly. This delay could lead the CBO to estimate 
selectedPartitionsRowCountas zero for the materialized view, causing it to be 
incorrectly bypassed during query planning. The fix involves manually injecting 
the statistical information for the synchronous materialized view​ when 
available, ensuring the CBO can make a stable and accurate assessment of its 
cost .
   
   2. Removes the fuzzyvalue setting for preMaterializedViewRewriteStrategyin 
SessionVariable:​ The test cases for the TRY_IN_RBOstrategy have already been 
extended to cover scenarios equivalent to both NOT_IN_RBOand FORCE_IN_RBO. 
Retaining the fuzzyoption can introduce unnecessary instability into the 
pipeline. For instance, a PR might pass tests when the strategy is 
TRY_IN_RBObut fail if the pipeline randomly selects NOT_IN_RBO, leading to 
inconsistent results. Removing this fuzzy setting helps eliminate such 
non-deterministic failures and enhances pipeline stability 
   
   Issue Number: close #xxx
   
   Related PR: #xxx
   
   Problem Summary:
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test 
   - [ ] Regression test
   - [ ] Unit Test
   - [ ] Manual test (add detailed scripts or steps below)
   - [ ] No need to test or manual test. Explain why:
   - [ ] This is a refactor/code format and no logic has been changed.
   - [ ] Previous test can cover this change.
   - [ ] No code files have been changed.
   - [ ] Other reason 
   
   - Behavior changed:
   - [ ] No.
   - [ ] Yes. 
   
   - Does this need documentation?
   - [ ] No.
   - [ ] Yes. 
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]