Re: [PR] [refactor](column) Refine column serialization [doris]
Gabriel39 merged PR #52994: URL: https://github.com/apache/doris/pull/52994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](column) Refine column serialization [doris]
github-actions[bot] commented on PR #52994: URL: https://github.com/apache/doris/pull/52994#issuecomment-3067582652 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](column) Refine column serialization [doris]
github-actions[bot] commented on PR #52994: URL: https://github.com/apache/doris/pull/52994#issuecomment-3067582607 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](column) Refine column serialization [doris]
HappenLee commented on code in PR #52994:
URL: https://github.com/apache/doris/pull/52994#discussion_r2203741577
##
be/src/vec/columns/column_nullable.cpp:
##
@@ -211,68 +211,61 @@ void ColumnNullable::insert_many_from(const IColumn& src,
size_t position, size_
StringRef ColumnNullable::serialize_value_into_arena(size_t n, Arena& arena,
char const*& begin) const
{
-const auto& arr = get_null_map_data();
-static constexpr auto s = sizeof(arr[0]);
-
-auto* pos = arena.alloc_continue(s, begin);
-memcpy(pos, &arr[n], s);
-
-if (arr[n]) {
-return {pos, s};
-}
-
-auto nested_ref = get_nested_column().serialize_value_into_arena(n, arena,
begin);
-
-/// serialize_value_into_arena may reallocate memory. Have to use ptr from
nested_ref.data and move it back.
-return {nested_ref.data - s, nested_ref.size + s};
+auto* pos = arena.alloc_continue(serialize_size_at(n), begin);
+return {pos, serialize_impl(pos, n)};
}
const char* ColumnNullable::deserialize_and_insert_from_arena(const char* pos)
{
+return pos + deserialize_impl(pos);
+}
+
+size_t ColumnNullable::deserialize_impl(const char* pos) {
+size_t sz = 0;
UInt8 val = *reinterpret_cast(pos);
-pos += sizeof(val);
+sz += sizeof(val);
get_null_map_data().push_back(val);
if (val == 0) {
-pos = get_nested_column().deserialize_and_insert_from_arena(pos);
+sz += get_nested_column().deserialize_impl(pos + sz);
} else {
get_nested_column().insert_default();
_has_null = true;
_need_update_has_null = false;
}
-
-return pos;
+return sz;
}
size_t ColumnNullable::get_max_row_byte_size() const {
constexpr auto flag_size = sizeof(NullMap::value_type);
return flag_size + get_nested_column().get_max_row_byte_size();
}
-void ColumnNullable::serialize_vec(StringRef* keys, size_t num_rows,
- size_t max_row_byte_size) const {
+size_t ColumnNullable::serialize_impl(char* pos, const size_t row) const {
const auto& arr = get_null_map_data();
-get_nested_column().serialize_vec_with_null_map(keys, num_rows,
arr.data());
+memcpy_fixed(pos, (char*)&arr[row]);
+if (arr[row]) {
+return sizeof(NullMap::value_type);
+}
+return sizeof(NullMap::value_type) +
+ get_nested_column().serialize_impl(pos +
sizeof(NullMap::value_type), row);
+}
+
+void ColumnNullable::serialize_vec(StringRef* keys, size_t num_rows) const {
Review Comment:
!_has_null
// process not null serialize
get_nested_column().deserialize_vec(keys, num_rows);
for loop num_rows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [refactor](column) Refine column serialization [doris]
HappenLee commented on code in PR #52994:
URL: https://github.com/apache/doris/pull/52994#discussion_r2203424821
##
be/src/vec/columns/column_variant.h:
##
@@ -474,6 +474,7 @@ class ColumnVariant final : public COWHelper {
throw doris::Exception(ErrorCode::NOT_IMPLEMENTED_ERROR,
"replace_column_data" + get_name());
}
+size_t serialize_size_at(size_t row) const override { return 0; }
Review Comment:
why variant is 0？ maybe should not be exec the method？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [refactor](column) Refine column serialization [doris]
doris-robot commented on PR #52994: URL: https://github.com/apache/doris/pull/52994#issuecomment-3056937175 # BE UT Coverage Report Increment line coverage `80.87% (186/230)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/62447ee4e84664c1796a7431772ce6213ddbb9c6_62447ee4e84664c1796a7431772ce6213ddbb9c6/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/62447ee4e84664c1796a7431772ce6213ddbb9c6_62447ee4e84664c1796a7431772ce6213ddbb9c6/report/index.html) | Category | Coverage | |---|| | Function Coverage | 57.04% (15519/27206) | | Line Coverage | 45.88% (138304/301421) | | Region Coverage | 35.31% (103461/293019) | | Branch Coverage | 37.73% (45492/120569) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](column) Refine column serialization [doris]
doris-robot commented on PR #52994: URL: https://github.com/apache/doris/pull/52994#issuecomment-3056658331 ClickBench: Total hot run time: 29.38 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 62447ee4e84664c1796a7431772ce6213ddbb9c6, data reload: false query1 0.040.040.04 query2 0.080.050.05 query3 0.250.070.07 query4 1.620.110.11 query5 0.420.440.42 query6 1.170.660.67 query7 0.020.010.02 query8 0.040.030.04 query9 0.610.520.52 query10 0.580.570.57 query11 0.150.120.11 query12 0.140.110.12 query13 0.630.610.62 query14 0.800.810.80 query15 0.900.890.86 query16 0.370.380.39 query17 1.081.061.09 query18 0.230.210.22 query19 1.911.861.85 query20 0.020.010.02 query21 15.42 0.910.55 query22 0.751.300.64 query23 14.91 1.380.64 query24 6.811.440.61 query25 0.520.160.08 query26 0.620.160.14 query27 0.060.060.05 query28 9.430.940.44 query29 12.60 4.003.30 query30 0.250.090.06 query31 2.860.580.38 query32 3.240.560.46 query33 3.153.063.10 query34 16.30 5.474.80 query35 4.844.894.88 query36 0.690.520.48 query37 0.090.070.06 query38 0.050.040.03 query39 0.030.030.02 query40 0.170.140.14 query41 0.080.030.02 query42 0.030.030.03 query43 0.040.030.03 Total cold run time: 104 s Total hot run time: 29.38 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](column) Refine column serialization [doris]
doris-robot commented on PR #52994: URL: https://github.com/apache/doris/pull/52994#issuecomment-3056627609 TPC-DS: Total hot run time: 186379 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 62447ee4e84664c1796a7431772ce6213ddbb9c6, data reload: false query1 994 381 381 381 query2 6556179217561756 query3 6732208 220 208 query4 26149 24061 23314 23314 query5 4889587 421 421 query6 304 208 201 201 query7 4629506 289 289 query8 278 220 221 220 query9 8650265626732656 query10 493 328 268 268 query11 15244 15057 14778 14778 query12 152 109 101 101 query13 1651531 400 400 query14 8623587658725872 query15 209 201 173 173 query16 441 261 261 query17 1280740 620 620 query18 2015402 305 305 query19 192 192 188 188 query20 122 120 108 108 query21 211 120 108 108 query22 4270425140984098 query23 34110 33220 33217 33217 query24 8397234423462344 query25 533 452 408 408 query26 912 267 142 142 query27 2758503 338 338 query28 4315215221312131 query29 648 590 420 420 query30 285 218 194 194 query31 917 849 755 755 query32 65 62 63 62 query33 559 329 296 296 query34 777 854 520 520 query35 585 632 543 543 query36 969 1020911 911 query37 114 99 78 78 query38 4136411540924092 query39 1479145014111411 query40 204 116 102 102 query41 78 52 50 50 query42 122 114 110 110 query43 505 498 499 498 query44 1293834 834 834 query45 170 175 164 164 query46 829 1005632 632 query47 1773178317791779 query48 386 420 295 295 query49 700 464 381 381 query50 613 693 408 408 query51 4111428043314280 query52 109 108 100 100 query53 237 249 183 183 query54 576 590 508 508 query55 79 77 80 77 query56 280 315 295 295 query57 1176120011491149 query58 279 243 255 243 query59 2633272124832483 query60 325 307 304 304 query61 121 123 122 122 query62 771 733 654 654 query63 218 182 186 182 query64 35641204808 808 query65 4224416641774166 query66 859 416 339 339 query67 16089 15675 15604 15604 query68 7860871 542 542 query69 512 310 272 272 query70 1203113210901090 query71 407 320 310 310 query72 5474469148784691 query73 674 635 350 350 query74 9309912486848684 query75 3558318526832683 query76 33781138706 706 query77 765 371 310 310 query78 10974 11045 10319 10319 query79 2030827 584 584 query80 581 503 435 435 query81 474 249 229 229 query82 461 124 99 99 query83 254 247 224 224 query84 247 99 89 89 query85 809 349 304 304 query86 345 309 303 303 query87 4441439544134395 query88 3782232023172317 query89 384 316 293 293 query90 1956211 205 205 query91 137 143 110 110 query92 79 59 54 54 query93 1550951 598 598 query94 692 313 197 197 query95 390 307 292 292 query96 502 563 287 287 query97 2689274126182618 query98 278 214 203 203 query99 1353140912481248 Total cold run time: 272851 ms Total hot run time: 186379 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [refactor](column) Refine column serialization [doris]
doris-robot commented on PR #52994: URL: https://github.com/apache/doris/pull/52994#issuecomment-3056568134 TPC-H: Total hot run time: 33506 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 62447ee4e84664c1796a7431772ce6213ddbb9c6, data reload: false -- Round 1 -- q1 17566 524550575057 q2 1931274 191 191 q3 10306 1285725 725 q4 10226 1022530 530 q5 7612249923742374 q6 177 158 128 128 q7 895 749 594 594 q8 9313128711401140 q9 6961513151395131 q10 6883236719741974 q11 474 291 276 276 q12 336 348 219 219 q13 17750 376930983098 q14 241 221 212 212 q15 553 491 483 483 q16 422 420 367 367 q17 576 875 372 372 q18 7512717672247176 q19 1853945 554 554 q20 348 353 216 216 q21 4010315523872387 q22 369 316 302 302 Total cold run time: 106314 ms Total hot run time: 33506 ms - Round 2, with runtime_filter_mode=off - q1 5196511251235112 q2 252 317 218 218 q3 269923092309 q4 1321180213661366 q5 4251439645214396 q6 211 169 130 130 q7 1994194218231823 q8 2678269425832583 q9 7377736572927292 q10 3113337728302830 q11 579 527 507 507 q12 694 775 603 603 q13 3657399536343634 q14 291 294 265 265 q15 518 463 472 463 q16 440 493 451 451 q17 1161158714201420 q18 7914776384717763 q19 792 835 844 835 q20 1948196018441844 q21 4830438542634263 q22 639 598 536 536 Total cold run time: 52078 ms Total hot run time: 50643 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](column) Refine column serialization [doris]
Gabriel39 commented on PR #52994: URL: https://github.com/apache/doris/pull/52994#issuecomment-3056206654 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](column) Refine column serialization [doris]
doris-robot commented on PR #52994: URL: https://github.com/apache/doris/pull/52994#issuecomment-3055771709 ClickBench: Total hot run time: 29.49 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 024567bc8a4905ae35c34da3b1e76c195caf6983, data reload: false query1 0.050.030.04 query2 0.080.040.04 query3 0.250.080.07 query4 1.620.100.10 query5 0.440.410.42 query6 1.160.670.65 query7 0.020.020.02 query8 0.040.040.04 query9 0.590.510.52 query10 0.550.560.56 query11 0.160.110.11 query12 0.150.120.12 query13 0.620.610.61 query14 0.800.810.83 query15 0.910.860.87 query16 0.390.380.38 query17 1.031.091.04 query18 0.220.210.22 query19 2.001.821.80 query20 0.010.020.01 query21 15.42 0.900.54 query22 0.761.240.66 query23 14.92 1.380.64 query24 6.592.330.77 query25 0.470.220.20 query26 0.630.170.14 query27 0.070.060.06 query28 9.700.880.44 query29 12.54 4.003.26 query30 0.240.090.06 query31 2.840.620.38 query32 3.240.550.47 query33 3.023.083.09 query34 16.09 5.424.73 query35 4.874.874.90 query36 0.700.490.49 query37 0.090.060.07 query38 0.050.040.04 query39 0.030.030.03 query40 0.180.140.13 query41 0.080.030.02 query42 0.030.030.02 query43 0.030.030.02 Total cold run time: 103.68 s Total hot run time: 29.49 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](column) Refine column serialization [doris]
doris-robot commented on PR #52994: URL: https://github.com/apache/doris/pull/52994#issuecomment-3055751749 TPC-DS: Total hot run time: 186957 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 024567bc8a4905ae35c34da3b1e76c195caf6983, data reload: false query1 989 391 403 391 query2 6509164916401640 query3 6750209 214 209 query4 26186 23567 23446 23446 query5 4362581 431 431 query6 315 219 205 205 query7 4622504 284 284 query8 259 220 215 215 query9 8613264926452645 query10 471 308 263 263 query11 15811 14974 14980 14974 query12 157 114 107 107 query13 1654529 406 406 query14 8481583559005835 query15 222 196 165 165 query16 7588437 260 260 query17 1323722 586 586 query18 2003425 316 316 query19 193 208 171 171 query20 125 130 114 114 query21 210 125 108 108 query22 4158429447074294 query23 35055 34208 33343 33343 query24 8419235423872354 query25 534 451 393 393 query26 1221259 141 141 query27 2769512 338 338 query28 4303214021402140 query29 731 549 421 421 query30 280 218 187 187 query31 934 867 755 755 query32 69 58 58 58 query33 542 324 299 299 query34 787 823 502 502 query35 589 649 557 557 query36 965 1003908 908 query37 107 92 72 72 query38 4227408340144014 query39 1479145014941450 query40 210 113 101 101 query41 54 51 48 48 query42 123 105 104 104 query43 498 506 485 485 query44 1299864 829 829 query45 170 166 161 161 query46 826 991 626 626 query47 1760179117961791 query48 399 402 300 300 query49 737 488 384 384 query50 627 682 398 398 query51 4183419642314196 query52 108 103 89 89 query53 216 256 177 177 query54 602 566 490 490 query55 85 84 85 84 query56 309 310 284 284 query57 1189119811141114 query58 259 247 276 247 query59 2569278926022602 query60 337 318 304 304 query61 127 129 128 128 query62 764 703 645 645 query63 219 182 182 182 query64 43811206877 877 query65 4286416741604160 query66 1117398 315 315 query67 16060 15878 15486 15486 query68 9240903 529 529 query69 502 319 266 266 query70 1208114611281128 query71 462 308 298 298 query72 5615485849694858 query73 733 754 355 355 query74 9139909289958995 query75 4240316927372737 query76 37091141713 713 query77 966 390 298 298 query78 10935 10960 10155 10155 query79 2176879 572 572 query80 632 516 451 451 query81 462 266 219 219 query82 428 131 91 91 query83 310 255 234 234 query84 293 109 86 86 query85 803 360 314 314 query86 333 311 298 298 query87 4437441742674267 query88 3377230723002300 query89 396 320 280 280 query90 1923209 212 209 query91 140 137 155 137 query92 72 62 57 57 query93 1244945 591 591 query94 673 314 195 195 query95 371 296 287 287 query96 499 573 281 281 query97 2712275426732673 query98 227 204 215 204 query99 1453142812751275 Total cold run time: 277236 ms Total hot run time: 186957 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [refactor](column) Refine column serialization [doris]
doris-robot commented on PR #52994: URL: https://github.com/apache/doris/pull/52994#issuecomment-3055718793 TPC-H: Total hot run time: 34416 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 024567bc8a4905ae35c34da3b1e76c195caf6983, data reload: false -- Round 1 -- q1 17570 543952905290 q2 1930307 200 200 q3 10291 1383740 740 q4 10225 1101551 551 q5 7936264827332648 q6 226 171 132 132 q7 1006812 630 630 q8 9344145911981198 q9 7091519251975192 q10 7044246519921992 q11 491 286 274 274 q12 350 380 217 217 q13 17793 385331563156 q14 235 240 219 219 q15 575 491 500 491 q16 433 437 374 374 q17 612 935 364 364 q18 7797732571827182 q19 12711071584 584 q20 341 359 222 222 q21 4333327924572457 q22 376 332 303 303 Total cold run time: 107270 ms Total hot run time: 34416 ms - Round 2, with runtime_filter_mode=off - q1 5479548454525452 q2 258 341 227 227 q3 2263283823362336 q4 1445185913641364 q5 4775466446534653 q6 254 178 124 124 q7 2187203318741874 q8 2946300628372837 q9 7197714971117111 q10 3336344930043004 q11 638 524 516 516 q12 702 811 652 652 q13 3834432734063406 q14 299 311 305 305 q15 563 492 503 492 q16 505 542 480 480 q17 1238180815081508 q18 8239778775987598 q19 889 911 1020911 q20 2282210419681968 q21 5441476548984765 q22 703 608 561 561 Total cold run time: 55473 ms Total hot run time: 52144 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](column) Refine column serialization [doris]
Gabriel39 commented on PR #52994: URL: https://github.com/apache/doris/pull/52994#issuecomment-3055655947 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](column) Refine column serialization [doris]
doris-robot commented on PR #52994: URL: https://github.com/apache/doris/pull/52994#issuecomment-3055225690 ClickBench: Total hot run time: 30.09 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit e37941fa41e5b055928943337da5f3c13c6e9bd3, data reload: false query1 0.050.040.04 query2 0.080.040.04 query3 0.250.080.07 query4 1.620.110.11 query5 0.440.430.43 query6 1.170.670.65 query7 0.020.020.01 query8 0.040.030.03 query9 0.610.530.51 query10 0.570.590.57 query11 0.160.110.11 query12 0.160.120.12 query13 0.620.600.60 query14 0.780.820.82 query15 0.890.880.86 query16 0.390.400.40 query17 1.061.051.06 query18 0.240.210.21 query19 1.911.831.82 query20 0.020.010.02 query21 15.38 0.900.55 query22 0.761.160.66 query23 14.98 1.400.66 query24 7.171.651.30 query25 0.500.230.16 query26 0.660.160.14 query27 0.060.060.06 query28 9.570.920.44 query29 12.59 3.983.27 query30 0.260.090.07 query31 2.820.600.39 query32 3.240.550.47 query33 3.043.063.15 query34 16.21 5.454.76 query35 4.844.834.88 query36 0.680.500.49 query37 0.090.070.07 query38 0.050.040.05 query39 0.030.020.02 query40 0.170.130.12 query41 0.090.020.03 query42 0.040.020.02 query43 0.030.030.03 Total cold run time: 104.34 s Total hot run time: 30.09 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](column) Refine column serialization [doris]
doris-robot commented on PR #52994: URL: https://github.com/apache/doris/pull/52994#issuecomment-3055211141 TPC-DS: Total hot run time: 186203 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit e37941fa41e5b055928943337da5f3c13c6e9bd3, data reload: false query1 981 392 402 392 query2 6523164316581643 query3 6734211 215 211 query4 26117 23362 23321 23321 query5 4366582 433 433 query6 319 211 207 207 query7 4631495 290 290 query8 258 232 211 211 query9 8625266526822665 query10 490 342 279 279 query11 15366 15168 14778 14778 query12 157 106 112 106 query13 1654518 408 408 query14 8985591259975912 query15 207 200 170 170 query16 7727432 261 261 query17 1325740 594 594 query18 2027412 314 314 query19 199 202 158 158 query20 115 119 117 117 query21 218 124 106 106 query22 4355433841634163 query23 34066 33241 33148 33148 query24 8390236624082366 query25 520 483 393 393 query26 929 270 145 145 query27 2740504 341 341 query28 4308214921372137 query29 653 581 437 437 query30 290 226 194 194 query31 920 861 773 773 query32 70 65 59 59 query33 540 337 281 281 query34 790 841 528 528 query35 587 636 569 569 query36 984 1004878 878 query37 113 99 74 74 query38 4277414940404040 query39 1699143313851385 query40 208 115 109 109 query41 54 56 51 51 query42 128 108 108 108 query43 524 494 456 456 query44 1312822 821 821 query45 175 168 162 162 query46 839 1006624 624 query47 1791179217511751 query48 375 413 306 306 query49 703 463 373 373 query50 631 693 416 416 query51 4149423441944194 query52 106 105 93 93 query53 227 253 181 181 query54 572 570 492 492 query55 83 83 84 83 query56 305 295 279 279 query57 1184119811351135 query58 261 254 255 254 query59 2578267225542554 query60 322 322 292 292 query61 126 121 117 117 query62 793 733 630 630 query63 216 185 197 185 query64 35591206952 952 query65 4276422441984198 query66 881 398 316 316 query67 16170 15622 15628 15622 query68 8365881 540 540 query69 514 304 266 266 query70 1283112810811081 query71 454 315 313 313 query72 5210467846274627 query73 697 567 356 356 query74 8867910090329032 query75 3848320526872687 query76 35921147720 720 query77 795 378 285 285 query78 10895 11062 10154 10154 query79 2104785 576 576 query80 579 517 442 442 query81 484 328 218 218 query82 479 128 102 102 query83 269 253 234 234 query84 240 109 83 83 query85 782 353 318 318 query86 380 308 271 271 query87 4368445942814281 query88 3635230122962296 query89 389 307 294 294 query90 1905283 204 204 query91 139 141 109 109 query92 71 61 54 54 query93 1602959 593 593 query94 694 308 196 196 query95 374 286 278 278 query96 494 564 279 279 query97 2727282026322632 query98 228 210 209 209 query99 1386139612321232 Total cold run time: 273652 ms Total hot run time: 186203 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [refactor](column) Refine column serialization [doris]
doris-robot commented on PR #52994: URL: https://github.com/apache/doris/pull/52994#issuecomment-3055188120 TPC-H: Total hot run time: 33592 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit e37941fa41e5b055928943337da5f3c13c6e9bd3, data reload: false -- Round 1 -- q1 17573 525350605060 q2 1932281 190 190 q3 10422 1282702 702 q4 10249 1004539 539 q5 7874242723802380 q6 178 157 125 125 q7 908 741 601 601 q8 9304125411381138 q9 7460514952785149 q10 6892240319761976 q11 496 295 278 278 q12 336 345 212 212 q13 17746 371031223122 q14 238 223 210 210 q15 552 479 479 479 q16 425 425 391 391 q17 610 910 372 372 q18 7475725772677257 q19 1658955 569 569 q20 327 346 220 220 q21 3747254223222322 q22 361 326 300 300 Total cold run time: 106763 ms Total hot run time: 33592 ms - Round 2, with runtime_filter_mode=off - q1 5200511550915091 q2 241 321 223 223 q3 2171273423042304 q4 1337180013651365 q5 4266444145284441 q6 216 172 127 127 q7 2011199818081808 q8 2709258526362585 q9 7357725673627256 q10 3110324530793079 q11 610 528 483 483 q12 680 753 626 626 q13 3488395633953395 q14 305 305 269 269 q15 524 474 482 474 q16 471 491 466 466 q17 1244161213711371 q18 8064780375847584 q19 791 787 855 787 q20 1942197318361836 q21 4796442442004200 q22 629 590 531 531 Total cold run time: 52162 ms Total hot run time: 50301 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](column) Refine column serialization [doris]
Gabriel39 commented on PR #52994: URL: https://github.com/apache/doris/pull/52994#issuecomment-3054995523 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](column) Refine column serialization [doris]
Gabriel39 commented on PR #52994: URL: https://github.com/apache/doris/pull/52994#issuecomment-3054849020 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](column) Refine column serialization [doris]
doris-robot commented on PR #52994: URL: https://github.com/apache/doris/pull/52994#issuecomment-3052910131 TPC-H: Total hot run time: 33553 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit e8ecc9193a926a86ff478e056061d61591401fd0, data reload: false -- Round 1 -- q1 17541 517750905090 q2 1947277 198 198 q3 10427 1276744 744 q4 10241 982 538 538 q5 7796239424122394 q6 183 158 132 132 q7 903 770 615 615 q8 93221296 q9 7432511851305118 q10 6892239919731973 q11 473 290 292 290 q12 344 345 212 212 q13 17780 367530573057 q14 229 232 219 219 q15 540 472 494 472 q16 429 418 370 370 q17 610 902 384 384 q18 7552714771457145 q19 1215951 587 587 q20 348 357 227 227 q21 3821259523802380 q22 363 320 297 297 Total cold run time: 106388 ms Total hot run time: 33553 ms - Round 2, with runtime_filter_mode=off - q1 5101506951635069 q2 251 336 220 220 q3 2210272422852285 q4 1469179713441344 q5 4312442144484421 q6 209 167 132 132 q7 2016202017961796 q8 2673269026022602 q9 7248738271527152 q10 3159329228342834 q11 600 518 531 518 q12 695 778 625 625 q13 3625399334153415 q14 281 300 260 260 q15 521 473 487 473 q16 463 508 450 450 q17 1427157414181418 q18 7951786475217521 q19 815 793 973 793 q20 2025205619871987 q21 4975434543154315 q22 640 631 573 573 Total cold run time: 52666 ms Total hot run time: 50203 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](column) Refine column serialization [doris]
Gabriel39 commented on PR #52994: URL: https://github.com/apache/doris/pull/52994#issuecomment-3052647842 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](column) Refine column serialization [doris]
Gabriel39 commented on PR #52994: URL: https://github.com/apache/doris/pull/52994#issuecomment-3052181439 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](column) Refine column serialization [doris]
doris-robot commented on PR #52994: URL: https://github.com/apache/doris/pull/52994#issuecomment-3051623607 TPC-H: Total hot run time: 9 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 5c7bb42d2e32aa0f298c16fff96d69caf6e6c682, data reload: false -- Round 1 -- q1 17561 514650455045 q2 1933289 204 204 q3 10298 1295731 731 q4 10247 1052532 532 q5 7593245923362336 q6 183 165 133 133 q7 934 742 615 615 q8 9324133511121112 q9 6950514350435043 q10 6898236819951995 q11 478 301 273 273 q12 338 362 226 226 q13 17763 373231033103 q14 222 220 220 220 q15 543 473 480 473 q16 436 430 380 380 q17 605 894 368 368 q18 7952713171907131 q19 1301971 561 561 q20 335 352 228 228 q21 3873313523302330 q22 368 324 300 300 Total cold run time: 106135 ms Total hot run time: 9 ms - Round 2, with runtime_filter_mode=off - q1 5140511751245117 q2 248 331 219 219 q3 2206271823122312 q4 1392180913791379 q5 4278443646194436 q6 218 171 126 126 q7 2098203118581858 q8 2678261226272612 q9 7301720973507209 q10 3135354528542854 q11 580 515 493 493 q12 683 744 660 660 q13 3759412235203520 q14 277 300 266 266 q15 515 493 468 468 q16 457 500 432 432 q17 1139156214791479 q18 7814767177527671 q19 778 846 936 846 q20 2000208618971897 q21 5078460445174517 q22 641 613 536 536 Total cold run time: 52415 ms Total hot run time: 50907 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](column) Refine column serialization [doris]
Gabriel39 commented on PR #52994: URL: https://github.com/apache/doris/pull/52994#issuecomment-3051357534 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](column) Refine column serialization [doris]
Thearas commented on PR #52994: URL: https://github.com/apache/doris/pull/52994#issuecomment-3051319908 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[PR] [refactor](column) Refine column serialization [doris]
Gabriel39 opened a new pull request, #52994: URL: https://github.com/apache/doris/pull/52994 ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [ ] No. - [ ] Yes. - Does this need documentation? - [ ] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
