Re: [PR] [refactor](storage) drop StorageField wrapper and others dead code [doris]
hello-stephen commented on PR #63233: URL: https://github.com/apache/doris/pull/63233#issuecomment-4449080889 TPC-DS: Total hot run time: 171293 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit dba29514cf661aeb26b3d7da818211a793307cac, data reload: false query5 4317667 508 508 query6 330 223 204 204 query7 4368597 303 303 query8 329 226 221 221 query9 8823404140324032 query10 461 342 305 305 query11 5794238222262226 query12 186 130 127 127 query13 1344621 443 443 query14 6692536150725072 query14_1438343344334 query15 219 205 190 190 query16 1020431 450 431 query17 1307761 644 644 query18 2709491 346 346 query19 248 198 153 153 query20 136 129 122 122 query21 214 135 118 118 query22 13533 14101 14519 14101 query23 17328 16550 16229 16229 query23_116305 16279 16229 16229 query24 7414174613301330 query24_11336134813661348 query25 540 477 424 424 query26 1278301 168 168 query27 2674588 339 339 query28 4388194619191919 query29 987 669 530 530 query30 307 233 197 197 query31 11181065942 942 query32 86 74 74 74 query33 550 361 316 316 query34 11591135635 635 query35 769 797 673 673 query36 1360130511251125 query37 152 106 91 91 query38 3183313630853085 query39 925 918 887 887 query39_1889 876 866 866 query40 236 159 139 139 query41 70 68 66 66 query42 109 110 107 107 query43 318 338 278 278 query44 query45 210 201 191 191 query46 10451221765 765 query47 2284235021762176 query48 411 429 294 294 query49 656 559 438 438 query50 724 280 235 235 query51 4341430841854185 query52 107 106 92 92 query53 257 277 204 204 query54 335 285 266 266 query55 96 93 87 87 query56 321 318 308 308 query57 1430138012981298 query58 308 287 276 276 query59 1570162614101410 query60 399 334 319 319 query61 162 155 185 155 query62 668 619 559 559 query63 236 195 204 195 query64 2328815 669 669 query65 query66 1714501 398 398 query67 30085 29870 29257 29257 query68 query69 467 340 300 300 query70 1012983 991 983 query71 308 260 267 260 query72 2995271624602460 query73 808 775 414 414 query74 5102488146964696 query75 2792265023202320 query76 22761152727 727 query77 413 417 343 343 query78 12980 12967 12343 12343 query79 14971025763 763 query80 1376555 469 469 query81 500 283 239 239 query82 1248155 123 123 query83 359 277 250 250 query84 256 144 114 114 query85 915 517 465 465 query86 441 336 304 304 query87 340232143214 query88 3566267626722672 query89 435 379 332 332 query90 1911181 177 177 query91 177 165 142 142 query92 75 75 71 71 query93 952 953 572 572 query94 719 338 297 297 query95 675 479 351 351 query96 1010788 368 368 query97 2675267825802580 query98 233 228 226 226 query99 11101121993 993 Total cold run time: 255233 ms Total hot run time: 171293 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]
Re: [PR] [refactor](storage) drop StorageField wrapper and others dead code [doris]
hello-stephen commented on PR #63233: URL: https://github.com/apache/doris/pull/63233#issuecomment-4449012899 TPC-H: Total hot run time: 29501 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit dba29514cf661aeb26b3d7da818211a793307cac, data reload: false -- Round 1 -- orders Doris NULLNULL0 0 0 NULL0 NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8 NULLNULL q1 17670 390838693869 q2 q3 10718 885 610 610 q4 4659462 339 339 q5 7461133511361136 q6 191 166 141 141 q7 915 932 740 740 q8 9325137213071307 q9 5633544353375337 q10 6250210018391839 q11 456 261 261 261 q12 631 415 295 295 q13 18180 327227792779 q14 292 285 264 264 q15 q16 903 859 786 786 q17 954 1017715 715 q18 6512578254085408 q19 1156124811061106 q20 504 392 257 257 q21 4644238419861986 q22 481 448 326 326 Total cold run time: 97535 ms Total hot run time: 29501 ms - Round 2, with runtime_filter_mode=off - orders Doris NULLNULL15000 42 6422171781 NULL22778155NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8 NULLNULL q1 4789471047464710 q2 q3 4666482142144214 q4 2130219214461446 q5 5008500053605000 q6 200 182 137 137 q7 2095178316161616 q8 3310307830833078 q9 8518842083958395 q10 4475448942414241 q11 612 414 397 397 q12 699 745 513 513 q13 3212361629602960 q14 310 294 280 280 q15 q16 963 805 702 702 q17 1362131112841284 q18 8033725471607160 q19 1170113812061138 q20 2216221419361936 q21 6143546048544854 q22 556 512 439 439 Total cold run time: 60467 ms Total hot run time: 54500 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](storage) drop StorageField wrapper and others dead code [doris]
csun5285 commented on PR #63233: URL: https://github.com/apache/doris/pull/63233#issuecomment-4448304416 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](storage) drop StorageField wrapper and others dead code [doris]
hello-stephen commented on PR #63233: URL: https://github.com/apache/doris/pull/63233#issuecomment-4448257750 # BE Regression && UT Coverage Report Increment line coverage `85.98% (141/164)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/63233_c322ef733f915fa262c959cac119947984d1a3de_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/63233_c322ef733f915fa262c959cac119947984d1a3de_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 73.81% (27766/37619) | | Line Coverage | 57.64% (301226/522565) | | Region Coverage | 54.93% (251797/458397) | | Branch Coverage | 56.39% (108775/192891) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](storage) drop StorageField wrapper and others dead code [doris]
hello-stephen commented on PR #63233: URL: https://github.com/apache/doris/pull/63233#issuecomment-4448226968 # BE UT Coverage Report Increment line coverage `67.88% (112/165)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/c322ef733f915fa262c959cac119947984d1a3de_c322ef733f915fa262c959cac119947984d1a3de/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/c322ef733f915fa262c959cac119947984d1a3de_c322ef733f915fa262c959cac119947984d1a3de/report/index.html) | Category | Coverage | |---|| | Function Coverage | 53.60% (20589/38412) | | Line Coverage | 37.18% (194795/523906) | | Region Coverage | 33.59% (152469/453864) | | Branch Coverage | 34.58% (66440/192137) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](storage) drop StorageField wrapper and others dead code [doris]
hello-stephen commented on PR #63233: URL: https://github.com/apache/doris/pull/63233#issuecomment-4447375996 TPC-DS: Total hot run time: 172234 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit c322ef733f915fa262c959cac119947984d1a3de, data reload: false query5 4306683 540 540 query6 324 225 201 201 query7 4227580 319 319 query8 328 238 218 218 query9 8843406240614061 query10 452 353 289 289 query11 5776244822842284 query12 184 132 129 129 query13 1279624 474 474 query14 6583536650895089 query14_14329433643054305 query15 206 200 183 183 query16 997 468 434 434 query17 1133759 630 630 query18 2763519 360 360 query19 218 206 158 158 query20 137 131 137 131 query21 229 135 112 112 query22 13643 13605 13509 13509 query23 17377 16335 16700 16335 query23_116331 16321 16304 16304 query24 7537184314281428 query24_11456141714071407 query25 598 571 486 486 query26 1452340 184 184 query27 2875622 344 344 query28 4339197019721970 query29 1047654 543 543 query30 316 257 208 208 query31 11121081952 952 query32 91 75 74 74 query33 579 369 313 313 query34 11841155646 646 query35 796 789 688 688 query36 1334128612031203 query37 152 115 92 92 query38 3228314430743074 query39 932 943 910 910 query39_1876 877 860 860 query40 234 161 144 144 query41 71 68 69 68 query42 113 110 110 110 query43 326 332 284 284 query44 query45 212 205 249 205 query46 10481231741 741 query47 2287228821662166 query48 392 424 293 293 query49 632 545 444 444 query50 682 282 216 216 query51 4405434942254225 query52 105 105 91 91 query53 257 272 201 201 query54 319 272 263 263 query55 93 89 83 83 query56 299 308 313 308 query57 1400137813181318 query58 298 255 262 255 query59 1609167814261426 query60 364 326 321 321 query61 175 165 162 162 query62 668 623 564 564 query63 241 198 200 198 query64 2327836 708 708 query65 query66 1700504 397 397 query67 30497 29729 30300 29729 query68 query69 465 347 299 299 query70 10361000995 995 query71 305 276 269 269 query72 3015277424272427 query73 851 776 433 433 query74 5091491347604760 query75 2810272523562356 query76 23101158751 751 query77 449 430 341 341 query78 13308 13308 12538 12538 query79 1524978 739 739 query80 1376555 503 503 query81 510 294 256 256 query82 1280154 117 117 query83 348 283 258 258 query84 259 134 109 109 query85 924 516 441 441 query86 444 352 308 308 query87 3468340332223222 query88 3547270126542654 query89 434 371 333 333 query90 1898183 179 179 query91 179 171 140 140 query92 79 71 72 71 query93 956 964 571 571 query94 724 340 313 313 query95 672 459 360 360 query96 999 808 318 318 query97 2738268925282528 query98 241 235 227 227 query99 11101114985 985 Total cold run time: 256525 ms Total hot run time: 172234 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]
Re: [PR] [refactor](storage) drop StorageField wrapper and others dead code [doris]
hello-stephen commented on PR #63233: URL: https://github.com/apache/doris/pull/63233#issuecomment-4447322624 TPC-H: Total hot run time: 29579 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit c322ef733f915fa262c959cac119947984d1a3de, data reload: false -- Round 1 -- orders Doris NULLNULL0 0 0 NULL0 NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8 NULLNULL q1 17645 385238393839 q2 q3 10718 900 618 618 q4 4663456 351 351 q5 7465133111391139 q6 183 167 140 140 q7 944 943 745 745 q8 9316142813011301 q9 5552539353315331 q10 6268209318341834 q11 482 268 259 259 q12 633 414 292 292 q13 18081 328327712771 q14 295 285 260 260 q15 q16 900 877 791 791 q17 10111089777 777 q18 6475569556645664 q19 1150126110341034 q20 502 407 263 263 q21 4553227718681868 q22 421 357 302 302 Total cold run time: 97257 ms Total hot run time: 29579 ms - Round 2, with runtime_filter_mode=off - orders Doris NULLNULL15000 42 6422171781 NULL22778155NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8 NULLNULL q1 4165408340944083 q2 q3 4652476842054205 q4 2072216513731373 q5 4996501752565017 q6 183 165 130 130 q7 2071176517931765 q8 3632323432943234 q9 8612854685718546 q10 4498449842304230 q11 616 428 416 416 q12 702 753 509 509 q13 3542363329062906 q14 310 314 289 289 q15 q16 792 789 681 681 q17 1362132312831283 q18 8013711971237119 q19 1170114611391139 q20 2209223019551955 q21 6226542749224922 q22 540 527 425 425 Total cold run time: 60363 ms Total hot run time: 54227 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](storage) drop StorageField wrapper and others dead code [doris]
hello-stephen commented on PR #63233: URL: https://github.com/apache/doris/pull/63233#issuecomment-4446806204 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](storage) drop StorageField wrapper and others dead code [doris]
csun5285 commented on PR #63233: URL: https://github.com/apache/doris/pull/63233#issuecomment-4446805682 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[PR] [refactor](storage) drop StorageField wrapper and others dead code [doris]
csun5285 opened a new pull request, #63233: URL: https://github.com/apache/doris/pull/63233 ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [ ] No. - [ ] Yes. - Does this need documentation? - [ ] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
