Re: [PR] [Bug](set) fix missing null when intersect operator's hashmap shrink [doris]
BiteThet merged PR #51063: URL: https://github.com/apache/doris/pull/51063 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](set) fix missing null when intersect operator's hashmap shrink [doris]
github-actions[bot] commented on PR #51063: URL: https://github.com/apache/doris/pull/51063#issuecomment-2910972048 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](set) fix missing null when intersect operator's hashmap shrink [doris]
BiteThet commented on PR #51063: URL: https://github.com/apache/doris/pull/51063#issuecomment-2908932065 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](set) fix missing null when intersect operator's hashmap shrink [doris]
BiteThet commented on PR #51063: URL: https://github.com/apache/doris/pull/51063#issuecomment-2908947533 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](set) fix missing null when intersect operator's hashmap shrink [doris]
BiteThet commented on PR #51063: URL: https://github.com/apache/doris/pull/51063#issuecomment-2908935730 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](set) fix missing null when intersect operator's hashmap shrink [doris]
BiteThet commented on PR #51063: URL: https://github.com/apache/doris/pull/51063#issuecomment-2908403811 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](set) fix missing null when intersect operator's hashmap shrink [doris]
BiteThet commented on PR #51063: URL: https://github.com/apache/doris/pull/51063#issuecomment-2908400688 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](set) fix missing null when intersect operator's hashmap shrink [doris]
BiteThet commented on PR #51063: URL: https://github.com/apache/doris/pull/51063#issuecomment-2903353798 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](set) fix missing null when intersect operator's hashmap shrink [doris]
HappenLee commented on code in PR #51063:
URL: https://github.com/apache/doris/pull/51063#discussion_r2103779845
##
be/src/pipeline/exec/set_probe_sink_operator.cpp:
##
@@ -211,8 +211,8 @@ void
SetProbeSinkOperatorX::_refresh_hash_table(
using HashTableCtxType = std::decay_t;
if constexpr (!std::is_same_v) {
arg.init_iterator();
-auto& iter = arg.iterator;
-auto iter_end = arg.hash_table->end();
+auto& iter = arg.begin;
+auto iter_end = arg.end;
Review Comment:
why begin use Ref，end not do the same thing？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](set) fix missing null when intersect operator's hashmap shrink [doris]
BiteThet commented on PR #51063: URL: https://github.com/apache/doris/pull/51063#issuecomment-2896730171 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](set) fix missing null when intersect operator's hashmap shrink [doris]
github-actions[bot] commented on PR #51063: URL: https://github.com/apache/doris/pull/51063#issuecomment-2896413414 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](set) fix missing null when intersect operator's hashmap shrink [doris]
BiteThet commented on PR #51063: URL: https://github.com/apache/doris/pull/51063#issuecomment-2895039745 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](set) fix missing null when intersect operator's hashmap shrink [doris]
BiteThet commented on PR #51063: URL: https://github.com/apache/doris/pull/51063#issuecomment-2894378813 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](set) fix missing null when intersect operator's hashmap shrink [doris]
BiteThet commented on PR #51063: URL: https://github.com/apache/doris/pull/51063#issuecomment-2893572519 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](set) fix missing null when intersect operator's hashmap shrink [doris]
BiteThet commented on PR #51063: URL: https://github.com/apache/doris/pull/51063#issuecomment-2893172161 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](set) fix missing null when intersect operator's hashmap shrink [doris]
Thearas commented on PR #51063: URL: https://github.com/apache/doris/pull/51063#issuecomment-2893093900 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
