Re: [PR] [BugFix] Fix filter push issue with OR in SQL [doris-spark-connector]
JNSimba merged PR #317: URL: https://github.com/apache/doris-spark-connector/pull/317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [BugFix] Fix filter push issue with OR in SQL [doris-spark-connector]
wary commented on PR #317: URL: https://github.com/apache/doris-spark-connector/pull/317#issuecomment-2903280680 > Thanks for the contribution, it would be better to cover it in ITCase, similar to this https://github.com/apache/doris-spark-connector/blob/master/spark-doris-connector/spark-doris-connector-it/src/test/java/org/apache/doris/spark/sql/DorisReaderITCase.scala#L376 added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [BugFix] Fix filter push issue with OR in SQL [doris-spark-connector]
JNSimba commented on PR #317: URL: https://github.com/apache/doris-spark-connector/pull/317#issuecomment-2903033666 Thanks for the contribution, it would be best to cover it in this ITCase https://github.com/apache/doris-spark-connector/blob/master/spark-doris-connector/spark-doris-connector-it/src/test/java/org/apache/doris/spark/sql/DorisReaderITCase.scala#L376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org