Re: [PR] [Chore](build) Adapt ldb toolchain 0.25 [doris]
BiteThet merged PR #52820: URL: https://github.com/apache/doris/pull/52820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Chore](build) Adapt ldb toolchain 0.25 [doris]
hello-stephen commented on PR #52820: URL: https://github.com/apache/doris/pull/52820#issuecomment-3051147177 # BE UT Coverage Report Increment line coverage `87.50% (7/8)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/ffde3a7cb78766e6acd9d75fbf143cc0423b5d92_ffde3a7cb78766e6acd9d75fbf143cc0423b5d92/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/ffde3a7cb78766e6acd9d75fbf143cc0423b5d92_ffde3a7cb78766e6acd9d75fbf143cc0423b5d92/report/index.html) | Category | Coverage | |---|| | Function Coverage | 57.33% (15509/27050) | | Line Coverage | 46.32% (140962/304352) | | Region Coverage | 45.56% (71269/156412) | | Branch Coverage | 40.28% (37555/93228) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Chore](build) Adapt ldb toolchain 0.25 [doris]
github-actions[bot] commented on PR #52820: URL: https://github.com/apache/doris/pull/52820#issuecomment-3050998339 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Chore](build) Adapt ldb toolchain 0.25 [doris]
BiteThet commented on PR #52820: URL: https://github.com/apache/doris/pull/52820#issuecomment-3050942547 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Chore](build) Adapt ldb toolchain 0.25 [doris]
zclllyybb commented on code in PR #52820: URL: https://github.com/apache/doris/pull/52820#discussion_r2193898429 ## be/src/glibc-compatibility/glibc-compatibility.c: ## @@ -175,6 +175,15 @@ void __explicit_bzero_chk(void * buf, size_t len, size_t unused) explicit_bzero(buf, len); } +int snprintf(char* __restrict __s, size_t __maxlen, const char* __restrict __format, ...); Review Comment: where does this symbol link to? add a comment? maybe explicit add a `extern` modifier is a good idea -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Chore](build) Adapt ldb toolchain 0.25 [doris]
zclllyybb commented on code in PR #52820:
URL: https://github.com/apache/doris/pull/52820#discussion_r2193893264
##
be/test/io/cache/block_file_cache_test_common.h:
##
@@ -74,14 +74,21 @@ extern int disk_used_percentage(const std::string& path,
std::pair* pe
extern fs::path caches_dir;
extern std::string cache_base_path;
extern std::string tmp_file;
-
+#if defined(__clang__)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wunknown-warning-option"
+#pragma clang diagnostic ignored "-Wdeprecated-literal-operator"
+#endif
constexpr unsigned long long operator"" _mb(unsigned long long m) {
Review Comment:
dont ignore warning. just fix like:
```suggestion
constexpr unsigned long long operator""_mb(unsigned long long m) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [Chore](build) Adapt ldb toolchain 0.25 [doris]
github-actions[bot] commented on PR #52820: URL: https://github.com/apache/doris/pull/52820#issuecomment-3050897066 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Chore](build) Adapt ldb toolchain 0.25 [doris]
hello-stephen commented on PR #52820: URL: https://github.com/apache/doris/pull/52820#issuecomment-3049016062 # BE UT Coverage Report Increment line coverage `87.50% (7/8)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/cf184ee5668bf3a39e56ea0052263b753961434d_cf184ee5668bf3a39e56ea0052263b753961434d/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/cf184ee5668bf3a39e56ea0052263b753961434d_cf184ee5668bf3a39e56ea0052263b753961434d/report/index.html) | Category | Coverage | |---|| | Function Coverage | 57.33% (15506/27047) | | Line Coverage | 46.31% (140932/304324) | | Region Coverage | 45.57% (71264/156400) | | Branch Coverage | 40.28% (37551/93222) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Chore](build) Adapt ldb toolchain 0.25 [doris]
BiteThet commented on PR #52820: URL: https://github.com/apache/doris/pull/52820#issuecomment-3048545950 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Chore](build) Adapt ldb toolchain 0.25 [doris]
BiteThet commented on PR #52820: URL: https://github.com/apache/doris/pull/52820#issuecomment-3048533133 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Chore](build) Adapt ldb toolchain 0.25 [doris]
hello-stephen commented on PR #52820: URL: https://github.com/apache/doris/pull/52820#issuecomment-3048288347 # BE UT Coverage Report Increment line coverage `87.50% (7/8)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/4e216e4f5a5babcc17538811857da55b28c2e02b_4e216e4f5a5babcc17538811857da55b28c2e02b/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/4e216e4f5a5babcc17538811857da55b28c2e02b_4e216e4f5a5babcc17538811857da55b28c2e02b/report/index.html) | Category | Coverage | |---|| | Function Coverage | 56.98% (15489/27181) | | Line Coverage | 45.82% (138037/301260) | | Region Coverage | 35.28% (103253/292650) | | Branch Coverage | 37.70% (45391/120387) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Chore](build) Adapt ldb toolchain 0.25 [doris]
BiteThet commented on PR #52820: URL: https://github.com/apache/doris/pull/52820#issuecomment-3047960554 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Chore](build) Adapt ldb toolchain 0.25 [doris]
BiteThet commented on PR #52820: URL: https://github.com/apache/doris/pull/52820#issuecomment-3047671885 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Chore](build) Adapt ldb toolchain 0.25 [doris]
BiteThet commented on PR #52820: URL: https://github.com/apache/doris/pull/52820#issuecomment-3047450314 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Chore](build) Adapt ldb toolchain 0.25 [doris]
BiteThet commented on PR #52820: URL: https://github.com/apache/doris/pull/52820#issuecomment-3047185534 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Chore](build) Adapt ldb toolchain 0.25 [doris]
hello-stephen commented on PR #52820: URL: https://github.com/apache/doris/pull/52820#issuecomment-3046122497 # BE UT Coverage Report Increment line coverage `100.00% (6/6)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/23ad84f54ce66feee599ea29c4c0cfb25f1dbde7_23ad84f54ce66feee599ea29c4c0cfb25f1dbde7/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/23ad84f54ce66feee599ea29c4c0cfb25f1dbde7_23ad84f54ce66feee599ea29c4c0cfb25f1dbde7/report/index.html) | Category | Coverage | |---|| | Function Coverage | 57.32% (15498/27039) | | Line Coverage | 46.29% (140850/304251) | | Region Coverage | 45.55% (71217/156358) | | Branch Coverage | 40.26% (37527/93202) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Chore](build) Adapt ldb toolchain 0.25 [doris]
BiteThet commented on PR #52820: URL: https://github.com/apache/doris/pull/52820#issuecomment-3045560657 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Chore](build) Adapt ldb toolchain 0.25 [doris]
yiguolei commented on PR #52820: URL: https://github.com/apache/doris/pull/52820#issuecomment-3038729264 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Chore](build) Adapt ldb toolchain 0.25 [doris]
hello-stephen commented on PR #52820: URL: https://github.com/apache/doris/pull/52820#issuecomment-3038344128 # BE UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/d3540b5dc37072e7461e2ede0742023562a81fec_d3540b5dc37072e7461e2ede0742023562a81fec/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/d3540b5dc37072e7461e2ede0742023562a81fec_d3540b5dc37072e7461e2ede0742023562a81fec/report/index.html) | Category | Coverage | |---|| | Function Coverage | 57.34% (15484/27006) | | Line Coverage | 46.31% (140664/303771) | | Region Coverage | 45.59% (71176/156112) | | Branch Coverage | 40.30% (37496/93036) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Chore](build) Adapt ldb toolchain 0.25 [doris]
BiteThet commented on PR #52820: URL: https://github.com/apache/doris/pull/52820#issuecomment-3038129464 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Chore](build) Adapt ldb toolchain 0.25 [doris]
BiteThet commented on PR #52820: URL: https://github.com/apache/doris/pull/52820#issuecomment-3038099006 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Chore](build) Adapt ldb toolchain 0.25 [doris]
BiteThet commented on PR #52820: URL: https://github.com/apache/doris/pull/52820#issuecomment-3037870041 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Chore](build) Adapt ldb toolchain 0.25 [doris]
Thearas commented on PR #52820: URL: https://github.com/apache/doris/pull/52820#issuecomment-3037869978 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
