Re: [PR] [Enhancement](function) The date_add function supports SECOND_MICROSECOND as interval type [doris]
codeDing18 merged PR #58665: URL: https://github.com/apache/doris/pull/58665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) The date_add function supports SECOND_MICROSECOND as interval type [doris]
github-actions[bot] commented on PR #58665: URL: https://github.com/apache/doris/pull/58665#issuecomment-3614142882 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) The date_add function supports SECOND_MICROSECOND as interval type [doris]
hello-stephen commented on PR #58665: URL: https://github.com/apache/doris/pull/58665#issuecomment-3610481835 # BE Regression && UT Coverage Report Increment line coverage `85.71% (42/49)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58665_728990e3795ef3b98180f8a2d53c1aaf6bc0fdab_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58665_728990e3795ef3b98180f8a2d53c1aaf6bc0fdab_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 71.89% (24623/34253) | | Line Coverage | 58.54% (258015/440722) | | Region Coverage | 53.53% (214649/401011) | | Branch Coverage | 55.01% (91702/166688) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) The date_add function supports SECOND_MICROSECOND as interval type [doris]
codeDing18 commented on PR #58665: URL: https://github.com/apache/doris/pull/58665#issuecomment-3609818402 run compile -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) The date_add function supports SECOND_MICROSECOND as interval type [doris]
hello-stephen commented on PR #58665: URL: https://github.com/apache/doris/pull/58665#issuecomment-3609790274 # BE UT Coverage Report Increment line coverage `71.43% (35/49)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/728990e3795ef3b98180f8a2d53c1aaf6bc0fdab_728990e3795ef3b98180f8a2d53c1aaf6bc0fdab/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/728990e3795ef3b98180f8a2d53c1aaf6bc0fdab_728990e3795ef3b98180f8a2d53c1aaf6bc0fdab/report/index.html) | Category | Coverage | |---|| | Function Coverage | 53.36% (18642/34936) | | Line Coverage | 39.02% (172125/441112) | | Region Coverage | 33.63% (133224/396197) | | Branch Coverage | 34.59% (57341/165789) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) The date_add function supports SECOND_MICROSECOND as interval type [doris]
doris-robot commented on PR #58665: URL: https://github.com/apache/doris/pull/58665#issuecomment-3609730809 ClickBench: Total hot run time: 27.37 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 728990e3795ef3b98180f8a2d53c1aaf6bc0fdab, data reload: false query1 0.050.050.05 query2 0.100.050.05 query3 0.260.090.09 query4 1.610.110.11 query5 0.290.270.26 query6 1.160.640.63 query7 0.030.020.03 query8 0.060.040.04 query9 0.580.500.50 query10 0.560.560.56 query11 0.170.100.10 query12 0.140.110.12 query13 0.620.600.60 query14 0.980.980.98 query15 0.820.790.80 query16 0.390.400.40 query17 1.101.061.06 query18 0.240.210.21 query19 1.831.851.88 query20 0.010.010.01 query21 15.45 0.320.15 query22 4.620.060.06 query23 16.01 0.260.10 query24 1.800.380.23 query25 0.080.040.09 query26 0.150.140.13 query27 0.080.050.06 query28 3.491.261.01 query29 12.54 4.053.36 query30 0.270.140.12 query31 2.820.600.38 query32 3.230.560.45 query33 3.023.053.06 query34 16.83 5.144.49 query35 4.524.624.50 query36 0.640.510.49 query37 0.110.060.06 query38 0.070.040.03 query39 0.050.030.04 query40 0.190.150.13 query41 0.080.030.03 query42 0.040.030.03 query43 0.040.040.03 Total cold run time: 97.13 s Total hot run time: 27.37 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) The date_add function supports SECOND_MICROSECOND as interval type [doris]
doris-robot commented on PR #58665: URL: https://github.com/apache/doris/pull/58665#issuecomment-3609705066 TPC-DS: Total hot run time: 181717 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 728990e3795ef3b98180f8a2d53c1aaf6bc0fdab, data reload: false query5 4372658 513 513 query6 344 246 228 228 query7 4653520 310 310 query8 329 256 232 232 query9 8700262626372626 query10 538 373 322 322 query11 15261 14786 14974 14786 query12 198 119 118 118 query13 1701589 455 455 query14 6481327930213021 query14_12928294229412941 query15 223 205 180 180 query16 7703695 539 539 query17 1257796 636 636 query18 2064446 351 351 query19 220 216 196 196 query20 134 129 125 125 query21 222 141 122 122 query22 3998390238993899 query23 16523 16171 15878 15878 query23_116148 16078 16111 16078 query24 6842163712151215 query24_11203121112241211 query25 648 558 493 493 query26 1258288 174 174 query27 2702503 352 352 query28 4329215921542154 query29 826 662 532 532 query30 324 245 219 219 query31 824 710 634 634 query32 90 77 82 77 query33 623 403 354 354 query34 828 894 584 584 query35 795 811 721 721 query36 906 927 828 828 query37 128 120 88 88 query38 3858387237833783 query39 770 723 715 715 query39_1702 698 696 696 query40 229 133 121 121 query41 69 61 60 60 query42 129 110 124 110 query43 445 444 418 418 query44 1309762 762 762 query45 199 194 183 183 query46 891 1007678 678 query47 1649176516371637 query48 413 421 321 321 query49 788 493 420 420 query50 675 701 405 405 query51 3867389239273892 query52 117 113 105 105 query53 245 259 200 200 query54 314 296 282 282 query55 102 97 93 93 query56 340 346 347 346 query57 1131114911091109 query58 325 287 272 272 query59 2333241322822282 query60 357 338 332 332 query61 162 166 160 160 query62 768 722 651 651 query63 224 190 194 190 query64 44651257892 892 query65 4036394539903945 query66 1099441 334 334 query67 15369 14941 14923 14923 query68 8325997 642 642 query69 519 350 307 307 query70 1121102110071007 query71 480 342 321 321 query72 5786488348344834 query73 704 569 343 343 query74 8875885986608660 query75 3688305024852485 query76 37531133754 754 query77 814 403 310 310 query78 9403968488858885 query79 2272843 595 595 query80 658 598 491 491 query81 512 273 244 244 query82 475 139 111 111 query83 272 272 250 250 query84 264 114 88 88 query85 952 498 442 442 query86 398 297 290 290 query87 4012410639783978 query88 4164227022732270 query89 389 331 297 297 query90 1865220 213 213 query91 165 182 135 135 query92 80 74 69 69 query93 19251025680 680 query94 727 445 335 335 query95 505 413 406 406 query96 540 554 290 290 query97 2618269325842584 query98 245 207 213 207 query99 1348137012751275 Total cold run time: 271752 ms Total hot run time: 181717 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [Enhancement](function) The date_add function supports SECOND_MICROSECOND as interval type [doris]
doris-robot commented on PR #58665: URL: https://github.com/apache/doris/pull/58665#issuecomment-3609658793 TPC-H: Total hot run time: 34501 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 728990e3795ef3b98180f8a2d53c1aaf6bc0fdab, data reload: false -- Round 1 -- q1 17668 499649244924 q2 2057328 199 199 q3 10232 1306735 735 q4 10206 794 319 319 q5 7531242521092109 q6 189 170 139 139 q7 948 802 637 637 q8 10120 142511141114 q9 7144543854375437 q10 6860222918511851 q11 528 316 304 304 q12 349 384 233 233 q13 18407 363329812981 q14 234 235 216 216 q15 586 515 515 515 q16 868 863 805 805 q17 679 738 510 510 q18 7613714471077107 q19 1149938 613 613 q20 361 343 233 233 q21 3962321725932593 q22 1018966 927 927 Total cold run time: 108709 ms Total hot run time: 34501 ms - Round 2, with runtime_filter_mode=off - q1 4981491848934893 q2 332 416 318 318 q3 2143266023272327 q4 1337177213211321 q5 4221453645354535 q6 216 169 132 132 q7 2049205618641864 q8 2757252224722472 q9 7510759375227522 q10 3101325728202820 q11 606 526 502 502 q12 715 732 826 732 q13 34333856 q14 282 413 410 410 q15 557 512 510 510 q16 892 905 880 880 q17 1175142714891427 q18 7919764875397539 q19 985 833 867 833 q20 2005206519101910 q21 4910430041614161 q22 11301032974 974 Total cold run time: 53256 ms Total hot run time: 51415 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) The date_add function supports SECOND_MICROSECOND as interval type [doris]
codeDing18 commented on PR #58665: URL: https://github.com/apache/doris/pull/58665#issuecomment-3609528857 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) The date_add function supports SECOND_MICROSECOND as interval type [doris]
codeDing18 commented on PR #58665: URL: https://github.com/apache/doris/pull/58665#issuecomment-3609503421 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) The date_add function supports SECOND_MICROSECOND as interval type [doris]
hello-stephen commented on PR #58665: URL: https://github.com/apache/doris/pull/58665#issuecomment-3607542322 # FE Regression Coverage Report Increment line coverage ` 79.49% (31/39)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58665_4f891f9f71e62ed79060251b3fac4511fffbda39_merge_fe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58665_4f891f9f71e62ed79060251b3fac4511fffbda39_merge_fe/report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) The date_add function supports SECOND_MICROSECOND as interval type [doris]
doris-robot commented on PR #58665: URL: https://github.com/apache/doris/pull/58665#issuecomment-3606783587 ClickBench: Total hot run time: 27.56 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 4f891f9f71e62ed79060251b3fac4511fffbda39, data reload: false query1 0.050.050.05 query2 0.100.050.04 query3 0.270.100.09 query4 1.600.110.11 query5 0.270.270.25 query6 1.150.650.63 query7 0.030.020.03 query8 0.060.040.04 query9 0.570.500.51 query10 0.570.550.56 query11 0.160.110.11 query12 0.150.110.12 query13 0.630.600.61 query14 0.980.980.99 query15 0.820.790.80 query16 0.430.400.40 query17 1.051.061.04 query18 0.270.220.21 query19 1.981.831.86 query20 0.010.010.02 query21 15.45 0.250.14 query22 4.970.050.04 query23 16.08 0.290.11 query24 1.180.620.46 query25 0.100.050.05 query26 0.140.140.14 query27 0.060.050.06 query28 3.971.221.02 query29 12.60 3.993.29 query30 0.270.140.11 query31 2.830.620.39 query32 3.240.550.45 query33 3.003.063.04 query34 16.90 5.234.58 query35 4.614.574.48 query36 0.660.500.50 query37 0.100.060.06 query38 0.070.050.03 query39 0.040.040.03 query40 0.160.140.14 query41 0.090.040.03 query42 0.050.030.03 query43 0.040.040.03 Total cold run time: 97.76 s Total hot run time: 27.56 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) The date_add function supports SECOND_MICROSECOND as interval type [doris]
doris-robot commented on PR #58665: URL: https://github.com/apache/doris/pull/58665#issuecomment-3606762650 TPC-DS: Total hot run time: 181697 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 4f891f9f71e62ed79060251b3fac4511fffbda39, data reload: false query1 1069417 400 400 query2 6569120911791179 query3 6745230 227 227 query4 25480 23511 22928 22928 query5 5254624 501 501 query6 360 246 247 246 query7 4658517 313 313 query8 331 245 248 245 query9 8719267826812678 query10 593 386 313 313 query11 15368 15108 14514 14514 query12 196 115 113 113 query13 1685566 448 448 query14 10140 590359875903 query15 206 200 185 185 query16 7658689 535 535 query17 1287763 615 615 query18 2049457 328 328 query19 206 205 174 174 query20 129 131 123 123 query21 221 135 113 113 query22 3979392338153815 query23 32829 31906 31865 31865 query24 8399244424272427 query25 602 518 468 468 query26 1247281 169 169 query27 2723503 357 357 query28 4395220521902190 query29 812 615 481 481 query30 319 236 216 216 query31 858 699 629 629 query32 85 74 71 71 query33 589 385 332 332 query34 842 867 541 541 query35 783 807 748 748 query36 888 920 837 837 query37 131 115 92 92 query38 3907383838143814 query39 1454141813951395 query40 227 135 123 123 query41 68 63 62 62 query42 133 119 114 114 query43 451 444 418 418 query44 1335775 763 763 query45 198 195 188 188 query46 906 1004654 654 query47 1687171516281628 query48 406 452 334 334 query49 785 514 424 424 query50 697 728 405 405 query51 3988396838423842 query52 118 112 110 110 query53 242 264 197 197 query54 329 320 303 303 query55 97 100 98 98 query56 367 337 345 337 query57 1141117011161116 query58 299 291 275 275 query59 2321243323542354 query60 372 364 362 362 query61 194 192 184 184 query62 842 746 643 643 query63 245 199 199 199 query64 4613135710271027 query65 4048397639893976 query66 1103462 349 349 query67 15228 14838 14927 14838 query68 7753998 648 648 query69 516 353 316 316 query70 11441091968 968 query71 443 359 325 325 query72 6101489250244892 query73 680 573 346 346 query74 8868873986338633 query75 3071302625752575 query76 33061137741 741 query77 521 419 339 339 query78 9538960687678767 query79 2689846 590 590 query80 679 586 510 510 query81 526 271 244 244 query82 488 140 109 109 query83 265 268 255 255 query84 260 121 103 103 query85 941 497 469 469 query86 387 310 274 274 query87 4042402840184018 query88 4257225622522252 query89 390 329 295 295 query90 2077223 210 210 query91 177 172 142 142 query92 82 71 67 67 query93 25021036672 672 query94 739 498 337 337 query95 516 404 415 404 query96 544 556 290 290 query97 2640267026142614 query98 260 216 213 213 query99 1282136612281228 Total cold run time: 273889 ms Total hot run time: 181697 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [Enhancement](function) The date_add function supports SECOND_MICROSECOND as interval type [doris]
doris-robot commented on PR #58665: URL: https://github.com/apache/doris/pull/58665#issuecomment-3606717917 TPC-H: Total hot run time: 35668 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 4f891f9f71e62ed79060251b3fac4511fffbda39, data reload: false -- Round 1 -- q1 17605 511449254925 q2 2042327 202 202 q3 10236 1334738 738 q4 10227 880 334 334 q5 7531244221402140 q6 185 165 137 137 q7 948 793 651 651 q8 9354140310781078 q9 7018526953345269 q10 6789219217641764 q11 521 320 294 294 q12 346 385 233 233 q13 17776 371530763076 q14 243 239 215 215 q15 574 540 510 510 q16 894 855 808 808 q17 670 760 588 588 q18 7656750379177503 q19 12621023641 641 q20 402 384 239 239 q21 4322393733303330 q22 11101047993 993 Total cold run time: 107711 ms Total hot run time: 35668 ms - Round 2, with runtime_filter_mode=off - q1 5203516452235164 q2 339 503 358 358 q3 2281273225832583 q4 1463194314281428 q5 4545443445234434 q6 210 165 127 127 q7 2035196517761776 q8 2734257624962496 q9 7443746774597459 q10 3066321628272827 q11 589 531 500 500 q12 707 740 614 614 q13 3353361329872987 q14 269 280 261 261 q15 542 494 488 488 q16 873 894 833 833 q17 1148132813691328 q18 7356698170336981 q19 870 831 837 831 q20 1912196718061806 q21 4616439941104110 q22 10851026988 988 Total cold run time: 52639 ms Total hot run time: 50379 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) The date_add function supports SECOND_MICROSECOND as interval type [doris]
codeDing18 commented on PR #58665: URL: https://github.com/apache/doris/pull/58665#issuecomment-3606625035 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) The date_add function supports SECOND_MICROSECOND as interval type [doris]
github-actions[bot] commented on PR #58665: URL: https://github.com/apache/doris/pull/58665#issuecomment-3606575552 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) The date_add function supports SECOND_MICROSECOND as interval type [doris]
linrrzqqq commented on code in PR #58665:
URL: https://github.com/apache/doris/pull/58665#discussion_r2584875822
##
fe/fe-core/src/test/java/org/apache/doris/nereids/rules/expression/FoldConstantTest.java:
##
@@ -467,6 +468,22 @@ void testFoldDate() {
new VarcharLiteral("-2:-1"));
rewritten = executor.rewrite(minuteSecondAdd, context);
Assertions.assertEquals(minuteSecondAdd, rewritten);
+
+SecondMicrosecondAdd secondMicrosecondAdd = new SecondMicrosecondAdd(
+DateTimeV2Literal.fromJavaDateType(LocalDateTime.of(1, 1, 1,
1, 1, 1), 0),
Review Comment:
```suggestion
DateTimeV2Literal.fromJavaDateType(LocalDateTime.of(1, 1, 1,
1, 1, 1), 6),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) The date_add function supports SECOND_MICROSECOND as interval type [doris]
linrrzqqq commented on code in PR #58665:
URL: https://github.com/apache/doris/pull/58665#discussion_r2584867718
##
be/test/vec/function/function_time_test.cpp:
##
@@ -1230,6 +1230,41 @@ TEST(VTimestampFunctionsTest, minute_second_add_v2_test)
{
}
}
+TEST(VTimestampFunctionsTest, second_microsecond_add_v2_test) {
+std::string func_name = "second_microsecond_add";
+
+InputTypeSet input_types = {PrimitiveType::TYPE_DATETIMEV2,
+Consted {PrimitiveType::TYPE_STRING}};
+
+{
+DataSet data_set = {
+{{std::string("2020-10-23 00:00:11.123456"),
std::string("1.1")},
+ std::string("2020-10-23 00:00:12.223456")},
+};
+
+static_cast(
+check_function(func_name,
input_types, data_set));
Review Comment:
```suggestion
static_cast(
check_function(func_name,
input_types, data_set, 6));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) The date_add function supports SECOND_MICROSECOND as interval type [doris]
linrrzqqq commented on code in PR #58665:
URL: https://github.com/apache/doris/pull/58665#discussion_r2584866139
##
be/test/vec/function/function_time_test.cpp:
##
@@ -1230,6 +1230,41 @@ TEST(VTimestampFunctionsTest, minute_second_add_v2_test)
{
}
}
+TEST(VTimestampFunctionsTest, second_microsecond_add_v2_test) {
+std::string func_name = "second_microsecond_add";
+
+InputTypeSet input_types = {PrimitiveType::TYPE_DATETIMEV2,
+Consted {PrimitiveType::TYPE_STRING}};
Review Comment:
```suggestion
InputTypeSet input_types = {{PrimitiveType::TYPE_DATETIMEV2, 6}
Consted {PrimitiveType::TYPE_STRING}};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) The date_add function supports SECOND_MICROSECOND as interval type [doris]
codeDing18 commented on PR #58665: URL: https://github.com/apache/doris/pull/58665#issuecomment-3605413911 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) The date_add function supports SECOND_MICROSECOND as interval type [doris]
zclllyybb commented on PR #58665: URL: https://github.com/apache/doris/pull/58665#issuecomment-3605399883 @linrrzqqq PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) The date_add function supports SECOND_MICROSECOND as interval type [doris]
codeDing18 commented on PR #58665: URL: https://github.com/apache/doris/pull/58665#issuecomment-3605355315 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) The date_add function supports SECOND_MICROSECOND as interval type [doris]
codeDing18 commented on PR #58665: URL: https://github.com/apache/doris/pull/58665#issuecomment-3605334033 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) The date_add function supports SECOND_MICROSECOND as interval type [doris]
hello-stephen commented on PR #58665: URL: https://github.com/apache/doris/pull/58665#issuecomment-3605333553 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
