Re: [PR] [Enhancement](nereids)support show snapshot [doris]
lsy3993 commented on PR #49274: URL: https://github.com/apache/doris/pull/49274#issuecomment-2736635838 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](nereids)support show snapshot [doris]
englefly merged PR #49274: URL: https://github.com/apache/doris/pull/49274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](nereids)support show snapshot [doris]
englefly commented on code in PR #49274:
URL: https://github.com/apache/doris/pull/49274#discussion_r2011146537
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/ShowSnapshotCommand.java:
##
@@ -0,0 +1,225 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.plans.commands;
+
+import org.apache.doris.backup.Repository;
+import org.apache.doris.catalog.Column;
+import org.apache.doris.catalog.Env;
+import org.apache.doris.catalog.ScalarType;
+import org.apache.doris.common.AnalysisException;
+import org.apache.doris.common.ErrorCode;
+import org.apache.doris.common.ErrorReport;
+import org.apache.doris.common.UserException;
+import org.apache.doris.mysql.privilege.PrivPredicate;
+import org.apache.doris.nereids.analyzer.UnboundSlot;
+import org.apache.doris.nereids.trees.expressions.And;
+import org.apache.doris.nereids.trees.expressions.ComparisonPredicate;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.literal.StringLikeLiteral;
+import org.apache.doris.nereids.trees.plans.PlanType;
+import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor;
+import org.apache.doris.qe.ConnectContext;
+import org.apache.doris.qe.ShowResultSet;
+import org.apache.doris.qe.ShowResultSetMetaData;
+import org.apache.doris.qe.StmtExecutor;
+
+import com.google.common.annotations.VisibleForTesting;
+import com.google.common.base.Strings;
+import com.google.common.collect.ImmutableList;
+
+import java.util.List;
+
+/**
+ * show snapshot command
+ */
+public class ShowSnapshotCommand extends ShowCommand {
+/**
+ * only remote and local type
+ */
+public enum SnapshotType {
+REMOTE,
+LOCAL
+}
+
+public static final ImmutableList SNAPSHOT_ALL = new
ImmutableList.Builder()
+.add("Snapshot").add("Timestamp").add("Status")
+.build();
+public static final ImmutableList SNAPSHOT_DETAIL = new
ImmutableList.Builder()
+
.add("Snapshot").add("Timestamp").add("Database").add("Details").add("Status")
Review Comment:
SNAPSHOT_DETAIL contains all columns, but SNAPSHOT_ALL is not.
Is SNAPSHOT_ALL a proper name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](nereids)support show snapshot [doris]
github-actions[bot] commented on PR #49274: URL: https://github.com/apache/doris/pull/49274#issuecomment-2739423624 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](nereids)support show snapshot [doris]
github-actions[bot] commented on PR #49274: URL: https://github.com/apache/doris/pull/49274#issuecomment-2739423709 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](nereids)support show snapshot [doris]
doris-robot commented on PR #49274: URL: https://github.com/apache/doris/pull/49274#issuecomment-2739170901 ClickBench: Total hot run time: 31.07 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit af083d2765370b7ca9883ad024ba27f3fe0592b8, data reload: false query1 0.040.040.03 query2 0.130.100.10 query3 0.240.200.20 query4 1.600.200.20 query5 0.580.580.60 query6 1.180.720.72 query7 0.020.010.02 query8 0.050.040.03 query9 0.600.530.51 query10 0.580.590.58 query11 0.160.110.10 query12 0.140.110.11 query13 0.620.600.60 query14 2.842.742.70 query15 0.940.860.85 query16 0.390.390.38 query17 1.010.990.98 query18 0.210.200.20 query19 1.931.891.94 query20 0.020.010.02 query21 15.36 0.940.54 query22 0.741.180.65 query23 14.98 1.390.64 query24 7.101.860.62 query25 0.530.230.18 query26 0.630.160.14 query27 0.050.050.05 query28 9.320.830.43 query29 12.72 4.023.31 query30 0.250.080.06 query31 2.840.600.40 query32 3.230.550.48 query33 3.022.983.10 query34 15.68 5.114.50 query35 4.474.504.54 query36 0.650.500.48 query37 0.080.070.06 query38 0.060.040.04 query39 0.030.030.03 query40 0.180.130.13 query41 0.080.030.02 query42 0.040.020.02 query43 0.030.040.03 Total cold run time: 105.35 s Total hot run time: 31.07 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](nereids)support show snapshot [doris]
doris-robot commented on PR #49274: URL: https://github.com/apache/doris/pull/49274#issuecomment-2739160720 TPC-DS: Total hot run time: 184724 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit af083d2765370b7ca9883ad024ba27f3fe0592b8, data reload: false query1 1011490 483 483 query2 6531192118871887 query3 6794217 217 217 query4 26883 23530 22958 22958 query5 4296628 468 468 query6 300 200 196 196 query7 4595494 296 296 query8 302 251 255 251 query9 8621259025842584 query10 450 315 255 255 query11 15401 15243 14898 14898 query12 177 113 102 102 query13 1650521 409 409 query14 10108 630963306309 query15 220 198 176 176 query16 7657625 426 426 query17 1351715 564 564 query18 1986398 311 311 query19 193 185 161 161 query20 122 118 121 118 query21 213 123 107 107 query22 4365407442494074 query23 33865 32929 32990 32929 query24 7911237723532353 query25 523 482 377 377 query26 1227269 153 153 query27 2580488 324 324 query28 4345241823792379 query29 701 551 423 423 query30 277 216 188 188 query31 967 844 762 762 query32 70 64 62 62 query33 548 363 304 304 query34 768 881 491 491 query35 780 821 732 732 query36 952 964 909 909 query37 145 104 71 71 query38 4206432640724072 query39 1449139713761376 query40 204 119 110 110 query41 56 53 51 51 query42 124 104 104 104 query43 512 514 478 478 query44 1278809 789 789 query45 171 174 164 164 query46 820 1026617 617 query47 1736176316801680 query48 371 448 321 321 query49 773 491 399 399 query50 696 718 417 417 query51 4170420541374137 query52 105 101 94 94 query53 225 260 192 192 query54 494 497 396 396 query55 79 80 85 80 query56 272 248 268 248 query57 1140113110751075 query58 244 238 233 233 query59 2779270324832483 query60 284 279 261 261 query61 121 119 111 111 query62 783 733 674 674 query63 241 192 192 192 query64 42441007668 668 query65 4432431743464317 query66 1057407 298 298 query67 15688 15563 15272 15272 query68 8689872 498 498 query69 457 303 269 269 query70 1232117511171117 query71 486 287 259 259 query72 5297361037793610 query73 800 733 343 343 query74 8946918389788978 query75 3948314526752675 query76 36811189756 756 query77 789 360 371 360 query78 10002 10086 92519251 query79 2622820 606 606 query80 677 506 441 441 query81 486 256 219 219 query82 608 127 94 94 query83 215 173 153 153 query84 286 95 80 80 query85 797 345 304 304 query86 338 304 306 304 query87 4636452243704370 query88 3359224522282228 query89 395 311 287 287 query90 1969226 216 216 query91 136 140 109 109 query92 78 60 56 56 query93 11941028579 579 query94 664 418 285 285 query95 344 268 259 259 query96 478 561 284 284 query97 3323333832393239 query98 266 203 201 201 query99 1439134412781278 Total cold run time: 276276 ms Total hot run time: 184724 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [Enhancement](nereids)support show snapshot [doris]
doris-robot commented on PR #49274: URL: https://github.com/apache/doris/pull/49274#issuecomment-2739149650 TPC-H: Total hot run time: 32467 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit af083d2765370b7ca9883ad024ba27f3fe0592b8, data reload: false -- Round 1 -- q1 24162 517350545054 q2 2040299 188 188 q3 10370 1270691 691 q4 10218 998 514 514 q5 8043241723992399 q6 191 167 137 137 q7 914 740 606 606 q8 9308130111041104 q9 4922486947204720 q10 6803231018851885 q11 470 273 259 259 q12 348 347 220 220 q13 17756 370531163116 q14 230 225 209 209 q15 521 482 480 480 q16 621 629 574 574 q17 562 859 356 356 q18 6684653162856285 q19 1222946 535 535 q20 325 325 208 208 q21 2797219119321932 q22 10611002995 995 Total cold run time: 109568 ms Total hot run time: 32467 ms - Round 2, with runtime_filter_mode=off - q1 5180514451675144 q2 239 329 231 231 q3 2154270623022302 q4 1399181513871387 q5 4238421244504212 q6 210 166 124 124 q7 2057193418041804 q8 2640264825782578 q9 7174722871857185 q10 3018322127902790 q11 587 506 493 493 q12 675 767 629 629 q13 3442386732733273 q14 272 300 271 271 q15 530 476 470 470 q16 665 694 635 635 q17 1181160313351335 q18 7864754474347434 q19 826 858 1135858 q20 1979206819021902 q21 5442502246324632 q22 1046100610101006 Total cold run time: 52818 ms Total hot run time: 50695 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](nereids)support show snapshot [doris]
lsy3993 commented on PR #49274: URL: https://github.com/apache/doris/pull/49274#issuecomment-2739125919 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](nereids)support show snapshot [doris]
lsy3993 commented on PR #49274: URL: https://github.com/apache/doris/pull/49274#issuecomment-2736756006 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
