Re: [PR] [Enhancement] (nereids)implement grantCommand in nereids [doris]
starocean999 merged PR #50203: URL: https://github.com/apache/doris/pull/50203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement] (nereids)implement grantCommand in nereids [doris]
github-actions[bot] commented on PR #50203: URL: https://github.com/apache/doris/pull/50203#issuecomment-2890109238 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement] (nereids)implement grantCommand in nereids [doris]
github-actions[bot] commented on PR #50203: URL: https://github.com/apache/doris/pull/50203#issuecomment-2890109382 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement] (nereids)implement grantCommand in nereids [doris]
codeDing18 commented on code in PR #50203:
URL: https://github.com/apache/doris/pull/50203#discussion_r2092404919
##
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##
@@ -6966,6 +6993,124 @@ public LogicalPlan
visitTransactionRollback(DorisParser.TransactionRollbackConte
return new TransactionRollbackCommand();
}
+@Override
+public LogicalPlan
visitGrantTablePrivilege(DorisParser.GrantTablePrivilegeContext ctx) {
+List accessPrivilegeWithCols =
visitPrivilegeList(ctx.privilegeList());
+
+List parts =
visitMultipartIdentifierOrAsterisk(ctx.multipartIdentifierOrAsterisk());
+int size = parts.size();
+
+if (size < 1) {
+throw new AnalysisException("grant table privilege statement
missing parameters");
+}
+
+TablePattern tablePattern = null;
+if (size == 1) {
+String db = parts.get(size - 1);
+tablePattern = new TablePattern(db, "");
+}
+
+if (size == 2) {
+String db = parts.get(size - 2);
+String tbl = parts.get(size - 1);
+tablePattern = new TablePattern(db, tbl);
+}
+
+if (size == 3) {
+String ctl = parts.get(size - 3);
+String db = parts.get(size - 2);
+String tbl = parts.get(size - 1);
+tablePattern = new TablePattern(ctl, db, tbl);
+}
+
+Optional userIdentity = ctx.userIdentify() == null
+? Optional.empty() :
Optional.of(visitUserIdentify(ctx.userIdentify()));
+Optional role = ctx.ROLE() == null
Review Comment:
I think wo can don't worry about it.Because antlr generated class will parse
the syntax. If we use user and role together or don't use user and role, the
generated class that parsing the syntax will throw exception in parse phase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement] (nereids)implement grantCommand in nereids [doris]
codeDing18 commented on PR #50203: URL: https://github.com/apache/doris/pull/50203#issuecomment-2888032216 run external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement] (nereids)implement grantCommand in nereids [doris]
doris-robot commented on PR #50203: URL: https://github.com/apache/doris/pull/50203#issuecomment-2876871838 ClickBench: Total hot run time: 28.5 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit b536bd55e92d585ae0f92fecc055670a4076a9b0, data reload: false query1 0.030.040.03 query2 0.130.100.11 query3 0.250.200.20 query4 1.590.200.11 query5 0.550.540.54 query6 1.180.720.72 query7 0.030.010.01 query8 0.040.030.04 query9 0.570.510.51 query10 0.580.580.56 query11 0.160.100.11 query12 0.150.110.11 query13 0.610.580.60 query14 0.780.810.81 query15 0.880.840.86 query16 0.380.410.38 query17 1.041.051.04 query18 0.220.210.22 query19 1.971.831.83 query20 0.010.010.01 query21 15.40 0.880.54 query22 0.761.110.64 query23 15.02 1.350.63 query24 6.502.250.31 query25 0.300.080.09 query26 0.600.160.13 query27 0.050.060.05 query28 9.350.920.44 query29 12.53 3.983.29 query30 0.250.090.07 query31 2.810.600.39 query32 3.220.550.47 query33 3.103.033.10 query34 15.71 5.064.44 query35 4.514.574.49 query36 0.670.490.47 query37 0.090.070.06 query38 0.050.040.04 query39 0.030.020.02 query40 0.180.140.12 query41 0.080.020.02 query42 0.040.020.03 query43 0.040.030.03 Total cold run time: 102.44 s Total hot run time: 28.5 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement] (nereids)implement grantCommand in nereids [doris]
doris-robot commented on PR #50203: URL: https://github.com/apache/doris/pull/50203#issuecomment-2876847653 TPC-DS: Total hot run time: 193389 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit b536bd55e92d585ae0f92fecc055670a4076a9b0, data reload: false query1 1424107610781076 query2 6316184818731848 query3 10999 445242224222 query4 53928 25393 23140 23140 query5 4961541 454 454 query6 327 205 196 196 query7 4887497 301 301 query8 333 261 252 252 query9 5382268426642664 query10 448 333 266 266 query11 15066 14999 14831 14831 query12 167 110 105 105 query13 1032542 406 406 query14 10064 637764866377 query15 218 209 175 175 query16 7112658 508 508 query17 1105770 593 593 query18 1600414 321 321 query19 206 198 168 168 query20 137 139 127 127 query21 202 131 109 109 query22 4388434742704270 query23 34284 33552 34006 33552 query24 6576245424202420 query25 484 480 406 406 query26 710 272 157 157 query27 2269510 346 346 query28 3034217921522152 query29 598 604 446 446 query30 271 223 185 185 query31 852 854 773 773 query32 79 70 65 65 query33 509 375 309 309 query34 1167879 541 541 query35 800 844 740 740 query36 980 1017931 931 query37 118 98 73 73 query38 4339438242924292 query39 1534146414251425 query40 227 124 108 108 query41 55 53 50 50 query42 128 114 115 114 query43 511 516 493 493 query44 1368855 854 854 query45 182 175 165 165 query46 852 1034666 666 query47 1885187318101810 query48 391 425 324 324 query49 685 534 445 445 query50 658 712 407 407 query51 4355431042114211 query52 110 115 98 98 query53 231 265 191 191 query54 632 596 520 520 query55 90 81 83 81 query56 316 318 313 313 query57 1213121311321132 query58 268 272 261 261 query59 2836285327162716 query60 329 326 312 312 query61 132 130 126 126 query62 728 748 678 678 query63 225 176 180 176 query64 19171034680 680 query65 4289423542484235 query66 773 406 305 305 query67 15938 15621 15468 15468 query68 7012915 531 531 query69 535 317 265 265 query70 1189112511501125 query71 505 332 310 310 query72 5735494449854944 query73 1524718 360 360 query74 8955888188898881 query75 4061325027332733 query76 41451185754 754 query77 704 357 296 296 query78 10165 10091 94139413 query79 2695799 583 583 query80 696 503 445 445 query81 482 264 223 223 query82 586 137 99 99 query83 248 252 227 227 query84 289 111 82 82 query85 779 353 311 311 query86 357 316 282 282 query87 4418444643484348 query88 3426228122862281 query89 407 317 283 283 query90 1803209 205 205 query91 146 141 112 112 query92 72 59 57 57 query93 2360932 577 577 query94 657 402 315 315 query95 370 298 287 287 query96 491 640 287 287 query97 3195323530973097 query98 245 214 201 201 query99 1461142813141314 Total cold run time: 299943 ms Total hot run time: 193389 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [Enhancement] (nereids)implement grantCommand in nereids [doris]
doris-robot commented on PR #50203: URL: https://github.com/apache/doris/pull/50203#issuecomment-2876797800 TPC-H: Total hot run time: 34000 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit b536bd55e92d585ae0f92fecc055670a4076a9b0, data reload: false -- Round 1 -- q1 26460 499149704970 q2 2064280 181 181 q3 10391 1266717 717 q4 10222 1021514 514 q5 7540237423482348 q6 186 166 131 131 q7 920 737 608 608 q8 9307128710871087 q9 6952515251215121 q10 6864230719161916 q11 509 284 272 272 q12 348 348 212 212 q13 17769 363330843084 q14 231 226 210 210 q15 523 500 493 493 q16 416 438 379 379 q17 593 866 355 355 q18 7616733272917291 q19 1398959 546 546 q20 341 330 220 220 q21 4066330823692369 q22 10401040976 976 Total cold run time: 115756 ms Total hot run time: 34000 ms - Round 2, with runtime_filter_mode=off - q1 5066519250675067 q2 252 325 237 237 q3 2145262423022302 q4 1332183413221322 q5 4442439944584399 q6 211 174 132 132 q7 2021190517701770 q8 2598248325342483 q9 7233719168986898 q10 3082319327622762 q11 592 526 488 488 q12 691 757 631 631 q13 3492388133013301 q14 278 302 274 274 q15 528 491 488 488 q16 460 476 442 442 q17 1133158313741374 q18 7751766274927492 q19 790 835 848 835 q20 1994204018371837 q21 4995491746544654 q22 1076108310801080 Total cold run time: 52162 ms Total hot run time: 50268 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement] (nereids)implement grantCommand in nereids [doris]
codeDing18 commented on PR #50203: URL: https://github.com/apache/doris/pull/50203#issuecomment-2876574608 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement] (nereids)implement grantCommand in nereids [doris]
codeDing18 commented on PR #50203: URL: https://github.com/apache/doris/pull/50203#issuecomment-2875156546 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement] (nereids)implement grantCommand in nereids [doris]
codeDing18 commented on PR #50203: URL: https://github.com/apache/doris/pull/50203#issuecomment-2874966221 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement] (nereids)implement grantCommand in nereids [doris]
codeDing18 commented on PR #50203: URL: https://github.com/apache/doris/pull/50203#issuecomment-2874731308 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement] (nereids)implement grantCommand in nereids [doris]
doris-robot commented on PR #50203: URL: https://github.com/apache/doris/pull/50203#issuecomment-2817540710 ClickBench: Total hot run time: 30.06 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 44332a447f7fe3327b102356eb7e6b96399fdeb3, data reload: false query1 0.040.040.03 query2 0.120.110.11 query3 0.240.210.20 query4 1.600.190.19 query5 0.600.590.62 query6 1.190.710.72 query7 0.020.020.02 query8 0.040.040.04 query9 0.560.530.51 query10 0.560.570.56 query11 0.160.110.11 query12 0.140.110.11 query13 0.620.590.61 query14 1.171.261.17 query15 0.880.850.83 query16 0.390.390.38 query17 1.021.031.06 query18 0.220.200.20 query19 1.881.821.83 query20 0.020.010.02 query21 15.41 0.900.55 query22 0.751.200.92 query23 14.75 1.400.63 query24 6.862.030.98 query25 0.470.210.11 query26 0.590.170.15 query27 0.050.060.05 query28 9.560.840.42 query29 12.56 4.033.34 query30 0.260.090.06 query31 2.810.600.39 query32 3.250.540.45 query33 3.093.073.03 query34 15.73 5.104.47 query35 4.574.514.51 query36 0.660.500.48 query37 0.090.060.06 query38 0.040.050.04 query39 0.030.020.03 query40 0.180.130.12 query41 0.080.030.02 query42 0.030.030.02 query43 0.040.040.03 Total cold run time: 103.33 s Total hot run time: 30.06 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement] (nereids)implement grantCommand in nereids [doris]
hello-stephen commented on PR #50203: URL: https://github.com/apache/doris/pull/50203#issuecomment-2817567203 # BE Regression P0 && UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/50203_44332a447f7fe3327b102356eb7e6b96399fdeb3_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/50203_44332a447f7fe3327b102356eb7e6b96399fdeb3_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 23.39% (6276/26829) | | Line Coverage | 15.98% (47562/297648) | | Region Coverage | 15.10% (27634/182988) | | Branch Coverage | 11.13% (11476/103098) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement] (nereids)implement grantCommand in nereids [doris]
doris-robot commented on PR #50203: URL: https://github.com/apache/doris/pull/50203#issuecomment-2817536469 TPC-DS: Total hot run time: 192449 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 44332a447f7fe3327b102356eb7e6b96399fdeb3, data reload: false query1 1384109010371037 query2 6252178617541754 query3 11038 447243434343 query4 55267 25272 23157 23157 query5 5036559 453 453 query6 347 208 206 206 query7 4932489 291 291 query8 315 250 221 221 query9 5618253625482536 query10 408 295 253 253 query11 15044 15113 14740 14740 query12 159 107 110 107 query13 1072515 368 368 query14 10161 630263876302 query15 202 191 183 183 query16 7082685 466 466 query17 1082749 596 596 query18 1616421 326 326 query19 210 206 176 176 query20 126 121 129 121 query21 214 126 110 110 query22 4480446544764465 query23 34174 33505 33365 33365 query24 6740241024372410 query25 463 474 441 441 query26 711 267 164 164 query27 2330507 342 342 query28 3017211521152115 query29 578 584 429 429 query30 275 222 185 185 query31 867 861 774 774 query32 74 61 65 61 query33 465 374 331 331 query34 783 870 543 543 query35 817 850 766 766 query36 922 987 920 920 query37 109 100 77 77 query38 4159437741274127 query39 1502161614581458 query40 212 118 135 118 query41 52 54 51 51 query42 122 104 103 103 query43 493 485 471 471 query44 1368831 825 825 query45 178 182 175 175 query46 927 1030649 649 query47 1867189317731773 query48 372 408 302 302 query49 655 522 439 439 query50 693 718 424 424 query51 4278433042334233 query52 114 104 103 103 query53 231 269 190 190 query54 588 580 511 511 query55 83 84 92 84 query56 334 319 296 296 query57 1160120911331133 query58 260 257 256 256 query59 2774278227482748 query60 318 323 305 305 query61 129 121 135 121 query62 760 789 727 727 query63 231 192 202 192 query64 18641030679 679 query65 4292424442114211 query66 759 401 308 308 query67 15843 15609 15444 15444 query68 8031909 511 511 query69 546 286 262 262 query70 1261113211151115 query71 518 320 302 302 query72 5466495746994699 query73 1410642 346 346 query74 8964911189378937 query75 3852316526802680 query76 42151204792 792 query77 644 369 278 278 query78 10124 999893399339 query79 2145808 554 554 query80 580 580 453 453 query81 481 254 222 222 query82 452 123 98 98 query83 253 248 240 240 query84 295 106 79 79 query85 783 345 303 303 query86 390 305 281 281 query87 4445434343894343 query88 3554224722402240 query89 402 316 281 281 query90 1913215 223 215 query91 139 140 109 109 query92 73 64 57 57 query93 1670978 574 574 query94 683 406 322 322 query95 360 299 291 291 query96 475 621 277 277 query97 3171322031823182 query98 238 203 196 196 query99 1435140512811281 Total cold run time: 299956 ms Total hot run time: 192449 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [Enhancement] (nereids)implement grantCommand in nereids [doris]
doris-robot commented on PR #50203: URL: https://github.com/apache/doris/pull/50203#issuecomment-2817525706 TPC-H: Total hot run time: 33794 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 44332a447f7fe3327b102356eb7e6b96399fdeb3, data reload: false -- Round 1 -- q1 26191 498750584987 q2 2083279 209 209 q3 10353 1211669 669 q4 10230 1018547 547 q5 7546239222932293 q6 181 163 135 135 q7 912 789 630 630 q8 9318127610611061 q9 6795508550875085 q10 6818230418841884 q11 476 280 273 273 q12 356 347 220 220 q13 17802 367030663066 q14 216 219 206 206 q15 521 478 491 478 q16 437 459 406 406 q17 589 847 368 368 q18 7500717571227122 q19 1316960 539 539 q20 344 322 221 221 q21 3870336324232423 q22 1047993 972 972 Total cold run time: 114901 ms Total hot run time: 33794 ms - Round 2, with runtime_filter_mode=off - q1 5099505950845059 q2 242 335 231 231 q3 2131263322732273 q4 1421182214031403 q5 4448443044774430 q6 213 169 127 127 q7 1950192117881788 q8 2577257825392539 q9 7252721969566956 q10 3062316727292729 q11 574 501 492 492 q12 691 742 593 593 q13 3501392432803280 q14 280 303 267 267 q15 523 491 476 476 q16 481 518 456 456 q17 1132153213801380 q18 7624745173967396 q19 850 816 915 816 q20 2060203919061906 q21 5165481947954795 q22 1079104010431040 Total cold run time: 52355 ms Total hot run time: 50432 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement] (nereids)implement grantCommand in nereids [doris]
starocean999 commented on PR #50203: URL: https://github.com/apache/doris/pull/50203#issuecomment-2817492707 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement] (nereids)implement grantCommand in nereids [doris]
Thearas commented on PR #50203: URL: https://github.com/apache/doris/pull/50203#issuecomment-2817138067 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
