Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
starocean999 merged PR #42979: URL: https://github.com/apache/doris/pull/42979 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
Vallishp commented on PR #42979: URL: https://github.com/apache/doris/pull/42979#issuecomment-2483773831 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
Vallishp commented on PR #42979: URL: https://github.com/apache/doris/pull/42979#issuecomment-2482795478 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
github-actions[bot] commented on PR #42979: URL: https://github.com/apache/doris/pull/42979#issuecomment-2483039845 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
github-actions[bot] commented on PR #42979: URL: https://github.com/apache/doris/pull/42979#issuecomment-2483039777 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
Vallishp commented on PR #42979: URL: https://github.com/apache/doris/pull/42979#issuecomment-2482533440 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
Vallishp commented on PR #42979: URL: https://github.com/apache/doris/pull/42979#issuecomment-2481362254 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
Vallishp commented on PR #42979: URL: https://github.com/apache/doris/pull/42979#issuecomment-2480930871 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
Vallishp commented on PR #42979: URL: https://github.com/apache/doris/pull/42979#issuecomment-2479468975 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
Vallishp commented on PR #42979: URL: https://github.com/apache/doris/pull/42979#issuecomment-2478530088 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
Vallishp commented on PR #42979: URL: https://github.com/apache/doris/pull/42979#issuecomment-2478496848 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
Vallishp commented on PR #42979: URL: https://github.com/apache/doris/pull/42979#issuecomment-2478214294 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
Vallishp commented on PR #42979: URL: https://github.com/apache/doris/pull/42979#issuecomment-2478022897 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
starocean999 commented on code in PR #42979:
URL: https://github.com/apache/doris/pull/42979#discussion_r1843150004
##
fe/fe-core/src/main/java/org/apache/doris/blockrule/SqlBlockRuleMgr.java:
##
@@ -90,6 +91,21 @@ public List
getSqlBlockRule(ShowSqlBlockRuleStmt stmt) throws Anal
return Lists.newArrayList(nameToSqlBlockRuleMap.values());
}
+/**
+ * Get SqlBlockRule by show command.
+ **/
+public List getSqlBlockRule(ShowSqlBlockRuleCommand cmd)
throws AnalysisException {
Review Comment:
better to use String as parameter and change the old code to call the new
function to remove duplicate code
```suggestion
public List getSqlBlockRule(String ruleName) throws
AnalysisException {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
doris-robot commented on PR #42979: URL: https://github.com/apache/doris/pull/42979#issuecomment-2456267496 ClickBench: Total hot run time: 32.66 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 3ff2c070f9b1f737c107f63816ea5b58b47d2265, data reload: false query1 0.030.030.03 query2 0.070.030.03 query3 0.240.070.07 query4 1.630.110.10 query5 0.420.390.41 query6 1.150.680.65 query7 0.020.010.02 query8 0.040.030.03 query9 0.570.500.49 query10 0.540.540.56 query11 0.150.110.11 query12 0.140.120.11 query13 0.600.590.60 query14 2.822.882.73 query15 0.900.820.82 query16 0.380.380.38 query17 1.081.001.04 query18 0.210.200.20 query19 1.891.881.92 query20 0.010.010.02 query21 15.35 0.590.57 query22 2.602.541.75 query23 17.05 0.840.85 query24 3.561.791.24 query25 0.240.050.13 query26 0.570.140.13 query27 0.040.030.04 query28 9.691.091.07 query29 12.56 3.273.27 query30 0.250.050.05 query31 2.890.390.37 query32 3.280.450.46 query33 2.983.023.10 query34 17.07 4.474.45 query35 4.534.444.43 query36 0.650.480.48 query37 0.090.060.06 query38 0.050.030.04 query39 0.030.020.02 query40 0.160.110.12 query41 0.080.030.02 query42 0.040.020.02 query43 0.030.040.03 Total cold run time: 106.68 s Total hot run time: 32.66 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
doris-robot commented on PR #42979: URL: https://github.com/apache/doris/pull/42979#issuecomment-2456261934 TPC-DS: Total hot run time: 195818 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 3ff2c070f9b1f737c107f63816ea5b58b47d2265, data reload: false query1 1212942 901 901 query2 6255204920572049 query3 10835 397140983971 query4 68411 28344 23487 23487 query5 4983456 448 448 query6 393 182 175 175 query7 5605296 291 291 query8 301 223 214 214 query9 9244266226242624 query10 450 256 257 256 query11 17458 15380 15861 15380 query12 159 101 99 99 query13 1569437 438 437 query14 10100 764869826982 query15 209 186 177 177 query16 7059442 485 442 query17 1021548 565 548 query18 1762301 294 294 query19 189 149 146 146 query20 113 113 112 112 query21 201 103 104 103 query22 4426436441914191 query23 34699 34752 34154 34154 query24 5981277527782775 query25 516 402 391 391 query26 646 157 157 157 query27 1688288 296 288 query28 4140243424002400 query29 704 432 437 432 query30 231 154 154 154 query31 985 812 818 812 query32 66 55 57 55 query33 423 263 273 263 query34 908 502 513 502 query35 854 725 740 725 query36 1076952 948 948 query37 115 73 73 73 query38 4366426742284228 query39 1461144914441444 query40 201 98 101 98 query41 48 44 49 44 query42 107 99 96 96 query43 560 491 487 487 query44 1209825 836 825 query45 181 163 170 163 query46 1121694 702 694 query47 1976182618341826 query48 406 314 327 314 query49 750 413 388 388 query50 795 404 389 389 query51 7310713670547054 query52 99 90 85 85 query53 248 177 179 177 query54 506 403 399 399 query55 74 75 79 75 query56 252 229 222 222 query57 1302117211591159 query58 210 194 198 194 query59 3272288829192888 query60 275 242 241 241 query61 121 111 107 107 query62 772 664 686 664 query63 214 188 185 185 query64 1353640 627 627 query65 3280321432363214 query66 698 301 297 297 query67 15960 15720 15623 15623 query68 3816591 590 590 query69 419 260 245 245 query70 1177114811421142 query71 350 249 249 249 query72 6178410239913991 query73 763 360 359 359 query74 9985900190509001 query75 3377264427002644 query76 1714119312101193 query77 462 282 273 273 query78 10355 951993869386 query79 2148587 594 587 query80 1413414 416 414 query81 536 239 245 239 query82 1289111 114 111 query83 248 141 158 141 query84 279 74 72 72 query85 1004298 289 289 query86 393 299 300 299 query87 4930462346534623 query88 3583218221632163 query89 413 284 287 284 query90 1960187 184 184 query91 133 100 105 100 query92 66 47 49 47 query93 2905556 546 546 query94 883 299 280 280 query95 341 247 243 243 query96 627 293 286 286 query97 2899269426862686 query98 210 203 200 200 query99 1619133112881288 Total cold run time: 320589 ms Total hot run time: 195818 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
doris-robot commented on PR #42979: URL: https://github.com/apache/doris/pull/42979#issuecomment-2456249481 TPC-H: Total hot run time: 40886 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 3ff2c070f9b1f737c107f63816ea5b58b47d2265, data reload: false -- Round 1 -- q1 17562 739872567256 q2 2045171 180 171 q3 10767 106411631064 q4 10513 906 822 822 q5 307830593059 q6 241 141 146 141 q7 1009612 586 586 q8 9345187319901873 q9 6585640363936393 q10 7081244224272427 q11 477 265 258 258 q12 409 219 214 214 q13 17772 302529782978 q14 244 211 211 211 q15 570 513 526 513 q16 658 581 582 581 q17 978 505 561 505 q18 7339673866356635 q19 13311065964 964 q20 475 183 177 177 q21 3982329630743074 q22 1147984 1005984 Total cold run time: 108307 ms Total hot run time: 40886 ms - Round 2, with runtime_filter_mode=off - q1 7322722072387220 q2 323 226 230 226 q3 2938295829292929 q4 2041180718171807 q5 5714579957795779 q6 232 147 147 147 q7 2239185017881788 q8 3359350734363436 q9 8928895588868886 q10 3570354735483547 q11 596 504 506 504 q12 806 665 642 642 q13 10376 318031673167 q14 304 277 274 274 q15 575 520 513 513 q16 676 638 656 638 q17 1876166816341634 q18 8348774276747674 q19 1704169214161416 q20 2143190519161905 q21 5667540453675367 q22 1131103510471035 Total cold run time: 70868 ms Total hot run time: 60534 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
Vallishp commented on PR #42979: URL: https://github.com/apache/doris/pull/42979#issuecomment-2456216352 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
Vallishp commented on PR #42979: URL: https://github.com/apache/doris/pull/42979#issuecomment-2456215997 run build all -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
LiBinfeng-01 commented on PR #42979: URL: https://github.com/apache/doris/pull/42979#issuecomment-2456081701 run external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
LiBinfeng-01 commented on PR #42979: URL: https://github.com/apache/doris/pull/42979#issuecomment-2451594732 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
doris-robot commented on PR #42979: URL: https://github.com/apache/doris/pull/42979#issuecomment-2451284254 ClickBench: Total hot run time: 31.24 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit e4a730ad824ec1ec95b81067de9cfd47deb3db97, data reload: false query1 0.030.030.03 query2 0.070.020.03 query3 0.230.070.07 query4 1.650.100.10 query5 0.400.390.40 query6 1.170.650.65 query7 0.020.010.01 query8 0.040.030.03 query9 0.580.500.49 query10 0.560.540.58 query11 0.140.100.11 query12 0.130.100.10 query13 0.620.590.60 query14 2.702.732.74 query15 0.900.830.82 query16 0.390.390.37 query17 1.061.001.01 query18 0.200.190.19 query19 1.981.801.90 query20 0.010.010.02 query21 15.38 0.590.59 query22 2.411.761.60 query23 16.94 1.150.82 query24 3.222.320.13 query25 0.180.060.05 query26 0.410.140.13 query27 0.040.050.04 query28 10.37 1.081.06 query29 12.56 3.193.16 query30 0.240.060.05 query31 2.890.380.36 query32 3.290.460.45 query33 2.973.003.07 query34 17.14 4.464.46 query35 4.474.544.56 query36 0.680.470.50 query37 0.080.050.05 query38 0.050.030.03 query39 0.030.020.02 query40 0.160.130.12 query41 0.080.020.02 query42 0.030.020.02 query43 0.040.030.03 Total cold run time: 106.54 s Total hot run time: 31.24 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
doris-robot commented on PR #42979: URL: https://github.com/apache/doris/pull/42979#issuecomment-2451280326 TPC-DS: Total hot run time: 195637 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit e4a730ad824ec1ec95b81067de9cfd47deb3db97, data reload: false query1 1204889 916 889 query2 6246202720462027 query3 10775 398739193919 query4 68041 29074 23696 23696 query5 4912473 444 444 query6 409 195 175 175 query7 5677300 298 298 query8 298 227 220 220 query9 9309274427332733 query10 446 254 240 240 query11 17703 15518 15816 15518 query12 157 108 111 108 query13 1564434 430 430 query14 10602 720671147114 query15 196 175 178 175 query16 7066437 464 437 query17 1023554 551 551 query18 1781285 289 285 query19 199 146 149 146 query20 114 109 108 108 query21 205 101 99 99 query22 4557441943994399 query23 34550 33997 33869 33869 query24 6053269427382694 query25 502 388 389 388 query26 658 156 154 154 query27 1709290 284 284 query28 4273246624452445 query29 685 431 431 431 query30 239 164 154 154 query31 969 812 770 770 query32 67 53 53 53 query33 400 263 268 263 query34 898 514 521 514 query35 883 729 726 726 query36 1048951 937 937 query37 125 75 70 70 query38 4359427942124212 query39 1499146314311431 query40 201 101 100 100 query41 49 44 45 44 query42 107 96 98 96 query43 537 497 492 492 query44 1159808 813 808 query45 184 163 164 163 query46 1134711 685 685 query47 1976185319171853 query48 429 316 330 316 query49 739 425 403 403 query50 809 393 405 393 query51 7252722669996999 query52 101 91 92 91 query53 253 188 207 188 query54 515 395 408 395 query55 76 72 75 72 query56 244 227 231 227 query57 1294120111601160 query58 201 201 201 201 query59 3196309429302930 query60 280 247 237 237 query61 103 100 104 100 query62 784 687 664 664 query63 214 191 180 180 query64 1374614 589 589 query65 3291318331803180 query66 738 304 292 292 query67 15876 15480 15718 15480 query68 3067605 607 605 query69 408 255 248 248 query70 1202114811271127 query71 373 255 255 255 query72 6095395439153915 query73 766 363 357 357 query74 10009 895290068952 query75 3366264526732645 query76 1512108311061083 query77 479 291 264 264 query78 10358 941993329332 query79 1211598 607 598 query80 804 409 431 409 query81 510 236 241 236 query82 1354117 116 116 query83 160 139 135 135 query84 281 68 68 68 query85 833 277 283 277 query86 324 298 294 294 query87 4778476146614661 query88 3460221821672167 query89 410 299 284 284 query90 2027195 184 184 query91 134 95 99 95 query92 58 48 54 48 query93 1322535 550 535 query94 773 283 286 283 query95 339 244 240 240 query96 604 275 288 275 query97 2912267527532675 query98 225 219 213 213 query99 1626132013171317 Total cold run time: 316297 ms Total hot run time: 195637 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
doris-robot commented on PR #42979: URL: https://github.com/apache/doris/pull/42979#issuecomment-2451271184 TPC-H: Total hot run time: 41360 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit e4a730ad824ec1ec95b81067de9cfd47deb3db97, data reload: false -- Round 1 -- q1 17757 747372527252 q2 2051166 158 158 q3 10676 108711591087 q4 10367 861 824 824 q5 7748311630553055 q6 234 144 143 143 q7 1003609 612 609 q8 9354194819701948 q9 6532645764976457 q10 7068239824012398 q11 467 256 252 252 q12 407 213 210 210 q13 17776 302229662966 q14 244 212 204 204 q15 557 526 515 515 q16 680 593 608 593 q17 1006552 562 552 q18 7418679667556755 q19 1325102110081008 q20 481 182 186 182 q21 3960319831843184 q22 1098100810181008 Total cold run time: 108209 ms Total hot run time: 41360 ms - Round 2, with runtime_filter_mode=off - q1 7264735872537253 q2 319 233 225 225 q3 3057294729782947 q4 2073187118251825 q5 5753582059275820 q6 229 138 137 137 q7 2283181717841784 q8 3425353634633463 q9 8925892388528852 q10 3620354935883549 q11 617 491 506 491 q12 836 633 596 596 q13 9518316132223161 q14 320 284 300 284 q15 563 515 513 513 q16 690 657 642 642 q17 1852161216291612 q18 8474780676527652 q19 1720153616201536 q20 2115187819031878 q21 5494538354475383 q22 1149104910491049 Total cold run time: 70296 ms Total hot run time: 60652 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
LiBinfeng-01 commented on PR #42979: URL: https://github.com/apache/doris/pull/42979#issuecomment-2451197467 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
Vallishp commented on code in PR #42979:
URL: https://github.com/apache/doris/pull/42979#discussion_r1824011062
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/ShowSqlBlockRuleCommand.java:
##
@@ -0,0 +1,81 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.plans.commands;
+
+import org.apache.doris.analysis.ShowSqlBlockRuleStmt;
+import org.apache.doris.analysis.StmtType;
+import org.apache.doris.blockrule.SqlBlockRule;
+import org.apache.doris.catalog.Env;
+import org.apache.doris.common.ErrorCode;
+import org.apache.doris.common.ErrorReport;
+import org.apache.doris.mysql.privilege.PrivPredicate;
+import org.apache.doris.nereids.trees.plans.PlanType;
+import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor;
+import org.apache.doris.qe.ConnectContext;
+import org.apache.doris.qe.ShowResultSet;
+import org.apache.doris.qe.StmtExecutor;
+
+import com.google.common.collect.Lists;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.util.List;
+
+/**
+ * show sql block rule command
+ */
+public class ShowSqlBlockRuleCommand extends Command implements NoForward {
+public static final Logger LOG =
LogManager.getLogger(ShowSqlBlockRuleCommand.class);
+private String ruleName; // optional
+
+/**
+ * constructor
+ */
+public ShowSqlBlockRuleCommand(String ruleName) {
+super(PlanType.SHOW_BLOCK_RULE_COMMAND);
+this.ruleName = ruleName;
+}
+
+public String getRuleName() {
+return ruleName;
+}
+
+@Override
+public void run(ConnectContext ctx, StmtExecutor executor) throws
Exception {
+// check auth
+if
(!Env.getCurrentEnv().getAccessManager().checkGlobalPriv(ConnectContext.get(),
PrivPredicate.ADMIN)) {
+
ErrorReport.reportAnalysisException(ErrorCode.ERR_SPECIFIC_ACCESS_DENIED_ERROR,
"ADMIN");
+}
+ShowSqlBlockRuleStmt showStmt = new ShowSqlBlockRuleStmt(ruleName);
+List> rows = Lists.newArrayList();
+List sqlBlockRules =
Env.getCurrentEnv().getSqlBlockRuleMgr().getSqlBlockRule(showStmt);
Review Comment:
thanks. updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
starocean999 commented on code in PR #42979:
URL: https://github.com/apache/doris/pull/42979#discussion_r1823823450
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/ShowSqlBlockRuleCommand.java:
##
@@ -0,0 +1,81 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.plans.commands;
+
+import org.apache.doris.analysis.ShowSqlBlockRuleStmt;
+import org.apache.doris.analysis.StmtType;
+import org.apache.doris.blockrule.SqlBlockRule;
+import org.apache.doris.catalog.Env;
+import org.apache.doris.common.ErrorCode;
+import org.apache.doris.common.ErrorReport;
+import org.apache.doris.mysql.privilege.PrivPredicate;
+import org.apache.doris.nereids.trees.plans.PlanType;
+import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor;
+import org.apache.doris.qe.ConnectContext;
+import org.apache.doris.qe.ShowResultSet;
+import org.apache.doris.qe.StmtExecutor;
+
+import com.google.common.collect.Lists;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.util.List;
+
+/**
+ * show sql block rule command
+ */
+public class ShowSqlBlockRuleCommand extends Command implements NoForward {
+public static final Logger LOG =
LogManager.getLogger(ShowSqlBlockRuleCommand.class);
+private String ruleName; // optional
+
+/**
+ * constructor
+ */
+public ShowSqlBlockRuleCommand(String ruleName) {
+super(PlanType.SHOW_BLOCK_RULE_COMMAND);
+this.ruleName = ruleName;
+}
+
+public String getRuleName() {
+return ruleName;
+}
+
+@Override
+public void run(ConnectContext ctx, StmtExecutor executor) throws
Exception {
+// check auth
+if
(!Env.getCurrentEnv().getAccessManager().checkGlobalPriv(ConnectContext.get(),
PrivPredicate.ADMIN)) {
+
ErrorReport.reportAnalysisException(ErrorCode.ERR_SPECIFIC_ACCESS_DENIED_ERROR,
"ADMIN");
+}
+ShowSqlBlockRuleStmt showStmt = new ShowSqlBlockRuleStmt(ruleName);
+List> rows = Lists.newArrayList();
+List sqlBlockRules =
Env.getCurrentEnv().getSqlBlockRuleMgr().getSqlBlockRule(showStmt);
Review Comment:
pls add a new getSqlBlockRule function without dependence of
ShowSqlBlockRuleStmt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
doris-robot commented on PR #42979: URL: https://github.com/apache/doris/pull/42979#issuecomment-2449085189 ClickBench: Total hot run time: 31.98 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 8e783dbfcd6429124ef09e1aa8bdf90d99b92730, data reload: false query1 0.040.030.03 query2 0.060.030.03 query3 0.220.060.06 query4 1.650.100.10 query5 0.430.410.42 query6 1.160.650.66 query7 0.020.010.02 query8 0.030.030.03 query9 0.570.490.50 query10 0.560.560.55 query11 0.140.100.11 query12 0.160.110.12 query13 0.610.590.59 query14 2.832.732.84 query15 0.900.820.82 query16 0.410.370.38 query17 0.991.051.07 query18 0.200.200.21 query19 1.901.902.00 query20 0.020.010.01 query21 15.37 0.570.55 query22 2.592.621.70 query23 17.02 0.900.73 query24 3.370.480.58 query25 0.300.110.17 query26 0.390.140.13 query27 0.040.030.04 query28 11.38 1.091.06 query29 12.60 3.243.27 query30 0.240.060.06 query31 2.870.370.38 query32 3.310.450.45 query33 2.983.003.04 query34 16.78 4.544.53 query35 4.534.544.59 query36 0.670.500.48 query37 0.080.060.05 query38 0.040.030.03 query39 0.030.020.02 query40 0.160.120.13 query41 0.070.020.02 query42 0.030.020.02 query43 0.030.030.02 Total cold run time: 107.78 s Total hot run time: 31.98 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
doris-robot commented on PR #42979: URL: https://github.com/apache/doris/pull/42979#issuecomment-2449080209 TPC-DS: Total hot run time: 196780 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 8e783dbfcd6429124ef09e1aa8bdf90d99b92730, data reload: false query1 12481002976 976 query2 6257198419991984 query3 11644 476448214764 query4 33758 23782 23556 23556 query5 4793457 437 437 query6 273 185 171 171 query7 4000293 295 293 query8 288 225 225 225 query9 9569262326132613 query10 472 257 260 257 query11 18176 15088 15181 15088 query12 145 105 98 98 query13 1559427 396 396 query14 8609740675327406 query15 287 185 186 185 query16 8158488 512 488 query17 1562596 585 585 query18 2153320 302 302 query19 364 163 160 160 query20 121 116 118 116 query21 204 108 106 106 query22 4961465447184654 query23 35528 33921 34097 33921 query24 11000 272228132722 query25 557 393 406 393 query26 754 160 157 157 query27 2255287 277 277 query28 7430242624102410 query29 655 416 411 411 query30 264 168 160 160 query31 1013779 771 771 query32 96 56 56 56 query33 759 261 272 261 query34 937 517 516 516 query35 1036885 889 885 query36 1094944 937 937 query37 127 76 76 76 query38 4446426543334265 query39 1455139913951395 query40 206 98 96 96 query41 46 46 48 46 query42 109 95 97 95 query43 523 484 471 471 query44 1229800 802 800 query45 182 168 163 163 query46 1132700 682 682 query47 1996181918681819 query48 425 322 319 319 query49 891 387 393 387 query50 807 380 396 380 query51 7207693469506934 query52 96 86 87 86 query53 249 179 180 179 query54 1092388 389 388 query55 74 72 74 72 query56 249 238 235 235 query57 1242118411551155 query58 225 205 197 197 query59 3132312329212921 query60 259 239 245 239 query61 103 98 99 98 query62 847 683 665 665 query63 209 183 183 183 query64 3832623 639 623 query65 3262321532743215 query66 814 333 298 298 query67 16003 15612 15690 15612 query68 4532542 533 533 query69 422 251 263 251 query70 1185113911471139 query71 323 259 253 253 query72 6047404139353935 query73 764 349 351 349 query74 10251 901889508950 query75 3440266026652660 query76 2662107510591059 query77 369 283 263 263 query78 10873 973495989598 query79 1107572 585 572 query80 677 413 432 413 query81 511 248 240 240 query82 1280114 117 114 query83 161 149 139 139 query84 240 68 66 66 query85 887 313 286 286 query86 320 272 298 272 query87 4782458447544584 query88 3174219621582158 query89 430 301 293 293 query90 1948185 181 181 query91 131 96 97 96 query92 56 47 47 47 query93 1073538 528 528 query94 707 283 287 283 query95 351 251 249 249 query96 617 279 283 279 query97 2865267526992675 query98 221 198 198 198 query99 1510131012861286 Total cold run time: 298364 ms Total hot run time: 196780 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th
Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
doris-robot commented on PR #42979: URL: https://github.com/apache/doris/pull/42979#issuecomment-2449068711 TPC-H: Total hot run time: 41433 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 8e783dbfcd6429124ef09e1aa8bdf90d99b92730, data reload: false -- Round 1 -- q1 17586 736072677267 q2 2052164 157 157 q3 10571 110211331102 q4 10234 861 887 861 q5 7729307730813077 q6 236 146 143 143 q7 1021601 608 601 q8 9342195820231958 q9 6611644964736449 q10 7112245024352435 q11 456 250 251 250 q12 410 213 209 209 q13 17779 303029952995 q14 241 208 208 208 q15 570 508 513 508 q16 669 594 592 592 q17 971 587 507 507 q18 7271673868126738 q19 13371045998 998 q20 465 180 181 180 q21 4027318332543183 q22 1161105010151015 Total cold run time: 107851 ms Total hot run time: 41433 ms - Round 2, with runtime_filter_mode=off - q1 7349728972407240 q2 325 223 232 223 q3 2957295229922952 q4 2074183617591759 q5 5744570857775708 q6 229 140 142 140 q7 2251186418351835 q8 3423363935413541 q9 8993902289748974 q10 3590355035453545 q11 585 480 494 480 q12 818 663 627 627 q13 10308 317232083172 q14 306 272 293 272 q15 577 523 528 523 q16 708 653 672 653 q17 1848166016481648 q18 8360789476127612 q19 1733160016301600 q20 2113182218801822 q21 5697551955315519 q22 1180105810611058 Total cold run time: 71168 ms Total hot run time: 60903 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
Vallishp commented on PR #42979: URL: https://github.com/apache/doris/pull/42979#issuecomment-2449036922 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids [doris]
doris-robot commented on PR #42979: URL: https://github.com/apache/doris/pull/42979#issuecomment-2449036770 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
