Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
hello-stephen commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2870904267 # BE UT Coverage Report Increment line coverage `47.95% (35/73)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/1b362cce2ae7613a212ecd3c44b08a57efe31b48_1b362cce2ae7613a212ecd3c44b08a57efe31b48/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/1b362cce2ae7613a212ecd3c44b08a57efe31b48_1b362cce2ae7613a212ecd3c44b08a57efe31b48/report/index.html) | Category | Coverage | |---|| | Function Coverage | 55.77% (14897/26712) | | Line Coverage | 44.58% (131826/295706) | | Region Coverage | 43.63% (66287/151921) | | Branch Coverage | 38.24% (33977/88846) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2870538586 TeamCity cloud ut coverage result: Function Coverage: 83.18% (1103/1326) Line Coverage: 66.09% (18561/28084) Region Coverage: 65.67% (9242/14073) Branch Coverage: 55.45% (4968/8960) Coverage Report: http://coverage.selectdb-in.cc/coverage/1b362cce2ae7613a212ecd3c44b08a57efe31b48_1b362cce2ae7613a212ecd3c44b08a57efe31b48_cloud/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2870491891 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2863033505 # BE UT Coverage Report Increment line coverage `47.95% (35/73)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/1b362cce2ae7613a212ecd3c44b08a57efe31b48_1b362cce2ae7613a212ecd3c44b08a57efe31b48/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/1b362cce2ae7613a212ecd3c44b08a57efe31b48_1b362cce2ae7613a212ecd3c44b08a57efe31b48/report/index.html) | Category | Coverage | |---|| | Function Coverage | 55.68% (14896/26754) | | Line Coverage | 44.49% (131375/295305) | | Region Coverage | 43.39% (66190/152559) | | Branch Coverage | 38.06% (33802/88812) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2862468224 TeamCity cloud ut coverage result: Function Coverage: 83.18% (1103/1326) Line Coverage: 66.09% (18560/28084) Region Coverage: 65.66% (9240/14073) Branch Coverage: 55.46% (4969/8960) Coverage Report: http://coverage.selectdb-in.cc/coverage/1b362cce2ae7613a212ecd3c44b08a57efe31b48_1b362cce2ae7613a212ecd3c44b08a57efe31b48_cloud/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2862422959 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
morrySnow commented on code in PR #47319: URL: https://github.com/apache/doris/pull/47319#discussion_r2001031767 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/TimeV2Literal.java: ## @@ -0,0 +1,275 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.expressions.literal; + +import org.apache.doris.analysis.LiteralExpr; +import org.apache.doris.nereids.exceptions.AnalysisException; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor; +import org.apache.doris.nereids.types.TimeV2Type; + +import java.time.LocalDateTime; + +/** + * Time literal in Nereids. + */ +public class TimeV2Literal extends Literal { +private static final LocalDateTime START_OF_A_DAY = LocalDateTime.of(0, 1, 1, 0, 0, 0); +private static final LocalDateTime END_OF_A_DAY = LocalDateTime.of(, 12, 31, 23, 59, 59, 99000); +private static final TimeV2Literal MIN_TIME = new TimeV2Literal(-838, 0, 0, 0, 0); +private static final TimeV2Literal MAX_TIME = new TimeV2Literal(838, 59, 59, 99, 6); + +protected int hour; +protected int minute; +protected int second; +protected int microsecond; +protected boolean negative; + +public TimeV2Literal(String s) { +this(TimeV2Type.of(0), s); Review Comment: this is not right, if we call `cast("01:01:01.123456" as time)` we should not use this ctor. the correct way is use ctor with two parameters `TimeV2Literal(String s, TimeType timeType)`. if we use the ctor with only String parameter, we should infer scale from the string literal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2739293418 # BE UT Coverage Report Increment line coverage `32.93% (27/82)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/e999a363568df997cf939d449ac1b8e844aa2b50_e999a363568df997cf939d449ac1b8e844aa2b50/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/e999a363568df997cf939d449ac1b8e844aa2b50_e999a363568df997cf939d449ac1b8e844aa2b50/report/index.html) | Category | Coverage | |---|| | Function Coverage | 48.81% (13072/26784) | | Line Coverage | 38.37% (112723/293744) | | Region Coverage | 37.16% (57300/154178) | | Branch Coverage | 32.26% (28802/89272) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2739127152 ClickBench: Total hot run time: 32.02 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit e999a363568df997cf939d449ac1b8e844aa2b50, data reload: false query1 0.040.030.03 query2 0.160.110.12 query3 0.340.190.20 query4 1.600.200.19 query5 0.610.620.64 query6 1.190.720.73 query7 0.020.020.01 query8 0.060.050.04 query9 0.630.520.52 query10 0.580.590.58 query11 0.240.130.12 query12 0.250.130.14 query13 0.640.630.62 query14 2.842.712.84 query15 1.020.870.89 query16 0.380.380.38 query17 1.041.051.05 query18 0.180.200.19 query19 1.922.031.87 query20 0.010.020.01 query21 15.36 0.970.67 query22 0.941.070.81 query23 14.69 1.530.76 query24 5.280.580.31 query25 0.160.100.08 query26 0.560.220.19 query27 0.090.090.09 query28 11.03 1.170.57 query29 12.53 4.093.44 query30 0.270.080.05 query31 2.830.640.43 query32 3.230.590.50 query33 3.063.073.02 query34 16.46 5.094.49 query35 4.484.504.49 query36 0.630.500.50 query37 0.180.180.17 query38 0.170.150.16 query39 0.050.050.04 query40 0.190.170.16 query41 0.100.050.06 query42 0.060.050.06 query43 0.060.050.04 Total cold run time: 106.16 s Total hot run time: 32.02 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2739058115 TeamCity cloud ut coverage result: Function Coverage: 83.09% (1081/1301) Line Coverage: 66.08% (18008/27253) Region Coverage: 65.44% (8868/13551) Branch Coverage: 55.28% (4774/8636) Coverage Report: http://coverage.selectdb-in.cc/coverage/e999a363568df997cf939d449ac1b8e844aa2b50_e999a363568df997cf939d449ac1b8e844aa2b50_cloud/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2739119487 TPC-DS: Total hot run time: 192305 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit e999a363568df997cf939d449ac1b8e844aa2b50, data reload: false query1 1395108910641064 query2 6238195619701956 query3 11033 462946754629 query4 26317 23472 23055 23055 query5 3449639 457 457 query6 283 195 192 192 query7 3978496 290 290 query8 283 244 237 237 query9 8528259925952595 query10 461 326 263 263 query11 15393 15278 14874 14874 query12 162 112 109 109 query13 1572537 417 417 query14 9865692966776677 query15 202 190 175 175 query16 7674640 501 501 query17 1158752 591 591 query18 2041439 326 326 query19 198 210 169 169 query20 134 129 132 129 query21 207 124 115 115 query22 4507437343004300 query23 34240 33745 33649 33649 query24 7766248324612461 query25 512 463 394 394 query26 1158277 158 158 query27 2213505 342 342 query28 4332244924242424 query29 737 568 450 450 query30 280 230 198 198 query31 933 875 781 781 query32 75 63 70 63 query33 573 374 308 308 query34 812 850 526 526 query35 806 856 800 800 query36 983 1022903 903 query37 128 102 79 79 query38 4373420040954095 query39 1489146414521452 query40 211 120 106 106 query41 52 53 52 52 query42 117 109 108 108 query43 504 514 498 498 query44 1325825 818 818 query45 186 172 168 168 query46 848 1036649 649 query47 1806189117701770 query48 396 424 318 318 query49 760 527 420 420 query50 703 755 421 421 query51 4273429042824282 query52 106 105 99 99 query53 231 260 189 189 query54 500 499 433 433 query55 85 84 86 84 query56 278 286 253 253 query57 1166121711141114 query58 246 239 234 234 query59 2962281627502750 query60 294 293 248 248 query61 126 154 117 117 query62 794 737 664 664 query63 234 191 189 189 query64 40751017669 669 query65 4570442944264426 query66 994 401 298 298 query67 16589 15503 15242 15242 query68 9821892 509 509 query69 470 293 262 262 query70 1242106010841060 query71 457 295 258 258 query72 5079352638173526 query73 807 725 353 353 query74 9010890386518651 query75 4270315127212721 query76 52371192752 752 query77 1003360 284 284 query78 986910263 93569356 query79 4679810 571 571 query80 583 517 429 429 query81 482 260 214 214 query82 188 124 95 95 query83 167 170 154 154 query84 289 91 78 78 query85 740 451 315 315 query86 336 310 297 297 query87 4426445144784451 query88 2859226822602260 query89 442 321 293 293 query90 2189219 223 219 query91 134 138 109 109 query92 72 61 54 54 query93 30781044578 578 query94 674 420 299 299 query95 355 319 270 270 query96 492 552 274 274 query97 3281341233293329 query98 222 201 200 200 query99 1379142312611261 Total cold run time: 285251 ms Total hot run time: 192305 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2739107201 TPC-H: Total hot run time: 32534 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit e999a363568df997cf939d449ac1b8e844aa2b50, data reload: false -- Round 1 -- q1 24408 516450465046 q2 2058349 208 208 q3 10650 1257678 678 q4 10248 1010556 556 q5 8157239923422342 q6 202 162 131 131 q7 916 764 610 610 q8 9315132510751075 q9 5020490549194905 q10 6827232818831883 q11 477 271 260 260 q12 358 361 217 217 q13 17782 376230743074 q14 232 233 207 207 q15 536 473 488 473 q16 621 613 583 583 q17 596 857 343 343 q18 6832640762936293 q19 1924963 568 568 q20 320 329 196 196 q21 2774222018991899 q22 10971007987 987 Total cold run time: 111350 ms Total hot run time: 32534 ms - Round 2, with runtime_filter_mode=off - q1 5254520151335133 q2 242 328 234 234 q3 2128267922412241 q4 1449180813661366 q5 4234428044284280 q6 222 172 128 128 q7 2009190818061806 q8 2624258627152586 q9 7274734572207220 q10 2947313727992799 q11 582 499 483 483 q12 675 780 588 588 q13 3496391933893389 q14 290 289 271 271 q15 525 468 473 468 q16 657 669 664 664 q17 1197165213231323 q18 7988757875037503 q19 840 794 826 794 q20 1964204818981898 q21 5318502748374837 q22 1072105210291029 Total cold run time: 52987 ms Total hot run time: 51040 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2739042948 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2736450052 # BE UT Coverage Report Increment line coverage `32.93% (27/82)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/dadb3566dedcd2b2bbd12c2408746795058d7d67_dadb3566dedcd2b2bbd12c2408746795058d7d67/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/dadb3566dedcd2b2bbd12c2408746795058d7d67_dadb3566dedcd2b2bbd12c2408746795058d7d67/report/index.html) | Category | Coverage | |---|| | Function Coverage | 48.82% (13077/26787) | | Line Coverage | 38.38% (112757/293786) | | Region Coverage | 37.18% (57323/154188) | | Branch Coverage | 32.29% (28824/89278) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2736079322 ClickBench: Total hot run time: 31.85 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit dadb3566dedcd2b2bbd12c2408746795058d7d67, data reload: false query1 0.040.040.04 query2 0.120.110.10 query3 0.240.200.19 query4 1.590.200.19 query5 0.610.590.55 query6 1.190.720.72 query7 0.030.030.02 query8 0.040.030.03 query9 0.570.520.51 query10 0.590.580.60 query11 0.150.110.11 query12 0.140.110.11 query13 0.610.610.60 query14 2.802.682.73 query15 0.930.850.86 query16 0.380.380.37 query17 1.021.051.06 query18 0.210.200.20 query19 1.942.031.84 query20 0.010.020.02 query21 15.35 0.880.57 query22 0.751.231.12 query23 14.67 1.350.63 query24 7.241.950.87 query25 0.490.170.20 query26 0.550.160.14 query27 0.070.050.05 query28 9.350.820.45 query29 12.53 3.943.35 query30 0.250.090.06 query31 2.840.580.39 query32 3.230.550.48 query33 2.963.013.02 query34 15.68 5.114.47 query35 4.564.564.53 query36 0.660.500.48 query37 0.080.060.07 query38 0.060.040.04 query39 0.040.020.03 query40 0.170.140.13 query41 0.080.020.02 query42 0.040.020.02 query43 0.040.030.03 Total cold run time: 104.9 s Total hot run time: 31.85 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2736065331 TPC-DS: Total hot run time: 186232 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit dadb3566dedcd2b2bbd12c2408746795058d7d67, data reload: false query1 1018510 473 473 query2 6572190319171903 query3 6785213 214 213 query4 26515 23788 23486 23486 query5 4360653 482 482 query6 313 211 205 205 query7 4609493 304 304 query8 316 248 239 239 query9 8615263826462638 query10 470 314 257 257 query11 15907 15163 14985 14985 query12 173 114 104 104 query13 1669505 401 401 query14 10401 626063656260 query15 204 187 171 171 query16 7256653 502 502 query17 1165693 555 555 query18 1927402 297 297 query19 183 178 156 156 query20 120 114 112 112 query21 203 119 104 104 query22 4145421641234123 query23 33715 32960 33013 32960 query24 7731236724032367 query25 530 449 397 397 query26 1237272 157 157 query27 2122499 323 323 query28 3937241123962396 query29 750 557 424 424 query30 287 216 201 201 query31 969 841 779 779 query32 73 66 63 63 query33 558 360 315 315 query34 799 844 514 514 query35 821 820 724 724 query36 1022977 912 912 query37 117 102 79 79 query38 4345424940364036 query39 1421147013961396 query40 235 116 103 103 query41 54 53 52 52 query42 122 106 105 105 query43 497 510 472 472 query44 1293785 778 778 query45 172 171 168 168 query46 830 1026614 614 query47 1753180217021702 query48 375 418 307 307 query49 779 515 415 415 query50 682 734 422 422 query51 4149418241934182 query52 109 104 100 100 query53 245 255 197 197 query54 487 492 425 425 query55 84 76 85 76 query56 274 268 264 264 query57 1142114710641064 query58 246 237 234 234 query59 2496275227152715 query60 305 303 274 274 query61 152 145 145 145 query62 824 792 667 667 query63 234 187 181 181 query64 43701002675 675 query65 4405433943414339 query66 1119459 313 313 query67 15662 15345 15487 15345 query68 8074869 502 502 query69 471 303 268 268 query70 1180114311411141 query71 389 290 263 263 query72 5633362038693620 query73 734 762 355 355 query74 9035905387658765 query75 3207318027102710 query76 31971188767 767 query77 512 385 290 290 query78 10019 10273 93049304 query79 1179836 594 594 query80 647 549 506 506 query81 482 260 227 227 query82 221 129 98 98 query83 173 172 154 154 query84 242 93 76 76 query85 748 344 305 305 query86 376 311 312 311 query87 4437461644734473 query88 2938233622712271 query89 390 313 282 282 query90 1869220 226 220 query91 144 143 112 112 query92 70 58 64 58 query93 11691047594 594 query94 638 411 309 309 query95 356 278 268 268 query96 493 564 283 283 query97 3307341032923292 query98 226 215 201 201 query99 1311140212661266 Total cold run time: 270322 ms Total hot run time: 186232 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2736035852 TPC-H: Total hot run time: 32912 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit dadb3566dedcd2b2bbd12c2408746795058d7d67, data reload: false -- Round 1 -- q1 24417 525551125112 q2 2057345 194 194 q3 10442 1238699 699 q4 10242 1050538 538 q5 7737238723982387 q6 198 160 134 134 q7 946 753 620 620 q8 9316131111321132 q9 4936493849024902 q10 6847234018881888 q11 470 274 256 256 q12 350 356 217 217 q13 17797 373531073107 q14 245 234 209 209 q15 538 484 480 480 q16 625 621 580 580 q17 569 864 367 367 q18 6939660264266426 q19 1493967 534 534 q20 325 335 207 207 q21 2686218219411941 q22 10911031982 982 Total cold run time: 110266 ms Total hot run time: 32912 ms - Round 2, with runtime_filter_mode=off - q1 5191517551235123 q2 244 331 236 236 q3 2194269723312331 q4 1487186214131413 q5 4263426145294261 q6 223 175 129 129 q7 2061195317801780 q8 2657258124772477 q9 7269722971727172 q10 3010320427332733 q11 603 517 502 502 q12 689 771 615 615 q13 3462387833353335 q14 270 302 273 273 q15 519 477 470 470 q16 623 687 637 637 q17 1169162213361336 q18 7796769074507450 q19 787 754 898 754 q20 1983205818621862 q21 5399468347794683 q22 10851025992 992 Total cold run time: 52984 ms Total hot run time: 50564 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2735827278 TeamCity cloud ut coverage result: Function Coverage: 83.09% (1081/1301) Line Coverage: 66.04% (17998/27253) Region Coverage: 65.41% (8864/13551) Branch Coverage: 55.22% (4769/8636) Coverage Report: http://coverage.selectdb-in.cc/coverage/dadb3566dedcd2b2bbd12c2408746795058d7d67_dadb3566dedcd2b2bbd12c2408746795058d7d67_cloud/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2735711223 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on code in PR #47319: URL: https://github.com/apache/doris/pull/47319#discussion_r2001333126 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/TimeV2Literal.java: ## @@ -0,0 +1,275 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.expressions.literal; + +import org.apache.doris.analysis.LiteralExpr; +import org.apache.doris.nereids.exceptions.AnalysisException; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor; +import org.apache.doris.nereids.types.TimeV2Type; + +import java.time.LocalDateTime; + +/** + * Time literal in Nereids. + */ +public class TimeV2Literal extends Literal { +private static final LocalDateTime START_OF_A_DAY = LocalDateTime.of(0, 1, 1, 0, 0, 0); +private static final LocalDateTime END_OF_A_DAY = LocalDateTime.of(, 12, 31, 23, 59, 59, 99000); +private static final TimeV2Literal MIN_TIME = new TimeV2Literal(-838, 0, 0, 0, 0); +private static final TimeV2Literal MAX_TIME = new TimeV2Literal(838, 59, 59, 99, 6); + +protected int hour; +protected int minute; +protected int second; +protected int microsecond; +protected boolean negative; + +public TimeV2Literal(String s) { +this(TimeV2Type.of(0), s); Review Comment: yes, what the scale is should be of concern to the pre level -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on code in PR #47319: URL: https://github.com/apache/doris/pull/47319#discussion_r2001333126 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/TimeV2Literal.java: ## @@ -0,0 +1,275 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.expressions.literal; + +import org.apache.doris.analysis.LiteralExpr; +import org.apache.doris.nereids.exceptions.AnalysisException; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor; +import org.apache.doris.nereids.types.TimeV2Type; + +import java.time.LocalDateTime; + +/** + * Time literal in Nereids. + */ +public class TimeV2Literal extends Literal { +private static final LocalDateTime START_OF_A_DAY = LocalDateTime.of(0, 1, 1, 0, 0, 0); +private static final LocalDateTime END_OF_A_DAY = LocalDateTime.of(, 12, 31, 23, 59, 59, 99000); +private static final TimeV2Literal MIN_TIME = new TimeV2Literal(-838, 0, 0, 0, 0); +private static final TimeV2Literal MAX_TIME = new TimeV2Literal(838, 59, 59, 99, 6); + +protected int hour; +protected int minute; +protected int second; +protected int microsecond; +protected boolean negative; + +public TimeV2Literal(String s) { +this(TimeV2Type.of(0), s); Review Comment: yes, all scales should be provided by the caller -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on code in PR #47319: URL: https://github.com/apache/doris/pull/47319#discussion_r2001333126 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/TimeV2Literal.java: ## @@ -0,0 +1,275 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.expressions.literal; + +import org.apache.doris.analysis.LiteralExpr; +import org.apache.doris.nereids.exceptions.AnalysisException; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor; +import org.apache.doris.nereids.types.TimeV2Type; + +import java.time.LocalDateTime; + +/** + * Time literal in Nereids. + */ +public class TimeV2Literal extends Literal { +private static final LocalDateTime START_OF_A_DAY = LocalDateTime.of(0, 1, 1, 0, 0, 0); +private static final LocalDateTime END_OF_A_DAY = LocalDateTime.of(, 12, 31, 23, 59, 59, 99000); +private static final TimeV2Literal MIN_TIME = new TimeV2Literal(-838, 0, 0, 0, 0); +private static final TimeV2Literal MAX_TIME = new TimeV2Literal(838, 59, 59, 99, 6); + +protected int hour; +protected int minute; +protected int second; +protected int microsecond; +protected boolean negative; + +public TimeV2Literal(String s) { +this(TimeV2Type.of(0), s); Review Comment: yes, what the scale is should be of concern to the top -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2712546503 TPC-DS: Total hot run time: 193167 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 2e3b554c58aed911ec676f0efd5286b2de72f433, data reload: false query1 14501005995 995 query2 6150198619541954 query3 11021 450745104507 query4 54209 25588 23094 23094 query5 5277509 481 481 query6 346 203 191 191 query7 4919500 300 300 query8 326 248 248 248 query9 5846264926432643 query10 413 317 251 251 query11 15268 15115 14995 14995 query12 162 109 100 100 query13 1048506 412 412 query14 10945 677669546776 query15 191 199 212 199 query16 7130662 472 472 query17 1043724 595 595 query18 1534398 330 330 query19 189 187 156 156 query20 126 122 122 122 query21 208 133 104 104 query22 4517460442954295 query23 34204 0 33601 0 query24 5734246024242424 query25 468 462 401 401 query26 677 290 168 168 query27 1776515 337 337 query28 2780250525102505 query29 609 596 478 478 query30 280 230 207 207 query31 867 865 797 797 query32 81 72 64 64 query33 507 382 324 324 query34 768 865 520 520 query35 805 847 779 779 query36 963 1000910 910 query37 127 110 82 82 query38 4322426443104264 query39 1483141814521418 query40 206 115 104 104 query41 53 51 48 48 query42 122 108 115 108 query43 513 520 513 513 query44 1327822 819 819 query45 182 172 166 166 query46 843 1037635 635 query47 1876193218901890 query48 401 421 317 317 query49 703 529 483 483 query50 713 767 435 435 query51 4290426842324232 query52 107 104 94 94 query53 238 260 184 184 query54 486 516 409 409 query55 92 81 82 81 query56 268 264 281 264 query57 1203120211411141 query58 260 242 244 242 query59 2840307928472847 query60 276 288 279 279 query61 121 123 121 121 query62 713 750 668 668 query63 238 194 191 191 query64 15401045727 727 query65 4564446744874467 query66 760 396 300 300 query67 15927 15466 15422 15422 query68 6930819 511 511 query69 563 290 264 264 query70 1176113510971097 query71 453 310 284 284 query72 5753363238643632 query73 1205753 351 351 query74 9285920387518751 query75 3390315726882688 query76 37981196760 760 query77 566 352 280 280 query78 10224 10086 93419341 query79 2476830 617 617 query80 658 543 453 453 query81 479 257 222 222 query82 675 129 101 101 query83 185 174 160 160 query84 352 94 74 74 query85 781 359 307 307 query86 422 308 288 288 query87 4391454243944394 query88 3647226622692266 query89 416 313 293 293 query90 1868217 221 217 query91 141 149 107 107 query92 72 60 59 59 query93 19541072582 582 query94 697 419 303 303 query95 363 273 266 266 query96 481 576 276 276 query97 3432338833073307 query98 220 201 209 201 query99 1420139513001300 Total cold run time: 298104 ms Total hot run time: 193167 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2723377427 ClickBench: Total hot run time: 31.37 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit dfd1604bdb9280406334397e5ab51056a0253fbe, data reload: false query1 0.030.030.04 query2 0.110.040.05 query3 0.280.050.05 query4 1.610.080.07 query5 0.550.540.55 query6 1.190.730.73 query7 0.020.020.01 query8 0.060.050.05 query9 0.630.520.53 query10 0.590.590.59 query11 0.260.120.12 query12 0.250.130.13 query13 0.630.620.62 query14 2.652.682.68 query15 0.990.880.86 query16 0.380.380.38 query17 1.061.051.00 query18 0.180.180.17 query19 1.911.861.98 query20 0.010.020.01 query21 15.37 0.960.67 query22 0.910.970.78 query23 14.76 1.490.73 query24 5.440.570.29 query25 0.170.090.08 query26 0.550.210.18 query27 0.090.080.08 query28 10.98 1.140.56 query29 12.53 4.123.43 query30 0.300.090.06 query31 2.840.620.43 query32 3.230.590.50 query33 3.133.093.05 query34 16.44 5.204.43 query35 4.524.494.49 query36 0.640.500.49 query37 0.200.170.17 query38 0.160.160.15 query39 0.060.040.04 query40 0.210.150.16 query41 0.120.060.05 query42 0.060.060.05 query43 0.060.050.05 Total cold run time: 106.16 s Total hot run time: 31.37 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2723349813 TPC-H: Total hot run time: 32950 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit dfd1604bdb9280406334397e5ab51056a0253fbe, data reload: false -- Round 1 -- q1 17613 519050765076 q2 2060301 172 172 q3 10399 1291799 799 q4 10214 1048540 540 q5 7543242724292427 q6 191 162 132 132 q7 935 781 610 610 q8 9299131111721172 q9 5088467746254625 q10 6848234719191919 q11 488 287 260 260 q12 360 353 214 214 q13 17779 370530673067 q14 230 236 209 209 q15 563 492 483 483 q16 655 645 589 589 q17 620 909 366 366 q18 6943654665116511 q19 1361956 592 592 q20 334 351 197 197 q21 3085232919931993 q22 10621017997 997 Total cold run time: 103670 ms Total hot run time: 32950 ms - Round 2, with runtime_filter_mode=off - q1 5254520051895189 q2 239 335 228 228 q3 2145264422962296 q4 1459187313811381 q5 4249419442364194 q6 215 168 135 135 q7 1992193217931793 q8 2661266626202620 q9 7322729971647164 q10 3055323727712771 q11 591 510 524 510 q12 662 767 601 601 q13 3581396932983298 q14 280 308 283 283 q15 543 481 492 481 q16 637 687 641 641 q17 1166163813651365 q18 7786769276017601 q19 914 101610921016 q20 1999208019191919 q21 5632501247844784 q22 1146101010071007 Total cold run time: 53528 ms Total hot run time: 51277 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2723363174 # BE UT Coverage Report Increment line coverage `32.93% (27/82)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/dfd1604bdb9280406334397e5ab51056a0253fbe_dfd1604bdb9280406334397e5ab51056a0253fbe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/dfd1604bdb9280406334397e5ab51056a0253fbe_dfd1604bdb9280406334397e5ab51056a0253fbe/report/index.html) | Category | Coverage | |---|| | Function Coverage | 47.98% (12831/26741) | | Line Coverage | 37.36% (109473/293056) | | Region Coverage | 36.49% (56103/153766) | | Branch Coverage | 31.77% (28273/88990) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2723366887 TPC-DS: Total hot run time: 192387 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit dfd1604bdb9280406334397e5ab51056a0253fbe, data reload: false query1 14271032989 989 query2 6099188218741874 query3 11031 452145054505 query4 54133 25792 23216 23216 query5 5067566 494 494 query6 355 204 194 194 query7 4897516 297 297 query8 323 270 255 255 query9 5805265826632658 query10 432 321 254 254 query11 15132 15063 15299 15063 query12 169 112 102 102 query13 1042512 422 422 query14 10747 656068006560 query15 208 206 179 179 query16 7106638 506 506 query17 1092748 599 599 query18 1568424 331 331 query19 202 199 186 186 query20 131 128 128 128 query21 207 124 107 107 query22 4506457244874487 query23 33951 33470 33384 33384 query24 5854246624282428 query25 476 477 419 419 query26 720 281 160 160 query27 1842498 336 336 query28 2812246024572457 query29 624 561 432 432 query30 275 227 193 193 query31 867 893 806 806 query32 74 70 62 62 query33 473 360 315 315 query34 815 867 512 512 query35 858 832 740 740 query36 962 997 909 909 query37 115 99 78 78 query38 4148425544534255 query39 1530145814371437 query40 210 120 108 108 query41 54 52 49 49 query42 122 109 109 109 query43 489 523 492 492 query44 1344822 814 814 query45 181 187 174 174 query46 867 1039665 665 query47 1850188618171817 query48 399 442 304 304 query49 715 537 442 442 query50 731 762 447 447 query51 4325424542404240 query52 111 110 97 97 query53 230 261 193 193 query54 494 514 427 427 query55 85 82 81 81 query56 266 288 280 280 query57 1184119311281128 query58 245 247 243 243 query59 2661291526072607 query60 313 282 260 260 query61 129 140 126 126 query62 756 752 687 687 query63 236 198 190 190 query64 2307708 708 query65 4518446644334433 query66 770 399 294 294 query67 15963 15801 15272 15272 query68 7069889 511 511 query69 533 308 272 272 query70 1221112310471047 query71 499 293 267 267 query72 5822359937103599 query73 1376731 348 348 query74 9177917184908490 query75 3764313027492749 query76 42361200766 766 query77 624 357 275 275 query78 10048 999492759275 query79 2871815 577 577 query80 691 582 462 462 query81 494 264 217 217 query82 654 124 95 95 query83 285 167 153 153 query84 279 94 76 76 query85 798 362 314 314 query86 379 296 286 286 query87 4535473444814481 query88 3499222922352229 query89 414 315 285 285 query90 1897208 209 208 query91 145 139 113 113 query92 74 58 59 58 query93 18601080590 590 query94 673 499 294 294 query95 347 267 258 258 query96 488 567 279 279 query97 3327341732903290 query98 224 205 211 205 query99 1426138113021302 Total cold run time: 299359 ms Total hot run time: 192387 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2723192227 TeamCity cloud ut coverage result: Function Coverage: 82.88% (1075/1297) Line Coverage: 65.87% (17737/26927) Region Coverage: 65.20% (8731/13391) Branch Coverage: 55.14% (4707/8536) Coverage Report: http://coverage.selectdb-in.cc/coverage/dfd1604bdb9280406334397e5ab51056a0253fbe_dfd1604bdb9280406334397e5ab51056a0253fbe_cloud/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2723149325 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2723141768 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
hello-stephen commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2720981424 # BE UT Coverage Report Increment line coverage `32.93% (27/82)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/f7c1a553e22f75642d4258a8bd14e532665fc23b_f7c1a553e22f75642d4258a8bd14e532665fc23b/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/f7c1a553e22f75642d4258a8bd14e532665fc23b_f7c1a553e22f75642d4258a8bd14e532665fc23b/report/index.html) | Category | Coverage | |---|| | Function Coverage | 47.92% (12812/26739) | | Line Coverage | 37.30% (109313/293034) | | Region Coverage | 36.41% (55980/153745) | | Branch Coverage | 31.72% (28223/88980) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on code in PR #47319: URL: https://github.com/apache/doris/pull/47319#discussion_r1992994003 ## fe/fe-core/src/main/java/org/apache/doris/analysis/TimeV2Literal.java: ## @@ -0,0 +1,287 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.analysis; + +import org.apache.doris.catalog.ScalarType; +import org.apache.doris.catalog.Type; +import org.apache.doris.common.FormatOptions; +import org.apache.doris.nereids.exceptions.AnalysisException; +import org.apache.doris.thrift.TExprNode; +import org.apache.doris.thrift.TExprNodeType; +import org.apache.doris.thrift.TTimeV2Literal; + +public class TimeV2Literal extends LiteralExpr { + +public static final TimeV2Literal MIN_TIME = new TimeV2Literal(-838, 0, 0, 0, 0); +public static final TimeV2Literal MAX_TIME = new TimeV2Literal(838, 59, 59, 99, 6); + +protected int hour; +protected int minute; +protected int second; +protected int microsecond; +protected boolean negative; + +/** + * C'tor forcing type, e.g., due to implicit cast + */ +// for restore +private TimeV2Literal() { +this.type = Type.TIMEV2; +this.hour = 0; +this.minute = 0; +this.second = 0; +this.microsecond = 0; +this.negative = false; +} + +public TimeV2Literal(double value) throws AnalysisException { +super(); +if (value > (double) MAX_TIME.getValue() || value < -(double) MAX_TIME.getValue()) { +throw new AnalysisException("The value is out of range"); +} +this.type = ScalarType.createTimeV2Type(6); +this.negative = 1.0 / value < 0; +long v = (long) Math.abs(value); +this.microsecond = (int) (v % 100); +v /= 100; +this.second = (int) (v % 60); +v /= 60; +this.minute = (int) (v % 60); +v /= 60; +this.hour = (int) v; +analysisDone(); +} + +public TimeV2Literal(int hour, int minute, int second) throws AnalysisException { +super(); +this.type = Type.TIMEV2; +this.hour = Math.abs(hour); +this.minute = minute; +this.second = second; +this.microsecond = 0; +this.negative = hour < 0; +if (checkRange(this.hour, this.minute, this.second, this.microsecond)) { +throw new AnalysisException("time literal is out of range"); +} +analysisDone(); +} + +public TimeV2Literal(int hour, int minute, int second, int microsecond, int scale) throws AnalysisException { +super(); +this.type = ScalarType.createTimeV2Type(scale); +this.hour = Math.abs(hour); +this.minute = minute; +this.second = second; +this.microsecond = microsecond; +while (microsecond != 0 && this.microsecond < 10) { +this.microsecond *= 10; +} +this.negative = hour < 0; +if (checkRange(this.hour, this.minute, this.second, this.microsecond)) { +throw new AnalysisException("time literal is out of range"); +} +analysisDone(); +} + +public TimeV2Literal(String s) { +super(); +init(s); +analysisDone(); +} + +protected TimeV2Literal(TimeV2Literal other) { +super(other); +this.type = ScalarType.createTimeV2Type(((ScalarType) other.type).getScalarScale()); +this.hour = other.getHour(); +this.minute = other.getMinute(); +this.second = other.getSecond(); +this.microsecond = other.getMicroSecond(); +} + +@Override +public Expr clone() { +return new TimeV2Literal(this); +} + +protected String normalize(String s) { +// remove suffix/prefix ' ' +s = s.trim(); +if (s.charAt(0) == '-') { +s = s.substring(1); +negative = true; +} +if (!s.contains(":")) { +String tail = ""; +if (s.contains(".")) { +tail = s.substring(s.indexOf(".")); +s = s.substring(0, s.indexOf(".")); +} +int len = s.length(); +if (len == 1) { +
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2720547467 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2720385874 TeamCity cloud ut coverage result: Function Coverage: 82.88% (1075/1297) Line Coverage: 65.87% (17730/26918) Region Coverage: 65.19% (8728/13388) Branch Coverage: 55.17% (4708/8534) Coverage Report: http://coverage.selectdb-in.cc/coverage/f7c1a553e22f75642d4258a8bd14e532665fc23b_f7c1a553e22f75642d4258a8bd14e532665fc23b_cloud/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2720368180 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on code in PR #47319: URL: https://github.com/apache/doris/pull/47319#discussion_r1992994003 ## fe/fe-core/src/main/java/org/apache/doris/analysis/TimeV2Literal.java: ## @@ -0,0 +1,287 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.analysis; + +import org.apache.doris.catalog.ScalarType; +import org.apache.doris.catalog.Type; +import org.apache.doris.common.FormatOptions; +import org.apache.doris.nereids.exceptions.AnalysisException; +import org.apache.doris.thrift.TExprNode; +import org.apache.doris.thrift.TExprNodeType; +import org.apache.doris.thrift.TTimeV2Literal; + +public class TimeV2Literal extends LiteralExpr { + +public static final TimeV2Literal MIN_TIME = new TimeV2Literal(-838, 0, 0, 0, 0); +public static final TimeV2Literal MAX_TIME = new TimeV2Literal(838, 59, 59, 99, 6); + +protected int hour; +protected int minute; +protected int second; +protected int microsecond; +protected boolean negative; + +/** + * C'tor forcing type, e.g., due to implicit cast + */ +// for restore +private TimeV2Literal() { +this.type = Type.TIMEV2; +this.hour = 0; +this.minute = 0; +this.second = 0; +this.microsecond = 0; +this.negative = false; +} + +public TimeV2Literal(double value) throws AnalysisException { +super(); +if (value > (double) MAX_TIME.getValue() || value < -(double) MAX_TIME.getValue()) { +throw new AnalysisException("The value is out of range"); +} +this.type = ScalarType.createTimeV2Type(6); +this.negative = 1.0 / value < 0; +long v = (long) Math.abs(value); +this.microsecond = (int) (v % 100); +v /= 100; +this.second = (int) (v % 60); +v /= 60; +this.minute = (int) (v % 60); +v /= 60; +this.hour = (int) v; +analysisDone(); +} + +public TimeV2Literal(int hour, int minute, int second) throws AnalysisException { +super(); +this.type = Type.TIMEV2; +this.hour = Math.abs(hour); +this.minute = minute; +this.second = second; +this.microsecond = 0; +this.negative = hour < 0; +if (checkRange(this.hour, this.minute, this.second, this.microsecond)) { +throw new AnalysisException("time literal is out of range"); +} +analysisDone(); +} + +public TimeV2Literal(int hour, int minute, int second, int microsecond, int scale) throws AnalysisException { +super(); +this.type = ScalarType.createTimeV2Type(scale); +this.hour = Math.abs(hour); +this.minute = minute; +this.second = second; +this.microsecond = microsecond; +while (microsecond != 0 && this.microsecond < 10) { +this.microsecond *= 10; +} +this.negative = hour < 0; +if (checkRange(this.hour, this.minute, this.second, this.microsecond)) { +throw new AnalysisException("time literal is out of range"); +} +analysisDone(); +} + +public TimeV2Literal(String s) { +super(); +init(s); +analysisDone(); +} + +protected TimeV2Literal(TimeV2Literal other) { +super(other); +this.type = ScalarType.createTimeV2Type(((ScalarType) other.type).getScalarScale()); +this.hour = other.getHour(); +this.minute = other.getMinute(); +this.second = other.getSecond(); +this.microsecond = other.getMicroSecond(); +} + +@Override +public Expr clone() { +return new TimeV2Literal(this); +} + +protected String normalize(String s) { +// remove suffix/prefix ' ' +s = s.trim(); +if (s.charAt(0) == '-') { +s = s.substring(1); +negative = true; +} +if (!s.contains(":")) { +String tail = ""; +if (s.contains(".")) { +tail = s.substring(s.indexOf(".")); +s = s.substring(0, s.indexOf(".")); +} +int len = s.length(); +if (len == 1) { +
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2712284110 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2712638524 # BE UT Coverage Report Increment line coverage `27.84% (27/97)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/2e3b554c58aed911ec676f0efd5286b2de72f433_2e3b554c58aed911ec676f0efd5286b2de72f433/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/2e3b554c58aed911ec676f0efd5286b2de72f433_2e3b554c58aed911ec676f0efd5286b2de72f433/report/index.html) | Category | Coverage | |---|| | Function Coverage | 46.86% (12527/26733) | | Line Coverage | 36.46% (106772/292808) | | Region Coverage | 35.50% (54556/153686) | | Branch Coverage | 30.88% (27454/88908) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2712556211 ClickBench: Total hot run time: 31.51 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 2e3b554c58aed911ec676f0efd5286b2de72f433, data reload: false query1 0.040.040.03 query2 0.110.050.04 query3 0.280.050.05 query4 1.600.100.07 query5 0.560.550.55 query6 1.180.740.73 query7 0.020.010.02 query8 0.050.050.05 query9 0.640.520.52 query10 0.590.610.58 query11 0.260.130.12 query12 0.250.130.14 query13 0.640.620.62 query14 2.862.722.82 query15 1.010.890.89 query16 0.370.370.37 query17 1.071.031.07 query18 0.180.190.18 query19 2.161.841.80 query20 0.010.010.02 query21 15.35 1.000.68 query22 0.931.030.82 query23 14.69 1.520.77 query24 5.260.600.30 query25 0.170.090.08 query26 0.550.240.18 query27 0.080.080.08 query28 11.02 1.140.58 query29 12.55 4.193.42 query30 0.280.080.06 query31 2.830.630.43 query32 3.230.600.50 query33 3.173.003.16 query34 16.43 5.124.53 query35 4.474.504.44 query36 0.630.500.50 query37 0.200.170.18 query38 0.170.150.17 query39 0.040.040.04 query40 0.190.160.15 query41 0.100.050.05 query42 0.060.040.04 query43 0.050.050.04 Total cold run time: 106.33 s Total hot run time: 31.51 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2712528023 TPC-H: Total hot run time: 32702 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 2e3b554c58aed911ec676f0efd5286b2de72f433, data reload: false -- Round 1 -- q1 17681 523750365036 q2 2049292 160 160 q3 10678 1250766 766 q4 10222 1031530 530 q5 7620238223922382 q6 186 161 132 132 q7 907 754 613 613 q8 9304143511531153 q9 4903475747714757 q10 6809231719311931 q11 476 274 255 255 q12 355 361 216 216 q13 17772 370830953095 q14 235 233 218 218 q15 556 491 490 490 q16 626 616 585 585 q17 595 896 336 336 q18 7268638664446386 q19 1739958 554 554 q20 324 338 199 199 q21 2787213919291929 q22 1005987 979 979 Total cold run time: 104097 ms Total hot run time: 32702 ms - Round 2, with runtime_filter_mode=off - q1 5205510350815081 q2 241 323 226 226 q3 2184267623352335 q4 1428181813851385 q5 4293414941934149 q6 220 172 126 126 q7 1988194017431743 q8 2666259225562556 q9 7283721773287217 q10 3031320428192819 q11 572 520 493 493 q12 657 732 610 610 q13 35583940 q14 293 307 264 264 q15 538 494 507 494 q16 650 695 644 644 q17 1155168113351335 q18 7843763076267626 q19 827 844 920 844 q20 2004203718571857 q21 5536496247944794 q22 1094104910141014 Total cold run time: 53266 ms Total hot run time: 50945 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2712329446 TeamCity cloud ut coverage result: Function Coverage: 83.05% (1073/1292) Line Coverage: 65.90% (17677/26824) Region Coverage: 65.34% (8713/13334) Branch Coverage: 55.22% (4698/8508) Coverage Report: http://coverage.selectdb-in.cc/coverage/2e3b554c58aed911ec676f0efd5286b2de72f433_2e3b554c58aed911ec676f0efd5286b2de72f433_cloud/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2708939289 # BE UT Coverage Report Increment line coverage `27.84% (27/97)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/8ff269e2026e15d0cf825300eee132c06450436f_8ff269e2026e15d0cf825300eee132c06450436f/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/8ff269e2026e15d0cf825300eee132c06450436f_8ff269e2026e15d0cf825300eee132c06450436f/report/index.html) | Category | Coverage | |---|| | Function Coverage | 46.89% (12542/26748) | | Line Coverage | 36.46% (106905/293210) | | Region Coverage | 35.50% (54604/153810) | | Branch Coverage | 30.85% (27463/89012) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2708840307 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2708852391 TeamCity cloud ut coverage result: Function Coverage: 82.15% (1063/1294) Line Coverage: 65.66% (17624/26840) Region Coverage: 65.11% (8686/13340) Branch Coverage: 55.08% (4687/8510) Coverage Report: http://coverage.selectdb-in.cc/coverage/8ff269e2026e15d0cf825300eee132c06450436f_8ff269e2026e15d0cf825300eee132c06450436f_cloud/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2708841501 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on code in PR #47319: URL: https://github.com/apache/doris/pull/47319#discussion_r1979642046 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/TimeV2Literal.java: ## @@ -0,0 +1,275 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.expressions.literal; + +import org.apache.doris.analysis.LiteralExpr; +import org.apache.doris.nereids.exceptions.AnalysisException; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor; +import org.apache.doris.nereids.types.TimeV2Type; + +import java.time.LocalDateTime; + +/** + * Time literal in Nereids. + */ +public class TimeV2Literal extends Literal { +private static final LocalDateTime START_OF_A_DAY = LocalDateTime.of(0, 1, 1, 0, 0, 0); +private static final LocalDateTime END_OF_A_DAY = LocalDateTime.of(, 12, 31, 23, 59, 59, 99000); +private static final TimeV2Literal MIN_TIME = new TimeV2Literal(-838, 0, 0, 0, 0); +private static final TimeV2Literal MAX_TIME = new TimeV2Literal(838, 59, 59, 99, 6); + +protected int hour; +protected int minute; +protected int second; +protected int microsecond; +protected boolean negative; + +public TimeV2Literal(String s) { +this(TimeV2Type.of(0), s); Review Comment: because if the sql is`select cast("01:01:01.123456" as time)` will call this function directly, the sql means scale is 0, unless it use `as time(scale)` this situation will call another function -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on code in PR #47319: URL: https://github.com/apache/doris/pull/47319#discussion_r1979642046 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/TimeV2Literal.java: ## @@ -0,0 +1,275 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.expressions.literal; + +import org.apache.doris.analysis.LiteralExpr; +import org.apache.doris.nereids.exceptions.AnalysisException; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor; +import org.apache.doris.nereids.types.TimeV2Type; + +import java.time.LocalDateTime; + +/** + * Time literal in Nereids. + */ +public class TimeV2Literal extends Literal { +private static final LocalDateTime START_OF_A_DAY = LocalDateTime.of(0, 1, 1, 0, 0, 0); +private static final LocalDateTime END_OF_A_DAY = LocalDateTime.of(, 12, 31, 23, 59, 59, 99000); +private static final TimeV2Literal MIN_TIME = new TimeV2Literal(-838, 0, 0, 0, 0); +private static final TimeV2Literal MAX_TIME = new TimeV2Literal(838, 59, 59, 99, 6); + +protected int hour; +protected int minute; +protected int second; +protected int microsecond; +protected boolean negative; + +public TimeV2Literal(String s) { +this(TimeV2Type.of(0), s); Review Comment: because if the sql is`select cast("01:01:01.123456" as time)` will call this function directly, the sql means scale is 0, unless it use `as time(scale)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on code in PR #47319: URL: https://github.com/apache/doris/pull/47319#discussion_r1979679471 ## fe/fe-core/src/main/java/org/apache/doris/analysis/TimeV2Literal.java: ## @@ -0,0 +1,287 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.analysis; + +import org.apache.doris.catalog.ScalarType; +import org.apache.doris.catalog.Type; +import org.apache.doris.common.FormatOptions; +import org.apache.doris.nereids.exceptions.AnalysisException; +import org.apache.doris.thrift.TExprNode; +import org.apache.doris.thrift.TExprNodeType; +import org.apache.doris.thrift.TTimeV2Literal; + +public class TimeV2Literal extends LiteralExpr { + +public static final TimeV2Literal MIN_TIME = new TimeV2Literal(-838, 0, 0, 0, 0); +public static final TimeV2Literal MAX_TIME = new TimeV2Literal(838, 59, 59, 99, 6); + +protected int hour; +protected int minute; +protected int second; +protected int microsecond; +protected boolean negative; + +/** + * C'tor forcing type, e.g., due to implicit cast + */ +// for restore +private TimeV2Literal() { +this.type = Type.TIMEV2; +this.hour = 0; +this.minute = 0; +this.second = 0; +this.microsecond = 0; +this.negative = false; +} + +public TimeV2Literal(double value) throws AnalysisException { +super(); +if (value > (double) MAX_TIME.getValue() || value < -(double) MAX_TIME.getValue()) { Review Comment: MAX_TIME and MIN_TIME just store every part min max value -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on code in PR #47319: URL: https://github.com/apache/doris/pull/47319#discussion_r1979678414 ## fe/fe-core/src/main/java/org/apache/doris/analysis/TimeV2Literal.java: ## @@ -0,0 +1,287 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.analysis; + +import org.apache.doris.catalog.ScalarType; +import org.apache.doris.catalog.Type; +import org.apache.doris.common.FormatOptions; +import org.apache.doris.nereids.exceptions.AnalysisException; +import org.apache.doris.thrift.TExprNode; +import org.apache.doris.thrift.TExprNodeType; +import org.apache.doris.thrift.TTimeV2Literal; + +public class TimeV2Literal extends LiteralExpr { + +public static final TimeV2Literal MIN_TIME = new TimeV2Literal(-838, 0, 0, 0, 0); +public static final TimeV2Literal MAX_TIME = new TimeV2Literal(838, 59, 59, 99, 6); + +protected int hour; +protected int minute; +protected int second; +protected int microsecond; +protected boolean negative; + +/** + * C'tor forcing type, e.g., due to implicit cast + */ +// for restore +private TimeV2Literal() { +this.type = Type.TIMEV2; +this.hour = 0; +this.minute = 0; +this.second = 0; +this.microsecond = 0; +this.negative = false; +} + +public TimeV2Literal(double value) throws AnalysisException { +super(); +if (value > (double) MAX_TIME.getValue() || value < -(double) MAX_TIME.getValue()) { +throw new AnalysisException("The value is out of range"); +} +this.type = ScalarType.createTimeV2Type(6); +this.negative = 1.0 / value < 0; +long v = (long) Math.abs(value); +this.microsecond = (int) (v % 100); +v /= 100; +this.second = (int) (v % 60); +v /= 60; +this.minute = (int) (v % 60); +v /= 60; +this.hour = (int) v; +analysisDone(); +} + +public TimeV2Literal(int hour, int minute, int second) throws AnalysisException { +super(); +this.type = Type.TIMEV2; +this.hour = Math.abs(hour); +this.minute = minute; +this.second = second; +this.microsecond = 0; +this.negative = hour < 0; +if (checkRange(this.hour, this.minute, this.second, this.microsecond)) { +throw new AnalysisException("time literal is out of range"); +} +analysisDone(); +} + +public TimeV2Literal(int hour, int minute, int second, int microsecond, int scale) throws AnalysisException { +super(); +this.type = ScalarType.createTimeV2Type(scale); +this.hour = Math.abs(hour); +this.minute = minute; +this.second = second; +this.microsecond = microsecond; +while (microsecond != 0 && this.microsecond < 10) { +this.microsecond *= 10; +} +this.negative = hour < 0; +if (checkRange(this.hour, this.minute, this.second, this.microsecond)) { +throw new AnalysisException("time literal is out of range"); +} +analysisDone(); +} + +public TimeV2Literal(String s) { +super(); +init(s); +analysisDone(); +} + +protected TimeV2Literal(TimeV2Literal other) { +super(other); +this.type = ScalarType.createTimeV2Type(((ScalarType) other.type).getScalarScale()); +this.hour = other.getHour(); +this.minute = other.getMinute(); +this.second = other.getSecond(); +this.microsecond = other.getMicroSecond(); +} + +@Override +public Expr clone() { +return new TimeV2Literal(this); +} + +protected String normalize(String s) { +// remove suffix/prefix ' ' +s = s.trim(); +if (s.charAt(0) == '-') { +s = s.substring(1); +negative = true; +} +if (!s.contains(":")) { +String tail = ""; +if (s.contains(".")) { +tail = s.substring(s.indexOf(".")); +s = s.substring(0, s.indexOf(".")); +} +int len = s.length(); +if (len == 1) { +
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on code in PR #47319: URL: https://github.com/apache/doris/pull/47319#discussion_r1979642046 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/TimeV2Literal.java: ## @@ -0,0 +1,275 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.expressions.literal; + +import org.apache.doris.analysis.LiteralExpr; +import org.apache.doris.nereids.exceptions.AnalysisException; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor; +import org.apache.doris.nereids.types.TimeV2Type; + +import java.time.LocalDateTime; + +/** + * Time literal in Nereids. + */ +public class TimeV2Literal extends Literal { +private static final LocalDateTime START_OF_A_DAY = LocalDateTime.of(0, 1, 1, 0, 0, 0); +private static final LocalDateTime END_OF_A_DAY = LocalDateTime.of(, 12, 31, 23, 59, 59, 99000); +private static final TimeV2Literal MIN_TIME = new TimeV2Literal(-838, 0, 0, 0, 0); +private static final TimeV2Literal MAX_TIME = new TimeV2Literal(838, 59, 59, 99, 6); + +protected int hour; +protected int minute; +protected int second; +protected int microsecond; +protected boolean negative; + +public TimeV2Literal(String s) { +this(TimeV2Type.of(0), s); Review Comment: because if the sql is`select cast("01:01:01.123456" as time) will call this function directly` will call this function directly, the sql means scale is 0, unless it use `as time(scale)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
morrySnow commented on code in PR #47319: URL: https://github.com/apache/doris/pull/47319#discussion_r1979174938 ## fe/fe-core/src/main/java/org/apache/doris/analysis/TimeV2Literal.java: ## @@ -0,0 +1,287 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.analysis; + +import org.apache.doris.catalog.ScalarType; +import org.apache.doris.catalog.Type; +import org.apache.doris.common.FormatOptions; +import org.apache.doris.nereids.exceptions.AnalysisException; +import org.apache.doris.thrift.TExprNode; +import org.apache.doris.thrift.TExprNodeType; +import org.apache.doris.thrift.TTimeV2Literal; + +public class TimeV2Literal extends LiteralExpr { + +public static final TimeV2Literal MIN_TIME = new TimeV2Literal(-838, 0, 0, 0, 0); +public static final TimeV2Literal MAX_TIME = new TimeV2Literal(838, 59, 59, 99, 6); + +protected int hour; +protected int minute; +protected int second; +protected int microsecond; +protected boolean negative; + +/** + * C'tor forcing type, e.g., due to implicit cast + */ +// for restore +private TimeV2Literal() { +this.type = Type.TIMEV2; +this.hour = 0; +this.minute = 0; +this.second = 0; +this.microsecond = 0; +this.negative = false; +} + +public TimeV2Literal(double value) throws AnalysisException { +super(); +if (value > (double) MAX_TIME.getValue() || value < -(double) MAX_TIME.getValue()) { +throw new AnalysisException("The value is out of range"); Review Comment: could u print out the current value's time and the range we accepted in error message? ## fe/fe-core/src/main/java/org/apache/doris/analysis/TimeV2Literal.java: ## @@ -0,0 +1,287 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.analysis; + +import org.apache.doris.catalog.ScalarType; +import org.apache.doris.catalog.Type; +import org.apache.doris.common.FormatOptions; +import org.apache.doris.nereids.exceptions.AnalysisException; +import org.apache.doris.thrift.TExprNode; +import org.apache.doris.thrift.TExprNodeType; +import org.apache.doris.thrift.TTimeV2Literal; + +public class TimeV2Literal extends LiteralExpr { + +public static final TimeV2Literal MIN_TIME = new TimeV2Literal(-838, 0, 0, 0, 0); +public static final TimeV2Literal MAX_TIME = new TimeV2Literal(838, 59, 59, 99, 6); + +protected int hour; +protected int minute; +protected int second; +protected int microsecond; +protected boolean negative; + +/** + * C'tor forcing type, e.g., due to implicit cast + */ +// for restore +private TimeV2Literal() { +this.type = Type.TIMEV2; +this.hour = 0; +this.minute = 0; +this.second = 0; +this.microsecond = 0; +this.negative = false; +} + +public TimeV2Literal(double value) throws AnalysisException { +super(); +if (value > (double) MAX_TIME.getValue() || value < -(double) MAX_TIME.getValue()) { Review Comment: why not use `MIN_TIME` when check lowest bound? does this mean, we accept `-(838, 01,01, 0)`? it is lower than `MIN_TIME` ## fe/fe-core/src/test/java/org/apache/doris/nereids/trees/expressions/literal/TimeV2LiteralTest.java: ## @@ -0,0 +1,106 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2675241365 ClickBench: Total hot run time: 30.95 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit ac8e1f14a8270ed3f582f5402795b4c4e616b971, data reload: false query1 0.030.030.03 query2 0.100.050.04 query3 0.280.050.05 query4 1.600.080.07 query5 0.410.400.40 query6 1.170.670.65 query7 0.030.020.01 query8 0.060.070.04 query9 0.620.520.54 query10 0.580.590.58 query11 0.250.120.12 query12 0.250.120.13 query13 0.630.610.61 query14 2.672.782.71 query15 0.990.870.88 query16 0.370.400.38 query17 1.051.011.06 query18 0.180.180.19 query19 1.921.832.00 query20 0.020.010.01 query21 15.36 0.940.65 query22 0.911.010.77 query23 14.72 1.530.71 query24 5.520.520.27 query25 0.160.090.09 query26 0.550.220.18 query27 0.090.090.08 query28 10.99 1.190.56 query29 12.51 4.093.41 query30 0.270.080.06 query31 2.830.620.42 query32 3.230.590.50 query33 3.033.073.12 query34 16.58 5.104.39 query35 4.474.454.42 query36 0.630.510.49 query37 0.210.180.17 query38 0.180.150.14 query39 0.050.050.04 query40 0.200.160.16 query41 0.110.060.05 query42 0.070.050.04 query43 0.050.050.05 Total cold run time: 105.93 s Total hot run time: 30.95 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2675168656 TeamCity cloud ut coverage result: Function Coverage: 82.25% (1061/1290) Line Coverage: 65.80% (17599/26746) Region Coverage: 65.34% (8671/13271) Branch Coverage: 55.29% (4679/8462) Coverage Report: http://coverage.selectdb-in.cc/coverage/ac8e1f14a8270ed3f582f5402795b4c4e616b971_ac8e1f14a8270ed3f582f5402795b4c4e616b971_cloud/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2675231040 TPC-DS: Total hot run time: 190451 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit ac8e1f14a8270ed3f582f5402795b4c4e616b971, data reload: false query1 1283964 943 943 query2 6475183918191819 query3 10908 462144114411 query4 57353 25758 23339 23339 query5 5136491 473 473 query6 363 177 176 176 query7 5105504 288 288 query8 305 245 241 241 query9 6469256925712569 query10 397 311 257 257 query11 15151 15045 14970 14970 query12 151 109 102 102 query13 1167495 388 388 query14 10006 633066896330 query15 215 194 188 188 query16 7115671 453 453 query17 1069714 575 575 query18 1644415 305 305 query19 195 198 158 158 query20 132 125 133 125 query21 216 119 104 104 query22 4415459743084308 query23 33767 33284 5 33284 query24 5528240724142407 query25 496 490 462 462 query26 725 285 152 152 query27 2015479 351 351 query28 2847249224462446 query29 561 569 434 434 query30 221 190 159 159 query31 900 869 824 824 query32 73 62 58 58 query33 462 359 309 309 query34 730 880 528 528 query35 784 838 761 761 query36 956 981 926 926 query37 135 101 79 79 query38 4223438844014388 query39 1474142414381424 query40 210 112 106 106 query41 53 52 52 52 query42 131 104 106 104 query43 505 514 487 487 query44 1309801 799 799 query45 184 171 183 171 query46 873 1097661 661 query47 1846186418081808 query48 392 435 322 322 query49 682 525 435 435 query50 691 753 423 423 query51 4248432042464246 query52 106 100 101 100 query53 236 274 183 183 query54 479 505 419 419 query55 82 82 79 79 query56 261 278 255 255 query57 1147117011551155 query58 250 241 239 239 query59 2715284026542654 query60 290 285 261 261 query61 128 139 120 120 query62 744 751 681 681 query63 240 202 188 188 query64 17401056790 790 query65 3300316331983163 query66 713 397 296 296 query67 15826 15595 15456 15456 query68 2709765 534 534 query69 424 310 265 265 query70 1122113011351130 query71 331 298 260 260 query72 6082361138743611 query73 631 764 346 346 query74 9199921092229210 query75 3123317726702670 query76 15911147723 723 query77 463 351 274 274 query78 994210156 92019201 query79 1678870 615 615 query80 849 542 451 451 query81 511 272 237 237 query82 1023131 94 94 query83 299 164 156 156 query84 281 94 72 72 query85 755 357 318 318 query86 346 292 290 290 query87 4583444745084447 query88 3000222021552155 query89 402 321 279 279 query90 1631192 188 188 query91 135 140 110 110 query92 67 61 55 55 query93 14381013587 587 query94 619 384 275 275 query95 351 271 252 252 query96 493 548 271 271 query97 2792287727162716 query98 224 205 209 205 query99 1325139812871287 Total cold run time: 288967 ms Total hot run time: 190451 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2675230200 TeamCity be ut coverage result: Function Coverage: 44.54% (11762/26410) Line Coverage: 34.02% (98320/289038) Region Coverage: 33.10% (50366/152164) Branch Coverage: 28.75% (25328/88094) Coverage Report: http://coverage.selectdb-in.cc/coverage/ac8e1f14a8270ed3f582f5402795b4c4e616b971_ac8e1f14a8270ed3f582f5402795b4c4e616b971/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2675207091 TPC-H: Total hot run time: 31361 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit ac8e1f14a8270ed3f582f5402795b4c4e616b971, data reload: false -- Round 1 -- q1 17619 528550795079 q2 2043299 172 172 q3 10726 1252749 749 q4 10270 999 542 542 q5 8215244322742274 q6 192 170 136 136 q7 904 770 603 603 q8 9319134011591159 q9 4753463046614630 q10 6819231418691869 q11 464 269 263 263 q12 354 352 225 225 q13 17762 369630453045 q14 229 219 205 205 q15 538 456 462 456 q16 632 606 580 580 q17 559 861 323 323 q18 6839610561396105 q19 2050968 546 546 q20 296 317 192 192 q21 2718214319021902 q22 376 339 306 306 Total cold run time: 103677 ms Total hot run time: 31361 ms - Round 2, with runtime_filter_mode=off - q1 5179508151265081 q2 239 325 228 228 q3 2152264623262326 q4 1445186013571357 q5 4218411041714110 q6 208 169 125 125 q7 1881182317541754 q8 2603257524942494 q9 7258717371897173 q10 2991319427732773 q11 580 533 489 489 q12 710 795 621 621 q13 3382383732513251 q14 280 288 286 286 q15 509 475 475 475 q16 637 677 621 621 q17 1139158713271327 q18 7719737572777277 q19 757 984 1066984 q20 1969200718821882 q21 5333498449004900 q22 609 545 523 523 Total cold run time: 51798 ms Total hot run time: 50057 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2675097383 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2674466341 TeamCity be ut coverage result: Function Coverage: 44.54% (11762/26410) Line Coverage: 34.02% (98328/289033) Region Coverage: 33.10% (50361/152158) Branch Coverage: 28.75% (25323/88092) Coverage Report: http://coverage.selectdb-in.cc/coverage/f34f8b817d7b6f055c19fc9c52e2f44cb442cdc0_f34f8b817d7b6f055c19fc9c52e2f44cb442cdc0/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2674431220 ClickBench: Total hot run time: 30.84 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit f34f8b817d7b6f055c19fc9c52e2f44cb442cdc0, data reload: false query1 0.040.030.04 query2 0.070.030.04 query3 0.230.070.07 query4 1.630.100.10 query5 0.400.420.39 query6 1.160.650.66 query7 0.030.020.02 query8 0.050.030.03 query9 0.590.510.53 query10 0.570.570.57 query11 0.150.100.10 query12 0.140.110.10 query13 0.610.590.61 query14 2.722.712.73 query15 0.920.830.83 query16 0.370.380.38 query17 1.031.021.02 query18 0.200.200.19 query19 1.871.751.88 query20 0.010.020.01 query21 15.35 0.890.53 query22 0.751.170.73 query23 14.87 1.370.61 query24 6.501.421.85 query25 0.510.160.11 query26 0.600.160.13 query27 0.050.050.04 query28 9.940.910.42 query29 12.53 3.903.23 query30 0.250.090.06 query31 2.820.590.38 query32 3.230.540.46 query33 2.962.982.96 query34 15.76 5.064.42 query35 4.504.464.54 query36 0.670.490.48 query37 0.090.060.06 query38 0.060.040.04 query39 0.030.020.03 query40 0.170.140.13 query41 0.080.020.03 query42 0.040.030.02 query43 0.040.030.03 Total cold run time: 104.59 s Total hot run time: 30.84 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2674420776 TPC-DS: Total hot run time: 183551 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit f34f8b817d7b6f055c19fc9c52e2f44cb442cdc0, data reload: false query1 967 382 377 377 query2 6539187018251825 query3 6793207 205 205 query4 25901 23534 23134 23134 query5 4386665 517 517 query6 323 200 184 184 query7 4613494 291 291 query8 297 248 246 246 query9 8622255025532550 query10 479 312 256 256 query11 15447 15131 14994 14994 query12 157 110 104 104 query13 1662515 404 404 query14 9301661966246619 query15 209 190 178 178 query16 7726608 450 450 query17 1195695 524 524 query18 1981386 294 294 query19 186 178 186 178 query20 122 111 113 111 query21 205 120 101 101 query22 4280418343614183 query23 34423 33519 33054 33054 query24 7662238023502350 query25 515 445 387 387 query26 1214280 151 151 query27 2092503 329 329 query28 3877239823822382 query29 707 532 414 414 query30 231 181 152 152 query31 910 850 776 776 query32 72 60 61 60 query33 542 363 298 298 query34 767 866 519 519 query35 788 829 726 726 query36 958 995 890 890 query37 122 97 79 79 query38 4273408241284082 query39 1413148913891389 query40 206 113 101 101 query41 78 51 49 49 query42 123 108 100 100 query43 486 492 483 483 query44 1320764 774 764 query45 177 166 160 160 query46 854 1100641 641 query47 1771179817261726 query48 394 421 310 310 query49 788 495 424 424 query50 697 737 418 418 query51 4221414441464144 query52 108 103 94 94 query53 232 261 187 187 query54 494 487 405 405 query55 80 81 80 80 query56 267 284 248 248 query57 1146110510801080 query58 247 233 233 233 query59 2673285626342634 query60 290 278 248 248 query61 117 113 114 113 query62 787 729 686 686 query63 228 187 185 185 query64 42941016713 713 query65 3211315030893089 query66 1083393 296 296 query67 15568 15546 15333 15333 query68 4423798 541 541 query69 483 300 265 265 query70 1179112010281028 query71 409 285 281 281 query72 5726354637943546 query73 695 739 356 356 query74 9028907188858885 query75 3139318927092709 query76 31961159740 740 query77 476 373 290 290 query78 9962993793039303 query79 2041824 595 595 query80 1133545 458 458 query81 532 278 242 242 query82 399 126 91 91 query83 162 170 150 150 query84 245 95 72 72 query85 754 343 305 305 query86 411 287 287 287 query87 4449458543174317 query88 3079220721892189 query89 399 324 279 279 query90 1795187 196 187 query91 138 143 110 110 query92 65 58 53 53 query93 14681010569 569 query94 697 411 299 299 query95 358 268 261 261 query96 503 534 280 280 query97 2758284726942694 query98 225 207 205 205 query99 1287139712571257 Total cold run time: 265511 ms Total hot run time: 183551 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2674396433 TPC-H: Total hot run time: 31306 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit f34f8b817d7b6f055c19fc9c52e2f44cb442cdc0, data reload: false -- Round 1 -- q1 17610 538951015101 q2 2052297 169 169 q3 10469 1503739 739 q4 10225 1020533 533 q5 7562254522482248 q6 192 169 139 139 q7 938 766 602 602 q8 9293136211191119 q9 4856472745414541 q10 6830230818741874 q11 473 280 252 252 q12 354 349 215 215 q13 1 368430463046 q14 245 224 203 203 q15 520 454 460 454 q16 619 610 577 577 q17 584 881 359 359 q18 6967615362036153 q19 1537964 537 537 q20 313 321 197 197 q21 2825210719361936 q22 376 322 312 312 Total cold run time: 102617 ms Total hot run time: 31306 ms - Round 2, with runtime_filter_mode=off - q1 5125508650745074 q2 239 340 236 236 q3 2173268722442244 q4 1426184513991399 q5 4205411041644110 q6 217 163 127 127 q7 1846181716971697 q8 2614261825132513 q9 7295707671627076 q10 2994319027522752 q11 586 501 513 501 q12 658 753 575 575 q13 3520391032323232 q14 278 290 277 277 q15 509 465 443 443 q16 653 672 631 631 q17 1116158813181318 q18 7629723572037203 q19 784 844 1029844 q20 2009199919061906 q21 5236492248694869 q22 609 625 558 558 Total cold run time: 51721 ms Total hot run time: 49585 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2674231791 TeamCity cloud ut coverage result: Function Coverage: 82.25% (1061/1290) Line Coverage: 65.78% (17594/26746) Region Coverage: 65.32% (8668/13271) Branch Coverage: 55.21% (4672/8462) Coverage Report: http://coverage.selectdb-in.cc/coverage/f34f8b817d7b6f055c19fc9c52e2f44cb442cdc0_f34f8b817d7b6f055c19fc9c52e2f44cb442cdc0_cloud/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2674219651 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2673562293 ClickBench: Total hot run time: 30.9 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 100f35897254d3bf5ad9959243acb259cabdabb3, data reload: false query1 0.030.030.04 query2 0.100.050.05 query3 0.290.050.05 query4 1.600.070.07 query5 0.400.400.39 query6 1.170.660.66 query7 0.020.020.02 query8 0.060.050.05 query9 0.610.530.54 query10 0.570.580.57 query11 0.240.120.12 query12 0.240.120.12 query13 0.630.610.62 query14 2.722.692.68 query15 0.990.860.85 query16 0.360.360.36 query17 1.031.021.04 query18 0.180.170.18 query19 1.911.831.91 query20 0.010.030.01 query21 15.38 0.980.67 query22 0.931.070.82 query23 14.67 1.560.74 query24 5.520.580.28 query25 0.170.090.09 query26 0.550.220.17 query27 0.090.080.09 query28 11.01 1.190.54 query29 12.56 4.013.36 query30 0.280.070.06 query31 2.840.590.42 query32 3.240.570.49 query33 3.153.043.04 query34 16.49 5.154.41 query35 4.444.414.42 query36 0.630.500.51 query37 0.200.170.16 query38 0.170.150.16 query39 0.050.050.04 query40 0.190.150.14 query41 0.100.050.05 query42 0.070.060.05 query43 0.050.050.04 Total cold run time: 105.94 s Total hot run time: 30.9 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2673579118 TeamCity be ut coverage result: Function Coverage: 44.31% (11698/26398) Line Coverage: 33.91% (97992/288975) Region Coverage: 32.98% (50166/152099) Branch Coverage: 28.64% (25223/88056) Coverage Report: http://coverage.selectdb-in.cc/coverage/100f35897254d3bf5ad9959243acb259cabdabb3_100f35897254d3bf5ad9959243acb259cabdabb3/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2673553449 TPC-DS: Total hot run time: 189985 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 100f35897254d3bf5ad9959243acb259cabdabb3, data reload: false query1 1299945 946 945 query2 6238183118611831 query3 10962 449745364497 query4 56994 24423 23565 23565 query5 5188523 504 504 query6 376 197 206 197 query7 5206497 296 296 query8 326 238 237 237 query9 6548254625762546 query10 415 317 250 250 query11 15218 15195 14807 14807 query12 161 107 110 107 query13 1209532 394 394 query14 10962 634965356349 query15 220 206 181 181 query16 7099659 505 505 query17 1063728 599 599 query18 1539411 322 322 query19 215 200 177 177 query20 122 163 132 132 query21 214 124 109 109 query22 4592455444174417 query23 33977 33192 33279 33192 query24 5649246024492449 query25 465 475 402 402 query26 684 276 164 164 query27 1678482 344 344 query28 3041251824532453 query29 565 548 420 420 query30 218 197 155 155 query31 921 859 801 801 query32 82 68 61 61 query33 472 348 296 296 query34 730 855 539 539 query35 820 858 759 759 query36 954 962 911 911 query37 120 95 76 76 query38 4355432642254225 query39 1513147914641464 query40 204 115 102 102 query41 52 48 50 48 query42 128 105 104 104 query43 484 494 493 493 query44 1300799 793 793 query45 202 175 165 165 query46 883 1063646 646 query47 1920188018201820 query48 385 411 319 319 query49 735 499 388 388 query50 701 755 422 422 query51 4393431942554255 query52 104 109 95 95 query53 231 267 187 187 query54 480 490 410 410 query55 85 86 80 80 query56 270 268 247 247 query57 1143118011081108 query58 252 238 243 238 query59 2738274526842684 query60 282 267 282 267 query61 122 118 119 118 query62 711 751 694 694 query63 237 204 206 204 query64 18101012667 667 query65 3192312631403126 query66 698 388 292 292 query67 15913 15700 15366 15366 query68 5348786 524 524 query69 521 299 266 266 query70 1215113611161116 query71 447 299 260 260 query72 6378359936903599 query73 1014735 350 350 query74 9157913589508950 query75 3454317726582658 query76 37571161713 713 query77 616 366 280 280 query78 10084 10159 92429242 query79 2124818 617 617 query80 789 520 451 451 query81 531 276 234 234 query82 388 135 98 98 query83 189 167 160 160 query84 288 101 67 67 query85 745 341 303 303 query86 407 287 286 286 query87 4619467043484348 query88 3320221421942194 query89 401 312 285 285 query90 1879192 193 192 query91 133 151 105 105 query92 76 64 59 59 query93 2785996 584 584 query94 664 418 298 298 query95 355 267 252 252 query96 479 544 276 276 query97 2751287927522752 query98 227 204 202 202 query99 1340141212481248 Total cold run time: 298546 ms Total hot run time: 189985 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2673537046 TPC-H: Total hot run time: 31606 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 100f35897254d3bf5ad9959243acb259cabdabb3, data reload: false -- Round 1 -- q1 17650 532751835183 q2 2059295 173 173 q3 10497 1241773 773 q4 10217 1006538 538 q5 7563243222832283 q6 192 174 134 134 q7 875 750 612 612 q8 9293131411811181 q9 4814456945494549 q10 6812230918781878 q11 491 274 257 257 q12 350 354 223 223 q13 17759 366830693069 q14 222 228 204 204 q15 507 457 461 457 q16 627 615 576 576 q17 586 866 333 333 q18 6640621761966196 q19 1491937 554 554 q20 303 321 190 190 q21 2769215619351935 q22 365 328 308 308 Total cold run time: 102082 ms Total hot run time: 31606 ms - Round 2, with runtime_filter_mode=off - q1 5137507251285072 q2 230 327 229 229 q3 2162268823172317 q4 1386178713841384 q5 4213415141224122 q6 211 164 126 126 q7 1889181116471647 q8 2564260625272527 q9 7229717171297129 q10 3008322628082808 q11 565 527 515 515 q12 713 796 620 620 q13 3485373732873287 q14 287 300 291 291 q15 507 487 465 465 q16 634 700 643 643 q17 1118157613591359 q18 7642745372407240 q19 777 885 961 885 q20 1956202518731873 q21 5549483548784835 q22 587 562 542 542 Total cold run time: 51849 ms Total hot run time: 49916 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2673344327 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2673364554 TeamCity cloud ut coverage result: Function Coverage: 82.25% (1061/1290) Line Coverage: 65.80% (17600/26746) Region Coverage: 65.35% (8673/13271) Branch Coverage: 55.27% (4677/8462) Coverage Report: http://coverage.selectdb-in.cc/coverage/100f35897254d3bf5ad9959243acb259cabdabb3_100f35897254d3bf5ad9959243acb259cabdabb3_cloud/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2672055394 TeamCity be ut coverage result: Function Coverage: 43.86% (11650/26560) Line Coverage: 33.77% (97650/289175) Region Coverage: 32.87% (49994/152117) Branch Coverage: 28.58% (25137/87940) Coverage Report: http://coverage.selectdb-in.cc/coverage/13b17f74a3eae7e36de463325599b15657f323e2_13b17f74a3eae7e36de463325599b15657f323e2/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2671952105 TeamCity cloud ut coverage result: Function Coverage: 82.25% (1061/1290) Line Coverage: 65.73% (17580/26746) Region Coverage: 65.27% (8662/13271) Branch Coverage: 55.18% (4669/8462) Coverage Report: http://coverage.selectdb-in.cc/coverage/13b17f74a3eae7e36de463325599b15657f323e2_13b17f74a3eae7e36de463325599b15657f323e2_cloud/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2671900606 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2671519998 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2671718138 TeamCity cloud ut coverage result: Function Coverage: 82.25% (1061/1290) Line Coverage: 65.77% (17590/26746) Region Coverage: 65.31% (8667/13271) Branch Coverage: 55.24% (4674/8462) Coverage Report: http://coverage.selectdb-in.cc/coverage/83be1ff8f997a6989c78e84fb371e2fb8017d28b_83be1ff8f997a6989c78e84fb371e2fb8017d28b_cloud/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2671695205 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2671541425 TeamCity cloud ut coverage result: Function Coverage: 82.25% (1061/1290) Line Coverage: 65.77% (17590/26746) Region Coverage: 65.31% (8667/13271) Branch Coverage: 55.20% (4671/8462) Coverage Report: http://coverage.selectdb-in.cc/coverage/149100798838ee56c7e42a188067f2607273933c_149100798838ee56c7e42a188067f2607273933c_cloud/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on code in PR #47319: URL: https://github.com/apache/doris/pull/47319#discussion_r1963344106 ## fe/fe-core/src/main/java/org/apache/doris/analysis/TimeV2Literal.java: ## @@ -0,0 +1,301 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.analysis; + +import org.apache.doris.catalog.ScalarType; +import org.apache.doris.catalog.Type; +import org.apache.doris.common.FormatOptions; +import org.apache.doris.nereids.exceptions.AnalysisException; +import org.apache.doris.thrift.TExprNode; +import org.apache.doris.thrift.TExprNodeType; +import org.apache.doris.thrift.TTimeV2Literal; + +public class TimeV2Literal extends LiteralExpr { + +public static final TimeV2Literal MIN_TIME = new TimeV2Literal(-838, 0, 0, 0, 0); +public static final TimeV2Literal MAX_TIME = new TimeV2Literal(838, 59, 59, 99, 6); + +// The time may start at -0. To keep this negative sign need to use a float number. +protected double hour; +protected long minute; +protected long second; +protected long microsecond; + +/** + * C'tor forcing type, e.g., due to implicit cast + */ +// for restore +private TimeV2Literal() { +this.type = Type.TIMEV2; +this.hour = 0; +this.minute = 0; +this.second = 0; +this.microsecond = 0; +} + +public TimeV2Literal(double value) { Review Comment: 12345678901234567890 is too large for timetype, the max value is 30203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
morrySnow commented on code in PR #47319: URL: https://github.com/apache/doris/pull/47319#discussion_r1961289901 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/TimeV2Literal.java: ## @@ -0,0 +1,295 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.expressions.literal; + +import org.apache.doris.analysis.LiteralExpr; +import org.apache.doris.nereids.exceptions.AnalysisException; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor; +import org.apache.doris.nereids.types.TimeV2Type; + +import java.time.LocalDateTime; + +/** + * Time literal in Nereids. + */ +public class TimeV2Literal extends Literal { +private static final LocalDateTime START_OF_A_DAY = LocalDateTime.of(0, 1, 1, 0, 0, 0); +private static final LocalDateTime END_OF_A_DAY = LocalDateTime.of(, 12, 31, 23, 59, 59, 99000); +private static final TimeV2Literal MIN_TIME = new TimeV2Literal(-838, 0, 0, 0, 0); +private static final TimeV2Literal MAX_TIME = new TimeV2Literal(838, 59, 59, 99, 6); + +// The time may start at -0. To keep this negative sign need to use a float number. +protected double hour; +protected long minute; +protected long second; +protected long microsecond; +protected long scale; + +public TimeV2Literal(String s) throws AnalysisException { +this(TimeV2Type.INSTANCE, s); Review Comment: should not use TimeV2Type.INSTANCE here. should get scale info and generate right type from parameter `s`, u could refer to decimalv3 literal ## fe/fe-core/src/main/java/org/apache/doris/analysis/TimeV2Literal.java: ## @@ -0,0 +1,301 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.analysis; + +import org.apache.doris.catalog.ScalarType; +import org.apache.doris.catalog.Type; +import org.apache.doris.common.FormatOptions; +import org.apache.doris.nereids.exceptions.AnalysisException; +import org.apache.doris.thrift.TExprNode; +import org.apache.doris.thrift.TExprNodeType; +import org.apache.doris.thrift.TTimeV2Literal; + +public class TimeV2Literal extends LiteralExpr { + +public static final TimeV2Literal MIN_TIME = new TimeV2Literal(-838, 0, 0, 0, 0); +public static final TimeV2Literal MAX_TIME = new TimeV2Literal(838, 59, 59, 99, 6); + +// The time may start at -0. To keep this negative sign need to use a float number. +protected double hour; +protected long minute; +protected long second; +protected long microsecond; Review Comment: why them are long not int? `minute` could larger than 59? ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/TimeV2Literal.java: ## @@ -0,0 +1,295 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2664558313 ClickBench: Total hot run time: 31.09 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 13c50b82368aae805c16a4a69c9ac59661e42a26, data reload: false query1 0.030.030.03 query2 0.100.050.05 query3 0.280.050.05 query4 1.590.090.08 query5 0.410.390.40 query6 1.160.650.65 query7 0.020.020.02 query8 0.050.040.05 query9 0.620.520.52 query10 0.590.580.58 query11 0.250.130.12 query12 0.240.120.12 query13 0.630.610.60 query14 2.702.712.72 query15 0.980.870.87 query16 0.380.370.39 query17 1.021.061.04 query18 0.180.180.18 query19 1.941.822.08 query20 0.020.020.02 query21 15.39 0.960.65 query22 0.921.010.77 query23 14.70 1.500.73 query24 7.520.880.42 query25 0.160.090.09 query26 0.610.240.18 query27 0.090.090.08 query28 11.06 1.170.55 query29 12.60 4.113.34 query30 0.280.080.06 query31 2.810.620.41 query32 3.220.590.49 query33 3.103.063.10 query34 16.50 5.164.39 query35 4.514.474.47 query36 0.620.520.50 query37 0.190.160.16 query38 0.170.160.15 query39 0.050.050.04 query40 0.190.150.16 query41 0.110.060.05 query42 0.060.050.05 query43 0.050.040.04 Total cold run time: 108.1 s Total hot run time: 31.09 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2664552186 TPC-DS: Total hot run time: 189665 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 13c50b82368aae805c16a4a69c9ac59661e42a26, data reload: false query1 1327934 954 934 query2 6224187019181870 query3 11099 457746374577 query4 25158 23374 23076 23076 query5 3677617 513 513 query6 285 204 190 190 query7 3998500 292 292 query8 301 252 246 246 query9 8451255025662550 query10 447 295 246 246 query11 15364 15260 14847 14847 query12 158 109 105 105 query13 1583532 371 371 query14 9372636470606364 query15 215 189 168 168 query16 7627620 444 444 query17 1173685 573 573 query18 2022416 318 318 query19 191 193 162 162 query20 122 119 127 119 query21 204 123 104 104 query22 4387454641824182 query23 34448 33489 33653 33489 query24 7843238724472387 query25 494 473 395 395 query26 718 277 153 153 query27 2077498 324 324 query28 4335247224302430 query29 602 560 431 431 query30 226 186 160 160 query31 922 931 784 784 query32 72 66 64 64 query33 549 381 312 312 query34 788 886 509 509 query35 836 866 771 771 query36 981 1006928 928 query37 129 105 79 79 query38 4310444244234423 query39 1502142314861423 query40 207 112 101 101 query41 53 51 53 51 query42 128 111 103 103 query43 509 509 503 503 query44 1305813 813 813 query45 181 180 169 169 query46 879 1056649 649 query47 1827182617941794 query48 424 419 318 318 query49 699 514 421 421 query50 713 757 427 427 query51 4265431742054205 query52 110 104 99 99 query53 229 254 229 229 query54 499 476 412 412 query55 81 84 86 84 query56 272 288 264 264 query57 1133117311101110 query58 249 243 237 237 query59 2938286426252625 query60 295 267 258 258 query61 139 114 109 109 query62 792 740 680 680 query63 230 195 192 192 query64 28661029664 664 query65 3448323732573237 query66 807 419 328 328 query67 16037 15701 15180 15180 query68 6747763 522 522 query69 483 312 263 263 query70 1218111510891089 query71 426 300 277 277 query72 5306361137543611 query73 759 719 355 355 query74 8941927988278827 query75 3160316926882688 query76 30901180766 766 query77 480 378 276 276 query78 10180 994393249324 query79 3005795 660 660 query80 684 533 462 462 query81 501 272 241 241 query82 693 131 93 93 query83 165 165 149 149 query84 237 88 69 69 query85 793 366 291 291 query86 371 291 320 291 query87 4452443943634363 query88 3850222022052205 query89 410 314 292 292 query90 1847197 188 188 query91 132 144 108 108 query92 70 59 55 55 query93 22681002592 592 query94 709 426 292 292 query95 355 276 260 260 query96 478 572 270 270 query97 2777283327062706 query98 230 210 206 206 query99 1353140912991299 Total cold run time: 271702 ms Total hot run time: 189665 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2664541718 TPC-H: Total hot run time: 31948 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 13c50b82368aae805c16a4a69c9ac59661e42a26, data reload: false -- Round 1 -- q1 17618 538352355235 q2 2054304 172 172 q3 10446 1251767 767 q4 10204 1024550 550 q5 7575243323462346 q6 194 171 141 141 q7 935 765 606 606 q8 9310134011661166 q9 4943473848244738 q10 6825231619061906 q11 475 283 255 255 q12 358 364 225 225 q13 17783 369930893089 q14 227 224 212 212 q15 517 483 462 462 q16 635 602 566 566 q17 594 870 364 364 q18 6834626860916091 q19 1640955 569 569 q20 319 323 204 204 q21 2793217319861986 q22 365 332 298 298 Total cold run time: 102644 ms Total hot run time: 31948 ms - Round 2, with runtime_filter_mode=off - q1 5239521551935193 q2 236 333 234 234 q3 2193272222822282 q4 1513182413751375 q5 4205416641884166 q6 214 169 127 127 q7 1853183316761676 q8 2625254726742547 q9 7224715470807080 q10 3054323727952795 q11 584 518 505 505 q12 747 814 608 608 q13 3650382733483348 q14 291 293 277 277 q15 513 472 466 466 q16 632 687 631 631 q17 1139163813621362 q18 7689728271377137 q19 862 809 875 809 q20 2040200918891889 q21 5439500949924992 q22 639 583 529 529 Total cold run time: 52581 ms Total hot run time: 50028 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2662461969 TPC-DS: Total hot run time: 190135 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 13c50b82368aae805c16a4a69c9ac59661e42a26, data reload: false query1 1327959 942 942 query2 6197194219131913 query3 11081 452145504521 query4 54146 25366 23377 23377 query5 5194520 479 479 query6 397 213 169 169 query7 5140487 298 298 query8 316 233 214 214 query9 6903247324962473 query10 417 289 249 249 query11 15346 15126 14847 14847 query12 167 113 106 106 query13 1217505 386 386 query14 10642 680566216621 query15 197 202 189 189 query16 7049667 526 526 query17 1113741 588 588 query18 1514399 323 323 query19 204 198 167 167 query20 126 123 122 122 query21 216 136 108 108 query22 4323464143794379 query23 34095 33429 33427 33427 query24 5697241324402413 query25 462 456 439 439 query26 708 285 153 153 query27 1962480 343 343 query28 2765243724042404 query29 583 566 430 430 query30 206 188 148 148 query31 895 852 828 828 query32 72 80 62 62 query33 440 351 308 308 query34 757 838 482 482 query35 805 812 749 749 query36 962 980 922 922 query37 114 96 74 74 query38 4293443443064306 query39 1483148414451445 query40 202 115 102 102 query41 53 50 50 50 query42 132 104 105 104 query43 512 530 495 495 query44 1279799 802 799 query45 184 175 164 164 query46 881 1066669 669 query47 1850189718321832 query48 390 410 295 295 query49 720 527 419 419 query50 731 769 431 431 query51 4387417942404179 query52 107 105 102 102 query53 231 261 191 191 query54 473 499 410 410 query55 85 77 82 77 query56 263 272 257 257 query57 1190117511511151 query58 247 240 245 240 query59 3074298927722772 query60 285 282 268 268 query61 119 123 118 118 query62 749 777 705 705 query63 248 195 191 191 query64 18411030652 652 query65 3319325331723172 query66 723 382 333 333 query67 15872 15504 15382 15382 query68 5601764 497 497 query69 530 300 264 264 query70 1276109410991094 query71 461 294 262 262 query72 5848345537773455 query73 1070720 335 335 query74 9042917287408740 query75 3263318827112711 query76 39681163734 734 query77 529 367 278 278 query78 10026 10041 93969396 query79 2370803 594 594 query80 587 526 429 429 query81 497 274 233 233 query82 462 129 96 96 query83 171 166 158 158 query84 291 86 67 67 query85 769 344 293 293 query86 389 285 287 285 query87 4421462943364336 query88 3524215721392139 query89 402 315 291 291 query90 1768189 190 189 query91 131 134 108 108 query92 76 58 55 55 query93 19591014570 570 query94 689 407 302 302 query95 345 262 254 254 query96 479 562 273 273 query97 2828283227352735 query98 227 201 212 201 query99 1325137012711271 Total cold run time: 295002 ms Total hot run time: 190135 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2662456463 TeamCity be ut coverage result: Function Coverage: 43.84% (11456/26129) Line Coverage: 33.83% (96472/285146) Region Coverage: 32.53% (49337/151650) Branch Coverage: 28.21% (24803/87910) Coverage Report: http://coverage.selectdb-in.cc/coverage/13c50b82368aae805c16a4a69c9ac59661e42a26_13c50b82368aae805c16a4a69c9ac59661e42a26/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2662434415 TPC-H: Total hot run time: 31791 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 13c50b82368aae805c16a4a69c9ac59661e42a26, data reload: false -- Round 1 -- q1 17672 535151475147 q2 2058304 172 172 q3 10584 1270764 764 q4 10218 1047571 571 q5 7625236823832368 q6 190 166 139 139 q7 901 759 603 603 q8 9312129810861086 q9 4868466446644664 q10 6831229818911891 q11 488 279 258 258 q12 357 361 219 219 q13 17803 373130583058 q14 228 226 214 214 q15 516 479 459 459 q16 643 633 572 572 q17 604 848 348 348 q18 6945623262116211 q19 1597948 550 550 q20 302 325 191 191 q21 2948215119931993 q22 370 327 313 313 Total cold run time: 103060 ms Total hot run time: 31791 ms - Round 2, with runtime_filter_mode=off - q1 5148518151515151 q2 241 324 234 234 q3 2156271323532353 q4 1441188213441344 q5 4226411541804115 q6 209 165 125 125 q7 1879182717721772 q8 2618278726652665 q9 7206713071197119 q10 3037324928112811 q11 577 539 487 487 q12 678 812 617 617 q13 3351398533043304 q14 281 309 273 273 q15 521 471 478 471 q16 643 682 642 642 q17 1115161013611361 q18 7651736373307330 q19 819 818 849 818 q20 1964199819641964 q21 5582505447764776 q22 631 599 578 578 Total cold run time: 51974 ms Total hot run time: 50310 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2662328902 TeamCity cloud ut coverage result: Function Coverage: 82.25% (1061/1290) Line Coverage: 65.74% (17583/26746) Region Coverage: 65.26% (8660/13271) Branch Coverage: 55.16% (4668/8462) Coverage Report: http://coverage.selectdb-in.cc/coverage/13c50b82368aae805c16a4a69c9ac59661e42a26_13c50b82368aae805c16a4a69c9ac59661e42a26_cloud/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2662313759 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2660996132 ClickBench: Total hot run time: 31.36 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 227a869a26e7998923ad0542db26fb09c4b3197c, data reload: false query1 0.040.040.03 query2 0.100.040.05 query3 0.270.060.06 query4 1.620.080.07 query5 0.420.400.40 query6 1.150.660.67 query7 0.030.020.02 query8 0.060.050.05 query9 0.620.530.52 query10 0.580.590.60 query11 0.250.120.12 query12 0.250.120.12 query13 0.630.620.62 query14 2.662.722.71 query15 1.000.880.88 query16 0.370.370.38 query17 1.021.011.07 query18 0.190.180.19 query19 1.981.742.03 query20 0.010.010.01 query21 15.38 0.970.66 query22 0.931.070.80 query23 14.67 1.510.74 query24 7.710.900.38 query25 0.180.090.08 query26 0.620.240.19 query27 0.090.090.09 query28 11.04 1.230.56 query29 12.58 4.063.42 query30 0.280.080.06 query31 2.840.650.42 query32 3.220.620.49 query33 3.013.073.16 query34 16.54 5.254.49 query35 4.494.594.56 query36 0.620.500.50 query37 0.200.170.18 query38 0.170.160.15 query39 0.040.040.04 query40 0.200.160.15 query41 0.120.060.05 query42 0.060.050.06 query43 0.050.040.05 Total cold run time: 108.29 s Total hot run time: 31.36 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2660994255 TPC-DS: Total hot run time: 189989 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 227a869a26e7998923ad0542db26fb09c4b3197c, data reload: false query1 1306983 930 930 query2 6222186118061806 query3 0 467545674567 query4 54254 24996 22950 22950 query5 5183552 473 473 query6 348 186 185 185 query7 4996517 297 297 query8 325 245 236 236 query9 6346252025202520 query10 414 309 264 264 query11 15185 15086 14909 14909 query12 165 109 110 109 query13 1104529 385 385 query14 10644 658565136513 query15 204 218 195 195 query16 7106663 490 490 query17 1097752 611 611 query18 1539413 314 314 query19 221 208 170 170 query20 148 150 137 137 query21 217 134 103 103 query22 4536440044314400 query23 34062 3 33472 3 query24 5605246624692466 query25 476 472 405 405 query26 737 279 163 163 query27 1775494 342 342 query28 2696244224002400 query29 610 592 433 433 query30 211 196 166 166 query31 886 864 834 834 query32 77 65 61 61 query33 483 375 312 312 query34 771 875 518 518 query35 821 844 768 768 query36 940 1000917 917 query37 121 101 75 75 query38 4326439044174390 query39 1479145014401440 query40 206 115 107 107 query41 53 51 48 48 query42 119 108 107 107 query43 500 515 479 479 query44 1356807 801 801 query45 185 183 165 165 query46 915 1087676 676 query47 1865184518301830 query48 389 436 308 308 query49 736 532 435 435 query50 752 776 428 428 query51 4268427842144214 query52 111 103 95 95 query53 247 272 198 198 query54 491 500 415 415 query55 86 79 79 79 query56 273 282 243 243 query57 1146116810841084 query58 247 249 242 242 query59 2722282726912691 query60 286 288 276 276 query61 146 115 120 115 query62 761 733 722 722 query63 236 205 211 205 query64 21221073693 693 query65 3383333831673167 query66 763 405 297 297 query67 15910 15650 15307 15307 query68 5631774 511 511 query69 579 310 262 262 query70 1219109810651065 query71 444 301 280 280 query72 5887364138003641 query73 1179768 353 353 query74 8931905589828982 query75 3189317226932693 query76 39581194767 767 query77 553 392 282 282 query78 992010024 92379237 query79 2593806 606 606 query80 692 545 461 461 query81 502 282 236 236 query82 447 132 98 98 query83 180 168 155 155 query84 284 95 72 72 query85 784 414 308 308 query86 382 294 295 294 query87 4502446343134313 query88 3669216721552155 query89 414 326 294 294 query90 1770192 196 192 query91 139 140 113 113 query92 80 64 54 54 query93 21191012578 578 query94 694 392 281 281 query95 342 268 263 263 query96 481 565 263 263 query97 2861284327052705 query98 230 198 198 198 query99 1347137812631263 Total cold run time: 295022 ms Total hot run time: 189989 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2660992970 TeamCity be ut coverage result: Function Coverage: 43.37% (11326/26115) Line Coverage: 33.37% (95129/285064) Region Coverage: 32.16% (48761/151613) Branch Coverage: 27.98% (24593/87892) Coverage Report: http://coverage.selectdb-in.cc/coverage/227a869a26e7998923ad0542db26fb09c4b3197c_227a869a26e7998923ad0542db26fb09c4b3197c/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2660989739 TPC-H: Total hot run time: 31886 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 227a869a26e7998923ad0542db26fb09c4b3197c, data reload: false -- Round 1 -- q1 17671 521851205120 q2 2054311 172 172 q3 10760 1269787 787 q4 10319 1013544 544 q5 8601234823512348 q6 190 164 131 131 q7 898 772 596 596 q8 9295129510961096 q9 4897480348364803 q10 6825231018841884 q11 472 268 258 258 q12 347 352 220 220 q13 17796 368831233123 q14 229 233 213 213 q15 505 469 463 463 q16 622 616 586 586 q17 557 854 337 337 q18 6637624562286228 q19 1533942 550 550 q20 323 330 187 187 q21 2794211919381938 q22 358 331 302 302 Total cold run time: 103683 ms Total hot run time: 31886 ms - Round 2, with runtime_filter_mode=off - q1 5177510251475102 q2 237 323 235 235 q3 2154267222942294 q4 1480183213781378 q5 4255418241564156 q6 209 165 124 124 q7 1853181717721772 q8 2634271726002600 q9 7293715571787155 q10 3006324227942794 q11 584 512 482 482 q12 684 765 611 611 q13 3385400932923292 q14 287 289 267 267 q15 502 465 454 454 q16 636 689 631 631 q17 1130163213171317 q18 7546735372057205 q19 811 787 921 787 q20 1971202818841884 q21 5497501248484848 q22 619 576 546 546 Total cold run time: 51950 ms Total hot run time: 49934 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2660975608 TeamCity cloud ut coverage result: Function Coverage: 82.25% (1061/1290) Line Coverage: 65.76% (17589/26746) Region Coverage: 65.31% (8667/13271) Branch Coverage: 55.21% (4672/8462) Coverage Report: http://coverage.selectdb-in.cc/coverage/227a869a26e7998923ad0542db26fb09c4b3197c_227a869a26e7998923ad0542db26fb09c4b3197c_cloud/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2660968500 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2660897532 TeamCity be ut coverage result: Function Coverage: 43.37% (11326/26115) Line Coverage: 33.37% (95129/285063) Region Coverage: 32.16% (48755/151613) Branch Coverage: 27.98% (24593/87892) Coverage Report: http://coverage.selectdb-in.cc/coverage/6320deabbc4f7243e55bd2e0617017ee1bb17d35_6320deabbc4f7243e55bd2e0617017ee1bb17d35/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2660890961 ClickBench: Total hot run time: 31.23 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 6320deabbc4f7243e55bd2e0617017ee1bb17d35, data reload: false query1 0.040.040.03 query2 0.100.040.05 query3 0.280.050.06 query4 1.610.060.08 query5 0.420.400.39 query6 1.160.660.65 query7 0.020.020.02 query8 0.060.050.05 query9 0.620.510.52 query10 0.590.590.57 query11 0.240.120.12 query12 0.250.130.12 query13 0.630.620.61 query14 2.662.752.72 query15 1.010.870.87 query16 0.370.360.37 query17 1.031.051.01 query18 0.220.200.20 query19 1.981.851.98 query20 0.010.010.01 query21 15.39 0.970.67 query22 0.931.050.78 query23 14.70 1.450.72 query24 7.500.900.41 query25 0.180.090.08 query26 0.610.240.19 query27 0.090.090.09 query28 11.04 1.130.55 query29 12.55 3.943.37 query30 0.270.080.06 query31 2.800.600.42 query32 3.240.590.50 query33 3.023.053.10 query34 16.39 5.214.46 query35 4.524.484.51 query36 0.630.510.50 query37 0.210.190.18 query38 0.180.160.16 query39 0.050.040.04 query40 0.190.160.15 query41 0.100.050.04 query42 0.060.050.05 query43 0.060.040.04 Total cold run time: 108.01 s Total hot run time: 31.23 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2660889020 TPC-DS: Total hot run time: 189858 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 6320deabbc4f7243e55bd2e0617017ee1bb17d35, data reload: false query1 1313963 933 933 query2 6183184418091809 query3 11071 451544544454 query4 54038 25478 23260 23260 query5 5106594 501 501 query6 346 190 181 181 query7 4866514 302 302 query8 314 250 238 238 query9 5589252625112511 query10 433 315 254 254 query11 15124 15036 15200 15036 query12 157 112 104 104 query13 1050511 405 405 query14 10156 684663536353 query15 208 206 171 171 query16 7145659 458 458 query17 1105725 583 583 query18 1759441 327 327 query19 201 199 170 170 query20 132 133 123 123 query21 214 124 108 108 query22 4359454444834483 query23 33986 33422 33752 33422 query24 5734243824482438 query25 473 465 411 411 query26 699 280 155 155 query27 1820487 337 337 query28 3480244324102410 query29 583 565 421 421 query30 218 192 156 156 query31 906 893 828 828 query32 71 63 61 61 query33 443 372 298 298 query34 774 862 513 513 query35 800 849 770 770 query36 940 998 908 908 query37 116 102 74 74 query38 4266441642894289 query39 1527144214421442 query40 211 115 105 105 query41 51 52 49 49 query42 126 107 112 107 query43 502 511 508 508 query44 1281799 796 796 query45 181 175 171 171 query46 878 1068674 674 query47 1856185917751775 query48 387 426 318 318 query49 728 515 410 410 query50 699 749 451 451 query51 4403425042304230 query52 102 108 108 108 query53 246 269 188 188 query54 487 501 409 409 query55 80 87 85 85 query56 286 299 279 279 query57 1175118911231123 query58 251 247 241 241 query59 2623264824692469 query60 274 264 259 259 query61 122 118 116 116 query62 729 722 655 655 query63 219 190 190 190 query64 19521050668 668 query65 3199312431373124 query66 761 396 294 294 query67 15858 15645 15443 15443 query68 5751766 500 500 query69 533 307 302 302 query70 1176112610261026 query71 469 317 278 278 query72 6342375037003700 query73 1362748 341 341 query74 9014943488538853 query75 3184315127052705 query76 38701197749 749 query77 512 377 280 280 query78 10115 10055 92429242 query79 2978819 599 599 query80 735 542 456 456 query81 509 324 226 226 query82 563 126 99 99 query83 175 170 147 147 query84 300 95 79 79 query85 757 350 303 303 query86 356 313 282 282 query87 4383460843044304 query88 3542217821582158 query89 411 308 289 289 query90 1709192 194 192 query91 140 144 111 111 query92 73 64 60 60 query93 21861021592 592 query94 720 423 305 305 query95 346 273 260 260 query96 480 567 268 268 query97 2818285527442744 query98 229 216 200 200 query99 1682139812661266 Total cold run time: 294792 ms Total hot run time: 189858 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2660885917 TPC-H: Total hot run time: 31569 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 6320deabbc4f7243e55bd2e0617017ee1bb17d35, data reload: false -- Round 1 -- q1 17596 518250105010 q2 2051332 167 167 q3 10369 1318713 713 q4 10219 1011547 547 q5 7535237723892377 q6 187 165 133 133 q7 900 739 592 592 q8 9299132210931093 q9 5029484447104710 q10 6839233118901890 q11 459 272 248 248 q12 346 354 220 220 q13 17770 368730713071 q14 222 227 216 216 q15 510 471 455 455 q16 632 622 581 581 q17 570 861 347 347 q18 6469630761866186 q19 874 926 534 534 q20 314 328 195 195 q21 2709216719961996 q22 380 336 288 288 Total cold run time: 101279 ms Total hot run time: 31569 ms - Round 2, with runtime_filter_mode=off - q1 5049514950955095 q2 228 326 230 230 q3 2207266723342334 q4 1416181413581358 q5 4249413741904137 q6 207 166 121 121 q7 1862181016731673 q8 2568266626242624 q9 7281723472337233 q10 2959312528232823 q11 564 524 493 493 q12 666 772 619 619 q13 3495459032613261 q14 278 309 279 279 q15 509 471 463 463 q16 643 703 650 650 q17 1130160013351335 q18 7696744173297329 q19 773 803 846 803 q20 1969204919111911 q21 5160481048514810 q22 649 576 529 529 Total cold run time: 51558 ms Total hot run time: 50110 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2660885224 TeamCity cloud ut coverage result: Function Coverage: 82.25% (1061/1290) Line Coverage: 65.76% (17587/26746) Region Coverage: 65.29% (8665/13271) Branch Coverage: 55.24% (4674/8462) Coverage Report: http://coverage.selectdb-in.cc/coverage/6320deabbc4f7243e55bd2e0617017ee1bb17d35_6320deabbc4f7243e55bd2e0617017ee1bb17d35_cloud/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2660877526 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2660868256 TeamCity be ut coverage result: Function Coverage: 43.37% (11326/26115) Line Coverage: 33.36% (95095/285063) Region Coverage: 32.16% (48754/151613) Branch Coverage: 27.98% (24593/87892) Coverage Report: http://coverage.selectdb-in.cc/coverage/75bebef9faccb7c8e2f9e98b2724269394b818cb_75bebef9faccb7c8e2f9e98b2724269394b818cb/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2660852365 TeamCity cloud ut coverage result: Function Coverage: 82.25% (1061/1290) Line Coverage: 65.77% (17590/26746) Region Coverage: 65.30% (8666/13271) Branch Coverage: 55.24% (4674/8462) Coverage Report: http://coverage.selectdb-in.cc/coverage/75bebef9faccb7c8e2f9e98b2724269394b818cb_75bebef9faccb7c8e2f9e98b2724269394b818cb_cloud/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org