Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
github-actions[bot] commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2934434033 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
zclllyybb merged PR #47319: URL: https://github.com/apache/doris/pull/47319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2921324046 ClickBench: Total hot run time: 29.71 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 26662bd1038e97dc7dab3cfca26a1e0a73b7016b, data reload: false query1 0.040.040.03 query2 0.150.110.11 query3 0.350.200.20 query4 1.590.210.21 query5 0.460.450.45 query6 1.170.650.68 query7 0.020.010.01 query8 0.050.050.04 query9 0.610.520.52 query10 0.570.570.57 query11 0.250.120.13 query12 0.280.140.14 query13 0.630.620.62 query14 0.800.810.82 query15 0.950.880.88 query16 0.380.370.37 query17 1.021.011.04 query18 0.200.180.18 query19 1.921.771.79 query20 0.020.010.01 query21 15.42 0.980.66 query22 0.921.030.85 query23 14.69 1.460.76 query24 5.510.540.27 query25 0.170.100.09 query26 0.560.210.18 query27 0.090.090.08 query28 11.02 1.180.57 query29 12.55 4.003.44 query30 0.280.090.07 query31 2.800.620.43 query32 3.240.580.52 query33 3.053.103.07 query34 16.22 5.174.42 query35 4.464.524.44 query36 0.630.500.50 query37 0.190.170.17 query38 0.160.150.16 query39 0.050.040.04 query40 0.190.170.16 query41 0.100.050.05 query42 0.060.050.05 query43 0.050.040.04 Total cold run time: 103.87 s Total hot run time: 29.71 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2921315743 TPC-DS: Total hot run time: 192845 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 26662bd1038e97dc7dab3cfca26a1e0a73b7016b, data reload: false query1 1388108610441044 query2 6383181717791779 query3 11051 443146264431 query4 52242 25526 23299 23299 query5 5098578 463 463 query6 336 216 206 206 query7 4896510 302 302 query8 289 233 221 221 query9 5733267026772670 query10 450 330 275 275 query11 15018 15128 14809 14809 query12 160 108 111 108 query13 1053534 418 418 query14 9982639063916390 query15 206 207 170 170 query16 7047650 504 504 query17 1100776 557 557 query18 1570401 320 320 query19 212 189 174 174 query20 136 129 127 127 query21 204 126 113 113 query22 4441438343484348 query23 34365 33683 33686 33683 query24 6631246024812460 query25 483 471 406 406 query26 730 276 160 160 query27 2343530 339 339 query28 3134219421902190 query29 583 575 428 428 query30 284 238 198 198 query31 859 839 765 765 query32 71 59 66 59 query33 437 380 326 326 query34 798 844 525 525 query35 824 860 765 765 query36 955 994 906 906 query37 111 103 82 82 query38 4247418842454188 query39 1525148815051488 query40 214 124 119 119 query41 67 58 58 58 query42 129 114 111 111 query43 502 496 475 475 query44 1366870 848 848 query45 183 172 169 169 query46 851 1025652 652 query47 1883188717861786 query48 400 423 311 311 query49 654 489 410 410 query50 667 700 421 421 query51 4261424742814247 query52 118 115 108 108 query53 233 267 185 185 query54 606 591 514 514 query55 89 91 85 85 query56 334 294 300 294 query57 1195122911521152 query58 274 275 266 266 query59 2656277226442644 query60 320 323 322 322 query61 132 128 137 128 query62 748 746 704 704 query63 230 203 203 203 query64 18241012666 666 query65 4233414341414141 query66 718 397 297 297 query67 15820 15678 15451 15451 query68 6805892 529 529 query69 546 296 259 259 query70 1244111810581058 query71 502 331 307 307 query72 6041488649594886 query73 1487686 366 366 query74 9254884087388738 query75 4008322827732773 query76 42701191738 738 query77 695 396 294 294 query78 10168 10229 93199319 query79 2632813 588 588 query80 573 510 446 446 query81 498 260 218 218 query82 442 123 100 100 query83 314 255 242 242 query84 292 100 93 93 query85 810 346 312 312 query86 362 319 278 278 query87 4375440743474347 query88 3671230223002300 query89 407 313 287 287 query90 1822206 206 206 query91 139 138 110 110 query92 74 58 59 58 query93 2168919 584 584 query94 677 409 306 306 query95 359 291 291 291 query96 504 564 281 281 query97 2734277626162616 query98 226 205 201 201 query99 1478137712511251 Total cold run time: 297659 ms Total hot run time: 192845 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2921297391 TPC-H: Total hot run time: 33932 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 26662bd1038e97dc7dab3cfca26a1e0a73b7016b, data reload: false -- Round 1 -- q1 26501 511252945112 q2 1967295 184 184 q3 10398 1263721 721 q4 10229 1003555 555 q5 7659238623022302 q6 184 165 133 133 q7 912 751 635 635 q8 9311129111051105 q9 6743511050415041 q10 6877231718881888 q11 491 289 274 274 q12 356 362 227 227 q13 17785 369130723072 q14 245 233 225 225 q15 559 501 484 484 q16 433 443 377 377 q17 594 865 364 364 q18 7805724970687068 q19 1695980 573 573 q20 334 342 218 218 q21 3849254423952395 q22 10691042979 979 Total cold run time: 115996 ms Total hot run time: 33932 ms - Round 2, with runtime_filter_mode=off - q1 5235513251735132 q2 237 332 220 220 q3 2198267822832283 q4 1359184514311431 q5 4431441143864386 q6 219 166 133 133 q7 2017197117691769 q8 2594268026032603 q9 7250703372597033 q10 3039316327662766 q11 593 528 502 502 q12 671 767 598 598 q13 3521389033843384 q14 279 310 266 266 q15 519 489 489 489 q16 464 496 450 450 q17 1173152914061406 q18 7793759474657465 q19 846 855 913 855 q20 1926203018961896 q21 4913456244354435 q22 1081107110471047 Total cold run time: 52358 ms Total hot run time: 50549 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2921238603 run external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2921131040 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2921131185 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2921131348 run external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2918735747 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/26662bd1038e97dc7dab3cfca26a1e0a73b7016b_26662bd1038e97dc7dab3cfca26a1e0a73b7016b_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/26662bd1038e97dc7dab3cfca26a1e0a73b7016b_26662bd1038e97dc7dab3cfca26a1e0a73b7016b_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 83.26% (1114/1338) | | Line Coverage | 66.48% (18806/28287) | | Region Coverage | 66.12% (9321/14098) | | Branch Coverage | 56.06% (5032/8976) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2918697537 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2918524528 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2916075900 ClickBench: Total hot run time: 28.56 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit b4497029fb5e5f88b6d4f2d5cddae5a24e5e9d84, data reload: false query1 0.040.040.03 query2 0.120.110.12 query3 0.250.210.20 query4 1.590.210.11 query5 0.430.440.42 query6 1.170.670.66 query7 0.020.020.02 query8 0.040.040.03 query9 0.600.510.50 query10 0.570.580.56 query11 0.160.100.11 query12 0.150.120.12 query13 0.620.590.59 query14 0.780.810.81 query15 0.860.870.85 query16 0.370.380.37 query17 1.031.031.04 query18 0.220.210.21 query19 1.921.811.89 query20 0.020.010.02 query21 15.41 0.920.54 query22 0.751.180.73 query23 14.84 1.370.59 query24 6.702.070.47 query25 0.440.210.07 query26 0.630.160.15 query27 0.060.050.04 query28 9.980.880.44 query29 12.55 3.943.28 query30 0.250.090.06 query31 2.830.590.38 query32 3.230.550.48 query33 2.983.063.09 query34 15.69 5.164.44 query35 4.544.504.46 query36 0.680.490.49 query37 0.090.060.06 query38 0.060.050.04 query39 0.040.030.03 query40 0.180.140.13 query41 0.090.030.03 query42 0.040.020.02 query43 0.040.040.03 Total cold run time: 103.06 s Total hot run time: 28.56 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2916062100 TPC-DS: Total hot run time: 185828 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit b4497029fb5e5f88b6d4f2d5cddae5a24e5e9d84, data reload: false query1 1023477 499 477 query2 6611180917841784 query3 6743231 236 231 query4 26457 24211 23604 23604 query5 4787618 442 442 query6 299 196 183 183 query7 4631499 282 282 query8 272 228 216 216 query9 8631260225942594 query10 491 349 271 271 query11 15857 15037 14805 14805 query12 157 110 106 106 query13 1648531 437 437 query14 9246596460885964 query15 207 184 170 170 query16 7221618 496 496 query17 1128701 568 568 query18 2001411 292 292 query19 189 177 161 161 query20 124 121 160 121 query21 207 126 108 108 query22 4207427940764076 query23 33957 33059 33073 33059 query24 8386238923862386 query25 546 458 394 394 query26 1242270 152 152 query27 2761489 341 341 query28 4338212621082108 query29 767 585 481 481 query30 288 221 187 187 query31 975 846 750 750 query32 77 65 72 65 query33 576 375 335 335 query34 801 863 562 562 query35 783 835 744 744 query36 938 981 851 851 query37 112 104 79 79 query38 4120409741394097 query39 1489142014571420 query40 216 127 116 116 query41 103 56 58 56 query42 129 106 106 106 query43 486 487 448 448 query44 1310827 820 820 query45 176 174 165 165 query46 839 1019637 637 query47 1724178017171717 query48 393 426 317 317 query49 769 496 406 406 query50 667 686 407 407 query51 4087412240814081 query52 109 108 99 99 query53 229 256 182 182 query54 634 583 502 502 query55 81 85 83 83 query56 305 292 284 284 query57 1126114610691069 query58 257 261 252 252 query59 2629259225352535 query60 330 339 304 304 query61 124 119 123 119 query62 789 715 673 673 query63 222 193 188 188 query64 43651038696 696 query65 4297422942814229 query66 1143402 314 314 query67 15728 15445 15321 15321 query68 7745899 528 528 query69 496 324 288 288 query70 1208112410661066 query71 429 333 308 308 query72 5916482548174817 query73 703 678 362 362 query74 8905898787068706 query75 3385316926912691 query76 32461174754 754 query77 606 384 297 297 query78 10033 10251 93629362 query79 2123795 592 592 query80 684 498 439 439 query81 486 250 224 224 query82 450 127 94 94 query83 293 248 234 234 query84 295 110 88 88 query85 779 350 311 311 query86 387 304 288 288 query87 4368438343134313 query88 3771229622972296 query89 398 308 288 288 query90 1983223 213 213 query91 142 149 113 113 query92 81 62 63 62 query93 1778945 579 579 query94 708 402 313 313 query95 377 302 287 287 query96 496 567 281 281 query97 2689276226372637 query98 235 214 203 203 query99 1421141112691269 Total cold run time: 274176 ms Total hot run time: 185828 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2916030859 TPC-H: Total hot run time: 33782 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit b4497029fb5e5f88b6d4f2d5cddae5a24e5e9d84, data reload: false -- Round 1 -- q1 26366 509350055005 q2 2100286 192 192 q3 10599 1286698 698 q4 10232 1010507 507 q5 7876242923452345 q6 184 163 135 135 q7 883 718 613 613 q8 9325128310831083 q9 6823508451155084 q10 6871234618831883 q11 503 294 273 273 q12 340 357 208 208 q13 17787 369030883088 q14 239 231 221 221 q15 557 499 520 499 q16 418 426 382 382 q17 594 875 373 373 q18 7693726970867086 q19 1573962 549 549 q20 335 338 220 220 q21 3849318523882388 q22 997 1018950 950 Total cold run time: 116144 ms Total hot run time: 33782 ms - Round 2, with runtime_filter_mode=off - q1 5213511751145114 q2 241 330 232 232 q3 2128262723342334 q4 1323176913761376 q5 4544445144044404 q6 222 175 129 129 q7 2008194317591759 q8 2580248224512451 q9 7196718272707182 q10 2965315327352735 q11 583 505 481 481 q12 680 792 580 580 q13 3459390232103210 q14 268 297 283 283 q15 541 511 506 506 q16 435 481 439 439 q17 1147150114051405 q18 7792749472887288 q19 808 806 917 806 q20 1945203318941894 q21 4892442341734173 q22 10841003959 959 Total cold run time: 52054 ms Total hot run time: 49740 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
hello-stephen commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2915766186 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/b4497029fb5e5f88b6d4f2d5cddae5a24e5e9d84_b4497029fb5e5f88b6d4f2d5cddae5a24e5e9d84_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/b4497029fb5e5f88b6d4f2d5cddae5a24e5e9d84_b4497029fb5e5f88b6d4f2d5cddae5a24e5e9d84_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 83.25% (1113/1337) | | Line Coverage | 66.17% (18676/28224) | | Region Coverage | 65.79% (9262/14079) | | Branch Coverage | 55.62% (4987/8966) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2915698809 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on code in PR #47319:
URL: https://github.com/apache/doris/pull/47319#discussion_r2111326823
##
fe/fe-core/src/main/java/org/apache/doris/analysis/TimeV2Literal.java:
##
@@ -0,0 +1,270 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.analysis;
+
+import org.apache.doris.catalog.ScalarType;
+import org.apache.doris.catalog.Type;
+import org.apache.doris.nereids.exceptions.AnalysisException;
+import org.apache.doris.thrift.TExprNode;
+import org.apache.doris.thrift.TExprNodeType;
+import org.apache.doris.thrift.TTimeV2Literal;
+
+public class TimeV2Literal extends LiteralExpr {
+// part min max store every part of time's min max value
+public static final TimeV2Literal PART_MIN = new TimeV2Literal(-838, 0, 0,
0, 0);
+public static final TimeV2Literal PART_MAX = new TimeV2Literal(838, 59,
59, 99, 6);
+
+protected long hour;
+protected long minute;
+protected long second;
+protected long microsecond;
+protected boolean negative;
+
+/**
+ * C'tor forcing type, e.g., due to implicit cast
+ */
+// for restore
+public TimeV2Literal() {
+this.type = Type.TIMEV2;
+this.hour = 0;
+this.minute = 0;
+this.second = 0;
+this.microsecond = 0;
+this.negative = false;
+}
+
+public TimeV2Literal(double value) throws AnalysisException {
Review Comment:
Time type data is always converted to double type operation in be, I think
it's more standardized to use double here？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on code in PR #47319:
URL: https://github.com/apache/doris/pull/47319#discussion_r2111212745
##
fe/fe-core/src/main/java/org/apache/doris/nereids/types/TimeV2Type.java:
##
@@ -49,6 +51,9 @@ public Type toCatalogDataType() {
* create TimeV2Type from scale
*/
public static TimeV2Type of(int scale) {
+if (scale > MAX_SCALE || scale < 0) {
Review Comment:
the constructor is `private TimeV2Type(int scale)` private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
924060929 commented on code in PR #47319:
URL: https://github.com/apache/doris/pull/47319#discussion_r2108564185
##
fe/fe-core/src/main/java/org/apache/doris/analysis/TimeV2Literal.java:
##
@@ -0,0 +1,270 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.analysis;
+
+import org.apache.doris.catalog.ScalarType;
+import org.apache.doris.catalog.Type;
+import org.apache.doris.nereids.exceptions.AnalysisException;
+import org.apache.doris.thrift.TExprNode;
+import org.apache.doris.thrift.TExprNodeType;
+import org.apache.doris.thrift.TTimeV2Literal;
+
+public class TimeV2Literal extends LiteralExpr {
+// part min max store every part of time's min max value
+public static final TimeV2Literal PART_MIN = new TimeV2Literal(-838, 0, 0,
0, 0);
+public static final TimeV2Literal PART_MAX = new TimeV2Literal(838, 59,
59, 99, 6);
+
+protected long hour;
+protected long minute;
+protected long second;
+protected long microsecond;
+protected boolean negative;
+
+/**
+ * C'tor forcing type, e.g., due to implicit cast
+ */
+// for restore
+public TimeV2Literal() {
+this.type = Type.TIMEV2;
+this.hour = 0;
+this.minute = 0;
+this.second = 0;
+this.microsecond = 0;
+this.negative = false;
+}
+
+public TimeV2Literal(double value) throws AnalysisException {
+super();
+if (value > (double) PART_MAX.getValue() || value < -(double)
PART_MAX.getValue()) {
+throw new AnalysisException("The value " + value + " is out of
range, expect value range is ["
++ (-PART_MAX.getValue()) + ", " + PART_MAX.getValue() +
"]");
+}
+this.type = ScalarType.createTimeV2Type(6);
+this.negative = 1.0 / value < 0;
Review Comment:
what's this? why not use `this.negative = value < 0`
##
fe/fe-core/src/main/java/org/apache/doris/analysis/TimeV2Literal.java:
##
@@ -0,0 +1,270 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.analysis;
+
+import org.apache.doris.catalog.ScalarType;
+import org.apache.doris.catalog.Type;
+import org.apache.doris.nereids.exceptions.AnalysisException;
+import org.apache.doris.thrift.TExprNode;
+import org.apache.doris.thrift.TExprNodeType;
+import org.apache.doris.thrift.TTimeV2Literal;
+
+public class TimeV2Literal extends LiteralExpr {
+// part min max store every part of time's min max value
+public static final TimeV2Literal PART_MIN = new TimeV2Literal(-838, 0, 0,
0, 0);
+public static final TimeV2Literal PART_MAX = new TimeV2Literal(838, 59,
59, 99, 6);
+
+protected long hour;
+protected long minute;
+protected long second;
+protected long microsecond;
+protected boolean negative;
+
+/**
+ * C'tor forcing type, e.g., due to implicit cast
+ */
+// for restore
+public TimeV2Literal() {
+this.type = Type.TIMEV2;
+this.hour = 0;
+this.minute = 0;
+this.second = 0;
+this.microsecond = 0;
+this.negative = false;
+}
+
+public TimeV2Literal(double value) throws AnalysisException {
+super();
+if (value > (double) PART_MAX.getValue() || value < -(double)
PART_MAX.getValue()) {
+throw new AnalysisException("The value " + value + " is out of
range, expect value range is ["
++ (-P
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2911570672 ClickBench: Total hot run time: 28.84 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 89c0c3ffe89bc2495222496d884f7f1cc4c7d757, data reload: false query1 0.040.030.03 query2 0.120.100.11 query3 0.250.190.20 query4 1.590.200.20 query5 0.430.420.42 query6 1.170.660.67 query7 0.020.010.01 query8 0.040.030.03 query9 0.580.520.52 query10 0.570.570.56 query11 0.160.110.12 query12 0.140.120.11 query13 0.610.610.61 query14 0.780.820.81 query15 0.880.870.88 query16 0.390.390.39 query17 1.021.021.06 query18 0.220.210.22 query19 1.921.821.84 query20 0.010.010.01 query21 15.39 0.900.55 query22 0.751.260.74 query23 14.78 1.380.66 query24 7.661.020.36 query25 0.530.150.13 query26 0.610.160.14 query27 0.050.050.05 query28 9.380.870.45 query29 12.55 3.943.31 query30 0.250.080.06 query31 2.820.600.39 query32 3.230.550.47 query33 3.003.203.04 query34 15.83 5.154.52 query35 4.564.554.49 query36 0.680.520.48 query37 0.080.060.06 query38 0.050.040.04 query39 0.040.030.02 query40 0.160.140.13 query41 0.080.030.03 query42 0.040.030.02 query43 0.040.030.02 Total cold run time: 103.5 s Total hot run time: 28.84 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2911554741 TPC-DS: Total hot run time: 185588 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 89c0c3ffe89bc2495222496d884f7f1cc4c7d757, data reload: false query1 1015490 497 490 query2 6578191418811881 query3 6750220 219 219 query4 26798 23374 23289 23289 query5 4316625 462 462 query6 324 222 199 199 query7 4625497 295 295 query8 310 253 254 253 query9 8630261126322611 query10 459 346 278 278 query11 15895 15026 14816 14816 query12 177 117 106 106 query13 1653539 401 401 query14 9862618162726181 query15 206 193 167 167 query16 7653634 461 461 query17 1198704 623 623 query18 1993393 293 293 query19 185 186 155 155 query20 122 123 114 114 query21 208 131 106 106 query22 4016413239653965 query23 34079 33165 32962 32962 query24 8407238023582358 query25 527 455 384 384 query26 1232272 150 150 query27 2715497 333 333 query28 4317211021042104 query29 743 567 435 435 query30 287 220 191 191 query31 948 856 791 791 query32 77 65 65 65 query33 545 368 305 305 query34 801 855 524 524 query35 795 790 742 742 query36 955 1008877 877 query37 115 99 80 80 query38 4067403440654034 query39 1453139613981396 query40 217 124 110 110 query41 57 54 54 54 query42 129 109 108 108 query43 503 500 478 478 query44 1282797 796 796 query45 174 168 164 164 query46 837 1023629 629 query47 1774178717301730 query48 383 409 312 312 query49 789 520 421 421 query50 649 707 402 402 query51 4116411441324114 query52 114 108 96 96 query53 230 247 187 187 query54 582 575 507 507 query55 84 83 84 83 query56 302 302 281 281 query57 1137111211071107 query58 263 258 280 258 query59 2659268026392639 query60 332 319 309 309 query61 129 137 127 127 query62 816 750 647 647 query63 217 186 185 185 query64 42791011694 694 query65 4342424042194219 query66 1085416 307 307 query67 15965 15695 15198 15198 query68 8632891 579 579 query69 465 306 274 274 query70 1252111911191119 query71 470 323 289 289 query72 5484463646764636 query73 700 553 346 346 query74 9087878890028788 query75 4110319826972697 query76 37271187755 755 query77 797 367 291 291 query78 995410235 92769276 query79 4560817 560 560 query80 689 524 458 458 query81 481 249 228 228 query82 541 128 96 96 query83 292 251 240 240 query84 300 103 95 95 query85 771 357 360 357 query86 347 291 280 280 query87 4342445144454445 query88 3104225622492249 query89 445 327 291 291 query90 1953209 203 203 query91 140 149 111 111 query92 76 62 60 60 query93 2453946 573 573 query94 673 390 300 300 query95 378 300 289 289 query96 493 567 282 282 query97 2775277626672667 query98 251 207 205 205 query99 1450140412911291 Total cold run time: 279674 ms Total hot run time: 185588 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2911522866 TPC-H: Total hot run time: 33740 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 89c0c3ffe89bc2495222496d884f7f1cc4c7d757, data reload: false -- Round 1 -- q1 26006 509349834983 q2 2076290 197 197 q3 10512 1278694 694 q4 10223 991 510 510 q5 7782241523492349 q6 188 162 129 129 q7 904 737 602 602 q8 9335129810991099 q9 6843505950375037 q10 6868230718991899 q11 509 282 266 266 q12 344 346 214 214 q13 17784 370830623062 q14 237 250 223 223 q15 538 486 499 486 q16 425 420 374 374 q17 612 862 357 357 q18 7659728171347134 q19 2105976 555 555 q20 326 340 223 223 q21 3703316223522352 q22 10481016995 995 Total cold run time: 116027 ms Total hot run time: 33740 ms - Round 2, with runtime_filter_mode=off - q1 5210542251035103 q2 242 330 228 228 q3 2213266322852285 q4 1407181214261426 q5 4606447943154315 q6 216 188 124 124 q7 1999196317691769 q8 2575255325272527 q9 7131701870737018 q10 3018320527702770 q11 572 504 505 504 q12 711 801 638 638 q13 3532382734063406 q14 281 304 282 282 q15 525 512 471 471 q16 440 480 420 420 q17 1126149813741374 q18 7870758974577457 q19 803 843 982 843 q20 1946205618351835 q21 4709430343194303 q22 10641042953 953 Total cold run time: 52196 ms Total hot run time: 50051 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2911136000 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
morrySnow commented on code in PR #47319:
URL: https://github.com/apache/doris/pull/47319#discussion_r2108387298
##
fe/fe-core/src/main/java/org/apache/doris/analysis/TimeV2Literal.java:
##
@@ -0,0 +1,270 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.analysis;
+
+import org.apache.doris.catalog.ScalarType;
+import org.apache.doris.catalog.Type;
+import org.apache.doris.nereids.exceptions.AnalysisException;
+import org.apache.doris.thrift.TExprNode;
+import org.apache.doris.thrift.TExprNodeType;
+import org.apache.doris.thrift.TTimeV2Literal;
+
+public class TimeV2Literal extends LiteralExpr {
+// part min max store every part of time's min max value
+public static final TimeV2Literal PART_MIN = new TimeV2Literal(-838, 0, 0,
0, 0);
+public static final TimeV2Literal PART_MAX = new TimeV2Literal(838, 59,
59, 99, 6);
+
+protected long hour;
+protected long minute;
+protected long second;
+protected long microsecond;
+protected boolean negative;
+
+/**
+ * C'tor forcing type, e.g., due to implicit cast
+ */
+// for restore
+public TimeV2Literal() {
+this.type = Type.TIMEV2;
+this.hour = 0;
+this.minute = 0;
+this.second = 0;
+this.microsecond = 0;
+this.negative = false;
+}
+
+public TimeV2Literal(double value) throws AnalysisException {
+super();
+if (value > (double) PART_MAX.getValue() || value < -(double)
PART_MAX.getValue()) {
+throw new AnalysisException("The value " + value + " is out of
range, expect value range is ["
++ (-PART_MAX.getValue()) + ", " + PART_MAX.getValue() +
"]");
+}
+this.type = ScalarType.createTimeV2Type(6);
+this.negative = 1.0 / value < 0;
+long v = (long) Math.abs(value);
+this.microsecond = (long) (v % 100);
+v /= 100;
+this.second = (long) (v % 60);
+v /= 60;
+this.minute = (long) (v % 60);
+v /= 60;
+this.hour = (long) v;
+analysisDone();
+}
+
+public TimeV2Literal(long hour, long minute, long second, long
microsecond, int scale) throws AnalysisException {
+super();
+this.type = ScalarType.createTimeV2Type(scale);
+this.hour = Math.abs(hour);
+this.minute = minute;
+this.second = second;
+this.microsecond = (long) (microsecond / Math.pow(10, 6 - scale)) *
(long) Math.pow(10, 6 - scale);
+while (microsecond != 0 && this.microsecond < 10) {
+this.microsecond *= 10;
+}
+this.negative = hour < 0;
+if (checkRange(this.hour, this.minute, this.second, this.microsecond)
|| scale > 6 || scale < 0) {
+throw new AnalysisException("time literal is out of range
[-838:59:59.99, 838:59:59.99]");
+}
+analysisDone();
+}
+
+public TimeV2Literal(String s, ScalarType type) {
+super();
+this.type = type;
+init(s);
+analysisDone();
+}
+
+protected TimeV2Literal(TimeV2Literal other) {
+super(other);
+this.type = other.type;
+this.hour = other.getHour();
+this.minute = other.getMinute();
+this.second = other.getSecond();
+this.microsecond = other.getMicroSecond();
+this.negative = other.isNegative();
+}
+
+@Override
+public Expr clone() {
+return new TimeV2Literal(this);
+}
+
+protected String normalize(String s) {
Review Comment:
remove all analysis in legacy planner's TimeV2Literal. we do not need
normalize for legacy planner's literal anymore, because legacy planner has been
removed
##
fe/fe-core/src/main/java/org/apache/doris/nereids/types/TimeV2Type.java:
##
@@ -49,6 +51,9 @@ public Type toCatalogDataType() {
* create TimeV2Type from scale
*/
public static TimeV2Type of(int scale) {
+if (scale > MAX_SCALE || scale < 0) {
+throw new AnalysisException("Scale of Datetime/Time must between 0
and 6. Scale was set to: " + scale);
+}
Review Comment:
need change equals function to compare s
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2911418988 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2911232717 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/89c0c3ffe89bc2495222496d884f7f1cc4c7d757_89c0c3ffe89bc2495222496d884f7f1cc4c7d757_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/89c0c3ffe89bc2495222496d884f7f1cc4c7d757_89c0c3ffe89bc2495222496d884f7f1cc4c7d757_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 83.25% (1113/1337) | | Line Coverage | 66.16% (18674/28224) | | Region Coverage | 65.79% (9262/14079) | | Branch Coverage | 55.65% (4990/8966) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2911209768 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
hello-stephen commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2911171984 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/7df81766cbaea25979d58ed89c4fe9475080a1d7_7df81766cbaea25979d58ed89c4fe9475080a1d7_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/7df81766cbaea25979d58ed89c4fe9475080a1d7_7df81766cbaea25979d58ed89c4fe9475080a1d7_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 83.25% (1113/1337) | | Line Coverage | 66.17% (18677/28224) | | Region Coverage | 65.76% (9259/14079) | | Branch Coverage | 55.59% (4984/8966) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2908970703 run cloud_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2908548832 TPC-H: Total hot run time: 33878 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 97e665c9be7a5518af99f06b74e6478fc620438f, data reload: false -- Round 1 -- q1 26315 498750444987 q2 2114271 189 189 q3 10529 1248701 701 q4 10220 1000522 522 q5 7694236023382338 q6 182 168 132 132 q7 889 737 606 606 q8 9321123611121112 q9 6816514550405040 q10 6821229818991899 q11 488 288 265 265 q12 340 349 208 208 q13 17778 363230383038 q14 230 223 216 216 q15 533 476 489 476 q16 439 429 383 383 q17 587 858 364 364 q18 7490727872247224 q19 1411953 576 576 q20 333 330 227 227 q21 3683321023752375 q22 1055101110001000 Total cold run time: 115268 ms Total hot run time: 33878 ms - Round 2, with runtime_filter_mode=off - q1 5039505150685051 q2 244 326 230 230 q3 2196266423022302 q4 1373181613641364 q5 4581439044884390 q6 208 171 126 126 q7 1946193717191719 q8 2571245124352435 q9 7075708670077007 q10 3052321027652765 q11 571 520 500 500 q12 667 761 634 634 q13 3560387533593359 q14 292 295 285 285 q15 524 475 465 465 q16 447 488 444 444 q17 1209155913841384 q18 7740760573987398 q19 785 770 893 770 q20 1978202319381938 q21 4859449642524252 q22 10511040968 968 Total cold run time: 51968 ms Total hot run time: 49786 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2908575533 ClickBench: Total hot run time: 29.26 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 97e665c9be7a5518af99f06b74e6478fc620438f, data reload: false query1 0.040.040.03 query2 0.120.100.11 query3 0.240.190.20 query4 1.590.190.19 query5 0.460.440.45 query6 1.140.660.66 query7 0.020.020.02 query8 0.050.040.04 query9 0.560.500.53 query10 0.560.580.56 query11 0.160.110.11 query12 0.140.110.11 query13 0.610.590.60 query14 0.780.820.81 query15 0.880.870.85 query16 0.380.380.37 query17 1.031.051.04 query18 0.220.210.21 query19 1.981.811.78 query20 0.010.020.01 query21 15.42 0.910.55 query22 0.761.230.63 query23 14.94 1.360.60 query24 6.651.230.73 query25 0.500.260.16 query26 0.540.170.14 query27 0.060.050.05 query28 9.560.900.44 query29 12.54 4.103.49 query30 0.250.100.07 query31 2.820.600.39 query32 3.240.540.47 query33 3.113.073.20 query34 15.73 5.074.54 query35 4.534.534.51 query36 0.670.500.48 query37 0.080.060.06 query38 0.060.040.04 query39 0.030.020.02 query40 0.170.150.13 query41 0.080.030.03 query42 0.030.020.02 query43 0.040.030.03 Total cold run time: 102.78 s Total hot run time: 29.26 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2908566418 TPC-DS: Total hot run time: 186135 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 97e665c9be7a5518af99f06b74e6478fc620438f, data reload: false query1 1019484 487 484 query2 6584186718651865 query3 6753234 227 227 query4 26474 23439 23331 23331 query5 4352635 459 459 query6 294 203 204 203 query7 4616478 297 297 query8 289 241 239 239 query9 8622257725882577 query10 481 338 269 269 query11 15817 15049 14968 14968 query12 162 106 100 100 query13 1637510 392 392 query14 8857617961836179 query15 213 192 171 171 query16 7136655 449 449 query17 1202706 571 571 query18 1979396 292 292 query19 198 184 167 167 query20 121 121 119 119 query21 218 129 108 108 query22 4280414040804080 query23 34105 33129 33028 33028 query24 8481239723742374 query25 557 429 385 385 query26 1250268 149 149 query27 2779498 342 342 query28 4344209620712071 query29 759 545 427 427 query30 275 215 183 183 query31 917 840 771 771 query32 73 68 65 65 query33 559 360 325 325 query34 797 836 555 555 query35 770 811 726 726 query36 940 971 863 863 query37 120 104 76 76 query38 4116408540214021 query39 1643144314151415 query40 208 119 112 112 query41 59 79 55 55 query42 122 111 115 111 query43 509 484 467 467 query44 1282813 808 808 query45 172 184 173 173 query46 834 1017656 656 query47 1758178817051705 query48 374 414 319 319 query49 808 510 430 430 query50 652 668 401 401 query51 4099420640624062 query52 111 112 96 96 query53 218 251 184 184 query54 582 571 498 498 query55 83 83 91 83 query56 305 288 285 285 query57 1141113911061106 query58 264 263 256 256 query59 2747265526052605 query60 330 335 319 319 query61 132 131 125 125 query62 799 743 679 679 query63 219 197 185 185 query64 43881078750 750 query65 4294421842554218 query66 1184402 309 309 query67 15750 15673 15631 15631 query68 8044872 507 507 query69 478 316 267 267 query70 1175107511231075 query71 465 331 284 284 query72 5590467148014671 query73 718 640 356 356 query74 9161920286398639 query75 3807316726682668 query76 36491178747 747 query77 793 397 288 288 query78 10083 10197 94199419 query79 1928814 598 598 query80 590 503 450 450 query81 482 251 216 216 query82 417 127 103 103 query83 249 252 238 238 query84 247 95 83 83 query85 787 350 322 322 query86 338 297 292 292 query87 4388446343904390 query88 3218232323182318 query89 396 308 286 286 query90 1931222 213 213 query91 143 144 112 112 query92 75 61 54 54 query93 1146913 574 574 query94 673 406 314 314 query95 374 295 283 283 query96 495 561 283 283 query97 2686274426622662 query98 230 212 198 198 query99 1399140612741274 Total cold run time: 273368 ms Total hot run time: 186135 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
hello-stephen commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2908397136 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/97e665c9be7a5518af99f06b74e6478fc620438f_97e665c9be7a5518af99f06b74e6478fc620438f_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/97e665c9be7a5518af99f06b74e6478fc620438f_97e665c9be7a5518af99f06b74e6478fc620438f_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 83.25% (1113/1337) | | Line Coverage | 66.15% (18670/28224) | | Region Coverage | 65.76% (9258/14079) | | Branch Coverage | 55.58% (4983/8966) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2908380405 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2903945937 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2903971343 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/04b756ecdd954b0aee6958ceb3dbb7dad553b219_04b756ecdd954b0aee6958ceb3dbb7dad553b219_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/04b756ecdd954b0aee6958ceb3dbb7dad553b219_04b756ecdd954b0aee6958ceb3dbb7dad553b219_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 83.25% (1113/1337) | | Line Coverage | 66.13% (18665/28223) | | Region Coverage | 65.75% (9255/14077) | | Branch Coverage | 55.59% (4983/8964) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2903818868 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2903879722 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/823ad633506f6ad33140338f448196da0d3c553b_823ad633506f6ad33140338f448196da0d3c553b_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/823ad633506f6ad33140338f448196da0d3c553b_823ad633506f6ad33140338f448196da0d3c553b_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 83.25% (1113/1337) | | Line Coverage | 66.14% (18667/28223) | | Region Coverage | 65.80% (9263/14077) | | Branch Coverage | 55.60% (4984/8964) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
hello-stephen commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2870904267 # BE UT Coverage Report Increment line coverage `47.95% (35/73)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/1b362cce2ae7613a212ecd3c44b08a57efe31b48_1b362cce2ae7613a212ecd3c44b08a57efe31b48/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/1b362cce2ae7613a212ecd3c44b08a57efe31b48_1b362cce2ae7613a212ecd3c44b08a57efe31b48/report/index.html) | Category | Coverage | |---|| | Function Coverage | 55.77% (14897/26712) | | Line Coverage | 44.58% (131826/295706) | | Region Coverage | 43.63% (66287/151921) | | Branch Coverage | 38.24% (33977/88846) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2870538586 TeamCity cloud ut coverage result: Function Coverage: 83.18% (1103/1326) Line Coverage: 66.09% (18561/28084) Region Coverage: 65.67% (9242/14073) Branch Coverage: 55.45% (4968/8960) Coverage Report: http://coverage.selectdb-in.cc/coverage/1b362cce2ae7613a212ecd3c44b08a57efe31b48_1b362cce2ae7613a212ecd3c44b08a57efe31b48_cloud/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2870491891 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2863033505 # BE UT Coverage Report Increment line coverage `47.95% (35/73)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/1b362cce2ae7613a212ecd3c44b08a57efe31b48_1b362cce2ae7613a212ecd3c44b08a57efe31b48/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/1b362cce2ae7613a212ecd3c44b08a57efe31b48_1b362cce2ae7613a212ecd3c44b08a57efe31b48/report/index.html) | Category | Coverage | |---|| | Function Coverage | 55.68% (14896/26754) | | Line Coverage | 44.49% (131375/295305) | | Region Coverage | 43.39% (66190/152559) | | Branch Coverage | 38.06% (33802/88812) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2862468224 TeamCity cloud ut coverage result: Function Coverage: 83.18% (1103/1326) Line Coverage: 66.09% (18560/28084) Region Coverage: 65.66% (9240/14073) Branch Coverage: 55.46% (4969/8960) Coverage Report: http://coverage.selectdb-in.cc/coverage/1b362cce2ae7613a212ecd3c44b08a57efe31b48_1b362cce2ae7613a212ecd3c44b08a57efe31b48_cloud/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2862422959 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
morrySnow commented on code in PR #47319:
URL: https://github.com/apache/doris/pull/47319#discussion_r2001031767
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/TimeV2Literal.java:
##
@@ -0,0 +1,275 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.expressions.literal;
+
+import org.apache.doris.analysis.LiteralExpr;
+import org.apache.doris.nereids.exceptions.AnalysisException;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor;
+import org.apache.doris.nereids.types.TimeV2Type;
+
+import java.time.LocalDateTime;
+
+/**
+ * Time literal in Nereids.
+ */
+public class TimeV2Literal extends Literal {
+private static final LocalDateTime START_OF_A_DAY = LocalDateTime.of(0, 1,
1, 0, 0, 0);
+private static final LocalDateTime END_OF_A_DAY = LocalDateTime.of(,
12, 31, 23, 59, 59, 99000);
+private static final TimeV2Literal MIN_TIME = new TimeV2Literal(-838, 0,
0, 0, 0);
+private static final TimeV2Literal MAX_TIME = new TimeV2Literal(838, 59,
59, 99, 6);
+
+protected int hour;
+protected int minute;
+protected int second;
+protected int microsecond;
+protected boolean negative;
+
+public TimeV2Literal(String s) {
+this(TimeV2Type.of(0), s);
Review Comment:
this is not right, if we call `cast("01:01:01.123456" as time)` we should
not use this ctor. the correct way is use ctor with two parameters
`TimeV2Literal(String s, TimeType timeType)`. if we use the ctor with only
String parameter, we should infer scale from the string literal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2739293418 # BE UT Coverage Report Increment line coverage `32.93% (27/82)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/e999a363568df997cf939d449ac1b8e844aa2b50_e999a363568df997cf939d449ac1b8e844aa2b50/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/e999a363568df997cf939d449ac1b8e844aa2b50_e999a363568df997cf939d449ac1b8e844aa2b50/report/index.html) | Category | Coverage | |---|| | Function Coverage | 48.81% (13072/26784) | | Line Coverage | 38.37% (112723/293744) | | Region Coverage | 37.16% (57300/154178) | | Branch Coverage | 32.26% (28802/89272) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2739127152 ClickBench: Total hot run time: 32.02 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit e999a363568df997cf939d449ac1b8e844aa2b50, data reload: false query1 0.040.030.03 query2 0.160.110.12 query3 0.340.190.20 query4 1.600.200.19 query5 0.610.620.64 query6 1.190.720.73 query7 0.020.020.01 query8 0.060.050.04 query9 0.630.520.52 query10 0.580.590.58 query11 0.240.130.12 query12 0.250.130.14 query13 0.640.630.62 query14 2.842.712.84 query15 1.020.870.89 query16 0.380.380.38 query17 1.041.051.05 query18 0.180.200.19 query19 1.922.031.87 query20 0.010.020.01 query21 15.36 0.970.67 query22 0.941.070.81 query23 14.69 1.530.76 query24 5.280.580.31 query25 0.160.100.08 query26 0.560.220.19 query27 0.090.090.09 query28 11.03 1.170.57 query29 12.53 4.093.44 query30 0.270.080.05 query31 2.830.640.43 query32 3.230.590.50 query33 3.063.073.02 query34 16.46 5.094.49 query35 4.484.504.49 query36 0.630.500.50 query37 0.180.180.17 query38 0.170.150.16 query39 0.050.050.04 query40 0.190.170.16 query41 0.100.050.06 query42 0.060.050.06 query43 0.060.050.04 Total cold run time: 106.16 s Total hot run time: 32.02 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2739058115 TeamCity cloud ut coverage result: Function Coverage: 83.09% (1081/1301) Line Coverage: 66.08% (18008/27253) Region Coverage: 65.44% (8868/13551) Branch Coverage: 55.28% (4774/8636) Coverage Report: http://coverage.selectdb-in.cc/coverage/e999a363568df997cf939d449ac1b8e844aa2b50_e999a363568df997cf939d449ac1b8e844aa2b50_cloud/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2739119487 TPC-DS: Total hot run time: 192305 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit e999a363568df997cf939d449ac1b8e844aa2b50, data reload: false query1 1395108910641064 query2 6238195619701956 query3 11033 462946754629 query4 26317 23472 23055 23055 query5 3449639 457 457 query6 283 195 192 192 query7 3978496 290 290 query8 283 244 237 237 query9 8528259925952595 query10 461 326 263 263 query11 15393 15278 14874 14874 query12 162 112 109 109 query13 1572537 417 417 query14 9865692966776677 query15 202 190 175 175 query16 7674640 501 501 query17 1158752 591 591 query18 2041439 326 326 query19 198 210 169 169 query20 134 129 132 129 query21 207 124 115 115 query22 4507437343004300 query23 34240 33745 33649 33649 query24 7766248324612461 query25 512 463 394 394 query26 1158277 158 158 query27 2213505 342 342 query28 4332244924242424 query29 737 568 450 450 query30 280 230 198 198 query31 933 875 781 781 query32 75 63 70 63 query33 573 374 308 308 query34 812 850 526 526 query35 806 856 800 800 query36 983 1022903 903 query37 128 102 79 79 query38 4373420040954095 query39 1489146414521452 query40 211 120 106 106 query41 52 53 52 52 query42 117 109 108 108 query43 504 514 498 498 query44 1325825 818 818 query45 186 172 168 168 query46 848 1036649 649 query47 1806189117701770 query48 396 424 318 318 query49 760 527 420 420 query50 703 755 421 421 query51 4273429042824282 query52 106 105 99 99 query53 231 260 189 189 query54 500 499 433 433 query55 85 84 86 84 query56 278 286 253 253 query57 1166121711141114 query58 246 239 234 234 query59 2962281627502750 query60 294 293 248 248 query61 126 154 117 117 query62 794 737 664 664 query63 234 191 189 189 query64 40751017669 669 query65 4570442944264426 query66 994 401 298 298 query67 16589 15503 15242 15242 query68 9821892 509 509 query69 470 293 262 262 query70 1242106010841060 query71 457 295 258 258 query72 5079352638173526 query73 807 725 353 353 query74 9010890386518651 query75 4270315127212721 query76 52371192752 752 query77 1003360 284 284 query78 986910263 93569356 query79 4679810 571 571 query80 583 517 429 429 query81 482 260 214 214 query82 188 124 95 95 query83 167 170 154 154 query84 289 91 78 78 query85 740 451 315 315 query86 336 310 297 297 query87 4426445144784451 query88 2859226822602260 query89 442 321 293 293 query90 2189219 223 219 query91 134 138 109 109 query92 72 61 54 54 query93 30781044578 578 query94 674 420 299 299 query95 355 319 270 270 query96 492 552 274 274 query97 3281341233293329 query98 222 201 200 200 query99 1379142312611261 Total cold run time: 285251 ms Total hot run time: 192305 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2739107201 TPC-H: Total hot run time: 32534 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit e999a363568df997cf939d449ac1b8e844aa2b50, data reload: false -- Round 1 -- q1 24408 516450465046 q2 2058349 208 208 q3 10650 1257678 678 q4 10248 1010556 556 q5 8157239923422342 q6 202 162 131 131 q7 916 764 610 610 q8 9315132510751075 q9 5020490549194905 q10 6827232818831883 q11 477 271 260 260 q12 358 361 217 217 q13 17782 376230743074 q14 232 233 207 207 q15 536 473 488 473 q16 621 613 583 583 q17 596 857 343 343 q18 6832640762936293 q19 1924963 568 568 q20 320 329 196 196 q21 2774222018991899 q22 10971007987 987 Total cold run time: 111350 ms Total hot run time: 32534 ms - Round 2, with runtime_filter_mode=off - q1 5254520151335133 q2 242 328 234 234 q3 2128267922412241 q4 1449180813661366 q5 4234428044284280 q6 222 172 128 128 q7 2009190818061806 q8 2624258627152586 q9 7274734572207220 q10 2947313727992799 q11 582 499 483 483 q12 675 780 588 588 q13 3496391933893389 q14 290 289 271 271 q15 525 468 473 468 q16 657 669 664 664 q17 1197165213231323 q18 7988757875037503 q19 840 794 826 794 q20 1964204818981898 q21 5318502748374837 q22 1072105210291029 Total cold run time: 52987 ms Total hot run time: 51040 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2739042948 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2736450052 # BE UT Coverage Report Increment line coverage `32.93% (27/82)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/dadb3566dedcd2b2bbd12c2408746795058d7d67_dadb3566dedcd2b2bbd12c2408746795058d7d67/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/dadb3566dedcd2b2bbd12c2408746795058d7d67_dadb3566dedcd2b2bbd12c2408746795058d7d67/report/index.html) | Category | Coverage | |---|| | Function Coverage | 48.82% (13077/26787) | | Line Coverage | 38.38% (112757/293786) | | Region Coverage | 37.18% (57323/154188) | | Branch Coverage | 32.29% (28824/89278) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2736079322 ClickBench: Total hot run time: 31.85 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit dadb3566dedcd2b2bbd12c2408746795058d7d67, data reload: false query1 0.040.040.04 query2 0.120.110.10 query3 0.240.200.19 query4 1.590.200.19 query5 0.610.590.55 query6 1.190.720.72 query7 0.030.030.02 query8 0.040.030.03 query9 0.570.520.51 query10 0.590.580.60 query11 0.150.110.11 query12 0.140.110.11 query13 0.610.610.60 query14 2.802.682.73 query15 0.930.850.86 query16 0.380.380.37 query17 1.021.051.06 query18 0.210.200.20 query19 1.942.031.84 query20 0.010.020.02 query21 15.35 0.880.57 query22 0.751.231.12 query23 14.67 1.350.63 query24 7.241.950.87 query25 0.490.170.20 query26 0.550.160.14 query27 0.070.050.05 query28 9.350.820.45 query29 12.53 3.943.35 query30 0.250.090.06 query31 2.840.580.39 query32 3.230.550.48 query33 2.963.013.02 query34 15.68 5.114.47 query35 4.564.564.53 query36 0.660.500.48 query37 0.080.060.07 query38 0.060.040.04 query39 0.040.020.03 query40 0.170.140.13 query41 0.080.020.02 query42 0.040.020.02 query43 0.040.030.03 Total cold run time: 104.9 s Total hot run time: 31.85 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2736065331 TPC-DS: Total hot run time: 186232 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit dadb3566dedcd2b2bbd12c2408746795058d7d67, data reload: false query1 1018510 473 473 query2 6572190319171903 query3 6785213 214 213 query4 26515 23788 23486 23486 query5 4360653 482 482 query6 313 211 205 205 query7 4609493 304 304 query8 316 248 239 239 query9 8615263826462638 query10 470 314 257 257 query11 15907 15163 14985 14985 query12 173 114 104 104 query13 1669505 401 401 query14 10401 626063656260 query15 204 187 171 171 query16 7256653 502 502 query17 1165693 555 555 query18 1927402 297 297 query19 183 178 156 156 query20 120 114 112 112 query21 203 119 104 104 query22 4145421641234123 query23 33715 32960 33013 32960 query24 7731236724032367 query25 530 449 397 397 query26 1237272 157 157 query27 2122499 323 323 query28 3937241123962396 query29 750 557 424 424 query30 287 216 201 201 query31 969 841 779 779 query32 73 66 63 63 query33 558 360 315 315 query34 799 844 514 514 query35 821 820 724 724 query36 1022977 912 912 query37 117 102 79 79 query38 4345424940364036 query39 1421147013961396 query40 235 116 103 103 query41 54 53 52 52 query42 122 106 105 105 query43 497 510 472 472 query44 1293785 778 778 query45 172 171 168 168 query46 830 1026614 614 query47 1753180217021702 query48 375 418 307 307 query49 779 515 415 415 query50 682 734 422 422 query51 4149418241934182 query52 109 104 100 100 query53 245 255 197 197 query54 487 492 425 425 query55 84 76 85 76 query56 274 268 264 264 query57 1142114710641064 query58 246 237 234 234 query59 2496275227152715 query60 305 303 274 274 query61 152 145 145 145 query62 824 792 667 667 query63 234 187 181 181 query64 43701002675 675 query65 4405433943414339 query66 1119459 313 313 query67 15662 15345 15487 15345 query68 8074869 502 502 query69 471 303 268 268 query70 1180114311411141 query71 389 290 263 263 query72 5633362038693620 query73 734 762 355 355 query74 9035905387658765 query75 3207318027102710 query76 31971188767 767 query77 512 385 290 290 query78 10019 10273 93049304 query79 1179836 594 594 query80 647 549 506 506 query81 482 260 227 227 query82 221 129 98 98 query83 173 172 154 154 query84 242 93 76 76 query85 748 344 305 305 query86 376 311 312 311 query87 4437461644734473 query88 2938233622712271 query89 390 313 282 282 query90 1869220 226 220 query91 144 143 112 112 query92 70 58 64 58 query93 11691047594 594 query94 638 411 309 309 query95 356 278 268 268 query96 493 564 283 283 query97 3307341032923292 query98 226 215 201 201 query99 1311140212661266 Total cold run time: 270322 ms Total hot run time: 186232 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2736035852 TPC-H: Total hot run time: 32912 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit dadb3566dedcd2b2bbd12c2408746795058d7d67, data reload: false -- Round 1 -- q1 24417 525551125112 q2 2057345 194 194 q3 10442 1238699 699 q4 10242 1050538 538 q5 7737238723982387 q6 198 160 134 134 q7 946 753 620 620 q8 9316131111321132 q9 4936493849024902 q10 6847234018881888 q11 470 274 256 256 q12 350 356 217 217 q13 17797 373531073107 q14 245 234 209 209 q15 538 484 480 480 q16 625 621 580 580 q17 569 864 367 367 q18 6939660264266426 q19 1493967 534 534 q20 325 335 207 207 q21 2686218219411941 q22 10911031982 982 Total cold run time: 110266 ms Total hot run time: 32912 ms - Round 2, with runtime_filter_mode=off - q1 5191517551235123 q2 244 331 236 236 q3 2194269723312331 q4 1487186214131413 q5 4263426145294261 q6 223 175 129 129 q7 2061195317801780 q8 2657258124772477 q9 7269722971727172 q10 3010320427332733 q11 603 517 502 502 q12 689 771 615 615 q13 3462387833353335 q14 270 302 273 273 q15 519 477 470 470 q16 623 687 637 637 q17 1169162213361336 q18 7796769074507450 q19 787 754 898 754 q20 1983205818621862 q21 5399468347794683 q22 10851025992 992 Total cold run time: 52984 ms Total hot run time: 50564 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2735827278 TeamCity cloud ut coverage result: Function Coverage: 83.09% (1081/1301) Line Coverage: 66.04% (17998/27253) Region Coverage: 65.41% (8864/13551) Branch Coverage: 55.22% (4769/8636) Coverage Report: http://coverage.selectdb-in.cc/coverage/dadb3566dedcd2b2bbd12c2408746795058d7d67_dadb3566dedcd2b2bbd12c2408746795058d7d67_cloud/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2735711223 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on code in PR #47319:
URL: https://github.com/apache/doris/pull/47319#discussion_r2001333126
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/TimeV2Literal.java:
##
@@ -0,0 +1,275 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.expressions.literal;
+
+import org.apache.doris.analysis.LiteralExpr;
+import org.apache.doris.nereids.exceptions.AnalysisException;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor;
+import org.apache.doris.nereids.types.TimeV2Type;
+
+import java.time.LocalDateTime;
+
+/**
+ * Time literal in Nereids.
+ */
+public class TimeV2Literal extends Literal {
+private static final LocalDateTime START_OF_A_DAY = LocalDateTime.of(0, 1,
1, 0, 0, 0);
+private static final LocalDateTime END_OF_A_DAY = LocalDateTime.of(,
12, 31, 23, 59, 59, 99000);
+private static final TimeV2Literal MIN_TIME = new TimeV2Literal(-838, 0,
0, 0, 0);
+private static final TimeV2Literal MAX_TIME = new TimeV2Literal(838, 59,
59, 99, 6);
+
+protected int hour;
+protected int minute;
+protected int second;
+protected int microsecond;
+protected boolean negative;
+
+public TimeV2Literal(String s) {
+this(TimeV2Type.of(0), s);
Review Comment:
yes, what the scale is should be of concern to the pre level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on code in PR #47319:
URL: https://github.com/apache/doris/pull/47319#discussion_r2001333126
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/TimeV2Literal.java:
##
@@ -0,0 +1,275 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.expressions.literal;
+
+import org.apache.doris.analysis.LiteralExpr;
+import org.apache.doris.nereids.exceptions.AnalysisException;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor;
+import org.apache.doris.nereids.types.TimeV2Type;
+
+import java.time.LocalDateTime;
+
+/**
+ * Time literal in Nereids.
+ */
+public class TimeV2Literal extends Literal {
+private static final LocalDateTime START_OF_A_DAY = LocalDateTime.of(0, 1,
1, 0, 0, 0);
+private static final LocalDateTime END_OF_A_DAY = LocalDateTime.of(,
12, 31, 23, 59, 59, 99000);
+private static final TimeV2Literal MIN_TIME = new TimeV2Literal(-838, 0,
0, 0, 0);
+private static final TimeV2Literal MAX_TIME = new TimeV2Literal(838, 59,
59, 99, 6);
+
+protected int hour;
+protected int minute;
+protected int second;
+protected int microsecond;
+protected boolean negative;
+
+public TimeV2Literal(String s) {
+this(TimeV2Type.of(0), s);
Review Comment:
yes, all scales should be provided by the caller
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on code in PR #47319:
URL: https://github.com/apache/doris/pull/47319#discussion_r2001333126
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/TimeV2Literal.java:
##
@@ -0,0 +1,275 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.expressions.literal;
+
+import org.apache.doris.analysis.LiteralExpr;
+import org.apache.doris.nereids.exceptions.AnalysisException;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor;
+import org.apache.doris.nereids.types.TimeV2Type;
+
+import java.time.LocalDateTime;
+
+/**
+ * Time literal in Nereids.
+ */
+public class TimeV2Literal extends Literal {
+private static final LocalDateTime START_OF_A_DAY = LocalDateTime.of(0, 1,
1, 0, 0, 0);
+private static final LocalDateTime END_OF_A_DAY = LocalDateTime.of(,
12, 31, 23, 59, 59, 99000);
+private static final TimeV2Literal MIN_TIME = new TimeV2Literal(-838, 0,
0, 0, 0);
+private static final TimeV2Literal MAX_TIME = new TimeV2Literal(838, 59,
59, 99, 6);
+
+protected int hour;
+protected int minute;
+protected int second;
+protected int microsecond;
+protected boolean negative;
+
+public TimeV2Literal(String s) {
+this(TimeV2Type.of(0), s);
Review Comment:
yes, what the scale is should be of concern to the top
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2712546503 TPC-DS: Total hot run time: 193167 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 2e3b554c58aed911ec676f0efd5286b2de72f433, data reload: false query1 14501005995 995 query2 6150198619541954 query3 11021 450745104507 query4 54209 25588 23094 23094 query5 5277509 481 481 query6 346 203 191 191 query7 4919500 300 300 query8 326 248 248 248 query9 5846264926432643 query10 413 317 251 251 query11 15268 15115 14995 14995 query12 162 109 100 100 query13 1048506 412 412 query14 10945 677669546776 query15 191 199 212 199 query16 7130662 472 472 query17 1043724 595 595 query18 1534398 330 330 query19 189 187 156 156 query20 126 122 122 122 query21 208 133 104 104 query22 4517460442954295 query23 34204 0 33601 0 query24 5734246024242424 query25 468 462 401 401 query26 677 290 168 168 query27 1776515 337 337 query28 2780250525102505 query29 609 596 478 478 query30 280 230 207 207 query31 867 865 797 797 query32 81 72 64 64 query33 507 382 324 324 query34 768 865 520 520 query35 805 847 779 779 query36 963 1000910 910 query37 127 110 82 82 query38 4322426443104264 query39 1483141814521418 query40 206 115 104 104 query41 53 51 48 48 query42 122 108 115 108 query43 513 520 513 513 query44 1327822 819 819 query45 182 172 166 166 query46 843 1037635 635 query47 1876193218901890 query48 401 421 317 317 query49 703 529 483 483 query50 713 767 435 435 query51 4290426842324232 query52 107 104 94 94 query53 238 260 184 184 query54 486 516 409 409 query55 92 81 82 81 query56 268 264 281 264 query57 1203120211411141 query58 260 242 244 242 query59 2840307928472847 query60 276 288 279 279 query61 121 123 121 121 query62 713 750 668 668 query63 238 194 191 191 query64 15401045727 727 query65 4564446744874467 query66 760 396 300 300 query67 15927 15466 15422 15422 query68 6930819 511 511 query69 563 290 264 264 query70 1176113510971097 query71 453 310 284 284 query72 5753363238643632 query73 1205753 351 351 query74 9285920387518751 query75 3390315726882688 query76 37981196760 760 query77 566 352 280 280 query78 10224 10086 93419341 query79 2476830 617 617 query80 658 543 453 453 query81 479 257 222 222 query82 675 129 101 101 query83 185 174 160 160 query84 352 94 74 74 query85 781 359 307 307 query86 422 308 288 288 query87 4391454243944394 query88 3647226622692266 query89 416 313 293 293 query90 1868217 221 217 query91 141 149 107 107 query92 72 60 59 59 query93 19541072582 582 query94 697 419 303 303 query95 363 273 266 266 query96 481 576 276 276 query97 3432338833073307 query98 220 201 209 201 query99 1420139513001300 Total cold run time: 298104 ms Total hot run time: 193167 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2723377427 ClickBench: Total hot run time: 31.37 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit dfd1604bdb9280406334397e5ab51056a0253fbe, data reload: false query1 0.030.030.04 query2 0.110.040.05 query3 0.280.050.05 query4 1.610.080.07 query5 0.550.540.55 query6 1.190.730.73 query7 0.020.020.01 query8 0.060.050.05 query9 0.630.520.53 query10 0.590.590.59 query11 0.260.120.12 query12 0.250.130.13 query13 0.630.620.62 query14 2.652.682.68 query15 0.990.880.86 query16 0.380.380.38 query17 1.061.051.00 query18 0.180.180.17 query19 1.911.861.98 query20 0.010.020.01 query21 15.37 0.960.67 query22 0.910.970.78 query23 14.76 1.490.73 query24 5.440.570.29 query25 0.170.090.08 query26 0.550.210.18 query27 0.090.080.08 query28 10.98 1.140.56 query29 12.53 4.123.43 query30 0.300.090.06 query31 2.840.620.43 query32 3.230.590.50 query33 3.133.093.05 query34 16.44 5.204.43 query35 4.524.494.49 query36 0.640.500.49 query37 0.200.170.17 query38 0.160.160.15 query39 0.060.040.04 query40 0.210.150.16 query41 0.120.060.05 query42 0.060.060.05 query43 0.060.050.05 Total cold run time: 106.16 s Total hot run time: 31.37 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2723349813 TPC-H: Total hot run time: 32950 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit dfd1604bdb9280406334397e5ab51056a0253fbe, data reload: false -- Round 1 -- q1 17613 519050765076 q2 2060301 172 172 q3 10399 1291799 799 q4 10214 1048540 540 q5 7543242724292427 q6 191 162 132 132 q7 935 781 610 610 q8 9299131111721172 q9 5088467746254625 q10 6848234719191919 q11 488 287 260 260 q12 360 353 214 214 q13 17779 370530673067 q14 230 236 209 209 q15 563 492 483 483 q16 655 645 589 589 q17 620 909 366 366 q18 6943654665116511 q19 1361956 592 592 q20 334 351 197 197 q21 3085232919931993 q22 10621017997 997 Total cold run time: 103670 ms Total hot run time: 32950 ms - Round 2, with runtime_filter_mode=off - q1 5254520051895189 q2 239 335 228 228 q3 2145264422962296 q4 1459187313811381 q5 4249419442364194 q6 215 168 135 135 q7 1992193217931793 q8 2661266626202620 q9 7322729971647164 q10 3055323727712771 q11 591 510 524 510 q12 662 767 601 601 q13 3581396932983298 q14 280 308 283 283 q15 543 481 492 481 q16 637 687 641 641 q17 1166163813651365 q18 7786769276017601 q19 914 101610921016 q20 1999208019191919 q21 5632501247844784 q22 1146101010071007 Total cold run time: 53528 ms Total hot run time: 51277 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2723363174 # BE UT Coverage Report Increment line coverage `32.93% (27/82)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/dfd1604bdb9280406334397e5ab51056a0253fbe_dfd1604bdb9280406334397e5ab51056a0253fbe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/dfd1604bdb9280406334397e5ab51056a0253fbe_dfd1604bdb9280406334397e5ab51056a0253fbe/report/index.html) | Category | Coverage | |---|| | Function Coverage | 47.98% (12831/26741) | | Line Coverage | 37.36% (109473/293056) | | Region Coverage | 36.49% (56103/153766) | | Branch Coverage | 31.77% (28273/88990) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2723366887 TPC-DS: Total hot run time: 192387 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit dfd1604bdb9280406334397e5ab51056a0253fbe, data reload: false query1 14271032989 989 query2 6099188218741874 query3 11031 452145054505 query4 54133 25792 23216 23216 query5 5067566 494 494 query6 355 204 194 194 query7 4897516 297 297 query8 323 270 255 255 query9 5805265826632658 query10 432 321 254 254 query11 15132 15063 15299 15063 query12 169 112 102 102 query13 1042512 422 422 query14 10747 656068006560 query15 208 206 179 179 query16 7106638 506 506 query17 1092748 599 599 query18 1568424 331 331 query19 202 199 186 186 query20 131 128 128 128 query21 207 124 107 107 query22 4506457244874487 query23 33951 33470 33384 33384 query24 5854246624282428 query25 476 477 419 419 query26 720 281 160 160 query27 1842498 336 336 query28 2812246024572457 query29 624 561 432 432 query30 275 227 193 193 query31 867 893 806 806 query32 74 70 62 62 query33 473 360 315 315 query34 815 867 512 512 query35 858 832 740 740 query36 962 997 909 909 query37 115 99 78 78 query38 4148425544534255 query39 1530145814371437 query40 210 120 108 108 query41 54 52 49 49 query42 122 109 109 109 query43 489 523 492 492 query44 1344822 814 814 query45 181 187 174 174 query46 867 1039665 665 query47 1850188618171817 query48 399 442 304 304 query49 715 537 442 442 query50 731 762 447 447 query51 4325424542404240 query52 111 110 97 97 query53 230 261 193 193 query54 494 514 427 427 query55 85 82 81 81 query56 266 288 280 280 query57 1184119311281128 query58 245 247 243 243 query59 2661291526072607 query60 313 282 260 260 query61 129 140 126 126 query62 756 752 687 687 query63 236 198 190 190 query64 2307708 708 query65 4518446644334433 query66 770 399 294 294 query67 15963 15801 15272 15272 query68 7069889 511 511 query69 533 308 272 272 query70 1221112310471047 query71 499 293 267 267 query72 5822359937103599 query73 1376731 348 348 query74 9177917184908490 query75 3764313027492749 query76 42361200766 766 query77 624 357 275 275 query78 10048 999492759275 query79 2871815 577 577 query80 691 582 462 462 query81 494 264 217 217 query82 654 124 95 95 query83 285 167 153 153 query84 279 94 76 76 query85 798 362 314 314 query86 379 296 286 286 query87 4535473444814481 query88 3499222922352229 query89 414 315 285 285 query90 1897208 209 208 query91 145 139 113 113 query92 74 58 59 58 query93 18601080590 590 query94 673 499 294 294 query95 347 267 258 258 query96 488 567 279 279 query97 3327341732903290 query98 224 205 211 205 query99 1426138113021302 Total cold run time: 299359 ms Total hot run time: 192387 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2723192227 TeamCity cloud ut coverage result: Function Coverage: 82.88% (1075/1297) Line Coverage: 65.87% (17737/26927) Region Coverage: 65.20% (8731/13391) Branch Coverage: 55.14% (4707/8536) Coverage Report: http://coverage.selectdb-in.cc/coverage/dfd1604bdb9280406334397e5ab51056a0253fbe_dfd1604bdb9280406334397e5ab51056a0253fbe_cloud/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2723149325 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2723141768 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
hello-stephen commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2720981424 # BE UT Coverage Report Increment line coverage `32.93% (27/82)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/f7c1a553e22f75642d4258a8bd14e532665fc23b_f7c1a553e22f75642d4258a8bd14e532665fc23b/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/f7c1a553e22f75642d4258a8bd14e532665fc23b_f7c1a553e22f75642d4258a8bd14e532665fc23b/report/index.html) | Category | Coverage | |---|| | Function Coverage | 47.92% (12812/26739) | | Line Coverage | 37.30% (109313/293034) | | Region Coverage | 36.41% (55980/153745) | | Branch Coverage | 31.72% (28223/88980) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on code in PR #47319:
URL: https://github.com/apache/doris/pull/47319#discussion_r1992994003
##
fe/fe-core/src/main/java/org/apache/doris/analysis/TimeV2Literal.java:
##
@@ -0,0 +1,287 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.analysis;
+
+import org.apache.doris.catalog.ScalarType;
+import org.apache.doris.catalog.Type;
+import org.apache.doris.common.FormatOptions;
+import org.apache.doris.nereids.exceptions.AnalysisException;
+import org.apache.doris.thrift.TExprNode;
+import org.apache.doris.thrift.TExprNodeType;
+import org.apache.doris.thrift.TTimeV2Literal;
+
+public class TimeV2Literal extends LiteralExpr {
+
+public static final TimeV2Literal MIN_TIME = new TimeV2Literal(-838, 0, 0,
0, 0);
+public static final TimeV2Literal MAX_TIME = new TimeV2Literal(838, 59,
59, 99, 6);
+
+protected int hour;
+protected int minute;
+protected int second;
+protected int microsecond;
+protected boolean negative;
+
+/**
+ * C'tor forcing type, e.g., due to implicit cast
+ */
+// for restore
+private TimeV2Literal() {
+this.type = Type.TIMEV2;
+this.hour = 0;
+this.minute = 0;
+this.second = 0;
+this.microsecond = 0;
+this.negative = false;
+}
+
+public TimeV2Literal(double value) throws AnalysisException {
+super();
+if (value > (double) MAX_TIME.getValue() || value < -(double)
MAX_TIME.getValue()) {
+throw new AnalysisException("The value is out of range");
+}
+this.type = ScalarType.createTimeV2Type(6);
+this.negative = 1.0 / value < 0;
+long v = (long) Math.abs(value);
+this.microsecond = (int) (v % 100);
+v /= 100;
+this.second = (int) (v % 60);
+v /= 60;
+this.minute = (int) (v % 60);
+v /= 60;
+this.hour = (int) v;
+analysisDone();
+}
+
+public TimeV2Literal(int hour, int minute, int second) throws
AnalysisException {
+super();
+this.type = Type.TIMEV2;
+this.hour = Math.abs(hour);
+this.minute = minute;
+this.second = second;
+this.microsecond = 0;
+this.negative = hour < 0;
+if (checkRange(this.hour, this.minute, this.second, this.microsecond))
{
+throw new AnalysisException("time literal is out of range");
+}
+analysisDone();
+}
+
+public TimeV2Literal(int hour, int minute, int second, int microsecond,
int scale) throws AnalysisException {
+super();
+this.type = ScalarType.createTimeV2Type(scale);
+this.hour = Math.abs(hour);
+this.minute = minute;
+this.second = second;
+this.microsecond = microsecond;
+while (microsecond != 0 && this.microsecond < 10) {
+this.microsecond *= 10;
+}
+this.negative = hour < 0;
+if (checkRange(this.hour, this.minute, this.second, this.microsecond))
{
+throw new AnalysisException("time literal is out of range");
+}
+analysisDone();
+}
+
+public TimeV2Literal(String s) {
+super();
+init(s);
+analysisDone();
+}
+
+protected TimeV2Literal(TimeV2Literal other) {
+super(other);
+this.type = ScalarType.createTimeV2Type(((ScalarType)
other.type).getScalarScale());
+this.hour = other.getHour();
+this.minute = other.getMinute();
+this.second = other.getSecond();
+this.microsecond = other.getMicroSecond();
+}
+
+@Override
+public Expr clone() {
+return new TimeV2Literal(this);
+}
+
+protected String normalize(String s) {
+// remove suffix/prefix ' '
+s = s.trim();
+if (s.charAt(0) == '-') {
+s = s.substring(1);
+negative = true;
+}
+if (!s.contains(":")) {
+String tail = "";
+if (s.contains(".")) {
+tail = s.substring(s.indexOf("."));
+s = s.substring(0, s.indexOf("."));
+}
+int len = s.length();
+if (len == 1) {
+
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2720547467 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2720385874 TeamCity cloud ut coverage result: Function Coverage: 82.88% (1075/1297) Line Coverage: 65.87% (17730/26918) Region Coverage: 65.19% (8728/13388) Branch Coverage: 55.17% (4708/8534) Coverage Report: http://coverage.selectdb-in.cc/coverage/f7c1a553e22f75642d4258a8bd14e532665fc23b_f7c1a553e22f75642d4258a8bd14e532665fc23b_cloud/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2720368180 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on code in PR #47319:
URL: https://github.com/apache/doris/pull/47319#discussion_r1992994003
##
fe/fe-core/src/main/java/org/apache/doris/analysis/TimeV2Literal.java:
##
@@ -0,0 +1,287 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.analysis;
+
+import org.apache.doris.catalog.ScalarType;
+import org.apache.doris.catalog.Type;
+import org.apache.doris.common.FormatOptions;
+import org.apache.doris.nereids.exceptions.AnalysisException;
+import org.apache.doris.thrift.TExprNode;
+import org.apache.doris.thrift.TExprNodeType;
+import org.apache.doris.thrift.TTimeV2Literal;
+
+public class TimeV2Literal extends LiteralExpr {
+
+public static final TimeV2Literal MIN_TIME = new TimeV2Literal(-838, 0, 0,
0, 0);
+public static final TimeV2Literal MAX_TIME = new TimeV2Literal(838, 59,
59, 99, 6);
+
+protected int hour;
+protected int minute;
+protected int second;
+protected int microsecond;
+protected boolean negative;
+
+/**
+ * C'tor forcing type, e.g., due to implicit cast
+ */
+// for restore
+private TimeV2Literal() {
+this.type = Type.TIMEV2;
+this.hour = 0;
+this.minute = 0;
+this.second = 0;
+this.microsecond = 0;
+this.negative = false;
+}
+
+public TimeV2Literal(double value) throws AnalysisException {
+super();
+if (value > (double) MAX_TIME.getValue() || value < -(double)
MAX_TIME.getValue()) {
+throw new AnalysisException("The value is out of range");
+}
+this.type = ScalarType.createTimeV2Type(6);
+this.negative = 1.0 / value < 0;
+long v = (long) Math.abs(value);
+this.microsecond = (int) (v % 100);
+v /= 100;
+this.second = (int) (v % 60);
+v /= 60;
+this.minute = (int) (v % 60);
+v /= 60;
+this.hour = (int) v;
+analysisDone();
+}
+
+public TimeV2Literal(int hour, int minute, int second) throws
AnalysisException {
+super();
+this.type = Type.TIMEV2;
+this.hour = Math.abs(hour);
+this.minute = minute;
+this.second = second;
+this.microsecond = 0;
+this.negative = hour < 0;
+if (checkRange(this.hour, this.minute, this.second, this.microsecond))
{
+throw new AnalysisException("time literal is out of range");
+}
+analysisDone();
+}
+
+public TimeV2Literal(int hour, int minute, int second, int microsecond,
int scale) throws AnalysisException {
+super();
+this.type = ScalarType.createTimeV2Type(scale);
+this.hour = Math.abs(hour);
+this.minute = minute;
+this.second = second;
+this.microsecond = microsecond;
+while (microsecond != 0 && this.microsecond < 10) {
+this.microsecond *= 10;
+}
+this.negative = hour < 0;
+if (checkRange(this.hour, this.minute, this.second, this.microsecond))
{
+throw new AnalysisException("time literal is out of range");
+}
+analysisDone();
+}
+
+public TimeV2Literal(String s) {
+super();
+init(s);
+analysisDone();
+}
+
+protected TimeV2Literal(TimeV2Literal other) {
+super(other);
+this.type = ScalarType.createTimeV2Type(((ScalarType)
other.type).getScalarScale());
+this.hour = other.getHour();
+this.minute = other.getMinute();
+this.second = other.getSecond();
+this.microsecond = other.getMicroSecond();
+}
+
+@Override
+public Expr clone() {
+return new TimeV2Literal(this);
+}
+
+protected String normalize(String s) {
+// remove suffix/prefix ' '
+s = s.trim();
+if (s.charAt(0) == '-') {
+s = s.substring(1);
+negative = true;
+}
+if (!s.contains(":")) {
+String tail = "";
+if (s.contains(".")) {
+tail = s.substring(s.indexOf("."));
+s = s.substring(0, s.indexOf("."));
+}
+int len = s.length();
+if (len == 1) {
+
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2712284110 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2712638524 # BE UT Coverage Report Increment line coverage `27.84% (27/97)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/2e3b554c58aed911ec676f0efd5286b2de72f433_2e3b554c58aed911ec676f0efd5286b2de72f433/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/2e3b554c58aed911ec676f0efd5286b2de72f433_2e3b554c58aed911ec676f0efd5286b2de72f433/report/index.html) | Category | Coverage | |---|| | Function Coverage | 46.86% (12527/26733) | | Line Coverage | 36.46% (106772/292808) | | Region Coverage | 35.50% (54556/153686) | | Branch Coverage | 30.88% (27454/88908) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2712556211 ClickBench: Total hot run time: 31.51 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 2e3b554c58aed911ec676f0efd5286b2de72f433, data reload: false query1 0.040.040.03 query2 0.110.050.04 query3 0.280.050.05 query4 1.600.100.07 query5 0.560.550.55 query6 1.180.740.73 query7 0.020.010.02 query8 0.050.050.05 query9 0.640.520.52 query10 0.590.610.58 query11 0.260.130.12 query12 0.250.130.14 query13 0.640.620.62 query14 2.862.722.82 query15 1.010.890.89 query16 0.370.370.37 query17 1.071.031.07 query18 0.180.190.18 query19 2.161.841.80 query20 0.010.010.02 query21 15.35 1.000.68 query22 0.931.030.82 query23 14.69 1.520.77 query24 5.260.600.30 query25 0.170.090.08 query26 0.550.240.18 query27 0.080.080.08 query28 11.02 1.140.58 query29 12.55 4.193.42 query30 0.280.080.06 query31 2.830.630.43 query32 3.230.600.50 query33 3.173.003.16 query34 16.43 5.124.53 query35 4.474.504.44 query36 0.630.500.50 query37 0.200.170.18 query38 0.170.150.17 query39 0.040.040.04 query40 0.190.160.15 query41 0.100.050.05 query42 0.060.040.04 query43 0.050.050.04 Total cold run time: 106.33 s Total hot run time: 31.51 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2712528023 TPC-H: Total hot run time: 32702 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 2e3b554c58aed911ec676f0efd5286b2de72f433, data reload: false -- Round 1 -- q1 17681 523750365036 q2 2049292 160 160 q3 10678 1250766 766 q4 10222 1031530 530 q5 7620238223922382 q6 186 161 132 132 q7 907 754 613 613 q8 9304143511531153 q9 4903475747714757 q10 6809231719311931 q11 476 274 255 255 q12 355 361 216 216 q13 17772 370830953095 q14 235 233 218 218 q15 556 491 490 490 q16 626 616 585 585 q17 595 896 336 336 q18 7268638664446386 q19 1739958 554 554 q20 324 338 199 199 q21 2787213919291929 q22 1005987 979 979 Total cold run time: 104097 ms Total hot run time: 32702 ms - Round 2, with runtime_filter_mode=off - q1 5205510350815081 q2 241 323 226 226 q3 2184267623352335 q4 1428181813851385 q5 4293414941934149 q6 220 172 126 126 q7 1988194017431743 q8 2666259225562556 q9 7283721773287217 q10 3031320428192819 q11 572 520 493 493 q12 657 732 610 610 q13 35583940 q14 293 307 264 264 q15 538 494 507 494 q16 650 695 644 644 q17 1155168113351335 q18 7843763076267626 q19 827 844 920 844 q20 2004203718571857 q21 5536496247944794 q22 1094104910141014 Total cold run time: 53266 ms Total hot run time: 50945 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2712329446 TeamCity cloud ut coverage result: Function Coverage: 83.05% (1073/1292) Line Coverage: 65.90% (17677/26824) Region Coverage: 65.34% (8713/13334) Branch Coverage: 55.22% (4698/8508) Coverage Report: http://coverage.selectdb-in.cc/coverage/2e3b554c58aed911ec676f0efd5286b2de72f433_2e3b554c58aed911ec676f0efd5286b2de72f433_cloud/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2708939289 # BE UT Coverage Report Increment line coverage `27.84% (27/97)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/8ff269e2026e15d0cf825300eee132c06450436f_8ff269e2026e15d0cf825300eee132c06450436f/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/8ff269e2026e15d0cf825300eee132c06450436f_8ff269e2026e15d0cf825300eee132c06450436f/report/index.html) | Category | Coverage | |---|| | Function Coverage | 46.89% (12542/26748) | | Line Coverage | 36.46% (106905/293210) | | Region Coverage | 35.50% (54604/153810) | | Branch Coverage | 30.85% (27463/89012) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2708840307 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2708852391 TeamCity cloud ut coverage result: Function Coverage: 82.15% (1063/1294) Line Coverage: 65.66% (17624/26840) Region Coverage: 65.11% (8686/13340) Branch Coverage: 55.08% (4687/8510) Coverage Report: http://coverage.selectdb-in.cc/coverage/8ff269e2026e15d0cf825300eee132c06450436f_8ff269e2026e15d0cf825300eee132c06450436f_cloud/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2708841501 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on code in PR #47319:
URL: https://github.com/apache/doris/pull/47319#discussion_r1979642046
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/TimeV2Literal.java:
##
@@ -0,0 +1,275 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.expressions.literal;
+
+import org.apache.doris.analysis.LiteralExpr;
+import org.apache.doris.nereids.exceptions.AnalysisException;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor;
+import org.apache.doris.nereids.types.TimeV2Type;
+
+import java.time.LocalDateTime;
+
+/**
+ * Time literal in Nereids.
+ */
+public class TimeV2Literal extends Literal {
+private static final LocalDateTime START_OF_A_DAY = LocalDateTime.of(0, 1,
1, 0, 0, 0);
+private static final LocalDateTime END_OF_A_DAY = LocalDateTime.of(,
12, 31, 23, 59, 59, 99000);
+private static final TimeV2Literal MIN_TIME = new TimeV2Literal(-838, 0,
0, 0, 0);
+private static final TimeV2Literal MAX_TIME = new TimeV2Literal(838, 59,
59, 99, 6);
+
+protected int hour;
+protected int minute;
+protected int second;
+protected int microsecond;
+protected boolean negative;
+
+public TimeV2Literal(String s) {
+this(TimeV2Type.of(0), s);
Review Comment:
because if the sql is`select cast("01:01:01.123456" as time)` will call this
function directly, the sql means scale is 0, unless it use `as time(scale)`
this situation will call another function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on code in PR #47319:
URL: https://github.com/apache/doris/pull/47319#discussion_r1979642046
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/TimeV2Literal.java:
##
@@ -0,0 +1,275 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.expressions.literal;
+
+import org.apache.doris.analysis.LiteralExpr;
+import org.apache.doris.nereids.exceptions.AnalysisException;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor;
+import org.apache.doris.nereids.types.TimeV2Type;
+
+import java.time.LocalDateTime;
+
+/**
+ * Time literal in Nereids.
+ */
+public class TimeV2Literal extends Literal {
+private static final LocalDateTime START_OF_A_DAY = LocalDateTime.of(0, 1,
1, 0, 0, 0);
+private static final LocalDateTime END_OF_A_DAY = LocalDateTime.of(,
12, 31, 23, 59, 59, 99000);
+private static final TimeV2Literal MIN_TIME = new TimeV2Literal(-838, 0,
0, 0, 0);
+private static final TimeV2Literal MAX_TIME = new TimeV2Literal(838, 59,
59, 99, 6);
+
+protected int hour;
+protected int minute;
+protected int second;
+protected int microsecond;
+protected boolean negative;
+
+public TimeV2Literal(String s) {
+this(TimeV2Type.of(0), s);
Review Comment:
because if the sql is`select cast("01:01:01.123456" as time)` will call this
function directly, the sql means scale is 0, unless it use `as time(scale)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on code in PR #47319:
URL: https://github.com/apache/doris/pull/47319#discussion_r1979679471
##
fe/fe-core/src/main/java/org/apache/doris/analysis/TimeV2Literal.java:
##
@@ -0,0 +1,287 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.analysis;
+
+import org.apache.doris.catalog.ScalarType;
+import org.apache.doris.catalog.Type;
+import org.apache.doris.common.FormatOptions;
+import org.apache.doris.nereids.exceptions.AnalysisException;
+import org.apache.doris.thrift.TExprNode;
+import org.apache.doris.thrift.TExprNodeType;
+import org.apache.doris.thrift.TTimeV2Literal;
+
+public class TimeV2Literal extends LiteralExpr {
+
+public static final TimeV2Literal MIN_TIME = new TimeV2Literal(-838, 0, 0,
0, 0);
+public static final TimeV2Literal MAX_TIME = new TimeV2Literal(838, 59,
59, 99, 6);
+
+protected int hour;
+protected int minute;
+protected int second;
+protected int microsecond;
+protected boolean negative;
+
+/**
+ * C'tor forcing type, e.g., due to implicit cast
+ */
+// for restore
+private TimeV2Literal() {
+this.type = Type.TIMEV2;
+this.hour = 0;
+this.minute = 0;
+this.second = 0;
+this.microsecond = 0;
+this.negative = false;
+}
+
+public TimeV2Literal(double value) throws AnalysisException {
+super();
+if (value > (double) MAX_TIME.getValue() || value < -(double)
MAX_TIME.getValue()) {
Review Comment:
MAX_TIME and MIN_TIME just store every part min max value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on code in PR #47319:
URL: https://github.com/apache/doris/pull/47319#discussion_r1979678414
##
fe/fe-core/src/main/java/org/apache/doris/analysis/TimeV2Literal.java:
##
@@ -0,0 +1,287 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.analysis;
+
+import org.apache.doris.catalog.ScalarType;
+import org.apache.doris.catalog.Type;
+import org.apache.doris.common.FormatOptions;
+import org.apache.doris.nereids.exceptions.AnalysisException;
+import org.apache.doris.thrift.TExprNode;
+import org.apache.doris.thrift.TExprNodeType;
+import org.apache.doris.thrift.TTimeV2Literal;
+
+public class TimeV2Literal extends LiteralExpr {
+
+public static final TimeV2Literal MIN_TIME = new TimeV2Literal(-838, 0, 0,
0, 0);
+public static final TimeV2Literal MAX_TIME = new TimeV2Literal(838, 59,
59, 99, 6);
+
+protected int hour;
+protected int minute;
+protected int second;
+protected int microsecond;
+protected boolean negative;
+
+/**
+ * C'tor forcing type, e.g., due to implicit cast
+ */
+// for restore
+private TimeV2Literal() {
+this.type = Type.TIMEV2;
+this.hour = 0;
+this.minute = 0;
+this.second = 0;
+this.microsecond = 0;
+this.negative = false;
+}
+
+public TimeV2Literal(double value) throws AnalysisException {
+super();
+if (value > (double) MAX_TIME.getValue() || value < -(double)
MAX_TIME.getValue()) {
+throw new AnalysisException("The value is out of range");
+}
+this.type = ScalarType.createTimeV2Type(6);
+this.negative = 1.0 / value < 0;
+long v = (long) Math.abs(value);
+this.microsecond = (int) (v % 100);
+v /= 100;
+this.second = (int) (v % 60);
+v /= 60;
+this.minute = (int) (v % 60);
+v /= 60;
+this.hour = (int) v;
+analysisDone();
+}
+
+public TimeV2Literal(int hour, int minute, int second) throws
AnalysisException {
+super();
+this.type = Type.TIMEV2;
+this.hour = Math.abs(hour);
+this.minute = minute;
+this.second = second;
+this.microsecond = 0;
+this.negative = hour < 0;
+if (checkRange(this.hour, this.minute, this.second, this.microsecond))
{
+throw new AnalysisException("time literal is out of range");
+}
+analysisDone();
+}
+
+public TimeV2Literal(int hour, int minute, int second, int microsecond,
int scale) throws AnalysisException {
+super();
+this.type = ScalarType.createTimeV2Type(scale);
+this.hour = Math.abs(hour);
+this.minute = minute;
+this.second = second;
+this.microsecond = microsecond;
+while (microsecond != 0 && this.microsecond < 10) {
+this.microsecond *= 10;
+}
+this.negative = hour < 0;
+if (checkRange(this.hour, this.minute, this.second, this.microsecond))
{
+throw new AnalysisException("time literal is out of range");
+}
+analysisDone();
+}
+
+public TimeV2Literal(String s) {
+super();
+init(s);
+analysisDone();
+}
+
+protected TimeV2Literal(TimeV2Literal other) {
+super(other);
+this.type = ScalarType.createTimeV2Type(((ScalarType)
other.type).getScalarScale());
+this.hour = other.getHour();
+this.minute = other.getMinute();
+this.second = other.getSecond();
+this.microsecond = other.getMicroSecond();
+}
+
+@Override
+public Expr clone() {
+return new TimeV2Literal(this);
+}
+
+protected String normalize(String s) {
+// remove suffix/prefix ' '
+s = s.trim();
+if (s.charAt(0) == '-') {
+s = s.substring(1);
+negative = true;
+}
+if (!s.contains(":")) {
+String tail = "";
+if (s.contains(".")) {
+tail = s.substring(s.indexOf("."));
+s = s.substring(0, s.indexOf("."));
+}
+int len = s.length();
+if (len == 1) {
+
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on code in PR #47319:
URL: https://github.com/apache/doris/pull/47319#discussion_r1979642046
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/TimeV2Literal.java:
##
@@ -0,0 +1,275 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.expressions.literal;
+
+import org.apache.doris.analysis.LiteralExpr;
+import org.apache.doris.nereids.exceptions.AnalysisException;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor;
+import org.apache.doris.nereids.types.TimeV2Type;
+
+import java.time.LocalDateTime;
+
+/**
+ * Time literal in Nereids.
+ */
+public class TimeV2Literal extends Literal {
+private static final LocalDateTime START_OF_A_DAY = LocalDateTime.of(0, 1,
1, 0, 0, 0);
+private static final LocalDateTime END_OF_A_DAY = LocalDateTime.of(,
12, 31, 23, 59, 59, 99000);
+private static final TimeV2Literal MIN_TIME = new TimeV2Literal(-838, 0,
0, 0, 0);
+private static final TimeV2Literal MAX_TIME = new TimeV2Literal(838, 59,
59, 99, 6);
+
+protected int hour;
+protected int minute;
+protected int second;
+protected int microsecond;
+protected boolean negative;
+
+public TimeV2Literal(String s) {
+this(TimeV2Type.of(0), s);
Review Comment:
because if the sql is`select cast("01:01:01.123456" as time) will call this
function directly`
will call this function directly, the sql means scale is 0, unless it use
`as time(scale)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
morrySnow commented on code in PR #47319:
URL: https://github.com/apache/doris/pull/47319#discussion_r1979174938
##
fe/fe-core/src/main/java/org/apache/doris/analysis/TimeV2Literal.java:
##
@@ -0,0 +1,287 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.analysis;
+
+import org.apache.doris.catalog.ScalarType;
+import org.apache.doris.catalog.Type;
+import org.apache.doris.common.FormatOptions;
+import org.apache.doris.nereids.exceptions.AnalysisException;
+import org.apache.doris.thrift.TExprNode;
+import org.apache.doris.thrift.TExprNodeType;
+import org.apache.doris.thrift.TTimeV2Literal;
+
+public class TimeV2Literal extends LiteralExpr {
+
+public static final TimeV2Literal MIN_TIME = new TimeV2Literal(-838, 0, 0,
0, 0);
+public static final TimeV2Literal MAX_TIME = new TimeV2Literal(838, 59,
59, 99, 6);
+
+protected int hour;
+protected int minute;
+protected int second;
+protected int microsecond;
+protected boolean negative;
+
+/**
+ * C'tor forcing type, e.g., due to implicit cast
+ */
+// for restore
+private TimeV2Literal() {
+this.type = Type.TIMEV2;
+this.hour = 0;
+this.minute = 0;
+this.second = 0;
+this.microsecond = 0;
+this.negative = false;
+}
+
+public TimeV2Literal(double value) throws AnalysisException {
+super();
+if (value > (double) MAX_TIME.getValue() || value < -(double)
MAX_TIME.getValue()) {
+throw new AnalysisException("The value is out of range");
Review Comment:
could u print out the current value's time and the range we accepted in
error message?
##
fe/fe-core/src/main/java/org/apache/doris/analysis/TimeV2Literal.java:
##
@@ -0,0 +1,287 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.analysis;
+
+import org.apache.doris.catalog.ScalarType;
+import org.apache.doris.catalog.Type;
+import org.apache.doris.common.FormatOptions;
+import org.apache.doris.nereids.exceptions.AnalysisException;
+import org.apache.doris.thrift.TExprNode;
+import org.apache.doris.thrift.TExprNodeType;
+import org.apache.doris.thrift.TTimeV2Literal;
+
+public class TimeV2Literal extends LiteralExpr {
+
+public static final TimeV2Literal MIN_TIME = new TimeV2Literal(-838, 0, 0,
0, 0);
+public static final TimeV2Literal MAX_TIME = new TimeV2Literal(838, 59,
59, 99, 6);
+
+protected int hour;
+protected int minute;
+protected int second;
+protected int microsecond;
+protected boolean negative;
+
+/**
+ * C'tor forcing type, e.g., due to implicit cast
+ */
+// for restore
+private TimeV2Literal() {
+this.type = Type.TIMEV2;
+this.hour = 0;
+this.minute = 0;
+this.second = 0;
+this.microsecond = 0;
+this.negative = false;
+}
+
+public TimeV2Literal(double value) throws AnalysisException {
+super();
+if (value > (double) MAX_TIME.getValue() || value < -(double)
MAX_TIME.getValue()) {
Review Comment:
why not use `MIN_TIME` when check lowest bound? does this mean, we accept
`-(838, 01,01, 0)`? it is lower than `MIN_TIME`
##
fe/fe-core/src/test/java/org/apache/doris/nereids/trees/expressions/literal/TimeV2LiteralTest.java:
##
@@ -0,0 +1,106 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2675241365 ClickBench: Total hot run time: 30.95 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit ac8e1f14a8270ed3f582f5402795b4c4e616b971, data reload: false query1 0.030.030.03 query2 0.100.050.04 query3 0.280.050.05 query4 1.600.080.07 query5 0.410.400.40 query6 1.170.670.65 query7 0.030.020.01 query8 0.060.070.04 query9 0.620.520.54 query10 0.580.590.58 query11 0.250.120.12 query12 0.250.120.13 query13 0.630.610.61 query14 2.672.782.71 query15 0.990.870.88 query16 0.370.400.38 query17 1.051.011.06 query18 0.180.180.19 query19 1.921.832.00 query20 0.020.010.01 query21 15.36 0.940.65 query22 0.911.010.77 query23 14.72 1.530.71 query24 5.520.520.27 query25 0.160.090.09 query26 0.550.220.18 query27 0.090.090.08 query28 10.99 1.190.56 query29 12.51 4.093.41 query30 0.270.080.06 query31 2.830.620.42 query32 3.230.590.50 query33 3.033.073.12 query34 16.58 5.104.39 query35 4.474.454.42 query36 0.630.510.49 query37 0.210.180.17 query38 0.180.150.14 query39 0.050.050.04 query40 0.200.160.16 query41 0.110.060.05 query42 0.070.050.04 query43 0.050.050.05 Total cold run time: 105.93 s Total hot run time: 30.95 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2675168656 TeamCity cloud ut coverage result: Function Coverage: 82.25% (1061/1290) Line Coverage: 65.80% (17599/26746) Region Coverage: 65.34% (8671/13271) Branch Coverage: 55.29% (4679/8462) Coverage Report: http://coverage.selectdb-in.cc/coverage/ac8e1f14a8270ed3f582f5402795b4c4e616b971_ac8e1f14a8270ed3f582f5402795b4c4e616b971_cloud/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2675231040 TPC-DS: Total hot run time: 190451 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit ac8e1f14a8270ed3f582f5402795b4c4e616b971, data reload: false query1 1283964 943 943 query2 6475183918191819 query3 10908 462144114411 query4 57353 25758 23339 23339 query5 5136491 473 473 query6 363 177 176 176 query7 5105504 288 288 query8 305 245 241 241 query9 6469256925712569 query10 397 311 257 257 query11 15151 15045 14970 14970 query12 151 109 102 102 query13 1167495 388 388 query14 10006 633066896330 query15 215 194 188 188 query16 7115671 453 453 query17 1069714 575 575 query18 1644415 305 305 query19 195 198 158 158 query20 132 125 133 125 query21 216 119 104 104 query22 4415459743084308 query23 33767 33284 5 33284 query24 5528240724142407 query25 496 490 462 462 query26 725 285 152 152 query27 2015479 351 351 query28 2847249224462446 query29 561 569 434 434 query30 221 190 159 159 query31 900 869 824 824 query32 73 62 58 58 query33 462 359 309 309 query34 730 880 528 528 query35 784 838 761 761 query36 956 981 926 926 query37 135 101 79 79 query38 4223438844014388 query39 1474142414381424 query40 210 112 106 106 query41 53 52 52 52 query42 131 104 106 104 query43 505 514 487 487 query44 1309801 799 799 query45 184 171 183 171 query46 873 1097661 661 query47 1846186418081808 query48 392 435 322 322 query49 682 525 435 435 query50 691 753 423 423 query51 4248432042464246 query52 106 100 101 100 query53 236 274 183 183 query54 479 505 419 419 query55 82 82 79 79 query56 261 278 255 255 query57 1147117011551155 query58 250 241 239 239 query59 2715284026542654 query60 290 285 261 261 query61 128 139 120 120 query62 744 751 681 681 query63 240 202 188 188 query64 17401056790 790 query65 3300316331983163 query66 713 397 296 296 query67 15826 15595 15456 15456 query68 2709765 534 534 query69 424 310 265 265 query70 1122113011351130 query71 331 298 260 260 query72 6082361138743611 query73 631 764 346 346 query74 9199921092229210 query75 3123317726702670 query76 15911147723 723 query77 463 351 274 274 query78 994210156 92019201 query79 1678870 615 615 query80 849 542 451 451 query81 511 272 237 237 query82 1023131 94 94 query83 299 164 156 156 query84 281 94 72 72 query85 755 357 318 318 query86 346 292 290 290 query87 4583444745084447 query88 3000222021552155 query89 402 321 279 279 query90 1631192 188 188 query91 135 140 110 110 query92 67 61 55 55 query93 14381013587 587 query94 619 384 275 275 query95 351 271 252 252 query96 493 548 271 271 query97 2792287727162716 query98 224 205 209 205 query99 1325139812871287 Total cold run time: 288967 ms Total hot run time: 190451 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2675230200 TeamCity be ut coverage result: Function Coverage: 44.54% (11762/26410) Line Coverage: 34.02% (98320/289038) Region Coverage: 33.10% (50366/152164) Branch Coverage: 28.75% (25328/88094) Coverage Report: http://coverage.selectdb-in.cc/coverage/ac8e1f14a8270ed3f582f5402795b4c4e616b971_ac8e1f14a8270ed3f582f5402795b4c4e616b971/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2675207091 TPC-H: Total hot run time: 31361 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit ac8e1f14a8270ed3f582f5402795b4c4e616b971, data reload: false -- Round 1 -- q1 17619 528550795079 q2 2043299 172 172 q3 10726 1252749 749 q4 10270 999 542 542 q5 8215244322742274 q6 192 170 136 136 q7 904 770 603 603 q8 9319134011591159 q9 4753463046614630 q10 6819231418691869 q11 464 269 263 263 q12 354 352 225 225 q13 17762 369630453045 q14 229 219 205 205 q15 538 456 462 456 q16 632 606 580 580 q17 559 861 323 323 q18 6839610561396105 q19 2050968 546 546 q20 296 317 192 192 q21 2718214319021902 q22 376 339 306 306 Total cold run time: 103677 ms Total hot run time: 31361 ms - Round 2, with runtime_filter_mode=off - q1 5179508151265081 q2 239 325 228 228 q3 2152264623262326 q4 1445186013571357 q5 4218411041714110 q6 208 169 125 125 q7 1881182317541754 q8 2603257524942494 q9 7258717371897173 q10 2991319427732773 q11 580 533 489 489 q12 710 795 621 621 q13 3382383732513251 q14 280 288 286 286 q15 509 475 475 475 q16 637 677 621 621 q17 1139158713271327 q18 7719737572777277 q19 757 984 1066984 q20 1969200718821882 q21 5333498449004900 q22 609 545 523 523 Total cold run time: 51798 ms Total hot run time: 50057 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
koarz commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2675097383 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2674466341 TeamCity be ut coverage result: Function Coverage: 44.54% (11762/26410) Line Coverage: 34.02% (98328/289033) Region Coverage: 33.10% (50361/152158) Branch Coverage: 28.75% (25323/88092) Coverage Report: http://coverage.selectdb-in.cc/coverage/f34f8b817d7b6f055c19fc9c52e2f44cb442cdc0_f34f8b817d7b6f055c19fc9c52e2f44cb442cdc0/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2674431220 ClickBench: Total hot run time: 30.84 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit f34f8b817d7b6f055c19fc9c52e2f44cb442cdc0, data reload: false query1 0.040.030.04 query2 0.070.030.04 query3 0.230.070.07 query4 1.630.100.10 query5 0.400.420.39 query6 1.160.650.66 query7 0.030.020.02 query8 0.050.030.03 query9 0.590.510.53 query10 0.570.570.57 query11 0.150.100.10 query12 0.140.110.10 query13 0.610.590.61 query14 2.722.712.73 query15 0.920.830.83 query16 0.370.380.38 query17 1.031.021.02 query18 0.200.200.19 query19 1.871.751.88 query20 0.010.020.01 query21 15.35 0.890.53 query22 0.751.170.73 query23 14.87 1.370.61 query24 6.501.421.85 query25 0.510.160.11 query26 0.600.160.13 query27 0.050.050.04 query28 9.940.910.42 query29 12.53 3.903.23 query30 0.250.090.06 query31 2.820.590.38 query32 3.230.540.46 query33 2.962.982.96 query34 15.76 5.064.42 query35 4.504.464.54 query36 0.670.490.48 query37 0.090.060.06 query38 0.060.040.04 query39 0.030.020.03 query40 0.170.140.13 query41 0.080.020.03 query42 0.040.030.02 query43 0.040.030.03 Total cold run time: 104.59 s Total hot run time: 30.84 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2674420776 TPC-DS: Total hot run time: 183551 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit f34f8b817d7b6f055c19fc9c52e2f44cb442cdc0, data reload: false query1 967 382 377 377 query2 6539187018251825 query3 6793207 205 205 query4 25901 23534 23134 23134 query5 4386665 517 517 query6 323 200 184 184 query7 4613494 291 291 query8 297 248 246 246 query9 8622255025532550 query10 479 312 256 256 query11 15447 15131 14994 14994 query12 157 110 104 104 query13 1662515 404 404 query14 9301661966246619 query15 209 190 178 178 query16 7726608 450 450 query17 1195695 524 524 query18 1981386 294 294 query19 186 178 186 178 query20 122 111 113 111 query21 205 120 101 101 query22 4280418343614183 query23 34423 33519 33054 33054 query24 7662238023502350 query25 515 445 387 387 query26 1214280 151 151 query27 2092503 329 329 query28 3877239823822382 query29 707 532 414 414 query30 231 181 152 152 query31 910 850 776 776 query32 72 60 61 60 query33 542 363 298 298 query34 767 866 519 519 query35 788 829 726 726 query36 958 995 890 890 query37 122 97 79 79 query38 4273408241284082 query39 1413148913891389 query40 206 113 101 101 query41 78 51 49 49 query42 123 108 100 100 query43 486 492 483 483 query44 1320764 774 764 query45 177 166 160 160 query46 854 1100641 641 query47 1771179817261726 query48 394 421 310 310 query49 788 495 424 424 query50 697 737 418 418 query51 4221414441464144 query52 108 103 94 94 query53 232 261 187 187 query54 494 487 405 405 query55 80 81 80 80 query56 267 284 248 248 query57 1146110510801080 query58 247 233 233 233 query59 2673285626342634 query60 290 278 248 248 query61 117 113 114 113 query62 787 729 686 686 query63 228 187 185 185 query64 42941016713 713 query65 3211315030893089 query66 1083393 296 296 query67 15568 15546 15333 15333 query68 4423798 541 541 query69 483 300 265 265 query70 1179112010281028 query71 409 285 281 281 query72 5726354637943546 query73 695 739 356 356 query74 9028907188858885 query75 3139318927092709 query76 31961159740 740 query77 476 373 290 290 query78 9962993793039303 query79 2041824 595 595 query80 1133545 458 458 query81 532 278 242 242 query82 399 126 91 91 query83 162 170 150 150 query84 245 95 72 72 query85 754 343 305 305 query86 411 287 287 287 query87 4449458543174317 query88 3079220721892189 query89 399 324 279 279 query90 1795187 196 187 query91 138 143 110 110 query92 65 58 53 53 query93 14681010569 569 query94 697 411 299 299 query95 358 268 261 261 query96 503 534 280 280 query97 2758284726942694 query98 225 207 205 205 query99 1287139712571257 Total cold run time: 265511 ms Total hot run time: 183551 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [Feature](literal)Support TimeV2Literal [doris]
doris-robot commented on PR #47319: URL: https://github.com/apache/doris/pull/47319#issuecomment-2674396433 TPC-H: Total hot run time: 31306 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit f34f8b817d7b6f055c19fc9c52e2f44cb442cdc0, data reload: false -- Round 1 -- q1 17610 538951015101 q2 2052297 169 169 q3 10469 1503739 739 q4 10225 1020533 533 q5 7562254522482248 q6 192 169 139 139 q7 938 766 602 602 q8 9293136211191119 q9 4856472745414541 q10 6830230818741874 q11 473 280 252 252 q12 354 349 215 215 q13 1 368430463046 q14 245 224 203 203 q15 520 454 460 454 q16 619 610 577 577 q17 584 881 359 359 q18 6967615362036153 q19 1537964 537 537 q20 313 321 197 197 q21 2825210719361936 q22 376 322 312 312 Total cold run time: 102617 ms Total hot run time: 31306 ms - Round 2, with runtime_filter_mode=off - q1 5125508650745074 q2 239 340 236 236 q3 2173268722442244 q4 1426184513991399 q5 4205411041644110 q6 217 163 127 127 q7 1846181716971697 q8 2614261825132513 q9 7295707671627076 q10 2994319027522752 q11 586 501 513 501 q12 658 753 575 575 q13 3520391032323232 q14 278 290 277 277 q15 509 465 443 443 q16 653 672 631 631 q17 1116158813181318 q18 7629723572037203 q19 784 844 1029844 q20 2009199919061906 q21 5236492248694869 q22 609 625 558 558 Total cold run time: 51721 ms Total hot run time: 49585 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
