Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
BiteThet merged PR #49429: URL: https://github.com/apache/doris/pull/49429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
doris-robot commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2813905132 # BE UT Coverage Report Increment line coverage `76.19% (48/63)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/541ef2b2b4d8c32c4e16ee95f89bf7858a888d73_541ef2b2b4d8c32c4e16ee95f89bf7858a888d73/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/541ef2b2b4d8c32c4e16ee95f89bf7858a888d73_541ef2b2b4d8c32c4e16ee95f89bf7858a888d73/report/index.html) | Category | Coverage | |---|| | Function Coverage | 53.15% (14423/27134) | | Line Coverage | 42.02% (124992/297448) | | Region Coverage | 40.83% (63853/156375) | | Branch Coverage | 35.48% (32120/90526) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
github-actions[bot] commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2814684241 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
doris-robot commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2814487808 ClickBench: Total hot run time: 29.62 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 541ef2b2b4d8c32c4e16ee95f89bf7858a888d73, data reload: false query1 0.040.040.03 query2 0.120.100.13 query3 0.250.200.20 query4 1.590.200.11 query5 0.550.550.56 query6 1.190.720.71 query7 0.020.020.01 query8 0.040.030.03 query9 0.590.510.51 query10 0.570.570.58 query11 0.150.110.11 query12 0.140.110.11 query13 0.610.600.59 query14 1.141.211.16 query15 0.880.870.86 query16 0.380.380.40 query17 1.031.051.07 query18 0.210.200.20 query19 1.881.791.89 query20 0.020.020.02 query21 15.37 0.920.54 query22 0.771.110.67 query23 15.00 1.380.63 query24 7.171.050.84 query25 0.520.240.09 query26 0.570.180.13 query27 0.050.050.06 query28 9.480.930.46 query29 12.53 4.063.35 query30 0.250.090.06 query31 2.830.600.39 query32 3.220.550.48 query33 3.093.073.10 query34 16.17 5.074.48 query35 4.534.484.51 query36 0.660.520.48 query37 0.090.070.06 query38 0.060.040.04 query39 0.020.020.02 query40 0.160.130.13 query41 0.080.030.03 query42 0.040.020.03 query43 0.030.030.03 Total cold run time: 104.09 s Total hot run time: 29.62 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
doris-robot commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2814480654 TPC-DS: Total hot run time: 193918 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 541ef2b2b4d8c32c4e16ee95f89bf7858a888d73, data reload: false query1 1382108910641064 query2 6086187218721872 query3 11016 441045024410 query4 5 25961 23450 23450 query5 4898504 455 455 query6 323 210 195 195 query7 4917483 295 295 query8 331 253 242 242 query9 6023259726112597 query10 431 328 268 268 query11 15085 15026 15204 15026 query12 162 112 107 107 query13 1072513 423 423 query14 10243 655764566456 query15 205 206 190 190 query16 7134687 476 476 query17 1105781 597 597 query18 1635441 327 327 query19 204 203 173 173 query20 130 124 131 124 query21 213 130 108 108 query22 4312440244224402 query23 34338 33649 33643 33643 query24 6607247224942472 query25 468 488 386 386 query26 696 282 155 155 query27 2228517 338 338 query28 3078217021632163 query29 587 555 459 459 query30 268 237 189 189 query31 873 864 775 775 query32 78 71 71 71 query33 438 356 318 318 query34 782 861 541 541 query35 815 826 800 800 query36 951 1022885 885 query37 117 103 76 76 query38 4234426041614161 query39 1562142814221422 query40 210 119 110 110 query41 53 54 49 49 query42 128 109 108 108 query43 509 521 484 484 query44 1374837 828 828 query45 188 185 166 166 query46 878 1031652 652 query47 1932187217811781 query48 384 419 312 312 query49 730 487 441 441 query50 684 712 410 410 query51 4256433041984198 query52 106 109 98 98 query53 232 262 181 181 query54 608 600 537 537 query55 81 82 85 82 query56 303 316 296 296 query57 1160122511351135 query58 270 269 271 269 query59 2695273926902690 query60 345 343 311 311 query61 131 132 129 129 query62 783 779 682 682 query63 225 193 195 193 query64 18551074679 679 query65 4447426142244224 query66 712 400 304 304 query67 15844 15937 15421 15421 query68 7392890 524 524 query69 541 311 271 271 query70 1241117411271127 query71 507 328 287 287 query72 5736484349724843 query73 1434711 344 344 query74 9323894489398939 query75 3797319227282728 query76 42981196771 771 query77 630 395 288 288 query78 10132 10160 93099309 query79 812 589 589 query80 620 505 435 435 query81 491 260 222 222 query82 459 127 96 96 query83 372 247 230 230 query84 299 103 95 95 query85 784 370 304 304 query86 383 311 282 282 query87 439743264326 query88 3696225022302230 query89 406 319 335 319 query90 1817220 211 211 query91 140 139 113 113 query92 76 61 64 61 query93 1874964 583 583 query94 666 388 300 300 query95 367 300 299 299 query96 492 566 277 277 query97 3174324331453145 query98 235 207 200 200 query99 1447139512891289 Total cold run time: 301153 ms Total hot run time: 193918 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
doris-robot commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2814467852 TPC-H: Total hot run time: 34844 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 541ef2b2b4d8c32c4e16ee95f89bf7858a888d73, data reload: false -- Round 1 -- q1 26155 564650725072 q2 2094287 200 200 q3 10368 1247704 704 q4 10227 998 554 554 q5 7539225923892259 q6 184 164 134 134 q7 910 763 614 614 q8 9333131211241124 q9 6844509250685068 q10 6811233618691869 q11 484 291 278 278 q12 362 369 236 236 q13 17774 376030963096 q14 229 241 202 202 q15 531 487 477 477 q16 462 449 402 402 q17 599 877 368 368 q18 7711721371037103 q19 1548978 552 552 q20 345 333 221 221 q21 4575340533433343 q22 10401017968 968 Total cold run time: 116125 ms Total hot run time: 34844 ms - Round 2, with runtime_filter_mode=off - q1 5161508451015084 q2 241 321 230 230 q3 2186269422582258 q4 1411189714791479 q5 4482443844034403 q6 223 170 128 128 q7 2005192817631763 q8 2623258725312531 q9 7342704871937048 q10 2991319427822782 q11 592 508 500 500 q12 730 775 628 628 q13 3548396233523352 q14 286 305 280 280 q15 534 485 471 471 q16 467 537 468 468 q17 1176153914361436 q18 7785770774427442 q19 821 870 947 870 q20 1934195818601860 q21 5208482848644828 q22 1090107610031003 Total cold run time: 52836 ms Total hot run time: 50844 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
zclllyybb commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2813513888 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
hello-stephen commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2809240941 # BE UT Coverage Report Increment line coverage `76.92% (50/65)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/d4acfd814f4374a769b18daa88dccf7bd72e5980_d4acfd814f4374a769b18daa88dccf7bd72e5980/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/d4acfd814f4374a769b18daa88dccf7bd72e5980_d4acfd814f4374a769b18daa88dccf7bd72e5980/report/index.html) | Category | Coverage | |---|| | Function Coverage | 52.84% (14225/26923) | | Line Coverage | 41.72% (123460/295891) | | Region Coverage | 40.46% (62888/155415) | | Branch Coverage | 35.09% (31543/89888) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
doris-robot commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2808996987 ClickBench: Total hot run time: 30.27 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit d4acfd814f4374a769b18daa88dccf7bd72e5980, data reload: false query1 0.040.040.03 query2 0.120.100.10 query3 0.250.200.20 query4 1.590.190.19 query5 0.620.570.60 query6 1.190.710.71 query7 0.030.020.01 query8 0.040.030.03 query9 0.590.540.50 query10 0.560.560.56 query11 0.150.100.11 query12 0.150.110.11 query13 0.620.590.60 query14 1.171.171.17 query15 0.880.850.85 query16 0.380.390.38 query17 1.031.041.03 query18 0.200.190.19 query19 1.861.781.75 query20 0.020.010.01 query21 15.40 0.880.54 query22 0.761.160.92 query23 14.69 1.360.62 query24 7.341.491.12 query25 0.470.190.13 query26 0.670.160.14 query27 0.050.050.04 query28 9.400.890.45 query29 12.52 4.203.46 query30 0.260.100.06 query31 2.800.590.38 query32 3.230.550.46 query33 3.033.083.08 query34 15.81 5.154.49 query35 4.524.554.51 query36 0.660.490.48 query37 0.090.060.06 query38 0.050.040.04 query39 0.030.020.03 query40 0.160.140.12 query41 0.080.020.02 query42 0.030.020.02 query43 0.030.030.03 Total cold run time: 103.57 s Total hot run time: 30.27 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
doris-robot commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2808983970 TPC-DS: Total hot run time: 185430 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit d4acfd814f4374a769b18daa88dccf7bd72e5980, data reload: false query1 1023473 517 473 query2 6556176317831763 query3 6764219 215 215 query4 26563 23559 23641 23559 query5 4382645 456 456 query6 306 211 190 190 query7 4628508 296 296 query8 308 255 237 237 query9 8622258825902588 query10 452 340 257 257 query11 15214 15168 14843 14843 query12 165 108 108 108 query13 1644525 387 387 query14 8630615860186018 query15 200 194 171 171 query16 7133636 497 497 query17 1213712 565 565 query18 1966393 293 293 query19 187 182 149 149 query20 122 126 115 115 query21 211 116 107 107 query22 3992426139663966 query23 33777 33038 32772 32772 query24 8576237823982378 query25 551 461 413 413 query26 1249266 150 150 query27 2755508 333 333 query28 4367210920922092 query29 747 551 429 429 query30 284 211 191 191 query31 931 875 764 764 query32 74 65 63 63 query33 560 361 310 310 query34 795 832 517 517 query35 780 804 745 745 query36 937 979 887 887 query37 131 104 78 78 query38 4160418440814081 query39 1480139215541392 query40 210 123 111 111 query41 61 59 61 59 query42 122 111 104 104 query43 493 496 462 462 query44 1315806 789 789 query45 184 178 173 173 query46 836 1011627 627 query47 1731177917191719 query48 378 420 303 303 query49 804 514 450 450 query50 668 686 392 392 query51 4183419441184118 query52 112 104 106 104 query53 239 255 192 192 query54 600 601 510 510 query55 82 84 92 84 query56 311 317 299 299 query57 1140116010721072 query58 289 253 270 253 query59 2570260524822482 query60 333 322 308 308 query61 135 129 128 128 query62 834 714 651 651 query63 217 181 181 181 query64 43531022662 662 query65 4355422742594227 query66 1139426 310 310 query67 15568 15435 15164 15164 query68 8857892 526 526 query69 470 320 264 264 query70 1241112710801080 query71 474 328 289 289 query72 5615478648814786 query73 728 654 350 350 query74 8881887588158815 query75 4135326527112711 query76 36241183752 752 query77 794 384 296 296 query78 999710076 91899189 query79 2359821 569 569 query80 646 507 519 507 query81 478 257 213 213 query82 447 135 98 98 query83 277 249 228 228 query84 293 106 85 85 query85 751 367 314 314 query86 327 313 291 291 query87 4372448644164416 query88 2719219821962196 query89 406 311 288 288 query90 2054207 210 207 query91 143 137 111 111 query92 77 64 55 55 query93 2043952 585 585 query94 672 410 302 302 query95 379 289 292 289 query96 485 603 273 273 query97 3140320930903090 query98 235 220 205 205 query99 1413137712681268 Total cold run time: 274229 ms Total hot run time: 185430 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
doris-robot commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2808954028 TPC-H: Total hot run time: 34275 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit d4acfd814f4374a769b18daa88dccf7bd72e5980, data reload: false -- Round 1 -- q1 26184 529951095109 q2 2114283 179 179 q3 10548 1249710 710 q4 10231 1041526 526 q5 7779241723892389 q6 188 169 136 136 q7 920 754 621 621 q8 9328133911201120 q9 6878514650705070 q10 6824231019031903 q11 465 302 263 263 q12 347 355 214 214 q13 17771 380231323132 q14 225 219 209 209 q15 538 480 484 480 q16 444 443 403 403 q17 614 903 368 368 q18 7470722472237223 q19 1272958 574 574 q20 345 340 221 221 q21 4251360224782478 q22 10361029947 947 Total cold run time: 115772 ms Total hot run time: 34275 ms - Round 2, with runtime_filter_mode=off - q1 5170511750975097 q2 241 337 228 228 q3 2178267823162316 q4 1480186314711471 q5 4523453443624362 q6 208 166 125 125 q7 1979189917661766 q8 2608267025452545 q9 7168712971487129 q10 3194315527252725 q11 579 513 490 490 q12 704 729 602 602 q13 3603396035323532 q14 275 302 261 261 q15 533 499 486 486 q16 451 511 465 465 q17 1167150013981398 q18 7785750973677367 q19 827 824 847 824 q20 2000201018161816 q21 5346491747874787 q22 10481027986 986 Total cold run time: 53067 ms Total hot run time: 50778 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
zclllyybb commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2808720449 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
doris-robot commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2803702694 ClickBench: Total hot run time: 31.72 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit a262de29ec52dd0ae13f0b96547efe861b6115fd, data reload: false query1 0.040.040.02 query2 0.120.110.10 query3 0.250.200.20 query4 1.590.190.19 query5 0.590.590.57 query6 1.190.730.73 query7 0.020.020.01 query8 0.050.040.03 query9 0.580.520.53 query10 0.580.570.58 query11 0.150.110.11 query12 0.150.120.12 query13 0.620.600.59 query14 2.682.802.71 query15 0.920.840.86 query16 0.380.380.37 query17 1.021.011.03 query18 0.220.190.19 query19 1.951.921.79 query20 0.010.020.01 query21 15.35 0.910.55 query22 0.761.270.62 query23 14.92 1.370.61 query24 6.921.681.45 query25 0.520.160.08 query26 0.570.150.14 query27 0.060.050.05 query28 9.460.770.44 query29 12.55 4.063.36 query30 0.250.090.07 query31 2.830.600.39 query32 3.240.560.47 query33 3.003.123.09 query34 15.88 5.114.44 query35 4.554.524.48 query36 0.670.500.48 query37 0.090.060.06 query38 0.050.040.04 query39 0.030.020.03 query40 0.160.140.13 query41 0.080.030.02 query42 0.040.020.02 query43 0.030.030.03 Total cold run time: 105.12 s Total hot run time: 31.72 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
github-actions[bot] commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2805177310 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
doris-robot commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2803827973 # BE UT Coverage Report Increment line coverage `76.19% (48/63)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/a262de29ec52dd0ae13f0b96547efe861b6115fd_a262de29ec52dd0ae13f0b96547efe861b6115fd/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/a262de29ec52dd0ae13f0b96547efe861b6115fd_a262de29ec52dd0ae13f0b96547efe861b6115fd/report/index.html) | Category | Coverage | |---|| | Function Coverage | 52.41% (14092/26887) | | Line Coverage | 41.34% (122135/295471) | | Region Coverage | 40.06% (62146/155136) | | Branch Coverage | 34.72% (31127/89650) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
doris-robot commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2803697049 TPC-DS: Total hot run time: 193784 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit a262de29ec52dd0ae13f0b96547efe861b6115fd, data reload: false query1 1431109310401040 query2 6262198419491949 query3 10996 458545114511 query4 53861 25947 23419 23419 query5 5071505 476 476 query6 339 201 198 198 query7 4928519 289 289 query8 313 247 241 241 query9 5591260826172608 query10 391 350 271 271 query11 14983 15010 14797 14797 query12 165 114 104 104 query13 1059509 398 398 query14 10191 636364356363 query15 196 190 176 176 query16 7076652 516 516 query17 1056701 558 558 query18 1581404 346 346 query19 192 207 163 163 query20 129 128 119 119 query21 211 122 103 103 query22 4426452344594459 query23 34285 33377 33426 33377 query24 6597243024462430 query25 452 488 450 450 query26 710 276 153 153 query27 2318531 325 325 query28 3289244424542444 query29 617 574 421 421 query30 278 222 187 187 query31 847 852 810 810 query32 77 61 62 61 query33 450 366 305 305 query34 802 864 534 534 query35 804 879 776 776 query36 970 1016916 916 query37 128 105 75 75 query38 4243426841424142 query39 1488144014731440 query40 215 114 107 107 query41 57 53 57 53 query42 134 110 110 110 query43 502 538 477 477 query44 1335845 841 841 query45 185 174 185 174 query46 843 1044649 649 query47 1856188317881788 query48 383 417 313 313 query49 716 492 426 426 query50 672 710 415 415 query51 4294429241834183 query52 107 105 103 103 query53 236 260 193 193 query54 581 580 516 516 query55 85 86 81 81 query56 326 306 299 299 query57 1148118811251125 query58 267 252 259 252 query59 2798293127042704 query60 349 345 324 324 query61 153 145 172 145 query62 743 737 671 671 query63 230 197 184 184 query64 18181053675 675 query65 4354425142564251 query66 737 397 315 315 query67 15875 15449 15389 15389 query68 6457824 510 510 query69 555 310 270 270 query70 1176110910941094 query71 443 317 290 290 query72 5780478849524788 query73 1019670 344 344 query74 9018914390289028 query75 3295317827132713 query76 38631193752 752 query77 574 370 287 287 query78 996910139 93349334 query79 1724831 569 569 query80 583 518 543 518 query81 504 251 236 236 query82 227 127 95 95 query83 273 251 240 240 query84 291 97 81 81 query85 745 351 312 312 query86 360 314 280 280 query87 4445439943774377 query88 3700227122742271 query89 400 316 306 306 query90 1843216 270 216 query91 140 151 107 107 query92 74 61 54 54 query93 1727960 581 581 query94 659 410 277 277 query95 360 295 278 278 query96 501 567 278 278 query97 3136321331273127 query98 225 204 203 203 query99 1341137612551255 Total cold run time: 295209 ms Total hot run time: 193784 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
doris-robot commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2803681851 TPC-H: Total hot run time: 34508 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit a262de29ec52dd0ae13f0b96547efe861b6115fd, data reload: false -- Round 1 -- q1 26709 528850725072 q2 2071277 194 194 q3 10377 1266713 713 q4 10220 1056556 556 q5 7511240523432343 q6 187 164 137 137 q7 943 735 632 632 q8 9318128911161116 q9 6840519151785178 q10 6831230818861886 q11 483 282 267 267 q12 352 357 222 222 q13 17781 366331043104 q14 229 233 210 210 q15 555 503 493 493 q16 619 618 601 601 q17 596 877 365 365 q18 7615723572477235 q19 2490989 566 566 q20 325 327 221 221 q21 3931343524482448 q22 10271037949 949 Total cold run time: 117010 ms Total hot run time: 34508 ms - Round 2, with runtime_filter_mode=off - q1 5241507651145076 q2 245 339 229 229 q3 2171265022602260 q4 1420195214911491 q5 4477437544274375 q6 221 170 131 131 q7 1982190517631763 q8 2599269525842584 q9 7361711473197114 q10 3015315827422742 q11 598 502 488 488 q12 698 776 612 612 q13 3507390433973397 q14 287 286 266 266 q15 539 502 473 473 q16 662 693 655 655 q17 1184157214171417 q18 7871768475397539 q19 797 801 784 784 q20 1936199218781878 q21 5357485948694859 q22 1090107810471047 Total cold run time: 53258 ms Total hot run time: 51180 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
zclllyybb commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2803517599 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
HappenLee commented on code in PR #49429:
URL: https://github.com/apache/doris/pull/49429#discussion_r2018150393
##
be/src/vec/runtime/vdatetime_value.h:
##
@@ -1533,16 +1533,34 @@ int64_t datetime_diff(const DateV2Value& ts_value1,
const DateV2Value& t
}
case HOUR: {
int64_t second = ts_value2.second_diff(ts_value1);
+int32_t ms_diff = ts_value2.microsecond() - ts_value1.microsecond();
Review Comment:
consider be a function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
github-actions[bot] commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2760332889 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
doris-robot commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2760330753 # BE UT Coverage Report Increment line coverage `71.43% (20/28)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/30bbabbdb52d4320073411c65be7e2dc2c8aac85_30bbabbdb52d4320073411c65be7e2dc2c8aac85/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/30bbabbdb52d4320073411c65be7e2dc2c8aac85_30bbabbdb52d4320073411c65be7e2dc2c8aac85/report/index.html) | Category | Coverage | |---|| | Function Coverage | 50.90% (13626/26769) | | Line Coverage | 40.27% (118272/293711) | | Region Coverage | 38.94% (60076/154276) | | Branch Coverage | 33.86% (30225/89268) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
github-actions[bot] commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2760332928 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
doris-robot commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2760121880 ClickBench: Total hot run time: 30.87 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 30bbabbdb52d4320073411c65be7e2dc2c8aac85, data reload: false query1 0.040.030.03 query2 0.120.110.11 query3 0.230.190.20 query4 1.590.200.20 query5 0.590.570.58 query6 1.170.720.72 query7 0.020.020.02 query8 0.050.030.03 query9 0.570.510.52 query10 0.630.580.57 query11 0.150.110.10 query12 0.140.110.12 query13 0.630.590.61 query14 2.652.682.74 query15 0.920.850.85 query16 0.400.380.40 query17 1.011.021.05 query18 0.210.200.20 query19 1.821.861.84 query20 0.020.010.01 query21 15.35 0.900.56 query22 0.761.230.64 query23 14.95 1.370.64 query24 7.330.730.60 query25 0.480.220.07 query26 0.620.160.13 query27 0.060.050.05 query28 9.040.900.45 query29 12.53 3.933.28 query30 0.240.090.06 query31 2.860.560.39 query32 3.230.540.47 query33 3.003.013.13 query34 15.81 5.124.50 query35 4.504.494.51 query36 0.650.500.48 query37 0.080.060.06 query38 0.050.040.03 query39 0.030.020.03 query40 0.160.130.13 query41 0.090.030.03 query42 0.040.020.02 query43 0.040.040.03 Total cold run time: 104.86 s Total hot run time: 30.87 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
doris-robot commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2760117022 TPC-DS: Total hot run time: 194831 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 30bbabbdb52d4320073411c65be7e2dc2c8aac85, data reload: false query1 1416110210661066 query2 6195200519661966 query3 11012 461046494610 query4 25756 23969 23515 23515 query5 4960686 502 502 query6 316 205 198 198 query7 3997508 274 274 query8 326 251 237 237 query9 8503257825532553 query10 510 320 280 280 query11 16065 15246 15161 15161 query12 163 115 112 112 query13 1715564 401 401 query14 10225 634564326345 query15 211 186 163 163 query16 7634673 475 475 query17 1282740 573 573 query18 2073424 315 315 query19 201 193 169 169 query20 121 118 115 115 query21 204 130 108 108 query22 4601443643944394 query23 34286 33997 33623 33623 query24 8278245924922459 query25 514 483 407 407 query26 723 269 145 145 query27 3159506 335 335 query28 4770247524402440 query29 662 581 461 461 query30 285 221 204 204 query31 913 917 823 823 query32 76 62 64 62 query33 523 379 329 329 query34 808 893 524 524 query35 805 870 772 772 query36 10181009921 921 query37 129 101 79 79 query38 4219429741554155 query39 1493149514771477 query40 216 120 103 103 query41 54 60 53 53 query42 126 107 110 107 query43 515 526 509 509 query44 1349850 833 833 query45 192 181 167 167 query46 887 1036665 665 query47 1798187417961796 query48 396 474 305 305 query49 727 525 458 458 query50 745 771 437 437 query51 4324431942214221 query52 121 111 102 102 query53 238 266 182 182 query54 513 524 463 463 query55 89 86 86 86 query56 285 272 282 272 query57 1182120111151115 query58 274 295 253 253 query59 2937290527622762 query60 290 291 272 272 query61 132 134 123 123 query62 754 753 671 671 query63 241 196 189 189 query64 30391096733 733 query65 4513435743634357 query66 796 396 294 294 query67 16072 15493 15369 15369 query68 8282891 514 514 query69 491 301 277 277 query70 1216111311181113 query71 401 311 275 275 query72 5609468948474689 query73 685 652 357 357 query74 8998937791399139 query75 3254325427462746 query76 30871193801 801 query77 499 389 287 287 query78 987110113 93509350 query79 2004827 575 575 query80 625 547 528 528 query81 469 263 223 223 query82 203 126 100 100 query83 182 173 164 164 query84 231 94 86 86 query85 755 360 302 302 query86 322 314 295 295 query87 4381460343814381 query88 3455225922452245 query89 392 321 281 281 query90 1993219 220 219 query91 138 138 105 105 query92 76 67 57 57 query93 11201053598 598 query94 702 408 303 303 query95 354 288 270 270 query96 497 570 276 276 query97 3190322431643164 query98 227 209 197 197 query99 1330142012691269 Total cold run time: 277991 ms Total hot run time: 194831 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
doris-robot commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2760106465 TPC-H: Total hot run time: 34371 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 30bbabbdb52d4320073411c65be7e2dc2c8aac85, data reload: false -- Round 1 -- q1 26202 515150845084 q2 2068289 166 166 q3 10387 1302720 720 q4 10234 1001527 527 q5 7535245823752375 q6 200 165 135 135 q7 934 748 610 610 q8 9336132611571157 q9 6874518652035186 q10 6836232519381938 q11 467 279 255 255 q12 366 370 224 224 q13 17793 378331113111 q14 230 223 222 222 q15 545 485 481 481 q16 618 618 573 573 q17 621 900 367 367 q18 7582713172677131 q19 1654981 583 583 q20 339 337 194 194 q21 3870338623952395 q22 10381015937 937 Total cold run time: 115729 ms Total hot run time: 34371 ms - Round 2, with runtime_filter_mode=off - q1 5278522852185218 q2 250 342 245 245 q3 2225270023062306 q4 1502191414481448 q5 4537447044064406 q6 221 172 127 127 q7 2024191917741774 q8 2650258425412541 q9 7339712772577127 q10 3026320127632763 q11 586 521 488 488 q12 722 745 597 597 q13 3529392333703370 q14 301 288 267 267 q15 530 474 479 474 q16 651 682 663 663 q17 1199158414401440 q18 7836752675157515 q19 913 897 1081897 q20 1970197018581858 q21 5310487647144714 q22 1113106210441044 Total cold run time: 53712 ms Total hot run time: 51282 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
zclllyybb commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2760004046 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
BiteThet commented on code in PR #49429:
URL: https://github.com/apache/doris/pull/49429#discussion_r2016439184
##
be/src/vec/functions/array/function_array_range.cpp:
##
@@ -135,8 +135,7 @@ struct RangeImplUtil {
auto dest_array_column_ptr =
ColumnArray::create(return_nested_type->create_column(),
ColumnArray::ColumnOffsets::create());
IColumn* dest_nested_column = &dest_array_column_ptr->get_data();
-ColumnNullable* dest_nested_nullable_col =
-reinterpret_cast(dest_nested_column);
+auto* dest_nested_nullable_col =
reinterpret_cast(dest_nested_column);
Review Comment:
better to use assert cast
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
doris-robot commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2755261291 ClickBench: Total hot run time: 31.91 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 948f899e555435bf7ab0ef5365b3d37bc6ff6c24, data reload: false query1 0.030.030.03 query2 0.120.110.10 query3 0.250.190.20 query4 1.590.190.19 query5 0.590.570.59 query6 1.180.720.71 query7 0.020.020.02 query8 0.050.030.03 query9 0.580.530.51 query10 0.560.590.56 query11 0.160.110.10 query12 0.140.110.11 query13 0.610.610.60 query14 2.792.732.81 query15 0.930.850.87 query16 0.380.380.37 query17 1.001.001.01 query18 0.220.190.20 query19 1.901.931.82 query20 0.020.010.02 query21 15.35 0.890.56 query22 0.751.070.68 query23 15.03 1.410.61 query24 6.831.751.46 query25 0.510.150.09 query26 0.590.160.13 query27 0.050.050.04 query28 10.53 0.820.42 query29 12.53 4.023.32 query30 0.250.100.06 query31 2.820.580.38 query32 3.230.550.47 query33 3.023.063.09 query34 15.78 5.124.56 query35 4.564.574.56 query36 0.660.500.48 query37 0.090.060.06 query38 0.060.050.04 query39 0.030.030.03 query40 0.170.130.14 query41 0.090.030.03 query42 0.030.020.03 query43 0.040.030.03 Total cold run time: 106.12 s Total hot run time: 31.91 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
doris-robot commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2755209221 TPC-DS: Total hot run time: 192889 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 948f899e555435bf7ab0ef5365b3d37bc6ff6c24, data reload: false query1 1402105910341034 query2 6182191819471918 query3 11152 468746954687 query4 25980 23659 22926 22926 query5 4307642 501 501 query6 315 205 193 193 query7 3984499 268 268 query8 301 250 249 249 query9 8478253425152515 query10 479 319 266 266 query11 15689 15094 14786 14786 query12 162 110 106 106 query13 1545528 391 391 query14 9180610960796079 query15 205 191 169 169 query16 7494650 492 492 query17 1172701 602 602 query18 2032423 331 331 query19 208 223 186 186 query20 134 128 118 118 query21 215 121 111 111 query22 4361464843344334 query23 34648 33600 33573 33573 query24 8036243224402432 query25 539 486 439 439 query26 735 278 148 148 query27 3110512 338 338 query28 4469243124642431 query29 601 583 489 489 query30 269 222 189 189 query31 890 870 788 788 query32 72 66 65 65 query33 538 369 317 317 query34 795 866 504 504 query35 795 842 745 745 query36 989 1014913 913 query37 121 104 80 80 query38 4139419841744174 query39 1590145414271427 query40 208 119 99 99 query41 52 55 50 50 query42 129 113 116 113 query43 511 496 481 481 query44 1325820 828 820 query45 180 178 170 170 query46 873 1024661 661 query47 1883194318061806 query48 384 420 313 313 query49 710 506 456 456 query50 714 743 417 417 query51 4310433343204320 query52 113 116 98 98 query53 222 249 175 175 query54 509 502 419 419 query55 81 89 81 81 query56 261 279 280 279 query57 1159119211261126 query58 269 255 240 240 query59 2750281728212817 query60 304 279 283 279 query61 141 135 131 131 query62 776 747 671 671 query63 223 180 182 180 query64 29661057692 692 query65 4492435943734359 query66 934 434 288 288 query67 16500 15615 15623 15615 query68 9554897 519 519 query69 490 293 261 261 query70 1237104811081048 query71 465 296 266 266 query72 5821476749084767 query73 707 650 357 357 query74 8969914787078707 query75 4388325927412741 query76 36521188747 747 query77 965 369 274 274 query78 10187 10370 93539353 query79 1564814 564 564 query80 672 523 440 440 query81 502 261 220 220 query82 444 129 96 96 query83 209 249 154 154 query84 286 90 73 73 query85 768 354 310 310 query86 350 319 279 279 query87 4419451142634263 query88 2934225022472247 query89 397 306 282 282 query90 1898213 210 210 query91 157 142 107 107 query92 76 59 55 55 query93 11851090583 583 query94 669 388 312 312 query95 361 272 287 272 query96 493 553 278 278 query97 3164324131723172 query98 216 210 202 202 query99 1464139612601260 Total cold run time: 278955 ms Total hot run time: 192889 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
doris-robot commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2755173246 TPC-H: Total hot run time: 34233 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 948f899e555435bf7ab0ef5365b3d37bc6ff6c24, data reload: false -- Round 1 -- q1 26248 506950345034 q2 2068292 166 166 q3 10403 1261686 686 q4 10213 1034571 571 q5 7566242423692369 q6 187 165 132 132 q7 922 768 613 613 q8 9325129611121112 q9 6892517552635175 q10 6884232218781878 q11 485 277 249 249 q12 353 354 224 224 q13 17771 386530963096 q14 236 230 205 205 q15 534 496 489 489 q16 641 603 575 575 q17 593 873 356 356 q18 7596739571577157 q19 2258997 569 569 q20 331 336 192 192 q21 3987261324292429 q22 10611042956 956 Total cold run time: 116554 ms Total hot run time: 34233 ms - Round 2, with runtime_filter_mode=off - q1 5271511151015101 q2 246 331 228 228 q3 2164265922992299 q4 1458183215261526 q5 4499445744314431 q6 220 177 130 130 q7 2030192717681768 q8 2641259625452545 q9 7434707972537079 q10 3044318627802780 q11 575 500 487 487 q12 684 767 613 613 q13 3563387933523352 q14 279 301 284 284 q15 522 468 468 468 q16 650 670 658 658 q17 1170154114251425 q18 7826758475147514 q19 842 882 1003882 q20 1919203418481848 q21 5313486747564756 q22 1145107310341034 Total cold run time: 53495 ms Total hot run time: 51208 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
zclllyybb commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2754871322 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
doris-robot commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2751723173 TPC-DS: Total hot run time: 193758 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit f1d779cfab39203c2d491ef697c37bb0319dbeab, data reload: false query1 1436106310281028 query2 6198196219501950 query3 11102 451945724519 query4 25999 23552 23200 23200 query5 4263672 476 476 query6 311 226 195 195 query7 3987490 278 278 query8 308 248 237 237 query9 8524256925662566 query10 476 309 268 268 query11 15551 15299 14843 14843 query12 165 115 107 107 query13 1572539 395 395 query14 9162630861736173 query15 211 183 170 170 query16 7626645 473 473 query17 1196766 618 618 query18 2074424 323 323 query19 201 193 163 163 query20 128 124 125 124 query21 207 123 108 108 query22 4665464543644364 query23 34317 33891 33719 33719 query24 8647241724512417 query25 528 474 390 390 query26 1258277 147 147 query27 2883495 328 328 query28 5014247624522452 query29 718 606 451 451 query30 301 222 186 186 query31 914 858 820 820 query32 74 62 62 62 query33 535 365 303 303 query34 796 877 546 546 query35 815 857 745 745 query36 963 1027918 918 query37 125 104 82 82 query38 4295423142434231 query39 1504145714781457 query40 213 116 100 100 query41 52 53 51 51 query42 125 107 107 107 query43 514 520 510 510 query44 1413846 811 811 query45 185 182 174 174 query46 882 1061652 652 query47 1876190018111811 query48 382 426 306 306 query49 760 528 415 415 query50 710 751 412 412 query51 4327432642654265 query52 105 104 100 100 query53 227 258 179 179 query54 506 516 419 419 query55 83 81 83 81 query56 286 278 271 271 query57 1143120811291129 query58 255 244 255 244 query59 2799293027842784 query60 292 288 259 259 query61 128 122 121 121 query62 775 757 691 691 query63 224 191 186 186 query64 43601031747 747 query65 4477435344074353 query66 1081407 306 306 query67 16213 15751 15622 15622 query68 8550892 500 500 query69 524 300 259 259 query70 1233110011261100 query71 456 310 259 259 query72 5379479648404796 query73 725 637 352 352 query74 8926924890049004 query75 3986323727362736 query76 37851202777 777 query77 789 379 282 282 query78 10040 10236 92919291 query79 2473805 572 572 query80 657 596 454 454 query81 474 256 218 218 query82 466 127 95 95 query83 208 185 160 160 query84 286 98 71 71 query85 781 345 307 307 query86 335 299 298 298 query87 4437446743524352 query88 3395227622042204 query89 400 312 287 287 query90 1920212 217 212 query91 146 146 110 110 query92 73 64 59 59 query93 16501055577 577 query94 666 421 300 300 query95 382 276 264 264 query96 481 556 276 276 query97 3215324831593159 query98 220 204 205 204 query99 1452142812851285 Total cold run time: 281952 ms Total hot run time: 193758 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
doris-robot commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2751739343 ClickBench: Total hot run time: 31.5 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit f1d779cfab39203c2d491ef697c37bb0319dbeab, data reload: false query1 0.040.040.03 query2 0.120.110.10 query3 0.240.190.19 query4 1.600.190.18 query5 0.610.590.60 query6 1.190.720.73 query7 0.020.020.01 query8 0.040.040.03 query9 0.580.510.51 query10 0.570.600.57 query11 0.160.110.11 query12 0.140.120.11 query13 0.600.620.60 query14 2.672.842.82 query15 0.920.850.87 query16 0.390.370.38 query17 1.061.031.03 query18 0.210.200.19 query19 1.942.001.81 query20 0.010.010.02 query21 15.36 0.930.57 query22 0.751.120.69 query23 15.01 1.390.69 query24 7.151.730.78 query25 0.470.200.21 query26 0.570.160.13 query27 0.050.050.05 query28 9.800.860.44 query29 12.53 3.923.29 query30 0.240.090.07 query31 2.820.590.40 query32 3.230.540.47 query33 3.003.053.06 query34 15.78 5.214.51 query35 4.594.574.53 query36 0.660.490.48 query37 0.080.060.06 query38 0.050.040.04 query39 0.030.030.02 query40 0.180.130.13 query41 0.080.030.02 query42 0.040.030.02 query43 0.030.030.03 Total cold run time: 105.61 s Total hot run time: 31.5 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
doris-robot commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2751684774 TPC-H: Total hot run time: 34442 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit f1d779cfab39203c2d491ef697c37bb0319dbeab, data reload: false -- Round 1 -- q1 26328 503750295029 q2 2064303 173 173 q3 10466 1287725 725 q4 10230 1010542 542 q5 7628243623982398 q6 195 167 134 134 q7 930 768 626 626 q8 9323133812651265 q9 6867512750925092 q10 6844231919051905 q11 483 284 263 263 q12 357 366 228 228 q13 17759 367131053105 q14 251 236 219 219 q15 532 483 482 482 q16 663 633 581 581 q17 582 873 343 343 q18 7769730971507150 q19 1520989 600 600 q20 333 345 192 192 q21 4255262624012401 q22 10521036989 989 Total cold run time: 116431 ms Total hot run time: 34442 ms - Round 2, with runtime_filter_mode=off - q1 5182511152135111 q2 248 337 227 227 q3 2223267923002300 q4 1443187014491449 q5 4533444644424442 q6 215 168 132 132 q7 2025197317761776 q8 2665261825682568 q9 7416715572667155 q10 3027322227732773 q11 588 508 509 508 q12 688 797 627 627 q13 3502392733753375 q14 297 291 269 269 q15 526 466 466 466 q16 641 687 659 659 q17 1201158514411441 q18 7929767774707470 q19 891 862 965 862 q20 1931197918271827 q21 5410501148224822 q22 1136109410511051 Total cold run time: 53717 ms Total hot run time: 51310 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
zclllyybb commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2751314257 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
zclllyybb commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2749817312 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
doris-robot commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2750132261 # BE UT Coverage Report Increment line coverage `64.00% (16/25)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/dff1ea89083e3ae6197c933ff9b79c17c78bea89_dff1ea89083e3ae6197c933ff9b79c17c78bea89/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/dff1ea89083e3ae6197c933ff9b79c17c78bea89_dff1ea89083e3ae6197c933ff9b79c17c78bea89/report/index.html) | Category | Coverage | |---|| | Function Coverage | 50.22% (13440/26760) | | Line Coverage | 39.67% (116423/293496) | | Region Coverage | 38.38% (59182/154189) | | Branch Coverage | 33.52% (29902/89206) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
doris-robot commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2749975965 TPC-DS: Total hot run time: 193291 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit dff1ea89083e3ae6197c933ff9b79c17c78bea89, data reload: false query1 1419105310541053 query2 6096191819171917 query3 11016 459745174517 query4 26002 23775 23029 23029 query5 4823660 490 490 query6 317 205 196 196 query7 3985490 276 276 query8 304 241 242 241 query9 8557258525512551 query10 500 304 256 256 query11 15471 15205 14741 14741 query12 166 110 106 106 query13 1540506 386 386 query14 9196614061886140 query15 202 187 189 187 query16 7584630 450 450 query17 1162742 581 581 query18 2041408 316 316 query19 187 183 161 161 query20 125 122 120 120 query21 204 129 117 117 query22 4322462745174517 query23 34385 33496 33478 33478 query24 8440244924092409 query25 532 485 415 415 query26 723 272 149 149 query27 2885499 325 325 query28 4820246624822466 query29 629 592 435 435 query30 277 219 194 194 query31 919 883 808 808 query32 75 72 62 62 query33 536 374 310 310 query34 836 869 502 502 query35 821 863 752 752 query36 970 1024916 916 query37 123 103 81 81 query38 4245417540474047 query39 1480147114561456 query40 204 120 131 120 query41 57 54 52 52 query42 121 103 109 103 query43 496 524 476 476 query44 1320827 815 815 query45 183 173 168 168 query46 854 1062651 651 query47 1837187517961796 query48 389 411 308 308 query49 711 531 427 427 query50 702 760 426 426 query51 4334430742794279 query52 107 105 95 95 query53 235 257 187 187 query54 494 516 436 436 query55 85 85 84 84 query56 281 265 274 265 query57 1195118311291129 query58 259 259 259 259 query59 2864285328072807 query60 309 273 268 268 query61 130 137 123 123 query62 768 728 669 669 query63 227 185 190 185 query64 29281016674 674 query65 4616448645274486 query66 774 396 304 304 query67 16725 15728 15612 15612 query68 8443879 501 501 query69 491 294 259 259 query70 1229115010721072 query71 462 290 261 261 query72 5228496549104910 query73 685 544 348 348 query74 9012887089178870 query75 3944326427312731 query76 36651187746 746 query77 794 365 286 286 query78 979610052 93009300 query79 2929792 561 561 query80 631 532 462 462 query81 466 264 224 224 query82 286 126 103 103 query83 185 179 173 173 query84 294 96 80 80 query85 923 439 308 308 query86 325 315 283 283 query87 4477442443834383 query88 2821226422322232 query89 412 311 284 284 query90 2145209 210 209 query91 140 152 109 109 query92 70 56 54 54 query93 19371025579 579 query94 679 406 305 305 query95 357 274 263 263 query96 495 565 274 274 query97 3243341332933293 query98 220 216 200 200 query99 1391138912711271 Total cold run time: 279295 ms Total hot run time: 193291 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
doris-robot commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2749982359 ClickBench: Total hot run time: 30.67 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit dff1ea89083e3ae6197c933ff9b79c17c78bea89, data reload: false query1 0.040.040.03 query2 0.120.100.11 query3 0.240.200.19 query4 1.600.180.20 query5 0.590.590.58 query6 1.190.720.71 query7 0.020.020.01 query8 0.040.040.03 query9 0.590.520.54 query10 0.560.590.55 query11 0.150.110.11 query12 0.150.110.12 query13 0.610.610.61 query14 2.692.832.78 query15 0.920.860.84 query16 0.380.380.38 query17 1.041.021.04 query18 0.210.190.19 query19 1.951.961.80 query20 0.010.020.01 query21 15.36 0.880.54 query22 0.761.150.70 query23 14.89 1.350.58 query24 7.980.710.32 query25 0.500.170.09 query26 0.630.170.14 query27 0.050.040.05 query28 9.060.900.44 query29 12.56 4.033.36 query30 0.250.090.07 query31 2.820.570.40 query32 3.230.550.46 query33 3.083.063.06 query34 15.77 5.054.44 query35 4.514.524.47 query36 0.650.490.49 query37 0.090.070.06 query38 0.050.040.04 query39 0.030.030.02 query40 0.180.130.13 query41 0.080.030.02 query42 0.040.030.02 query43 0.030.030.03 Total cold run time: 105.7 s Total hot run time: 30.67 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
doris-robot commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2749956641 TPC-H: Total hot run time: 34530 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit dff1ea89083e3ae6197c933ff9b79c17c78bea89, data reload: false -- Round 1 -- q1 26378 508050495049 q2 2062288 161 161 q3 10427 1275697 697 q4 10232 1046562 562 q5 7553242723552355 q6 191 164 135 135 q7 909 751 626 626 q8 9351134711661166 q9 6827513951445139 q10 6866230118911891 q11 497 277 253 253 q12 351 351 215 215 q13 17772 368931113111 q14 250 234 220 220 q15 534 489 494 489 q16 628 609 574 574 q17 615 864 346 346 q18 7821723472397234 q19 1709967 574 574 q20 316 321 199 199 q21 4230274825752575 q22 10691003959 959 Total cold run time: 116588 ms Total hot run time: 34530 ms - Round 2, with runtime_filter_mode=off - q1 5229512151395121 q2 234 326 226 226 q3 2168265523112311 q4 1411184514691469 q5 4509440044134400 q6 215 170 131 131 q7 2004193317911791 q8 2703261924882488 q9 7290719172007191 q10 3000319327542754 q11 580 505 480 480 q12 716 730 619 619 q13 3503393433443344 q14 305 309 261 261 q15 549 491 484 484 q16 653 678 669 669 q17 1173158114281428 q18 7757765974217421 q19 849 842 991 842 q20 1958196818621862 q21 5387504449014901 q22 1107105810011001 Total cold run time: 53300 ms Total hot run time: 51194 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix](function) fix wrong floor of function date_diff when unit less than day [doris]
hello-stephen commented on PR #49429: URL: https://github.com/apache/doris/pull/49429#issuecomment-2749773792 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
