Re: [PR] [Fix]fix compile warning [doris]
yiguolei merged PR #53445: URL: https://github.com/apache/doris/pull/53445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix]fix compile warning [doris]
github-actions[bot] commented on PR #53445: URL: https://github.com/apache/doris/pull/53445#issuecomment-3086146682 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix]fix compile warning [doris]
github-actions[bot] commented on PR #53445: URL: https://github.com/apache/doris/pull/53445#issuecomment-3086146258 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix]fix compile warning [doris]
hello-stephen commented on PR #53445: URL: https://github.com/apache/doris/pull/53445#issuecomment-3084071557 # BE Regression && UT Coverage Report Increment line coverage `80.95% (17/21)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/53445_7a9aa6421bb38697553ec9755c771e934ca37834_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/53445_7a9aa6421bb38697553ec9755c771e934ca37834_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 81.20% (21880/26946) | | Line Coverage | 73.74% (226211/306774) | | Region Coverage | 61.52% (188901/307075) | | Branch Coverage | 65.16% (81349/124843) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix]fix compile warning [doris]
doris-robot commented on PR #53445: URL: https://github.com/apache/doris/pull/53445#issuecomment-3084059308 # BE UT Coverage Report Increment line coverage `50.00% (10/20)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/7a9aa6421bb38697553ec9755c771e934ca37834_7a9aa6421bb38697553ec9755c771e934ca37834/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/7a9aa6421bb38697553ec9755c771e934ca37834_7a9aa6421bb38697553ec9755c771e934ca37834/report/index.html) | Category | Coverage | |---|| | Function Coverage | 57.41% (15768/27466) | | Line Coverage | 46.18% (141890/307244) | | Region Coverage | 35.68% (106815/299344) | | Branch Coverage | 38.18% (47138/123453) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix]fix compile warning [doris]
doris-robot commented on PR #53445: URL: https://github.com/apache/doris/pull/53445#issuecomment-3083492811 ClickBench: Total hot run time: 32.34 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 7a9aa6421bb38697553ec9755c771e934ca37834, data reload: false query1 0.040.040.03 query2 0.080.040.04 query3 0.240.070.08 query4 1.620.110.11 query5 0.440.420.41 query6 1.180.660.69 query7 0.030.020.02 query8 0.050.040.04 query9 0.600.550.52 query10 0.580.580.59 query11 0.150.110.11 query12 0.150.110.12 query13 0.620.610.60 query14 0.790.830.81 query15 0.910.860.88 query16 0.390.380.40 query17 1.101.061.06 query18 0.240.210.21 query19 2.021.811.84 query20 0.020.020.01 query21 15.38 0.910.55 query22 0.781.230.62 query23 14.93 1.400.62 query24 6.941.720.52 query25 0.490.120.13 query26 0.510.170.15 query27 0.060.060.06 query28 10.03 0.890.45 query29 12.54 3.973.34 query30 3.093.012.90 query31 2.820.590.39 query32 3.250.550.49 query33 3.033.243.19 query34 16.02 5.434.80 query35 4.874.874.87 query36 0.710.510.50 query37 0.100.070.07 query38 0.050.050.03 query39 0.030.030.02 query40 0.170.140.14 query41 0.080.020.02 query42 0.040.020.02 query43 0.040.030.04 Total cold run time: 107.21 s Total hot run time: 32.34 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix]fix compile warning [doris]
doris-robot commented on PR #53445: URL: https://github.com/apache/doris/pull/53445#issuecomment-3083476306 TPC-DS: Total hot run time: 187561 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 7a9aa6421bb38697553ec9755c771e934ca37834, data reload: false query1 980 394 412 394 query2 6532166016651660 query3 6734216 216 216 query4 26455 23777 22950 22950 query5 4706583 452 452 query6 325 203 200 200 query7 4619502 283 283 query8 260 222 214 214 query9 8654260126112601 query10 505 327 292 292 query11 15243 15368 14795 14795 query12 156 105 103 103 query13 1647536 404 404 query14 9510599258865886 query15 218 209 179 179 query16 7374650 445 445 query17 1185729 599 599 query18 2080419 307 307 query19 196 196 165 165 query20 119 119 113 113 query21 221 129 110 110 query22 4231435242254225 query23 34426 33465 33386 33386 query24 8478240424782404 query25 532 468 402 402 query26 1223272 145 145 query27 2751506 346 346 query28 4316212320972097 query29 726 559 428 428 query30 281 227 185 185 query31 986 857 766 766 query32 73 65 65 65 query33 579 373 308 308 query34 817 844 515 515 query35 779 844 731 731 query36 10131009917 917 query37 105 96 76 76 query38 4179420641014101 query39 1483142114291421 query40 218 115 105 105 query41 59 56 55 55 query42 123 107 109 107 query43 509 512 469 469 query44 1363828 817 817 query45 177 169 162 162 query46 853 1008637 637 query47 1777185817521752 query48 386 443 304 304 query49 759 454 409 409 query50 663 692 413 413 query51 5593551154195419 query52 116 105 99 99 query53 227 260 173 173 query54 578 570 513 513 query55 85 81 86 81 query56 298 306 301 301 query57 1203119711231123 query58 273 265 263 263 query59 2487267626322632 query60 353 332 335 332 query61 151 124 126 124 query62 797 713 663 663 query63 226 198 183 183 query64 42791012713 713 query65 4288424342134213 query66 1130428 316 316 query67 16099 15646 15475 15475 query68 7954942 523 523 query69 467 309 274 274 query70 1225116211461146 query71 448 325 303 303 query72 5760481348584813 query73 704 626 358 358 query74 9107924790469046 query75 3983327927962796 query76 37361156729 729 query77 810 407 278 278 query78 10162 10060 94899489 query79 4323816 573 573 query80 693 518 440 440 query81 473 260 221 221 query82 567 128 96 96 query83 283 257 239 239 query84 305 105 85 85 query85 798 357 319 319 query86 353 314 300 300 query87 4456454443494349 query88 3262229022602260 query89 444 316 305 305 query90 1961210 203 203 query91 136 141 112 112 query92 74 62 58 58 query93 3027938 565 565 query94 676 393 301 301 query95 374 295 285 285 query96 495 588 276 276 query97 2777274826282628 query98 232 210 200 200 query99 1434142712521252 Total cold run time: 281266 ms Total hot run time: 187561 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [Fix]fix compile warning [doris]
doris-robot commented on PR #53445: URL: https://github.com/apache/doris/pull/53445#issuecomment-3083437087 TPC-H: Total hot run time: 34415 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 7a9aa6421bb38697553ec9755c771e934ca37834, data reload: false -- Round 1 -- q1 17569 532651515151 q2 1949294 178 178 q3 10306 1347706 706 q4 10226 1034545 545 q5 7604244223642364 q6 178 161 129 129 q7 922 781 611 611 q8 9318144312011201 q9 6983515251315131 q10 6908240719511951 q11 492 297 275 275 q12 352 364 219 219 q13 17775 370531573157 q14 231 230 227 227 q15 547 486 483 483 q16 435 452 383 383 q17 599 878 354 354 q18 7966720371107110 q19 1222946 584 584 q20 351 355 229 229 q21 3955315824542454 q22 10331034973 973 Total cold run time: 106921 ms Total hot run time: 34415 ms - Round 2, with runtime_filter_mode=off - q1 5372524152425241 q2 259 322 219 219 q3 268922942294 q4 1418179413551355 q5 4407446546254465 q6 218 169 128 128 q7 2027200718131813 q8 2744253726482537 q9 7393736673027302 q10 3128339628722872 q11 571 520 510 510 q12 685 823 716 716 q13 3629400634023402 q14 309 297 290 290 q15 663 543 479 479 q16 435 486 437 437 q17 1206161213421342 q18 7874777076167616 q19 865 912 971 912 q20 1930199818111811 q21 4931431243584312 q22 10731023989 989 Total cold run time: 53359 ms Total hot run time: 51042 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix]fix compile warning [doris]
wangbo commented on PR #53445: URL: https://github.com/apache/doris/pull/53445#issuecomment-3083157666 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix]fix compile warning [doris]
doris-robot commented on PR #53445: URL: https://github.com/apache/doris/pull/53445#issuecomment-3083111466 ClickBench: Total hot run time: 33 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit a684469bc28c3e5372cafedd9d7e8d2d23703c0f, data reload: false query1 0.040.040.04 query2 0.080.040.04 query3 0.250.070.08 query4 1.610.100.11 query5 0.430.440.42 query6 1.160.670.68 query7 0.020.020.02 query8 0.040.030.04 query9 0.590.510.50 query10 0.570.560.56 query11 0.160.110.11 query12 0.150.120.12 query13 0.620.610.62 query14 0.810.820.85 query15 0.910.880.89 query16 0.410.380.43 query17 1.071.081.08 query18 0.230.220.21 query19 1.921.861.87 query20 0.020.010.01 query21 15.37 0.900.58 query22 0.761.250.61 query23 14.95 1.420.61 query24 6.771.551.30 query25 0.510.200.08 query26 0.580.170.14 query27 0.070.060.05 query28 9.610.900.44 query29 12.54 3.993.34 query30 3.013.002.96 query31 2.820.600.39 query32 3.260.560.47 query33 3.093.093.09 query34 16.04 5.434.74 query35 4.794.834.85 query36 0.680.500.49 query37 0.090.060.07 query38 0.060.040.04 query39 0.030.030.03 query40 0.180.140.14 query41 0.080.030.03 query42 0.030.020.02 query43 0.040.030.03 Total cold run time: 106.45 s Total hot run time: 33 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix]fix compile warning [doris]
doris-robot commented on PR #53445: URL: https://github.com/apache/doris/pull/53445#issuecomment-3083096380 TPC-DS: Total hot run time: 187378 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit a684469bc28c3e5372cafedd9d7e8d2d23703c0f, data reload: false query1 989 369 398 369 query2 6526173117081708 query3 6777215 214 214 query4 25844 23694 23400 23400 query5 4360625 443 443 query6 309 211 207 207 query7 4624501 301 301 query8 281 226 218 218 query9 8614259926292599 query10 492 340 294 294 query11 15578 15068 14848 14848 query12 156 109 101 101 query13 1656534 387 387 query14 9376580158365801 query15 215 206 171 171 query16 7406605 464 464 query17 1208711 600 600 query18 1996407 307 307 query19 202 190 168 168 query20 124 123 116 116 query21 220 124 106 106 query22 4058415840524052 query23 34184 33094 33228 33094 query24 8556240323902390 query25 519 467 401 401 query26 1227263 146 146 query27 2766499 362 362 query28 4296212820922092 query29 738 545 427 427 query30 282 215 192 192 query31 932 868 775 775 query32 81 63 59 59 query33 577 358 313 313 query34 778 830 527 527 query35 809 796 750 750 query36 957 987 893 893 query37 118 98 76 76 query38 4149422841344134 query39 1507142814361428 query40 211 120 107 107 query41 60 54 51 51 query42 114 104 109 104 query43 516 517 485 485 query44 1298821 810 810 query45 173 172 166 166 query46 843 1019630 630 query47 1789180217471747 query48 374 416 304 304 query49 733 473 377 377 query50 655 690 428 428 query51 5410563155015501 query52 113 108 96 96 query53 216 248 185 185 query54 564 578 509 509 query55 85 80 87 80 query56 295 297 278 278 query57 1201119811291129 query58 263 265 267 265 query59 2719276726212621 query60 350 322 308 308 query61 125 123 124 123 query62 778 710 643 643 query63 222 189 192 189 query64 42941010665 665 query65 4233415141764151 query66 1129428 310 310 query67 16028 15786 15682 15682 query68 8110884 520 520 query69 472 320 278 278 query70 1221117211491149 query71 481 331 300 300 query72 5758484248694842 query73 741 648 357 357 query74 8860884986998699 query75 3807321326922692 query76 37101218733 733 query77 787 393 300 300 query78 997510131 93759375 query79 3702796 557 557 query80 655 513 499 499 query81 492 265 217 217 query82 552 124 96 96 query83 285 251 235 235 query84 307 111 84 84 query85 801 349 317 317 query86 349 310 309 309 query87 4456455643964396 query88 2954230823162308 query89 436 310 298 298 query90 1945220 222 220 query91 149 141 109 109 query92 78 64 56 56 query93 2221928 572 572 query94 673 424 297 297 query95 375 294 293 293 query96 498 573 287 287 query97 2706280526392639 query98 225 205 205 205 query99 1470142412621262 Total cold run time: 277529 ms Total hot run time: 187378 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [Fix]fix compile warning [doris]
doris-robot commented on PR #53445: URL: https://github.com/apache/doris/pull/53445#issuecomment-3083053004 TPC-H: Total hot run time: 33945 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit a684469bc28c3e5372cafedd9d7e8d2d23703c0f, data reload: false -- Round 1 -- q1 17571 525050645064 q2 1931284 188 188 q3 10302 1277704 704 q4 10233 978 532 532 q5 7547233423412334 q6 178 169 131 131 q7 890 739 613 613 q8 9326128911061106 q9 6824510951205109 q10 6913236919491949 q11 514 297 275 275 q12 346 356 226 226 q13 17757 364931413141 q14 232 229 225 225 q15 548 487 480 480 q16 448 455 378 378 q17 603 867 380 380 q18 7444719469896989 q19 1217949 584 584 q20 343 328 223 223 q21 4032322724132413 q22 10521013901 901 Total cold run time: 106251 ms Total hot run time: 33945 ms - Round 2, with runtime_filter_mode=off - q1 5181517651635163 q2 243 321 220 220 q3 2185265122862286 q4 1350181513651365 q5 4219447645504476 q6 227 168 128 128 q7 2057192218221822 q8 2669265426032603 q9 7211733472727272 q10 3138334929352935 q11 559 518 507 507 q12 715 777 611 611 q13 3586446533763376 q14 294 321 288 288 q15 530 482 483 482 q16 478 518 466 466 q17 1165157314491449 q18 7907773175717571 q19 846 810 1015810 q20 2017197818201820 q21 4639434344574343 q22 1086962 1007962 Total cold run time: 52302 ms Total hot run time: 50955 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix]fix compile warning [doris]
yiguolei commented on code in PR #53445:
URL: https://github.com/apache/doris/pull/53445#discussion_r2212615826
##
be/src/runtime/workload_group/workload_group.cpp:
##
@@ -428,14 +430,14 @@ WorkloadGroupInfo WorkloadGroupInfo::parse_topic_info(
int read_bytes_per_second = -1;
if (tworkload_group_info.__isset.read_bytes_per_second &&
tworkload_group_info.read_bytes_per_second > 0) {
-read_bytes_per_second = tworkload_group_info.read_bytes_per_second;
+read_bytes_per_second =
(int)tworkload_group_info.read_bytes_per_second;
Review Comment:
这个值是int 应该不行。
当前的磁盘吞吐，是可以达到几个GB/S的，尤其是假如我们命中了page cache，所以我们得是int64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [Fix]fix compile warning [doris]
hello-stephen commented on PR #53445: URL: https://github.com/apache/doris/pull/53445#issuecomment-3082945081 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Fix]fix compile warning [doris]
wangbo commented on PR #53445: URL: https://github.com/apache/doris/pull/53445#issuecomment-3082945357 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
