Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
kaka11chen commented on PR #59453: URL: https://github.com/apache/doris/pull/59453#issuecomment-369177 run compile -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
doris-robot commented on PR #59453: URL: https://github.com/apache/doris/pull/59453#issuecomment-3696605081 # BE UT Coverage Report Increment line coverage `15.72% (36/229)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/7ac471982ffa40536cae0c784e1a848929be9d07_7ac471982ffa40536cae0c784e1a848929be9d07/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/7ac471982ffa40536cae0c784e1a848929be9d07_7ac471982ffa40536cae0c784e1a848929be9d07/report/index.html) | Category | Coverage | |---|| | Function Coverage | 53.35% (18670/34993) | | Line Coverage | 39.12% (172943/442085) | | Region Coverage | 33.80% (133683/395488) | | Branch Coverage | 34.78% (57796/166173) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
kaka11chen commented on PR #59453: URL: https://github.com/apache/doris/pull/59453#issuecomment-3696419147 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
kaka11chen commented on PR #59453: URL: https://github.com/apache/doris/pull/59453#issuecomment-3696356699 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
kaka11chen commented on PR #59453: URL: https://github.com/apache/doris/pull/59453#issuecomment-3696276386 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
kaka11chen commented on PR #59453: URL: https://github.com/apache/doris/pull/59453#issuecomment-3696245369 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
kaka11chen commented on PR #59453: URL: https://github.com/apache/doris/pull/59453#issuecomment-3696188707 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
kaka11chen commented on PR #59453: URL: https://github.com/apache/doris/pull/59453#issuecomment-3695962707 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
Thearas commented on PR #59453: URL: https://github.com/apache/doris/pull/59453#issuecomment-3695962439 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
morningman merged PR #58679: URL: https://github.com/apache/doris/pull/58679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
github-actions[bot] commented on PR #58679: URL: https://github.com/apache/doris/pull/58679#issuecomment-3627365480 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
github-actions[bot] commented on PR #58679: URL: https://github.com/apache/doris/pull/58679#issuecomment-3627365701 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
morningman commented on code in PR #58679:
URL: https://github.com/apache/doris/pull/58679#discussion_r2598968470
##
be/src/vec/exec/scan/file_scanner.cpp:
##
@@ -1123,6 +1135,10 @@ Status FileScanner::_get_next_reader() {
_cur_reader =
RemoteDorisReader::create_unique(_file_slot_descs,
_state, _profile, range);
init_status =
((RemoteDorisReader*)(_cur_reader.get()))->init_reader();
+if (_cur_reader) {
Review Comment:
ditto
##
be/src/vec/exec/scan/file_scanner.cpp:
##
@@ -1110,6 +1117,11 @@ Status FileScanner::_get_next_reader() {
_cur_reader = AvroJNIReader::create_unique(_state, _profile,
*_params, _file_slot_descs,
range);
init_status = ((AvroJNIReader*)(_cur_reader.get()))->init_reader();
+// Set col_name_to_block_idx for JNI readers to avoid repeated map
creation
+if (_cur_reader) {
Review Comment:
This `if (_cur_reader)` is unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
hello-stephen commented on PR #58679: URL: https://github.com/apache/doris/pull/58679#issuecomment-3611689431 # BE Regression && UT Coverage Report Increment line coverage `28.10% (59/210)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58679_73fc308da83ac6f3fbb18a8b6e9e88bd8400983c_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58679_73fc308da83ac6f3fbb18a8b6e9e88bd8400983c_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 72.14% (24709/34251) | | Line Coverage | 58.85% (259404/440769) | | Region Coverage | 53.88% (216161/401159) | | Branch Coverage | 55.35% (92290/166737) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
hello-stephen commented on PR #58679: URL: https://github.com/apache/doris/pull/58679#issuecomment-3611391466 # BE UT Coverage Report Increment line coverage `17.14% (36/210)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/73fc308da83ac6f3fbb18a8b6e9e88bd8400983c_73fc308da83ac6f3fbb18a8b6e9e88bd8400983c/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/73fc308da83ac6f3fbb18a8b6e9e88bd8400983c_73fc308da83ac6f3fbb18a8b6e9e88bd8400983c/report/index.html) | Category | Coverage | |---|| | Function Coverage | 53.35% (18633/34929) | | Line Coverage | 39.01% (172079/441148) | | Region Coverage | 33.63% (133281/396339) | | Branch Coverage | 34.58% (57350/165838) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
doris-robot commented on PR #58679: URL: https://github.com/apache/doris/pull/58679#issuecomment-3610922448 ClickBench: Total hot run time: 27.84 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 73fc308da83ac6f3fbb18a8b6e9e88bd8400983c, data reload: false query1 0.050.060.05 query2 0.110.050.04 query3 0.250.080.08 query4 1.610.120.11 query5 0.270.250.26 query6 1.150.630.62 query7 0.030.020.03 query8 0.060.040.04 query9 0.580.520.50 query10 0.570.540.54 query11 0.160.110.11 query12 0.150.110.11 query13 0.630.600.62 query14 0.990.990.98 query15 0.820.800.81 query16 0.400.420.39 query17 1.061.071.08 query18 0.230.220.22 query19 1.891.891.87 query20 0.010.020.01 query21 15.43 0.280.13 query22 4.770.050.05 query23 15.88 0.290.10 query24 1.320.580.59 query25 0.090.070.10 query26 0.140.130.13 query27 0.070.060.05 query28 4.971.211.03 query29 12.64 4.003.34 query30 0.280.130.14 query31 2.820.630.41 query32 3.230.560.46 query33 3.043.113.02 query34 16.83 5.224.52 query35 4.594.584.59 query36 0.660.490.50 query37 0.120.060.06 query38 0.080.040.04 query39 0.050.040.03 query40 0.160.140.12 query41 0.100.040.03 query42 0.050.030.03 query43 0.040.040.03 Total cold run time: 98.38 s Total hot run time: 27.84 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
doris-robot commented on PR #58679: URL: https://github.com/apache/doris/pull/58679#issuecomment-3610903545 TPC-DS: Total hot run time: 179889 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 73fc308da83ac6f3fbb18a8b6e9e88bd8400983c, data reload: false query5 4853616 480 480 query6 338 221 209 209 query7 4659496 298 298 query8 320 245 240 240 query9 8737262626432626 query10 558 320 286 286 query11 15328 14883 14811 14811 query12 177 125 122 122 query13 1697501 387 387 query14 6322331931353135 query14_12955292029872920 query15 216 205 183 183 query16 7682514 486 486 query17 1224733 616 616 query18 2064440 355 355 query19 217 205 170 170 query20 134 120 121 120 query21 225 136 119 119 query22 4004406138893889 query23 16646 16120 15906 15906 query23_116208 15934 16072 15934 query24 7233164412041204 query24_11210119712271197 query25 634 515 451 451 query26 1275285 187 187 query27 2872475 323 323 query28 4399218821832183 query29 830 584 475 475 query30 324 243 215 215 query31 829 720 629 629 query32 84 72 71 71 query33 673 364 330 330 query34 855 925 544 544 query35 794 811 732 732 query36 891 914 840 840 query37 118 96 78 78 query38 3872378737523752 query39 762 728 728 728 query39_1707 721 699 699 query40 237 131 133 131 query41 64 63 75 63 query42 123 99 104 99 query43 430 431 399 399 query44 1352766 759 759 query45 203 188 187 187 query46 892 978 579 579 query47 1688172916191619 query48 391 325 241 241 query49 764 436 365 365 query50 698 303 234 234 query51 3850393338663866 query52 108 95 85 85 query53 234 229 177 177 query54 342 256 237 237 query55 97 83 76 76 query56 325 289 285 285 query57 1190115510881088 query58 304 259 250 250 query59 2317233222552255 query60 354 328 332 328 query61 167 164 158 158 query62 795 686 613 613 query63 228 170 178 170 query64 44641177882 882 query65 4052393339863933 query66 1176449 336 336 query67 15131 14785 14655 14655 query68 8275933 681 681 query69 545 303 270 270 query70 11041004983 983 query71 443 286 278 278 query72 5978494250354942 query73 708 576 303 303 query74 8708893086478647 query75 3217302524602460 query76 35381153763 763 query77 729 412 305 305 query78 9466969088148814 query79 1841862 601 601 query80 703 562 466 466 query81 511 270 236 236 query82 228 127 104 104 query83 296 282 261 261 query84 266 123 97 97 query85 949 506 459 459 query86 382 308 282 282 query87 4034403839843984 query88 4348217621652165 query89 403 324 281 281 query90 2043171 168 168 query91 176 168 146 146 query92 79 72 61 61 query93 18921084684 684 query94 752 329 287 287 query95 566 340 338 338 query96 537 512 213 213 query97 2594266826002600 query98 256 211 197 197 query99 1383131012051205 Total cold run time: 271994 ms Total hot run time: 179889 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
doris-robot commented on PR #58679: URL: https://github.com/apache/doris/pull/58679#issuecomment-3610860072 TPC-H: Total hot run time: 35399 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 73fc308da83ac6f3fbb18a8b6e9e88bd8400983c, data reload: false -- Round 1 -- q1 17668 533350575057 q2 2044317 197 197 q3 10254 1444744 744 q4 10203 839 314 314 q5 7554269823572357 q6 212 197 142 142 q7 1029850 643 643 q8 9364151612131213 q9 7005558655255525 q10 6909221517921792 q11 546 337 281 281 q12 359 406 222 222 q13 17785 373230643064 q14 233 234 204 204 q15 602 519 508 508 q16 904 878 811 811 q17 678 840 610 610 q18 7994721572077207 q19 10861085630 630 q20 391 361 223 223 q21 4150388127082708 q22 10441032947 947 Total cold run time: 108014 ms Total hot run time: 35399 ms - Round 2, with runtime_filter_mode=off - q1 5229517751655165 q2 357 413 325 325 q3 2149273323182318 q4 1352181113201320 q5 4631455946104559 q6 265 194 135 135 q7 2093194018351835 q8 2982273227662732 q9 7603757775177517 q10 3189331328812881 q11 706 583 498 498 q12 703 780 589 589 q13 3528419432543254 q14 285 306 289 289 q15 591 533 505 505 q16 1033960 896 896 q17 1224159115381538 q18 7861768179337681 q19 960 873 939 873 q20 2006212019541954 q21 5003431941704170 q22 11291036984 984 Total cold run time: 54879 ms Total hot run time: 52018 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
kaka11chen commented on PR #58679: URL: https://github.com/apache/doris/pull/58679#issuecomment-3610732087 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
doris-robot commented on PR #58679: URL: https://github.com/apache/doris/pull/58679#issuecomment-3609613218 ClickBench: Total hot run time: 27.22 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 0488d41413c85e45223e3dee694cf5920d111f13, data reload: false query1 0.060.050.04 query2 0.150.050.05 query3 0.270.080.08 query4 1.610.120.10 query5 0.260.260.27 query6 1.180.650.63 query7 0.030.020.02 query8 0.050.040.04 query9 0.610.510.50 query10 0.570.560.54 query11 0.180.110.11 query12 0.160.120.12 query13 0.630.610.61 query14 1.000.981.00 query15 0.820.790.82 query16 0.410.380.38 query17 0.991.051.04 query18 0.230.210.21 query19 1.841.761.81 query20 0.020.010.01 query21 15.43 0.280.13 query22 4.940.050.05 query23 16.00 0.290.10 query24 2.910.260.23 query25 0.090.080.06 query26 0.160.140.13 query27 0.080.050.05 query28 4.141.221.01 query29 12.61 4.013.24 query30 0.280.130.11 query31 2.820.640.40 query32 3.230.550.47 query33 3.043.083.12 query34 16.87 5.114.55 query35 4.494.624.53 query36 0.650.500.48 query37 0.120.060.07 query38 0.070.050.04 query39 0.060.030.02 query40 0.160.140.13 query41 0.100.040.02 query42 0.050.030.03 query43 0.050.040.03 Total cold run time: 99.42 s Total hot run time: 27.22 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
doris-robot commented on PR #58679: URL: https://github.com/apache/doris/pull/58679#issuecomment-3609602695 TPC-DS: Total hot run time: 181985 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 0488d41413c85e45223e3dee694cf5920d111f13, data reload: false query5 5190648 494 494 query6 347 254 250 250 query7 4697518 317 317 query8 305 271 253 253 query9 8714263426492634 query10 540 385 324 324 query11 15601 15309 14628 14628 query12 224 118 119 118 query13 1697586 473 473 query14 6699331030623062 query14_12962303729322932 query15 212 200 196 196 query16 7703693 526 526 query17 1234783 647 647 query18 2040438 354 354 query19 224 219 204 204 query20 129 135 123 123 query21 428 137 114 114 query22 4030401239313931 query23 16573 16189 16044 16044 query23_116240 15929 15948 15929 query24 6800167312091209 query24_11231122912591229 query25 650 559 498 498 query26 1284291 190 190 query27 2659502 353 353 query28 4306217121572157 query29 815 657 534 534 query30 327 245 219 219 query31 848 717 660 660 query32 91 79 76 76 query33 642 406 337 337 query34 868 893 587 587 query35 811 825 732 732 query36 903 960 842 842 query37 147 114 92 92 query38 3880391437213721 query39 737 727 720 720 query39_1701 712 688 688 query40 228 130 121 121 query41 68 62 62 62 query42 136 119 113 113 query43 453 440 423 423 query44 1359755 792 755 query45 200 192 186 186 query46 929 1028670 670 query47 1688171416091609 query48 401 444 322 322 query49 788 505 394 394 query50 705 714 406 406 query51 3851392538723872 query52 115 121 113 113 query53 241 263 198 198 query54 325 297 278 278 query55 101 100 94 94 query56 340 345 332 332 query57 1128116510841084 query58 281 315 267 267 query59 2300243223612361 query60 354 352 329 329 query61 161 157 155 155 query62 788 704 658 658 query63 232 198 199 198 query64 44371183889 889 query65 4061397739683968 query66 1094432 346 346 query67 15126 15073 14800 14800 query68 84311019639 639 query69 522 364 313 313 query70 1102101610091009 query71 484 362 343 343 query72 5522485547584758 query73 723 583 345 345 query74 8838876586088608 query75 3644302325472547 query76 38251152737 737 query77 809 421 319 319 query78 9526965489208920 query79 2196834 585 585 query80 650 581 493 493 query81 532 272 231 231 query82 481 144 116 116 query83 274 268 251 251 query84 262 119 99 99 query85 912 489 440 440 query86 396 300 300 300 query87 4084407839573957 query88 4121228622802280 query89 393 326 296 296 query90 1981225 212 212 query91 171 174 139 139 query92 87 73 67 67 query93 19101018686 686 query94 745 467 345 345 query95 512 406 409 406 query96 548 561 285 285 query97 2616269125772577 query98 245 221 220 220 query99 1332137112411241 Total cold run time: 273484 ms Total hot run time: 181985 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
doris-robot commented on PR #58679: URL: https://github.com/apache/doris/pull/58679#issuecomment-3609556369 TPC-H: Total hot run time: 34296 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 0488d41413c85e45223e3dee694cf5920d111f13, data reload: false -- Round 1 -- q1 17719 513649004900 q2 2262315 215 215 q3 10242 1312724 724 q4 10221 832 322 322 q5 7504238521482148 q6 181 166 141 141 q7 949 782 656 656 q8 9363139711151115 q9 7113534252685268 q10 7089220217601760 q11 651 307 292 292 q12 371 379 233 233 q13 17809 365630703070 q14 231 247 218 218 q15 604 523 515 515 q16 882 871 793 793 q17 672 760 586 586 q18 7771700670607006 q19 1161938 600 600 q20 350 357 230 230 q21 3953365225472547 q22 10681002957 957 Total cold run time: 108166 ms Total hot run time: 34296 ms - Round 2, with runtime_filter_mode=off - q1 4958493048924892 q2 316 395 318 318 q3 2131263523122312 q4 1313176112871287 q5 4293455844644464 q6 233 187 135 135 q7 2063201417511751 q8 2690255525102510 q9 7621765275417541 q10 3029333128242824 q11 595 530 475 475 q12 673 741 658 658 q13 3722382033153315 q14 291 297 285 285 q15 552 508 504 504 q16 956 918 895 895 q17 1175140014591400 q18 7733767576117611 q19 869 846 850 846 q20 2008206319121912 q21 4627428841004100 q22 10811040984 984 Total cold run time: 52929 ms Total hot run time: 51019 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
kaka11chen commented on PR #58679: URL: https://github.com/apache/doris/pull/58679#issuecomment-3609433054 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
doris-robot commented on PR #58679: URL: https://github.com/apache/doris/pull/58679#issuecomment-3608031759 # BE UT Coverage Report Increment line coverage `17.73% (36/203)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/5f3512a390bbb7e6578f149638ceffdaa4e556bb_5f3512a390bbb7e6578f149638ceffdaa4e556bb/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/5f3512a390bbb7e6578f149638ceffdaa4e556bb_5f3512a390bbb7e6578f149638ceffdaa4e556bb/report/index.html) | Category | Coverage | |---|| | Function Coverage | 53.35% (18640/34937) | | Line Coverage | 39.01% (172092/441121) | | Region Coverage | 33.62% (133187/396192) | | Branch Coverage | 34.59% (57340/165789) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
doris-robot commented on PR #58679: URL: https://github.com/apache/doris/pull/58679#issuecomment-3607891330 ClickBench: Total hot run time: 27.29 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 5f3512a390bbb7e6578f149638ceffdaa4e556bb, data reload: false query1 0.050.050.04 query2 0.110.050.05 query3 0.250.090.08 query4 1.620.130.11 query5 0.270.280.25 query6 1.150.640.66 query7 0.030.020.02 query8 0.050.040.04 query9 0.550.510.51 query10 0.570.580.56 query11 0.170.100.10 query12 0.160.130.11 query13 0.630.620.60 query14 1.020.991.00 query15 0.810.800.81 query16 0.410.420.39 query17 1.081.071.04 query18 0.230.210.22 query19 1.911.861.81 query20 0.020.010.01 query21 15.43 0.280.13 query22 4.700.050.05 query23 15.99 0.280.10 query24 2.640.590.23 query25 0.110.060.07 query26 0.160.130.13 query27 0.060.060.07 query28 5.151.201.02 query29 12.62 4.063.25 query30 0.280.140.13 query31 2.830.620.38 query32 3.250.560.48 query33 3.103.063.03 query34 16.99 5.164.51 query35 4.544.524.57 query36 0.650.520.49 query37 0.110.070.06 query38 0.070.040.04 query39 0.040.030.03 query40 0.160.140.14 query41 0.090.030.03 query42 0.040.030.03 query43 0.040.030.03 Total cold run time: 100.14 s Total hot run time: 27.29 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
doris-robot commented on PR #58679: URL: https://github.com/apache/doris/pull/58679#issuecomment-3607867886 TPC-DS: Total hot run time: 182412 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 5f3512a390bbb7e6578f149638ceffdaa4e556bb, data reload: false query5 4922661 493 493 query6 344 243 235 235 query7 4654515 311 311 query8 314 256 244 244 query9 8726264626582646 query10 552 374 314 314 query11 15414 15110 14984 14984 query12 188 129 122 122 query13 1687610 455 455 query14 6555342031253125 query14_13060303429972997 query15 215 200 182 182 query16 7697703 538 538 query17 1225794 640 640 query18 2046438 355 355 query19 222 208 189 189 query20 130 128 122 122 query21 226 138 117 117 query22 3861420138743874 query23 16672 16032 15799 15799 query23_115995 15866 15933 15866 query24 6871165112281228 query24_11218120512421205 query25 660 558 488 488 query26 775 282 179 179 query27 2721513 349 349 query28 4329218721802180 query29 762 651 518 518 query30 324 250 223 223 query31 848 721 620 620 query32 86 79 73 73 query33 604 402 348 348 query34 838 893 587 587 query35 796 832 741 741 query36 890 935 841 841 query37 133 116 95 95 query38 3809384037943794 query39 752 741 715 715 query39_1721 698 696 696 query40 225 133 127 127 query41 66 62 64 62 query42 127 112 114 112 query43 430 445 405 405 query44 1332766 759 759 query45 203 194 187 187 query46 906 1005647 647 query47 1665174116251625 query48 411 455 331 331 query49 742 505 423 423 query50 693 697 421 421 query51 3925392639263926 query52 117 115 104 104 query53 250 264 200 200 query54 315 303 279 279 query55 104 98 95 95 query56 335 329 350 329 query57 1132115211201120 query58 292 278 316 278 query59 2347246223332333 query60 355 354 338 338 query61 168 157 162 157 query62 802 719 666 666 query63 238 199 211 199 query64 36351242911 911 query65 4058400739743974 query66 918 458 334 334 query67 15174 15110 14712 14712 query68 83911001641 641 query69 541 353 313 313 query70 1068104910511049 query71 492 345 321 321 query72 5975493448934893 query73 738 592 359 359 query74 8867881286408640 query75 3662304525592559 query76 37551166762 762 query77 819 447 320 320 query78 9332956488328832 query79 2236862 605 605 query80 661 615 499 499 query81 537 281 241 241 query82 472 146 113 113 query83 273 274 248 248 query84 255 120 98 98 query85 956 504 462 462 query86 407 309 273 273 query87 4037407739233923 query88 4183233022862286 query89 388 341 301 301 query90 1906231 225 225 query91 167 179 141 141 query92 77 73 70 70 query93 19461055672 672 query94 719 464 350 350 query95 519 424 420 420 query96 539 563 286 286 query97 2651267526052605 query98 246 221 213 213 query99 1382138412641264 Total cold run time: 270579 ms Total hot run time: 182412 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
doris-robot commented on PR #58679: URL: https://github.com/apache/doris/pull/58679#issuecomment-3607820270 TPC-H: Total hot run time: 34564 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 5f3512a390bbb7e6578f149638ceffdaa4e556bb, data reload: false -- Round 1 -- q1 17622 512149974997 q2 2008320 206 206 q3 10246 1333742 742 q4 10226 901 325 325 q5 7515241821572157 q6 190 175 139 139 q7 964 798 634 634 q8 9350146411561156 q9 7053543654595436 q10 6832218017911791 q11 519 320 292 292 q12 343 377 233 233 q13 17815 369730393039 q14 230 238 215 215 q15 601 526 509 509 q16 890 885 815 815 q17 693 842 526 526 q18 7523705570977055 q19 1195965 596 596 q20 366 355 231 231 q21 4026376225502550 q22 10521022920 920 Total cold run time: 107259 ms Total hot run time: 34564 ms - Round 2, with runtime_filter_mode=off - q1 5056500949954995 q2 332 402 326 326 q3 2119282022522252 q4 1302177713031303 q5 4248452745444527 q6 230 186 136 136 q7 2054204918381838 q8 2651265525332533 q9 7442745875087458 q10 3161324728072807 q11 596 531 484 484 q12 708 749 831 749 q13 3526391832563256 q14 273 295 274 274 q15 566 514 507 507 q16 915 961 870 870 q17 1200141114041404 q18 7810762975427542 q19 914 871 893 871 q20 2017201719151915 q21 4756427641144114 q22 11031003967 967 Total cold run time: 52979 ms Total hot run time: 51128 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
kaka11chen commented on PR #58679: URL: https://github.com/apache/doris/pull/58679#issuecomment-3607644108 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
doris-robot commented on PR #58679: URL: https://github.com/apache/doris/pull/58679#issuecomment-3607191356 ClickBench: Total hot run time: 27.49 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit dd836e24c2d3644e6538f6dfc9c628e50c242702, data reload: false query1 0.050.040.05 query2 0.110.050.05 query3 0.260.090.09 query4 1.630.120.11 query5 0.270.270.27 query6 1.190.630.63 query7 0.040.030.02 query8 0.060.050.05 query9 0.570.510.49 query10 0.560.550.55 query11 0.160.110.11 query12 0.160.120.12 query13 0.630.630.61 query14 0.980.980.98 query15 0.800.800.80 query16 0.410.410.40 query17 1.041.041.06 query18 0.240.210.21 query19 1.861.711.77 query20 0.010.010.01 query21 15.43 0.290.14 query22 4.660.050.04 query23 16.09 0.270.10 query24 1.990.490.93 query25 0.080.090.09 query26 0.150.130.14 query27 0.060.050.07 query28 5.041.221.03 query29 12.57 4.003.16 query30 0.280.140.12 query31 2.810.640.39 query32 3.220.540.46 query33 2.973.033.04 query34 16.76 5.134.59 query35 4.564.584.53 query36 0.680.510.49 query37 0.100.070.07 query38 0.070.040.04 query39 0.050.030.03 query40 0.160.140.14 query41 0.080.030.02 query42 0.050.030.03 query43 0.040.040.03 Total cold run time: 98.93 s Total hot run time: 27.49 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
doris-robot commented on PR #58679: URL: https://github.com/apache/doris/pull/58679#issuecomment-3607166872 TPC-DS: Total hot run time: 182015 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit dd836e24c2d3644e6538f6dfc9c628e50c242702, data reload: false query5 5056666 501 501 query6 334 239 224 224 query7 4694519 316 316 query8 306 274 240 240 query9 8716265826742658 query10 561 378 322 322 query11 15406 15050 14894 14894 query12 180 128 117 117 query13 1688604 455 455 query14 6500326030063006 query14_12914293929072907 query15 215 199 181 181 query16 7643690 533 533 query17 1245810 617 617 query18 2023416 318 318 query19 202 203 174 174 query20 128 122 120 120 query21 217 131 118 118 query22 3837394337763776 query23 16575 16255 16001 16001 query23_116032 15930 16037 15930 query24 6918163212071207 query24_11229118612091186 query25 596 515 457 457 query26 1236278 164 164 query27 2729507 338 338 query28 4320219321662166 query29 801 630 492 492 query30 313 245 214 214 query31 809 706 628 628 query32 78 74 76 74 query33 593 380 328 328 query34 854 879 542 542 query35 785 829 743 743 query36 878 899 851 851 query37 123 116 90 90 query38 3915393637953795 query39 765 764 723 723 query39_1690 694 694 694 query40 224 140 118 118 query41 71 77 61 61 query42 129 111 118 111 query43 440 462 420 420 query44 1319755 755 755 query45 197 193 182 182 query46 899 1026638 638 query47 1681175616811681 query48 403 425 335 335 query49 795 491 402 402 query50 686 709 423 423 query51 3881384837693769 query52 119 116 104 104 query53 237 258 198 198 query54 323 303 290 290 query55 94 93 92 92 query56 334 323 324 323 query57 1107117911031103 query58 286 271 297 271 query59 2388250423752375 query60 354 363 331 331 query61 165 162 153 153 query62 761 714 647 647 query63 227 193 190 190 query64 45091214904 904 query65 4041400739643964 query66 1096455 335 335 query67 15140 15104 15030 15030 query68 46601018649 649 query69 516 346 314 314 query70 1137104810011001 query71 430 345 318 318 query72 5889501150225011 query73 658 581 366 366 query74 8886882685878587 query75 3042305025742574 query76 32551160793 793 query77 512 432 326 326 query78 9428967988218821 query79 2013839 577 577 query80 1681581 499 499 query81 554 268 247 247 query82 425 141 112 112 query83 368 272 252 252 query84 273 117 92 92 query85 951 505 464 464 query86 386 282 298 282 query87 4159404339383938 query88 3061232623102310 query89 393 340 289 289 query90 1745234 227 227 query91 180 178 141 141 query92 74 73 67 67 query93 12791039685 685 query94 741 451 336 336 query95 501 409 407 407 query96 549 552 288 288 query97 2607268325852585 query98 239 216 217 216 query99 1331137312941294 Total cold run time: 265466 ms Total hot run time: 182015 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
doris-robot commented on PR #58679: URL: https://github.com/apache/doris/pull/58679#issuecomment-3607115111 TPC-H: Total hot run time: 34338 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit dd836e24c2d3644e6538f6dfc9c628e50c242702, data reload: false -- Round 1 -- q1 17663 510149274927 q2 2054328 204 204 q3 10228 1287748 748 q4 10243 906 329 329 q5 7532241021962196 q6 192 173 142 142 q7 938 798 628 628 q8 9352143011741174 q9 6869535953455345 q10 6834218317641764 q11 524 300 297 297 q12 338 375 224 224 q13 17771 362030223022 q14 228 233 215 215 q15 596 506 509 506 q16 912 859 807 807 q17 664 800 524 524 q18 7431717970277027 q19 1192958 608 608 q20 359 343 226 226 q21 3962321224932493 q22 1038989 932 932 Total cold run time: 106920 ms Total hot run time: 34338 ms - Round 2, with runtime_filter_mode=off - q1 4981496149174917 q2 347 419 317 317 q3 2150262922812281 q4 1316174012781278 q5 4195434745164347 q6 228 184 135 135 q7 2070196818531853 q8 2680248524462446 q9 7530765375797579 q10 3079327128092809 q11 574 530 486 486 q12 693 763 658 658 q13 3532393434293429 q14 295 314 282 282 q15 566 524 521 521 q16 903 939 881 881 q17 1129144914441444 q18 8232763176407631 q19 901 865 887 865 q20 1996205219381938 q21 4610419740964096 q22 10761058991 991 Total cold run time: 53083 ms Total hot run time: 51184 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
kaka11chen commented on PR #58679: URL: https://github.com/apache/doris/pull/58679#issuecomment-3606886033 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
kaka11chen commented on PR #58679: URL: https://github.com/apache/doris/pull/58679#issuecomment-3606196103 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
kaka11chen commented on PR #58679: URL: https://github.com/apache/doris/pull/58679#issuecomment-3605991405 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
Copilot commented on code in PR #58679:
URL: https://github.com/apache/doris/pull/58679#discussion_r2584146205
##
be/src/vec/exec/jni_connector.cpp:
##
@@ -313,10 +313,9 @@ Status JniConnector::_fill_block(Block* block, size_t
num_rows) {
SCOPED_RAW_TIMER(&_fill_block_watcher);
JNIEnv* env = nullptr;
RETURN_IF_ERROR(JniUtil::GetJNIEnv(&env));
-// todo: maybe do not need to build name to index map every time
-auto name_to_pos_map = block->get_name_to_pos_map();
for (int i = 0; i < _column_names.size(); ++i) {
-auto& column_with_type_and_name =
block->get_by_position(name_to_pos_map[_column_names[i]]);
+auto& column_with_type_and_name =
+
block->get_by_position(_col_name_to_block_idx->at(_column_names[i]));
Review Comment:
Potential null pointer dereference. `_col_name_to_block_idx` is used without
checking if it's nullptr. If `set_col_name_to_block_idx()` is not called before
`_fill_block()`, this will crash. Add a null check or ensure initialization in
the constructor.
##
be/src/vec/exec/scan/scanner_context.cpp:
##
@@ -487,43 +512,45 @@ int32_t
ScannerContext::_get_margin(std::unique_lock& transfer_lock,
Status ScannerContext::schedule_scan_task(std::shared_ptr
current_scan_task,
std::unique_lock&
transfer_lock,
std::unique_lock&
scheduler_lock) {
+std::cout << "ScannerContext::schedule_scan_task()" << std::endl;
if (current_scan_task &&
(!current_scan_task->cached_blocks.empty() ||
current_scan_task->is_eos())) {
throw doris::Exception(ErrorCode::INTERNAL_ERROR, "Scanner scheduler
logical error.");
}
std::list> tasks_to_submit;
-int32_t margin = _get_margin(transfer_lock, scheduler_lock);
-
-// margin is less than zero. Means this scan operator could not submit any
scan task for now.
-if (margin <= 0) {
-// Be careful with current scan task.
-// We need to add it back to task queue to make sure it could be
resubmitted.
-if (current_scan_task) {
-// This usually happens when we should downgrade the concurrency.
-_pending_scanners.push(current_scan_task);
-VLOG_DEBUG << fmt::format(
-"{} push back scanner to task queue, because diff <= 0,
task_queue size "
-"{}, _num_scheduled_scanners {}",
-ctx_id, _tasks_queue.size(), _num_scheduled_scanners);
-}
-
-#ifndef NDEBUG
-// This DCHECK is necessary.
-// We need to make sure each scan operator could have at least 1 scan
tasks.
-// Or this scan operator will not be re-scheduled.
-if (!_pending_scanners.empty() && _num_scheduled_scanners == 0 &&
_tasks_queue.empty()) {
-throw doris::Exception(ErrorCode::INTERNAL_ERROR, "Scanner
scheduler logical error.");
-}
-#endif
-
-return Status::OK();
-}
+// int32_t margin = _get_margin(transfer_lock, scheduler_lock);
+
+// // margin is less than zero. Means this scan operator could not
submit any scan task for now.
+// if (margin <= 0) {
+// // Be careful with current scan task.
+// // We need to add it back to task queue to make sure it could
be resubmitted.
+// if (current_scan_task) {
+// // This usually happens when we should downgrade the
concurrency.
+// _pending_scanners.push(current_scan_task);
+// VLOG_DEBUG << fmt::format(
+// "{} push back scanner to task queue, because diff
<= 0, task_queue size "
+// "{}, _num_scheduled_scanners {}",
+// ctx_id, _tasks_queue.size(),
_num_scheduled_scanners);
+// }
+
+// #ifndef NDEBUG
+// // This DCHECK is necessary.
+// // We need to make sure each scan operator could have at least
1 scan tasks.
+// // Or this scan operator will not be re-scheduled.
+// if (!_pending_scanners.empty() && _num_scheduled_scanners == 0
&& _tasks_queue.empty()) {
+// throw doris::Exception(ErrorCode::INTERNAL_ERROR, "Scanner
scheduler logical error.");
+// }
+// #endif
+
+// return Status::OK();
+// }
Review Comment:
Large blocks of commented-out code (lines 523-548) should be removed. This
includes critical logic for checking margins and concurrency limits that
appears to have been disabled. If this is intentional, it needs proper
documentation explaining why this critical logic was disabled.
```suggestion
// [Removed: previously disabled margin and concurrency check logic. If
needed, see git history for details.]
```
##
be/src/vec/exec/format/orc/vorc_reader.cpp:
##
@@ -1334,10 +1336,9 @@ Status OrcReader::_fill_p
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
kaka11chen commented on PR #58679: URL: https://github.com/apache/doris/pull/58679#issuecomment-3605654340 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Opt](multi-catalog) Opt by avoid building name_to_index map every time. [doris]
hello-stephen commented on PR #58679: URL: https://github.com/apache/doris/pull/58679#issuecomment-3605654039 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
