Re: [PR] [Refactor] Refactor ConnectContext.getCluster [doris]
yiguolei merged PR #50783: URL: https://github.com/apache/doris/pull/50783 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Refactor] Refactor ConnectContext.getCluster [doris]
github-actions[bot] commented on PR #50783: URL: https://github.com/apache/doris/pull/50783#issuecomment-2901076138 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Refactor] Refactor ConnectContext.getCluster [doris]
github-actions[bot] commented on PR #50783: URL: https://github.com/apache/doris/pull/50783#issuecomment-2901076001 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Refactor] Refactor ConnectContext.getCluster [doris]
doris-robot commented on PR #50783: URL: https://github.com/apache/doris/pull/50783#issuecomment-2894708730 ClickBench: Total hot run time: 28.7 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 35a3c309a0f07a2ce31fb3d97c5570fa867ab2f7, data reload: false query1 0.040.040.03 query2 0.120.110.12 query3 0.250.200.19 query4 1.590.190.20 query5 0.460.430.43 query6 1.470.660.67 query7 0.020.010.01 query8 0.040.040.03 query9 0.570.510.51 query10 0.570.580.56 query11 0.150.110.11 query12 0.150.110.12 query13 0.610.600.60 query14 0.800.810.80 query15 0.870.850.85 query16 0.390.380.37 query17 1.050.991.05 query18 0.210.210.21 query19 1.921.781.76 query20 0.010.010.01 query21 15.41 0.910.54 query22 0.751.230.78 query23 14.81 1.390.60 query24 7.231.340.51 query25 0.470.220.08 query26 0.710.160.16 query27 0.050.050.06 query28 9.490.900.45 query29 12.56 4.023.26 query30 0.240.080.07 query31 2.820.600.39 query32 3.230.540.47 query33 3.083.083.05 query34 15.80 5.084.48 query35 4.514.494.53 query36 0.660.490.48 query37 0.090.060.06 query38 0.050.040.03 query39 0.030.020.02 query40 0.170.130.13 query41 0.090.030.02 query42 0.030.030.02 query43 0.040.040.03 Total cold run time: 103.61 s Total hot run time: 28.7 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Refactor] Refactor ConnectContext.getCluster [doris]
doris-robot commented on PR #50783: URL: https://github.com/apache/doris/pull/50783#issuecomment-2894691989 TPC-DS: Total hot run time: 191964 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 35a3c309a0f07a2ce31fb3d97c5570fa867ab2f7, data reload: false query1 1401108810541054 query2 6251183417901790 query3 11005 451743664366 query4 53793 25017 22938 22938 query5 5137502 466 466 query6 312 189 205 189 query7 4884503 300 300 query8 316 273 242 242 query9 5657261126302611 query10 449 317 276 276 query11 15034 14982 14729 14729 query12 157 114 109 109 query13 1041526 414 414 query14 10081 624362026202 query15 207 195 189 189 query16 7034627 487 487 query17 1104746 593 593 query18 1549421 315 315 query19 204 199 185 185 query20 142 134 128 128 query21 207 135 115 115 query22 4534449643664366 query23 34420 33729 33727 33727 query24 6740244124272427 query25 463 458 412 412 query26 714 276 152 152 query27 2292511 342 342 query28 3420214921392139 query29 576 570 438 438 query30 279 225 188 188 query31 862 854 821 821 query32 70 70 60 60 query33 456 369 317 317 query34 791 870 521 521 query35 802 831 745 745 query36 942 995 905 905 query37 115 101 75 75 query38 4174428441134113 query39 1542143314831433 query40 212 126 108 108 query41 55 54 53 53 query42 122 116 113 113 query43 496 487 481 481 query44 1349877 832 832 query45 184 173 171 171 query46 853 1031644 644 query47 1860188518341834 query48 402 458 319 319 query49 691 489 429 429 query50 671 694 404 404 query51 4246431042154215 query52 118 105 100 100 query53 227 256 193 193 query54 585 580 521 521 query55 85 80 81 80 query56 311 320 296 296 query57 1191119511481148 query58 272 263 264 263 query59 2633281826832683 query60 324 310 306 306 query61 128 124 128 124 query62 744 748 696 696 query63 229 194 194 194 query64 20631050682 682 query65 4322425042504250 query66 754 395 304 304 query67 16018 15950 15404 15404 query68 7196932 526 526 query69 549 308 272 272 query70 1185113210661066 query71 498 338 291 291 query72 5876476448034764 query73 1401649 360 360 query74 8977898688198819 query75 3785318426952695 query76 42401191760 760 query77 619 361 278 278 query78 10039 10094 92789278 query79 2596833 591 591 query80 679 507 437 437 query81 490 267 219 219 query82 463 125 96 96 query83 386 251 234 234 query84 300 111 80 80 query85 787 427 301 301 query86 403 295 285 285 query87 4432434443404340 query88 3446230022932293 query89 389 311 281 281 query90 1783203 201 201 query91 143 141 113 113 query92 70 65 53 53 query93 1936970 575 575 query94 668 405 311 311 query95 369 291 284 284 query96 499 583 280 280 query97 2713276526902690 query98 234 207 202 202 query99 1413138912631263 Total cold run time: 298866 ms Total hot run time: 191964 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [Refactor] Refactor ConnectContext.getCluster [doris]
wangbo commented on PR #50783: URL: https://github.com/apache/doris/pull/50783#issuecomment-2893332938 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Refactor] Refactor ConnectContext.getCluster [doris]
doris-robot commented on PR #50783: URL: https://github.com/apache/doris/pull/50783#issuecomment-2894647770 TPC-H: Total hot run time: 33773 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 35a3c309a0f07a2ce31fb3d97c5570fa867ab2f7, data reload: false -- Round 1 -- q1 26088 495349614953 q2 2056274 206 206 q3 10374 1246700 700 q4 10228 998 500 500 q5 7526230123672301 q6 183 162 130 130 q7 924 762 602 602 q8 9559130111441144 q9 7055518151775177 q10 7097231019261926 q11 512 295 275 275 q12 345 354 216 216 q13 18093 364530543054 q14 241 228 210 210 q15 536 491 485 485 q16 420 435 378 378 q17 613 839 367 367 q18 7600712970717071 q19 1236939 556 556 q20 336 326 218 218 q21 3989254723442344 q22 1052992 960 960 Total cold run time: 116063 ms Total hot run time: 33773 ms - Round 2, with runtime_filter_mode=off - q1 5051503650425036 q2 236 322 232 232 q3 2088265922782278 q4 1367179813711371 q5 4369435544124355 q6 219 164 126 126 q7 2024192018161816 q8 2567255325142514 q9 7217723170457045 q10 3016319527382738 q11 569 495 503 495 q12 648 756 622 622 q13 3462385632283228 q14 294 318 289 289 q15 539 475 485 475 q16 457 485 449 449 q17 1141160013211321 q18 7682750775197507 q19 846 804 838 804 q20 2028198818411841 q21 4872441343834383 q22 1087105210541052 Total cold run time: 51779 ms Total hot run time: 49977 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Refactor] Refactor ConnectContext.getCluster [doris]
wangbo commented on PR #50783: URL: https://github.com/apache/doris/pull/50783#issuecomment-2894490890 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Refactor] Refactor ConnectContext.getCluster [doris]
doris-robot commented on PR #50783: URL: https://github.com/apache/doris/pull/50783#issuecomment-2893471645 ClickBench: Total hot run time: 28.95 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit a83cbde7043604c44bba60cd19fe71cf2bc8fd1b, data reload: false query1 0.040.040.03 query2 0.130.100.11 query3 0.250.190.19 query4 1.590.190.20 query5 0.470.440.46 query6 1.150.660.65 query7 0.020.020.02 query8 0.040.040.04 query9 0.620.530.53 query10 0.560.580.56 query11 0.160.110.11 query12 0.150.120.12 query13 0.620.600.59 query14 0.790.800.80 query15 0.890.890.85 query16 0.390.380.39 query17 1.041.081.08 query18 0.220.210.21 query19 1.911.871.77 query20 0.010.010.01 query21 15.42 0.910.53 query22 0.751.200.67 query23 14.91 1.380.64 query24 7.601.000.68 query25 0.450.250.06 query26 0.520.170.13 query27 0.050.060.05 query28 9.450.950.45 query29 12.53 4.013.33 query30 0.250.090.07 query31 2.830.630.41 query32 3.230.550.47 query33 3.043.003.10 query34 15.69 5.164.48 query35 4.524.504.55 query36 0.660.500.49 query37 0.080.060.06 query38 0.050.040.04 query39 0.030.020.03 query40 0.180.140.13 query41 0.080.030.02 query42 0.040.020.02 query43 0.030.030.04 Total cold run time: 103.44 s Total hot run time: 28.95 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Refactor] Refactor ConnectContext.getCluster [doris]
doris-robot commented on PR #50783: URL: https://github.com/apache/doris/pull/50783#issuecomment-2893451424 TPC-DS: Total hot run time: 186713 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit a83cbde7043604c44bba60cd19fe71cf2bc8fd1b, data reload: false query1 1010492 506 492 query2 6567192119101910 query3 6756225 220 220 query4 26505 23724 23129 23129 query5 4352637 450 450 query6 306 207 188 188 query7 4629488 285 285 query8 295 240 232 232 query9 8618260326372603 query10 507 323 264 264 query11 15844 15007 15066 15007 query12 161 108 100 100 query13 1633522 392 392 query14 8805616662046166 query15 216 194 176 176 query16 7138642 476 476 query17 961 719 602 602 query18 1970403 307 307 query19 195 200 170 170 query20 124 119 118 118 query21 217 127 110 110 query22 4114426441544154 query23 33896 33223 33116 33116 query24 8444239724472397 query25 570 490 413 413 query26 1249281 158 158 query27 2736504 333 333 query28 4370210620922092 query29 831 546 440 440 query30 291 221 185 185 query31 941 852 749 749 query32 74 63 65 63 query33 546 374 317 317 query34 822 862 532 532 query35 788 808 806 806 query36 947 988 863 863 query37 114 99 78 78 query38 4128409841154098 query39 1477145714271427 query40 216 126 108 108 query41 58 56 53 53 query42 122 120 111 111 query43 515 521 487 487 query44 1312835 818 818 query45 176 172 167 167 query46 837 1040633 633 query47 1741179617321732 query48 392 415 330 330 query49 785 522 406 406 query50 659 677 410 410 query51 4104411441124112 query52 122 109 106 106 query53 225 245 188 188 query54 592 573 511 511 query55 91 83 81 81 query56 310 318 303 303 query57 1165115010951095 query58 281 259 254 254 query59 2641279626102610 query60 338 312 314 312 query61 126 133 122 122 query62 810 710 658 658 query63 233 191 192 191 query64 43801034707 707 query65 4336421142124211 query66 1154413 313 313 query67 15854 15425 15554 15425 query68 8008903 540 540 query69 479 323 274 274 query70 1147110610741074 query71 477 337 295 295 query72 5663495848224822 query73 709 644 360 360 query74 8874908986588658 query75 3750321527482748 query76 36211214791 791 query77 808 446 293 293 query78 10016 10187 94449444 query79 2348843 595 595 query80 620 544 461 461 query81 481 263 223 223 query82 416 130 101 101 query83 291 266 241 241 query84 296 104 85 85 query85 805 362 312 312 query86 333 317 281 281 query87 4506449644074407 query88 3258233323452333 query89 401 326 291 291 query90 1926241 215 215 query91 143 150 114 114 query92 79 64 63 63 query93 1156950 590 590 query94 681 407 311 311 query95 377 292 295 292 query96 509 585 288 288 query97 2744277526492649 query98 243 211 212 211 query99 1465139312791279 Total cold run time: 273352 ms Total hot run time: 186713 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [Refactor] Refactor ConnectContext.getCluster [doris]
doris-robot commented on PR #50783: URL: https://github.com/apache/doris/pull/50783#issuecomment-2893404200 TPC-H: Total hot run time: 33825 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit a83cbde7043604c44bba60cd19fe71cf2bc8fd1b, data reload: false -- Round 1 -- q1 26413 511050055005 q2 2074279 200 200 q3 10375 1233686 686 q4 10217 996 529 529 q5 7534229424222294 q6 179 164 135 135 q7 914 764 616 616 q8 9320128510451045 q9 6842512151235121 q10 6822231619181918 q11 481 292 278 278 q12 354 346 214 214 q13 17748 365830833083 q14 226 226 217 217 q15 538 492 491 491 q16 429 448 376 376 q17 593 880 366 366 q18 7697715872307158 q19 1218988 580 580 q20 352 357 225 225 q21 3767321023602360 q22 10111039928 928 Total cold run time: 115104 ms Total hot run time: 33825 ms - Round 2, with runtime_filter_mode=off - q1 5070506150515051 q2 236 329 241 241 q3 2210269723232323 q4 1338177513931393 q5 4497446244344434 q6 221 175 128 128 q7 1989188617321732 q8 2617256025422542 q9 7142715771517151 q10 2997317527412741 q11 569 503 492 492 q12 689 791 613 613 q13 3508388733413341 q14 268 291 284 284 q15 525 495 486 486 q16 438 486 448 448 q17 1139158413951395 q18 7694751274277427 q19 810 838 903 838 q20 2027200919121912 q21 4955442244044404 q22 10501019972 972 Total cold run time: 51989 ms Total hot run time: 50348 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Refactor] Refactor ConnectContext.getCluster [doris]
doris-robot commented on PR #50783: URL: https://github.com/apache/doris/pull/50783#issuecomment-2890732932 ClickBench: Total hot run time: 29.74 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 0138bd845c90a84405f0fd0dd4c19932fb391c40, data reload: false query1 0.040.030.04 query2 0.130.110.11 query3 0.240.190.19 query4 1.600.210.20 query5 0.460.460.46 query6 1.180.660.66 query7 0.020.020.01 query8 0.040.030.04 query9 0.580.520.52 query10 0.580.590.57 query11 0.150.100.11 query12 0.150.120.12 query13 0.620.600.60 query14 0.780.800.81 query15 0.890.860.84 query16 0.400.420.38 query17 1.041.021.08 query18 0.220.210.21 query19 1.891.791.80 query20 0.010.010.01 query21 15.40 0.900.57 query22 0.761.301.00 query23 14.69 1.360.60 query24 7.081.781.15 query25 0.530.250.13 query26 0.540.160.14 query27 0.060.050.04 query28 10.26 0.840.43 query29 12.60 3.943.28 query30 0.250.100.08 query31 2.820.580.40 query32 3.230.560.48 query33 3.013.043.06 query34 15.82 5.084.48 query35 4.534.534.48 query36 0.670.510.48 query37 0.090.070.06 query38 0.050.040.04 query39 0.030.020.02 query40 0.170.140.13 query41 0.080.030.02 query42 0.040.030.02 query43 0.040.030.02 Total cold run time: 103.77 s Total hot run time: 29.74 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Refactor] Refactor ConnectContext.getCluster [doris]
doris-robot commented on PR #50783: URL: https://github.com/apache/doris/pull/50783#issuecomment-2890719164 TPC-DS: Total hot run time: 193578 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 0138bd845c90a84405f0fd0dd4c19932fb391c40, data reload: false query1 1402109110461046 query2 6333182417441744 query3 11010 454245504542 query4 53776 24560 23088 23088 query5 5179489 468 468 query6 363 205 197 197 query7 4910493 307 307 query8 322 264 239 239 query9 5830265626612656 query10 453 337 283 283 query11 15063 15066 15174 15066 query12 161 115 109 109 query13 1056529 423 423 query14 10149 627162926271 query15 222 201 177 177 query16 7148696 487 487 query17 1107739 611 611 query18 1583416 326 326 query19 208 203 186 186 query20 132 131 130 130 query21 223 127 115 115 query22 4422458045724572 query23 34516 33552 33669 33552 query24 6550241424482414 query25 462 484 412 412 query26 705 270 154 154 query27 2426547 347 347 query28 3023217221522152 query29 581 565 458 458 query30 275 231 193 193 query31 852 879 767 767 query32 70 61 61 61 query33 479 379 308 308 query34 774 878 567 567 query35 797 825 766 766 query36 958 1009913 913 query37 109 102 80 80 query38 4321428943124289 query39 1524148814811481 query40 206 118 110 110 query41 58 58 52 52 query42 132 109 121 109 query43 510 502 474 474 query44 1328857 871 857 query45 192 183 173 173 query46 901 1027666 666 query47 1893192418121812 query48 434 455 331 331 query49 694 525 425 425 query50 657 727 404 404 query51 4209427342354235 query52 118 109 106 106 query53 227 258 203 203 query54 601 580 513 513 query55 90 88 90 88 query56 335 307 301 301 query57 1237117911281128 query58 284 262 265 262 query59 2647271926562656 query60 338 346 333 333 query61 134 128 125 125 query62 761 742 683 683 query63 232 208 188 188 query64 16371005676 676 query65 4321431042094209 query66 736 399 311 311 query67 16216 15651 15791 15651 query68 7180902 542 542 query69 553 313 273 273 query70 1250108111301081 query71 517 338 316 316 query72 5776478750324787 query73 1497715 373 373 query74 8948904587888788 query75 3772318026882688 query76 41431188760 760 query77 635 378 282 282 query78 10130 10126 94409440 query79 3451821 564 564 query80 650 578 463 463 query81 499 259 225 225 query82 484 123 96 96 query83 365 254 231 231 query84 295 96 87 87 query85 800 356 306 306 query86 401 303 286 286 query87 4495450143154315 query88 3719236923302330 query89 408 312 298 298 query90 1807203 205 203 query91 153 159 111 111 query92 70 58 56 56 query93 2273948 576 576 query94 673 394 307 307 query95 371 291 290 290 query96 506 577 292 292 query97 2742280426752675 query98 242 205 207 205 query99 1447143212941294 Total cold run time: 300854 ms Total hot run time: 193578 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [Refactor] Refactor ConnectContext.getCluster [doris]
doris-robot commented on PR #50783: URL: https://github.com/apache/doris/pull/50783#issuecomment-2890685245 TPC-H: Total hot run time: 33736 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 0138bd845c90a84405f0fd0dd4c19932fb391c40, data reload: false -- Round 1 -- q1 26143 512249964996 q2 2087274 175 175 q3 10404 1217682 682 q4 10219 1007524 524 q5 7535236223092309 q6 179 168 133 133 q7 934 737 599 599 q8 9317122610541054 q9 6795509450695069 q10 6875233918901890 q11 501 297 275 275 q12 346 346 208 208 q13 17758 372031403140 q14 225 244 226 226 q15 531 492 488 488 q16 435 429 384 384 q17 607 851 382 382 q18 7650710971697109 q19 1500947 538 538 q20 331 327 231 231 q21 3626311723452345 q22 10131014979 979 Total cold run time: 115011 ms Total hot run time: 33736 ms - Round 2, with runtime_filter_mode=off - q1 5087501550175015 q2 235 340 228 228 q3 2128260822562256 q4 1319174112981298 q5 4390438544314385 q6 216 176 129 129 q7 2036189417591759 q8 2585250924632463 q9 7224722369856985 q10 3010319327372737 q11 582 523 492 492 q12 746 755 611 611 q13 3433388732723272 q14 265 310 284 284 q15 521 480 472 472 q16 471 513 438 438 q17 1137150613901390 q18 7709751073947394 q19 785 886 1090886 q20 2022211018761876 q21 4766460844034403 q22 1055104110331033 Total cold run time: 51722 ms Total hot run time: 49806 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Refactor] Refactor ConnectContext.getCluster [doris]
wangbo commented on PR #50783: URL: https://github.com/apache/doris/pull/50783#issuecomment-2890582797 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Refactor] Refactor ConnectContext.getCluster [doris]
yiguolei commented on code in PR #50783:
URL: https://github.com/apache/doris/pull/50783#discussion_r2095075724
##
fe/fe-core/src/main/java/org/apache/doris/cloud/catalog/CloudReplica.java:
##
@@ -212,41 +214,43 @@ private String getCurrentClusterId() throws
ComputeGroupException {
String cluster = null;
ConnectContext context = ConnectContext.get();
if (context != null) {
-if
(!Strings.isNullOrEmpty(context.getSessionVariable().getCloudCluster())) {
-cluster = context.getSessionVariable().getCloudCluster();
+// TODO(wb) rethinking whether should update err status.
+cluster = context.getCloudCluster();
+
+if (LOG.isDebugEnabled()) {
+LOG.debug("get compute group by context {}", cluster);
+}
+
+UserIdentity currentUid = context.getCurrentUserIdentity();
+if (currentUid != null &&
!StringUtils.isEmpty(currentUid.getQualifiedUser())) {
Review Comment:
这里为什么要判断userid 是不是为null？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [Refactor] Refactor ConnectContext.getCluster [doris]
doris-robot commented on PR #50783: URL: https://github.com/apache/doris/pull/50783#issuecomment-2889527143 ClickBench: Total hot run time: 28.92 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit a6b823ac100c57e4e1bbb08eec945604698ed917, data reload: false query1 0.040.040.04 query2 0.130.100.12 query3 0.250.190.19 query4 1.600.200.10 query5 0.440.420.43 query6 1.180.670.66 query7 0.020.030.02 query8 0.040.030.04 query9 0.590.520.52 query10 0.570.580.57 query11 0.150.110.12 query12 0.150.120.11 query13 0.630.600.60 query14 0.790.810.81 query15 0.880.860.85 query16 0.380.390.38 query17 1.071.041.09 query18 0.230.210.21 query19 1.951.881.93 query20 0.010.020.01 query21 15.39 0.910.57 query22 0.751.220.80 query23 14.76 1.390.62 query24 7.181.170.39 query25 0.380.140.12 query26 0.690.160.15 query27 0.070.050.05 query28 8.930.980.44 query29 12.58 3.983.29 query30 0.260.100.07 query31 2.810.610.39 query32 3.240.560.48 query33 3.173.043.07 query34 15.78 5.134.53 query35 4.494.574.52 query36 0.680.510.48 query37 0.080.060.06 query38 0.050.040.04 query39 0.030.020.02 query40 0.190.140.13 query41 0.090.030.03 query42 0.030.020.03 query43 0.040.040.03 Total cold run time: 102.77 s Total hot run time: 28.92 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Refactor] Refactor ConnectContext.getCluster [doris]
doris-robot commented on PR #50783: URL: https://github.com/apache/doris/pull/50783#issuecomment-2889521209 TPC-DS: Total hot run time: 194706 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit a6b823ac100c57e4e1bbb08eec945604698ed917, data reload: false query1 1404112310611061 query2 6278183818301830 query3 11029 437344604373 query4 54968 25346 23439 23439 query5 4953503 451 451 query6 361 218 201 201 query7 4945527 306 306 query8 326 264 242 242 query9 5915272227082708 query10 480 325 294 294 query11 15365 15063 14980 14980 query12 153 109 107 107 query13 1058540 400 400 query14 10180 631462716271 query15 192 204 176 176 query16 7061679 541 541 query17 1079728 580 580 query18 1508411 321 321 query19 194 186 173 173 query20 126 133 123 123 query21 205 129 116 116 query22 4486462844534453 query23 34279 33705 33594 33594 query24 6711245324822453 query25 516 519 457 457 query26 667 283 164 164 query27 2200530 363 363 query28 2960230422902290 query29 622 614 511 511 query30 286 227 212 212 query31 881 891 822 822 query32 79 108 60 60 query33 456 378 313 313 query34 801 893 541 541 query35 825 824 759 759 query36 981 1019903 903 query37 110 105 79 79 query38 4202429642104210 query39 1545147514991475 query40 218 124 115 115 query41 59 58 57 57 query42 133 113 118 113 query43 527 521 505 505 query44 1386908 906 906 query45 181 178 172 172 query46 873 1059677 677 query47 1855194918651865 query48 405 448 329 329 query49 716 545 440 440 query50 690 724 422 422 query51 4362431042754275 query52 113 109 100 100 query53 227 265 185 185 query54 606 598 551 551 query55 94 89 86 86 query56 312 311 301 301 query57 1212121811311131 query58 281 271 275 271 query59 2797278028332780 query60 346 341 338 338 query61 130 127 123 123 query62 769 741 676 676 query63 243 204 196 196 query64 14581021716 716 query65 4282426442874264 query66 711 407 306 306 query67 16112 15681 15542 15542 query68 7800916 548 548 query69 554 306 281 281 query70 1250107811321078 query71 502 322 302 302 query72 5796481949624819 query73 1275711 373 373 query74 9268911289738973 query75 3927323127282728 query76 43371208771 771 query77 605 368 300 300 query78 10022 10268 93929392 query79 4489818 578 578 query80 666 531 455 455 query81 480 256 225 225 query82 522 128 96 96 query83 354 258 237 237 query84 287 117 89 89 query85 846 363 323 323 query86 397 301 376 301 query87 4406451943424342 query88 3287238624272386 query89 454 325 283 283 query90 1904218 211 211 query91 150 145 117 117 query92 75 64 58 58 query93 2560948 597 597 query94 696 420 314 314 query95 378 295 298 295 query96 508 592 298 298 query97 2748279426402640 query98 240 215 206 206 query99 1453138212961296 Total cold run time: 303721 ms Total hot run time: 194706 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [Refactor] Refactor ConnectContext.getCluster [doris]
doris-robot commented on PR #50783: URL: https://github.com/apache/doris/pull/50783#issuecomment-2889507673 TPC-H: Total hot run time: 33704 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit a6b823ac100c57e4e1bbb08eec945604698ed917, data reload: false -- Round 1 -- q1 26622 504750435043 q2 2100305 190 190 q3 10357 1236688 688 q4 10234 1004535 535 q5 7527231423202314 q6 185 164 130 130 q7 904 740 616 616 q8 9325121710271027 q9 6862504350675043 q10 6872231018901890 q11 477 287 267 267 q12 347 352 220 220 q13 18018 377030963096 q14 230 229 210 210 q15 531 492 505 492 q16 421 453 377 377 q17 581 846 364 364 q18 7534721170907090 q19 1803943 535 535 q20 330 329 223 223 q21 3662310323822382 q22 10341020972 972 Total cold run time: 115956 ms Total hot run time: 33704 ms - Round 2, with runtime_filter_mode=off - q1 5123501650315016 q2 240 332 230 230 q3 2156261222652265 q4 1306171913381338 q5 4430432443974324 q6 208 172 127 127 q7 1980189917601760 q8 2554263224672467 q9 7221712969186918 q10 3023316727792779 q11 578 511 488 488 q12 679 787 593 593 q13 3453391832963296 q14 300 308 280 280 q15 520 507 479 479 q16 465 521 441 441 q17 1140146614101410 q18 7702755475167516 q19 804 764 876 764 q20 1993204218451845 q21 4601452043734373 q22 1096109210161016 Total cold run time: 51572 ms Total hot run time: 49725 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Refactor] Refactor ConnectContext.getCluster [doris]
wangbo commented on PR #50783: URL: https://github.com/apache/doris/pull/50783#issuecomment-2889471569 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Refactor] Refactor ConnectContext.getCluster [doris]
wangbo commented on code in PR #50783:
URL: https://github.com/apache/doris/pull/50783#discussion_r2094744013
##
fe/fe-core/src/main/java/org/apache/doris/cloud/load/CloudBrokerLoadJob.java:
##
@@ -130,12 +125,16 @@ private AutoCloseConnectContext buildConnectContext()
throws UserException {
if (ConnectContext.get() == null) {
ConnectContext connectContext = new ConnectContext();
connectContext.setCloudCluster(clusterName);
+connectContext.setCurrentUserIdentity(this.userInfo);
+connectContext.setQualifiedUser(this.userInfo.getQualifiedUser());
if (connectContext.getEnv() == null) {
connectContext.setEnv(Env.getCurrentEnv());
}
return new AutoCloseConnectContext(connectContext);
} else {
ConnectContext.get().setCloudCluster(clusterName);
+ConnectContext.get().setCurrentUserIdentity(this.userInfo);
+
ConnectContext.get().setQualifiedUser(this.userInfo.getQualifiedUser());
Review Comment:
不是，是单独存的一个
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [Refactor] Refactor ConnectContext.getCluster [doris]
yiguolei commented on code in PR #50783:
URL: https://github.com/apache/doris/pull/50783#discussion_r2093426925
##
fe/fe-core/src/main/java/org/apache/doris/cloud/load/CloudLoadLoadingTask.java:
##
@@ -66,16 +69,25 @@ private AutoCloseConnectContext buildConnectContext()
throws UserException {
if (ConnectContext.get() == null) {
ConnectContext connectContext = new ConnectContext();
connectContext.setCloudCluster(clusterName);
+connectContext.setCurrentUserIdentity(this.userInfo);
+connectContext.setQualifiedUser(this.userInfo.getQualifiedUser());
return new AutoCloseConnectContext(connectContext);
} else {
ConnectContext.get().setCloudCluster(clusterName);
+ConnectContext.get().setCurrentUserIdentity(this.userInfo);
+
ConnectContext.get().setQualifiedUser(this.userInfo.getQualifiedUser());
return null;
}
}
@Override
protected void executeOnce() throws Exception {
try (AutoCloseConnectContext r = buildConnectContext()) {
+if (ConnectContext.get().getCurrentUserIdentity() == null ||
StringUtils.isEmpty(
+
ConnectContext.get().getCurrentUserIdentity().getQualifiedUser())) {
Review Comment:
什么时候useridentity的qualified user 为空？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [Refactor] Refactor ConnectContext.getCluster [doris]
yiguolei commented on code in PR #50783:
URL: https://github.com/apache/doris/pull/50783#discussion_r2093149367
##
fe/fe-core/src/main/java/org/apache/doris/cloud/load/CloudBrokerLoadJob.java:
##
@@ -95,24 +95,19 @@ private void setCloudClusterId() throws
MetaNotFoundException {
try {
clusterName = context.getCloudCluster();
} catch (ComputeGroupException e) {
-LOG.warn("failed to get compute group name", e);
-throw new MetaNotFoundException("failed to get compute group
name " + e);
+LOG.warn("error happens when get cloud cluster", e);
Review Comment:
CloudBrokerLoadJob 有2个构造函数，是不带user 这些参数的，此时咋处理呢？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [Refactor] Refactor ConnectContext.getCluster [doris]
wangbo commented on PR #50783: URL: https://github.com/apache/doris/pull/50783#issuecomment-2879234076 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Refactor] Refactor ConnectContext.getCluster [doris]
hello-stephen commented on PR #50783: URL: https://github.com/apache/doris/pull/50783#issuecomment-2868670949 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
