Re: [PR] [Test](cloud-mow) check delete bitmap key's existence before put KV [doris]
zhannngchen merged PR #51013: URL: https://github.com/apache/doris/pull/51013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Test](cloud-mow) check delete bitmap key's existence before put KV [doris]
github-actions[bot] commented on PR #51013: URL: https://github.com/apache/doris/pull/51013#issuecomment-2894202153 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Test](cloud-mow) check delete bitmap key's existence before put KV [doris]
github-actions[bot] commented on PR #51013: URL: https://github.com/apache/doris/pull/51013#issuecomment-2894202032 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Test](cloud-mow) check delete bitmap key's existence before put KV [doris]
hello-stephen commented on PR #51013: URL: https://github.com/apache/doris/pull/51013#issuecomment-2893900560 # BE Regression && UT Coverage Report Increment line coverage `0.00% (0/6)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/51013_40b6bd85e83ff0f54d90438eb3778c10c8f25f26_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/51013_40b6bd85e83ff0f54d90438eb3778c10c8f25f26_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 79.45% (20863/26259) | | Line Coverage | 72.66% (214910/295773) | | Region Coverage | 70.78% (126305/178441) | | Branch Coverage | 64.53% (65446/101416) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Test](cloud-mow) check delete bitmap key's existence before put KV [doris]
doris-robot commented on PR #51013: URL: https://github.com/apache/doris/pull/51013#issuecomment-2893599291 TPC-DS: Total hot run time: 193366 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 40b6bd85e83ff0f54d90438eb3778c10c8f25f26, data reload: false query1 1385110310741074 query2 6400179417851785 query3 11183 462347224623 query4 26002 24037 22990 22990 query5 5143652 462 462 query6 307 217 209 209 query7 4001498 288 288 query8 320 260 242 242 query9 8520264126132613 query10 521 345 271 271 query11 15671 15109 14766 14766 query12 168 113 111 111 query13 1576536 415 415 query14 9028640663446344 query15 203 195 172 172 query16 7617662 500 500 query17 1121791 645 645 query18 2049419 324 324 query19 205 212 174 174 query20 169 123 122 122 query21 215 137 113 113 query22 4365464644074407 query23 34818 33856 33718 33718 query24 8500246025112460 query25 523 490 427 427 query26 1204291 151 151 query27 2848512 367 367 query28 4658215521332133 query29 692 583 455 455 query30 282 233 196 196 query31 914 894 799 799 query32 81 70 64 64 query33 548 411 342 342 query34 810 875 534 534 query35 803 822 755 755 query36 977 1026911 911 query37 116 103 76 76 query38 4386425642044204 query39 1546150914501450 query40 215 120 109 109 query41 55 57 53 53 query42 119 111 110 110 query43 521 512 476 476 query44 1325850 855 850 query45 190 183 169 169 query46 866 1049685 685 query47 1861186017511751 query48 403 443 351 351 query49 764 517 451 451 query50 697 703 417 417 query51 4249427242474247 query52 111 111 97 97 query53 232 257 193 193 query54 620 590 528 528 query55 91 90 88 88 query56 354 310 317 310 query57 1174118411361136 query58 272 268 257 257 query59 2753278826402640 query60 379 341 306 306 query61 132 132 134 132 query62 772 745 696 696 query63 235 192 203 192 query64 40331055717 717 query65 4438441644184416 query66 924 401 311 311 query67 15817 15607 15515 15515 query68 8437889 521 521 query69 511 314 285 285 query70 1202114410791079 query71 481 322 291 291 query72 5891468846504650 query73 668 591 362 362 query74 8904886590888865 query75 3892322826982698 query76 37981186755 755 query77 855 390 288 288 query78 10220 10212 94519451 query79 2688829 604 604 query80 654 536 449 449 query81 477 250 227 227 query82 452 120 99 99 query83 277 251 227 227 query84 293 104 93 93 query85 759 362 323 323 query86 326 339 267 267 query87 4407448642784278 query88 3271236723392339 query89 438 331 290 290 query90 1919220 217 217 query91 139 143 112 112 query92 77 61 55 55 query93 1783973 575 575 query94 667 404 306 306 query95 377 301 288 288 query96 504 572 287 287 query97 2758281926952695 query98 230 209 199 199 query99 1456142012961296 Total cold run time: 282288 ms Total hot run time: 193366 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [Test](cloud-mow) check delete bitmap key's existence before put KV [doris]
hello-stephen commented on PR #51013: URL: https://github.com/apache/doris/pull/51013#issuecomment-2893723445 # BE UT Coverage Report Increment line coverage `0.00% (0/6)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/40b6bd85e83ff0f54d90438eb3778c10c8f25f26_40b6bd85e83ff0f54d90438eb3778c10c8f25f26/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/40b6bd85e83ff0f54d90438eb3778c10c8f25f26_40b6bd85e83ff0f54d90438eb3778c10c8f25f26/report/index.html) | Category | Coverage | |---|| | Function Coverage | 55.94% (14922/26675) | | Line Coverage | 44.76% (132386/295776) | | Region Coverage | 43.85% (66603/151889) | | Branch Coverage | 38.44% (34129/88782) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Test](cloud-mow) check delete bitmap key's existence before put KV [doris]
doris-robot commented on PR #51013: URL: https://github.com/apache/doris/pull/51013#issuecomment-2893614990 ClickBench: Total hot run time: 29.65 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 40b6bd85e83ff0f54d90438eb3778c10c8f25f26, data reload: false query1 0.040.030.03 query2 0.160.100.10 query3 0.340.200.20 query4 1.600.220.19 query5 0.480.440.46 query6 1.150.660.67 query7 0.020.010.01 query8 0.050.050.05 query9 0.620.540.53 query10 0.560.590.57 query11 0.260.130.12 query12 0.250.140.14 query13 0.620.630.63 query14 0.800.820.83 query15 0.980.870.87 query16 0.380.360.37 query17 1.061.011.03 query18 0.190.190.18 query19 1.981.851.83 query20 0.010.020.01 query21 15.43 0.970.67 query22 0.941.040.75 query23 14.69 1.610.77 query24 5.160.600.31 query25 0.160.090.08 query26 0.550.230.18 query27 0.090.080.08 query28 11.05 1.210.59 query29 12.58 4.043.39 query30 0.280.080.06 query31 2.840.650.44 query32 3.250.600.49 query33 3.123.203.06 query34 16.69 5.164.40 query35 4.484.524.45 query36 0.620.500.50 query37 0.200.180.17 query38 0.160.160.16 query39 0.040.040.04 query40 0.200.160.16 query41 0.110.060.05 query42 0.060.060.05 query43 0.050.060.05 Total cold run time: 104.3 s Total hot run time: 29.65 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Test](cloud-mow) check delete bitmap key's existence before put KV [doris]
doris-robot commented on PR #51013: URL: https://github.com/apache/doris/pull/51013#issuecomment-2893560476 TPC-H: Total hot run time: 33641 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 40b6bd85e83ff0f54d90438eb3778c10c8f25f26, data reload: false -- Round 1 -- q1 26195 502649354935 q2 2077301 185 185 q3 10459 1234700 700 q4 10228 1001530 530 q5 7666239723672367 q6 177 163 135 135 q7 918 752 613 613 q8 9329129710871087 q9 6801509550175017 q10 6853233719101910 q11 491 283 282 282 q12 351 347 217 217 q13 17773 372730833083 q14 233 242 224 224 q15 528 486 499 486 q16 425 435 370 370 q17 600 858 363 363 q18 7875707372337073 q19 1842967 547 547 q20 344 329 229 229 q21 3714256623202320 q22 10911048968 968 Total cold run time: 115970 ms Total hot run time: 33641 ms - Round 2, with runtime_filter_mode=off - q1 5156501450095009 q2 238 324 231 231 q3 2192268623132313 q4 1317176813641364 q5 4453441744214417 q6 204 167 128 128 q7 2004193817771777 q8 2621252025262520 q9 7308725469336933 q10 3031324427812781 q11 591 514 510 510 q12 680 769 623 623 q13 3485395332573257 q14 281 310 280 280 q15 508 491 477 477 q16 462 532 457 457 q17 1153158513611361 q18 7854761673747374 q19 806 816 862 816 q20 1982205418821882 q21 4810439944074399 q22 1112108010161016 Total cold run time: 52248 ms Total hot run time: 49925 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Test](cloud-mow) check delete bitmap key's existence before put KV [doris]
doris-robot commented on PR #51013: URL: https://github.com/apache/doris/pull/51013#issuecomment-2893407769 # Cloud UT Coverage Report Increment line coverage `0.00% (0/33)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/40b6bd85e83ff0f54d90438eb3778c10c8f25f26_40b6bd85e83ff0f54d90438eb3778c10c8f25f26_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/40b6bd85e83ff0f54d90438eb3778c10c8f25f26_40b6bd85e83ff0f54d90438eb3778c10c8f25f26_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 83.25% (1113/1337) | | Line Coverage | 66.12% (18659/28220) | | Region Coverage | 65.79% (9261/14077) | | Branch Coverage | 55.52% (4977/8964) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Test](cloud-mow) check delete bitmap key's existence before put KV [doris]
bobhan1 commented on PR #51013: URL: https://github.com/apache/doris/pull/51013#issuecomment-2893366523 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Test](cloud-mow) check delete bitmap key's existence before put KV [doris]
doris-robot commented on PR #51013: URL: https://github.com/apache/doris/pull/51013#issuecomment-2893129666 ClickBench: Total hot run time: 29.74 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 3fed39c891f7b557de767462e73b6ef68b5c786e, data reload: false query1 0.040.040.03 query2 0.150.120.10 query3 0.340.210.20 query4 1.600.200.09 query5 0.420.400.40 query6 1.160.660.67 query7 0.020.020.02 query8 0.050.050.05 query9 0.640.510.51 query10 0.590.590.58 query11 0.260.130.13 query12 0.250.130.13 query13 0.640.620.62 query14 0.810.850.82 query15 0.960.870.88 query16 0.370.370.39 query17 1.091.071.05 query18 0.180.180.18 query19 1.981.871.82 query20 0.020.010.01 query21 15.39 0.980.67 query22 0.931.130.90 query23 14.69 1.520.77 query24 5.190.600.31 query25 0.160.080.08 query26 0.560.220.18 query27 0.080.080.08 query28 10.99 1.160.59 query29 12.56 4.103.45 query30 0.280.080.07 query31 2.810.630.41 query32 3.240.600.51 query33 3.103.073.10 query34 16.41 5.074.40 query35 4.474.484.45 query36 0.630.500.51 query37 0.190.170.18 query38 0.170.150.15 query39 0.050.040.04 query40 0.210.170.15 query41 0.110.060.05 query42 0.070.050.06 query43 0.050.050.06 Total cold run time: 103.91 s Total hot run time: 29.74 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Test](cloud-mow) check delete bitmap key's existence before put KV [doris]
doris-robot commented on PR #51013: URL: https://github.com/apache/doris/pull/51013#issuecomment-2893116303 TPC-DS: Total hot run time: 192766 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 3fed39c891f7b557de767462e73b6ef68b5c786e, data reload: false query1 1462108610601060 query2 6368191119181911 query3 11015 465346294629 query4 25401 24103 22960 22960 query5 4295625 463 463 query6 298 209 198 198 query7 3996507 295 295 query8 334 255 241 241 query9 8483262826382628 query10 503 329 263 263 query11 15374 15104 14861 14861 query12 166 110 105 105 query13 1572549 419 419 query14 8823607361266073 query15 215 192 175 175 query16 7172636 474 474 query17 1188711 558 558 query18 1974410 307 307 query19 209 195 185 185 query20 137 131 117 117 query21 206 125 108 108 query22 4479461342984298 query23 34461 33732 33550 33550 query24 8388241224222412 query25 501 498 410 410 query26 1032274 150 150 query27 3004514 344 344 query28 4860224421652165 query29 787 615 476 476 query30 278 226 201 201 query31 906 883 811 811 query32 80 68 68 68 query33 535 408 340 340 query34 800 923 540 540 query35 794 850 777 777 query36 991 1002895 895 query37 119 104 79 79 query38 4267426741994199 query39 1532149114821482 query40 220 125 115 115 query41 60 57 58 57 query42 134 118 142 118 query43 520 522 496 496 query44 1348843 841 841 query45 191 174 179 174 query46 853 1034649 649 query47 1884188618091809 query48 412 440 328 328 query49 762 519 430 430 query50 662 694 422 422 query51 4321424942784249 query52 110 110 97 97 query53 226 258 187 187 query54 612 576 543 543 query55 92 83 85 83 query56 321 288 302 288 query57 1183122611521152 query58 282 272 270 270 query59 2910286928292829 query60 360 327 321 321 query61 126 123 127 123 query62 762 733 699 699 query63 242 195 192 192 query64 38401073707 707 query65 4549444743264326 query66 1042392 320 320 query67 15777 15661 15471 15471 query68 8533886 525 525 query69 520 309 280 280 query70 1290109310931093 query71 473 326 306 306 query72 5897475247604752 query73 703 615 362 362 query74 8921914886408640 query75 3896316726782678 query76 37161177756 756 query77 777 440 294 294 query78 10044 10152 94199419 query79 2102894 583 583 query80 661 509 441 441 query81 482 263 225 225 query82 420 126 96 96 query83 281 258 236 236 query84 280 112 90 90 query85 774 410 307 307 query86 342 289 274 274 query87 4513446342774277 query88 2907234523182318 query89 405 319 294 294 query90 1861211 202 202 query91 152 139 113 113 query92 70 67 56 56 query93 1198941 581 581 query94 671 415 304 304 query95 378 306 301 301 query96 496 582 295 295 query97 2729277326322632 query98 225 208 208 208 query99 1422139313051305 Total cold run time: 277945 ms Total hot run time: 192766 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [Test](cloud-mow) check delete bitmap key's existence before put KV [doris]
doris-robot commented on PR #51013: URL: https://github.com/apache/doris/pull/51013#issuecomment-2893092718 TPC-H: Total hot run time: 33997 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 3fed39c891f7b557de767462e73b6ef68b5c786e, data reload: false -- Round 1 -- q1 26405 509050275027 q2 2098274 198 198 q3 10593 1275734 734 q4 10249 1007521 521 q5 7850239523372337 q6 189 168 136 136 q7 933 789 649 649 q8 9327129411041104 q9 6701506050945060 q10 6834230218971897 q11 491 291 300 291 q12 361 351 217 217 q13 17780 370330703070 q14 230 227 207 207 q15 541 493 505 493 q16 450 432 386 386 q17 601 881 368 368 q18 7672724471207120 q19 1415945 592 592 q20 342 360 235 235 q21 3775341723822382 q22 10261017973 973 Total cold run time: 115863 ms Total hot run time: 33997 ms - Round 2, with runtime_filter_mode=off - q1 5299514851535148 q2 235 336 235 235 q3 2189265723282328 q4 1345179314171417 q5 44914464 q6 220 170 130 130 q7 2011191918121812 q8 2605255225512551 q9 7186716269246924 q10 3077321927192719 q11 578 511 487 487 q12 657 761 584 584 q13 3505391033323332 q14 294 291 271 271 q15 522 474 488 474 q16 443 476 443 443 q17 1159150014291429 q18 7773764573547354 q19 870 908 1087908 q20 2008210618801880 q21 4811456344314431 q22 1095107110071007 Total cold run time: 52373 ms Total hot run time: 50308 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Test](cloud-mow) check delete bitmap key's existence before put KV [doris]
bobhan1 commented on PR #51013: URL: https://github.com/apache/doris/pull/51013#issuecomment-2892859943 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Test](cloud-mow) check delete bitmap key's existence before put KV [doris]
zhannngchen commented on code in PR #51013: URL: https://github.com/apache/doris/pull/51013#discussion_r2096782723 ## be/src/common/config.cpp: ## @@ -1493,6 +1493,8 @@ DEFINE_mBool(enable_compaction_pause_on_high_memory, "true"); DEFINE_mBool(enable_calc_delete_bitmap_between_segments_concurrently, "false"); +DEFINE_mBool(enable_update_delete_bitmap_kv_check_core, "true"); Review Comment: should default false -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Test](cloud-mow) check delete bitmap key's existence before put KV [doris]
Thearas commented on PR #51013: URL: https://github.com/apache/doris/pull/51013#issuecomment-2889538412 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
