Re: [PR] [bug](function) fix array_map cause coredump as NULL [doris]
HappenLee merged PR #51618: URL: https://github.com/apache/doris/pull/51618 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bug](function) fix array_map cause coredump as NULL [doris]
github-actions[bot] commented on PR #51618: URL: https://github.com/apache/doris/pull/51618#issuecomment-2969088659 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bug](function) fix array_map cause coredump as NULL [doris]
github-actions[bot] commented on PR #51618: URL: https://github.com/apache/doris/pull/51618#issuecomment-2969088512 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bug](function) fix array_map cause coredump as NULL [doris]
hello-stephen commented on PR #51618: URL: https://github.com/apache/doris/pull/51618#issuecomment-2961303514 # BE Regression && UT Coverage Report Increment line coverage `100.00% (27/27)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/51618_5197cd6cc80285bb9cdd9ec532ba7c8c1028f5c1_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/51618_5197cd6cc80285bb9cdd9ec532ba7c8c1028f5c1_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 79.78% (20992/26311) | | Line Coverage | 72.74% (216901/298182) | | Region Coverage | 70.94% (127815/180169) | | Branch Coverage | 64.63% (66174/102384) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bug](function) fix array_map cause coredump as NULL [doris]
doris-robot commented on PR #51618: URL: https://github.com/apache/doris/pull/51618#issuecomment-2961226058 # BE UT Coverage Report Increment line coverage `0.00% (0/27)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/5197cd6cc80285bb9cdd9ec532ba7c8c1028f5c1_5197cd6cc80285bb9cdd9ec532ba7c8c1028f5c1/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/5197cd6cc80285bb9cdd9ec532ba7c8c1028f5c1_5197cd6cc80285bb9cdd9ec532ba7c8c1028f5c1/report/index.html) | Category | Coverage | |---|| | Function Coverage | 56.39% (15076/26733) | | Line Coverage | 45.14% (134672/298332) | | Region Coverage | 44.25% (67767/153163) | | Branch Coverage | 38.80% (34755/89564) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bug](function) fix array_map cause coredump as NULL [doris]
doris-robot commented on PR #51618: URL: https://github.com/apache/doris/pull/51618#issuecomment-2961151043 ClickBench: Total hot run time: 29.27 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 5197cd6cc80285bb9cdd9ec532ba7c8c1028f5c1, data reload: false query1 0.040.030.04 query2 0.120.100.11 query3 0.250.200.18 query4 1.590.200.20 query5 0.460.440.45 query6 1.180.670.66 query7 0.020.020.02 query8 0.050.040.03 query9 0.580.510.53 query10 0.570.570.55 query11 0.170.110.10 query12 0.150.120.12 query13 0.620.600.60 query14 0.790.800.80 query15 0.870.870.86 query16 0.370.380.37 query17 1.041.041.04 query18 0.240.210.21 query19 1.881.901.87 query20 0.010.000.01 query21 15.42 0.930.55 query22 0.751.220.72 query23 14.85 1.370.62 query24 7.021.840.79 query25 0.470.310.06 query26 0.460.160.14 query27 0.050.060.05 query28 9.180.890.43 query29 12.55 4.013.31 query30 0.260.090.07 query31 2.840.600.40 query32 3.230.570.46 query33 3.153.113.06 query34 15.82 5.144.54 query35 4.584.604.56 query36 0.670.500.49 query37 0.090.060.07 query38 0.050.040.04 query39 0.030.020.03 query40 0.170.140.13 query41 0.080.020.02 query42 0.030.030.03 query43 0.040.030.03 Total cold run time: 102.79 s Total hot run time: 29.27 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bug](function) fix array_map cause coredump as NULL [doris]
doris-robot commented on PR #51618: URL: https://github.com/apache/doris/pull/51618#issuecomment-2961145300 TPC-DS: Total hot run time: 193020 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 5197cd6cc80285bb9cdd9ec532ba7c8c1028f5c1, data reload: false query1 1397108710591059 query2 6441182217931793 query3 11148 464445824582 query4 25304 23731 23005 23005 query5 4260640 460 460 query6 312 222 215 215 query7 4020494 284 284 query8 270 225 206 206 query9 8478260826252608 query10 474 335 270 270 query11 15056 15098 14788 14788 query12 151 108 106 106 query13 1559546 402 402 query14 8270607760546054 query15 198 192 178 178 query16 7220652 519 519 query17 1201720 586 586 query18 1977450 327 327 query19 205 210 178 178 query20 127 122 123 122 query21 215 143 114 114 query22 4709483844644464 query23 35147 33915 33963 33915 query24 8567241524412415 query25 523 462 399 399 query26 1159268 152 152 query27 2812520 337 337 query28 4381221321862186 query29 731 654 446 446 query30 270 235 202 202 query31 876 877 829 829 query32 76 65 65 65 query33 529 369 318 318 query34 834 878 556 556 query35 799 835 754 754 query36 980 1009900 900 query37 109 118 81 81 query38 4243425943514259 query39 1684146814801468 query40 207 117 110 110 query41 59 55 53 53 query42 127 109 114 109 query43 513 506 485 485 query44 1330830 836 830 query45 186 173 175 173 query46 888 1035671 671 query47 1869189618401840 query48 404 419 322 322 query49 715 499 428 428 query50 684 696 396 396 query51 4231424942424242 query52 116 109 107 107 query53 221 256 190 190 query54 581 583 530 530 query55 85 82 84 82 query56 307 313 285 285 query57 1225122811601160 query58 268 265 257 257 query59 2846276727222722 query60 339 333 333 333 query61 151 118 124 118 query62 781 764 659 659 query63 223 196 193 193 query64 41371034706 706 query65 4375428843034288 query66 1140463 306 306 query67 16155 15825 15391 15391 query68 8739893 524 524 query69 475 309 269 269 query70 1207108810881088 query71 461 329 295 295 query72 5832478549144785 query73 726 681 363 363 query74 8961929587988798 query75 3855320726782678 query76 37241193748 748 query77 787 375 286 286 query78 10084 10057 94619461 query79 4184775 570 570 query80 649 511 442 442 query81 479 255 219 219 query82 581 131 97 97 query83 278 253 237 237 query84 296 112 88 88 query85 800 358 309 309 query86 350 315 279 279 query87 4491444543604360 query88 3374228423152284 query89 442 327 292 292 query90 1963283 214 214 query91 140 152 111 111 query92 78 59 63 59 query93 3181958 570 570 query94 667 403 302 302 query95 375 294 285 285 query96 498 586 284 284 query97 2750278426712671 query98 229 201 196 196 query99 1437138512681268 Total cold run time: 282968 ms Total hot run time: 193020 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [bug](function) fix array_map cause coredump as NULL [doris]
doris-robot commented on PR #51618: URL: https://github.com/apache/doris/pull/51618#issuecomment-2961132283 TPC-H: Total hot run time: 33556 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 5197cd6cc80285bb9cdd9ec532ba7c8c1028f5c1, data reload: false -- Round 1 -- q1 26239 507449974997 q2 1966280 178 178 q3 10294 1262679 679 q4 10226 1017509 509 q5 7507240322782278 q6 181 158 126 126 q7 916 704 584 584 q8 9293124410981098 q9 6886514750835083 q10 6922234919381938 q11 490 293 291 291 q12 338 352 222 222 q13 18287 365130633063 q14 235 235 214 214 q15 563 489 491 489 q16 419 430 370 370 q17 574 824 363 363 q18 7584710370107010 q19 1852989 543 543 q20 323 323 215 215 q21 3662256223282328 q22 10831000978 978 Total cold run time: 115840 ms Total hot run time: 33556 ms - Round 2, with runtime_filter_mode=off - q1 5118504750045004 q2 236 315 217 217 q3 2149261722952295 q4 1310173113441344 q5 4389442644124412 q6 220 168 122 122 q7 2047193717681768 q8 2587260324912491 q9 7297724470477047 q10 2999319527392739 q11 568 499 502 499 q12 686 764 609 609 q13 3500384032713271 q14 295 317 303 303 q15 540 491 482 482 q16 446 492 440 440 q17 1135152614081408 q18 7661763274167416 q19 783 830 834 830 q20 2021198118271827 q21 4813448345924483 q22 1121106410231023 Total cold run time: 51921 ms Total hot run time: 50030 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bug](function) fix array_map cause coredump as NULL [doris]
zhangstar333 commented on PR #51618: URL: https://github.com/apache/doris/pull/51618#issuecomment-2961096762 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bug](function) fix array_map cause coredump as NULL [doris]
HappenLee commented on code in PR #51618:
URL: https://github.com/apache/doris/pull/51618#discussion_r2138055956
##
be/src/vec/exprs/lambda_function/varray_map_function.cpp:
##
@@ -186,6 +186,39 @@ class ArrayMapFunction : public LambdaFunction {
data_types.push_back(col_type.get_nested_type());
}
+ColumnWithTypeAndName result_arr;
+// if column_array is NULL, we know the array_data_column will not
write any data,
+// so the column is empty. eg : (x) -> concat('|',x + "1"). if still
execute the lambda function, will cause the bolck rows are not equal
+// the x column is empty, but "|" is const literal, size of column is
1, so the block rows is 1, but the x column is empty, will be coredump.
+if (std::any_of(lambda_datas.begin(), lambda_datas.end(),
+[](const auto& v) { return v->empty(); })) {
+DataTypePtr nested_type;
+bool is_nullable = result_type->is_nullable();
+if (is_nullable) {
+nested_type =
+assert_cast(result_type.get())->get_nested_type();
+} else {
+nested_type = result_type;
+}
+auto empty_nested_column = assert_cast(nested_type.get())
+ ->get_nested_type()
+ ->create_column();
+auto result_array_column =
ColumnArray::create(std::move(empty_nested_column),
+
std::move(array_column_offset));
+
+if (is_nullable) {
+result_arr =
{ColumnNullable::create(std::move(result_array_column),
+
std::move(outside_null_map)),
+ result_type, "Result"};
+} else {
+result_arr = {std::move(result_array_column), result_type,
"Result"};
Review Comment:
should add a case test the code line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bug](function) fix array_map cause coredump as NULL [doris]
Thearas commented on PR #51618: URL: https://github.com/apache/doris/pull/51618#issuecomment-2959044714 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
