Re: [PR] [bug](s3) fix S3 file system gets absolute path [doris]

2024-12-09 Thread via GitHub


GoGoWen merged PR #44965:
URL: https://github.com/apache/doris/pull/44965


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [bug](s3) fix S3 file system gets absolute path [doris]

2024-12-08 Thread via GitHub


github-actions[bot] commented on PR #44965:
URL: https://github.com/apache/doris/pull/44965#issuecomment-2527136253

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [bug](s3) fix S3 file system gets absolute path [doris]

2024-12-08 Thread via GitHub


github-actions[bot] commented on PR #44965:
URL: https://github.com/apache/doris/pull/44965#issuecomment-2527136312

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [bug](s3) fix S3 file system gets absolute path [doris]

2024-12-04 Thread via GitHub


DarvenDuan commented on PR #44965:
URL: https://github.com/apache/doris/pull/44965#issuecomment-2516467439

   run cloud_p0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [bug](s3) fix S3 file system gets absolute path [doris]

2024-12-03 Thread via GitHub


doris-robot commented on PR #44965:
URL: https://github.com/apache/doris/pull/44965#issuecomment-2516148668

   TeamCity be ut coverage result:
Function Coverage: 38.51% (10009/25990) 
Line Coverage: 29.50% (83796/284075)
Region Coverage: 28.63% (43109/150580)
Branch Coverage: 25.23% (21910/86834)
Coverage Report: 
http://coverage.selectdb-in.cc/coverage/c45f3651e277e56bc2b2795e334a9c3f0169cf83_c45f3651e277e56bc2b2795e334a9c3f0169cf83/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [bug](s3) fix S3 file system gets absolute path [doris]

2024-12-03 Thread via GitHub


doris-robot commented on PR #44965:
URL: https://github.com/apache/doris/pull/44965#issuecomment-2516108441

   
   
   ClickBench: Total hot run time: 33.03 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit c45f3651e277e56bc2b2795e334a9c3f0169cf83, 
data reload: false
   
   query1   0.030.040.03
   query2   0.060.040.03
   query3   0.230.080.06
   query4   1.620.100.11
   query5   0.420.400.43
   query6   1.150.660.66
   query7   0.020.020.01
   query8   0.040.030.03
   query9   0.570.510.49
   query10  0.550.560.56
   query11  0.140.100.11
   query12  0.150.110.11
   query13  0.620.620.61
   query14  2.702.742.77
   query15  0.890.820.82
   query16  0.390.390.38
   query17  1.011.061.06
   query18  0.230.220.22
   query19  1.951.801.98
   query20  0.020.010.01
   query21  15.35   0.610.59
   query22  2.472.321.92
   query23  17.05   1.010.83
   query24  3.371.262.41
   query25  0.120.230.06
   query26  0.720.130.14
   query27  0.060.040.05
   query28  9.291.101.08
   query29  12.54   3.233.27
   query30  0.250.060.06
   query31  2.850.380.38
   query32  3.280.470.46
   query33  3.023.083.06
   query34  16.85   4.504.48
   query35  4.544.454.44
   query36  0.660.480.50
   query37  0.090.060.06
   query38  0.040.030.03
   query39  0.040.020.03
   query40  0.160.130.13
   query41  0.080.020.02
   query42  0.030.030.02
   query43  0.040.030.03
   Total cold run time: 105.69 s
   Total hot run time: 33.03 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [bug](s3) fix S3 file system gets absolute path [doris]

2024-12-03 Thread via GitHub


doris-robot commented on PR #44965:
URL: https://github.com/apache/doris/pull/44965#issuecomment-2516103984

   
   
   TPC-DS: Total hot run time: 198303 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit c45f3651e277e56bc2b2795e334a9c3f0169cf83, 
data reload: false
   
   query1   1241988 930 930
   query2   6225203519811981
   query3   10972   437943824379
   query4   67237   28870   23948   23948
   query5   4960476 460 460
   query6   402 186 187 186
   query7   5523315 299 299
   query8   320 240 240 240
   query9   8495270427002700
   query10  440 252 254 252
   query11  17093   15296   16146   15296
   query12  156 102 107 102
   query13  1439446 440 440
   query14  10868   749572697269
   query15  205 193 195 193
   query16  7069476 473 473
   query17  1053585 581 581
   query18  1728301 300 300
   query19  200 143 185 143
   query20  119 111 112 111
   query21  209 111 106 106
   query22  4727461347184613
   query23  35104   34525   34546   34525
   query24  5475253625272527
   query25  486 383 393 383
   query26  643 163 158 158
   query27  2027295 294 294
   query28  4603249724572457
   query29  675 423 418 418
   query30  220 151 150 150
   query31  1006840 845 840
   query32  69  60  67  60
   query33  413 284 289 284
   query34  957 530 510 510
   query35  876 758 748 748
   query36  1078943 959 943
   query37  129 78  105 78
   query38  4409447644914476
   query39  1537148314871483
   query40  203 104 101 101
   query41  52  44  47  44
   query42  111 100 96  96
   query43  543 496 478 478
   query44  1213846 836 836
   query45  182 169 169 169
   query46  1191718 720 718
   query47  2090195719441944
   query48  416 327 325 325
   query49  709 405 399 399
   query50  929 405 384 384
   query51  7350721170877087
   query52  101 93  87  87
   query53  253 173 176 173
   query54  522 403 390 390
   query55  75  73  80  73
   query56  251 224 223 223
   query57  1278111711421117
   query58  215 209 226 209
   query59  3131308330193019
   query60  283 242 240 240
   query61  104 109 107 107
   query62  834 680 664 664
   query63  217 183 197 183
   query64  1371675 686 675
   query65  3324320431913191
   query66  701 300 306 300
   query67  15900   15724   15916   15724
   query68  4267589 555 555
   query69  424 256 263 256
   query70  1123113010471047
   query71  356 244 253 244
   query72  6415420140574057
   query73  799 364 362 362
   query74  10352   905389588958
   query75  3401266426702664
   query76  1829107011391070
   query77  502 268 264 264
   query78  10374   941394829413
   query79  1980616 646 616
   query80  1394426 423 423
   query81  517 236 231 231
   query82  1280116 123 116
   query83  258 151 137 137
   query84  278 70  70  70
   query85  1033312 312 312
   query86  407 303 302 302
   query87  4691469445814581
   query88  3509226121722172
   query89  415 300 284 284
   query90  1969189 191 189
   query91  134 104 106 104
   query92  60  47  51  47
   query93  2748550 548 548
   query94  837 287 288 287
   query95  348 251 249 249
   query96  644 278 278 278
   query97  2824265426962654
   query98  217 196 195 195
   query99  1611133513261326
   Total cold run time: 320933 ms
   Total hot run time: 198303 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t

Re: [PR] [bug](s3) fix S3 file system gets absolute path [doris]

2024-12-03 Thread via GitHub


doris-robot commented on PR #44965:
URL: https://github.com/apache/doris/pull/44965#issuecomment-2516092058

   
   
   TPC-H: Total hot run time: 40315 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit c45f3651e277e56bc2b2795e334a9c3f0169cf83, 
data reload: false
   
   -- Round 1 --
   q1   17568   756873387338
   q2   2043173 177 173
   q3   10604   112811841128
   q4   10554   769 744 744
   q5   7635277127212721
   q6   240 155 148 148
   q7   993 615 594 594
   q8   9250188319611883
   q9   6785652465036503
   q10  7035232823342328
   q11  461 263 258 258
   q12  417 227 219 219
   q13  17775   303230153015
   q14  253 206 211 206
   q15  572 540 512 512
   q16  673 582 585 582
   q17  1004531 624 531
   q18  7406666967896669
   q19  1324101410631014
   q20  455 184 178 178
   q21  4007325532583255
   q22  371 316 324 316
   Total cold run time: 107425 ms
   Total hot run time: 40315 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   7274727772957277
   q2   333 246 229 229
   q3   2925290228842884
   q4   2175181718961817
   q5   5668571656945694
   q6   221 144 138 138
   q7   2265180818021802
   q8   3461357335393539
   q9   9065909989598959
   q10  3603357835383538
   q11  594 512 497 497
   q12  799 596 632 596
   q13  11193   323331993199
   q14  314 290 288 288
   q15  581 527 521 521
   q16  676 650 652 650
   q17  1885165016431643
   q18  8318789875437543
   q19  1741166316211621
   q20  2116183918671839
   q21  5620544955035449
   q22  659 615 574 574
   Total cold run time: 71486 ms
   Total hot run time: 60297 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [bug](s3) fix S3 file system gets absolute path [doris]

2024-12-03 Thread via GitHub


DarvenDuan commented on code in PR #44965:
URL: https://github.com/apache/doris/pull/44965#discussion_r186862


##
be/src/io/fs/s3_file_system.h:
##
@@ -121,7 +121,7 @@ class S3FileSystem final : public RemoteFileSystem {
 abs_path = path;
 } else {
 // path with no schema
-abs_path = _root_path / path;
+abs_path = _prefix / path;

Review Comment:
   _prefix is normalized in constructor, it is removed the first and last '/'



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [bug](s3) fix S3 file system gets absolute path [doris]

2024-12-03 Thread via GitHub


DarvenDuan commented on PR #44965:
URL: https://github.com/apache/doris/pull/44965#issuecomment-2516030034

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [bug](s3) fix S3 file system gets absolute path [doris]

2024-12-03 Thread via GitHub


DarvenDuan commented on code in PR #44965:
URL: https://github.com/apache/doris/pull/44965#discussion_r186862


##
be/src/io/fs/s3_file_system.h:
##
@@ -121,7 +121,7 @@ class S3FileSystem final : public RemoteFileSystem {
 abs_path = path;
 } else {
 // path with no schema
-abs_path = _root_path / path;
+abs_path = _prefix / path;

Review Comment:
   _prefix is normalized in S3FileSystem's constructor, removed the first and 
last '/'



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [bug](s3) fix S3 file system gets absolute path [doris]

2024-12-03 Thread via GitHub


doris-robot commented on PR #44965:
URL: https://github.com/apache/doris/pull/44965#issuecomment-2516025188

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting 
information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it 
now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and 
after the optimization?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org