Re: [PR] [chore](Mysql) remove unused code in MysqlResultWriter [doris]
yiguolei merged PR #58699: URL: https://github.com/apache/doris/pull/58699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [chore](Mysql) remove unused code in MysqlResultWriter [doris]
github-actions[bot] commented on PR #58699: URL: https://github.com/apache/doris/pull/58699#issuecomment-3615132050 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [chore](Mysql) remove unused code in MysqlResultWriter [doris]
Mryange commented on PR #58699: URL: https://github.com/apache/doris/pull/58699#issuecomment-3614777091 run external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [chore](Mysql) remove unused code in MysqlResultWriter [doris]
hello-stephen commented on PR #58699: URL: https://github.com/apache/doris/pull/58699#issuecomment-3613958110 # BE Regression && UT Coverage Report Increment line coverage `71.79% (28/39)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58699_c0e08b5ea4014c7251aed5b2f62c921870998dbd_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58699_c0e08b5ea4014c7251aed5b2f62c921870998dbd_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 72.14% (24709/34252) | | Line Coverage | 58.84% (259328/440705) | | Region Coverage | 53.78% (215710/401122) | | Branch Coverage | 55.30% (92181/166683) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [chore](Mysql) remove unused code in MysqlResultWriter [doris]
hello-stephen commented on PR #58699: URL: https://github.com/apache/doris/pull/58699#issuecomment-3613936892 # BE UT Coverage Report Increment line coverage `17.95% (7/39)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/c0e08b5ea4014c7251aed5b2f62c921870998dbd_c0e08b5ea4014c7251aed5b2f62c921870998dbd/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/c0e08b5ea4014c7251aed5b2f62c921870998dbd_c0e08b5ea4014c7251aed5b2f62c921870998dbd/report/index.html) | Category | Coverage | |---|| | Function Coverage | 53.35% (18634/34931) | | Line Coverage | 39.02% (172125/441090) | | Region Coverage | 33.65% (133342/396303) | | Branch Coverage | 34.61% (57371/165784) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [chore](Mysql) remove unused code in MysqlResultWriter [doris]
Mryange commented on PR #58699: URL: https://github.com/apache/doris/pull/58699#issuecomment-3612898334 run external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [chore](Mysql) remove unused code in MysqlResultWriter [doris]
Mryange commented on PR #58699: URL: https://github.com/apache/doris/pull/58699#issuecomment-3612896915 run beut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [chore](Mysql) remove unused code in MysqlResultWriter [doris]
doris-robot commented on PR #58699: URL: https://github.com/apache/doris/pull/58699#issuecomment-3611743808 ClickBench: Total hot run time: 28.05 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit c0e08b5ea4014c7251aed5b2f62c921870998dbd, data reload: false query1 0.050.050.05 query2 0.110.050.05 query3 0.260.090.09 query4 1.610.120.10 query5 0.260.270.26 query6 1.160.650.63 query7 0.030.030.03 query8 0.060.040.04 query9 0.570.530.51 query10 0.580.580.56 query11 0.170.110.12 query12 0.150.110.12 query13 0.630.620.60 query14 0.990.980.99 query15 0.860.800.80 query16 0.400.400.40 query17 1.061.131.05 query18 0.240.220.22 query19 1.841.901.89 query20 0.020.020.02 query21 15.45 0.280.13 query22 4.500.060.04 query23 15.94 0.310.10 query24 1.350.780.96 query25 0.100.050.09 query26 0.150.140.13 query27 0.070.040.07 query28 6.021.231.02 query29 12.60 4.043.21 query30 0.270.140.13 query31 2.820.630.39 query32 3.220.550.48 query33 3.033.113.12 query34 16.94 5.224.56 query35 4.584.604.56 query36 0.670.520.49 query37 0.110.070.06 query38 0.080.040.04 query39 0.040.030.02 query40 0.170.140.13 query41 0.090.020.03 query42 0.040.030.03 query43 0.040.030.04 Total cold run time: 99.33 s Total hot run time: 28.05 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [chore](Mysql) remove unused code in MysqlResultWriter [doris]
doris-robot commented on PR #58699: URL: https://github.com/apache/doris/pull/58699#issuecomment-3611716692 TPC-DS: Total hot run time: 181465 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit c0e08b5ea4014c7251aed5b2f62c921870998dbd, data reload: false query5 4694651 494 494 query6 351 242 222 222 query7 4680475 278 278 query8 310 261 251 251 query9 8735267626872676 query10 519 325 287 287 query11 15498 15009 15219 15009 query12 192 122 120 120 query13 1693515 377 377 query14 6257332130513051 query14_12916296729702967 query15 213 195 201 195 query16 7490508 468 468 query17 1261765 641 641 query18 2059438 348 348 query19 223 207 168 168 query20 131 121 124 121 query21 225 141 114 114 query22 3960404040344034 query23 16765 16319 16153 16153 query23_116057 16126 16106 16106 query24 7282164012401240 query24_11242122912551229 query25 688 511 461 461 query26 1275285 182 182 query27 2884500 324 324 query28 4417225622662256 query29 864 619 489 489 query30 323 249 220 220 query31 847 741 627 627 query32 90 76 74 74 query33 693 362 319 319 query34 886 936 608 608 query35 809 837 745 745 query36 904 913 854 854 query37 129 94 80 80 query38 3911391139103910 query39 762 730 724 724 query39_1699 698 702 698 query40 230 136 124 124 query41 67 64 63 63 query42 128 99 104 99 query43 438 438 382 382 query44 1374763 776 763 query45 202 193 184 184 query46 940 988 603 603 query47 1686172416021602 query48 407 342 239 239 query49 770 439 377 377 query50 715 316 243 243 query51 3846384538763845 query52 123 99 91 91 query53 254 247 182 182 query54 327 273 244 244 query55 104 87 78 78 query56 347 301 311 301 query57 1203114110941094 query58 305 270 264 264 query59 2344242424092409 query60 379 330 321 321 query61 160 159 161 159 query62 780 704 631 631 query63 239 182 184 182 query64 45101208905 905 query65 4040400939983998 query66 1227458 345 345 query67 15522 15261 15011 15011 query68 81441001677 677 query69 530 302 273 273 query70 11501014994 994 query71 468 301 281 281 query72 6006498948894889 query73 695 572 306 306 query74 8693885786908690 query75 3435305825812581 query76 34881187767 767 query77 813 418 306 306 query78 9549972187878787 query79 1671903 611 611 query80 671 581 478 478 query81 522 276 234 234 query82 493 132 105 105 query83 297 275 259 259 query84 265 127 97 97 query85 982 501 463 463 query86 391 300 313 300 query87 4052408639393939 query88 4065220021822182 query89 399 324 290 290 query90 2110171 161 161 query91 180 165 148 148 query92 88 73 70 70 query93 16461103717 717 query94 757 299 301 299 query95 593 397 342 342 query96 573 513 221 221 query97 2666268325862586 query98 251 210 208 208 query99 1378131812791279 Total cold run time: 272859 ms Total hot run time: 181465 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t
Re: [PR] [chore](Mysql) remove unused code in MysqlResultWriter [doris]
doris-robot commented on PR #58699: URL: https://github.com/apache/doris/pull/58699#issuecomment-3611666521 TPC-H: Total hot run time: 34647 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit c0e08b5ea4014c7251aed5b2f62c921870998dbd, data reload: false -- Round 1 -- q1 17622 508049684968 q2 2111316 195 195 q3 10237 1347726 726 q4 10236 963 330 330 q5 7564249222162216 q6 201 174 140 140 q7 985 806 644 644 q8 9359147611241124 q9 7302537354355373 q10 6883223817991799 q11 534 314 299 299 q12 375 379 242 242 q13 1 366530493049 q14 238 248 229 229 q15 597 520 513 513 q16 893 875 800 800 q17 699 809 537 537 q18 7725717871517151 q19 11011000621 621 q20 396 359 232 232 q21 3995319825132513 q22 10561030946 946 Total cold run time: 107886 ms Total hot run time: 34647 ms - Round 2, with runtime_filter_mode=off - q1 5015500950195009 q2 360 405 314 314 q3 2169268523212321 q4 1329178513281328 q5 4285452845734528 q6 225 180 137 137 q7 2079202518351835 q8 2729260125872587 q9 7625758176237581 q10 3077326828412841 q11 599 535 497 497 q12 736 822 639 639 q13 3651397332793279 q14 278 329 273 273 q15 560 526 516 516 q16 912 940 876 876 q17 1259153914411441 q18 8054760476077604 q19 938 877 926 877 q20 2013202718261826 q21 4608434741204120 q22 11121021970 970 Total cold run time: 53613 ms Total hot run time: 51399 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [chore](Mysql) remove unused code in MysqlResultWriter [doris]
Mryange commented on PR #58699: URL: https://github.com/apache/doris/pull/58699#issuecomment-368480 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [chore](Mysql) remove unused code in MysqlResultWriter [doris]
github-actions[bot] commented on PR #58699: URL: https://github.com/apache/doris/pull/58699#issuecomment-361069 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [chore](Mysql) remove unused code in MysqlResultWriter [doris]
github-actions[bot] commented on PR #58699: URL: https://github.com/apache/doris/pull/58699#issuecomment-3610666565 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [chore](Mysql) remove unused code in MysqlResultWriter [doris]
doris-robot commented on PR #58699: URL: https://github.com/apache/doris/pull/58699#issuecomment-3610417279 ClickBench: Total hot run time: 27.21 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 08c56d0584535fcc8749a0d5eff874dbb373906a, data reload: false query1 0.050.050.05 query2 0.110.050.05 query3 0.260.090.09 query4 1.610.120.11 query5 0.270.250.27 query6 1.180.650.64 query7 0.030.030.03 query8 0.050.040.04 query9 0.570.510.50 query10 0.560.560.54 query11 0.160.110.11 query12 0.160.110.11 query13 0.630.600.60 query14 0.970.970.98 query15 0.810.780.81 query16 0.370.420.41 query17 1.031.000.97 query18 0.250.210.20 query19 1.901.881.73 query20 0.020.010.01 query21 15.46 0.280.13 query22 4.790.050.05 query23 16.15 0.290.10 query24 0.980.540.29 query25 0.070.100.05 query26 0.140.140.13 query27 0.060.060.05 query28 3.301.231.01 query29 12.58 4.083.26 query30 0.270.140.12 query31 2.830.630.40 query32 3.230.540.45 query33 3.053.073.12 query34 16.76 5.204.52 query35 4.534.564.55 query36 0.660.500.49 query37 0.100.070.06 query38 0.080.050.04 query39 0.050.030.03 query40 0.160.140.13 query41 0.090.040.03 query42 0.040.030.03 query43 0.040.040.03 Total cold run time: 96.41 s Total hot run time: 27.21 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [chore](Mysql) remove unused code in MysqlResultWriter [doris]
doris-robot commented on PR #58699: URL: https://github.com/apache/doris/pull/58699#issuecomment-3610399550 TPC-DS: Total hot run time: 181711 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 08c56d0584535fcc8749a0d5eff874dbb373906a, data reload: false query5 4600649 488 488 query6 350 237 219 219 query7 4666515 305 305 query8 299 255 248 248 query9 8733263326342633 query10 503 378 304 304 query11 15228 14910 14986 14910 query12 176 117 113 113 query13 1690560 467 467 query14 6173329130413041 query14_12892293329172917 query15 216 203 179 179 query16 7332691 519 519 query17 1214756 615 615 query18 2014437 336 336 query19 213 243 177 177 query20 125 121 119 119 query21 210 139 109 109 query22 3849394739083908 query23 16594 16176 15850 15850 query23_116073 15946 16084 15946 query24 6924162212171217 query24_11198121112201211 query25 633 522 460 460 query26 1250284 164 164 query27 2739503 347 347 query28 4396216621372137 query29 798 681 486 486 query30 322 246 214 214 query31 865 711 606 606 query32 81 77 74 74 query33 601 371 330 330 query34 824 891 543 543 query35 783 838 745 745 query36 868 917 846 846 query37 124 110 88 88 query38 3789382337403740 query39 756 887 719 719 query39_1697 701 685 685 query40 222 130 125 125 query41 67 62 65 62 query42 125 122 115 115 query43 431 447 413 413 query44 1370756 756 756 query45 212 205 192 192 query46 900 1002657 657 query47 1669173316051605 query48 402 434 334 334 query49 769 497 405 405 query50 683 692 428 428 query51 3886388038553855 query52 114 116 107 107 query53 246 257 193 193 query54 303 288 289 288 query55 99 97 92 92 query56 326 337 354 337 query57 1137117511021102 query58 298 287 295 287 query59 2303232122992299 query60 369 364 354 354 query61 187 187 189 187 query62 772 717 681 681 query63 245 202 214 202 query64 4675131610071007 query65 4072397340103973 query66 1183457 347 347 query67 15164 14952 14620 14620 query68 82021008651 651 query69 525 360 311 311 query70 1124107810291029 query71 432 367 334 334 query72 6245508850685068 query73 730 658 347 347 query74 8569879685778577 query75 3020302325502550 query76 32981134767 767 query77 511 423 329 329 query78 9405978188568856 query79 2274867 599 599 query80 646 569 516 516 query81 521 289 250 250 query82 360 137 110 110 query83 271 267 258 258 query84 261 120 94 94 query85 981 482 453 453 query86 381 315 307 307 query87 4020404139533953 query88 4224229223092292 query89 403 331 293 293 query90 1880240 223 223 query91 170 176 140 140 query92 87 76 65 65 query93 19191040683 683 query94 733 457 351 351 query95 508 406 430 406 query96 546 562 283 283 query97 2661269325562556 query98 256 219 219 219 query99 1320140212781278 Total cold run time: 268967 ms Total hot run time: 181711 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [chore](Mysql) remove unused code in MysqlResultWriter [doris]
doris-robot commented on PR #58699: URL: https://github.com/apache/doris/pull/58699#issuecomment-3610362314 TPC-H: Total hot run time: 34202 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 08c56d0584535fcc8749a0d5eff874dbb373906a, data reload: false -- Round 1 -- q1 17686 531648524852 q2 2055331 209 209 q3 10233 1329747 747 q4 10234 832 313 313 q5 7540248021392139 q6 185 171 136 136 q7 960 788 633 633 q8 9365141611501150 q9 7130530953185309 q10 6881219817591759 q11 528 313 282 282 q12 388 368 221 221 q13 17804 365929962996 q14 237 235 236 235 q15 605 516 508 508 q16 876 849 816 816 q17 668 837 503 503 q18 7542710771437107 q19 1096977 604 604 q20 359 353 224 224 q21 4055336825032503 q22 1066981 956 956 Total cold run time: 107493 ms Total hot run time: 34202 ms - Round 2, with runtime_filter_mode=off - q1 4914491050114910 q2 325 415 316 316 q3 2125269422562256 q4 1330175213201320 q5 4200439245894392 q6 223 177 134 134 q7 2123198617611761 q8 2698261924482448 q9 7598751675627516 q10 3076327828182818 q11 602 520 503 503 q12 877 762 590 590 q13 3523386932663266 q14 279 313 304 304 q15 553 523 533 523 q16 925 895 890 890 q17 1204136614251366 q18 7969786075557555 q19 888 856 895 856 q20 1880198218251825 q21 4606424041954195 q22 10791022993 993 Total cold run time: 52997 ms Total hot run time: 50737 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [chore](Mysql) remove unused code in MysqlResultWriter [doris]
Mryange commented on PR #58699: URL: https://github.com/apache/doris/pull/58699#issuecomment-3609957415 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [chore](Mysql) remove unused code in MysqlResultWriter [doris]
Thearas commented on PR #58699: URL: https://github.com/apache/doris/pull/58699#issuecomment-3609950434 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
