Re: [PR] [enhance](nereids)row policy removes dependency on the old optimizer [doris]
github-actions[bot] commented on PR #51122: URL: https://github.com/apache/doris/pull/51122#issuecomment-2900736434 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance](nereids)row policy removes dependency on the old optimizer [doris]
morrySnow merged PR #51122: URL: https://github.com/apache/doris/pull/51122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance](nereids)row policy removes dependency on the old optimizer [doris]
github-actions[bot] commented on PR #51122: URL: https://github.com/apache/doris/pull/51122#issuecomment-2900736555 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance](nereids)row policy removes dependency on the old optimizer [doris]
zddr commented on PR #51122: URL: https://github.com/apache/doris/pull/51122#issuecomment-2900233272 run cloud_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance](nereids)row policy removes dependency on the old optimizer [doris]
doris-robot commented on PR #51122: URL: https://github.com/apache/doris/pull/51122#issuecomment-2899859068 ClickBench: Total hot run time: 28.64 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 17eaca8fb2680eef31f1d11414b7179c635f805e, data reload: false query1 0.040.030.03 query2 0.130.100.11 query3 0.260.190.19 query4 1.590.180.19 query5 0.460.430.44 query6 1.490.660.67 query7 0.030.020.02 query8 0.040.030.04 query9 0.570.520.51 query10 0.560.590.56 query11 0.150.110.11 query12 0.150.120.11 query13 0.610.590.60 query14 0.790.820.79 query15 0.870.850.84 query16 0.390.380.38 query17 1.031.071.07 query18 0.230.210.20 query19 1.881.841.83 query20 0.020.010.01 query21 15.41 0.900.55 query22 0.761.270.70 query23 14.80 1.380.61 query24 7.172.020.35 query25 0.310.130.08 query26 0.590.170.13 query27 0.050.040.05 query28 9.120.930.45 query29 12.53 4.003.27 query30 0.250.100.07 query31 2.810.580.39 query32 3.230.540.48 query33 3.093.043.09 query34 15.78 5.064.51 query35 4.474.544.52 query36 0.660.500.48 query37 0.090.070.06 query38 0.060.040.04 query39 0.040.020.02 query40 0.170.140.14 query41 0.080.030.03 query42 0.030.020.02 query43 0.040.020.02 Total cold run time: 102.83 s Total hot run time: 28.64 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance](nereids)row policy removes dependency on the old optimizer [doris]
doris-robot commented on PR #51122: URL: https://github.com/apache/doris/pull/51122#issuecomment-2899852897 TPC-DS: Total hot run time: 192831 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 17eaca8fb2680eef31f1d11414b7179c635f805e, data reload: false query1 1354109710601060 query2 6111182118141814 query3 10985 450145284501 query4 53204 25399 23253 23253 query5 4909539 451 451 query6 322 203 200 200 query7 4881513 290 290 query8 316 273 236 236 query9 5451264226372637 query10 401 352 277 277 query11 14995 14966 14827 14827 query12 163 114 106 106 query13 1039529 411 411 query14 10102 636563586358 query15 209 207 184 184 query16 7062677 510 510 query17 1092771 612 612 query18 1559420 326 326 query19 200 203 178 178 query20 128 125 121 121 query21 212 136 107 107 query22 4379445842574257 query23 34372 33494 33616 33494 query24 6722241324332413 query25 475 469 424 424 query26 722 291 160 160 query27 2257512 342 342 query28 3168217421642164 query29 567 567 454 454 query30 277 221 188 188 query31 879 850 768 768 query32 76 65 67 65 query33 449 370 318 318 query34 774 876 536 536 query35 809 853 735 735 query36 948 1014909 909 query37 125 109 80 80 query38 4297422742784227 query39 1491145514491449 query40 228 126 113 113 query41 56 53 53 53 query42 130 114 107 107 query43 508 518 464 464 query44 1323830 835 830 query45 180 180 167 167 query46 846 1035643 643 query47 1868191018171817 query48 393 450 322 322 query49 682 508 438 438 query50 706 706 417 417 query51 4203424141944194 query52 120 110 96 96 query53 229 266 193 193 query54 609 604 513 513 query55 87 83 81 81 query56 310 302 305 302 query57 1198122411761176 query58 272 258 254 254 query59 2699285127162716 query60 340 350 339 339 query61 131 132 132 132 query62 770 773 664 664 query63 234 195 192 192 query64 19331040706 706 query65 4321419542534195 query66 738 409 310 310 query67 15840 15681 15551 15551 query68 7433882 533 533 query69 550 306 275 275 query70 1211120911431143 query71 503 311 296 296 query72 5462456049784560 query73 1467616 350 350 query74 9013911990419041 query75 3889315627062706 query76 42011190754 754 query77 623 380 303 303 query78 10236 10121 93109310 query79 2670831 569 569 query80 650 509 457 457 query81 491 256 218 218 query82 483 130 103 103 query83 362 253 232 232 query84 304 104 90 90 query85 794 363 312 312 query86 384 310 293 293 query87 4359441043464346 query88 3467224822402240 query89 402 314 286 286 query90 1811203 206 203 query91 145 146 111 111 query92 80 59 58 58 query93 1950953 584 584 query94 660 403 299 299 query95 375 299 285 285 query96 505 569 281 281 query97 2746279026742674 query98 228 200 203 200 query99 1414140712921292 Total cold run time: 297304 ms Total hot run time: 192831 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [enhance](nereids)row policy removes dependency on the old optimizer [doris]
doris-robot commented on PR #51122: URL: https://github.com/apache/doris/pull/51122#issuecomment-2899839315 TPC-H: Total hot run time: 34515 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 17eaca8fb2680eef31f1d11414b7179c635f805e, data reload: false -- Round 1 -- q1 26179 512550495049 q2 2082281 190 190 q3 10382 1240711 711 q4 10231 987 542 542 q5 7512242523292329 q6 187 168 138 138 q7 933 745 628 628 q8 9328131411231123 q9 6787501950615019 q10 6871233119191919 q11 488 297 276 276 q12 358 361 219 219 q13 17760 367730873087 q14 240 228 207 207 q15 529 487 491 487 q16 419 433 379 379 q17 613 860 382 382 q18 7478730069736973 q19 1335963 553 553 q20 345 328 236 236 q21 3998330430593059 q22 1083103410091009 Total cold run time: 115138 ms Total hot run time: 34515 ms - Round 2, with runtime_filter_mode=off - q1 5167512051185118 q2 239 323 228 228 q3 2159273623232323 q4 1361183814131413 q5 4451440843854385 q6 225 170 135 135 q7 2048194617791779 q8 2608287025272527 q9 7168712072017120 q10 3061322927882788 q11 574 500 505 500 q12 706 776 647 647 q13 3496390233383338 q14 271 305 267 267 q15 539 480 471 471 q16 444 489 466 466 q17 1198157313461346 q18 7640745173737373 q19 869 929 1171929 q20 1905200418951895 q21 4943451645004500 q22 1074103810191019 Total cold run time: 52146 ms Total hot run time: 50567 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance](nereids)row policy removes dependency on the old optimizer [doris]
zddr commented on PR #51122: URL: https://github.com/apache/doris/pull/51122#issuecomment-2899796007 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance](nereids)row policy removes dependency on the old optimizer [doris]
Copilot commented on code in PR #51122:
URL: https://github.com/apache/doris/pull/51122#discussion_r2101535385
##
fe/fe-core/src/main/java/org/apache/doris/analysis/CreatePolicyStmt.java:
##
@@ -39,119 +29,28 @@
*/
public class CreatePolicyStmt extends DdlStmt implements NotFallbackInParser {
-@Getter
-private final PolicyTypeEnum type;
-
-@Getter
-private final boolean ifNotExists;
-
-@Getter
-private final String policyName;
-
-@Getter
-private TableName tableName = null;
-
-@Getter
-private FilterType filterType = null;
-
-@Getter
-private UserIdentity user = null;
-
-@Getter
-private String roleName = null;
-
-@Getter
-private Expr wherePredicate;
-
-@Getter
-private Map properties;
-
/**
* Use for cup.
**/
public CreatePolicyStmt(PolicyTypeEnum type, boolean ifNotExists, String
policyName, TableName tableName,
String filterType, UserIdentity user, String roleName, Expr
wherePredicate) {
-this.type = type;
-this.ifNotExists = ifNotExists;
-this.policyName = policyName;
-this.tableName = tableName;
-this.filterType = FilterType.of(filterType);
-this.user = user;
-this.roleName = roleName;
-this.wherePredicate = wherePredicate;
}
/**
* Use for cup.
*/
public CreatePolicyStmt(PolicyTypeEnum type, boolean ifNotExists, String
policyName,
Map properties) {
-this.type = type;
-this.ifNotExists = ifNotExists;
-this.policyName = policyName;
-this.properties = properties;
}
@Override
public void analyze(Analyzer analyzer) throws UserException {
-super.analyze(analyzer);
-switch (type) {
-case STORAGE:
-if (!Config.enable_storage_policy) {
-throw new UserException("storage policy feature is
disabled by default. "
-+ "Enable it by setting
'enable_storage_policy=true' in fe.conf");
-}
-// check auth
-// check if can create policy and use storage_resource
-if (!Env.getCurrentEnv().getAccessManager()
-.checkGlobalPriv(ConnectContext.get(),
PrivPredicate.ADMIN)) {
-
ErrorReport.reportAnalysisException(ErrorCode.ERR_SPECIFIC_ACCESS_DENIED_ERROR,
-PrivPredicate.ADMIN.getPrivs().toString());
-}
-break;
-case ROW:
-default:
-tableName.analyze(analyzer);
-if (user != null) {
-user.analyze();
-if (user.isRootUser() || user.isAdminUser()) {
-
ErrorReport.reportAnalysisException(ErrorCode.ERR_TABLEACCESS_DENIED_ERROR,
"CreatePolicyStmt",
-user.getQualifiedUser(), user.getHost(),
tableName.getTbl());
-}
-}
-// check auth
-if (!Env.getCurrentEnv().getAccessManager()
-.checkGlobalPriv(ConnectContext.get(),
PrivPredicate.GRANT)) {
-
ErrorReport.reportAnalysisException(ErrorCode.ERR_SPECIFIC_ACCESS_DENIED_ERROR,
-PrivPredicate.GRANT.getPrivs().toString());
-}
-}
+
}
@Override
public String toSql() {
-StringBuilder sb = new StringBuilder();
-sb.append("CREATE ").append(type).append(" POLICY ");
-if (ifNotExists) {
-sb.append("IF NOT EXISTS");
-}
-sb.append(policyName);
-switch (type) {
-case STORAGE:
-sb.append(" PROPERTIES(").append(new
PrintableMap<>(properties, " = ", true, false)).append(")");
-break;
-case ROW:
-default:
-sb.append(" ON ").append(tableName.toSql()).append(" AS
").append(filterType)
-.append(" TO ");
-if (user == null) {
-sb.append("ROLE ").append(roleName);
-} else {
-sb.append(user.getQualifiedUser());
-}
-sb.append(" USING ").append(wherePredicate.toSql());
-}
-return sb.toString();
+return "";
Review Comment:
The toSql() method now returns an empty string instead of a valid SQL
representation. Please add a comment to clarify that this is intentional due to
the removal of the old optimizer dependency, so future maintainers understand
the rationale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure
