Re: [PR] [enhance](nerieds) data_format, to_monday, last_day, to_date, year implement Monotonic [doris]
feiniaofeiafei commented on PR #44789: URL: https://github.com/apache/doris/pull/44789#issuecomment-2547806872 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance](nerieds) data_format, to_monday, last_day, to_date, year implement Monotonic [doris]
morrySnow commented on code in PR #44789:
URL: https://github.com/apache/doris/pull/44789#discussion_r1865725858
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/DateFormat.java:
##
@@ -74,4 +78,33 @@ public List getSignatures() {
public R accept(ExpressionVisitor visitor, C context) {
return visitor.visitDateFormat(this, context);
}
+
+@Override
+public boolean isMonotonic() {
+Expression format = child(1);
+if (!(format instanceof VarcharLiteral)) {
+return false;
+}
+VarcharLiteral varcharLiteral = (VarcharLiteral) format;
+String str = varcharLiteral.getValue();
+Set monoFormat = ImmutableSet.of("MMdd", "-MM-dd",
"-MM-dd HH:mm:ss", "%Y", "%Y-%m",
+"%Y-%m-%d", "%Y-%m-%d %H", "%Y-%m-%d %H:%i", "%Y-%m-%d
%H:%i:%s", "%Y-%m-%d %H:%i:%S", "%Y-%m-%d %T",
+"%Y%m%d", "%Y%m");
Review Comment:
maybe we should ignore any blank in format
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance](nerieds) data_format, to_monday, last_day, to_date, year implement Monotonic [doris]
morrySnow commented on code in PR #44789:
URL: https://github.com/apache/doris/pull/44789#discussion_r1865725858
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/DateFormat.java:
##
@@ -74,4 +78,33 @@ public List getSignatures() {
public R accept(ExpressionVisitor visitor, C context) {
return visitor.visitDateFormat(this, context);
}
+
+@Override
+public boolean isMonotonic() {
+Expression format = child(1);
+if (!(format instanceof VarcharLiteral)) {
+return false;
+}
+VarcharLiteral varcharLiteral = (VarcharLiteral) format;
+String str = varcharLiteral.getValue();
+Set monoFormat = ImmutableSet.of("MMdd", "-MM-dd",
"-MM-dd HH:mm:ss", "%Y", "%Y-%m",
+"%Y-%m-%d", "%Y-%m-%d %H", "%Y-%m-%d %H:%i", "%Y-%m-%d
%H:%i:%s", "%Y-%m-%d %H:%i:%S", "%Y-%m-%d %T",
+"%Y%m%d", "%Y%m");
Review Comment:
maybe we should ignore any blank
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance](nerieds) data_format, to_monday, last_day, to_date, year implement Monotonic [doris]
doris-robot commented on PR #44789: URL: https://github.com/apache/doris/pull/44789#issuecomment-2507702843 ClickBench: Total hot run time: 33.11 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 4f5a5fc6f6674f2bc4111ec4f338a35462659932, data reload: false query1 0.030.030.03 query2 0.070.030.03 query3 0.240.080.07 query4 1.610.100.11 query5 0.420.390.42 query6 1.160.660.65 query7 0.020.020.01 query8 0.040.040.03 query9 0.570.520.51 query10 0.540.560.55 query11 0.140.100.10 query12 0.140.110.12 query13 0.620.610.60 query14 2.702.712.70 query15 0.900.830.82 query16 0.370.370.37 query17 1.041.011.01 query18 0.240.200.20 query19 1.901.821.87 query20 0.020.010.01 query21 15.36 0.580.58 query22 2.542.203.05 query23 17.31 0.940.82 query24 2.821.161.19 query25 0.160.150.04 query26 0.590.140.13 query27 0.050.040.05 query28 10.65 1.101.09 query29 12.53 3.303.29 query30 0.240.060.06 query31 2.860.380.38 query32 3.290.460.47 query33 2.963.043.06 query34 17.01 4.494.46 query35 4.514.474.55 query36 0.660.490.48 query37 0.090.060.05 query38 0.050.030.03 query39 0.040.020.03 query40 0.170.130.14 query41 0.090.030.02 query42 0.030.020.02 query43 0.040.040.03 Total cold run time: 106.82 s Total hot run time: 33.11 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance](nerieds) data_format, to_monday, last_day, to_date, year implement Monotonic [doris]
doris-robot commented on PR #44789: URL: https://github.com/apache/doris/pull/44789#issuecomment-2507690673 TPC-DS: Total hot run time: 196683 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 4f5a5fc6f6674f2bc4111ec4f338a35462659932, data reload: false query1 1245971 936 936 query2 6223202620192019 query3 10991 439642944294 query4 66318 28776 23657 23657 query5 5219460 439 439 query6 449 210 182 182 query7 5738326 288 288 query8 300 212 226 212 query9 9464272426932693 query10 460 238 238 238 query11 17442 15293 15965 15293 query12 171 108 104 104 query13 1550420 429 420 query14 10575 751465516551 query15 219 192 181 181 query16 7038501 509 501 query17 1090587 584 584 query18 1827318 304 304 query19 213 168 157 157 query20 123 113 110 110 query21 212 107 104 104 query22 4576470846534653 query23 34723 34515 34492 34492 query24 5752248224282428 query25 493 384 379 379 query26 639 149 149 149 query27 1960291 298 291 query28 4091250524802480 query29 692 424 400 400 query30 210 163 151 151 query31 1006829 817 817 query32 70 56 57 56 query33 405 280 293 280 query34 922 530 504 504 query35 909 767 760 760 query36 1079966 973 966 query37 123 74 78 74 query38 4561441643904390 query39 1538147514631463 query40 196 102 128 102 query41 48 46 45 45 query42 116 100 94 94 query43 530 500 495 495 query44 1167838 845 838 query45 190 181 170 170 query46 1184740 728 728 query47 2005195519271927 query48 450 343 338 338 query49 718 398 369 369 query50 853 389 390 389 query51 7442720071877187 query52 94 92 86 86 query53 248 174 171 171 query54 498 413 394 394 query55 78 76 75 75 query56 250 238 230 230 query57 1228113810931093 query58 211 201 198 198 query59 3230307429642964 query60 260 240 242 240 query61 110 103 121 103 query62 758 674 667 667 query63 207 186 178 178 query64 1365682 628 628 query65 3312326032453245 query66 638 302 304 302 query67 15948 15577 15665 15577 query68 4273580 544 544 query69 409 248 250 248 query70 1195112711391127 query71 348 249 252 249 query72 6466405140974051 query73 758 367 363 363 query74 10090 905290439043 query75 3396268626652665 query76 1876101410731014 query77 492 271 265 265 query78 10469 932394659323 query79 2228582 600 582 query80 879 417 421 417 query81 512 237 228 228 query82 316 116 114 114 query83 227 149 144 144 query84 266 72 70 70 query85 1078298 305 298 query86 450 295 301 295 query87 4648451945374519 query88 4238220821732173 query89 419 306 286 286 query90 1959191 185 185 query91 136 103 100 100 query92 64 50 60 50 query93 2314544 527 527 query94 771 292 292 292 query95 355 246 243 243 query96 624 278 275 275 query97 2841266826782668 query98 222 194 202 194 query99 1609130612981298 Total cold run time: 319878 ms Total hot run time: 196683 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [enhance](nerieds) data_format, to_monday, last_day, to_date, year implement Monotonic [doris]
doris-robot commented on PR #44789: URL: https://github.com/apache/doris/pull/44789#issuecomment-2507669537 TPC-H: Total hot run time: 40062 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 4f5a5fc6f6674f2bc4111ec4f338a35462659932, data reload: false -- Round 1 -- q1 17597 815572957295 q2 2044202 167 167 q3 10578 108812411088 q4 10540 734 743 734 q5 7600273927372737 q6 239 153 144 144 q7 998 626 600 600 q8 9246191019451910 q9 6574642964346429 q10 6977229923402299 q11 465 268 272 268 q12 434 225 224 224 q13 17780 301030383010 q14 263 209 210 209 q15 573 527 516 516 q16 667 592 582 582 q17 971 523 530 523 q18 7429675968446759 q19 1346970 1036970 q20 483 184 179 179 q21 3975311132543111 q22 390 315 308 308 Total cold run time: 107169 ms Total hot run time: 40062 ms - Round 2, with runtime_filter_mode=off - q1 7271721172257211 q2 326 235 231 231 q3 2909281428802814 q4 2116180018201800 q5 5694568156965681 q6 220 138 139 138 q7 2259183018831830 q8 3414357435023502 q9 9120913790909090 q10 3590358135563556 q11 607 501 498 498 q12 788 621 604 604 q13 11259 323631853185 q14 313 291 278 278 q15 578 528 532 528 q16 685 658 627 627 q17 1873165816291629 q18 8264789976667666 q19 1752160115831583 q20 2128189918661866 q21 5786548554925485 q22 727 592 576 576 Total cold run time: 71679 ms Total hot run time: 60378 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance](nerieds) data_format, to_monday, last_day, to_date, year implement Monotonic [doris]
doris-robot commented on PR #44789: URL: https://github.com/apache/doris/pull/44789#issuecomment-2507583516 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance](nerieds) data_format, to_monday, last_day, to_date, year implement Monotonic [doris]
feiniaofeiafei commented on PR #44789: URL: https://github.com/apache/doris/pull/44789#issuecomment-2507583590 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
