Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
gavinchou merged PR #50726: URL: https://github.com/apache/doris/pull/50726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
github-actions[bot] commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2903624691 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
github-actions[bot] commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2903624600 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
gavinchou commented on code in PR #50726:
URL: https://github.com/apache/doris/pull/50726#discussion_r2103882387
##
be/src/io/cache/fs_file_cache_storage.cpp:
##
@@ -326,91 +442,99 @@ Status
FSFileCacheStorage::upgrade_cache_dir_if_necessary() const {
std::string version;
std::error_code ec;
int rename_count = 0;
+int failure_count = 0;
auto start_time = std::chrono::steady_clock::now();
RETURN_IF_ERROR(read_file_cache_version(&version));
+
LOG(INFO) << "Checking cache version upgrade. Current version: " << version
<< ", target version: 2.0, need upgrade: "
<< (USE_CACHE_VERSION2 && version != "2.0");
if (USE_CACHE_VERSION2 && version != "2.0") {
// move directories format as version 2.0
-std::filesystem::directory_iterator key_it {_cache_base_path, ec};
-if (ec) {
-LOG(WARNING) << "Failed to list directory: " << _cache_base_path
- << ", error: " << ec.message();
-return Status::InternalError("Failed to list dir {}: {}",
_cache_base_path,
- ec.message());
-}
-for (; key_it != std::filesystem::directory_iterator(); ++key_it) {
-if (key_it->is_directory()) {
-std::string cache_key = key_it->path().filename().native();
-if (cache_key.size() > KEY_PREFIX_LENGTH) {
-std::string key_prefix =
-Path(_cache_base_path) / cache_key.substr(0,
KEY_PREFIX_LENGTH);
-bool exists = false;
-auto exists_status = fs->exists(key_prefix, &exists);
-if (!exists_status.ok()) {
-LOG(WARNING) << "Failed to check directory existence:
" << key_prefix
- << ", error: " <<
exists_status.to_string();
-return exists_status;
-}
-if (!exists) {
-auto create_status = fs->create_directory(key_prefix);
-if (!create_status.ok()) {
-LOG(WARNING) << "Failed to create directory: " <<
key_prefix
- << ", error: " <<
create_status.to_string();
-return create_status;
+std::vector file_list;
+file_list.reserve(1);
Review Comment:
100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
freemandealer commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2903039350 run beut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
freemandealer commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2903039234 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
freemandealer commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2903039486 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
doris-robot commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2901587833 TPC-DS: Total hot run time: 192918 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit bac0a8ceea8b97de5d2abb97f1c0cbc8f5a83a12, data reload: false query1 1409110710921092 query2 6199186618601860 query3 11061 460344324432 query4 53262 24892 22971 22971 query5 4958502 481 481 query6 339 207 199 199 query7 4904548 302 302 query8 321 254 246 246 query9 5717265826472647 query10 439 335 279 279 query11 14948 15182 14935 14935 query12 176 117 102 102 query13 1043554 400 400 query14 10190 633864296338 query15 223 205 182 182 query16 7041643 493 493 query17 1058739 568 568 query18 1579409 318 318 query19 197 193 164 164 query20 125 129 126 126 query21 204 125 107 107 query22 4407444543994399 query23 34070 33621 33735 33621 query24 6614245424282428 query25 484 483 420 420 query26 673 286 159 159 query27 2237535 348 348 query28 3196215921732159 query29 617 586 476 476 query30 270 230 205 205 query31 903 892 793 793 query32 83 70 67 67 query33 471 391 323 323 query34 776 853 532 532 query35 851 859 769 769 query36 948 1010912 912 query37 132 119 79 79 query38 4231429642654265 query39 1525147714551455 query40 219 126 132 126 query41 63 60 57 57 query42 128 118 117 117 query43 525 522 494 494 query44 1391840 825 825 query45 184 175 164 164 query46 852 1030653 653 query47 1826186418371837 query48 406 439 345 345 query49 720 534 470 470 query50 685 719 413 413 query51 4240425942904259 query52 113 113 95 95 query53 231 262 189 189 query54 592 588 550 550 query55 92 90 94 90 query56 322 304 313 304 query57 1194121111471147 query58 272 266 256 256 query59 2787279427372737 query60 347 329 310 310 query61 129 122 143 122 query62 731 749 673 673 query63 226 188 181 181 query64 17021053685 685 query65 4319429242684268 query66 750 398 306 306 query67 15901 15758 15169 15169 query68 7401886 515 515 query69 542 316 259 259 query70 1205113610711071 query71 506 330 305 305 query72 5491487448914874 query73 1448662 349 349 query74 9188902488378837 query75 3744318726912691 query76 42561179764 764 query77 594 375 280 280 query78 10148 10041 93769376 query79 4140781 558 558 query80 635 527 461 461 query81 491 261 220 220 query82 525 129 94 94 query83 375 249 238 238 query84 302 105 87 87 query85 814 362 363 362 query86 434 296 274 274 query87 4423441443334333 query88 3683226822912268 query89 431 327 287 287 query90 1847209 200 200 query91 142 140 108 108 query92 75 69 54 54 query93 3012944 578 578 query94 666 386 286 286 query95 374 299 283 283 query96 499 576 281 281 query97 2715271526352635 query98 230 209 203 203 query99 1429139512931293 Total cold run time: 300593 ms Total hot run time: 192918 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
doris-robot commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2901608120 ClickBench: Total hot run time: 29.49 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit bac0a8ceea8b97de5d2abb97f1c0cbc8f5a83a12, data reload: false query1 0.040.030.04 query2 0.150.110.10 query3 0.340.210.20 query4 1.590.200.07 query5 0.420.400.40 query6 1.160.670.66 query7 0.020.020.02 query8 0.050.040.05 query9 0.630.520.53 query10 0.570.600.56 query11 0.250.130.13 query12 0.260.140.14 query13 0.640.630.62 query14 0.800.830.83 query15 0.970.860.87 query16 0.370.360.37 query17 1.071.051.07 query18 0.170.180.18 query19 1.991.791.86 query20 0.020.020.01 query21 15.39 0.960.66 query22 0.921.020.77 query23 14.72 1.530.74 query24 4.720.650.33 query25 0.170.080.08 query26 0.570.220.18 query27 0.080.080.09 query28 11.03 1.230.57 query29 12.55 4.033.41 query30 0.280.090.07 query31 2.820.630.43 query32 3.240.600.51 query33 3.033.173.09 query34 16.29 5.134.40 query35 4.434.444.45 query36 0.650.500.49 query37 0.190.180.17 query38 0.170.160.17 query39 0.050.040.04 query40 0.190.170.16 query41 0.100.050.06 query42 0.070.050.05 query43 0.060.050.04 Total cold run time: 103.23 s Total hot run time: 29.49 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
doris-robot commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2901544728 TPC-H: Total hot run time: 33745 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit bac0a8ceea8b97de5d2abb97f1c0cbc8f5a83a12, data reload: false -- Round 1 -- q1 26148 514050005000 q2 2078280 176 176 q3 10760 1251714 714 q4 10280 1011516 516 q5 8178235823242324 q6 188 161 131 131 q7 950 725 625 625 q8 9310127810501050 q9 6843507450495049 q10 6851232218921892 q11 506 298 279 279 q12 366 372 218 218 q13 17790 365131063106 q14 227 229 217 217 q15 533 493 485 485 q16 410 440 388 388 q17 595 858 354 354 q18 7614722871037103 q19 1879941 573 573 q20 328 329 235 235 q21 3745256123682368 q22 10501018942 942 Total cold run time: 116629 ms Total hot run time: 33745 ms - Round 2, with runtime_filter_mode=off - q1 5218501550885015 q2 241 327 231 231 q3 2178266722952295 q4 1339181014191419 q5 4518437543534353 q6 213 171 126 126 q7 2026187918071807 q8 2569254225872542 q9 7275724768496849 q10 3035316927442744 q11 561 532 498 498 q12 679 790 663 663 q13 3608390533443344 q14 290 288 265 265 q15 517 491 487 487 q16 462 489 438 438 q17 1158160013401340 q18 7768754574927492 q19 811 896 1034896 q20 1993209318681868 q21 4856454145664541 q22 1081104110091009 Total cold run time: 52396 ms Total hot run time: 50222 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
freemandealer commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2901344458 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
hello-stephen commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2901414088 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/bac0a8ceea8b97de5d2abb97f1c0cbc8f5a83a12_bac0a8ceea8b97de5d2abb97f1c0cbc8f5a83a12_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/bac0a8ceea8b97de5d2abb97f1c0cbc8f5a83a12_bac0a8ceea8b97de5d2abb97f1c0cbc8f5a83a12_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 83.25% (1113/1337) | | Line Coverage | 66.14% (18667/28223) | | Region Coverage | 65.81% (9264/14077) | | Branch Coverage | 55.57% (4981/8964) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
freemandealer commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2901342207 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
doris-robot commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2900528155 ClickBench: Total hot run time: 29.21 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit bac0a8ceea8b97de5d2abb97f1c0cbc8f5a83a12, data reload: false query1 0.040.040.03 query2 0.120.100.11 query3 0.260.200.20 query4 1.590.190.11 query5 0.450.420.42 query6 1.170.650.68 query7 0.030.020.01 query8 0.050.040.03 query9 0.590.510.52 query10 0.570.590.55 query11 0.160.110.11 query12 0.160.120.12 query13 0.620.610.60 query14 0.780.820.80 query15 0.880.860.88 query16 0.390.390.39 query17 1.061.041.08 query18 0.220.210.22 query19 1.961.861.81 query20 0.010.010.01 query21 15.42 0.890.54 query22 0.771.210.65 query23 14.91 1.370.60 query24 6.671.520.97 query25 0.500.210.07 query26 0.470.170.15 query27 0.050.050.05 query28 10.12 0.920.44 query29 12.57 4.033.34 query30 0.250.080.07 query31 2.830.600.38 query32 3.230.560.48 query33 3.063.103.08 query34 15.78 5.154.49 query35 4.524.554.53 query36 0.660.500.48 query37 0.080.060.06 query38 0.050.040.03 query39 0.040.030.03 query40 0.160.140.14 query41 0.080.020.02 query42 0.030.030.02 query43 0.040.040.03 Total cold run time: 103.4 s Total hot run time: 29.21 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
doris-robot commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2900512210 TPC-DS: Total hot run time: 186372 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit bac0a8ceea8b97de5d2abb97f1c0cbc8f5a83a12, data reload: false query1 1010484 519 484 query2 6570190218621862 query3 6764230 225 225 query4 26223 23399 23698 23399 query5 4344639 445 445 query6 290 209 220 209 query7 4623520 281 281 query8 277 238 236 236 query9 8594259726032597 query10 470 313 275 275 query11 15306 15045 14957 14957 query12 161 109 109 109 query13 1673537 405 405 query14 8883621962546219 query15 208 194 169 169 query16 7137660 448 448 query17 1204694 550 550 query18 1971401 289 289 query19 186 184 157 157 query20 118 126 118 118 query21 215 123 105 105 query22 4045429540084008 query23 34174 33094 33096 33094 query24 8466241524152415 query25 540 461 398 398 query26 1239291 156 156 query27 2738521 349 349 query28 4313214521112111 query29 777 556 428 428 query30 280 220 187 187 query31 924 836 740 740 query32 77 62 65 62 query33 553 378 311 311 query34 796 914 511 511 query35 806 835 750 750 query36 982 984 908 908 query37 115 103 76 76 query38 4104410440754075 query39 1503141013871387 query40 211 124 110 110 query41 60 61 54 54 query42 123 107 106 106 query43 523 511 500 500 query44 1345811 800 800 query45 176 177 168 168 query46 890 1059630 630 query47 1734178517051705 query48 406 433 313 313 query49 784 501 421 421 query50 680 731 431 431 query51 4190414140944094 query52 112 113 106 106 query53 234 281 184 184 query54 584 602 501 501 query55 84 82 94 82 query56 343 292 302 292 query57 1125113210991099 query58 266 259 251 251 query59 2671263426382634 query60 330 325 301 301 query61 134 128 167 128 query62 817 732 673 673 query63 228 196 187 187 query64 43361008668 668 query65 4291419242374192 query66 1141410 315 315 query67 15786 15480 15405 15405 query68 4650902 534 534 query69 491 326 267 267 query70 1218109711211097 query71 414 322 300 300 query72 5759470947094709 query73 650 606 349 349 query74 9186934288738873 query75 3219319427042704 query76 31531264799 799 query77 482 385 300 300 query78 995910074 94239423 query79 1983854 585 585 query80 662 554 488 488 query81 498 269 218 218 query82 218 130 101 101 query83 252 256 239 239 query84 250 114 84 84 query85 751 361 312 312 query86 375 312 303 303 query87 4353443442904290 query88 2900225022602250 query89 398 315 280 280 query90 1978212 204 204 query91 136 144 112 112 query92 80 69 58 58 query93 2420948 583 583 query94 686 420 302 302 query95 377 293 300 293 query96 507 643 290 290 query97 2645280226432643 query98 226 232 207 207 query99 1305140413201320 Total cold run time: 268444 ms Total hot run time: 186372 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
doris-robot commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2900478455 TPC-H: Total hot run time: 33829 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit bac0a8ceea8b97de5d2abb97f1c0cbc8f5a83a12, data reload: false -- Round 1 -- q1 26077 502550595025 q2 2088290 189 189 q3 10489 1247719 719 q4 10233 1019517 517 q5 7673244123312331 q6 182 164 129 129 q7 915 746 610 610 q8 9321127110751075 q9 6829508650795079 q10 6810231319041904 q11 476 290 273 273 q12 357 349 210 210 q13 17800 376430983098 q14 237 228 215 215 q15 546 500 514 500 q16 427 448 364 364 q17 625 862 370 370 q18 7577731171117111 q19 1822949 573 573 q20 340 353 223 223 q21 3793256023542354 q22 10541018960 960 Total cold run time: 115671 ms Total hot run time: 33829 ms - Round 2, with runtime_filter_mode=off - q1 5238513851265126 q2 241 319 226 226 q3 2189270823042304 q4 1356175913771377 q5 4589452444024402 q6 214 171 122 122 q7 1975193417461746 q8 2569246926082469 q9 7219699971216999 q10 3000319827722772 q11 567 496 482 482 q12 674 757 594 594 q13 3530392433543354 q14 274 289 278 278 q15 550 528 517 517 q16 433 478 447 447 q17 1176155413961396 q18 7610745873627362 q19 856 824 941 824 q20 1993200618751875 q21 5031447143474347 q22 10831044970 970 Total cold run time: 52367 ms Total hot run time: 49989 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
freemandealer commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2900189467 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
doris-robot commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2900232770 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/bac0a8ceea8b97de5d2abb97f1c0cbc8f5a83a12_bac0a8ceea8b97de5d2abb97f1c0cbc8f5a83a12_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/bac0a8ceea8b97de5d2abb97f1c0cbc8f5a83a12_bac0a8ceea8b97de5d2abb97f1c0cbc8f5a83a12_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 83.25% (1113/1337) | | Line Coverage | 66.16% (18672/28223) | | Region Coverage | 65.82% (9265/14077) | | Branch Coverage | 55.58% (4982/8964) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
gavinchou commented on code in PR #50726:
URL: https://github.com/apache/doris/pull/50726#discussion_r2099588169
##
be/src/io/cache/fs_file_cache_storage.cpp:
##
@@ -307,6 +328,98 @@ std::string
FSFileCacheStorage::get_path_in_local_cache(const UInt128Wrapper& va
}
}
+void FSFileCacheStorage::remove_old_version_directories() {
+std::error_code ec;
+std::filesystem::directory_iterator key_it {_cache_base_path, ec};
+if (ec) {
+LOG(WARNING) << "Failed to list directory: " << _cache_base_path
+ << ", error: " << ec.message();
+return;
+}
+
+std::vector file_list;
+// the dir is concurrently accessed, so handle invalid iter with retry
+bool success = false;
+size_t retry_count = 0;
+const size_t max_retry = 30;
+while (!success && retry_count < max_retry) {
+try {
+++retry_count;
+for (; key_it != std::filesystem::directory_iterator(); ++key_it) {
+file_list.push_back(key_it->path());
+}
+success = true;
+} catch (const std::exception& e) {
+LOG(WARNING) << "Error occurred while iterating directory: " <<
e.what();
+file_list.clear();
+}
+}
+
+if (!success) {
+LOG_WARNING("iteration of cache dir still failed after retry {}
times.", max_retry);
+}
+
+auto path_itr = file_list.begin();
+for (; path_itr != file_list.end(); ++path_itr) {
+if (std::filesystem::is_directory(*path_itr)) {
+std::string cache_key = path_itr->filename().native();
+if (cache_key.size() > KEY_PREFIX_LENGTH) {
+// try our best to delete, not care the return
+(void)fs->delete_directory(*path_itr);
+}
+}
+}
+auto s = fs->delete_file(get_version_path());
+if (!s.ok()) {
+LOG(WARNING) << "deleted old version file failed: " << s.to_string();
+return;
+}
+s = write_file_cache_version();
+if (!s.ok()) {
+LOG(WARNING) << "write new version file failed: " << s.to_string();
+return;
+}
+}
+
+Status FSFileCacheStorage::collect_directory_entries(const
std::filesystem::path& dir_path,
+ std::vector&
file_list) const {
+std::error_code ec;
+bool success = false;
+size_t retry_count = 0;
+const size_t max_retry = 5;
+
+while (!success && retry_count < max_retry) {
+try {
+++retry_count;
+std::filesystem::directory_iterator it {dir_path, ec};
+
TEST_SYNC_POINT_CALLBACK("FSFileCacheStorage::collect_directory_entries");
+if (ec) {
+LOG(WARNING) << "Failed to list directory: " << dir_path
+ << ", error: " << ec.message();
+return Status::InternalError("Failed to list dir {}: {}",
dir_path.native(),
+ ec.message());
+}
+
+file_list.clear();
+for (; it != std::filesystem::directory_iterator(); ++it) {
+file_list.push_back(it->path().string());
+}
+success = true;
+} catch (const std::exception& e) {
+LOG(WARNING) << "Error occurred while iterating directory: " <<
dir_path
+ << " err: " << e.what();
+file_list.clear();
+}
+}
+
+if (!success) {
+LOG_WARNING("iteration of cache dir still failed after retry {}
times.", max_retry);
Review Comment:
log stats
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
freemandealer commented on code in PR #50726:
URL: https://github.com/apache/doris/pull/50726#discussion_r2099587525
##
be/src/io/cache/fs_file_cache_storage.cpp:
##
@@ -307,6 +328,98 @@ std::string
FSFileCacheStorage::get_path_in_local_cache(const UInt128Wrapper& va
}
}
+void FSFileCacheStorage::remove_old_version_directories() {
+std::error_code ec;
+std::filesystem::directory_iterator key_it {_cache_base_path, ec};
+if (ec) {
+LOG(WARNING) << "Failed to list directory: " << _cache_base_path
+ << ", error: " << ec.message();
+return;
+}
+
+std::vector file_list;
+// the dir is concurrently accessed, so handle invalid iter with retry
+bool success = false;
+size_t retry_count = 0;
+const size_t max_retry = 30;
+while (!success && retry_count < max_retry) {
+try {
+++retry_count;
+for (; key_it != std::filesystem::directory_iterator(); ++key_it) {
+file_list.push_back(key_it->path());
+}
+success = true;
+} catch (const std::exception& e) {
+LOG(WARNING) << "Error occurred while iterating directory: " <<
e.what();
+file_list.clear();
+}
+}
+
+if (!success) {
+LOG_WARNING("iteration of cache dir still failed after retry {}
times.", max_retry);
+}
+
+auto path_itr = file_list.begin();
+for (; path_itr != file_list.end(); ++path_itr) {
+if (std::filesystem::is_directory(*path_itr)) {
+std::string cache_key = path_itr->filename().native();
+if (cache_key.size() > KEY_PREFIX_LENGTH) {
+// try our best to delete, not care the return
+(void)fs->delete_directory(*path_itr);
+}
+}
+}
+auto s = fs->delete_file(get_version_path());
+if (!s.ok()) {
+LOG(WARNING) << "deleted old version file failed: " << s.to_string();
+return;
+}
+s = write_file_cache_version();
+if (!s.ok()) {
+LOG(WARNING) << "write new version file failed: " << s.to_string();
+return;
+}
+}
+
+Status FSFileCacheStorage::collect_directory_entries(const
std::filesystem::path& dir_path,
+ std::vector&
file_list) const {
+std::error_code ec;
+bool success = false;
+size_t retry_count = 0;
+const size_t max_retry = 5;
+
+while (!success && retry_count < max_retry) {
+try {
+++retry_count;
+std::filesystem::directory_iterator it {dir_path, ec};
+
TEST_SYNC_POINT_CALLBACK("FSFileCacheStorage::collect_directory_entries");
+if (ec) {
+LOG(WARNING) << "Failed to list directory: " << dir_path
+ << ", error: " << ec.message();
+return Status::InternalError("Failed to list dir {}: {}",
dir_path.native(),
+ ec.message());
+}
+
+file_list.clear();
+for (; it != std::filesystem::directory_iterator(); ++it) {
+file_list.push_back(it->path().string());
+}
+success = true;
+} catch (const std::exception& e) {
+LOG(WARNING) << "Error occurred while iterating directory: " <<
dir_path
+ << " err: " << e.what();
+file_list.clear();
+}
+}
+
Review Comment:
add retry metrics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
freemandealer commented on code in PR #50726:
URL: https://github.com/apache/doris/pull/50726#discussion_r2099583273
##
be/src/io/cache/fs_file_cache_storage.cpp:
##
@@ -307,6 +328,98 @@ std::string
FSFileCacheStorage::get_path_in_local_cache(const UInt128Wrapper& va
}
}
+void FSFileCacheStorage::remove_old_version_directories() {
+std::error_code ec;
+std::filesystem::directory_iterator key_it {_cache_base_path, ec};
+if (ec) {
+LOG(WARNING) << "Failed to list directory: " << _cache_base_path
+ << ", error: " << ec.message();
+return;
+}
+
+std::vector file_list;
+// the dir is concurrently accessed, so handle invalid iter with retry
+bool success = false;
+size_t retry_count = 0;
+const size_t max_retry = 30;
+while (!success && retry_count < max_retry) {
+try {
+++retry_count;
+for (; key_it != std::filesystem::directory_iterator(); ++key_it) {
+file_list.push_back(key_it->path());
+}
+success = true;
+} catch (const std::exception& e) {
+LOG(WARNING) << "Error occurred while iterating directory: " <<
e.what();
+file_list.clear();
+}
+}
+
+if (!success) {
+LOG_WARNING("iteration of cache dir still failed after retry {}
times.", max_retry);
+}
+
+auto path_itr = file_list.begin();
+for (; path_itr != file_list.end(); ++path_itr) {
+if (std::filesystem::is_directory(*path_itr)) {
+std::string cache_key = path_itr->filename().native();
+if (cache_key.size() > KEY_PREFIX_LENGTH) {
+// try our best to delete, not care the return
+(void)fs->delete_directory(*path_itr);
+}
+}
+}
+auto s = fs->delete_file(get_version_path());
+if (!s.ok()) {
+LOG(WARNING) << "deleted old version file failed: " << s.to_string();
+return;
+}
+s = write_file_cache_version();
+if (!s.ok()) {
+LOG(WARNING) << "write new version file failed: " << s.to_string();
+return;
+}
+}
+
+Status FSFileCacheStorage::collect_directory_entries(const
std::filesystem::path& dir_path,
+ std::vector&
file_list) const {
+std::error_code ec;
+bool success = false;
+size_t retry_count = 0;
+const size_t max_retry = 5;
+
+while (!success && retry_count < max_retry) {
+try {
+++retry_count;
+std::filesystem::directory_iterator it {dir_path, ec};
+
TEST_SYNC_POINT_CALLBACK("FSFileCacheStorage::collect_directory_entries");
+if (ec) {
+LOG(WARNING) << "Failed to list directory: " << dir_path
+ << ", error: " << ec.message();
+return Status::InternalError("Failed to list dir {}: {}",
dir_path.native(),
+ ec.message());
+}
+
+file_list.clear();
Review Comment:
reserve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
freemandealer commented on code in PR #50726:
URL: https://github.com/apache/doris/pull/50726#discussion_r2099582106
##
be/src/io/cache/fs_file_cache_storage.cpp:
##
@@ -307,6 +328,98 @@ std::string
FSFileCacheStorage::get_path_in_local_cache(const UInt128Wrapper& va
}
}
+void FSFileCacheStorage::remove_old_version_directories() {
+std::error_code ec;
+std::filesystem::directory_iterator key_it {_cache_base_path, ec};
+if (ec) {
+LOG(WARNING) << "Failed to list directory: " << _cache_base_path
+ << ", error: " << ec.message();
+return;
+}
+
+std::vector file_list;
+// the dir is concurrently accessed, so handle invalid iter with retry
+bool success = false;
+size_t retry_count = 0;
+const size_t max_retry = 30;
+while (!success && retry_count < max_retry) {
+try {
+++retry_count;
+for (; key_it != std::filesystem::directory_iterator(); ++key_it) {
+file_list.push_back(key_it->path());
+}
+success = true;
+} catch (const std::exception& e) {
+LOG(WARNING) << "Error occurred while iterating directory: " <<
e.what();
+file_list.clear();
+}
+}
+
+if (!success) {
+LOG_WARNING("iteration of cache dir still failed after retry {}
times.", max_retry);
+}
+
+auto path_itr = file_list.begin();
+for (; path_itr != file_list.end(); ++path_itr) {
+if (std::filesystem::is_directory(*path_itr)) {
+std::string cache_key = path_itr->filename().native();
+if (cache_key.size() > KEY_PREFIX_LENGTH) {
+// try our best to delete, not care the return
+(void)fs->delete_directory(*path_itr);
+}
+}
+}
+auto s = fs->delete_file(get_version_path());
+if (!s.ok()) {
+LOG(WARNING) << "deleted old version file failed: " << s.to_string();
+return;
+}
+s = write_file_cache_version();
+if (!s.ok()) {
+LOG(WARNING) << "write new version file failed: " << s.to_string();
+return;
+}
+}
+
+Status FSFileCacheStorage::collect_directory_entries(const
std::filesystem::path& dir_path,
+ std::vector&
file_list) const {
+std::error_code ec;
+bool success = false;
+size_t retry_count = 0;
+const size_t max_retry = 5;
+
+while (!success && retry_count < max_retry) {
+try {
+++retry_count;
+std::filesystem::directory_iterator it {dir_path, ec};
+
TEST_SYNC_POINT_CALLBACK("FSFileCacheStorage::collect_directory_entries");
+if (ec) {
+LOG(WARNING) << "Failed to list directory: " << dir_path
+ << ", error: " << ec.message();
+return Status::InternalError("Failed to list dir {}: {}",
dir_path.native(),
+ ec.message());
Review Comment:
continue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
freemandealer commented on code in PR #50726:
URL: https://github.com/apache/doris/pull/50726#discussion_r2099569738
##
be/src/io/cache/fs_file_cache_storage.cpp:
##
@@ -307,6 +328,98 @@ std::string
FSFileCacheStorage::get_path_in_local_cache(const UInt128Wrapper& va
}
}
+void FSFileCacheStorage::remove_old_version_directories() {
+std::error_code ec;
+std::filesystem::directory_iterator key_it {_cache_base_path, ec};
+if (ec) {
+LOG(WARNING) << "Failed to list directory: " << _cache_base_path
+ << ", error: " << ec.message();
+return;
+}
+
+std::vector file_list;
+// the dir is concurrently accessed, so handle invalid iter with retry
+bool success = false;
+size_t retry_count = 0;
+const size_t max_retry = 30;
Review Comment:
5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
gavinchou commented on code in PR #50726:
URL: https://github.com/apache/doris/pull/50726#discussion_r2096028982
##
be/src/io/cache/fs_file_cache_storage.cpp:
##
@@ -102,11 +104,33 @@ size_t FDCache::file_reader_cache_size() {
Status FSFileCacheStorage::init(BlockFileCache* _mgr) {
_cache_base_path = _mgr->_cache_base_path;
-RETURN_IF_ERROR(upgrade_cache_dir_if_necessary());
_cache_background_load_thread = std::thread([this, mgr = _mgr]() {
+auto mem_tracker =
MemTrackerLimiter::create_shared(MemTrackerLimiter::Type::OTHER,
+
fmt::format("FileCacheVersionReader"));
+SCOPED_ATTACH_TASK(mem_tracker);
+Status st = upgrade_cache_dir_if_necessary();
+
TEST_SYNC_POINT_CALLBACK("FSFileCacheStorage::upgrade_cache_dir_if_necessary",
&st);
+if (!st.ok()) {
+std::string msg = fmt::format(
+"file cache {} lazy load done with error. upgrade version
failed. st={}",
+_cache_base_path, st.to_string());
+if (doris::config::ignore_file_cache_dir_upgrade_failure) {
+LOG(WARNING) << msg << "be conf:
`ignore_file_cache_dir_upgrade_failure = true`"
+ << " so we are ignoring the error (unsuccessful
cache files will be "
+"removed)";
+remove_old_version_directories();
+} else {
+LOG(WARNING) << msg << ". please fix error and restart BE or"
+ << " use be conf:
`ignore_file_cache_dir_upgrade_failure = true`"
+ << " to skip the error (unsuccessful cache files
will be removed)";
+throw doris::Exception(Status::InternalError(
Review Comment:
why not just return error instead of throw?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
gavinchou commented on code in PR #50726:
URL: https://github.com/apache/doris/pull/50726#discussion_r2096028982
##
be/src/io/cache/fs_file_cache_storage.cpp:
##
@@ -102,11 +104,33 @@ size_t FDCache::file_reader_cache_size() {
Status FSFileCacheStorage::init(BlockFileCache* _mgr) {
_cache_base_path = _mgr->_cache_base_path;
-RETURN_IF_ERROR(upgrade_cache_dir_if_necessary());
_cache_background_load_thread = std::thread([this, mgr = _mgr]() {
+auto mem_tracker =
MemTrackerLimiter::create_shared(MemTrackerLimiter::Type::OTHER,
+
fmt::format("FileCacheVersionReader"));
+SCOPED_ATTACH_TASK(mem_tracker);
+Status st = upgrade_cache_dir_if_necessary();
+
TEST_SYNC_POINT_CALLBACK("FSFileCacheStorage::upgrade_cache_dir_if_necessary",
&st);
+if (!st.ok()) {
+std::string msg = fmt::format(
+"file cache {} lazy load done with error. upgrade version
failed. st={}",
+_cache_base_path, st.to_string());
+if (doris::config::ignore_file_cache_dir_upgrade_failure) {
+LOG(WARNING) << msg << "be conf:
`ignore_file_cache_dir_upgrade_failure = true`"
+ << " so we are ignoring the error (unsuccessful
cache files will be "
+"removed)";
+remove_old_version_directories();
+} else {
+LOG(WARNING) << msg << ". please fix error and restart BE or"
+ << " use be conf:
`ignore_file_cache_dir_upgrade_failure = true`"
+ << " to skip the error (unsuccessful cache files
will be removed)";
+throw doris::Exception(Status::InternalError(
Review Comment:
why not just return error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
gavinchou commented on code in PR #50726:
URL: https://github.com/apache/doris/pull/50726#discussion_r2096010192
##
be/src/io/cache/fs_file_cache_storage.cpp:
##
@@ -326,91 +442,139 @@ Status
FSFileCacheStorage::upgrade_cache_dir_if_necessary() const {
std::string version;
std::error_code ec;
int rename_count = 0;
+int failure_count = 0;
auto start_time = std::chrono::steady_clock::now();
RETURN_IF_ERROR(read_file_cache_version(&version));
+
LOG(INFO) << "Checking cache version upgrade. Current version: " << version
<< ", target version: 2.0, need upgrade: "
<< (USE_CACHE_VERSION2 && version != "2.0");
if (USE_CACHE_VERSION2 && version != "2.0") {
// move directories format as version 2.0
-std::filesystem::directory_iterator key_it {_cache_base_path, ec};
-if (ec) {
-LOG(WARNING) << "Failed to list directory: " << _cache_base_path
- << ", error: " << ec.message();
-return Status::InternalError("Failed to list dir {}: {}",
_cache_base_path,
- ec.message());
-}
-for (; key_it != std::filesystem::directory_iterator(); ++key_it) {
-if (key_it->is_directory()) {
-std::string cache_key = key_it->path().filename().native();
-if (cache_key.size() > KEY_PREFIX_LENGTH) {
-std::string key_prefix =
-Path(_cache_base_path) / cache_key.substr(0,
KEY_PREFIX_LENGTH);
-bool exists = false;
-auto exists_status = fs->exists(key_prefix, &exists);
-if (!exists_status.ok()) {
-LOG(WARNING) << "Failed to check directory existence:
" << key_prefix
- << ", error: " <<
exists_status.to_string();
-return exists_status;
-}
-if (!exists) {
-auto create_status = fs->create_directory(key_prefix);
-if (!create_status.ok()) {
-LOG(WARNING) << "Failed to create directory: " <<
key_prefix
- << ", error: " <<
create_status.to_string();
-return create_status;
+std::vector file_list;
+RETURN_IF_ERROR(collect_directory_entries(_cache_base_path,
file_list));
+
+// this directory_iterator should be a problem in concurrent access
+for (const auto& key_it : file_list) {
+try {
+if (key_it->is_directory()) {
+std::string cache_key = key_it->path().filename().native();
+if (cache_key.size() > KEY_PREFIX_LENGTH) {
+std::string key_prefix =
+Path(_cache_base_path) / cache_key.substr(0,
KEY_PREFIX_LENGTH);
+bool exists = false;
+auto exists_status = fs->exists(key_prefix, &exists);
+if (!exists_status.ok()) {
+LOG(WARNING) << "Failed to check directory
existence: " << key_prefix
+ << ", error: " <<
exists_status.to_string();
+++failure_count;
+continue;
+}
+if (!exists) {
+auto create_status =
fs->create_directory(key_prefix);
+if (!create_status.ok() &&
+create_status.code() !=
TStatusCode::type::ALREADY_EXIST) {
+LOG(WARNING) << "Failed to create directory: "
<< key_prefix
+ << ", error: " <<
create_status.to_string();
+++failure_count;
+continue;
+}
+}
+auto rename_status = fs->rename(key_it->path(),
key_prefix / cache_key);
+if (rename_status.ok() ||
+rename_status.code() ==
TStatusCode::type::DIRECTORY_NOT_EMPTY) {
+++rename_count;
+} else {
+LOG(WARNING)
+<< "Failed to rename directory from " <<
key_it->path().native()
+<< " to " << (key_prefix /
cache_key).native()
+<< ", error: " <<
rename_status.to_string();
+++failure_count;
+continue;
}
-}
-auto rename_status = fs->rename(key_it->path(), key_prefix
/ cache_key);
-if (rename_status
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
hello-stephen commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2877441671 # BE Regression && UT Coverage Report Increment line coverage `76.47% (13/17)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/50726_0732e55b0e235899c8af1b833960ad1e917387ae_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/50726_0732e55b0e235899c8af1b833960ad1e917387ae_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 79.46% (20869/26264) | | Line Coverage | 72.70% (214860/295542) | | Region Coverage | 70.88% (126410/178356) | | Branch Coverage | 64.57% (65455/101374) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
hello-stephen commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2877155264 # BE UT Coverage Report Increment line coverage `70.59% (12/17)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/0732e55b0e235899c8af1b833960ad1e917387ae_0732e55b0e235899c8af1b833960ad1e917387ae/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/0732e55b0e235899c8af1b833960ad1e917387ae_0732e55b0e235899c8af1b833960ad1e917387ae/report/index.html) | Category | Coverage | |---|| | Function Coverage | 55.79% (14895/26698) | | Line Coverage | 44.60% (131848/295606) | | Region Coverage | 43.66% (66294/151856) | | Branch Coverage | 38.28% (33976/88766) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
doris-robot commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2876871172 ClickBench: Total hot run time: 28.62 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 0732e55b0e235899c8af1b833960ad1e917387ae, data reload: false query1 0.040.030.03 query2 0.120.100.12 query3 0.260.190.19 query4 1.600.200.20 query5 0.610.590.60 query6 1.190.720.73 query7 0.020.020.01 query8 0.040.030.04 query9 0.560.530.51 query10 0.570.580.56 query11 0.150.100.11 query12 0.140.110.11 query13 0.620.600.59 query14 0.780.820.80 query15 0.880.850.86 query16 0.390.380.37 query17 1.041.011.04 query18 0.230.210.22 query19 1.901.811.81 query20 0.010.010.01 query21 15.39 0.860.53 query22 0.781.170.65 query23 14.97 1.370.57 query24 7.401.380.47 query25 0.500.240.05 query26 0.580.160.14 query27 0.050.050.05 query28 9.850.870.42 query29 12.59 3.903.24 query30 0.250.110.06 query31 2.810.590.37 query32 3.230.540.46 query33 3.093.053.15 query34 15.80 5.114.50 query35 4.484.494.49 query36 0.680.490.47 query37 0.080.060.07 query38 0.060.040.03 query39 0.030.030.02 query40 0.170.150.13 query41 0.080.030.02 query42 0.030.020.02 query43 0.030.030.02 Total cold run time: 104.08 s Total hot run time: 28.62 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
doris-robot commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2876847161 TPC-DS: Total hot run time: 193992 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 0732e55b0e235899c8af1b833960ad1e917387ae, data reload: false query1 1394108310631063 query2 6165184118241824 query3 11051 451946904519 query4 53545 24721 23378 23378 query5 5186545 465 465 query6 379 213 195 195 query7 4946525 298 298 query8 328 257 246 246 query9 5999266126352635 query10 440 333 275 275 query11 15101 15070 15085 15070 query12 166 114 106 106 query13 1099529 420 420 query14 10067 627763046277 query15 208 195 184 184 query16 7077635 464 464 query17 1066747 573 573 query18 1500392 301 301 query19 198 195 162 162 query20 128 119 123 119 query21 209 134 105 105 query22 4488462744764476 query23 34275 33557 33615 33557 query24 6674241724272417 query25 481 465 415 415 query26 725 279 162 162 query27 2274514 359 359 query28 3103215821372137 query29 567 572 435 435 query30 273 224 189 189 query31 900 820 814 814 query32 74 66 66 66 query33 469 355 318 318 query34 761 888 559 559 query35 799 825 759 759 query36 951 1001876 876 query37 117 103 77 77 query38 4306425941564156 query39 1528144614351435 query40 211 116 109 109 query41 58 61 53 53 query42 126 111 117 111 query43 509 502 498 498 query44 1313845 829 829 query45 184 177 163 163 query46 868 1057671 671 query47 1891194817801780 query48 403 438 322 322 query49 691 536 446 446 query50 674 712 400 400 query51 4198419542414195 query52 118 108 100 100 query53 232 260 187 187 query54 632 605 542 542 query55 86 86 84 84 query56 337 311 316 311 query57 1246125611391139 query58 262 266 249 249 query59 2751277927482748 query60 338 328 313 313 query61 137 133 125 125 query62 701 733 694 694 query63 225 192 187 187 query64 18281014698 698 query65 4407430342134213 query66 726 409 358 358 query67 16075 15821 15553 15553 query68 5765880 527 527 query69 537 310 266 266 query70 1224112611051105 query71 442 331 296 296 query72 6022483649294836 query73 1258682 350 350 query74 9027890588068806 query75 3315325326762676 query76 39471192774 774 query77 528 423 292 292 query78 10037 10296 94509450 query79 1734874 577 577 query80 665 519 434 434 query81 502 245 219 219 query82 391 131 97 97 query83 259 261 236 236 query84 297 99 84 84 query85 748 350 312 312 query86 349 316 295 295 query87 4453440743824382 query88 2894230722542254 query89 400 334 294 294 query90 1670201 210 201 query91 141 140 110 110 query92 67 58 52 52 query93 2386923 579 579 query94 635 411 302 302 query95 360 284 289 284 query96 486 557 278 278 query97 3116324131423142 query98 244 223 204 204 query99 1303139813141314 Total cold run time: 295446 ms Total hot run time: 193992 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
doris-robot commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2876797175 TPC-H: Total hot run time: 33937 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 0732e55b0e235899c8af1b833960ad1e917387ae, data reload: false -- Round 1 -- q1 26001 501949994999 q2 2065293 188 188 q3 10376 1310705 705 q4 10223 1009534 534 q5 7516228824042288 q6 184 167 137 137 q7 928 767 618 618 q8 9317134710981098 q9 6802511050395039 q10 6886231719241924 q11 485 290 271 271 q12 348 348 216 216 q13 17769 365631063106 q14 229 227 214 214 q15 535 485 487 485 q16 429 433 373 373 q17 611 864 353 353 q18 7728716171707161 q19 1477955 572 572 q20 330 346 219 219 q21 3852334024552455 q22 10831033982 982 Total cold run time: 115174 ms Total hot run time: 33937 ms - Round 2, with runtime_filter_mode=off - q1 5141510851095108 q2 240 325 224 224 q3 2186266223052305 q4 1388182413771377 q5 4429438343624362 q6 216 178 129 129 q7 2059192917521752 q8 2556252925052505 q9 7326732070027002 q10 3050320527212721 q11 578 524 497 497 q12 706 755 617 617 q13 3514387232713271 q14 296 327 260 260 q15 544 493 485 485 q16 433 481 457 457 q17 1161159613681368 q18 7949751274327432 q19 816 829 976 829 q20 1962196019281928 q21 5195471247594712 q22 1130104610361036 Total cold run time: 52875 ms Total hot run time: 50377 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
freemandealer commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2876567589 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
freemandealer commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2874833566 run beut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
freemandealer commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2874730523 run cloud_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
freemandealer commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2865464767 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
doris-robot commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2865413619 TPC-H: Total hot run time: 33738 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 200c0fcc6ffabfded50abb1b408f9cfb7b5cbdd0, data reload: false -- Round 1 -- q1 26574 505749784978 q2 2084281 189 189 q3 10389 1243681 681 q4 10234 1008530 530 q5 7534235123112311 q6 183 162 132 132 q7 928 747 625 625 q8 9315125410441044 q9 6866510750895089 q10 6876229518901890 q11 507 282 272 272 q12 345 349 214 214 q13 17759 369230153015 q14 230 230 226 226 q15 516 488 482 482 q16 446 428 379 379 q17 673 853 380 380 q18 7401709670797079 q19 1550947 542 542 q20 342 330 216 216 q21 3994338825072507 q22 10131001957 957 Total cold run time: 115759 ms Total hot run time: 33738 ms - Round 2, with runtime_filter_mode=off - q1 5134505450655054 q2 228 321 228 228 q3 2152261522762276 q4 1353175713301330 q5 4421437743654365 q6 221 176 132 132 q7 2040191517721772 q8 2598255625602556 q9 7138718870397039 q10 3043315527162716 q11 569 507 476 476 q12 681 766 610 610 q13 3481381532563256 q14 298 306 306 306 q15 533 486 476 476 q16 451 466 439 439 q17 1130153113851385 q18 7723748974327432 q19 815 827 861 827 q20 2011195818481848 q21 5044478347274727 q22 10881050993 993 Total cold run time: 52152 ms Total hot run time: 50243 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
doris-robot commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2865578899 ClickBench: Total hot run time: 28.78 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit a46e6c371a43024e70c7a1a7faf6a80396d2ecf8, data reload: false query1 0.050.040.03 query2 0.120.110.11 query3 0.260.200.19 query4 1.600.180.18 query5 0.610.570.58 query6 1.190.720.72 query7 0.020.020.02 query8 0.040.060.03 query9 0.570.540.52 query10 0.580.570.59 query11 0.160.110.11 query12 0.150.110.11 query13 0.610.600.61 query14 0.780.810.81 query15 0.870.850.86 query16 0.370.380.40 query17 1.041.011.06 query18 0.210.200.19 query19 1.881.791.82 query20 0.010.010.01 query21 15.40 0.870.55 query22 0.761.210.68 query23 14.92 1.400.64 query24 6.891.670.47 query25 0.470.240.06 query26 0.670.160.13 query27 0.050.050.05 query28 8.850.870.43 query29 12.56 3.943.25 query30 0.260.090.07 query31 2.810.590.38 query32 3.220.550.46 query33 3.043.053.12 query34 15.75 5.104.45 query35 4.564.544.51 query36 0.660.500.49 query37 0.090.060.06 query38 0.050.040.04 query39 0.030.020.02 query40 0.170.130.12 query41 0.080.030.02 query42 0.030.020.02 query43 0.040.030.03 Total cold run time: 102.48 s Total hot run time: 28.78 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
doris-robot commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2865564559 TPC-DS: Total hot run time: 185900 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit a46e6c371a43024e70c7a1a7faf6a80396d2ecf8, data reload: false query1 998 480 512 480 query2 6563194919381938 query3 6734233 216 216 query4 25923 23865 23590 23590 query5 5806624 461 461 query6 309 205 193 193 query7 4648496 289 289 query8 311 256 241 241 query9 8657256025682560 query10 541 323 264 264 query11 15436 15566 14831 14831 query12 161 113 111 111 query13 1685536 404 404 query14 10907 611960856085 query15 250 198 176 176 query16 7793661 448 448 query17 1562747 582 582 query18 2035406 306 306 query19 267 188 181 181 query20 122 120 112 112 query21 219 124 113 113 query22 4055413440134013 query23 33789 32876 32888 32876 query24 8080239724112397 query25 504 470 383 383 query26 1210269 153 153 query27 2710491 335 335 query28 4376213421352134 query29 700 543 426 426 query30 286 223 183 183 query31 917 863 774 774 query32 76 63 61 61 query33 545 389 297 297 query34 796 837 524 524 query35 799 804 718 718 query36 988 1040894 894 query37 112 101 79 79 query38 4141413842034138 query39 1449139113931391 query40 209 121 106 106 query41 57 56 54 54 query42 120 110 106 106 query43 507 544 484 484 query44 1282792 796 792 query45 180 174 169 169 query46 849 1019625 625 query47 1725177917141714 query48 369 411 311 311 query49 752 488 419 419 query50 665 677 405 405 query51 4118405240954052 query52 104 102 102 102 query53 227 246 189 189 query54 586 587 494 494 query55 79 82 83 82 query56 309 302 288 288 query57 1110114510931093 query58 283 257 259 257 query59 2756282826662666 query60 329 315 312 312 query61 132 130 130 130 query62 762 712 656 656 query63 236 186 183 183 query64 42251018667 667 query65 4291421042504210 query66 1017414 308 308 query67 15620 15610 15335 15335 query68 8157891 511 511 query69 505 297 257 257 query70 1244111011221110 query71 512 326 286 286 query72 5784471447494714 query73 720 627 355 355 query74 8819907686888688 query75 4004320827082708 query76 37601182754 754 query77 780 384 281 281 query78 989610050 92949294 query79 2741817 580 580 query80 613 519 432 432 query81 496 249 220 220 query82 481 134 95 95 query83 276 249 247 247 query84 303 104 88 88 query85 760 353 308 308 query86 355 307 285 285 query87 4391430742624262 query88 3649221322112211 query89 384 321 278 278 query90 1939205 209 205 query91 148 149 123 123 query92 74 60 58 58 query93 1930974 579 579 query94 648 397 298 298 query95 369 291 280 280 query96 502 570 274 274 query97 3188324330963096 query98 243 210 206 206 query99 1445138212511251 Total cold run time: 278475 ms Total hot run time: 185900 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
doris-robot commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2865523226 TPC-H: Total hot run time: 34037 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit a46e6c371a43024e70c7a1a7faf6a80396d2ecf8, data reload: false -- Round 1 -- q1 26771 508550485048 q2 2080280 183 183 q3 10397 1265671 671 q4 10229 1009522 522 q5 7556234923572349 q6 185 160 132 132 q7 909 729 630 630 q8 9305129611461146 q9 6745508751245087 q10 6814230418861886 q11 503 288 289 288 q12 340 356 210 210 q13 17793 369130873087 q14 235 226 213 213 q15 517 480 475 475 q16 428 434 377 377 q17 611 842 385 385 q18 8090724871647164 q19 1226958 567 567 q20 347 339 229 229 q21 3980341324222422 q22 10271030966 966 Total cold run time: 116088 ms Total hot run time: 34037 ms - Round 2, with runtime_filter_mode=off - q1 5115510950475047 q2 232 331 227 227 q3 2177266322702270 q4 1352179713741374 q5 4194410041414100 q6 204 179 125 125 q7 1878180816451645 q8 2472251924132413 q9 6774671466036603 q10 2864308426472647 q11 568 485 476 476 q12 632 718 618 618 q13 3406370331073107 q14 265 276 273 273 q15 515 475 473 473 q16 425 476 429 429 q17 1098149113191319 q18 7209706271657062 q19 803 821 890 821 q20 1913196218351835 q21 4963466046704660 q22 1064997 973 973 Total cold run time: 50123 ms Total hot run time: 48497 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
doris-robot commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2865465109 ClickBench: Total hot run time: 29.01 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 200c0fcc6ffabfded50abb1b408f9cfb7b5cbdd0, data reload: false query1 0.040.030.03 query2 0.120.100.11 query3 0.260.190.19 query4 1.590.190.19 query5 0.590.600.59 query6 1.180.720.72 query7 0.030.020.02 query8 0.050.040.04 query9 0.570.530.53 query10 0.570.590.57 query11 0.150.110.10 query12 0.150.110.11 query13 0.610.590.59 query14 0.780.800.80 query15 0.870.840.86 query16 0.380.370.39 query17 1.071.061.06 query18 0.210.200.20 query19 1.891.781.85 query20 0.020.010.01 query21 15.40 0.870.56 query22 0.751.240.67 query23 14.89 1.390.67 query24 6.942.930.49 query25 0.480.310.12 query26 0.600.170.14 query27 0.050.050.05 query28 9.970.770.45 query29 12.54 3.893.26 query30 0.250.090.06 query31 2.840.590.37 query32 3.240.540.47 query33 3.083.063.08 query34 16.07 5.044.53 query35 4.534.504.49 query36 0.670.500.47 query37 0.080.060.06 query38 0.060.040.04 query39 0.030.020.02 query40 0.170.140.12 query41 0.080.030.02 query42 0.040.020.02 query43 0.030.030.03 Total cold run time: 103.92 s Total hot run time: 29.01 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
doris-robot commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2865452367 TPC-DS: Total hot run time: 192110 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 200c0fcc6ffabfded50abb1b408f9cfb7b5cbdd0, data reload: false query1 1398110210551055 query2 6340184017831783 query3 11003 455445224522 query4 51622 25754 23203 23203 query5 5148602 443 443 query6 341 202 203 202 query7 4876496 270 270 query8 302 254 240 240 query9 5433259425852585 query10 434 319 261 261 query11 14951 15003 14820 14820 query12 158 113 113 113 query13 1039530 405 405 query14 10104 616362966163 query15 209 205 181 181 query16 7131673 504 504 query17 1100729 595 595 query18 1561419 320 320 query19 208 201 175 175 query20 130 133 129 129 query21 210 135 104 104 query22 4450451244064406 query23 34028 33486 33109 33109 query24 6643238524502385 query25 454 459 409 409 query26 717 271 155 155 query27 2302528 336 336 query28 3032211820952095 query29 589 578 443 443 query30 288 230 197 197 query31 843 879 784 784 query32 68 69 69 69 query33 508 367 311 311 query34 773 865 513 513 query35 802 818 759 759 query36 949 1003902 902 query37 119 101 74 74 query38 4141418241874182 query39 1575142714451427 query40 208 120 108 108 query41 55 54 52 52 query42 122 112 114 112 query43 505 519 493 493 query44 1298803 824 803 query45 186 173 166 166 query46 870 1043632 632 query47 1864189418481848 query48 383 432 316 316 query49 685 484 435 435 query50 669 755 416 416 query51 4232423042124212 query52 107 112 102 102 query53 233 259 183 183 query54 578 572 530 530 query55 88 82 81 81 query56 317 295 282 282 query57 1164117711511151 query58 263 258 247 247 query59 2672277727662766 query60 328 334 298 298 query61 138 136 127 127 query62 761 767 671 671 query63 233 198 189 189 query64 19681065714 714 query65 4389429442244224 query66 753 405 307 307 query67 15947 15670 15398 15398 query68 6504902 521 521 query69 535 300 274 274 query70 1188114111191119 query71 499 312 282 282 query72 6019487050814870 query73 1524729 346 346 query74 8911914588178817 query75 4045320527162716 query76 42081177749 749 query77 761 381 287 287 query78 989210024 92249224 query79 2429809 564 564 query80 680 527 437 437 query81 481 255 223 223 query82 444 125 97 97 query83 301 250 235 235 query84 305 102 90 90 query85 775 366 323 323 query86 374 301 296 296 query87 4393445142694269 query88 3476215221982152 query89 408 314 284 284 query90 1862206 206 206 query91 220 139 110 110 query92 81 56 55 55 query93 2003950 577 577 query94 665 410 307 307 query95 369 290 292 290 query96 508 568 274 274 query97 3166324231533153 query98 248 208 200 200 query99 1430138312711271 Total cold run time: 295699 ms Total hot run time: 192110 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
freemandealer commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2865313932 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
raiderss commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2864853438 Impressive project! Eyes Store community would find this quite useful for FiveM development. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
freemandealer commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2863883124 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) make file cache version upgrade faster [doris]
hello-stephen commented on PR #50726: URL: https://github.com/apache/doris/pull/50726#issuecomment-2863882940 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
