Re: [PR] [feat](function) json_array return json binary instead of string. [doris]
github-actions[bot] closed pull request #51613: [feat](function) json_array return json binary instead of string. URL: https://github.com/apache/doris/pull/51613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat](function) json_array return json binary instead of string. [doris]
github-actions[bot] commented on PR #51613: URL: https://github.com/apache/doris/pull/51613#issuecomment-3629598583 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat](function) json_array return json binary instead of string. [doris]
amorynan commented on code in PR #51613: URL: https://github.com/apache/doris/pull/51613#discussion_r2139362742 ## be/src/vec/data_types/serde/data_type_jsonb_serde.cpp: ## @@ -294,5 +295,18 @@ Status DataTypeJsonbSerDe::read_column_from_pb(IColumn& column, const PValues& a } return Status::OK(); } + +Status DataTypeJsonbSerDe::write_column_to_jsonb(const IColumn& column, JsonbWriter** results, Review Comment: If U add new interface for Serde, please add UT case for it . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat](function) json_array return json binary instead of string. [doris]
hello-stephen commented on PR #51613: URL: https://github.com/apache/doris/pull/51613#issuecomment-2961255358 # BE Regression && UT Coverage Report Increment line coverage `79.34% (192/242)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/51613_49dfb1b7ddabd714d188c3a123dc713f6bda88b7_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/51613_49dfb1b7ddabd714d188c3a123dc713f6bda88b7_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 79.79% (21012/26333) | | Line Coverage | 72.72% (216954/298359) | | Region Coverage | 70.89% (127801/180293) | | Branch Coverage | 64.58% (66148/102426) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat](function) json_array return json binary instead of string. [doris]
hello-stephen commented on PR #51613: URL: https://github.com/apache/doris/pull/51613#issuecomment-2961230660 # BE Regression && UT Coverage Report Increment line coverage `79.34% (192/242)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/51613_49dfb1b7ddabd714d188c3a123dc713f6bda88b7_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/51613_49dfb1b7ddabd714d188c3a123dc713f6bda88b7_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 79.79% (21012/26333) | | Line Coverage | 72.72% (216954/298359) | | Region Coverage | 70.89% (127801/180293) | | Branch Coverage | 64.58% (66148/102426) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat](function) json_array return json binary instead of string. [doris]
doris-robot commented on PR #51613: URL: https://github.com/apache/doris/pull/51613#issuecomment-2961220598 # BE UT Coverage Report Increment line coverage `56.20% (136/242)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/49dfb1b7ddabd714d188c3a123dc713f6bda88b7_49dfb1b7ddabd714d188c3a123dc713f6bda88b7/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/49dfb1b7ddabd714d188c3a123dc713f6bda88b7_49dfb1b7ddabd714d188c3a123dc713f6bda88b7/report/index.html) | Category | Coverage | |---|| | Function Coverage | 56.40% (15089/26755) | | Line Coverage | 45.16% (134803/298527) | | Region Coverage | 44.25% (67828/153285) | | Branch Coverage | 38.81% (34779/89606) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat](function) json_array return json binary instead of string. [doris]
doris-robot commented on PR #51613: URL: https://github.com/apache/doris/pull/51613#issuecomment-2958945552 ClickBench: Total hot run time: 29.56 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 49dfb1b7ddabd714d188c3a123dc713f6bda88b7, data reload: false query1 0.040.040.03 query2 0.130.110.10 query3 0.250.200.20 query4 1.600.190.20 query5 0.440.440.44 query6 1.530.660.67 query7 0.020.020.01 query8 0.040.030.04 query9 0.570.510.52 query10 0.570.580.58 query11 0.150.110.10 query12 0.150.120.11 query13 0.630.600.60 query14 0.800.810.82 query15 0.870.840.85 query16 0.390.390.38 query17 1.031.081.03 query18 0.230.210.21 query19 1.881.871.83 query20 0.010.010.01 query21 15.40 0.910.53 query22 0.751.110.67 query23 15.12 1.380.65 query24 6.800.981.15 query25 0.510.250.11 query26 0.580.150.15 query27 0.050.050.05 query28 10.11 0.910.45 query29 12.52 4.043.37 query30 0.250.090.06 query31 2.820.600.40 query32 3.230.550.47 query33 3.163.203.14 query34 15.69 5.184.51 query35 4.564.574.54 query36 0.670.500.48 query37 0.090.060.06 query38 0.050.040.04 query39 0.030.020.02 query40 0.170.130.13 query41 0.080.020.03 query42 0.030.030.03 query43 0.040.030.04 Total cold run time: 104.04 s Total hot run time: 29.56 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat](function) json_array return json binary instead of string. [doris]
doris-robot commented on PR #51613: URL: https://github.com/apache/doris/pull/51613#issuecomment-2958929864 TPC-DS: Total hot run time: 193481 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 49dfb1b7ddabd714d188c3a123dc713f6bda88b7, data reload: false query1 1440107710681068 query2 6420182818621828 query3 11178 461846474618 query4 25728 23428 23327 23327 query5 3591638 492 492 query6 308 241 213 213 query7 3999509 289 289 query8 271 228 208 208 query9 8489266626722666 query10 471 327 273 273 query11 15221 15012 14724 14724 query12 169 107 108 107 query13 1583536 403 403 query14 8556619662236196 query15 204 196 169 169 query16 7292652 424 424 query17 1222718 603 603 query18 1980427 324 324 query19 205 200 161 161 query20 132 131 132 131 query21 207 129 116 116 query22 4400450845094508 query23 34797 33719 33804 33719 query24 8685245524852455 query25 515 488 401 401 query26 1067279 150 150 query27 2911524 355 355 query28 4426219121872187 query29 711 592 455 455 query30 274 225 227 225 query31 924 877 797 797 query32 75 64 62 62 query33 540 354 335 335 query34 835 863 552 552 query35 798 809 757 757 query36 925 985 922 922 query37 110 102 80 80 query38 4193430542364236 query39 1520146914551455 query40 216 120 114 114 query41 60 60 55 55 query42 130 109 117 109 query43 526 517 510 510 query44 1395848 832 832 query45 189 174 175 174 query46 872 1031654 654 query47 1825192417851785 query48 402 438 318 318 query49 726 518 423 423 query50 707 711 415 415 query51 4257427641944194 query52 111 117 100 100 query53 235 263 185 185 query54 585 594 507 507 query55 94 89 89 89 query56 322 308 306 306 query57 1222125911641164 query58 286 271 268 268 query59 2751286026702670 query60 364 350 318 318 query61 124 125 119 119 query62 758 742 669 669 query63 238 199 189 189 query64 38031072705 705 query65 4346423342774233 query66 983 407 317 317 query67 16178 15603 15380 15380 query68 8810908 523 523 query69 491 317 283 283 query70 1183111610941094 query71 467 336 300 300 query72 5852482849494828 query73 725 656 364 364 query74 8979906189108910 query75 3945322226802680 query76 36391199799 799 query77 777 375 286 286 query78 10008 10419 94749474 query79 2097818 578 578 query80 596 510 448 448 query81 488 249 224 224 query82 506 130 95 95 query83 252 253 229 229 query84 242 99 90 90 query85 775 446 322 322 query86 377 304 276 276 query87 4425448143794379 query88 3602229022632263 query89 412 330 281 281 query90 1798214 210 210 query91 139 142 110 110 query92 80 59 66 59 query93 1723969 579 579 query94 639 412 312 312 query95 371 300 281 281 query96 496 565 279 279 query97 2751274526612661 query98 233 206 201 201 query99 1440141512701270 Total cold run time: 278395 ms Total hot run time: 193481 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [feat](function) json_array return json binary instead of string. [doris]
hello-stephen commented on PR #51613: URL: https://github.com/apache/doris/pull/51613#issuecomment-2958879440 # FE UT Coverage Report Increment line coverage ` 0.00% (0/3)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/51613_49dfb1b7ddabd714d188c3a123dc713f6bda88b7/fe_increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/51613_49dfb1b7ddabd714d188c3a123dc713f6bda88b7/fe_report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat](function) json_array return json binary instead of string. [doris]
doris-robot commented on PR #51613: URL: https://github.com/apache/doris/pull/51613#issuecomment-295887 TPC-H: Total hot run time: 34062 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 49dfb1b7ddabd714d188c3a123dc713f6bda88b7, data reload: false -- Round 1 -- q1 26664 576150565056 q2 1987297 188 188 q3 10431 1261699 699 q4 10239 989 546 546 q5 7671237523032303 q6 182 164 133 133 q7 997 729 610 610 q8 9331132310981098 q9 6774521451325132 q10 6895233319661966 q11 480 295 283 283 q12 347 352 222 222 q13 17799 371231523152 q14 232 233 207 207 q15 550 494 492 492 q16 434 439 370 370 q17 633 867 366 366 q18 7538718771527152 q19 21841000576 576 q20 325 336 223 223 q21 3824314723452345 q22 1048996 943 943 Total cold run time: 116565 ms Total hot run time: 34062 ms - Round 2, with runtime_filter_mode=off - q1 5187501550055005 q2 241 323 216 216 q3 2175267922832283 q4 1405184414671467 q5 4469442344104410 q6 220 171 130 130 q7 2024192817791779 q8 2622261725012501 q9 7320717671687168 q10 3006321427772777 q11 579 526 491 491 q12 701 748 605 605 q13 3501387933253325 q14 293 294 279 279 q15 521 475 468 468 q16 433 497 437 437 q17 1185156413401340 q18 7812752574647464 q19 871 842 941 842 q20 1965197218631863 q21 4812445444224422 q22 1132105310231023 Total cold run time: 52474 ms Total hot run time: 50295 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat](function) json_array return json binary instead of string. [doris]
mrhhsg commented on PR #51613: URL: https://github.com/apache/doris/pull/51613#issuecomment-2958451764 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat](function) json_array return json binary instead of string. [doris]
Thearas commented on PR #51613: URL: https://github.com/apache/doris/pull/51613#issuecomment-2958437958 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
