Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
yujun777 commented on code in PR #45081: URL: https://github.com/apache/doris/pull/45081#discussion_r1879313557 ## regression-test/data/nereids_hint_tpcds_p0/shape/query13.out: ## @@ -7,7 +7,7 @@ PhysicalResultSink PhysicalProject --hashJoin[INNER_JOIN broadcast] hashCondition=((store.s_store_sk = store_sales.ss_store_sk)) otherCondition=() build RFs:RF4 s_store_sk->[ss_store_sk] PhysicalProject ---hashJoin[INNER_JOIN shuffle] hashCondition=((customer_demographics.cd_demo_sk = store_sales.ss_cdemo_sk)) otherCondition=(OR[AND[(household_demographics.hd_dep_count = 1),cd_marital_status IN ('D', 'W'),cd_education_status IN ('2 yr Degree', 'Primary'),OR[AND[(customer_demographics.cd_marital_status = 'D'),(customer_demographics.cd_education_status = 'Primary'),(store_sales.ss_sales_price >= 50.00),(store_sales.ss_sales_price <= 100.00)],AND[(customer_demographics.cd_marital_status = 'W'),(customer_demographics.cd_education_status = '2 yr Degree'),(store_sales.ss_sales_price >= 150.00),(store_sales.ss_sales_price <= 200.00)]]],AND[(customer_demographics.cd_marital_status = 'M'),(customer_demographics.cd_education_status = 'College'),(store_sales.ss_sales_price >= 100.00),(store_sales.ss_sales_price <= 150.00),(household_demographics.hd_dep_count = 3)]]) build RFs:RF3 ss_cdemo_sk->[cd_demo_sk] +--hashJoin[INNER_JOIN shuffle] hashCondition=((customer_demographics.cd_demo_sk = store_sales.ss_cdemo_sk)) otherCondition=(OR[AND[(household_demographics.hd_dep_count = 1),cd_marital_status IN ('D', 'W'),cd_education_status IN ('2 yr Degree', 'Primary'),OR[AND[(customer_demographics.cd_marital_status = 'D'),(customer_demographics.cd_education_status = 'Primary'),(store_sales.ss_sales_price <= 100.00)],AND[(customer_demographics.cd_marital_status = 'W'),(customer_demographics.cd_education_status = '2 yr Degree'),(store_sales.ss_sales_price >= 150.00)]]],AND[(customer_demographics.cd_marital_status = 'M'),(customer_demographics.cd_education_status = 'College'),(store_sales.ss_sales_price >= 100.00),(store_sales.ss_sales_price <= 150.00),(household_demographics.hd_dep_count = 3)]]) build RFs:RF3 ss_cdemo_sk->[cd_demo_sk] Review Comment: had push down to children -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
yujun777 commented on code in PR #45081: URL: https://github.com/apache/doris/pull/45081#discussion_r1879312615 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/AddMinMax.java: ## @@ -0,0 +1,378 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.rules.expression.rules; + +import org.apache.doris.nereids.rules.expression.ExpressionPatternMatcher; +import org.apache.doris.nereids.rules.expression.ExpressionPatternRuleFactory; +import org.apache.doris.nereids.rules.expression.ExpressionRewriteContext; +import org.apache.doris.nereids.rules.expression.rules.RangeInference.DiscreteValue; +import org.apache.doris.nereids.rules.expression.rules.RangeInference.EmptyValue; +import org.apache.doris.nereids.rules.expression.rules.RangeInference.RangeValue; +import org.apache.doris.nereids.rules.expression.rules.RangeInference.UnknownValue; +import org.apache.doris.nereids.rules.expression.rules.RangeInference.ValueDesc; +import org.apache.doris.nereids.trees.expressions.ComparisonPredicate; +import org.apache.doris.nereids.trees.expressions.CompoundPredicate; +import org.apache.doris.nereids.trees.expressions.EqualTo; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.GreaterThan; +import org.apache.doris.nereids.trees.expressions.GreaterThanEqual; +import org.apache.doris.nereids.trees.expressions.LessThan; +import org.apache.doris.nereids.trees.expressions.LessThanEqual; +import org.apache.doris.nereids.trees.expressions.SlotReference; +import org.apache.doris.nereids.trees.expressions.literal.BooleanLiteral; +import org.apache.doris.nereids.trees.expressions.literal.Literal; +import org.apache.doris.nereids.util.ExpressionUtils; + +import com.google.common.collect.BoundType; +import com.google.common.collect.ImmutableList; +import com.google.common.collect.Lists; +import com.google.common.collect.Maps; +import com.google.common.collect.Range; +import com.google.common.collect.Sets; +import org.apache.commons.lang3.NotImplementedException; + +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.stream.Collectors; + +/** + * This class implements the function to add min max to or expression. + * for example: Review Comment: add test later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
starocean999 merged PR #45081: URL: https://github.com/apache/doris/pull/45081 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
xzj7019 commented on code in PR #45081: URL: https://github.com/apache/doris/pull/45081#discussion_r1879255731 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/AddMinMax.java: ## @@ -0,0 +1,378 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.rules.expression.rules; + +import org.apache.doris.nereids.rules.expression.ExpressionPatternMatcher; +import org.apache.doris.nereids.rules.expression.ExpressionPatternRuleFactory; +import org.apache.doris.nereids.rules.expression.ExpressionRewriteContext; +import org.apache.doris.nereids.rules.expression.rules.RangeInference.DiscreteValue; +import org.apache.doris.nereids.rules.expression.rules.RangeInference.EmptyValue; +import org.apache.doris.nereids.rules.expression.rules.RangeInference.RangeValue; +import org.apache.doris.nereids.rules.expression.rules.RangeInference.UnknownValue; +import org.apache.doris.nereids.rules.expression.rules.RangeInference.ValueDesc; +import org.apache.doris.nereids.trees.expressions.ComparisonPredicate; +import org.apache.doris.nereids.trees.expressions.CompoundPredicate; +import org.apache.doris.nereids.trees.expressions.EqualTo; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.GreaterThan; +import org.apache.doris.nereids.trees.expressions.GreaterThanEqual; +import org.apache.doris.nereids.trees.expressions.LessThan; +import org.apache.doris.nereids.trees.expressions.LessThanEqual; +import org.apache.doris.nereids.trees.expressions.SlotReference; +import org.apache.doris.nereids.trees.expressions.literal.BooleanLiteral; +import org.apache.doris.nereids.trees.expressions.literal.Literal; +import org.apache.doris.nereids.util.ExpressionUtils; + +import com.google.common.collect.BoundType; +import com.google.common.collect.ImmutableList; +import com.google.common.collect.Lists; +import com.google.common.collect.Maps; +import com.google.common.collect.Range; +import com.google.common.collect.Sets; +import org.apache.commons.lang3.NotImplementedException; + +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.stream.Collectors; + +/** + * This class implements the function to add min max to or expression. + * for example: Review Comment: my feeling is only to extract the predicate which can be pushed down and DON'T change the original complex compound expression to avoid some unexpected correctness issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
xzj7019 commented on code in PR #45081: URL: https://github.com/apache/doris/pull/45081#discussion_r1879254172 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/AddMinMax.java: ## @@ -0,0 +1,378 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.rules.expression.rules; + +import org.apache.doris.nereids.rules.expression.ExpressionPatternMatcher; +import org.apache.doris.nereids.rules.expression.ExpressionPatternRuleFactory; +import org.apache.doris.nereids.rules.expression.ExpressionRewriteContext; +import org.apache.doris.nereids.rules.expression.rules.RangeInference.DiscreteValue; +import org.apache.doris.nereids.rules.expression.rules.RangeInference.EmptyValue; +import org.apache.doris.nereids.rules.expression.rules.RangeInference.RangeValue; +import org.apache.doris.nereids.rules.expression.rules.RangeInference.UnknownValue; +import org.apache.doris.nereids.rules.expression.rules.RangeInference.ValueDesc; +import org.apache.doris.nereids.trees.expressions.ComparisonPredicate; +import org.apache.doris.nereids.trees.expressions.CompoundPredicate; +import org.apache.doris.nereids.trees.expressions.EqualTo; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.GreaterThan; +import org.apache.doris.nereids.trees.expressions.GreaterThanEqual; +import org.apache.doris.nereids.trees.expressions.LessThan; +import org.apache.doris.nereids.trees.expressions.LessThanEqual; +import org.apache.doris.nereids.trees.expressions.SlotReference; +import org.apache.doris.nereids.trees.expressions.literal.BooleanLiteral; +import org.apache.doris.nereids.trees.expressions.literal.Literal; +import org.apache.doris.nereids.util.ExpressionUtils; + +import com.google.common.collect.BoundType; +import com.google.common.collect.ImmutableList; +import com.google.common.collect.Lists; +import com.google.common.collect.Maps; +import com.google.common.collect.Range; +import com.google.common.collect.Sets; +import org.apache.commons.lang3.NotImplementedException; + +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.stream.Collectors; + +/** + * This class implements the function to add min max to or expression. + * for example: Review Comment: this kind of change is aggressive and pls add rqg later to ensure the rewrite's correctness. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
xzj7019 commented on code in PR #45081: URL: https://github.com/apache/doris/pull/45081#discussion_r1879247382 ## regression-test/data/nereids_hint_tpcds_p0/shape/query13.out: ## @@ -7,7 +7,7 @@ PhysicalResultSink PhysicalProject --hashJoin[INNER_JOIN broadcast] hashCondition=((store.s_store_sk = store_sales.ss_store_sk)) otherCondition=() build RFs:RF4 s_store_sk->[ss_store_sk] PhysicalProject ---hashJoin[INNER_JOIN shuffle] hashCondition=((customer_demographics.cd_demo_sk = store_sales.ss_cdemo_sk)) otherCondition=(OR[AND[(household_demographics.hd_dep_count = 1),cd_marital_status IN ('D', 'W'),cd_education_status IN ('2 yr Degree', 'Primary'),OR[AND[(customer_demographics.cd_marital_status = 'D'),(customer_demographics.cd_education_status = 'Primary'),(store_sales.ss_sales_price >= 50.00),(store_sales.ss_sales_price <= 100.00)],AND[(customer_demographics.cd_marital_status = 'W'),(customer_demographics.cd_education_status = '2 yr Degree'),(store_sales.ss_sales_price >= 150.00),(store_sales.ss_sales_price <= 200.00)]]],AND[(customer_demographics.cd_marital_status = 'M'),(customer_demographics.cd_education_status = 'College'),(store_sales.ss_sales_price >= 100.00),(store_sales.ss_sales_price <= 150.00),(household_demographics.hd_dep_count = 3)]]) build RFs:RF3 ss_cdemo_sk->[cd_demo_sk] +--hashJoin[INNER_JOIN shuffle] hashCondition=((customer_demographics.cd_demo_sk = store_sales.ss_cdemo_sk)) otherCondition=(OR[AND[(household_demographics.hd_dep_count = 1),cd_marital_status IN ('D', 'W'),cd_education_status IN ('2 yr Degree', 'Primary'),OR[AND[(customer_demographics.cd_marital_status = 'D'),(customer_demographics.cd_education_status = 'Primary'),(store_sales.ss_sales_price <= 100.00)],AND[(customer_demographics.cd_marital_status = 'W'),(customer_demographics.cd_education_status = '2 yr Degree'),(store_sales.ss_sales_price >= 150.00)]]],AND[(customer_demographics.cd_marital_status = 'M'),(customer_demographics.cd_education_status = 'College'),(store_sales.ss_sales_price >= 100.00),(store_sales.ss_sales_price <= 150.00),(household_demographics.hd_dep_count = 3)]]) build RFs:RF3 ss_cdemo_sk->[cd_demo_sk] Review Comment: why >= 50.00 and <=200.00 are lost? is it pushed down to the basic table? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
xzj7019 commented on code in PR #45081: URL: https://github.com/apache/doris/pull/45081#discussion_r1879247382 ## regression-test/data/nereids_hint_tpcds_p0/shape/query13.out: ## @@ -7,7 +7,7 @@ PhysicalResultSink PhysicalProject --hashJoin[INNER_JOIN broadcast] hashCondition=((store.s_store_sk = store_sales.ss_store_sk)) otherCondition=() build RFs:RF4 s_store_sk->[ss_store_sk] PhysicalProject ---hashJoin[INNER_JOIN shuffle] hashCondition=((customer_demographics.cd_demo_sk = store_sales.ss_cdemo_sk)) otherCondition=(OR[AND[(household_demographics.hd_dep_count = 1),cd_marital_status IN ('D', 'W'),cd_education_status IN ('2 yr Degree', 'Primary'),OR[AND[(customer_demographics.cd_marital_status = 'D'),(customer_demographics.cd_education_status = 'Primary'),(store_sales.ss_sales_price >= 50.00),(store_sales.ss_sales_price <= 100.00)],AND[(customer_demographics.cd_marital_status = 'W'),(customer_demographics.cd_education_status = '2 yr Degree'),(store_sales.ss_sales_price >= 150.00),(store_sales.ss_sales_price <= 200.00)]]],AND[(customer_demographics.cd_marital_status = 'M'),(customer_demographics.cd_education_status = 'College'),(store_sales.ss_sales_price >= 100.00),(store_sales.ss_sales_price <= 150.00),(household_demographics.hd_dep_count = 3)]]) build RFs:RF3 ss_cdemo_sk->[cd_demo_sk] +--hashJoin[INNER_JOIN shuffle] hashCondition=((customer_demographics.cd_demo_sk = store_sales.ss_cdemo_sk)) otherCondition=(OR[AND[(household_demographics.hd_dep_count = 1),cd_marital_status IN ('D', 'W'),cd_education_status IN ('2 yr Degree', 'Primary'),OR[AND[(customer_demographics.cd_marital_status = 'D'),(customer_demographics.cd_education_status = 'Primary'),(store_sales.ss_sales_price <= 100.00)],AND[(customer_demographics.cd_marital_status = 'W'),(customer_demographics.cd_education_status = '2 yr Degree'),(store_sales.ss_sales_price >= 150.00)]]],AND[(customer_demographics.cd_marital_status = 'M'),(customer_demographics.cd_education_status = 'College'),(store_sales.ss_sales_price >= 100.00),(store_sales.ss_sales_price <= 150.00),(household_demographics.hd_dep_count = 3)]]) build RFs:RF3 ss_cdemo_sk->[cd_demo_sk] Review Comment: why >= 50.00 and <=200.00 are lost? pls check the result's correctness. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
yujun777 commented on code in PR #45081: URL: https://github.com/apache/doris/pull/45081#discussion_r1879223475 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/ExpressionOptimization.java: ## @@ -58,6 +59,20 @@ public class ExpressionOptimization extends ExpressionRewrite { BetweenToEqual.INSTANCE ) ); + +/** + * don't use it with PushDownFilterThroughJoin, it may cause dead loop: + * LogicalFilter(origin expr) + * => LogicalFilter((origin expr) and (add min max range)) + * => LogicalFilter((origin expr)) // use PushDownFilterThroughJoin + * => ... + */ +public static final List ADD_RANGE = ImmutableList.of( Review Comment: ming hong said it may add OrToIn to this rule set later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
xzj7019 commented on code in PR #45081: URL: https://github.com/apache/doris/pull/45081#discussion_r1879222906 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/ExpressionOptimization.java: ## @@ -58,6 +59,20 @@ public class ExpressionOptimization extends ExpressionRewrite { BetweenToEqual.INSTANCE ) ); + +/** + * don't use it with PushDownFilterThroughJoin, it may cause dead loop: + * LogicalFilter(origin expr) + * => LogicalFilter((origin expr) and (add min max range)) + * => LogicalFilter((origin expr)) // use PushDownFilterThroughJoin + * => ... + */ +public static final List ADD_RANGE = ImmutableList.of( Review Comment: is this possible to add other similar processing rule in the future? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
yujun777 commented on code in PR #45081: URL: https://github.com/apache/doris/pull/45081#discussion_r1879221458 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/ExpressionOptimization.java: ## @@ -58,6 +59,20 @@ public class ExpressionOptimization extends ExpressionRewrite { BetweenToEqual.INSTANCE ) ); + +/** + * don't use it with PushDownFilterThroughJoin, it may cause dead loop: + * LogicalFilter(origin expr) + * => LogicalFilter((origin expr) and (add min max range)) + * => LogicalFilter((origin expr)) // use PushDownFilterThroughJoin + * => ... + */ +public static final List ADD_RANGE = ImmutableList.of( Review Comment: the annotation said it cause dead loop with push down filter through join. so seperate it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
xzj7019 commented on code in PR #45081: URL: https://github.com/apache/doris/pull/45081#discussion_r1879219943 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/ExpressionOptimization.java: ## @@ -58,6 +59,20 @@ public class ExpressionOptimization extends ExpressionRewrite { BetweenToEqual.INSTANCE ) ); + +/** + * don't use it with PushDownFilterThroughJoin, it may cause dead loop: + * LogicalFilter(origin expr) + * => LogicalFilter((origin expr) and (add min max range)) + * => LogicalFilter((origin expr)) // use PushDownFilterThroughJoin + * => ... + */ +public static final List ADD_RANGE = ImmutableList.of( Review Comment: pls add explain that why splitting this as a separate rule set -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
github-actions[bot] commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2531619122 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
github-actions[bot] commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2531619021 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
doris-robot commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2531442766 ClickBench: Total hot run time: 33.01 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 12743b18062e458f1aa4a72c5f38495506277617, data reload: false query1 0.030.030.03 query2 0.070.040.04 query3 0.230.070.07 query4 1.620.100.11 query5 0.410.430.43 query6 1.170.650.65 query7 0.010.020.02 query8 0.040.030.02 query9 0.580.490.51 query10 0.550.570.57 query11 0.140.110.11 query12 0.130.110.11 query13 0.610.620.59 query14 2.742.712.73 query15 0.900.830.82 query16 0.400.400.37 query17 0.981.021.04 query18 0.220.210.21 query19 1.871.881.92 query20 0.010.010.01 query21 15.37 0.610.58 query22 2.802.582.33 query23 17.04 0.880.74 query24 3.040.851.58 query25 0.190.090.27 query26 0.420.130.14 query27 0.040.040.04 query28 10.36 1.111.08 query29 12.56 3.293.26 query30 0.240.060.06 query31 2.870.380.38 query32 3.270.470.46 query33 3.003.023.06 query34 17.23 4.504.48 query35 4.564.574.49 query36 0.670.480.47 query37 0.090.060.06 query38 0.040.040.03 query39 0.030.030.02 query40 0.170.120.13 query41 0.070.020.02 query42 0.040.020.02 query43 0.040.030.03 Total cold run time: 106.85 s Total hot run time: 33.01 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
doris-robot commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2531403316 TPC-DS: Total hot run time: 197152 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 12743b18062e458f1aa4a72c5f38495506277617, data reload: false query1 1279967 1011967 query2 6236213219961996 query3 11120 443645314436 query4 67212 29006 23585 23585 query5 5021467 446 446 query6 403 177 175 175 query7 5470312 312 312 query8 329 250 245 245 query9 8711271827112711 query10 430 247 265 247 query11 17319 15315 15924 15315 query12 152 102 105 102 query13 1484417 408 408 query14 10946 686174366861 query15 219 195 203 195 query16 7252490 469 469 query17 1240599 596 596 query18 1823314 311 311 query19 207 157 160 157 query20 128 113 115 113 query21 212 105 105 105 query22 4839473943804380 query23 35353 34326 34469 34326 query24 5366256024682468 query25 493 376 386 376 query26 658 163 154 154 query27 1986289 288 288 query28 4727248624442444 query29 678 419 435 419 query30 215 149 156 149 query31 1021830 824 824 query32 103 53 56 53 query33 498 298 307 298 query34 972 528 532 528 query35 892 774 765 765 query36 1106935 956 935 query37 126 77 75 75 query38 4622468644784478 query39 1505146314961463 query40 191 107 103 103 query41 44 41 41 41 query42 109 100 102 100 query43 542 501 512 501 query44 1194828 824 824 query45 201 177 175 175 query46 1180762 795 762 query47 2023194819401940 query48 424 320 331 320 query49 721 394 398 394 query50 851 401 391 391 query51 7395722970067006 query52 102 89 92 89 query53 257 179 184 179 query54 507 389 401 389 query55 83 76 77 76 query56 251 231 256 231 query57 1236115811191119 query58 216 211 214 211 query59 3143312432743124 query60 264 242 247 242 query61 113 105 113 105 query62 763 675 669 669 query63 219 192 195 192 query64 1367663 633 633 query65 3300319231893189 query66 690 318 306 306 query67 15909 15794 15601 15601 query68 3894568 566 566 query69 422 253 252 252 query70 1221111611531116 query71 347 252 240 240 query72 6486416739733973 query73 788 353 367 353 query74 10133 911290409040 query75 3422268026842680 query76 1877103811901038 query77 493 287 269 269 query78 10482 945994269426 query79 1457606 595 595 query80 857 445 461 445 query81 497 240 234 234 query82 1277126 123 123 query83 158 161 147 147 query84 281 78 70 70 query85 889 375 305 305 query86 348 299 299 299 query87 4821455246244552 query88 3459224522022202 query89 420 298 288 288 query90 1935191 191 191 query91 138 103 105 103 query92 65 52 52 52 query93 1960549 549 549 query94 732 310 315 310 query95 350 259 311 259 query96 623 275 279 275 query97 2808271026222622 query98 215 203 197 197 query99 1830129413221294 Total cold run time: 320333 ms Total hot run time: 197152 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
doris-robot commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2531344557 TPC-H: Total hot run time: 39893 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 12743b18062e458f1aa4a72c5f38495506277617, data reload: false -- Round 1 -- q1 17561 753172837283 q2 2043173 159 159 q3 10660 109912071099 q4 10556 773 759 759 q5 7586271926932693 q6 241 148 147 147 q7 974 616 615 615 q8 9245187419161874 q9 6664653764906490 q10 6998232722802280 q11 474 259 262 259 q12 426 225 223 223 q13 1 304329842984 q14 243 203 213 203 q15 580 530 513 513 q16 673 593 574 574 q17 994 613 567 567 q18 7114670166496649 q19 13521024951 951 q20 466 184 176 176 q21 3990323930763076 q22 382 324 319 319 Total cold run time: 106999 ms Total hot run time: 39893 ms - Round 2, with runtime_filter_mode=off - q1 7253721772367217 q2 331 227 231 227 q3 2882279929572799 q4 2088186018201820 q5 5723563356385633 q6 220 138 137 137 q7 2230183518201820 q8 3353356934893489 q9 9027909990659065 q10 3565352335613523 q11 606 494 514 494 q12 835 591 571 571 q13 12358 325132543251 q14 302 274 281 274 q15 578 525 527 525 q16 686 647 644 644 q17 1853162715791579 q18 8238771975327532 q19 1693164014751475 q20 2139186518601860 q21 5703538553815381 q22 658 551 545 545 Total cold run time: 72321 ms Total hot run time: 59861 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
yujun777 commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2531278798 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
yujun777 commented on code in PR #45081: URL: https://github.com/apache/doris/pull/45081#discussion_r1877897563 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/ExpressionOptimization.java: ## @@ -58,6 +59,13 @@ public class ExpressionOptimization extends ExpressionRewrite { BetweenToEqual.INSTANCE ) ); + +public static final List OPTIMIZE_REWRITE_RULES_OR_ADD_RANGE = ImmutableList.of( Review Comment: fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
yujun777 commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2531266133 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
yujun777 commented on code in PR #45081: URL: https://github.com/apache/doris/pull/45081#discussion_r1877897036 ## fe/fe-core/src/test/java/org/apache/doris/nereids/rules/expression/SimplifyRangeTest.java: ## @@ -62,7 +66,7 @@ public SimplifyRangeTest() { @Test public void testSimplify() { executor = new ExpressionRuleExecutor(ImmutableList.of( -bottomUp(SimplifyRange.INSTANCE) +bottomUp(SimplifyRange.INSTANCE, OrAddMinMax.INSTANCE) Review Comment: add ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/OrAddMinMax.java: ## @@ -0,0 +1,378 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.rules.expression.rules; + +import org.apache.doris.nereids.rules.expression.ExpressionPatternMatcher; +import org.apache.doris.nereids.rules.expression.ExpressionPatternRuleFactory; +import org.apache.doris.nereids.rules.expression.ExpressionRewriteContext; +import org.apache.doris.nereids.rules.expression.rules.RangeInference.DiscreteValue; +import org.apache.doris.nereids.rules.expression.rules.RangeInference.EmptyValue; +import org.apache.doris.nereids.rules.expression.rules.RangeInference.RangeValue; +import org.apache.doris.nereids.rules.expression.rules.RangeInference.UnknownValue; +import org.apache.doris.nereids.rules.expression.rules.RangeInference.ValueDesc; +import org.apache.doris.nereids.trees.expressions.ComparisonPredicate; +import org.apache.doris.nereids.trees.expressions.CompoundPredicate; +import org.apache.doris.nereids.trees.expressions.EqualTo; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.GreaterThan; +import org.apache.doris.nereids.trees.expressions.GreaterThanEqual; +import org.apache.doris.nereids.trees.expressions.LessThan; +import org.apache.doris.nereids.trees.expressions.LessThanEqual; +import org.apache.doris.nereids.trees.expressions.SlotReference; +import org.apache.doris.nereids.trees.expressions.literal.BooleanLiteral; +import org.apache.doris.nereids.trees.expressions.literal.Literal; +import org.apache.doris.nereids.util.ExpressionUtils; + +import com.google.common.collect.BoundType; +import com.google.common.collect.ImmutableList; +import com.google.common.collect.Lists; +import com.google.common.collect.Maps; +import com.google.common.collect.Range; +import com.google.common.collect.Sets; +import org.apache.commons.lang3.NotImplementedException; + +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.stream.Collectors; + +/** + * This class implements the function to add min max to or expression. + * for example: + * + * a > 10 and a < 20 or a > 30 and a < 40 or a > 50 and a < 60 + * => (a < 20 or a > 30 and a < 40 or a > 50) and a > 10 and a < 60 + * + * a between 10 and 20 and b between 10 and 20 or a between 100 and 200 and b between 100 and 200 + * => (a <= 20 and b <= 20 or a >= 100 and b >= 100) and a >= 10 and a <= 200 and b >= 10 and b <= 200 + */ +public class OrAddMinMax implements ExpressionPatternRuleFactory { Review Comment: fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
englefly commented on code in PR #45081: URL: https://github.com/apache/doris/pull/45081#discussion_r1877807958 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/OrAddMinMax.java: ## @@ -0,0 +1,378 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.rules.expression.rules; + +import org.apache.doris.nereids.rules.expression.ExpressionPatternMatcher; +import org.apache.doris.nereids.rules.expression.ExpressionPatternRuleFactory; +import org.apache.doris.nereids.rules.expression.ExpressionRewriteContext; +import org.apache.doris.nereids.rules.expression.rules.RangeInference.DiscreteValue; +import org.apache.doris.nereids.rules.expression.rules.RangeInference.EmptyValue; +import org.apache.doris.nereids.rules.expression.rules.RangeInference.RangeValue; +import org.apache.doris.nereids.rules.expression.rules.RangeInference.UnknownValue; +import org.apache.doris.nereids.rules.expression.rules.RangeInference.ValueDesc; +import org.apache.doris.nereids.trees.expressions.ComparisonPredicate; +import org.apache.doris.nereids.trees.expressions.CompoundPredicate; +import org.apache.doris.nereids.trees.expressions.EqualTo; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.GreaterThan; +import org.apache.doris.nereids.trees.expressions.GreaterThanEqual; +import org.apache.doris.nereids.trees.expressions.LessThan; +import org.apache.doris.nereids.trees.expressions.LessThanEqual; +import org.apache.doris.nereids.trees.expressions.SlotReference; +import org.apache.doris.nereids.trees.expressions.literal.BooleanLiteral; +import org.apache.doris.nereids.trees.expressions.literal.Literal; +import org.apache.doris.nereids.util.ExpressionUtils; + +import com.google.common.collect.BoundType; +import com.google.common.collect.ImmutableList; +import com.google.common.collect.Lists; +import com.google.common.collect.Maps; +import com.google.common.collect.Range; +import com.google.common.collect.Sets; +import org.apache.commons.lang3.NotImplementedException; + +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.stream.Collectors; + +/** + * This class implements the function to add min max to or expression. + * for example: + * + * a > 10 and a < 20 or a > 30 and a < 40 or a > 50 and a < 60 + * => (a < 20 or a > 30 and a < 40 or a > 50) and a > 10 and a < 60 + * + * a between 10 and 20 and b between 10 and 20 or a between 100 and 200 and b between 100 and 200 + * => (a <= 20 and b <= 20 or a >= 100 and b >= 100) and a >= 10 and a <= 200 and b >= 10 and b <= 200 + */ +public class OrAddMinMax implements ExpressionPatternRuleFactory { Review Comment: how about rename to "AddMinMax", becase we could extract min/max range from And ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/ExpressionOptimization.java: ## @@ -58,6 +59,13 @@ public class ExpressionOptimization extends ExpressionRewrite { BetweenToEqual.INSTANCE ) ); + +public static final List OPTIMIZE_REWRITE_RULES_OR_ADD_RANGE = ImmutableList.of( Review Comment: this name make pepole understand as "optimize rewrite rules" or "add range" it is better to use the rule name -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
doris-robot commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2531106899 TPC-DS: Total hot run time: 197787 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit d4e6a2c3ade841cc2d4988787f47267b5e859f1a, data reload: false query1 1328960 905 905 query2 6253211020442044 query3 11099 447946204479 query4 67382 28538 23569 23569 query5 4914444 434 434 query6 404 177 184 177 query7 5657297 295 295 query8 351 241 240 240 query9 9228270826982698 query10 474 260 256 256 query11 17503 15493 15875 15493 query12 154 106 106 106 query13 1594434 431 431 query14 10882 753171797179 query15 217 185 183 183 query16 7545484 511 484 query17 1068627 604 604 query18 1899333 308 308 query19 195 148 144 144 query20 120 124 108 108 query21 198 109 99 99 query22 4960448545174485 query23 34912 34636 34670 34636 query24 5460253225512532 query25 489 390 396 390 query26 638 148 143 143 query27 1747278 278 278 query28 4295248324552455 query29 693 417 429 417 query30 204 151 154 151 query31 1051855 850 850 query32 70 56 57 56 query33 469 322 290 290 query34 949 509 524 509 query35 858 782 771 771 query36 1113955 973 955 query37 115 71 73 71 query38 4563455444854485 query39 1532147114451445 query40 201 98 99 98 query41 44 45 52 45 query42 114 97 102 97 query43 531 493 494 493 query44 1178823 825 823 query45 185 172 169 169 query46 1202723 749 723 query47 2047190719481907 query48 432 311 323 311 query49 739 378 373 373 query50 835 389 397 389 query51 7415704071597040 query52 100 86 89 86 query53 253 179 178 178 query54 502 394 390 390 query55 77 74 94 74 query56 243 240 236 236 query57 1249111711221117 query58 211 200 216 200 query59 3160314730153015 query60 273 239 242 239 query61 105 105 104 104 query62 787 669 657 657 query63 210 182 179 179 query64 1342682 623 623 query65 3291324432023202 query66 697 299 347 299 query67 16124 15666 15960 15666 query68 4010566 548 548 query69 412 249 237 237 query70 1183114211201120 query71 370 240 239 239 query72 6403419939573957 query73 757 352 355 352 query74 10285 911690569056 query75 3408263126582631 query76 1914110110271027 query77 504 267 262 262 query78 10462 970894649464 query79 1099599 586 586 query80 803 432 437 432 query81 515 233 235 233 query82 1145121 126 121 query83 253 142 149 142 query84 283 67 70 67 query85 865 296 304 296 query86 329 297 296 296 query87 4784452646804526 query88 3532222121812181 query89 418 291 298 291 query90 2042190 187 187 query91 141 103 107 103 query92 60 49 49 49 query93 1112533 520 520 query94 788 295 297 295 query95 343 242 247 242 query96 614 281 273 273 query97 2847264726722647 query98 235 203 197 197 query99 1813132213381322 Total cold run time: 319859 ms Total hot run time: 197787 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
doris-robot commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2531119198 ClickBench: Total hot run time: 32.88 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit d4e6a2c3ade841cc2d4988787f47267b5e859f1a, data reload: false query1 0.040.030.03 query2 0.070.030.04 query3 0.230.080.06 query4 1.630.100.10 query5 0.440.430.39 query6 1.170.660.65 query7 0.020.010.02 query8 0.040.030.03 query9 0.560.530.50 query10 0.540.560.56 query11 0.140.110.11 query12 0.140.120.12 query13 0.610.600.60 query14 2.692.762.82 query15 0.890.830.84 query16 0.380.380.37 query17 1.080.961.06 query18 0.230.200.20 query19 1.971.811.99 query20 0.010.010.01 query21 15.36 0.590.56 query22 2.612.092.04 query23 17.10 0.960.67 query24 3.281.181.64 query25 0.260.170.10 query26 0.460.130.13 query27 0.040.050.03 query28 9.781.091.09 query29 12.53 3.253.27 query30 0.240.060.06 query31 2.850.360.37 query32 3.290.460.48 query33 2.983.053.03 query34 16.93 4.514.51 query35 4.554.544.51 query36 0.680.470.47 query37 0.090.060.06 query38 0.050.030.04 query39 0.030.020.02 query40 0.160.120.13 query41 0.080.020.02 query42 0.030.020.02 query43 0.040.030.03 Total cold run time: 106.3 s Total hot run time: 32.88 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
doris-robot commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2531071319 TPC-H: Total hot run time: 40002 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit d4e6a2c3ade841cc2d4988787f47267b5e859f1a, data reload: false -- Round 1 -- q1 17560 741372497249 q2 2040178 169 169 q3 10607 108112221081 q4 10580 724 713 713 q5 7610272326492649 q6 238 149 148 148 q7 1086625 613 613 q8 9244189218841884 q9 6685647764936477 q10 6992227723532277 q11 475 266 263 263 q12 429 226 217 217 q13 17811 303129792979 q14 241 218 211 211 q15 577 511 513 511 q16 661 565 579 565 q17 986 551 528 528 q18 7244670466846684 q19 1350101410481014 q20 463 184 180 180 q21 4087327032943270 q22 379 333 320 320 Total cold run time: 107345 ms Total hot run time: 40002 ms - Round 2, with runtime_filter_mode=off - q1 7209723372327232 q2 324 231 236 231 q3 2902280429632804 q4 2066181818371818 q5 5728563956755639 q6 232 141 142 141 q7 2255184617911791 q8 3401355934753475 q9 8952905490399039 q10 3581356735353535 q11 614 498 509 498 q12 806 614 619 614 q13 12149 328832453245 q14 310 280 276 276 q15 584 526 529 526 q16 716 655 628 628 q17 1875164716291629 q18 8317771676447644 q19 1804157015251525 q20 2070186518881865 q21 5557536953995369 q22 655 589 598 589 Total cold run time: 72107 ms Total hot run time: 60113 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
yujun777 commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2530996849 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
yujun777 commented on code in PR #45081: URL: https://github.com/apache/doris/pull/45081#discussion_r1877665101 ## fe/fe-core/src/test/java/org/apache/doris/nereids/rules/expression/SimplifyRangeTest.java: ## @@ -62,7 +66,7 @@ public SimplifyRangeTest() { @Test public void testSimplify() { executor = new ExpressionRuleExecutor(ImmutableList.of( -bottomUp(SimplifyRange.INSTANCE) +bottomUp(SimplifyRange.INSTANCE, OrAddMinMax.INSTANCE) Review Comment: ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
morrySnow commented on code in PR #45081: URL: https://github.com/apache/doris/pull/45081#discussion_r1877566187 ## fe/fe-core/src/main/java/org/apache/doris/nereids/util/MutableState.java: ## @@ -31,6 +31,8 @@ public interface MutableState { String KEY_OR_TO_IN = "or_to_in"; +String KEY_SIMPLIFY_RANGE = "simplify_range"; Review Comment: range inference ## fe/fe-core/src/test/java/org/apache/doris/nereids/rules/expression/SimplifyRangeTest.java: ## Review Comment: rename to RangeInferenceTest -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
morrySnow commented on code in PR #45081: URL: https://github.com/apache/doris/pull/45081#discussion_r1877565817 ## fe/fe-core/src/test/java/org/apache/doris/nereids/rules/expression/SimplifyRangeTest.java: ## Review Comment: rename to RangeInferenceTest ## fe/fe-core/src/test/java/org/apache/doris/nereids/rules/expression/SimplifyRangeTest.java: ## @@ -62,7 +66,7 @@ public SimplifyRangeTest() { @Test public void testSimplify() { executor = new ExpressionRuleExecutor(ImmutableList.of( -bottomUp(SimplifyRange.INSTANCE) +bottomUp(SimplifyRange.INSTANCE, OrAddMinMax.INSTANCE) Review Comment: should we test them separately? ## fe/fe-core/src/main/java/org/apache/doris/nereids/util/MutableState.java: ## @@ -31,6 +31,8 @@ public interface MutableState { String KEY_OR_TO_IN = "or_to_in"; +String KEY_SIMPLIFY_RANGE = "simplify_range"; Review Comment: range inference -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
yujun777 commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2530869522 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
doris-robot commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2528838627 ClickBench: Total hot run time: 32.71 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 534d5617158a79f1e5846c2e46ebf08e0c94227a, data reload: false query1 0.030.030.03 query2 0.070.030.03 query3 0.230.070.07 query4 1.630.100.11 query5 0.410.410.40 query6 1.180.660.66 query7 0.010.020.02 query8 0.040.040.03 query9 0.570.520.51 query10 0.550.580.59 query11 0.140.100.11 query12 0.140.120.11 query13 0.610.610.60 query14 2.782.862.85 query15 0.890.830.83 query16 0.380.390.38 query17 1.081.101.05 query18 0.230.210.20 query19 1.971.872.07 query20 0.010.010.02 query21 15.35 0.560.58 query22 2.502.101.94 query23 17.06 0.990.88 query24 3.020.822.31 query25 0.270.160.04 query26 0.500.130.14 query27 0.040.040.04 query28 9.981.111.08 query29 12.52 3.203.23 query30 0.240.060.07 query31 2.850.380.36 query32 3.300.470.47 query33 2.992.973.05 query34 17.01 4.494.45 query35 4.484.494.50 query36 0.640.510.48 query37 0.080.060.06 query38 0.040.030.03 query39 0.030.030.02 query40 0.160.130.13 query41 0.070.020.03 query42 0.040.020.03 query43 0.030.030.03 Total cold run time: 106.15 s Total hot run time: 32.71 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
doris-robot commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2528820718 TPC-DS: Total hot run time: 197286 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 534d5617158a79f1e5846c2e46ebf08e0c94227a, data reload: false query1 1240940 944 940 query2 6254202720702027 query3 10923 445344044404 query4 67673 29282 23580 23580 query5 4884490 462 462 query6 421 177 177 177 query7 5593318 310 310 query8 337 241 237 237 query9 9014274626912691 query10 467 253 262 253 query11 17365 15287 15967 15287 query12 171 102 101 101 query13 1488438 425 425 query14 10852 666273056662 query15 211 200 204 200 query16 7131470 433 433 query17 1387605 589 589 query18 1847317 318 317 query19 211 165 155 155 query20 121 114 113 113 query21 208 109 115 109 query22 4747449644464446 query23 35187 34543 34494 34494 query24 5542255125022502 query25 489 387 396 387 query26 647 157 156 156 query27 1811292 292 292 query28 4905250225082502 query29 680 428 426 426 query30 210 195 153 153 query31 1011807 816 807 query32 79 55 57 55 query33 419 301 314 301 query34 937 533 528 528 query35 871 761 773 761 query36 1120972 986 972 query37 132 79 81 79 query38 4522439744924397 query39 1522148814681468 query40 197 103 99 99 query41 43 41 46 41 query42 112 100 100 100 query43 553 508 504 504 query44 1239861 843 843 query45 195 168 169 168 query46 1194743 732 732 query47 2080189819231898 query48 431 338 330 330 query49 768 408 407 407 query50 818 413 398 398 query51 7349731370297029 query52 102 88 94 88 query53 256 178 181 178 query54 520 399 397 397 query55 78 77 82 77 query56 263 233 243 233 query57 1281110210981098 query58 219 208 218 208 query59 3192309131373091 query60 273 262 235 235 query61 108 105 105 105 query62 798 671 667 667 query63 213 190 186 186 query64 1381686 635 635 query65 3347323132283228 query66 704 293 300 293 query67 15932 15651 15616 15616 query68 3793559 617 559 query69 430 261 252 252 query70 1199115211441144 query71 371 250 258 250 query72 6406407841634078 query73 789 360 361 360 query74 10257 905691289056 query75 3401268226722672 query76 1956106210611061 query77 477 267 273 267 query78 10645 950094349434 query79 1305614 608 608 query80 872 441 444 441 query81 482 245 234 234 query82 1311119 121 119 query83 251 148 147 147 query84 279 70 64 64 query85 882 307 307 307 query86 335 293 299 293 query87 4792464545524552 query88 3498224321902190 query89 426 302 289 289 query90 2041187 188 187 query91 142 105 105 105 query92 69 50 50 50 query93 1608543 558 543 query94 822 256 297 256 query95 352 291 253 253 query96 614 289 276 276 query97 2842265426822654 query98 229 194 195 194 query99 1598131413091309 Total cold run time: 320749 ms Total hot run time: 197286 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
doris-robot commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2528791392 TPC-H: Total hot run time: 40311 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 534d5617158a79f1e5846c2e46ebf08e0c94227a, data reload: false -- Round 1 -- q1 17594 755773677367 q2 2046179 175 175 q3 10570 109011571090 q4 10568 793 744 744 q5 7629273427082708 q6 237 152 151 151 q7 985 623 589 589 q8 9238183519371835 q9 6619655065416541 q10 6952227423052274 q11 456 262 266 262 q12 428 229 228 228 q13 17771 307530683068 q14 257 215 225 215 q15 575 538 524 524 q16 665 593 581 581 q17 986 538 520 520 q18 7230676467336733 q19 1342973 980 973 q20 487 180 180 180 q21 4002328832363236 q22 393 323 317 317 Total cold run time: 107030 ms Total hot run time: 40311 ms - Round 2, with runtime_filter_mode=off - q1 7255726772747267 q2 331 231 242 231 q3 2921280129562801 q4 2116183518701835 q5 5690568756775677 q6 222 147 147 147 q7 2278182518341825 q8 3446357734953495 q9 9008904690689046 q10 3621359035743574 q11 607 526 491 491 q12 806 632 644 632 q13 13443 327432253225 q14 316 264 270 264 q15 582 547 531 531 q16 702 651 659 651 q17 1889165216551652 q18 8553799474777477 q19 1743154415261526 q20 2111188518441844 q21 5721545554045404 q22 641 574 577 574 Total cold run time: 74002 ms Total hot run time: 60169 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
yujun777 commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2528631477 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
doris-robot commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2527220380 ClickBench: Total hot run time: 33.32 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 190005a71021cc1842283bd4350802c771e50b74, data reload: false query1 0.030.030.04 query2 0.080.040.03 query3 0.230.070.06 query4 1.630.100.10 query5 0.430.410.40 query6 1.160.670.66 query7 0.020.020.02 query8 0.040.030.03 query9 0.590.520.52 query10 0.570.570.56 query11 0.140.100.11 query12 0.130.120.11 query13 0.620.610.61 query14 2.812.742.89 query15 0.900.850.84 query16 0.400.380.39 query17 1.051.021.03 query18 0.200.220.20 query19 1.901.822.04 query20 0.020.010.02 query21 15.39 0.580.59 query22 2.922.551.74 query23 17.05 0.870.82 query24 2.961.591.52 query25 0.310.260.09 query26 0.370.140.14 query27 0.050.040.04 query28 10.07 1.101.08 query29 12.56 3.373.37 query30 0.240.060.06 query31 2.870.380.39 query32 3.240.470.47 query33 3.033.073.05 query34 17.12 4.464.49 query35 4.504.474.48 query36 0.680.490.49 query37 0.090.060.06 query38 0.050.030.03 query39 0.040.030.02 query40 0.160.140.12 query41 0.080.030.03 query42 0.040.020.02 query43 0.040.040.04 Total cold run time: 106.81 s Total hot run time: 33.32 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
doris-robot commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2527209649 TPC-DS: Total hot run time: 197230 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 190005a71021cc1842283bd4350802c771e50b74, data reload: false query1 1231955 928 928 query2 6210210420432043 query3 10955 438944714389 query4 67388 28170 23742 23742 query5 4981463 480 463 query6 406 185 192 185 query7 5486315 300 300 query8 335 236 238 236 query9 8607274927382738 query10 404 236 229 229 query11 17219 15200 16049 15200 query12 150 104 109 104 query13 1487436 419 419 query14 10460 765468176817 query15 212 195 188 188 query16 7155468 468 468 query17 1273591 559 559 query18 1804302 305 302 query19 205 157 165 157 query20 116 114 118 114 query21 219 108 106 106 query22 4636455846004558 query23 35147 34333 34744 34333 query24 5626247725402477 query25 492 391 383 383 query26 645 152 146 146 query27 1919292 295 292 query28 4393249724932493 query29 675 402 416 402 query30 225 156 155 155 query31 996 828 853 828 query32 70 56 60 56 query33 442 287 301 287 query34 919 537 502 502 query35 886 771 772 771 query36 1086969 951 951 query37 121 87 78 78 query38 4622439743064306 query39 1519146614831466 query40 212 100 97 97 query41 46 44 46 44 query42 109 100 103 100 query43 539 503 516 503 query44 1230836 838 836 query45 183 168 169 168 query46 1175718 732 718 query47 2047190719371907 query48 423 328 325 325 query49 726 427 407 407 query50 851 403 389 389 query51 7423724570717071 query52 100 92 85 85 query53 250 175 182 175 query54 502 401 410 401 query55 80 73 76 73 query56 249 236 252 236 query57 1224113511071107 query58 221 217 213 213 query59 3320305329442944 query60 273 243 277 243 query61 110 111 113 111 query62 780 685 650 650 query63 212 184 188 184 query64 1374687 664 664 query65 3288325332033203 query66 625 305 298 298 query67 15755 15696 15700 15696 query68 4019583 571 571 query69 400 260 258 258 query70 1212110611251106 query71 330 245 251 245 query72 6401419642234196 query73 753 361 363 361 query74 10149 897989698969 query75 3386265626402640 query76 1839111310921092 query77 513 278 285 278 query78 10359 947394409440 query79 2060602 601 601 query80 1434431 428 428 query81 519 223 231 223 query82 1230119 114 114 query83 260 145 142 142 query84 275 76 74 74 query85 1113305 304 304 query86 422 289 309 289 query87 4678454046654540 query88 3687223721932193 query89 416 292 290 290 query90 1856185 185 185 query91 138 104 104 104 query92 71 53 50 50 query93 3022552 556 552 query94 781 283 278 278 query95 343 244 242 242 query96 634 273 276 273 query97 2892268526722672 query98 224 196 194 194 query99 1601147513071307 Total cold run time: 321066 ms Total hot run time: 197230 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
doris-robot commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2527183886 TPC-H: Total hot run time: 40225 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 190005a71021cc1842283bd4350802c771e50b74, data reload: false -- Round 1 -- q1 17581 812673257325 q2 2049174 163 163 q3 10623 109811981098 q4 10560 786 745 745 q5 7623278026972697 q6 238 154 147 147 q7 1009661 603 603 q8 9233189319551893 q9 6717646965916469 q10 7054231123892311 q11 472 258 263 258 q12 425 223 210 210 q13 17766 301729992999 q14 236 210 213 210 q15 577 524 512 512 q16 657 569 571 569 q17 996 556 534 534 q18 7233669567456695 q19 1362101610541016 q20 472 197 180 180 q21 4027331832753275 q22 389 316 326 316 Total cold run time: 107299 ms Total hot run time: 40225 ms - Round 2, with runtime_filter_mode=off - q1 7258724772017201 q2 335 237 228 228 q3 2891292929712929 q4 2089187418861874 q5 5635570257055702 q6 231 137 141 137 q7 2256180717941794 q8 3401355536033555 q9 9018908190999081 q10 3575356435603560 q11 592 505 494 494 q12 828 589 653 589 q13 12142 320332483203 q14 304 277 267 267 q15 581 544 533 533 q16 679 632 649 632 q17 1886163416341634 q18 8369763476237623 q19 1723164814241424 q20 2192190118541854 q21 5651555754645464 q22 650 570 594 570 Total cold run time: 72286 ms Total hot run time: 60348 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
yujun777 commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2527089291 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
doris-robot commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2526915673 ClickBench: Total hot run time: 32.62 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 64c4f7ce635dfd521a374cb40f977842ac215fd9, data reload: false query1 0.040.030.02 query2 0.070.030.03 query3 0.240.070.07 query4 1.630.110.11 query5 0.400.420.42 query6 1.140.660.67 query7 0.020.020.02 query8 0.040.030.04 query9 0.570.520.50 query10 0.550.560.58 query11 0.150.100.10 query12 0.130.110.11 query13 0.610.610.60 query14 2.722.842.80 query15 0.900.850.83 query16 0.390.390.38 query17 1.091.041.05 query18 0.220.200.20 query19 1.901.802.04 query20 0.010.010.01 query21 15.36 0.580.58 query22 2.751.681.83 query23 17.03 1.140.76 query24 2.961.991.07 query25 0.250.250.08 query26 0.410.150.14 query27 0.050.050.05 query28 9.831.101.07 query29 12.58 3.253.21 query30 0.240.060.06 query31 2.870.380.38 query32 3.290.450.46 query33 2.963.013.07 query34 17.00 4.504.52 query35 4.564.504.54 query36 0.680.480.49 query37 0.090.060.06 query38 0.050.040.04 query39 0.030.020.02 query40 0.170.130.12 query41 0.080.020.02 query42 0.040.030.02 query43 0.040.030.03 Total cold run time: 106.14 s Total hot run time: 32.62 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
doris-robot commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2526906035 TPC-DS: Total hot run time: 197694 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 64c4f7ce635dfd521a374cb40f977842ac215fd9, data reload: false query1 1244946 922 922 query2 6250209320842084 query3 0 453044794479 query4 67190 28257 23482 23482 query5 4929464 455 455 query6 426 181 177 177 query7 5543315 295 295 query8 326 234 241 234 query9 8200260025902590 query10 423 253 231 231 query11 16996 15382 16016 15382 query12 146 117 103 103 query13 1496431 407 407 query14 10714 719275397192 query15 250 187 201 187 query16 7091501 472 472 query17 1039579 552 552 query18 1818298 293 293 query19 208 149 151 149 query20 127 119 119 119 query21 206 105 102 102 query22 4761473146594659 query23 35173 34435 34678 34435 query24 5619246625752466 query25 473 382 383 382 query26 630 160 149 149 query27 1748290 281 281 query28 4770250024732473 query29 656 426 412 412 query30 210 160 157 157 query31 1006841 860 841 query32 71 57 59 57 query33 476 311 308 308 query34 936 567 507 507 query35 896 780 753 753 query36 1119971 972 971 query37 121 78 72 72 query38 4517446044904460 query39 1523147414721472 query40 208 100 97 97 query41 44 42 45 42 query42 117 98 100 98 query43 560 515 501 501 query44 1189827 854 827 query45 185 165 166 165 query46 1182714 714 714 query47 2085189219611892 query48 423 333 317 317 query49 737 404 391 391 query50 852 404 407 404 query51 7393728272027202 query52 94 87 87 87 query53 258 182 175 175 query54 495 416 389 389 query55 77 75 74 74 query56 262 267 256 256 query57 1254116211371137 query58 223 224 213 213 query59 3348305933223059 query60 274 255 260 255 query61 130 132 129 129 query62 839 654 645 645 query63 211 176 181 176 query64 1341644 622 622 query65 3285325332383238 query66 724 294 302 294 query67 16061 15752 15638 15638 query68 3524595 562 562 query69 436 248 247 247 query70 1203114011401140 query71 422 247 245 245 query72 6465400340734003 query73 773 360 351 351 query74 10327 907290269026 query75 3350262126772621 query76 2029114210471047 query77 474 267 258 258 query78 10517 946493409340 query79 1547600 598 598 query80 848 428 450 428 query81 491 239 227 227 query82 1247122 121 121 query83 162 143 145 143 query84 285 70 72 70 query85 849 307 376 307 query86 313 301 312 301 query87 4672460846474608 query88 3685217721512151 query89 406 296 285 285 query90 2033181 183 181 query91 134 101 101 101 query92 70 51 49 49 query93 1840538 540 538 query94 757 288 280 280 query95 346 252 247 247 query96 606 282 269 269 query97 2921268326532653 query98 233 199 195 195 query99 1597130313111303 Total cold run time: 318850 ms Total hot run time: 197694 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
doris-robot commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2526892524 TPC-H: Total hot run time: 40361 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 64c4f7ce635dfd521a374cb40f977842ac215fd9, data reload: false -- Round 1 -- q1 17615 748673047304 q2 2043185 172 172 q3 10613 110611951106 q4 10570 791 853 791 q5 7625280127592759 q6 242 148 147 147 q7 1001652 603 603 q8 9246183819411838 q9 6812656965566556 q10 7057228223472282 q11 463 257 275 257 q12 452 219 223 219 q13 17807 307030113011 q14 235 206 220 206 q15 588 534 521 521 q16 676 591 599 591 q17 984 557 578 557 q18 7402676367346734 q19 1363106410571057 q20 461 179 173 173 q21 4009316132133161 q22 378 316 326 316 Total cold run time: 107642 ms Total hot run time: 40361 ms - Round 2, with runtime_filter_mode=off - q1 7339720672277206 q2 323 230 230 230 q3 2922295229652952 q4 2151190819431908 q5 5633568356845683 q6 221 139 140 139 q7 2243180118411801 q8 3394353335543533 q9 9020906190729061 q10 3642356735363536 q11 604 500 507 500 q12 854 683 627 627 q13 12125 323232613232 q14 321 280 270 270 q15 576 536 537 536 q16 675 637 641 637 q17 1872164216291629 q18 8312786175497549 q19 1695157814181418 q20 2136188518951885 q21 5639540255425402 q22 653 558 606 558 Total cold run time: 72350 ms Total hot run time: 60292 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
yujun777 commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2526810698 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
yujun777 commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2526795586 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
yujun777 commented on code in PR #45081: URL: https://github.com/apache/doris/pull/45081#discussion_r1873259232 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/PredicatesSplitter.java: ## @@ -102,9 +104,9 @@ public Void visit(Expression expr, Void context) { public Predicates.SplitPredicate getSplitPredicate() { return Predicates.SplitPredicate.of( -equalPredicates.isEmpty() ? null : ExpressionUtils.and(equalPredicates), -rangePredicates.isEmpty() ? null : ExpressionUtils.and(rangePredicates), -residualPredicates.isEmpty() ? null : ExpressionUtils.and(residualPredicates)); +equalPredicates.isEmpty() ? null : ExpressionUtils.and(Lists.newArrayList(equalPredicates)), Review Comment: change ExpressionUtil.and/or implementation, also change its argument type from Collation to List, because new And/Or require List. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
xzj7019 commented on code in PR #45081: URL: https://github.com/apache/doris/pull/45081#discussion_r1873092364 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/PredicatesSplitter.java: ## @@ -102,9 +104,9 @@ public Void visit(Expression expr, Void context) { public Predicates.SplitPredicate getSplitPredicate() { return Predicates.SplitPredicate.of( -equalPredicates.isEmpty() ? null : ExpressionUtils.and(equalPredicates), -rangePredicates.isEmpty() ? null : ExpressionUtils.and(rangePredicates), -residualPredicates.isEmpty() ? null : ExpressionUtils.and(residualPredicates)); +equalPredicates.isEmpty() ? null : ExpressionUtils.and(Lists.newArrayList(equalPredicates)), Review Comment: what's the opt point for these kind of change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
xzj7019 commented on code in PR #45081: URL: https://github.com/apache/doris/pull/45081#discussion_r1873086959 ## regression-test/data/nereids_tpcds_shape_sf1000_p0/shape/query13.out: ## @@ -7,14 +7,14 @@ PhysicalResultSink PhysicalProject --hashJoin[INNER_JOIN broadcast] hashCondition=((store.s_store_sk = store_sales.ss_store_sk)) otherCondition=() build RFs:RF4 s_store_sk->[ss_store_sk] PhysicalProject ---hashJoin[INNER_JOIN bucketShuffle] hashCondition=((store_sales.ss_addr_sk = customer_address.ca_address_sk)) otherCondition=(OR[AND[ca_state IN ('IL', 'TN', 'TX'),(store_sales.ss_net_profit >= 100.00),(store_sales.ss_net_profit <= 200.00)],AND[ca_state IN ('ID', 'OH', 'WY'),(store_sales.ss_net_profit >= 150.00),(store_sales.ss_net_profit <= 300.00)],AND[ca_state IN ('IA', 'MS', 'SC'),(store_sales.ss_net_profit >= 50.00),(store_sales.ss_net_profit <= 250.00)]]) build RFs:RF3 ss_addr_sk->[ca_address_sk] +--hashJoin[INNER_JOIN bucketShuffle] hashCondition=((store_sales.ss_addr_sk = customer_address.ca_address_sk)) otherCondition=(OR[AND[ca_state IN ('IL', 'TN', 'TX'),(store_sales.ss_net_profit >= 100.00),(store_sales.ss_net_profit <= 200.00)],AND[ca_state IN ('ID', 'OH', 'WY'),(store_sales.ss_net_profit >= 150.00)],AND[ca_state IN ('IA', 'MS', 'SC'),(store_sales.ss_net_profit <= 250.00)]]) build RFs:RF3 ss_addr_sk->[ca_address_sk] Review Comment: need to do perf regression checking -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
doris-robot commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2522788080 ClickBench: Total hot run time: 32.41 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 8a0eed2307dda8eb4446b506a246e2dcbce5f74c, data reload: false query1 0.040.030.02 query2 0.070.040.03 query3 0.230.080.07 query4 1.630.100.11 query5 0.460.410.40 query6 1.140.670.66 query7 0.020.020.02 query8 0.040.040.03 query9 0.550.530.49 query10 0.560.560.60 query11 0.130.100.10 query12 0.140.110.11 query13 0.620.600.59 query14 2.752.702.87 query15 0.900.840.82 query16 0.390.380.38 query17 1.061.021.08 query18 0.210.210.20 query19 1.911.852.06 query20 0.020.000.02 query21 15.43 0.600.58 query22 2.731.921.88 query23 17.19 0.860.83 query24 3.921.590.86 query25 0.260.100.04 query26 0.700.130.14 query27 0.040.050.05 query28 9.841.101.09 query29 12.56 3.243.21 query30 0.240.060.07 query31 2.880.370.38 query32 3.280.460.46 query33 3.083.012.98 query34 16.98 4.464.44 query35 4.504.514.55 query36 0.680.470.48 query37 0.080.060.06 query38 0.040.030.03 query39 0.030.030.02 query40 0.170.130.12 query41 0.070.020.02 query42 0.030.020.02 query43 0.030.030.04 Total cold run time: 107.63 s Total hot run time: 32.41 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
doris-robot commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2522778399 TPC-DS: Total hot run time: 191906 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 8a0eed2307dda8eb4446b506a246e2dcbce5f74c, data reload: false query1 1153384 396 384 query2 6524214520302030 query3 6705223 209 209 query4 34099 23913 23523 23523 query5 4279468 490 468 query6 295 187 176 176 query7 4626302 303 302 query8 310 248 237 237 query9 9369276127332733 query10 468 255 258 255 query11 18035 15231 15387 15231 query12 150 107 104 104 query13 1662432 421 421 query14 10360 751772177217 query15 324 180 185 180 query16 8200482 411 411 query17 1841594 544 544 query18 2120292 284 284 query19 364 148 147 147 query20 132 120 110 110 query21 213 107 100 100 query22 4516444043314331 query23 35049 34323 34279 34279 query24 10391 253424182418 query25 654 372 392 372 query26 1409154 152 152 query27 2733281 279 279 query28 7941245024512450 query29 901 395 409 395 query30 296 148 147 147 query31 1043804 860 804 query32 97 56 60 56 query33 776 289 300 289 query34 947 500 503 500 query35 865 741 759 741 query36 1114941 945 941 query37 130 73 72 72 query38 4333435942784278 query39 1519144414131413 query40 277 106 99 99 query41 48 44 43 43 query42 111 102 99 99 query43 545 490 497 490 query44 1268796 813 796 query45 184 171 163 163 query46 1179690 723 690 query47 1934184818361836 query48 404 313 329 313 query49 1152390 384 384 query50 798 380 388 380 query51 7147714570707070 query52 101 92 90 90 query53 253 179 198 179 query54 1321415 406 406 query55 80 81 80 80 query56 259 249 241 241 query57 1229113611291129 query58 226 215 216 215 query59 3234311930393039 query60 267 268 298 268 query61 111 108 111 108 query62 887 688 674 674 query63 214 186 181 181 query64 5153683 664 664 query65 3312319532703195 query66 1474340 315 315 query67 16075 15596 15719 15596 query68 4575573 553 553 query69 414 248 249 248 query70 1193111911361119 query71 332 250 259 250 query72 6441402640724026 query73 763 361 367 361 query74 10375 898689788978 query75 3409266226752662 query76 2731107411571074 query77 503 296 278 278 query78 10563 953894719471 query79 1119596 606 596 query80 844 431 435 431 query81 520 239 232 232 query82 333 124 119 119 query83 274 166 149 149 query84 235 72 68 68 query85 1323304 313 304 query86 376 270 304 270 query87 4853486345544554 query88 3421224822302230 query89 399 296 300 296 query90 2017189 186 186 query91 135 113 104 104 query92 61 50 51 50 query93 1067545 547 545 query94 1049305 290 290 query95 369 253 256 253 query96 617 286 296 286 query97 2865268626882686 query98 220 215 207 207 query99 1527131913041304 Total cold run time: 300109 ms Total hot run time: 191906 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
doris-robot commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2522757234 TPC-H: Total hot run time: 40101 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 8a0eed2307dda8eb4446b506a246e2dcbce5f74c, data reload: false -- Round 1 -- q1 17722 757073337333 q2 2077176 186 176 q3 10609 114911521149 q4 10232 770 698 698 q5 7629270326592659 q6 234 147 148 147 q7 999 623 606 606 q8 9283183719081837 q9 6727648164766476 q10 7016226922752269 q11 465 264 265 264 q12 413 216 228 216 q13 17785 306730223022 q14 247 217 214 214 q15 568 527 504 504 q16 672 580 612 580 q17 990 578 524 524 q18 7444676067236723 q19 13401051952 952 q20 465 185 187 185 q21 3975325232813252 q22 367 315 341 315 Total cold run time: 107259 ms Total hot run time: 40101 ms - Round 2, with runtime_filter_mode=off - q1 7226727772557255 q2 327 228 232 228 q3 2911280530372805 q4 2140190618391839 q5 5586567356335633 q6 229 136 136 136 q7 2165177718491777 q8 3435351434913491 q9 9000898290448982 q10 3591352736073527 q11 594 499 499 499 q12 843 626 620 620 q13 12034 316431593159 q14 302 270 280 270 q15 552 515 496 496 q16 658 623 622 622 q17 1817158215331533 q18 7874741475377414 q19 1724155614881488 q20 2132180518271805 q21 5502533553615335 q22 628 555 567 555 Total cold run time: 71270 ms Total hot run time: 59469 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
yujun777 commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2522718587 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
yujun777 commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2522706967 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
yujun777 commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2522701604 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
doris-robot commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2522501446 ClickBench: Total hot run time: 32.13 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 9446c318764416948c95ebebea1541de0be64724, data reload: false query1 0.030.030.03 query2 0.070.030.03 query3 0.250.070.07 query4 1.620.100.10 query5 0.440.420.41 query6 1.190.670.65 query7 0.020.020.01 query8 0.040.030.03 query9 0.570.510.52 query10 0.560.580.55 query11 0.140.110.10 query12 0.130.110.10 query13 0.610.590.59 query14 2.732.852.86 query15 0.910.840.82 query16 0.390.380.38 query17 1.021.071.08 query18 0.220.210.21 query19 1.931.862.03 query20 0.020.000.02 query21 15.37 0.600.60 query22 2.502.011.38 query23 17.05 1.030.84 query24 2.962.040.71 query25 0.270.120.10 query26 0.460.130.14 query27 0.040.040.07 query28 10.35 1.101.07 query29 12.56 3.293.23 query30 0.250.060.06 query31 2.890.380.38 query32 3.300.480.47 query33 3.143.013.05 query34 16.76 4.464.52 query35 4.604.504.49 query36 0.670.480.49 query37 0.090.060.06 query38 0.040.040.03 query39 0.030.020.02 query40 0.160.130.14 query41 0.080.020.02 query42 0.030.020.02 query43 0.040.030.03 Total cold run time: 106.53 s Total hot run time: 32.13 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
doris-robot commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2522493163 TPC-DS: Total hot run time: 191159 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 9446c318764416948c95ebebea1541de0be64724, data reload: false query1 1166378 384 378 query2 6512213521032103 query3 6703223 206 206 query4 33723 23577 23516 23516 query5 4375485 445 445 query6 301 186 170 170 query7 4628307 315 307 query8 299 240 233 233 query9 9594276727502750 query10 481 258 252 252 query11 18296 15386 15155 15155 query12 170 107 107 107 query13 1690433 408 408 query14 11626 688867166716 query15 309 195 189 189 query16 8028496 487 487 query17 1791641 559 559 query18 2136303 291 291 query19 364 152 148 148 query20 115 110 107 107 query21 204 100 102 100 query22 4593423543764235 query23 34901 34098 34112 34098 query24 10212 256024412441 query25 615 374 401 374 query26 1153150 153 150 query27 2259277 291 277 query28 7366243524582435 query29 831 401 394 394 query30 285 163 153 153 query31 1029850 836 836 query32 89 55 58 55 query33 784 290 292 290 query34 980 511 523 511 query35 855 733 739 733 query36 1076894 957 894 query37 120 69 76 69 query38 4349421242094209 query39 1460145214131413 query40 190 102 98 98 query41 45 43 46 43 query42 111 98 106 98 query43 536 485 476 476 query44 1256815 794 794 query45 182 206 178 178 query46 1160705 708 705 query47 1961184918541849 query48 419 344 320 320 query49 1128401 419 401 query50 818 391 396 391 query51 7182721471157115 query52 100 89 94 89 query53 258 180 186 180 query54 1186387 393 387 query55 87 76 74 74 query56 247 242 244 242 query57 1270114411451144 query58 225 206 218 206 query59 3292308430313031 query60 274 241 242 241 query61 105 102 111 102 query62 872 665 681 665 query63 211 191 184 184 query64 3798661 632 632 query65 3287322432693224 query66 869 314 320 314 query67 15879 15641 15699 15641 query68 4937581 617 581 query69 436 247 255 247 query70 1122111311501113 query71 316 249 245 245 query72 6498414340864086 query73 767 362 377 362 query74 10247 892889908928 query75 3414265826742658 query76 29501107995 995 query77 506 296 276 276 query78 10429 948394569456 query79 2374619 618 618 query80 1276431 437 431 query81 555 230 231 230 query82 892 120 121 120 query83 248 152 142 142 query84 246 73 70 70 query85 1279312 304 304 query86 434 297 304 297 query87 4754459845614561 query88 4110226422142214 query89 413 296 297 296 query90 2032188 186 186 query91 140 104 107 104 query92 62 49 51 49 query93 1785547 558 547 query94 844 293 287 287 query95 340 250 248 248 query96 624 284 283 283 query97 2848271627182716 query98 214 190 203 190 query99 1613133213011301 Total cold run time: 301121 ms Total hot run time: 191159 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
doris-robot commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2522470003 TPC-H: Total hot run time: 40458 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 9446c318764416948c95ebebea1541de0be64724, data reload: false -- Round 1 -- q1 13816 745473727372 q2 1301175 179 175 q3 2538121411501150 q4 1057751 869 751 q5 2838276627642764 q6 236 147 144 144 q7 1010631 622 622 q8 1863187419221874 q9 6642649365126493 q10 2739238823182318 q11 399 268 262 262 q12 422 221 222 221 q13 4332306430543054 q14 247 211 211 211 q15 579 544 527 527 q16 619 603 584 584 q17 952 590 561 561 q18 7299682667666766 q19 1160991 1012991 q20 446 186 182 182 q21 4023324831373137 q22 373 299 319 299 Total cold run time: 54891 ms Total hot run time: 40458 ms - Round 2, with runtime_filter_mode=off - q1 7396728372817281 q2 336 224 242 224 q3 2910276928212769 q4 1997169317001693 q5 5388542654205420 q6 219 137 134 134 q7 2167173417141714 q8 3277341233993399 q9 8770865787678657 q10 3482341834433418 q11 584 510 488 488 q12 817 574 588 574 q13 3845305730133013 q14 286 260 258 258 q15 565 513 517 513 q16 679 634 632 632 q17 1801156315661563 q18 7771761275317531 q19 1688155813911391 q20 2050182518431825 q21 5361539551225122 q22 635 577 580 577 Total cold run time: 62024 ms Total hot run time: 58196 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
yujun777 commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2522391189 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
yujun777 commented on code in PR #45081: URL: https://github.com/apache/doris/pull/45081#discussion_r1872695838 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/SimplifyRange.java: ## @@ -548,6 +763,7 @@ public Expression toExpression() { return toExpr; } Expression result = sourceValues.get(0).toExpression(); +BinaryOperator mergeExprOp = isAnd ? ExpressionUtils::and : ExpressionUtils::or; for (int i = 1; i < sourceValues.size(); i++) { result = mergeExprOp.apply(result, sourceValues.get(i).toExpression()); Review Comment: fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
doris-robot commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2522108373 ClickBench: Total hot run time: 32.51 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 45e8a9b11a40f96c5f4cabe4fe501012354db9fc, data reload: false query1 0.030.030.05 query2 0.070.030.03 query3 0.240.060.06 query4 1.630.100.12 query5 0.410.420.41 query6 1.170.660.65 query7 0.010.020.02 query8 0.050.040.03 query9 0.600.500.50 query10 0.560.560.56 query11 0.150.110.10 query12 0.140.120.11 query13 0.610.610.60 query14 2.942.722.86 query15 0.910.830.83 query16 0.390.380.40 query17 1.031.051.07 query18 0.220.200.21 query19 1.951.911.99 query20 0.020.010.02 query21 15.36 0.590.58 query22 2.902.041.62 query23 16.96 1.210.77 query24 2.451.061.47 query25 0.290.220.06 query26 0.460.140.15 query27 0.040.040.04 query28 10.78 1.091.07 query29 12.55 3.233.23 query30 0.250.070.06 query31 2.860.390.39 query32 3.260.460.47 query33 3.023.043.09 query34 16.83 4.454.47 query35 4.594.494.47 query36 0.680.480.49 query37 0.090.060.06 query38 0.040.030.03 query39 0.030.020.03 query40 0.170.130.12 query41 0.080.030.02 query42 0.040.030.02 query43 0.040.020.03 Total cold run time: 106.9 s Total hot run time: 32.51 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
doris-robot commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2522102624 TPC-DS: Total hot run time: 197469 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 45e8a9b11a40f96c5f4cabe4fe501012354db9fc, data reload: false query1 1445961 977 961 query2 6243214520622062 query3 10980 432243984322 query4 66998 28532 23582 23582 query5 4938472 473 472 query6 436 178 173 173 query7 5533312 293 293 query8 337 255 245 245 query9 8869275227472747 query10 434 245 243 243 query11 17220 15139 16171 15139 query12 157 107 108 107 query13 1451457 405 405 query14 10927 798271497149 query15 217 192 193 192 query16 7059479 489 479 query17 1082590 591 590 query18 1075319 311 311 query19 214 164 161 161 query20 122 114 123 114 query21 220 106 107 106 query22 4866475744984498 query23 34973 34459 34456 34456 query24 5470244824812448 query25 484 382 396 382 query26 652 155 150 150 query27 2058311 292 292 query28 4502251925052505 query29 653 423 421 421 query30 210 147 151 147 query31 1016846 850 846 query32 65 57 55 55 query33 422 295 299 295 query34 914 557 533 533 query35 907 779 759 759 query36 1113953 940 940 query37 118 76 71 71 query38 4473428143654281 query39 1535146714811467 query40 212 99 99 99 query41 43 44 44 44 query42 117 105 108 105 query43 544 516 497 497 query44 1209827 813 813 query45 185 163 171 163 query46 1170715 750 715 query47 2065194519661945 query48 453 324 327 324 query49 736 397 409 397 query50 834 426 393 393 query51 7479730571037103 query52 98 87 92 87 query53 239 182 177 177 query54 504 393 390 390 query55 80 77 83 77 query56 247 246 250 246 query57 1266115611641156 query58 206 204 218 204 query59 3177299929092909 query60 296 242 270 242 query61 105 103 104 103 query62 787 645 675 645 query63 211 186 191 186 query64 1353668 659 659 query65 3252320031893189 query66 643 301 297 297 query67 16189 15675 15735 15675 query68 3909570 587 570 query69 434 253 250 250 query70 1168114611381138 query71 376 242 254 242 query72 6413424740484048 query73 773 366 362 362 query74 10217 905190499049 query75 3365268927452689 query76 1899104811701048 query77 460 281 274 274 query78 10506 947394599459 query79 2059611 599 599 query80 1427416 478 416 query81 513 234 227 227 query82 1287122 121 121 query83 265 149 148 148 query84 279 77 74 74 query85 1032304 312 304 query86 424 279 292 279 query87 4870457245244524 query88 3700227222432243 query89 425 300 301 300 query90 1949191 188 188 query91 131 100 105 100 query92 68 52 51 51 query93 2934546 546 546 query94 795 272 300 272 query95 347 252 242 242 query96 635 277 284 277 query97 2893268626742674 query98 218 198 195 195 query99 1606132113441321 Total cold run time: 321465 ms Total hot run time: 197469 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
doris-robot commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2522091399 TPC-H: Total hot run time: 40315 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 45e8a9b11a40f96c5f4cabe4fe501012354db9fc, data reload: false -- Round 1 -- q1 17645 740073167316 q2 2049180 169 169 q3 10681 112311901123 q4 10467 743 715 715 q5 7626278127182718 q6 238 146 143 143 q7 993 656 613 613 q8 9243186919341869 q9 6697651265226512 q10 7061231523382315 q11 471 262 263 262 q12 417 223 224 223 q13 17762 314630083008 q14 256 230 227 227 q15 573 526 505 505 q16 661 589 587 587 q17 994 554 514 514 q18 7276678867516751 q19 1350101010231010 q20 466 187 183 183 q21 4184328232393239 q22 379 324 313 313 Total cold run time: 107489 ms Total hot run time: 40315 ms - Round 2, with runtime_filter_mode=off - q1 7285729073007290 q2 325 229 228 228 q3 2920289029542890 q4 2068187318351835 q5 5645567556965675 q6 222 139 139 139 q7 2273186018151815 q8 3399354335423542 q9 8940905590569055 q10 3597361435643564 q11 583 501 493 493 q12 817 616 609 609 q13 10828 322431593159 q14 294 277 281 277 q15 568 520 523 520 q16 699 650 634 634 q17 1862163516171617 q18 8403784977357735 q19 1738147616071476 q20 2130186718601860 q21 5564557754165416 q22 644 589 578 578 Total cold run time: 70804 ms Total hot run time: 60407 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
englefly commented on code in PR #45081: URL: https://github.com/apache/doris/pull/45081#discussion_r1872529148 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/SimplifyRange.java: ## @@ -548,6 +763,7 @@ public Expression toExpression() { return toExpr; } Expression result = sourceValues.get(0).toExpression(); +BinaryOperator mergeExprOp = isAnd ? ExpressionUtils::and : ExpressionUtils::or; for (int i = 1; i < sourceValues.size(); i++) { result = mergeExprOp.apply(result, sourceValues.get(i).toExpression()); Review Comment: avoid to generate deep tree list = new List(result); for (int i = 1; i < sourceValues.size(); i++) { list.add(sourceValues.get(i).toExpression()) } result = new And(list); -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
yujun777 commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2522013159 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) expression add min max scope for slot reference [doris]
doris-robot commented on PR #45081: URL: https://github.com/apache/doris/pull/45081#issuecomment-2522012424 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org