Re: [PR] [feat] Virtual Slot Ref [doris]
airborne12 merged PR #52701: URL: https://github.com/apache/doris/pull/52701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
github-actions[bot] commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3124990405 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
hello-stephen commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3120473068 # BE Regression && UT Coverage Report Increment line coverage `81.70% (518/634)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/52701_af5fc37ffc558c01d31ea8935f747c53d1ed8220_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/52701_af5fc37ffc558c01d31ea8935f747c53d1ed8220_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 81.09% (22069/27214) | | Line Coverage | 73.70% (228016/309376) | | Region Coverage | 61.36% (190548/310523) | | Branch Coverage | 65.10% (82110/126135) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3120361756 # BE UT Coverage Report Increment line coverage `40.13% (256/638)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/af5fc37ffc558c01d31ea8935f747c53d1ed8220_af5fc37ffc558c01d31ea8935f747c53d1ed8220/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/af5fc37ffc558c01d31ea8935f747c53d1ed8220_af5fc37ffc558c01d31ea8935f747c53d1ed8220/report/index.html) | Category | Coverage | |---|| | Function Coverage | 57.58% (15964/27724) | | Line Coverage | 46.34% (143555/309804) | | Region Coverage | 35.72% (108162/302775) | | Branch Coverage | 38.30% (47768/124727) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3120164947 ClickBench: Total hot run time: 32.96 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit af5fc37ffc558c01d31ea8935f747c53d1ed8220, data reload: false query1 0.050.040.04 query2 0.080.040.05 query3 0.250.070.08 query4 1.610.110.11 query5 0.430.450.43 query6 1.170.700.69 query7 0.020.020.01 query8 0.050.030.03 query9 0.550.480.47 query10 0.540.530.53 query11 0.150.100.11 query12 0.150.110.12 query13 0.640.650.64 query14 0.931.261.01 query15 0.920.910.92 query16 0.390.400.39 query17 1.101.111.08 query18 0.220.200.21 query19 2.001.931.85 query20 0.020.010.01 query21 15.37 0.860.55 query22 0.781.080.82 query23 14.83 1.140.61 query24 6.462.040.53 query25 0.510.130.18 query26 0.680.160.13 query27 0.060.060.06 query28 9.370.840.44 query29 12.60 3.833.34 query30 3.022.962.93 query31 2.810.560.39 query32 3.240.560.49 query33 3.053.223.27 query34 15.99 5.334.90 query35 4.875.044.87 query36 0.690.510.50 query37 0.100.080.07 query38 0.050.060.04 query39 0.040.020.03 query40 0.170.140.13 query41 0.070.020.02 query42 0.040.020.02 query43 0.040.030.04 Total cold run time: 106.11 s Total hot run time: 32.96 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3120149476 TPC-DS: Total hot run time: 172137 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit af5fc37ffc558c01d31ea8935f747c53d1ed8220, data reload: false query1 982 406 408 406 query2 6535174616321632 query3 6741228 238 228 query4 27185 23948 22891 22891 query5 4394653 549 549 query6 340 248 231 231 query7 4653526 319 319 query8 291 243 240 240 query9 8594304930403040 query10 476 353 306 306 query11 15867 15062 14753 14753 query12 188 131 129 129 query13 1653568 423 423 query14 8792604860606048 query15 216 197 171 171 query16 7125673 476 476 query17 959 757 632 632 query18 1994449 317 317 query19 220 210 186 186 query20 151 140 146 140 query21 211 122 109 109 query22 4040418339913991 query23 34398 33640 34078 33640 query24 8346245324862453 query25 610 515 450 450 query26 1263294 167 167 query27 2710517 350 350 query28 4418232023202320 query29 803 625 529 529 query30 303 232 209 209 query31 908 805 720 720 query32 98 83 85 83 query33 569 421 387 387 query34 831 879 533 533 query35 819 828 756 756 query36 10571057940 940 query37 137 113 96 96 query38 4028403639763976 query39 1464140113701370 query40 244 151 135 135 query41 64 59 54 54 query42 150 128 132 128 query43 518 518 479 479 query44 1467877 886 877 query45 207 189 182 182 query46 951 1076707 707 query47 1796185017831783 query48 420 450 325 325 query49 736 508 422 422 query50 659 717 437 437 query51 5571559654405440 query52 137 133 124 124 query53 272 326 217 217 query54 679 659 591 591 query55 93 94 90 90 query56 376 377 354 354 query57 1197121911431143 query58 352 350 327 327 query59 2536260425292529 query60 424 416 402 402 query61 128 127 142 127 query62 806 717 662 662 query63 262 227 228 227 query64 43711109890 890 query65 4249413441344134 query66 1150437 338 338 query67 query68 16521 914 1025914 query69 1021287 296 287 query70 1366110810941094 query71 693 332 339 332 query72 9248234222872287 query73 3295666 355 355 query74 9126908388398839 query75 7510315826722672 query76 85061234800 800 query77 1164430 350 350 query78 968510143 94369436 query79 14559 668 576 576 query80 990 587 524 524 query81 556 254 233 233 query82 575 150 122 122 query83 321 293 271 271 query84 316 101 89 89 query85 815 372 329 329 query86 363 346 311 311 query87 4381434742764276 query88 4026226422622262 query89 487 363 323 323 query90 2599233 234 233 query91 147 141 163 141 query92 87 72 68 68 query93 4329986 652 652 query94 919 407 284 284 query95 413 334 323 323 query96 507 597 283 283 query97 2727273426172617 query98 242 244 224 224 query99 1459142113101310 Total cold run time: 303137 ms Total hot run time: 172137 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3120120205 TPC-H: Total hot run time: 33910 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit af5fc37ffc558c01d31ea8935f747c53d1ed8220, data reload: false -- Round 1 -- q1 17628 518151965181 q2 1918294 184 184 q3 10470 1414700 700 q4 10242 1034517 517 q5 8009236223412341 q6 179 166 134 134 q7 911 874 623 623 q8 9307136111351135 q9 6829506650745066 q10 6956234419751975 q11 463 274 267 267 q12 354 380 234 234 q13 17784 350329952995 q14 235 243 210 210 q15 544 475 461 461 q16 427 447 372 372 q17 571 840 339 339 q18 7459720371647164 q19 2639984 536 536 q20 684 333 222 222 q21 3928299122702270 q22 10871031984 984 Total cold run time: 108624 ms Total hot run time: 33910 ms - Round 2, with runtime_filter_mode=off - q1 5533520152885201 q2 602 319 218 218 q3 2081258621792179 q4 1371174813661366 q5 4394457745064506 q6 213 180 133 133 q7 2037193118281828 q8 2609257524942494 q9 7413735874537358 q10 3105332929212921 q11 550 505 480 480 q12 685 787 632 632 q13 3401381533013301 q14 292 317 315 315 q15 562 476 439 439 q16 507 494 470 470 q17 1186144813891389 q18 8007765278787652 q19 3190886 885 885 q20 2999194419381938 q21 6219440041654165 q22 11181003971 971 Total cold run time: 58074 ms Total hot run time: 50841 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
hello-stephen commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3120019242 # FE UT Coverage Report Increment line coverage ` 58.31% (221/379)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/52701_af5fc37ffc558c01d31ea8935f747c53d1ed8220/fe_increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/52701_af5fc37ffc558c01d31ea8935f747c53d1ed8220/fe_report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3119885611 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/af5fc37ffc558c01d31ea8935f747c53d1ed8220_af5fc37ffc558c01d31ea8935f747c53d1ed8220_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/af5fc37ffc558c01d31ea8935f747c53d1ed8220_af5fc37ffc558c01d31ea8935f747c53d1ed8220_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 80.42% (1302/1619) | | Line Coverage | 65.77% (21798/33142) | | Region Coverage | 67.09% (10954/16328) | | Branch Coverage | 56.60% (5760/10176) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
zhiqiang- commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3119795242 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
hello-stephen commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3119518247 # BE Regression && UT Coverage Report Increment line coverage `79.18% (502/634)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/52701_8b52452627eba562e35f0ffa1287812ad0a77dd5_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/52701_8b52452627eba562e35f0ffa1287812ad0a77dd5_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 81.08% (22068/27217) | | Line Coverage | 73.70% (228024/309375) | | Region Coverage | 61.26% (190231/310508) | | Branch Coverage | 65.07% (82079/126135) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
hello-stephen commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3119113293 # BE UT Coverage Report Increment line coverage `37.77% (241/638)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/8b52452627eba562e35f0ffa1287812ad0a77dd5_8b52452627eba562e35f0ffa1287812ad0a77dd5/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/8b52452627eba562e35f0ffa1287812ad0a77dd5_8b52452627eba562e35f0ffa1287812ad0a77dd5/report/index.html) | Category | Coverage | |---|| | Function Coverage | 57.58% (15965/27727) | | Line Coverage | 46.34% (143562/309803) | | Region Coverage | 35.76% (108262/302760) | | Branch Coverage | 38.30% (47765/124727) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3118559609 ClickBench: Total hot run time: 33.38 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 8b52452627eba562e35f0ffa1287812ad0a77dd5, data reload: false query1 0.040.040.03 query2 0.120.050.06 query3 0.290.060.07 query4 1.620.090.08 query5 0.420.420.41 query6 1.160.640.66 query7 0.030.030.02 query8 0.060.060.05 query9 0.640.520.53 query10 0.590.580.57 query11 0.260.130.13 query12 0.260.140.13 query13 0.640.630.64 query14 0.810.860.84 query15 0.970.890.89 query16 0.380.380.40 query17 1.031.051.04 query18 0.230.220.23 query19 1.921.841.84 query20 0.020.020.01 query21 15.36 1.040.68 query22 0.941.120.91 query23 14.72 1.590.77 query24 5.250.620.31 query25 0.160.100.10 query26 0.560.220.19 query27 0.090.090.09 query28 11.04 1.230.57 query29 12.59 4.133.38 query30 3.153.063.01 query31 2.820.620.42 query32 3.240.610.53 query33 3.063.103.10 query34 16.57 5.404.69 query35 4.884.904.95 query36 0.650.530.51 query37 0.210.190.17 query38 0.180.170.16 query39 0.050.040.05 query40 0.200.170.16 query41 0.100.050.05 query42 0.070.050.05 query43 0.050.050.05 Total cold run time: 107.43 s Total hot run time: 33.38 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3118501628 TPC-DS: Total hot run time: 186689 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 8b52452627eba562e35f0ffa1287812ad0a77dd5, data reload: false query1 998 396 403 396 query2 6504179417811781 query3 6748223 217 217 query4 26342 23452 22979 22979 query5 4394623 485 485 query6 320 219 220 219 query7 4629490 292 292 query8 276 257 222 222 query9 8597291329102910 query10 463 323 280 280 query11 15755 15015 14774 14774 query12 169 116 118 116 query13 1658534 415 415 query14 8818590359145903 query15 203 190 166 166 query16 7757624 486 486 query17 1217707 566 566 query18 2011400 314 314 query19 182 186 161 161 query20 131 119 131 119 query21 210 132 109 109 query22 4094428741414141 query23 33936 32892 32834 32834 query24 8066235123512351 query25 533 462 404 404 query26 1244273 159 159 query27 2748509 346 346 query28 4301222921992199 query29 742 569 445 445 query30 287 223 186 186 query31 890 808 714 714 query32 82 78 78 78 query33 553 379 335 335 query34 791 840 519 519 query35 792 880 749 749 query36 990 1011907 907 query37 123 110 91 91 query38 4116413941024102 query39 1480144013821382 query40 220 129 117 117 query41 60 57 54 54 query42 127 109 111 109 query43 523 510 485 485 query44 1315849 844 844 query45 178 173 179 173 query46 861 998 640 640 query47 1799184117621762 query48 388 427 314 314 query49 718 469 411 411 query50 640 694 391 391 query51 5485556254605460 query52 114 109 103 103 query53 227 258 187 187 query54 596 596 539 539 query55 85 86 85 85 query56 309 322 307 307 query57 1180119811431143 query58 288 273 271 271 query59 2812281326122612 query60 351 336 329 329 query61 132 126 120 120 query62 788 741 664 664 query63 221 191 183 183 query64 42841002704 704 query65 4220414141764141 query66 1110428 342 342 query67 16088 15422 15601 15422 query68 7883910 577 577 query69 498 314 281 281 query70 1251112111631121 query71 426 323 325 323 query72 5599474947574749 query73 669 615 355 355 query74 9014909186898689 query75 3421308326912691 query76 32421150761 761 query77 549 412 330 330 query78 9561961988578857 query79 1972802 596 596 query80 604 542 495 495 query81 521 254 220 220 query82 191 136 112 112 query83 263 253 238 238 query84 249 105 93 93 query85 774 373 332 332 query86 383 309 292 292 query87 4492438642524252 query88 2945224322352235 query89 384 317 288 288 query90 1982227 216 216 query91 138 147 115 115 query92 82 67 68 67 query93 1839997 632 632 query94 667 417 276 276 query95 392 314 310 310 query96 489 593 275 275 query97 2660275426212621 query98 238 232 211 211 query99 1320137313151315 Total cold run time: 272967 ms Total hot run time: 186689 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3118400331 TPC-H: Total hot run time: 34121 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 8b52452627eba562e35f0ffa1287812ad0a77dd5, data reload: false -- Round 1 -- q1 17581 521950145014 q2 1931291 194 194 q3 10374 1335726 726 q4 10281 1008538 538 q5 8329236823682368 q6 175 161 129 129 q7 894 756 635 635 q8 9303133611381138 q9 7128511551005100 q10 6893242219501950 q11 467 278 250 250 q12 342 347 217 217 q13 17766 366430873087 q14 242 246 216 216 q15 545 487 481 481 q16 426 437 380 380 q17 572 862 360 360 q18 7497716671937166 q19 1239973 569 569 q20 350 349 218 218 q21 3689317523972397 q22 10571023988 988 Total cold run time: 107081 ms Total hot run time: 34121 ms - Round 2, with runtime_filter_mode=off - q1 5159510050815081 q2 234 321 223 223 q3 2213269623552355 q4 1355175113321332 q5 4228458545464546 q6 227 176 129 129 q7 1984194018381838 q8 2668249326402493 q9 7354730872687268 q10 3090330528822882 q11 641 519 483 483 q12 747 786 654 654 q13 3788387633813381 q14 290 315 264 264 q15 521 470 470 470 q16 445 504 452 452 q17 1178156113881388 q18 8034781573597359 q19 774 725 786 725 q20 1878196017781778 q21 4795441842794279 q22 10781035998 998 Total cold run time: 52681 ms Total hot run time: 50378 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
hello-stephen commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3117829722 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/8b52452627eba562e35f0ffa1287812ad0a77dd5_8b52452627eba562e35f0ffa1287812ad0a77dd5_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/8b52452627eba562e35f0ffa1287812ad0a77dd5_8b52452627eba562e35f0ffa1287812ad0a77dd5_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 80.42% (1302/1619) | | Line Coverage | 65.79% (21805/33142) | | Region Coverage | 67.10% (10956/16328) | | Branch Coverage | 56.65% (5765/10176) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
zhiqiang- commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3117748664 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
github-actions[bot] commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3116832012 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
zhiqiang- commented on code in PR #52701: URL: https://github.com/apache/doris/pull/52701#discussion_r2230254480 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PushDownVirtualColumnsIntoOlapScan.java: ## @@ -0,0 +1,469 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.rules.rewrite; + +import org.apache.doris.catalog.KeysType; +import org.apache.doris.nereids.rules.Rule; +import org.apache.doris.nereids.rules.RuleType; +import org.apache.doris.nereids.trees.expressions.Alias; +import org.apache.doris.nereids.trees.expressions.Cast; +import org.apache.doris.nereids.trees.expressions.ComparisonPredicate; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.InPredicate; +import org.apache.doris.nereids.trees.expressions.IsNull; +import org.apache.doris.nereids.trees.expressions.NamedExpression; +import org.apache.doris.nereids.trees.expressions.Slot; +import org.apache.doris.nereids.trees.expressions.functions.scalar.DecodeAsVarchar; +import org.apache.doris.nereids.trees.expressions.functions.scalar.EncodeAsBigInt; +import org.apache.doris.nereids.trees.expressions.functions.scalar.EncodeAsInt; +import org.apache.doris.nereids.trees.expressions.functions.scalar.EncodeAsLargeInt; +import org.apache.doris.nereids.trees.expressions.functions.scalar.EncodeAsSmallInt; +import org.apache.doris.nereids.trees.expressions.functions.scalar.IsIpAddressInRange; +import org.apache.doris.nereids.trees.expressions.functions.scalar.Lambda; +import org.apache.doris.nereids.trees.expressions.functions.scalar.MultiMatch; +import org.apache.doris.nereids.trees.expressions.functions.scalar.MultiMatchAny; +import org.apache.doris.nereids.trees.plans.Plan; +import org.apache.doris.nereids.trees.plans.logical.LogicalFilter; +import org.apache.doris.nereids.trees.plans.logical.LogicalOlapScan; +import org.apache.doris.nereids.trees.plans.logical.LogicalProject; +import org.apache.doris.nereids.util.ExpressionUtils; + +import com.google.common.collect.ImmutableList; +import com.google.common.collect.Maps; +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; + +import java.util.HashMap; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.Set; + +/** + * Extract virtual columns from filter and push down them into olap scan. + * This rule can extract: + * 1. Common repeated sub-expressions across multiple conjuncts to eliminate redundant computation + * + * Example transformation: + * Before: + * Project[a, b, c] + * └── Filter[func(x, y) > 10 AND func(x, y) < 100 AND func(z, w) = func(x, y)] + * └── OlapScan[table] + * + * After: + * Project[a, b, c] + * └── Filter[v_func_1 > 10 AND v_func_1 < 100 AND v_func_2 = v_func_1] + * └── OlapScan[table, virtual_columns=[func(x, y) as v_func_1, func(z, w) as v_func_2]] + * + * Benefits: + * - Eliminates redundant computation of repeated expressions + * - Can leverage vectorization and SIMD optimizations at scan level + * - Reduces CPU usage in upper operators + * + * BLACKLIST STRATEGY: + * To avoid reverse optimization (preventing more important optimizations), this rule implements + * a blacklist strategy that skips certain types of expressions: + * + * 1. Index Pushdown Functions: Functions like is_ip_address_in_range(), multi_match(), match_* + *can be pushed down to storage engine as index operations. Virtual column optimization would + *prevent this index pushdown optimization. + * + * 2. ColumnPredicate Expressions: Comparison predicates (>, <, =, IN, IS NULL) can be converted + *to ColumnPredicate objects for efficient filtering in BE. Virtual columns would lose this + *optimization opportunity. + * + * 3. CAST Expressions: CAST operations are lightweight and creating virtual columns for them + *may not provide significant benefit while adding complexity. + * + * 4. Lambda-containing Expressions: Expressions with lambda functions have complex evaluation + *contexts that make virtual column optimization problematic. + */ +public class PushDownVirtua
Re: [PR] [feat] Virtual Slot Ref [doris]
airborne12 commented on code in PR #52701: URL: https://github.com/apache/doris/pull/52701#discussion_r2230203317 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PushDownVirtualColumnsIntoOlapScan.java: ## @@ -0,0 +1,469 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.rules.rewrite; + +import org.apache.doris.catalog.KeysType; +import org.apache.doris.nereids.rules.Rule; +import org.apache.doris.nereids.rules.RuleType; +import org.apache.doris.nereids.trees.expressions.Alias; +import org.apache.doris.nereids.trees.expressions.Cast; +import org.apache.doris.nereids.trees.expressions.ComparisonPredicate; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.InPredicate; +import org.apache.doris.nereids.trees.expressions.IsNull; +import org.apache.doris.nereids.trees.expressions.NamedExpression; +import org.apache.doris.nereids.trees.expressions.Slot; +import org.apache.doris.nereids.trees.expressions.functions.scalar.DecodeAsVarchar; +import org.apache.doris.nereids.trees.expressions.functions.scalar.EncodeAsBigInt; +import org.apache.doris.nereids.trees.expressions.functions.scalar.EncodeAsInt; +import org.apache.doris.nereids.trees.expressions.functions.scalar.EncodeAsLargeInt; +import org.apache.doris.nereids.trees.expressions.functions.scalar.EncodeAsSmallInt; +import org.apache.doris.nereids.trees.expressions.functions.scalar.IsIpAddressInRange; +import org.apache.doris.nereids.trees.expressions.functions.scalar.Lambda; +import org.apache.doris.nereids.trees.expressions.functions.scalar.MultiMatch; +import org.apache.doris.nereids.trees.expressions.functions.scalar.MultiMatchAny; +import org.apache.doris.nereids.trees.plans.Plan; +import org.apache.doris.nereids.trees.plans.logical.LogicalFilter; +import org.apache.doris.nereids.trees.plans.logical.LogicalOlapScan; +import org.apache.doris.nereids.trees.plans.logical.LogicalProject; +import org.apache.doris.nereids.util.ExpressionUtils; + +import com.google.common.collect.ImmutableList; +import com.google.common.collect.Maps; +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; + +import java.util.HashMap; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.Set; + +/** + * Extract virtual columns from filter and push down them into olap scan. + * This rule can extract: + * 1. Common repeated sub-expressions across multiple conjuncts to eliminate redundant computation + * + * Example transformation: + * Before: + * Project[a, b, c] + * └── Filter[func(x, y) > 10 AND func(x, y) < 100 AND func(z, w) = func(x, y)] + * └── OlapScan[table] + * + * After: + * Project[a, b, c] + * └── Filter[v_func_1 > 10 AND v_func_1 < 100 AND v_func_2 = v_func_1] + * └── OlapScan[table, virtual_columns=[func(x, y) as v_func_1, func(z, w) as v_func_2]] + * + * Benefits: + * - Eliminates redundant computation of repeated expressions + * - Can leverage vectorization and SIMD optimizations at scan level + * - Reduces CPU usage in upper operators + * + * BLACKLIST STRATEGY: + * To avoid reverse optimization (preventing more important optimizations), this rule implements + * a blacklist strategy that skips certain types of expressions: + * + * 1. Index Pushdown Functions: Functions like is_ip_address_in_range(), multi_match(), match_* + *can be pushed down to storage engine as index operations. Virtual column optimization would + *prevent this index pushdown optimization. + * + * 2. ColumnPredicate Expressions: Comparison predicates (>, <, =, IN, IS NULL) can be converted + *to ColumnPredicate objects for efficient filtering in BE. Virtual columns would lose this + *optimization opportunity. + * + * 3. CAST Expressions: CAST operations are lightweight and creating virtual columns for them + *may not provide significant benefit while adding complexity. + * + * 4. Lambda-containing Expressions: Expressions with lambda functions have complex evaluation + *contexts that make virtual column optimization problematic. + */ +public class PushDownVirtualCo
Re: [PR] [feat] Virtual Slot Ref [doris]
zhiqiang- commented on code in PR #52701:
URL: https://github.com/apache/doris/pull/52701#discussion_r2230051607
##
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##
@@ -485,6 +496,12 @@ Status SegmentIterator::_prepare_seek(const
StorageReadOptions::KeyRange& key_ra
// create used column iterator
for (auto cid : _seek_schema->column_ids()) {
if (_column_iterators[cid] == nullptr) {
+// TODO: Do we need this?
Review Comment:
> Is there any possible that virtual column use key range to seek?
Currently, no. Predicate on Virtual column will not be processed as
ColumnPredicate, so `_seek_schema` do not have virtual column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
airborne12 commented on code in PR #52701:
URL: https://github.com/apache/doris/pull/52701#discussion_r2230030437
##
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##
@@ -485,6 +496,12 @@ Status SegmentIterator::_prepare_seek(const
StorageReadOptions::KeyRange& key_ra
// create used column iterator
for (auto cid : _seek_schema->column_ids()) {
if (_column_iterators[cid] == nullptr) {
+// TODO: Do we need this?
Review Comment:
Is there any possible that virtual column use key range to seek?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
zhiqiang- commented on code in PR #52701:
URL: https://github.com/apache/doris/pull/52701#discussion_r2227195455
##
be/src/olap/rowset/segment_v2/virtual_column_iterator.cpp:
##
@@ -0,0 +1,166 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "virtual_column_iterator.h"
+
+#include
+#include
+
+#include "vec/columns/column.h"
+#include "vec/columns/column_nothing.h"
+
+namespace doris::segment_v2 {
+
+VirtualColumnIterator::VirtualColumnIterator()
+: _materialized_column_ptr(vectorized::ColumnNothing::create(0)) {}
+
+// Init implementation
+Status VirtualColumnIterator::init(const ColumnIteratorOptions& opts) {
+// Virtual column doesn't need special initialization
+return Status::OK();
+}
+
+// TODO(zhiqiang): What if input is empty?
+void VirtualColumnIterator::prepare_materialization(vectorized::IColumn::Ptr
column,
+
std::unique_ptr> labels) {
+DCHECK(labels->size() == column->size()) << "labels size: " <<
labels->size()
+ << ", materialized column size: "
<< column->size();
+// 1. do sort to labels
+// column: [100, 101, 102, 99, 50, 49]
+// lables: [5, 4, 1, 10, 7, 2]
+const std::vector& labels_ref = *labels;
Review Comment:
> std::vector> labels_order; <5,0> <4,1> <1.2> <10,3>
<7,4> <2,5>
>
> sort first
>
> <1,2> <2,5> <4,1> ... <10,3>
applied
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
zhiqiang- commented on code in PR #52701:
URL: https://github.com/apache/doris/pull/52701#discussion_r2227188115
##
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##
@@ -2184,7 +2316,7 @@ Status
SegmentIterator::_next_batch_internal(vectorized::Block* block) {
// step 3.2: read remaining expr column and evaluate it.
if (_is_need_expr_eval) {
// The predicate column contains the remaining expr
column, no need second read.
-if (!_non_predicate_column_ids.empty()) {
+if (_non_predicate_column_ids.size() > 0) {
Review Comment:
> why change this?
maybe clang-tidy suggestion during dev. It can be revert, I have no problem
with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
airborne12 commented on code in PR #52701:
URL: https://github.com/apache/doris/pull/52701#discussion_r2227180793
##
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##
@@ -2184,7 +2316,7 @@ Status
SegmentIterator::_next_batch_internal(vectorized::Block* block) {
// step 3.2: read remaining expr column and evaluate it.
if (_is_need_expr_eval) {
// The predicate column contains the remaining expr
column, no need second read.
-if (!_non_predicate_column_ids.empty()) {
+if (_non_predicate_column_ids.size() > 0) {
Review Comment:
why change this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
hello-stephen commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3109362337 # BE Regression && UT Coverage Report Increment line coverage `73.93% (468/633)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/52701_6a8ce208f5ca25f0370481271ddb529362e5531e_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/52701_6a8ce208f5ca25f0370481271ddb529362e5531e_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 81.04% (22057/27219) | | Line Coverage | 73.75% (228024/309194) | | Region Coverage | 61.53% (190838/310170) | | Branch Coverage | 65.21% (82172/126010) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3109315329 # BE UT Coverage Report Increment line coverage `30.65% (198/646)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/6a8ce208f5ca25f0370481271ddb529362e5531e_6a8ce208f5ca25f0370481271ddb529362e5531e/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/6a8ce208f5ca25f0370481271ddb529362e5531e_6a8ce208f5ca25f0370481271ddb529362e5531e/report/index.html) | Category | Coverage | |---|| | Function Coverage | 57.45% (15936/27740) | | Line Coverage | 46.25% (143216/309675) | | Region Coverage | 35.71% (108006/302455) | | Branch Coverage | 38.21% (47624/124622) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3108967764 ClickBench: Total hot run time: 33.49 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 6a8ce208f5ca25f0370481271ddb529362e5531e, data reload: false query1 0.040.040.03 query2 0.110.060.06 query3 0.300.070.07 query4 1.600.090.08 query5 0.430.410.40 query6 1.160.670.65 query7 0.030.010.01 query8 0.060.050.05 query9 0.640.510.52 query10 0.570.580.57 query11 0.260.130.14 query12 0.250.140.14 query13 0.650.640.63 query14 0.810.860.83 query15 0.990.910.91 query16 0.380.400.39 query17 1.051.051.11 query18 0.230.210.22 query19 1.991.862.01 query20 0.010.020.02 query21 15.36 1.000.68 query22 0.941.100.91 query23 14.74 1.510.79 query24 5.360.550.30 query25 0.160.100.09 query26 0.560.220.20 query27 0.100.100.09 query28 11.11 1.220.61 query29 12.53 3.993.40 query30 3.153.053.01 query31 2.830.620.43 query32 3.260.610.52 query33 3.103.123.16 query34 16.67 5.534.71 query35 4.904.864.82 query36 0.640.520.51 query37 0.200.180.18 query38 0.180.160.16 query39 0.050.040.05 query40 0.200.170.17 query41 0.100.060.05 query42 0.060.050.06 query43 0.070.050.05 Total cold run time: 107.83 s Total hot run time: 33.49 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3108946314 TPC-DS: Total hot run time: 188783 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 6a8ce208f5ca25f0370481271ddb529362e5531e, data reload: false query1 1013393 422 393 query2 6536167616801676 query3 6745225 221 221 query4 26277 23734 23243 23243 query5 4342637 506 506 query6 301 247 216 216 query7 4629524 308 308 query8 305 237 230 230 query9 8584292929242924 query10 483 337 282 282 query11 15936 15310 14992 14992 query12 163 119 118 118 query13 1658574 421 421 query14 9415611360886088 query15 208 198 173 173 query16 7435600 464 464 query17 1227722 583 583 query18 2002426 313 313 query19 199 208 167 167 query20 129 123 121 121 query21 209 126 111 111 query22 4128414940384038 query23 34071 33147 33208 33147 query24 8109239224572392 query25 534 473 414 414 query26 1228266 167 167 query27 2761506 346 346 query28 4379226722522252 query29 765 570 459 459 query30 295 227 193 193 query31 935 855 763 763 query32 79 80 77 77 query33 551 407 356 356 query34 801 847 528 528 query35 824 814 760 760 query36 992 1017920 920 query37 118 107 88 88 query38 4121418740414041 query39 1480142214061406 query40 223 129 118 118 query41 62 59 55 55 query42 126 113 114 113 query43 498 526 477 477 query44 1387881 869 869 query45 185 165 170 165 query46 855 1015659 659 query47 1756183117311731 query48 396 436 328 328 query49 739 483 397 397 query50 655 691 411 411 query51 5363552555635525 query52 112 113 104 104 query53 258 272 189 189 query54 609 609 539 539 query55 93 92 92 92 query56 323 317 305 305 query57 1159119511011101 query58 286 295 274 274 query59 2573268026022602 query60 351 340 346 340 query61 130 128 151 128 query62 818 750 661 661 query63 223 198 207 198 query64 43381013718 718 query65 4328419042314190 query66 1131422 327 327 query67 15920 15725 15458 15458 query68 7813909 593 593 query69 494 327 294 294 query70 1236115512021155 query71 448 326 309 309 query72 5880486150104861 query73 713 690 360 360 query74 8914907089118911 query75 3380320626312631 query76 33421128729 729 query77 643 420 338 338 query78 989810013 93089308 query79 3290798 600 600 query80 765 534 507 507 query81 509 265 219 219 query82 471 140 109 109 query83 312 248 292 248 query84 299 110 85 85 query85 804 364 327 327 query86 384 324 300 300 query87 4393445042964296 query88 3597228123162281 query89 391 324 283 283 query90 1890221 227 221 query91 133 144 122 122 query92 88 71 67 67 query93 2450960 646 646 query94 722 392 307 307 query95 405 319 314 314 query96 497 566 287 287 query97 2771272225992599 query98 265 225 214 214 query99 1457142812911291 Total cold run time: 277518 ms Total hot run time: 188783 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3108899788 TPC-H: Total hot run time: 34307 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 6a8ce208f5ca25f0370481271ddb529362e5531e, data reload: false -- Round 1 -- q1 17563 521950675067 q2 1942305 195 195 q3 10255 1313746 746 q4 10211 1015537 537 q5 7582244723502350 q6 185 166 130 130 q7 915 748 601 601 q8 9300134611151115 q9 7050512951925129 q10 6929238820002000 q11 509 283 271 271 q12 357 349 217 217 q13 17774 370431353135 q14 226 226 212 212 q15 559 497 470 470 q16 427 439 374 374 q17 626 874 389 389 q18 7771720570927092 q19 1229957 582 582 q20 364 349 232 232 q21 3979260424862486 q22 10751001977 977 Total cold run time: 106828 ms Total hot run time: 34307 ms - Round 2, with runtime_filter_mode=off - q1 5160506151185061 q2 242 322 216 216 q3 2212272923212321 q4 1342181213381338 q5 4232460946644609 q6 232 179 135 135 q7 2036202918251825 q8 2683278926002600 q9 7558711275777112 q10 3069330228632863 q11 574 522 513 513 q12 692 803 697 697 q13 3623399233503350 q14 279 309 307 307 q15 529 511 502 502 q16 467 524 451 451 q17 1179163714101410 q18 8051765776377637 q19 902 809 897 809 q20 2045201919381938 q21 5035441543934393 q22 1048100010061000 Total cold run time: 53190 ms Total hot run time: 51087 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
hello-stephen commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3108854461 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/6a8ce208f5ca25f0370481271ddb529362e5531e_6a8ce208f5ca25f0370481271ddb529362e5531e_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/6a8ce208f5ca25f0370481271ddb529362e5531e_6a8ce208f5ca25f0370481271ddb529362e5531e_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 80.42% (1302/1619) | | Line Coverage | 65.80% (21807/33140) | | Region Coverage | 67.12% (10959/16328) | | Branch Coverage | 56.70% (5770/10176) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
zhiqiang- commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3108748459 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
hello-stephen commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3108700754 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/056b84fb3fc781b5918ecfd7694b610bb3fa2728_056b84fb3fc781b5918ecfd7694b610bb3fa2728_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/056b84fb3fc781b5918ecfd7694b610bb3fa2728_056b84fb3fc781b5918ecfd7694b610bb3fa2728_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 80.42% (1302/1619) | | Line Coverage | 65.76% (21794/33140) | | Region Coverage | 67.04% (10946/16328) | | Branch Coverage | 56.63% (5763/10176) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
zhiqiang- commented on code in PR #52701:
URL: https://github.com/apache/doris/pull/52701#discussion_r2225645859
##
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##
@@ -2594,7 +2778,63 @@ bool SegmentIterator::_can_opt_topn_reads() {
return all_true;
}
-#include "common/compile_check_end.h"
+// Before get next batch. make sure all virtual columns in block has type
ColumnNothing.
+void SegmentIterator::_init_virtual_columns(vectorized::Block* block) {
+for (const auto& pair : _vir_cid_to_idx_in_block) {
+auto& col_with_type_and_name = block->get_by_position(pair.second);
+col_with_type_and_name.column = vectorized::ColumnNothing::create(0);
+col_with_type_and_name.type = _opts.vir_col_idx_to_type[pair.second];
+}
+}
+
+Status SegmentIterator::_materialization_of_virtual_column(vectorized::Block*
block) {
+size_t prev_block_columns = block->columns();
+for (const auto& cid_and_expr : _virtual_column_exprs) {
+auto cid = cid_and_expr.first;
+auto column_expr = cid_and_expr.second;
+size_t idx_in_block = _vir_cid_to_idx_in_block[cid];
+if (block->columns() <= idx_in_block) {
+LOG_ERROR("Block columns: {}, virtual column idx {}",
block->columns(), idx_in_block);
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
zhiqiang- commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3108506101 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
zhiqiang- commented on code in PR #52701:
URL: https://github.com/apache/doris/pull/52701#discussion_r2225449996
##
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##
@@ -2594,7 +2778,63 @@ bool SegmentIterator::_can_opt_topn_reads() {
return all_true;
}
-#include "common/compile_check_end.h"
+// Before get next batch. make sure all virtual columns in block has type
ColumnNothing.
+void SegmentIterator::_init_virtual_columns(vectorized::Block* block) {
+for (const auto& pair : _vir_cid_to_idx_in_block) {
+auto& col_with_type_and_name = block->get_by_position(pair.second);
+col_with_type_and_name.column = vectorized::ColumnNothing::create(0);
+col_with_type_and_name.type = _opts.vir_col_idx_to_type[pair.second];
+}
+}
+
+Status SegmentIterator::_materialization_of_virtual_column(vectorized::Block*
block) {
+size_t prev_block_columns = block->columns();
+for (const auto& cid_and_expr : _virtual_column_exprs) {
+auto cid = cid_and_expr.first;
+auto column_expr = cid_and_expr.second;
+size_t idx_in_block = _vir_cid_to_idx_in_block[cid];
+if (block->columns() <= idx_in_block) {
+LOG_ERROR("Block columns: {}, virtual column idx {}",
block->columns(), idx_in_block);
Review Comment:
> why log and return the same error status in code ? seems status have
enough msg?
I will remove the repetitive log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
HappenLee commented on code in PR #52701:
URL: https://github.com/apache/doris/pull/52701#discussion_r2225438041
##
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##
@@ -2594,7 +2778,63 @@ bool SegmentIterator::_can_opt_topn_reads() {
return all_true;
}
-#include "common/compile_check_end.h"
+// Before get next batch. make sure all virtual columns in block has type
ColumnNothing.
+void SegmentIterator::_init_virtual_columns(vectorized::Block* block) {
+for (const auto& pair : _vir_cid_to_idx_in_block) {
+auto& col_with_type_and_name = block->get_by_position(pair.second);
+col_with_type_and_name.column = vectorized::ColumnNothing::create(0);
+col_with_type_and_name.type = _opts.vir_col_idx_to_type[pair.second];
+}
+}
+
+Status SegmentIterator::_materialization_of_virtual_column(vectorized::Block*
block) {
+size_t prev_block_columns = block->columns();
+for (const auto& cid_and_expr : _virtual_column_exprs) {
+auto cid = cid_and_expr.first;
+auto column_expr = cid_and_expr.second;
+size_t idx_in_block = _vir_cid_to_idx_in_block[cid];
+if (block->columns() <= idx_in_block) {
+LOG_ERROR("Block columns: {}, virtual column idx {}",
block->columns(), idx_in_block);
Review Comment:
why log and return the same error status in code ? seems status have enough
msg?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
hello-stephen commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3107689591 # BE Regression && UT Coverage Report Increment line coverage `73.57% (476/647)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/52701_02889bed4e175fc1d9b5532f9202bdb941c3ff92_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/52701_02889bed4e175fc1d9b5532f9202bdb941c3ff92_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 81.02% (22053/27219) | | Line Coverage | 73.66% (227764/309211) | | Region Coverage | 61.40% (190476/310227) | | Branch Coverage | 65.11% (82059/126031) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
hello-stephen commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3107654190 # BE UT Coverage Report Increment line coverage `30.24% (199/658)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/02889bed4e175fc1d9b5532f9202bdb941c3ff92_02889bed4e175fc1d9b5532f9202bdb941c3ff92/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/02889bed4e175fc1d9b5532f9202bdb941c3ff92_02889bed4e175fc1d9b5532f9202bdb941c3ff92/report/index.html) | Category | Coverage | |---|| | Function Coverage | 57.45% (15938/27740) | | Line Coverage | 46.25% (143220/309692) | | Region Coverage | 35.71% (108014/302512) | | Branch Coverage | 38.22% (47636/124643) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
HappenLee commented on code in PR #52701:
URL: https://github.com/apache/doris/pull/52701#discussion_r2225355086
##
be/src/olap/rowset/segment_v2/virtual_column_iterator.cpp:
##
@@ -0,0 +1,166 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "virtual_column_iterator.h"
+
+#include
+#include
+
+#include "vec/columns/column.h"
+#include "vec/columns/column_nothing.h"
+
+namespace doris::segment_v2 {
+
+VirtualColumnIterator::VirtualColumnIterator()
+: _materialized_column_ptr(vectorized::ColumnNothing::create(0)) {}
+
+// Init implementation
+Status VirtualColumnIterator::init(const ColumnIteratorOptions& opts) {
+// Virtual column doesn't need special initialization
+return Status::OK();
+}
+
+// TODO(zhiqiang): What if input is empty?
+void VirtualColumnIterator::prepare_materialization(vectorized::IColumn::Ptr
column,
+
std::unique_ptr> labels) {
+DCHECK(labels->size() == column->size()) << "labels size: " <<
labels->size()
+ << ", materialized column size: "
<< column->size();
+// 1. do sort to labels
+// column: [100, 101, 102, 99, 50, 49]
+// lables: [5, 4, 1, 10, 7, 2]
+const std::vector& labels_ref = *labels;
Review Comment:
std::vector> labels_order;
<5,0> <4,1> <1.2> <10,3> <7,4> <2,5>
sort first
<1,2> <2,5> <4,1> ... <10,3>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
zhiqiang- commented on code in PR #52701:
URL: https://github.com/apache/doris/pull/52701#discussion_r2225097047
##
be/src/vec/exprs/virtual_slot_ref.cpp:
##
@@ -0,0 +1,207 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "vec/exprs/virtual_slot_ref.h"
+
+#include
+#include
+#include
+
+#include
+
+#include "common/exception.h"
+#include "common/logging.h"
+#include "common/status.h"
+#include "runtime/descriptors.h"
+#include "runtime/runtime_state.h"
+#include "vec/columns/column.h"
+#include "vec/columns/column_nothing.h"
+#include "vec/core/block.h"
+#include "vec/core/column_with_type_and_name.h"
+#include "vec/exprs/vectorized_fn_call.h"
+#include "vec/exprs/vexpr_context.h"
+#include "vec/exprs/vexpr_fwd.h"
+
+namespace doris::vectorized {
+
+VirtualSlotRef::VirtualSlotRef(const doris::TExprNode& node)
+: VExpr(node),
+ _column_id(-1),
+ _slot_id(node.slot_ref.slot_id),
+ _column_name(nullptr),
+ _column_label(node.label) {}
+
+VirtualSlotRef::VirtualSlotRef(const SlotDescriptor* desc)
+: VExpr(desc->type(), false), _column_id(-1), _slot_id(desc->id()),
_column_name(nullptr) {}
+
+Status VirtualSlotRef::prepare(doris::RuntimeState* state, const
doris::RowDescriptor& desc,
+ VExprContext* context) {
+RETURN_IF_ERROR_OR_PREPARED(VExpr::prepare(state, desc, context));
+DCHECK_EQ(_children.size(), 0);
+if (_slot_id == -1) {
+_prepare_finished = true;
+return Status::OK();
+}
+
+const SlotDescriptor* slot_desc =
state->desc_tbl().get_slot_descriptor(_slot_id);
+if (slot_desc == nullptr) {
+return Status::Error(
+"couldn't resolve slot descriptor {}, desc: {}", _slot_id,
+state->desc_tbl().debug_string());
+}
+
+if (slot_desc->get_virtual_column_expr() == nullptr) {
+return Status::InternalError(
+"VirtualSlotRef {} has no virtual column expr, slot_id: {},
desc: {}, "
+"slot_desc: {}, desc_tbl: {}",
+*_column_name, _slot_id, desc.debug_string(),
slot_desc->debug_string(),
+state->desc_tbl().debug_string());
+}
+
+_column_name = &slot_desc->col_name();
+_column_data_type = slot_desc->get_data_type_ptr();
+DCHECK(_column_data_type != nullptr);
+if (!context->force_materialize_slot() && !slot_desc->is_materialized()) {
+// slot should be ignored manually
+_column_id = -1;
+_prepare_finished = true;
+return Status::OK();
+}
+
+_column_id = desc.get_column_id(_slot_id,
context->force_materialize_slot());
+if (_column_id < 0) {
+return Status::Error(
+"VirtualSlotRef {} has invalid slot id: "
+"{}.\nslot_desc:\n{},\ndesc:\n{},\ndesc_tbl:\n{}",
+*_column_name, _slot_id, slot_desc->debug_string(),
desc.debug_string(),
+state->desc_tbl().debug_string());
+}
+const TExpr& expr = *slot_desc->get_virtual_column_expr();
+// Create a temp_ctx only for create_expr_tree.
+VExprContextSPtr temp_ctx;
+RETURN_IF_ERROR(VExpr::create_expr_tree(expr, temp_ctx));
+_virtual_column_expr = temp_ctx->root();
+// Virtual column expr should do prepare with original context.
+RETURN_IF_ERROR(_virtual_column_expr->prepare(state, desc, context));
+_prepare_finished = true;
+return Status::OK();
+}
+
+Status VirtualSlotRef::open(RuntimeState* state, VExprContext* context,
+FunctionContext::FunctionStateScope scope) {
+DCHECK(_prepare_finished);
+RETURN_IF_ERROR(_virtual_column_expr->open(state, context, scope));
+RETURN_IF_ERROR(VExpr::open(state, context, scope));
+_open_finished = true;
+return Status::OK();
+}
+
+Status VirtualSlotRef::execute(VExprContext* context, Block* block, int*
result_column_id) {
+if (_column_id >= 0 && _column_id >= block->columns()) {
Review Comment:
> line 86 in prepare already check the _column_id < 0 return error. should
here no need do _column_id >= 0 check ？
yes, check of `_column_id > 0` can be removed.
--
This is an autom
Re: [PR] [feat] Virtual Slot Ref [doris]
HappenLee commented on code in PR #52701:
URL: https://github.com/apache/doris/pull/52701#discussion_r2225079304
##
be/src/vec/exprs/virtual_slot_ref.cpp:
##
@@ -0,0 +1,207 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "vec/exprs/virtual_slot_ref.h"
+
+#include
+#include
+#include
+
+#include
+
+#include "common/exception.h"
+#include "common/logging.h"
+#include "common/status.h"
+#include "runtime/descriptors.h"
+#include "runtime/runtime_state.h"
+#include "vec/columns/column.h"
+#include "vec/columns/column_nothing.h"
+#include "vec/core/block.h"
+#include "vec/core/column_with_type_and_name.h"
+#include "vec/exprs/vectorized_fn_call.h"
+#include "vec/exprs/vexpr_context.h"
+#include "vec/exprs/vexpr_fwd.h"
+
+namespace doris::vectorized {
+
+VirtualSlotRef::VirtualSlotRef(const doris::TExprNode& node)
+: VExpr(node),
+ _column_id(-1),
+ _slot_id(node.slot_ref.slot_id),
+ _column_name(nullptr),
+ _column_label(node.label) {}
+
+VirtualSlotRef::VirtualSlotRef(const SlotDescriptor* desc)
+: VExpr(desc->type(), false), _column_id(-1), _slot_id(desc->id()),
_column_name(nullptr) {}
+
+Status VirtualSlotRef::prepare(doris::RuntimeState* state, const
doris::RowDescriptor& desc,
+ VExprContext* context) {
+RETURN_IF_ERROR_OR_PREPARED(VExpr::prepare(state, desc, context));
+DCHECK_EQ(_children.size(), 0);
+if (_slot_id == -1) {
+_prepare_finished = true;
+return Status::OK();
+}
+
+const SlotDescriptor* slot_desc =
state->desc_tbl().get_slot_descriptor(_slot_id);
+if (slot_desc == nullptr) {
+return Status::Error(
+"couldn't resolve slot descriptor {}, desc: {}", _slot_id,
+state->desc_tbl().debug_string());
+}
+
+if (slot_desc->get_virtual_column_expr() == nullptr) {
+return Status::InternalError(
+"VirtualSlotRef {} has no virtual column expr, slot_id: {},
desc: {}, "
+"slot_desc: {}, desc_tbl: {}",
+*_column_name, _slot_id, desc.debug_string(),
slot_desc->debug_string(),
+state->desc_tbl().debug_string());
+}
+
+_column_name = &slot_desc->col_name();
+_column_data_type = slot_desc->get_data_type_ptr();
+DCHECK(_column_data_type != nullptr);
+if (!context->force_materialize_slot() && !slot_desc->is_materialized()) {
+// slot should be ignored manually
+_column_id = -1;
+_prepare_finished = true;
+return Status::OK();
+}
+
+_column_id = desc.get_column_id(_slot_id,
context->force_materialize_slot());
+if (_column_id < 0) {
+return Status::Error(
+"VirtualSlotRef {} has invalid slot id: "
+"{}.\nslot_desc:\n{},\ndesc:\n{},\ndesc_tbl:\n{}",
+*_column_name, _slot_id, slot_desc->debug_string(),
desc.debug_string(),
+state->desc_tbl().debug_string());
+}
+const TExpr& expr = *slot_desc->get_virtual_column_expr();
+// Create a temp_ctx only for create_expr_tree.
+VExprContextSPtr temp_ctx;
+RETURN_IF_ERROR(VExpr::create_expr_tree(expr, temp_ctx));
+_virtual_column_expr = temp_ctx->root();
+// Virtual column expr should do prepare with original context.
+RETURN_IF_ERROR(_virtual_column_expr->prepare(state, desc, context));
+_prepare_finished = true;
+return Status::OK();
+}
+
+Status VirtualSlotRef::open(RuntimeState* state, VExprContext* context,
+FunctionContext::FunctionStateScope scope) {
+DCHECK(_prepare_finished);
+RETURN_IF_ERROR(_virtual_column_expr->open(state, context, scope));
+RETURN_IF_ERROR(VExpr::open(state, context, scope));
+_open_finished = true;
+return Status::OK();
+}
+
+Status VirtualSlotRef::execute(VExprContext* context, Block* block, int*
result_column_id) {
+if (_column_id >= 0 && _column_id >= block->columns()) {
Review Comment:
line 86 in prepare already check the _column_id < 0 return error. should
here no need do _column_id >= 0 check ？
--
This is an automated message from the Apache Git Service.
To respond to the
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3106670878 ClickBench: Total hot run time: 32.68 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 02889bed4e175fc1d9b5532f9202bdb941c3ff92, data reload: false query1 0.040.030.03 query2 0.080.050.04 query3 0.240.080.08 query4 1.620.120.11 query5 0.430.400.40 query6 1.190.650.67 query7 0.030.010.02 query8 0.050.040.04 query9 0.610.510.51 query10 0.570.570.57 query11 0.160.110.10 query12 0.150.120.12 query13 0.630.630.61 query14 0.800.830.83 query15 0.900.870.89 query16 0.390.380.39 query17 1.091.061.08 query18 0.210.200.20 query19 2.011.841.84 query20 0.010.020.01 query21 15.40 0.920.56 query22 0.781.180.82 query23 14.79 1.380.65 query24 7.300.610.81 query25 0.470.230.09 query26 0.670.200.14 query27 0.060.050.06 query28 9.520.920.41 query29 12.64 3.993.32 query30 3.093.043.00 query31 2.820.600.38 query32 3.230.540.47 query33 3.063.173.19 query34 16.01 5.454.83 query35 4.894.894.90 query36 0.690.510.49 query37 0.090.070.06 query38 0.060.040.04 query39 0.040.030.03 query40 0.170.140.14 query41 0.070.020.03 query42 0.030.030.02 query43 0.030.030.03 Total cold run time: 107.12 s Total hot run time: 32.68 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3106651632 TPC-DS: Total hot run time: 187537 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 02889bed4e175fc1d9b5532f9202bdb941c3ff92, data reload: false query1 991 396 422 396 query2 6560174417281728 query3 6748231 225 225 query4 26501 23610 23600 23600 query5 4329605 479 479 query6 302 210 198 198 query7 4623514 291 291 query8 288 244 221 221 query9 8600280628262806 query10 470 332 295 295 query11 15830 15204 14786 14786 query12 160 115 113 113 query13 1661532 401 401 query14 8696593458695869 query15 215 199 176 176 query16 7135635 470 470 query17 1220724 592 592 query18 1996418 323 323 query19 196 193 164 164 query20 130 123 113 113 query21 217 129 109 109 query22 4011418240154015 query23 34061 33008 33172 33008 query24 8179240124082401 query25 564 557 409 409 query26 1240270 158 158 query27 2755501 344 344 query28 4349216321402140 query29 767 565 455 455 query30 293 221 192 192 query31 909 846 769 769 query32 82 77 75 75 query33 564 464 347 347 query34 801 840 514 514 query35 783 842 733 733 query36 963 1017929 929 query37 124 100 88 88 query38 4128404440284028 query39 1465142114101410 query40 222 129 115 115 query41 64 58 75 58 query42 118 113 109 109 query43 491 508 482 482 query44 1331841 821 821 query45 176 171 170 170 query46 864 998 645 645 query47 1837182817321732 query48 372 419 306 306 query49 734 470 421 421 query50 682 696 405 405 query51 5578555755035503 query52 121 111 107 107 query53 238 265 191 191 query54 602 615 527 527 query55 89 85 85 85 query56 324 342 314 314 query57 1189121211121112 query58 286 275 269 269 query59 2650272926232623 query60 373 342 345 342 query61 125 121 125 121 query62 781 711 656 656 query63 229 198 191 191 query64 43471040686 686 query65 4245419341814181 query66 1174415 327 327 query67 15887 15849 15268 15268 query68 8023904 546 546 query69 484 327 284 284 query70 1249110710891089 query71 467 334 309 309 query72 5608491748234823 query73 732 639 351 351 query74 9289918588168816 query75 3893312126802680 query76 37321117744 744 query77 770 403 314 314 query78 994910116 93419341 query79 1778842 587 587 query80 632 539 477 477 query81 482 252 223 223 query82 418 135 106 106 query83 278 250 254 250 query84 296 106 79 79 query85 767 404 326 326 query86 350 300 284 284 query87 4434438042764276 query88 2804223222112211 query89 378 323 284 284 query90 1970217 210 210 query91 142 145 113 113 query92 90 71 66 66 query93 954 629 629 query94 677 399 270 270 query95 397 325 315 315 query96 482 586 270 270 query97 2715274626132613 query98 235 213 220 213 query99 1449139313011301 Total cold run time: 274116 ms Total hot run time: 187537 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3106616101 TPC-H: Total hot run time: 34150 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 02889bed4e175fc1d9b5532f9202bdb941c3ff92, data reload: false -- Round 1 -- q1 17583 533551225122 q2 1918293 195 195 q3 10297 1491714 714 q4 10215 1029508 508 q5 7527242023242324 q6 177 165 129 129 q7 923 744 607 607 q8 9312130110851085 q9 7137513251805132 q10 6910241719711971 q11 490 290 263 263 q12 350 343 210 210 q13 17774 371130993099 q14 231 227 228 227 q15 547 479 478 478 q16 422 450 371 371 q17 600 869 368 368 q18 7613727472217221 q19 1217964 584 584 q20 333 346 225 225 q21 3936255923172317 q22 1083104610001000 Total cold run time: 106595 ms Total hot run time: 34150 ms - Round 2, with runtime_filter_mode=off - q1 5159515251195119 q2 249 326 228 228 q3 2226272123182318 q4 1324178813651365 q5 4255457746554577 q6 213 164 125 125 q7 2065193218491849 q8 2667271725842584 q9 7498750171147114 q10 3129330828712871 q11 566 522 491 491 q12 752 809 619 619 q13 3643400534203420 q14 275 310 287 287 q15 533 474 482 474 q16 443 520 441 441 q17 1195160714031403 q18 7999782775257525 q19 848 852 854 852 q20 1971208819901990 q21 5038430743524307 q22 10361043989 989 Total cold run time: 53084 ms Total hot run time: 50948 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
hello-stephen commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3106455216 # FE UT Coverage Report Increment line coverage ` 59.27% (227/383)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/52701_02889bed4e175fc1d9b5532f9202bdb941c3ff92/fe_increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/52701_02889bed4e175fc1d9b5532f9202bdb941c3ff92/fe_report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
hello-stephen commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3106270477 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/02889bed4e175fc1d9b5532f9202bdb941c3ff92_02889bed4e175fc1d9b5532f9202bdb941c3ff92_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/02889bed4e175fc1d9b5532f9202bdb941c3ff92_02889bed4e175fc1d9b5532f9202bdb941c3ff92_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 80.42% (1302/1619) | | Line Coverage | 65.80% (21807/33140) | | Region Coverage | 67.07% (10951/16328) | | Branch Coverage | 56.67% (5767/10176) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
zhiqiang- commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3106169543 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3105523868 ClickBench: Total hot run time: 33.47 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit a496202e11521d16d54fbf545787c275c4bb631b, data reload: false query1 0.040.040.04 query2 0.120.060.06 query3 0.300.070.06 query4 1.610.080.09 query5 0.420.420.41 query6 1.160.650.66 query7 0.030.020.01 query8 0.060.050.05 query9 0.650.520.53 query10 0.590.590.59 query11 0.260.130.13 query12 0.250.140.14 query13 0.660.640.65 query14 0.830.840.86 query15 0.980.880.90 query16 0.380.390.40 query17 1.081.051.06 query18 0.230.220.23 query19 2.041.852.00 query20 0.020.020.01 query21 15.34 1.000.69 query22 0.941.170.92 query23 14.71 1.490.77 query24 5.180.640.31 query25 0.160.100.09 query26 0.570.220.20 query27 0.090.090.09 query28 11.00 1.190.59 query29 12.57 4.063.43 query30 3.113.083.02 query31 2.810.620.42 query32 3.260.610.52 query33 3.213.243.09 query34 16.83 5.484.73 query35 4.834.794.81 query36 0.660.520.50 query37 0.200.180.17 query38 0.170.170.16 query39 0.060.060.05 query40 0.200.170.17 query41 0.110.050.05 query42 0.060.050.06 query43 0.050.040.04 Total cold run time: 107.83 s Total hot run time: 33.47 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3105516526 TPC-DS: Total hot run time: 187707 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit a496202e11521d16d54fbf545787c275c4bb631b, data reload: false query1 1012394 394 394 query2 6530176916911691 query3 6737226 217 217 query4 26744 23355 22952 22952 query5 4392629 496 496 query6 317 228 203 203 query7 4629513 309 309 query8 275 238 222 222 query9 8593284728502847 query10 473 323 282 282 query11 15855 15006 14818 14818 query12 159 120 113 113 query13 1664529 417 417 query14 9148600760766007 query15 202 194 167 167 query16 7344605 468 468 query17 1200731 599 599 query18 2002423 318 318 query19 194 200 172 172 query20 127 128 115 115 query21 215 125 112 112 query22 4242413243374132 query23 34075 33055 32877 32877 query24 8088237324112373 query25 535 474 429 429 query26 818 281 161 161 query27 2711512 345 345 query28 4310217621642164 query29 700 593 458 458 query30 288 218 190 190 query31 907 814 782 782 query32 80 84 78 78 query33 556 379 338 338 query34 772 840 535 535 query35 803 835 751 751 query36 971 1012902 902 query37 121 103 88 88 query38 4310410140384038 query39 1478142514261425 query40 237 125 118 118 query41 63 65 53 53 query42 129 115 109 109 query43 521 514 477 477 query44 1306857 832 832 query45 181 166 166 166 query46 832 989 629 629 query47 1790186617441744 query48 386 447 306 306 query49 666 471 392 392 query50 657 701 398 398 query51 5578549253955395 query52 113 113 107 107 query53 231 267 186 186 query54 603 607 546 546 query55 87 87 92 87 query56 328 322 322 322 query57 1207119111261126 query58 278 275 276 275 query59 2689268926172617 query60 343 386 330 330 query61 128 119 118 118 query62 780 703 672 672 query63 233 198 189 189 query64 35211002692 692 query65 4263420841904190 query66 1044437 330 330 query67 15741 15606 15648 15606 query68 8034910 571 571 query69 483 330 287 287 query70 1238117111591159 query71 448 334 320 320 query72 5362478448684784 query73 742 610 354 354 query74 9193911389538953 query75 3846311326142614 query76 36381182740 740 query77 788 392 331 331 query78 998910156 93339333 query79 2488847 585 585 query80 656 581 480 480 query81 493 252 229 229 query82 429 154 113 113 query83 283 253 239 239 query84 298 107 89 89 query85 783 357 321 321 query86 345 325 312 312 query87 4440446343414341 query88 3202223422322232 query89 385 320 286 286 query90 1921226 226 226 query91 142 137 117 117 query92 85 75 72 72 query93 1706975 631 631 query94 682 414 308 308 query95 403 384 317 317 query96 496 573 279 279 query97 2696276126092609 query98 243 216 216 216 query99 1462142812621262 Total cold run time: 274911 ms Total hot run time: 187707 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3105500720 TPC-H: Total hot run time: 34204 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit a496202e11521d16d54fbf545787c275c4bb631b, data reload: false -- Round 1 -- q1 17664 531852485248 q2 1929287 186 186 q3 10392 1331735 735 q4 10259 994 508 508 q5 8070247323062306 q6 188 160 132 132 q7 916 741 611 611 q8 9325133611021102 q9 7171509351235093 q10 6889239819811981 q11 476 310 277 277 q12 339 355 212 212 q13 17771 379131163116 q14 242 234 221 221 q15 551 477 485 477 q16 425 452 377 377 q17 614 866 361 361 q18 7447715371707153 q19 1291972 571 571 q20 329 338 223 223 q21 4109321523412341 q22 10541058973 973 Total cold run time: 107451 ms Total hot run time: 34204 ms - Round 2, with runtime_filter_mode=off - q1 5245523052395230 q2 240 321 223 223 q3 2220270623142314 q4 1405178813361336 q5 4455451345724513 q6 239 170 133 133 q7 2034197518321832 q8 2661261726342617 q9 7272740673417341 q10 3071335328562856 q11 595 520 495 495 q12 718 787 641 641 q13 3618401535043504 q14 292 308 277 277 q15 536 485 486 485 q16 463 495 433 433 q17 1207160014131413 q18 7975788573887388 q19 760 748 760 748 q20 1974195918331833 q21 4878438243214321 q22 10571071990 990 Total cold run time: 52915 ms Total hot run time: 50923 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
hello-stephen commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3105433293 # FE UT Coverage Report Increment line coverage ` 59.27% (227/383)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/52701_a496202e11521d16d54fbf545787c275c4bb631b/fe_increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/52701_a496202e11521d16d54fbf545787c275c4bb631b/fe_report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3105330187 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/a496202e11521d16d54fbf545787c275c4bb631b_a496202e11521d16d54fbf545787c275c4bb631b_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/a496202e11521d16d54fbf545787c275c4bb631b_a496202e11521d16d54fbf545787c275c4bb631b_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 80.42% (1302/1619) | | Line Coverage | 65.78% (21799/33140) | | Region Coverage | 67.09% (10955/16328) | | Branch Coverage | 56.65% (5765/10176) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
zhiqiang- commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3105289309 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3104169152 ClickBench: Total hot run time: 32.84 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 444766e96dfed4795b9a642daf32804d606b9604, data reload: false query1 0.040.030.03 query2 0.080.040.05 query3 0.250.070.08 query4 1.620.110.11 query5 0.440.410.40 query6 1.180.650.66 query7 0.030.020.02 query8 0.050.040.04 query9 0.610.510.51 query10 0.570.580.57 query11 0.150.110.10 query12 0.150.120.11 query13 0.630.610.60 query14 0.800.840.86 query15 0.900.860.90 query16 0.400.390.40 query17 1.081.061.04 query18 0.210.200.20 query19 1.901.801.90 query20 0.010.010.01 query21 15.39 0.900.54 query22 0.771.090.80 query23 14.88 1.390.61 query24 6.801.041.46 query25 0.510.260.06 query26 0.490.180.13 query27 0.060.050.05 query28 10.20 0.920.43 query29 12.53 4.063.34 query30 3.132.992.93 query31 2.820.570.40 query32 3.250.560.48 query33 3.173.053.08 query34 15.80 5.434.89 query35 4.884.864.90 query36 0.690.500.49 query37 0.090.070.07 query38 0.060.040.04 query39 0.030.030.03 query40 0.170.140.14 query41 0.080.030.02 query42 0.030.030.02 query43 0.030.030.03 Total cold run time: 106.96 s Total hot run time: 32.84 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3104144722 TPC-DS: Total hot run time: 187856 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 444766e96dfed4795b9a642daf32804d606b9604, data reload: false query1 990 384 420 384 query2 6514172617461726 query3 6744227 225 225 query4 27009 23651 22942 22942 query5 4401620 501 501 query6 336 229 212 212 query7 4619502 298 298 query8 261 232 215 215 query9 8596285728692857 query10 479 332 279 279 query11 16102 15485 14769 14769 query12 169 116 110 110 query13 1655552 402 402 query14 9512598460265984 query15 229 189 168 168 query16 7382666 474 474 query17 1204722 595 595 query18 2033412 319 319 query19 191 192 178 178 query20 130 118 122 118 query21 213 130 115 115 query22 4237448642794279 query23 34144 33080 33087 33080 query24 8142238323692369 query25 550 489 399 399 query26 1223273 155 155 query27 2744496 349 349 query28 4330219521612161 query29 758 563 471 471 query30 291 220 190 190 query31 921 827 753 753 query32 76 80 76 76 query33 587 374 335 335 query34 799 830 522 522 query35 781 809 759 759 query36 993 991 932 932 query37 118 105 96 96 query38 4119418740414041 query39 1490141313991399 query40 229 123 113 113 query41 59 56 53 53 query42 122 109 114 109 query43 528 509 471 471 query44 1324831 832 831 query45 185 170 169 169 query46 845 998 630 630 query47 1780179717691769 query48 370 426 318 318 query49 729 470 377 377 query50 631 685 419 419 query51 5738557855125512 query52 114 113 107 107 query53 234 260 194 194 query54 610 611 528 528 query55 91 88 88 88 query56 324 320 304 304 query57 1195120411391139 query58 276 270 263 263 query59 2619278526412641 query60 348 346 344 344 query61 130 125 118 118 query62 804 718 664 664 query63 226 192 193 192 query64 42881000684 684 query65 4295416841564156 query66 1183421 327 327 query67 15907 15705 15407 15407 query68 8487911 553 553 query69 523 328 297 297 query70 1276122011661166 query71 463 331 305 305 query72 5663481348644813 query73 771 665 358 358 query74 9230901489018901 query75 3966310726742674 query76 37031116724 724 query77 791 394 325 325 query78 9938997691929192 query79 3560859 593 593 query80 711 550 489 489 query81 466 265 229 229 query82 457 136 113 113 query83 287 248 244 244 query84 295 104 90 90 query85 788 365 338 338 query86 340 331 318 318 query87 4447436744184367 query88 3029224322462243 query89 449 310 292 292 query90 1954233 226 226 query91 137 137 113 113 query92 82 72 69 69 query93 2320996 633 633 query94 689 390 315 315 query95 399 320 315 315 query96 496 594 276 276 query97 2678279226322632 query98 243 216 211 211 query99 1434140712781278 Total cold run time: 280328 ms Total hot run time: 187856 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3104094197 TPC-H: Total hot run time: 34371 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 444766e96dfed4795b9a642daf32804d606b9604, data reload: false -- Round 1 -- q1 17588 536651705170 q2 1945304 181 181 q3 10281 1371736 736 q4 10235 1045522 522 q5 7515244523612361 q6 180 162 133 133 q7 918 757 594 594 q8 9313130511751175 q9 7154514051185118 q10 6894241119821982 q11 490 288 265 265 q12 346 365 225 225 q13 17753 372331103110 q14 227 229 216 216 q15 561 489 495 489 q16 446 457 370 370 q17 602 888 371 371 q18 7689728172527252 q19 1221957 563 563 q20 351 348 231 231 q21 3833314923382338 q22 10741039969 969 Total cold run time: 106616 ms Total hot run time: 34371 ms - Round 2, with runtime_filter_mode=off - q1 5218518951705170 q2 240 325 231 231 q3 2190268622952295 q4 1387179013261326 q5 4422472446084608 q6 218 173 132 132 q7 2053200318411841 q8 2732262827042628 q9 7441726672357235 q10 3271338428812881 q11 586 508 494 494 q12 716 865 667 667 q13 3649411133613361 q14 281 315 289 289 q15 542 495 489 489 q16 457 498 461 461 q17 1203161713851385 q18 8055771975157515 q19 849 879 936 879 q20 2068209118821882 q21 4922434144344341 q22 10881042988 988 Total cold run time: 53588 ms Total hot run time: 51098 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
hello-stephen commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3103636224 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/444766e96dfed4795b9a642daf32804d606b9604_444766e96dfed4795b9a642daf32804d606b9604_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/444766e96dfed4795b9a642daf32804d606b9604_444766e96dfed4795b9a642daf32804d606b9604_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 80.42% (1302/1619) | | Line Coverage | 65.77% (21797/33140) | | Region Coverage | 67.09% (10954/16328) | | Branch Coverage | 56.60% (5760/10176) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
zhiqiang- commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3103606119 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
hello-stephen commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3102641930 # FE UT Coverage Report Increment line coverage ` 59.27% (227/383)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/52701_48969c4f6202a03ef83e755b8d6dbe35ad14562d/fe_increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/52701_48969c4f6202a03ef83e755b8d6dbe35ad14562d/fe_report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
hello-stephen commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3102454150 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/48969c4f6202a03ef83e755b8d6dbe35ad14562d_48969c4f6202a03ef83e755b8d6dbe35ad14562d_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/48969c4f6202a03ef83e755b8d6dbe35ad14562d_48969c4f6202a03ef83e755b8d6dbe35ad14562d_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 80.42% (1302/1619) | | Line Coverage | 65.76% (21792/33140) | | Region Coverage | 67.03% (10944/16328) | | Branch Coverage | 56.61% (5761/10176) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
zhiqiang- commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3102394150 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3102155428 ClickBench: Total hot run time: 32.59 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit b3ba53e8ecdf753dcebcfdf4146066dea1e93b8f, data reload: false query1 0.050.040.04 query2 0.080.040.05 query3 0.250.080.07 query4 1.620.110.11 query5 0.440.400.42 query6 1.190.660.67 query7 0.030.020.02 query8 0.050.040.04 query9 0.600.540.51 query10 0.580.580.57 query11 0.150.110.10 query12 0.160.110.11 query13 0.630.640.61 query14 0.800.830.84 query15 0.900.870.86 query16 0.380.380.40 query17 1.061.061.07 query18 0.200.200.20 query19 1.931.921.92 query20 0.010.010.02 query21 15.39 0.920.56 query22 0.801.260.72 query23 14.78 1.390.62 query24 6.571.100.63 query25 0.460.100.10 query26 0.700.170.13 query27 0.060.060.06 query28 9.590.920.42 query29 12.57 4.023.33 query30 3.083.023.00 query31 2.810.560.38 query32 3.230.540.47 query33 3.213.173.06 query34 16.07 5.454.85 query35 4.844.904.90 query36 0.680.520.49 query37 0.090.070.06 query38 0.040.040.04 query39 0.030.030.02 query40 0.160.150.14 query41 0.080.020.03 query42 0.040.020.03 query43 0.040.040.03 Total cold run time: 106.43 s Total hot run time: 32.59 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3102133108 TPC-DS: Total hot run time: 186945 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit b3ba53e8ecdf753dcebcfdf4146066dea1e93b8f, data reload: false query1 996 378 420 378 query2 6523176517881765 query3 6749225 216 216 query4 26544 23174 22915 22915 query5 4372610 486 486 query6 313 221 216 216 query7 4634508 297 297 query8 272 228 213 213 query9 8605282428112811 query10 467 327 298 298 query11 16002 15164 14753 14753 query12 156 109 125 109 query13 1638505 393 393 query14 8790596959765969 query15 208 197 174 174 query16 7149654 457 457 query17 958 727 593 593 query18 2002412 321 321 query19 196 191 170 170 query20 134 122 117 117 query21 216 121 109 109 query22 4118418139743974 query23 34055 33156 33016 33016 query24 8110236923642364 query25 535 472 397 397 query26 1265262 160 160 query27 2748498 344 344 query28 4321216521422142 query29 788 577 440 440 query30 284 221 193 193 query31 911 821 748 748 query32 81 85 71 71 query33 545 370 345 345 query34 787 833 502 502 query35 820 835 751 751 query36 994 1002920 920 query37 124 111 84 84 query38 4262412841054105 query39 1509142714031403 query40 232 128 115 115 query41 60 59 54 54 query42 119 106 110 106 query43 499 537 487 487 query44 1333845 838 838 query45 204 172 168 168 query46 849 1005626 626 query47 1802180817421742 query48 382 414 304 304 query49 702 496 384 384 query50 641 660 413 413 query51 5432547355085473 query52 115 108 101 101 query53 222 270 195 195 query54 596 603 521 521 query55 94 86 85 85 query56 317 323 333 323 query57 1195120711271127 query58 274 273 273 273 query59 2685269626442644 query60 346 338 323 323 query61 130 127 127 127 query62 795 716 675 675 query63 228 190 183 183 query64 43191004689 689 query65 4302419242014192 query66 1167429 316 316 query67 15998 15481 15635 15481 query68 7788893 544 544 query69 482 346 289 289 query70 1195109310491049 query71 403 348 315 315 query72 5807478049004780 query73 664 617 351 351 query74 9136915087178717 query75 3480307626302630 query76 33231145761 761 query77 804 398 323 323 query78 10029 10103 92879287 query79 2446831 581 581 query80 606 557 521 521 query81 487 255 217 217 query82 464 140 105 105 query83 248 257 248 248 query84 298 106 93 93 query85 779 364 325 325 query86 388 332 289 289 query87 4373440543164316 query88 3682226322342234 query89 384 322 291 291 query90 1894230 220 220 query91 140 144 109 109 query92 94 72 67 67 query93 1903953 600 600 query94 715 396 297 297 query95 394 320 311 311 query96 492 578 278 278 query97 2672277326382638 query98 242 218 203 203 query99 1646142912721272 Total cold run time: 275677 ms Total hot run time: 186945 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3102073119 TPC-H: Total hot run time: 34057 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit b3ba53e8ecdf753dcebcfdf4146066dea1e93b8f, data reload: false -- Round 1 -- q1 17611 526050695069 q2 1968288 184 184 q3 10289 1269726 726 q4 10201 992 535 535 q5 7526248423182318 q6 177 160 129 129 q7 893 743 606 606 q8 9295131110731073 q9 7392510451455104 q10 6880237319641964 q11 492 303 268 268 q12 337 359 222 222 q13 17757 374831193119 q14 236 231 229 229 q15 550 491 482 482 q16 417 440 397 397 q17 587 877 353 353 q18 7699720271807180 q19 1211938 570 570 q20 341 348 220 220 q21 3761317623402340 q22 10711018969 969 Total cold run time: 106691 ms Total hot run time: 34057 ms - Round 2, with runtime_filter_mode=off - q1 5383514351555143 q2 245 332 232 232 q3 2191266723362336 q4 1327178413471347 q5 4311459146294591 q6 211 167 125 125 q7 2049194218821882 q8 2661250226232502 q9 7508710372877103 q10 3081332028882888 q11 594 495 519 495 q12 677 813 645 645 q13 3601413335623562 q14 298 309 271 271 q15 513 510 522 510 q16 492 509 447 447 q17 1244157514231423 q18 7912785776657665 q19 817 789 894 789 q20 2010208519161916 q21 4734450943474347 q22 10771081969 969 Total cold run time: 52936 ms Total hot run time: 51188 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3101815882 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/b3ba53e8ecdf753dcebcfdf4146066dea1e93b8f_b3ba53e8ecdf753dcebcfdf4146066dea1e93b8f_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/b3ba53e8ecdf753dcebcfdf4146066dea1e93b8f_b3ba53e8ecdf753dcebcfdf4146066dea1e93b8f_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 80.42% (1302/1619) | | Line Coverage | 65.80% (21807/33140) | | Region Coverage | 67.13% (10961/16328) | | Branch Coverage | 56.67% (5767/10176) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
zhiqiang- commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3101712899 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3100687568 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/326e93bd9e2a6cb1f56b0362191ebd1296b0c4c2_326e93bd9e2a6cb1f56b0362191ebd1296b0c4c2_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/326e93bd9e2a6cb1f56b0362191ebd1296b0c4c2_326e93bd9e2a6cb1f56b0362191ebd1296b0c4c2_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 80.42% (1302/1619) | | Line Coverage | 65.77% (21797/33140) | | Region Coverage | 67.10% (10956/16328) | | Branch Coverage | 56.62% (5762/10176) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
zhiqiang- commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3100646594 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
hello-stephen commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3097019249 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/db9396a34ed6da0c6e5d48bdf294cdf2b1584950_db9396a34ed6da0c6e5d48bdf294cdf2b1584950_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/db9396a34ed6da0c6e5d48bdf294cdf2b1584950_db9396a34ed6da0c6e5d48bdf294cdf2b1584950_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 80.36% (1297/1614) | | Line Coverage | 65.75% (21723/33038) | | Region Coverage | 67.11% (10925/16280) | | Branch Coverage | 56.59% (5742/10146) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
zhiqiang- commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3096934276 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3096834131 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/f15f87f3c59713c6de83974e3a5172716344f143_f15f87f3c59713c6de83974e3a5172716344f143_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/f15f87f3c59713c6de83974e3a5172716344f143_f15f87f3c59713c6de83974e3a5172716344f143_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 80.36% (1297/1614) | | Line Coverage | 65.73% (21717/33038) | | Region Coverage | 67.09% (10922/16280) | | Branch Coverage | 56.60% (5743/10146) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
zhiqiang- commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3096781535 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
zhiqiang- commented on code in PR #52701:
URL: https://github.com/apache/doris/pull/52701#discussion_r2218197106
##
be/src/vec/exprs/virtual_slot_ref.cpp:
##
@@ -0,0 +1,208 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "vec/exprs/virtual_slot_ref.h"
+
+#include
+#include
+#include
+
+#include
+
+#include "common/exception.h"
+#include "common/logging.h"
+#include "common/status.h"
+#include "runtime/descriptors.h"
+#include "runtime/runtime_state.h"
+#include "vec/columns/column.h"
+#include "vec/columns/column_nothing.h"
+#include "vec/core/block.h"
+#include "vec/core/column_with_type_and_name.h"
+#include "vec/exprs/vectorized_fn_call.h"
+#include "vec/exprs/vexpr_context.h"
+#include "vec/exprs/vexpr_fwd.h"
+
+namespace doris::vectorized {
+
+VirtualSlotRef::VirtualSlotRef(const doris::TExprNode& node)
+: VExpr(node),
+ _column_id(-1),
+ _slot_id(node.slot_ref.slot_id),
+ _column_name(nullptr),
+ _column_label(node.label) {}
+
+VirtualSlotRef::VirtualSlotRef(const SlotDescriptor* desc)
+: VExpr(desc->type(), false), _column_id(-1), _slot_id(desc->id()),
_column_name(nullptr) {}
+
+Status VirtualSlotRef::prepare(doris::RuntimeState* state, const
doris::RowDescriptor& desc,
+ VExprContext* context) {
+RETURN_IF_ERROR_OR_PREPARED(VExpr::prepare(state, desc, context));
+DCHECK_EQ(_children.size(), 0);
+if (_slot_id == -1) {
+_prepare_finished = true;
+return Status::OK();
+}
+
+const SlotDescriptor* slot_desc =
state->desc_tbl().get_slot_descriptor(_slot_id);
+if (slot_desc == nullptr) {
+return Status::Error(
+"couldn't resolve slot descriptor {}, desc: {}", _slot_id,
+state->desc_tbl().debug_string());
+}
+
+if (slot_desc->get_virtual_column_expr() == nullptr) {
+return Status::InternalError(
+"VirtualSlotRef {} has no virtual column expr, slot_id: {},
desc: {}, "
+"slot_desc: {}, desc_tbl: {}",
+*_column_name, _slot_id, desc.debug_string(),
slot_desc->debug_string(),
+state->desc_tbl().debug_string());
+}
+
+_column_name = &slot_desc->col_name();
+_column_data_type = slot_desc->get_data_type_ptr();
+DCHECK(_column_data_type != nullptr);
+if (!context->force_materialize_slot() && !slot_desc->is_materialized()) {
+// slot should be ignored manually
+_column_id = -1;
+_prepare_finished = true;
+return Status::OK();
+}
+
+_column_id = desc.get_column_id(_slot_id,
context->force_materialize_slot());
+if (_column_id < 0) {
+return Status::Error(
+"VirtualSlotRef {} has invalid slot id: "
+"{}.\nslot_desc:\n{},\ndesc:\n{},\ndesc_tbl:\n{}",
+*_column_name, _slot_id, slot_desc->debug_string(),
desc.debug_string(),
+state->desc_tbl().debug_string());
+}
+const TExpr& expr = *slot_desc->get_virtual_column_expr();
+// LOG_INFO("Virtual column expr is {}",
apache::thrift::ThriftDebugString(expr));
+// Create a temp_ctx only for create_expr_tree.
+VExprContextSPtr temp_ctx;
+RETURN_IF_ERROR(VExpr::create_expr_tree(expr, temp_ctx));
+_virtual_column_expr = temp_ctx->root();
+// Virtual column expr should do prepare with original context.
+RETURN_IF_ERROR(_virtual_column_expr->prepare(state, desc, context));
+_prepare_finished = true;
+return Status::OK();
+}
+
+Status VirtualSlotRef::open(RuntimeState* state, VExprContext* context,
+FunctionContext::FunctionStateScope scope) {
+DCHECK(_prepare_finished);
+RETURN_IF_ERROR(_virtual_column_expr->open(state, context, scope));
+RETURN_IF_ERROR(VExpr::open(state, context, scope));
+_open_finished = true;
+return Status::OK();
+}
+
+Status VirtualSlotRef::execute(VExprContext* context, Block* block, int*
result_column_id) {
+if (_column_id >= 0 && _column_id >= block->columns()) {
+return Status::Error(
+"input block not contain slot column {}, column_id={},
block={}", *_column_
Re: [PR] [feat] Virtual Slot Ref [doris]
zhiqiang- commented on code in PR #52701:
URL: https://github.com/apache/doris/pull/52701#discussion_r2218195214
##
be/src/vec/exprs/virtual_slot_ref.cpp:
##
@@ -0,0 +1,208 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "vec/exprs/virtual_slot_ref.h"
+
+#include
+#include
+#include
+
+#include
+
+#include "common/exception.h"
+#include "common/logging.h"
+#include "common/status.h"
+#include "runtime/descriptors.h"
+#include "runtime/runtime_state.h"
+#include "vec/columns/column.h"
+#include "vec/columns/column_nothing.h"
+#include "vec/core/block.h"
+#include "vec/core/column_with_type_and_name.h"
+#include "vec/exprs/vectorized_fn_call.h"
+#include "vec/exprs/vexpr_context.h"
+#include "vec/exprs/vexpr_fwd.h"
+
+namespace doris::vectorized {
+
+VirtualSlotRef::VirtualSlotRef(const doris::TExprNode& node)
+: VExpr(node),
+ _column_id(-1),
+ _slot_id(node.slot_ref.slot_id),
+ _column_name(nullptr),
+ _column_label(node.label) {}
+
+VirtualSlotRef::VirtualSlotRef(const SlotDescriptor* desc)
+: VExpr(desc->type(), false), _column_id(-1), _slot_id(desc->id()),
_column_name(nullptr) {}
+
+Status VirtualSlotRef::prepare(doris::RuntimeState* state, const
doris::RowDescriptor& desc,
+ VExprContext* context) {
+RETURN_IF_ERROR_OR_PREPARED(VExpr::prepare(state, desc, context));
+DCHECK_EQ(_children.size(), 0);
+if (_slot_id == -1) {
+_prepare_finished = true;
+return Status::OK();
+}
+
+const SlotDescriptor* slot_desc =
state->desc_tbl().get_slot_descriptor(_slot_id);
+if (slot_desc == nullptr) {
+return Status::Error(
+"couldn't resolve slot descriptor {}, desc: {}", _slot_id,
+state->desc_tbl().debug_string());
+}
+
+if (slot_desc->get_virtual_column_expr() == nullptr) {
+return Status::InternalError(
+"VirtualSlotRef {} has no virtual column expr, slot_id: {},
desc: {}, "
+"slot_desc: {}, desc_tbl: {}",
+*_column_name, _slot_id, desc.debug_string(),
slot_desc->debug_string(),
+state->desc_tbl().debug_string());
+}
+
+_column_name = &slot_desc->col_name();
+_column_data_type = slot_desc->get_data_type_ptr();
+DCHECK(_column_data_type != nullptr);
+if (!context->force_materialize_slot() && !slot_desc->is_materialized()) {
+// slot should be ignored manually
+_column_id = -1;
+_prepare_finished = true;
+return Status::OK();
+}
+
+_column_id = desc.get_column_id(_slot_id,
context->force_materialize_slot());
+if (_column_id < 0) {
+return Status::Error(
+"VirtualSlotRef {} has invalid slot id: "
+"{}.\nslot_desc:\n{},\ndesc:\n{},\ndesc_tbl:\n{}",
+*_column_name, _slot_id, slot_desc->debug_string(),
desc.debug_string(),
+state->desc_tbl().debug_string());
+}
+const TExpr& expr = *slot_desc->get_virtual_column_expr();
+// LOG_INFO("Virtual column expr is {}",
apache::thrift::ThriftDebugString(expr));
+// Create a temp_ctx only for create_expr_tree.
+VExprContextSPtr temp_ctx;
+RETURN_IF_ERROR(VExpr::create_expr_tree(expr, temp_ctx));
+_virtual_column_expr = temp_ctx->root();
+// Virtual column expr should do prepare with original context.
+RETURN_IF_ERROR(_virtual_column_expr->prepare(state, desc, context));
+_prepare_finished = true;
+return Status::OK();
+}
+
+Status VirtualSlotRef::open(RuntimeState* state, VExprContext* context,
+FunctionContext::FunctionStateScope scope) {
+DCHECK(_prepare_finished);
+RETURN_IF_ERROR(_virtual_column_expr->open(state, context, scope));
+RETURN_IF_ERROR(VExpr::open(state, context, scope));
+_open_finished = true;
+return Status::OK();
+}
+
+Status VirtualSlotRef::execute(VExprContext* context, Block* block, int*
result_column_id) {
+if (_column_id >= 0 && _column_id >= block->columns()) {
Review Comment:
> vslot没有children吗？那如果expr顺序被打乱了是否可能会有问题
没有child。`expr顺序打乱`是什么？
--
This is an automat
Re: [PR] [feat] Virtual Slot Ref [doris]
BiteThet commented on code in PR #52701:
URL: https://github.com/apache/doris/pull/52701#discussion_r2218121033
##
be/src/runtime/descriptors.cpp:
##
@@ -61,7 +64,31 @@ SlotDescriptor::SlotDescriptor(const TSlotDescriptor& tdesc)
_is_key(tdesc.is_key),
_column_paths(tdesc.column_paths),
_is_auto_increment(tdesc.__isset.is_auto_increment ?
tdesc.is_auto_increment : false),
- _col_default_value(tdesc.__isset.col_default_value ?
tdesc.col_default_value : "") {}
+ _col_default_value(tdesc.__isset.col_default_value ?
tdesc.col_default_value : "") {
+if (tdesc.__isset.virtual_column_expr) {
+// Make sure virtual column is valid.
+if (tdesc.virtual_column_expr.nodes.empty()) {
+LOG_ERROR("Virtual column expr node is empty, col_name={},
col_unique_id={}",
+ tdesc.colName, tdesc.col_unique_id);
+
+throw doris::Exception(doris::ErrorCode::FATAL_ERROR,
+ "Virtual column expr node is empty,
col_name: {}, "
+ "col_unique_id: {}",
+ tdesc.colName, tdesc.col_unique_id);
+}
+const auto& node = tdesc.virtual_column_expr.nodes[0];
+if (node.node_type == TExprNodeType::SLOT_REF) {
+LOG_ERROR(
+"Virtual column expr node is slot ref, col_name={},
col_unique_id={}, expr: {}",
Review Comment:
ditto
##
be/src/pipeline/exec/scan_operator.h:
##
@@ -180,7 +182,12 @@ class ScanLocalState : public ScanLocalStateBase {
continue;
}
if (_push_down_topn(pred) == push_down) {
+LOG_INFO("push down topn filter, source node id: {}, target
node id: {}", id,
Review Comment:
use vlog or something else
##
be/src/runtime/descriptors.cpp:
##
@@ -61,7 +64,31 @@ SlotDescriptor::SlotDescriptor(const TSlotDescriptor& tdesc)
_is_key(tdesc.is_key),
_column_paths(tdesc.column_paths),
_is_auto_increment(tdesc.__isset.is_auto_increment ?
tdesc.is_auto_increment : false),
- _col_default_value(tdesc.__isset.col_default_value ?
tdesc.col_default_value : "") {}
+ _col_default_value(tdesc.__isset.col_default_value ?
tdesc.col_default_value : "") {
+if (tdesc.__isset.virtual_column_expr) {
+// Make sure virtual column is valid.
+if (tdesc.virtual_column_expr.nodes.empty()) {
+LOG_ERROR("Virtual column expr node is empty, col_name={},
col_unique_id={}",
Review Comment:
seems duplicated with exception
##
be/src/vec/exec/scan/olap_scanner.cpp:
##
@@ -457,6 +471,16 @@ Status OlapScanner::_init_variant_columns() {
}
Status OlapScanner::_init_return_columns() {
+#ifndef NDEBUG
+std::vector debug_strings;
+for (const auto* slot : _output_tuple_desc->slots()) {
+debug_strings.push_back(slot->debug_string());
Review Comment:
we should not type too many logs even in debug mode
##
be/src/vec/exprs/virtual_slot_ref.cpp:
##
@@ -0,0 +1,208 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "vec/exprs/virtual_slot_ref.h"
+
+#include
+#include
+#include
+
+#include
+
+#include "common/exception.h"
+#include "common/logging.h"
+#include "common/status.h"
+#include "runtime/descriptors.h"
+#include "runtime/runtime_state.h"
+#include "vec/columns/column.h"
+#include "vec/columns/column_nothing.h"
+#include "vec/core/block.h"
+#include "vec/core/column_with_type_and_name.h"
+#include "vec/exprs/vectorized_fn_call.h"
+#include "vec/exprs/vexpr_context.h"
+#include "vec/exprs/vexpr_fwd.h"
+
+namespace doris::vectorized {
+
+VirtualSlotRef::VirtualSlotRef(const doris::TExprNode& node)
+: VExpr(node),
+ _column_id(-1),
+ _slot_id(node.slot_ref.slot_id),
+ _column_name(nullptr),
+ _column_label(node.label) {}
+
+VirtualSlotRef::VirtualSlotRef(const SlotDescriptor* desc)
+: VExpr(desc->type(), false), _column_id(-1), _slot_id(desc->id()),
_column_name(nullptr) {}
+
+Status VirtualSlotRef::prepare(doris::RuntimeSta
Re: [PR] [feat] Virtual Slot Ref [doris]
hello-stephen commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3094635369 # BE UT Coverage Report Increment line coverage `30.43% (206/677)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/e4e8e7a5559eafddccc960e22758f2f82b7cc6c1_e4e8e7a5559eafddccc960e22758f2f82b7cc6c1/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/e4e8e7a5559eafddccc960e22758f2f82b7cc6c1_e4e8e7a5559eafddccc960e22758f2f82b7cc6c1/report/index.html) | Category | Coverage | |---|| | Function Coverage | 57.40% (15775/27483) | | Line Coverage | 46.14% (141930/307622) | | Region Coverage | 35.61% (106980/300445) | | Branch Coverage | 38.13% (47229/123862) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3094529056 ClickBench: Total hot run time: 33.67 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit e4e8e7a5559eafddccc960e22758f2f82b7cc6c1, data reload: false query1 0.040.030.04 query2 0.110.060.05 query3 0.300.070.07 query4 1.600.090.11 query5 0.440.410.41 query6 1.150.660.67 query7 0.030.020.01 query8 0.060.060.06 query9 0.640.540.53 query10 0.590.590.59 query11 0.280.140.14 query12 0.260.140.14 query13 0.640.630.64 query14 0.800.850.83 query15 0.980.900.89 query16 0.400.380.39 query17 1.111.081.13 query18 0.260.230.24 query19 2.051.842.04 query20 0.020.010.02 query21 15.35 0.970.67 query22 0.941.050.80 query23 14.71 1.560.77 query24 5.210.610.30 query25 0.180.100.09 query26 0.580.240.20 query27 0.100.090.09 query28 11.04 1.220.62 query29 12.54 4.133.49 query30 3.293.153.09 query31 2.820.620.44 query32 3.250.610.52 query33 3.213.143.08 query34 16.87 5.514.75 query35 4.864.874.79 query36 0.660.520.52 query37 0.220.190.18 query38 0.180.170.17 query39 0.060.060.06 query40 0.230.180.19 query41 0.120.080.06 query42 0.080.070.07 query43 0.070.060.07 Total cold run time: 108.33 s Total hot run time: 33.67 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3094526339 TPC-DS: Total hot run time: 191999 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit e4e8e7a5559eafddccc960e22758f2f82b7cc6c1, data reload: false query1 1025394 416 394 query2 6544180518081805 query3 6748238 231 231 query4 26864 23879 23659 23659 query5 4506728 574 574 query6 346 248 226 226 query7 4655530 309 309 query8 390 341 296 296 query9 8658263426612634 query10 512 363 307 307 query11 15826 15153 14953 14953 query12 163 125 120 120 query13 1685549 423 423 query14 9279613261276127 query15 236 225 188 188 query16 7238678 521 521 query17 1249780 640 640 query18 2044466 347 347 query19 224 217 184 184 query20 147 141 196 141 query21 235 147 127 127 query22 4276425340704070 query23 34914 33460 33451 33451 query24 8459248824412441 query25 557 497 426 426 query26 1106279 162 162 query27 2750531 358 358 query28 4409217821542154 query29 764 582 459 459 query30 309 238 211 211 query31 978 840 805 805 query32 91 88 83 83 query33 601 412 362 362 query34 837 860 526 526 query35 834 849 782 782 query36 997 1005941 941 query37 132 116 96 96 query38 4178411540954095 query39 1535147414791474 query40 240 150 133 133 query41 111 110 104 104 query42 135 133 126 126 query43 514 540 491 491 query44 1352870 871 870 query45 198 194 186 186 query46 854 1034655 655 query47 1815188117821782 query48 404 465 338 338 query49 819 592 476 476 query50 692 718 441 441 query51 5578550554615461 query52 126 127 115 115 query53 254 280 248 248 query54 641 643 565 565 query55 102 101 125 101 query56 340 356 323 323 query57 1236123011551155 query58 328 322 350 322 query59 2624267825752575 query60 374 379 355 355 query61 169 149 152 149 query62 846 733 694 694 query63 246 215 218 215 query64 39291107743 743 query65 4331429342354235 query66 1274663 538 538 query67 16011 15836 15801 15801 query68 8028920 564 564 query69 533 339 305 305 query70 1268116611681166 query71 486 356 336 336 query72 5889489349854893 query73 787 713 352 352 query74 9192940688398839 query75 3898327527882788 query76 36461179764 764 query77 929 458 368 368 query78 10148 10238 93269326 query79 2234867 622 622 query80 666 644 528 528 query81 504 282 241 241 query82 433 150 111 111 query83 326 292 282 282 query84 301 130 97 97 query85 832 416 372 372 query86 369 338 330 330 query87 4503450844354435 query88 3299240823772377 query89 415 338 309 309 query90 1982239 241 239 query91 170 161 133 133 query92 98 88 82 82 query93 1683954 614 614 query94 715 442 332 332 query95 419 337 322 322 query96 505 579 291 291 query97 2728277827012701 query98 254 231 260 231 query99 1488145213501350 Total cold run time: 280572 ms Total hot run time: 191999 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3094520389 TPC-H: Total hot run time: 34709 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit e4e8e7a5559eafddccc960e22758f2f82b7cc6c1, data reload: false -- Round 1 -- q1 17661 530351805180 q2 1954302 211 211 q3 10345 1339736 736 q4 10278 1033517 517 q5 7797241124282411 q6 197 190 142 142 q7 941 804 633 633 q8 9323138511051105 q9 7177517352715173 q10 6901242920042004 q11 492 312 275 275 q12 352 362 226 226 q13 17789 375631423142 q14 242 247 236 236 q15 615 537 533 533 q16 442 454 402 402 q17 649 878 394 394 q18 7759709772717097 q19 1307992 619 619 q20 364 367 251 251 q21 4087322924212421 q22 1059106510011001 Total cold run time: 107731 ms Total hot run time: 34709 ms - Round 2, with runtime_filter_mode=off - q1 5466513851475138 q2 271 349 245 245 q3 2230269223382338 q4 1364179113511351 q5 4585447445274474 q6 223 177 131 131 q7 2031191618031803 q8 2732248326792483 q9 7246734873177317 q10 3154340628872887 q11 602 526 497 497 q12 700 796 623 623 q13 3676405333393339 q14 300 304 324 304 q15 569 523 509 509 q16 470 511 482 482 q17 1200155814031403 q18 8049786675597559 q19 832 936 1145936 q20 2137207419291929 q21 5207469845184518 q22 1090104510261026 Total cold run time: 54134 ms Total hot run time: 51292 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3094470831 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/e4e8e7a5559eafddccc960e22758f2f82b7cc6c1_e4e8e7a5559eafddccc960e22758f2f82b7cc6c1_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/e4e8e7a5559eafddccc960e22758f2f82b7cc6c1_e4e8e7a5559eafddccc960e22758f2f82b7cc6c1_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 80.36% (1297/1614) | | Line Coverage | 65.74% (21716/33035) | | Region Coverage | 67.04% (10912/16276) | | Branch Coverage | 56.63% (5743/10142) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
zhiqiang- commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3094460638 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
hello-stephen commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3084545389 # BE Regression && UT Coverage Report Increment line coverage `76.24% (536/703)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/52701_6080bc48732c2e64934d89bab83d209b9ade0ab3_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/52701_6080bc48732c2e64934d89bab83d209b9ade0ab3_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 81.13% (21885/26976) | | Line Coverage | 73.71% (226589/307386) | | Region Coverage | 61.63% (189902/308110) | | Branch Coverage | 65.20% (81600/125152) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
zhiqiang- commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3084024788 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3083694556 # BE UT Coverage Report Increment line coverage `31.70% (227/716)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/6080bc48732c2e64934d89bab83d209b9ade0ab3_6080bc48732c2e64934d89bab83d209b9ade0ab3/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/6080bc48732c2e64934d89bab83d209b9ade0ab3_6080bc48732c2e64934d89bab83d209b9ade0ab3/report/index.html) | Category | Coverage | |---|| | Function Coverage | 57.38% (15782/27503) | | Line Coverage | 46.15% (142089/307866) | | Region Coverage | 35.65% (107087/300386) | | Branch Coverage | 38.16% (47226/123762) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
zhiqiang- commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3083609930 run external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3083188088 ClickBench: Total hot run time: 33.05 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 6080bc48732c2e64934d89bab83d209b9ade0ab3, data reload: false query1 0.030.030.04 query2 0.110.060.06 query3 0.300.060.07 query4 1.600.090.07 query5 0.430.410.42 query6 1.160.650.66 query7 0.030.020.02 query8 0.070.060.05 query9 0.650.520.52 query10 0.580.590.57 query11 0.250.130.13 query12 0.250.140.13 query13 0.640.630.63 query14 0.830.810.84 query15 0.970.900.89 query16 0.380.380.38 query17 1.101.101.06 query18 0.260.230.24 query19 1.961.871.92 query20 0.020.010.02 query21 15.35 0.960.66 query22 0.921.060.78 query23 14.73 1.620.76 query24 4.860.630.32 query25 0.170.100.09 query26 0.560.220.19 query27 0.090.090.08 query28 11.05 1.190.58 query29 12.52 4.053.37 query30 3.092.982.92 query31 2.810.610.44 query32 3.240.600.51 query33 3.143.153.12 query34 16.71 5.454.74 query35 4.754.774.72 query36 0.640.520.50 query37 0.200.190.17 query38 0.170.160.15 query39 0.060.040.04 query40 0.200.170.17 query41 0.100.060.06 query42 0.060.050.05 query43 0.060.060.05 Total cold run time: 107.1 s Total hot run time: 33.05 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3083166047 TPC-DS: Total hot run time: 187536 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 6080bc48732c2e64934d89bab83d209b9ade0ab3, data reload: false query1 1002389 445 389 query2 6499173416631663 query3 6736213 216 213 query4 26065 23594 23562 23562 query5 4494578 469 469 query6 321 218 200 200 query7 4622501 292 292 query8 282 239 217 217 query9 8658261226272612 query10 483 322 296 296 query11 15768 14979 14808 14808 query12 170 113 107 107 query13 1650518 406 406 query14 9632588958965889 query15 289 203 168 168 query16 7599623 477 477 query17 1158736 581 581 query18 2017407 288 288 query19 194 192 162 162 query20 126 114 113 113 query21 217 128 109 109 query22 4235439143004300 query23 34285 33187 33000 33000 query24 8445237123572357 query25 526 458 393 393 query26 1239266 152 152 query27 2763499 340 340 query28 4300213821082108 query29 722 566 426 426 query30 286 217 186 186 query31 932 863 756 756 query32 76 69 76 69 query33 569 375 327 327 query34 784 832 511 511 query35 812 835 741 741 query36 10021010918 918 query37 111 135 84 84 query38 4206410741824107 query39 1506145414201420 query40 215 117 109 109 query41 70 66 55 55 query42 124 116 110 110 query43 502 530 496 496 query44 1298811 841 811 query45 177 171 169 169 query46 855 1030631 631 query47 1796181517731773 query48 378 429 307 307 query49 723 473 392 392 query50 637 685 409 409 query51 5561569354975497 query52 111 104 101 101 query53 225 245 186 186 query54 573 567 508 508 query55 88 81 86 81 query56 303 292 291 291 query57 1206120511361136 query58 287 275 298 275 query59 2690270325872587 query60 327 325 317 317 query61 132 124 126 124 query62 785 723 687 687 query63 218 190 184 184 query64 42511021653 653 query65 4286419342204193 query66 1078412 320 320 query67 15946 15663 15465 15465 query68 7823875 519 519 query69 471 314 299 299 query70 1263114212161142 query71 409 318 310 310 query72 5482467748754677 query73 647 571 330 330 query74 9133881888658818 query75 3232317527512751 query76 32881190741 741 query77 517 378 313 313 query78 994910126 94099409 query79 2259804 601 601 query80 579 518 431 431 query81 500 260 221 221 query82 472 128 101 101 query83 249 246 246 246 query84 243 97 90 90 query85 806 352 321 321 query86 373 313 323 313 query87 4462453443104310 query88 3652227722482248 query89 400 329 291 291 query90 1936204 204 204 query91 140 180 113 113 query92 81 67 66 66 query93 1854937 575 575 query94 670 411 310 310 query95 380 294 298 294 query96 490 571 281 281 query97 2681274826732673 query98 249 214 207 207 query99 1370143012481248 Total cold run time: 275683 ms Total hot run time: 187536 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3083127450 TPC-H: Total hot run time: 34027 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 6080bc48732c2e64934d89bab83d209b9ade0ab3, data reload: false -- Round 1 -- q1 17648 523151245124 q2 1950283 180 180 q3 10571 1302721 721 q4 10238 1011523 523 q5 8002234624022346 q6 182 160 129 129 q7 885 744 601 601 q8 9325134310521052 q9 6986526851175117 q10 6901238619851985 q11 477 291 278 278 q12 333 348 221 221 q13 17763 369931043104 q14 230 231 230 230 q15 560 481 475 475 q16 429 417 367 367 q17 610 864 375 375 q18 7534719771037103 q19 1142950 552 552 q20 359 342 234 234 q21 4093256023592359 q22 10171002951 951 Total cold run time: 107235 ms Total hot run time: 34027 ms - Round 2, with runtime_filter_mode=off - q1 5201516151365136 q2 239 350 212 212 q3 2150267222572257 q4 1324178913501350 q5 4203460745294529 q6 237 182 131 131 q7 2055194318431843 q8 2630254325072507 q9 7262733272177217 q10 3120336031113111 q11 559 512 485 485 q12 705 821 644 644 q13 3545397133783378 q14 287 317 283 283 q15 557 498 486 486 q16 459 507 448 448 q17 1179163813361336 q18 779576777677 q19 773 801 851 801 q20 1902193218171817 q21 4735430842084208 q22 10311024960 960 Total cold run time: 51930 ms Total hot run time: 50816 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
hello-stephen commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3082949196 # FE UT Coverage Report Increment line coverage ` 48.77% (178/365)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/52701_6080bc48732c2e64934d89bab83d209b9ade0ab3/fe_increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/52701_6080bc48732c2e64934d89bab83d209b9ade0ab3/fe_report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
hello-stephen commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3082797505 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/6080bc48732c2e64934d89bab83d209b9ade0ab3_6080bc48732c2e64934d89bab83d209b9ade0ab3_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/6080bc48732c2e64934d89bab83d209b9ade0ab3_6080bc48732c2e64934d89bab83d209b9ade0ab3_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 80.36% (1297/1614) | | Line Coverage | 65.80% (21707/32991) | | Region Coverage | 67.10% (10902/16247) | | Branch Coverage | 56.67% (5732/10114) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
zhiqiang- commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3082748474 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3073171218 # BE UT Coverage Report Increment line coverage `31.70% (227/716)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/9989cd43eca314b83ad15348acb70658207df716_9989cd43eca314b83ad15348acb70658207df716/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/9989cd43eca314b83ad15348acb70658207df716_9989cd43eca314b83ad15348acb70658207df716/report/index.html) | Category | Coverage | |---|| | Function Coverage | 57.48% (15753/27405) | | Line Coverage | 46.12% (140563/304749) | | Region Coverage | 35.38% (104835/296277) | | Branch Coverage | 38.01% (46192/121523) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3073161292 ClickBench: Total hot run time: 33.37 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 9989cd43eca314b83ad15348acb70658207df716, data reload: false query1 0.040.040.03 query2 0.110.060.05 query3 0.280.070.06 query4 1.600.080.09 query5 0.430.420.42 query6 1.150.670.67 query7 0.020.020.01 query8 0.060.050.05 query9 0.650.520.52 query10 0.580.580.58 query11 0.260.130.13 query12 0.250.150.14 query13 0.650.630.65 query14 0.810.820.87 query15 0.990.900.90 query16 0.390.380.39 query17 1.121.081.08 query18 0.250.230.24 query19 2.051.891.92 query20 0.020.020.03 query21 15.36 0.970.67 query22 0.921.070.76 query23 14.71 1.530.80 query24 5.480.580.29 query25 0.170.090.09 query26 0.560.230.19 query27 0.100.080.09 query28 11.05 1.200.58 query29 12.56 4.253.44 query30 3.072.993.00 query31 2.840.640.43 query32 3.250.610.51 query33 3.153.143.19 query34 17.24 5.414.74 query35 4.834.814.76 query36 0.660.520.50 query37 0.200.180.18 query38 0.170.160.16 query39 0.060.050.05 query40 0.190.180.17 query41 0.110.050.06 query42 0.060.060.05 query43 0.060.050.05 Total cold run time: 108.51 s Total hot run time: 33.37 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3073147315 TPC-DS: Total hot run time: 188098 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 9989cd43eca314b83ad15348acb70658207df716, data reload: false query1 999 388 409 388 query2 6519163716811637 query3 6741222 216 216 query4 26642 23197 23429 23197 query5 4340589 458 458 query6 318 219 217 217 query7 4635492 295 295 query8 284 229 218 218 query9 8610266426682664 query10 472 356 276 276 query11 15761 15073 14791 14791 query12 155 110 107 107 query13 1662516 403 403 query14 9124615861036103 query15 211 200 167 167 query16 7580444 269 269 query17 1307726 606 606 query18 2023417 318 318 query19 196 213 166 166 query20 123 120 114 114 query21 213 122 109 109 query22 4182419141714171 query23 34228 33192 33272 33192 query24 8420235223462346 query25 531 470 410 410 query26 1256266 151 151 query27 2745496 353 353 query28 4314215521342134 query29 730 558 461 461 query30 286 220 192 192 query31 929 856 776 776 query32 77 75 70 70 query33 585 339 297 297 query34 780 832 498 498 query35 598 638 555 555 query36 986 1006951 951 query37 115 122 88 88 query38 4217414541284128 query39 1515144414281428 query40 217 119 108 108 query41 56 54 54 54 query42 141 116 112 112 query43 528 503 484 484 query44 1355835 829 829 query45 180 172 164 164 query46 839 1020630 630 query47 1783183517321732 query48 373 417 323 323 query49 723 470 388 388 query50 665 702 416 416 query51 5593560153165316 query52 113 106 101 101 query53 224 258 198 198 query54 587 583 510 510 query55 86 87 85 85 query56 332 311 312 311 query57 1220121311681168 query58 292 319 284 284 query59 2566270725992599 query60 336 325 312 312 query61 123 121 122 121 query62 778 723 676 676 query63 226 191 187 187 query64 43551191886 886 query65 4299419041864186 query66 1124420 318 318 query67 16075 15882 15573 15573 query68 8600883 532 532 query69 529 330 289 289 query70 1219119410761076 query71 471 317 315 315 query72 5681473848604738 query73 706 614 340 340 query74 9111912186818681 query75 3858319527222722 query76 36271142710 710 query77 834 368 298 298 query78 11071 11055 10239 10239 query79 1911841 599 599 query80 669 524 453 453 query81 464 258 235 235 query82 418 133 101 101 query83 290 281 236 236 query84 290 111 92 92 query85 776 362 318 318 query86 351 300 300 300 query87 4446453243494349 query88 2922229323332293 query89 387 314 296 296 query90 1919214 211 211 query91 136 143 116 116 query92 84 64 66 64 query93 1089961 603 603 query94 690 317 205 205 query95 392 299 295 295 query96 496 573 279 279 query97 2744278326452645 query98 226 220 207 207 query99 1425135912701270 Total cold run time: 277430 ms Total hot run time: 188098 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3073115810 TPC-H: Total hot run time: 33254 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 9989cd43eca314b83ad15348acb70658207df716, data reload: false -- Round 1 -- q1 17569 525350765076 q2 1918279 217 217 q3 10382 1288719 719 q4 10247 1023522 522 q5 7935244123232323 q6 179 156 128 128 q7 919 755 602 602 q8 9323128710621062 q9 7519508651505086 q10 6917236619791979 q11 497 293 273 273 q12 340 350 213 213 q13 17752 365730613061 q14 236 223 223 223 q15 548 485 480 480 q16 416 435 383 383 q17 595 873 371 371 q18 7819711172237111 q19 1229947 528 528 q20 347 352 234 234 q21 3837324323612361 q22 369 323 302 302 Total cold run time: 106893 ms Total hot run time: 33254 ms - Round 2, with runtime_filter_mode=off - q1 5090515452295154 q2 240 329 221 221 q3 2184268923522352 q4 1335178113431343 q5 4258446844544454 q6 227 179 131 131 q7 2036204218381838 q8 2650266925352535 q9 7312729872577257 q10 3163325828942894 q11 599 530 498 498 q12 694 791 648 648 q13 3638415432973297 q14 267 298 282 282 q15 538 491 472 472 q16 478 501 457 457 q17 1193154713761376 q18 7997776875367536 q19 805 826 964 826 q20 1942199418101810 q21 4674434142034203 q22 671 576 537 537 Total cold run time: 51991 ms Total hot run time: 50121 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3072570368 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/9989cd43eca314b83ad15348acb70658207df716_9989cd43eca314b83ad15348acb70658207df716_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/9989cd43eca314b83ad15348acb70658207df716_9989cd43eca314b83ad15348acb70658207df716_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 79.57% (1270/1596) | | Line Coverage | 65.61% (21457/32704) | | Region Coverage | 66.87% (10789/16134) | | Branch Coverage | 56.55% (5687/10056) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
zhiqiang- commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3072472209 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3072064314 ClickBench: Total hot run time: 33.33 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit ae1592c5f288c088fe0c9f16893c000c39737715, data reload: false query1 0.040.030.03 query2 0.110.060.05 query3 0.290.080.06 query4 1.600.080.08 query5 0.430.420.42 query6 1.150.670.66 query7 0.020.020.02 query8 0.070.050.05 query9 0.640.520.52 query10 0.570.580.58 query11 0.250.130.13 query12 0.260.150.15 query13 0.660.630.63 query14 0.800.820.83 query15 0.980.880.91 query16 0.380.370.38 query17 1.051.051.03 query18 0.250.240.23 query19 2.011.891.93 query20 0.020.020.01 query21 15.38 0.990.68 query22 0.921.050.86 query23 14.68 1.540.76 query24 5.320.570.29 query25 0.160.100.08 query26 0.560.230.19 query27 0.090.090.09 query28 11.01 1.240.59 query29 12.61 4.003.37 query30 3.123.032.98 query31 2.830.620.43 query32 3.240.610.51 query33 3.103.203.16 query34 16.90 5.454.74 query35 4.834.904.78 query36 0.650.530.51 query37 0.190.180.17 query38 0.180.160.16 query39 0.050.040.05 query40 0.200.190.18 query41 0.100.050.06 query42 0.070.050.06 query43 0.060.050.06 Total cold run time: 107.83 s Total hot run time: 33.33 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feat] Virtual Slot Ref [doris]
doris-robot commented on PR #52701: URL: https://github.com/apache/doris/pull/52701#issuecomment-3072053688 TPC-DS: Total hot run time: 188573 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit ae1592c5f288c088fe0c9f16893c000c39737715, data reload: false query1 988 385 393 385 query2 6529169316691669 query3 6737220 235 220 query4 26249 24015 23701 23701 query5 4299598 470 470 query6 319 215 212 212 query7 4648494 290 290 query8 287 227 223 223 query9 8646264226652642 query10 467 367 277 277 query11 15297 14995 14830 14830 query12 151 111 116 111 query13 1677543 420 420 query14 8607616961936169 query15 200 200 183 183 query16 7411445 271 271 query17 1313739 601 601 query18 1988419 331 331 query19 200 196 176 176 query20 124 122 116 116 query21 222 125 108 108 query22 4165416142214161 query23 34368 33380 33063 33063 query24 8474235023862350 query25 541 476 406 406 query26 1239268 151 151 query27 2758502 353 353 query28 4302212821022102 query29 787 555 465 465 query30 287 223 188 188 query31 924 849 745 745 query32 81 68 69 68 query33 552 344 294 294 query34 793 845 519 519 query35 618 633 560 560 query36 992 1010936 936 query37 115 103 88 88 query38 4200406540934065 query39 1496146614341434 query40 211 119 111 111 query41 56 56 51 51 query42 126 113 116 113 query43 516 530 481 481 query44 1318821 829 821 query45 180 169 166 166 query46 859 1023638 638 query47 1762181017411741 query48 374 416 327 327 query49 726 491 392 392 query50 656 698 432 432 query51 5487564553665366 query52 112 108 102 102 query53 250 255 182 182 query54 597 585 511 511 query55 90 83 85 83 query56 303 310 301 301 query57 1191117311191119 query58 311 300 298 298 query59 2622264924752475 query60 328 327 311 311 query61 126 125 119 119 query62 774 730 676 676 query63 227 194 187 187 query64 44131175822 822 query65 4309415941964159 query66 1156415 319 319 query67 15908 15863 15658 15658 query68 8152915 539 539 query69 505 309 285 285 query70 1260115810981098 query71 447 325 360 325 query72 5591458446334584 query73 716 563 336 336 query74 8866938290179017 query75 3778318426692669 query76 36211148723 723 query77 779 374 306 306 query78 11096 11092 10233 10233 query79 1975817 610 610 query80 614 522 444 444 query81 471 256 229 229 query82 427 132 102 102 query83 254 256 227 227 query84 244 102 82 82 query85 801 358 392 358 query86 344 315 279 279 query87 4441443843454345 query88 3409227322522252 query89 378 324 306 306 query90 1921207 209 207 query91 220 142 111 111 query92 80 67 62 62 query93 1180948 604 604 query94 691 320 202 202 query95 386 294 301 294 query96 488 555 282 282 query97 2700277126402640 query98 235 205 208 205 query99 1454138513031303 Total cold run time: 275563 ms Total hot run time: 188573 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
