Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
doris-robot commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2723414288 ClickBench: Total hot run time: 31.07 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit b5432b73fb9b4588b919dc85dc8f74eb1dca2cb7, data reload: false query1 0.030.030.03 query2 0.070.030.03 query3 0.230.070.06 query4 1.610.100.10 query5 0.550.540.55 query6 1.200.720.73 query7 0.040.020.02 query8 0.040.030.03 query9 0.600.530.52 query10 0.580.580.61 query11 0.160.100.11 query12 0.140.110.12 query13 0.610.590.60 query14 2.662.822.70 query15 0.930.860.87 query16 0.390.380.40 query17 1.030.991.02 query18 0.210.200.19 query19 1.901.892.02 query20 0.010.020.02 query21 15.37 0.880.53 query22 0.751.230.75 query23 14.78 1.400.62 query24 6.991.870.88 query25 0.480.400.07 query26 0.500.150.15 query27 0.050.050.06 query28 10.18 0.860.42 query29 12.56 3.983.36 query30 0.260.090.06 query31 2.810.580.39 query32 3.220.540.45 query33 3.003.023.02 query34 15.91 5.154.52 query35 4.584.544.55 query36 0.680.500.50 query37 0.100.070.06 query38 0.050.040.03 query39 0.040.030.02 query40 0.170.140.13 query41 0.100.030.02 query42 0.030.020.02 query43 0.040.030.02 Total cold run time: 105.64 s Total hot run time: 31.07 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
924060929 commented on code in PR #42199:
URL: https://github.com/apache/doris/pull/42199#discussion_r1994634619
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##
@@ -325,8 +343,8 @@ private ImmutableSet
getAvailableExpressions(Set predica
return ImmutableSet.copyOf(newPredicates);
}
-private boolean hasAgg(Expression expression) {
-return expression.anyMatch(AggregateFunction.class::isInstance);
+private boolean supportPullUpAgg(Expression expr) {
Review Comment:
origin logic seems trivial, or not working
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
doris-robot commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2723395254 TPC-DS: Total hot run time: 192050 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit b5432b73fb9b4588b919dc85dc8f74eb1dca2cb7, data reload: false query1 1421100110041001 query2 6427191918691869 query3 11142 457946904579 query4 26051 23921 23157 23157 query5 4716669 468 468 query6 303 210 187 187 query7 3990511 287 287 query8 291 247 236 236 query9 8506260825972597 query10 488 316 259 259 query11 15453 15075 14894 14894 query12 179 115 111 111 query13 1586517 398 398 query14 9692630169396301 query15 220 190 177 177 query16 7650681 512 512 query17 1528810 626 626 query18 2052474 335 335 query19 236 205 163 163 query20 133 128 121 121 query21 217 128 101 101 query22 4429457746444577 query23 34433 33611 33616 33611 query24 7180239824242398 query25 490 464 391 391 query26 838 278 157 157 query27 2379490 327 327 query28 4346244224322432 query29 632 560 418 418 query30 274 219 198 198 query31 924 872 847 847 query32 73 63 61 61 query33 539 369 299 299 query34 806 902 511 511 query35 816 852 779 779 query36 965 1002913 913 query37 114 96 78 78 query38 4248424841084108 query39 1519145414361436 query40 206 116 100 100 query41 51 48 50 48 query42 119 108 109 108 query43 510 512 473 473 query44 1314783 783 783 query45 186 185 170 170 query46 861 1028643 643 query47 1853188518321832 query48 403 420 312 312 query49 717 510 417 417 query50 706 743 413 413 query51 4320435342704270 query52 108 102 98 98 query53 241 268 191 191 query54 521 508 420 420 query55 93 88 78 78 query56 294 272 248 248 query57 1182118111351135 query58 270 253 241 241 query59 2687279227352735 query60 285 283 269 269 query61 122 115 120 115 query62 846 727 673 673 query63 236 190 195 190 query64 33071039687 687 query65 4649444944504449 query66 925 416 303 303 query67 16491 15577 15364 15364 query68 9554886 497 497 query69 476 297 264 264 query70 1217114610931093 query71 464 294 262 262 query72 5147367839063678 query73 827 747 354 354 query74 9043911486458645 query75 4363315427242724 query76 50761202752 752 query77 986 350 270 270 query78 991710233 93199319 query79 3007825 565 565 query80 591 516 446 446 query81 465 263 217 217 query82 229 125 94 94 query83 161 169 149 149 query84 287 91 76 76 query85 744 360 351 351 query86 329 311 301 301 query87 4595456443024302 query88 2883221722942217 query89 426 317 273 273 query90 2184209 215 209 query91 139 140 107 107 query92 70 57 53 53 query93 22741034566 566 query94 673 408 306 306 query95 349 259 257 257 query96 483 545 278 278 query97 3327343832893289 query98 216 204 205 204 query99 1385140612471247 Total cold run time: 282676 ms Total hot run time: 192050 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
doris-robot commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2723366050 TPC-H: Total hot run time: 32229 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit b5432b73fb9b4588b919dc85dc8f74eb1dca2cb7, data reload: false -- Round 1 -- q1 17585 527750115011 q2 2033299 162 162 q3 10495 1243735 735 q4 10204 1000523 523 q5 7513236323162316 q6 185 161 133 133 q7 910 762 595 595 q8 9290126210951095 q9 4905489645764576 q10 6820231518761876 q11 468 268 259 259 q12 344 344 217 217 q13 17771 371030833083 q14 228 228 211 211 q15 532 488 496 488 q16 623 618 557 557 q17 574 814 370 370 q18 6864644563446344 q19 1224935 543 543 q20 320 325 197 197 q21 2854214619171917 q22 1037103010211021 Total cold run time: 102779 ms Total hot run time: 32229 ms - Round 2, with runtime_filter_mode=off - q1 5165510351325103 q2 241 323 232 232 q3 2208268023302330 q4 1468186514301430 q5 4308418842324188 q6 213 166 125 125 q7 1865193018571857 q8 2652268025772577 q9 7357734072537253 q10 3044327128272827 q11 583 514 493 493 q12 705 804 620 620 q13 3494396033013301 q14 278 308 279 279 q15 565 529 495 495 q16 672 679 645 645 q17 1133154714021402 q18 7700762277997622 q19 856 884 977 884 q20 2070212519411941 q21 5872517849934993 q22 1163113910841084 Total cold run time: 53612 ms Total hot run time: 51681 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
github-actions[bot] commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2723302927 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
feiniaofeiafei commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2723310174 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
924060929 commented on code in PR #42199:
URL: https://github.com/apache/doris/pull/42199#discussion_r1994634619
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##
@@ -325,8 +343,8 @@ private ImmutableSet
getAvailableExpressions(Set predica
return ImmutableSet.copyOf(newPredicates);
}
-private boolean hasAgg(Expression expression) {
-return expression.anyMatch(AggregateFunction.class::isInstance);
+private boolean supportPullUpAgg(Expression expr) {
Review Comment:
origin logic seems trivial, or not working
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
github-actions[bot] commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2723302807 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
924060929 commented on code in PR #42199:
URL: https://github.com/apache/doris/pull/42199#discussion_r1994637970
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##
@@ -325,8 +343,8 @@ private ImmutableSet
getAvailableExpressions(Set predica
return ImmutableSet.copyOf(newPredicates);
}
-private boolean hasAgg(Expression expression) {
-return expression.anyMatch(AggregateFunction.class::isInstance);
+private boolean supportPullUpAgg(Expression expr) {
Review Comment:
origin logic seems trivial, or not working
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
doris-robot commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2674008960 ClickBench: Total hot run time: 30.58 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 563407c27d31afaca36163575298fbe46d66912a, data reload: false query1 0.040.020.03 query2 0.070.030.04 query3 0.240.070.07 query4 1.610.110.10 query5 0.420.410.39 query6 1.170.650.66 query7 0.020.010.02 query8 0.040.030.03 query9 0.600.510.52 query10 0.560.580.56 query11 0.150.110.11 query12 0.140.110.11 query13 0.610.590.60 query14 2.742.702.70 query15 0.920.860.86 query16 0.360.380.37 query17 1.031.051.00 query18 0.200.200.19 query19 1.931.802.02 query20 0.010.010.01 query21 15.35 0.920.55 query22 0.761.260.60 query23 14.92 1.400.64 query24 7.122.350.81 query25 0.500.150.18 query26 0.710.160.13 query27 0.060.050.06 query28 9.660.820.43 query29 12.53 3.983.33 query30 0.240.080.06 query31 2.830.580.38 query32 3.220.540.47 query33 2.982.983.03 query34 15.95 5.134.56 query35 4.584.534.60 query36 0.650.510.48 query37 0.090.070.06 query38 0.050.050.04 query39 0.030.030.02 query40 0.170.130.12 query41 0.080.030.03 query42 0.040.030.02 query43 0.040.030.03 Total cold run time: 105.42 s Total hot run time: 30.58 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
doris-robot commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2673971987 TPC-H: Total hot run time: 31065 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 563407c27d31afaca36163575298fbe46d66912a, data reload: false -- Round 1 -- q1 17593 529050585058 q2 2041319 172 172 q3 10398 1244724 724 q4 10202 1020534 534 q5 7525247922312231 q6 183 165 130 130 q7 910 732 592 592 q8 9277132111841184 q9 4867459845124512 q10 6826230318801880 q11 477 285 249 249 q12 357 388 225 225 q13 17749 370430603060 q14 233 231 202 202 q15 500 449 459 449 q16 633 601 563 563 q17 565 853 324 324 q18 6491617161016101 q19 1635932 534 534 q20 304 315 189 189 q21 2655214318561856 q22 353 338 296 296 Total cold run time: 101774 ms Total hot run time: 31065 ms - Round 2, with runtime_filter_mode=off - q1 5130508351095083 q2 234 331 237 237 q3 2184269923012301 q4 1445179513631363 q5 4190410641804106 q6 203 165 125 125 q7 1887183716571657 q8 2535252625432526 q9 7242727171987198 q10 3030320028132813 q11 564 519 484 484 q12 695 784 634 634 q13 3456388732733273 q14 279 288 265 265 q15 495 458 450 450 q16 647 680 656 656 q17 1126158113321332 q18 7560734772527252 q19 783 815 990 815 q20 1947203018921892 q21 5322495348154815 q22 618 565 539 539 Total cold run time: 51572 ms Total hot run time: 49816 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
doris-robot commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2673997853 TPC-DS: Total hot run time: 189746 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 563407c27d31afaca36163575298fbe46d66912a, data reload: false query1 1315963 936 936 query2 6249184819061848 query3 9 445744804457 query4 56929 24195 23195 23195 query5 5103549 514 514 query6 391 203 189 189 query7 5264502 289 289 query8 320 246 233 233 query9 6587258225952582 query10 423 312 266 266 query11 15163 15095 14845 14845 query12 166 106 111 106 query13 1274504 403 403 query14 10577 631563906315 query15 211 205 191 191 query16 7025658 493 493 query17 1054732 578 578 query18 1538429 319 319 query19 223 220 169 169 query20 132 134 127 127 query21 204 125 114 114 query22 4411457844464446 query23 34057 33321 33635 33321 query24 5574240124532401 query25 445 470 409 409 query26 667 274 159 159 query27 1697472 335 335 query28 2985248724112411 query29 545 568 444 444 query30 206 190 153 153 query31 897 860 798 798 query32 72 62 59 59 query33 438 363 304 304 query34 779 839 525 525 query35 801 839 773 773 query36 957 980 924 924 query37 119 97 74 74 query38 4333435042494249 query39 1496143614361436 query40 201 112 101 101 query41 53 50 50 50 query42 119 99 111 99 query43 501 517 498 498 query44 1296814 791 791 query45 191 182 168 168 query46 874 1055665 665 query47 1852186317851785 query48 405 427 314 314 query49 698 523 430 430 query50 741 771 426 426 query51 4287425842384238 query52 113 107 96 96 query53 227 256 184 184 query54 483 502 425 425 query55 83 79 87 79 query56 276 265 260 260 query57 1172119010771077 query58 259 238 232 232 query59 2732283726762676 query60 292 298 268 268 query61 121 114 119 114 query62 727 730 674 674 query63 232 195 193 193 query64 14141006652 652 query65 3166316331643163 query66 700 415 294 294 query67 15927 15675 15339 15339 query68 5371763 508 508 query69 553 307 256 256 query70 1222113611021102 query71 461 282 251 251 query72 5931362737113627 query73 1063737 349 349 query74 9133908690119011 query75 3237312326942694 query76 39041164718 718 query77 560 378 278 278 query78 989810146 93659365 query79 2365819 600 600 query80 593 535 440 440 query81 509 286 237 237 query82 204 126 95 95 query83 173 171 154 154 query84 290 90 70 70 query85 769 345 301 301 query86 373 318 286 286 query87 4683444643194319 query88 3750220822702208 query89 420 321 289 289 query90 1813191 188 188 query91 133 136 107 107 query92 80 58 51 51 query93 20351054569 569 query94 645 411 291 291 query95 341 264 255 255 query96 502 543 290 290 query97 2841284027062706 query98 233 197 201 197 query99 1320141212531253 Total cold run time: 296293 ms Total hot run time: 189746 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
feiniaofeiafei commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2673864066 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
feiniaofeiafei commented on code in PR #42199:
URL: https://github.com/apache/doris/pull/42199#discussion_r1963717032
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##
@@ -379,4 +397,16 @@ private ImmutableSet
getFiltersFromUnionConstExprs(LogicalUnion unio
}
return ImmutableSet.copyOf(filtersFromConstExprs);
}
+
+private Map generateMap(List
namedExpressions) {
+Map replaceMap = new
LinkedHashMap<>(namedExpressions.size());
+for (NamedExpression namedExpression : namedExpressions) {
+if (namedExpression instanceof Alias) {
+replaceMap.putIfAbsent(namedExpression.toSlot(),
namedExpression.child(0));
+} else if (namedExpression instanceof SlotReference) {
+replaceMap.putIfAbsent((Slot) namedExpression,
namedExpression);
Review Comment:
the qualifier may be different when there is a LogicalSubQueryAlias pushed
to the LogicalProject.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
feiniaofeiafei commented on code in PR #42199:
URL: https://github.com/apache/doris/pull/42199#discussion_r1963717798
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##
@@ -273,24 +284,31 @@ public ImmutableSet
visitLogicalProject(LogicalProject visitLogicalAggregate(LogicalAggregate aggregate, Void context) {
return cacheOrElse(aggregate, () -> {
ImmutableSet childPredicates =
aggregate.child().accept(this, context);
-// TODO
List outputExpressions =
aggregate.getOutputExpressions();
-
-Map expressionSlotMap
-=
Maps.newLinkedHashMapWithExpectedSize(outputExpressions.size());
+Map> expressionSlotMap
+=
Maps.newHashMapWithExpectedSize(outputExpressions.size());
Review Comment:
no need here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
feiniaofeiafei commented on code in PR #42199:
URL: https://github.com/apache/doris/pull/42199#discussion_r1963715401
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##
@@ -379,4 +397,16 @@ private ImmutableSet
getFiltersFromUnionConstExprs(LogicalUnion unio
}
return ImmutableSet.copyOf(filtersFromConstExprs);
}
+
+private Map generateMap(List
namedExpressions) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
feiniaofeiafei commented on code in PR #42199:
URL: https://github.com/apache/doris/pull/42199#discussion_r1963465068
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##
@@ -273,24 +284,31 @@ public ImmutableSet
visitLogicalProject(LogicalProject visitLogicalAggregate(LogicalAggregate aggregate, Void context) {
return cacheOrElse(aggregate, () -> {
ImmutableSet childPredicates =
aggregate.child().accept(this, context);
-// TODO
List outputExpressions =
aggregate.getOutputExpressions();
-
-Map expressionSlotMap
-=
Maps.newLinkedHashMapWithExpectedSize(outputExpressions.size());
+Map> expressionSlotMap
+=
Maps.newHashMapWithExpectedSize(outputExpressions.size());
for (NamedExpression output : outputExpressions) {
-if (hasAgg(output)) {
-expressionSlotMap.putIfAbsent(
-output instanceof Alias ? output.child(0) :
output, output.toSlot()
-);
+if (output instanceof Alias &&
supportPullUpAgg(output.child(0))) {
+expressionSlotMap.computeIfAbsent(output.child(0).child(0),
+k -> new ArrayList<>()).add(output.toSlot());
+}
Review Comment:
these function only has one child:min,max,avg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
morrySnow commented on code in PR #42199:
URL: https://github.com/apache/doris/pull/42199#discussion_r1955739668
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##
@@ -379,4 +397,16 @@ private ImmutableSet
getFiltersFromUnionConstExprs(LogicalUnion unio
}
return ImmutableSet.copyOf(filtersFromConstExprs);
}
+
+private Map generateMap(List
namedExpressions) {
Review Comment:
could u add some comment to explain the purpose of this replace map
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##
@@ -379,4 +397,16 @@ private ImmutableSet
getFiltersFromUnionConstExprs(LogicalUnion unio
}
return ImmutableSet.copyOf(filtersFromConstExprs);
}
+
+private Map generateMap(List
namedExpressions) {
+Map replaceMap = new
LinkedHashMap<>(namedExpressions.size());
+for (NamedExpression namedExpression : namedExpressions) {
+if (namedExpression instanceof Alias) {
+replaceMap.putIfAbsent(namedExpression.toSlot(),
namedExpression.child(0));
+} else if (namedExpression instanceof SlotReference) {
+replaceMap.putIfAbsent((Slot) namedExpression,
namedExpression);
Review Comment:
why put a entry with same key and value? i think it is not necessary
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##
@@ -273,24 +284,31 @@ public ImmutableSet
visitLogicalProject(LogicalProject visitLogicalAggregate(LogicalAggregate aggregate, Void context) {
return cacheOrElse(aggregate, () -> {
ImmutableSet childPredicates =
aggregate.child().accept(this, context);
-// TODO
List outputExpressions =
aggregate.getOutputExpressions();
-
-Map expressionSlotMap
-=
Maps.newLinkedHashMapWithExpectedSize(outputExpressions.size());
+Map> expressionSlotMap
+=
Maps.newHashMapWithExpectedSize(outputExpressions.size());
Review Comment:
not need to keep order anymore?
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##
@@ -273,24 +284,31 @@ public ImmutableSet
visitLogicalProject(LogicalProject visitLogicalAggregate(LogicalAggregate aggregate, Void context) {
return cacheOrElse(aggregate, () -> {
ImmutableSet childPredicates =
aggregate.child().accept(this, context);
-// TODO
List outputExpressions =
aggregate.getOutputExpressions();
-
-Map expressionSlotMap
-=
Maps.newLinkedHashMapWithExpectedSize(outputExpressions.size());
+Map> expressionSlotMap
+=
Maps.newHashMapWithExpectedSize(outputExpressions.size());
for (NamedExpression output : outputExpressions) {
-if (hasAgg(output)) {
-expressionSlotMap.putIfAbsent(
-output instanceof Alias ? output.child(0) :
output, output.toSlot()
-);
+if (output instanceof Alias &&
supportPullUpAgg(output.child(0))) {
+expressionSlotMap.computeIfAbsent(output.child(0).child(0),
+k -> new ArrayList<>()).add(output.toSlot());
+}
Review Comment:
maybe need add some comment to explain when `supportPullUpAgg` return true,
`output.child(0)` always has one child
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##
@@ -68,9 +77,11 @@ public class PullUpPredicates extends
PlanVisitor, Void
Map> cache = new IdentityHashMap<>();
private final boolean getAllPredicates;
+private final ExpressionRewriteContext rewriteContext;
Review Comment:
could we add more detail about this rule in the class' comment or in each
function's comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
morrySnow commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2658474337 @xzj7019 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
doris-robot commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2636331688 ClickBench: Total hot run time: 30.77 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit d9beba2bbe5801c8d2ad396c173c4ca974342eac, data reload: false query1 0.040.030.03 query2 0.060.040.03 query3 0.250.070.06 query4 1.620.100.11 query5 0.440.420.41 query6 1.150.650.66 query7 0.020.020.02 query8 0.040.040.03 query9 0.580.490.51 query10 0.560.570.56 query11 0.160.090.09 query12 0.140.120.12 query13 0.620.590.59 query14 2.862.892.87 query15 0.880.820.84 query16 0.380.360.37 query17 0.991.010.98 query18 0.230.220.21 query19 1.912.001.87 query20 0.020.010.01 query21 15.39 0.930.58 query22 0.730.800.83 query23 15.11 1.480.56 query24 2.891.200.83 query25 0.190.220.06 query26 0.250.150.14 query27 0.080.060.04 query28 13.82 1.090.45 query29 12.57 3.933.24 query30 0.250.080.06 query31 2.820.590.38 query32 3.220.540.48 query33 2.953.093.03 query34 16.64 5.144.54 query35 4.494.474.55 query36 0.660.510.50 query37 0.090.060.06 query38 0.050.040.03 query39 0.030.030.02 query40 0.170.140.14 query41 0.080.020.02 query42 0.040.020.02 query43 0.030.020.02 Total cold run time: 105.5 s Total hot run time: 30.77 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
doris-robot commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2636319445 TPC-DS: Total hot run time: 185869 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit d9beba2bbe5801c8d2ad396c173c4ca974342eac, data reload: false query1 972 370 359 359 query2 6514208820942088 query3 6801210 215 210 query4 33618 23335 23555 23335 query5 4345640 476 476 query6 302 195 181 181 query7 4599481 307 307 query8 290 257 233 233 query9 9598270226942694 query10 456 322 259 259 query11 17916 15456 15060 15060 query12 156 109 108 108 query13 1661530 417 417 query14 10275 696867516751 query15 225 194 195 194 query16 8021658 499 499 query17 1618746 613 613 query18 2101388 283 283 query19 224 183 154 154 query20 117 113 111 111 query21 213 121 100 100 query22 4184420241344134 query23 34131 33176 33147 33147 query24 6802223822482238 query25 490 458 379 379 query26 1215270 152 152 query27 2041458 339 339 query28 5475245224432443 query29 701 530 417 417 query30 231 182 153 153 query31 959 875 805 805 query32 108 64 58 58 query33 517 344 295 295 query34 740 837 524 524 query35 800 821 729 729 query36 990 1052939 939 query37 114 99 87 87 query38 4248415840644064 query39 1457139413951394 query40 207 115 99 99 query41 51 53 51 51 query42 120 100 102 100 query43 531 509 489 489 query44 1343792 793 792 query45 186 178 166 166 query46 856 1041645 645 query47 1823182417701770 query48 384 395 329 329 query49 765 486 393 393 query50 624 695 404 404 query51 4223415541314131 query52 107 111 93 93 query53 227 254 188 188 query54 475 500 434 434 query55 87 78 81 78 query56 269 261 233 233 query57 1112112910781078 query58 250 237 237 237 query59 3054323829302930 query60 280 266 257 257 query61 125 125 115 115 query62 815 734 648 648 query63 221 191 187 187 query64 44031050654 654 query65 3233316431193119 query66 1054419 304 304 query67 15889 15496 15283 15283 query68 2433829 568 568 query69 439 290 260 260 query70 1247115411341134 query71 408 279 251 251 query72 5860381337803780 query73 646 751 366 366 query74 10053 917988388838 query75 3171316926542654 query76 28631227803 803 query77 451 366 274 274 query78 10022 10370 97429742 query79 1022888 593 593 query80 1280539 470 470 query81 552 279 238 238 query82 364 154 124 124 query83 274 174 164 164 query84 235 95 70 70 query85 770 413 383 383 query86 411 319 314 314 query87 4465445145174451 query88 3671224421992199 query89 391 330 295 295 query90 1738192 195 192 query91 202 141 106 106 query92 62 61 53 53 query93 955 877 548 548 query94 673 394 295 295 query95 336 269 259 259 query96 487 598 285 285 query97 2808287127672767 query98 220 203 200 200 query99 1272139912571257 Total cold run time: 277720 ms Total hot run time: 185869 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
doris-robot commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2636289162 TPC-H: Total hot run time: 32422 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit d9beba2bbe5801c8d2ad396c173c4ca974342eac, data reload: false -- Round 1 -- q1 17596 552854055405 q2 2043329 176 176 q3 10384 1330728 728 q4 10220 967 532 532 q5 7699246821672167 q6 196 164 132 132 q7 914 771 610 610 q8 9214133211131113 q9 5476493848954895 q10 6833232519241924 q11 480 277 262 262 q12 342 364 223 223 q13 17767 372931343134 q14 239 217 210 210 q15 511 482 473 473 q16 653 616 597 597 q17 566 865 323 323 q18 6989648765026487 q19 1234936 539 539 q20 321 328 196 196 q21 2829221019871987 q22 372 339 309 309 Total cold run time: 102878 ms Total hot run time: 32422 ms - Round 2, with runtime_filter_mode=off - q1 5507551754495449 q2 238 324 233 233 q3 2207264823322332 q4 1412182914351435 q5 4342478246804680 q6 168 159 122 122 q7 2095199018561856 q8 2667280626952695 q9 7228723871807180 q10 2987326628032803 q11 578 512 492 492 q12 640 758 619 619 q13 3576415433253325 q14 292 309 269 269 q15 508 464 460 460 q16 645 687 640 640 q17 1203174112391239 q18 7919743072037203 q19 757 117510661066 q20 2025205519351935 q21 5686518750745074 q22 593 599 552 552 Total cold run time: 53273 ms Total hot run time: 51659 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
feiniaofeiafei commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2636231939 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
doris-robot commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2606290847 ClickBench: Total hot run time: 30.29 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 7e6e02ce3437d56f29abf375f41f696c6d5f6383, data reload: false query1 0.030.030.03 query2 0.080.030.03 query3 0.240.070.07 query4 1.610.100.10 query5 0.440.400.40 query6 1.170.660.66 query7 0.030.020.02 query8 0.040.030.03 query9 0.580.520.50 query10 0.560.560.54 query11 0.150.100.10 query12 0.140.110.12 query13 0.610.590.60 query14 2.852.772.75 query15 0.910.820.82 query16 0.390.390.37 query17 1.021.061.03 query18 0.230.220.21 query19 1.961.791.97 query20 0.010.010.01 query21 15.36 0.940.57 query22 0.760.820.67 query23 15.26 1.490.52 query24 2.940.721.22 query25 0.120.080.13 query26 0.360.150.14 query27 0.070.060.06 query28 13.72 1.060.43 query29 12.56 3.913.30 query30 0.250.080.05 query31 2.850.600.39 query32 3.220.540.46 query33 3.012.973.06 query34 16.48 5.194.49 query35 4.554.524.50 query36 0.640.490.48 query37 0.100.070.06 query38 0.040.030.03 query39 0.030.030.02 query40 0.160.130.13 query41 0.080.030.02 query42 0.040.030.02 query43 0.040.030.02 Total cold run time: 105.69 s Total hot run time: 30.29 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
doris-robot commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2606285826 TPC-DS: Total hot run time: 186664 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 7e6e02ce3437d56f29abf375f41f696c6d5f6383, data reload: false query1 972 381 363 363 query2 6509203219201920 query3 6794214 211 211 query4 33296 23269 22924 22924 query5 4376619 464 464 query6 312 198 187 187 query7 4599492 315 315 query8 307 246 231 231 query9 9283259625902590 query10 493 334 274 274 query11 17817 15231 14864 14864 query12 154 107 108 107 query13 1659554 408 408 query14 10359 730866796679 query15 259 197 183 183 query16 7922645 478 478 query17 1644725 549 549 query18 1971378 285 285 query19 221 180 153 153 query20 112 112 136 112 query21 209 129 99 99 query22 4248433941104110 query23 33938 32933 33185 32933 query24 6417221822832218 query25 501 460 371 371 query26 1194272 155 155 query27 1999472 337 337 query28 5126243223842384 query29 658 559 412 412 query30 237 185 155 155 query31 949 862 805 805 query32 91 60 65 60 query33 523 368 305 305 query34 753 834 507 507 query35 802 816 740 740 query36 982 1031959 959 query37 130 98 74 74 query38 4180412541324125 query39 1467139214071392 query40 209 111 105 105 query41 54 53 52 52 query42 121 102 110 102 query43 525 502 477 477 query44 1346799 818 799 query45 181 172 165 165 query46 854 1024634 634 query47 1847181117971797 query48 384 386 304 304 query49 785 488 391 391 query50 631 683 395 395 query51 7049698368356835 query52 101 96 90 90 query53 219 251 184 184 query54 488 496 406 406 query55 81 81 78 78 query56 261 251 250 250 query57 1155117510561056 query58 244 228 241 228 query59 2977319129202920 query60 288 278 256 256 query61 119 118 121 118 query62 794 711 657 657 query63 224 193 192 192 query64 43191059652 652 query65 3247315631623156 query66 1082413 315 315 query67 16042 15636 15464 15464 query68 5762822 525 525 query69 491 298 265 265 query70 1248111510851085 query71 386 291 260 260 query72 5899382238353822 query73 653 758 367 367 query74 10315 900688668866 query75 3188320126652665 query76 32341210752 752 query77 482 349 289 289 query78 10068 10094 92419241 query79 3354809 595 595 query80 598 524 451 451 query81 514 287 243 243 query82 589 145 121 121 query83 173 173 157 157 query84 237 100 77 77 query85 798 379 310 310 query86 404 317 310 310 query87 4466445544034403 query88 4887213021332130 query89 402 336 284 284 query90 1852189 193 189 query91 136 140 114 114 query92 70 59 54 54 query93 1949866 537 537 query94 706 408 299 299 query95 342 262 263 262 query96 494 619 278 278 query97 2789285027462746 query98 237 208 197 197 query99 1267139512541254 Total cold run time: 287080 ms Total hot run time: 186664 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
doris-robot commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2606273695 TPC-H: Total hot run time: 32592 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 7e6e02ce3437d56f29abf375f41f696c6d5f6383, data reload: false -- Round 1 -- q1 17631 558254295429 q2 2048307 172 172 q3 10407 1263711 711 q4 10218 956 526 526 q5 7537240722052205 q6 192 170 134 134 q7 953 750 623 623 q8 9233138212181218 q9 5189499549564956 q10 6832232319091909 q11 471 269 250 250 q12 345 364 219 219 q13 17790 377531943194 q14 228 229 211 211 q15 509 471 466 466 q16 635 625 598 598 q17 550 858 319 319 q18 7094655864306430 q19 1227963 533 533 q20 305 332 193 193 q21 2857223719821982 q22 367 339 314 314 Total cold run time: 102618 ms Total hot run time: 32592 ms - Round 2, with runtime_filter_mode=off - q1 5528548855095488 q2 243 341 239 239 q3 2250267123292329 q4 1405184213871387 q5 4312475746524652 q6 165 155 123 123 q7 2084202318341834 q8 2624280426942694 q9 7332724371797179 q10 2999327027612761 q11 587 528 509 509 q12 690 784 605 605 q13 3497392633683368 q14 278 292 268 268 q15 517 488 471 471 q16 661 694 648 648 q17 1238172312661266 q18 7796743073527352 q19 790 109111191091 q20 1972202718881888 q21 5611525448654865 q22 603 623 555 555 Total cold run time: 53182 ms Total hot run time: 51572 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
feiniaofeiafei commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2606251555 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
doris-robot commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2499671177 ClickBench: Total hot run time: 33.25 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit ecdd0726355ea639e978a478e6bafab23087a721, data reload: false query1 0.040.040.04 query2 0.060.040.03 query3 0.230.080.07 query4 1.610.100.11 query5 0.420.420.40 query6 1.140.650.67 query7 0.020.020.01 query8 0.040.030.03 query9 0.570.490.51 query10 0.530.580.56 query11 0.140.100.11 query12 0.140.110.11 query13 0.610.610.61 query14 2.712.722.72 query15 0.910.830.84 query16 0.380.390.38 query17 1.001.071.03 query18 0.240.210.21 query19 1.961.851.93 query20 0.020.010.01 query21 15.37 0.590.58 query22 2.731.962.44 query23 16.88 0.960.84 query24 2.631.281.78 query25 0.150.240.16 query26 0.420.140.13 query27 0.050.060.04 query28 10.42 1.101.09 query29 12.52 3.253.21 query30 0.250.060.07 query31 2.860.390.38 query32 3.280.460.47 query33 3.033.113.03 query34 16.86 4.534.55 query35 4.574.474.54 query36 0.660.500.49 query37 0.090.060.07 query38 0.050.040.03 query39 0.030.020.03 query40 0.160.130.13 query41 0.070.020.02 query42 0.040.020.02 query43 0.040.030.03 Total cold run time: 105.93 s Total hot run time: 33.25 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
doris-robot commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2499664985 TPC-DS: Total hot run time: 197942 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit ecdd0726355ea639e978a478e6bafab23087a721, data reload: false query1 1229933 899 899 query2 6267214520802080 query3 10952 397240413972 query4 67874 29187 23542 23542 query5 4829466 467 466 query6 433 193 188 188 query7 5503307 294 294 query8 313 230 219 219 query9 8715263426452634 query10 442 261 250 250 query11 17228 15224 15940 15224 query12 149 106 105 105 query13 1477408 415 408 query14 10030 792779347927 query15 208 201 205 201 query16 7038466 467 466 query17 1195558 568 558 query18 1794297 303 297 query19 230 147 154 147 query20 120 120 113 113 query21 202 104 108 104 query22 4724462443504350 query23 34934 34354 34417 34354 query24 5446251725712517 query25 487 390 394 390 query26 645 156 153 153 query27 1810292 290 290 query28 4666247624732473 query29 677 409 427 409 query30 219 150 160 150 query31 1045828 838 828 query32 67 52 55 52 query33 467 289 285 285 query34 946 533 523 523 query35 864 743 755 743 query36 1068976 947 947 query37 122 84 72 72 query38 4526450743494349 query39 1515151514941494 query40 198 110 101 101 query41 44 40 44 40 query42 114 105 105 105 query43 553 491 521 491 query44 1203835 834 834 query45 200 204 167 167 query46 1136736 726 726 query47 2031188219141882 query48 423 317 333 317 query49 724 408 396 396 query50 840 396 423 396 query51 7465727972907279 query52 104 95 85 85 query53 261 187 174 174 query54 518 391 397 391 query55 85 77 77 77 query56 252 241 243 241 query57 1290117911741174 query58 230 223 227 223 query59 3337318031803180 query60 285 258 250 250 query61 133 127 127 127 query62 808 676 682 676 query63 217 194 191 191 query64 1464662 631 631 query65 3280318332453183 query66 706 305 326 305 query67 15969 15737 15627 15627 query68 4073574 562 562 query69 419 253 251 251 query70 1225106410931064 query71 356 262 255 255 query72 6313407340154015 query73 772 350 368 350 query74 10508 907390899073 query75 3392268227892682 query76 1805113411321132 query77 446 280 277 277 query78 10418 945593769376 query79 2221591 607 591 query80 1426424 436 424 query81 535 240 231 231 query82 1314123 126 123 query83 269 155 146 146 query84 276 70 73 70 query85 1146331 290 290 query86 435 302 304 302 query87 4870465646254625 query88 3570225622182218 query89 425 291 293 291 query90 1929189 186 186 query91 136 102 105 102 query92 64 49 51 49 query93 3104550 534 534 query94 873 306 275 275 query95 356 247 255 247 query96 632 282 282 282 query97 2928268027022680 query98 222 193 199 193 query99 1666131713041304 Total cold run time: 322450 ms Total hot run time: 197942 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
doris-robot commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2499651767 TPC-H: Total hot run time: 41598 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit ecdd0726355ea639e978a478e6bafab23087a721, data reload: false -- Round 1 -- q1 17583 789080097890 q2 2044178 169 169 q3 10776 117712661177 q4 10564 738 772 738 q5 7629287928652865 q6 260 152 151 151 q7 1064637 626 626 q8 9260187020511870 q9 6973672966986698 q10 7010235223692352 q11 470 275 270 270 q12 454 227 219 219 q13 17772 305830403040 q14 258 210 207 207 q15 589 531 544 531 q16 684 600 582 582 q17 1032534 557 534 q18 7316665768156657 q19 1359113012181130 q20 496 182 187 182 q21 4285354533953395 q22 396 328 315 315 Total cold run time: 108274 ms Total hot run time: 41598 ms - Round 2, with runtime_filter_mode=off - q1 7836782279907822 q2 357 243 237 237 q3 3202305231113052 q4 2265197018911891 q5 5782584259165842 q6 251 146 148 146 q7 2365182318041804 q8 3712379637103710 q9 9165903990299029 q10 3805370937273709 q11 628 532 514 514 q12 861 623 589 589 q13 11252 331732923292 q14 333 295 293 293 q15 587 530 537 530 q16 704 637 658 637 q17 1985173917181718 q18 8338775777887757 q19 1898176017581758 q20 2127189219131892 q21 5814551055415510 q22 676 577 573 573 Total cold run time: 73943 ms Total hot run time: 62305 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
feiniaofeiafei commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2499613396 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
doris-robot commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2451300534 TPC-DS: Total hot run time: 196276 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit f1e405f3e40ba131d6e3e9c1f58b0067abdfc3c7, data reload: false query1 1218904 897 897 query2 6259207720912077 query3 10788 389639253896 query4 67879 29405 23628 23628 query5 5077455 432 432 query6 403 164 159 159 query7 5649294 302 294 query8 294 231 225 225 query9 9290276527562756 query10 467 267 251 251 query11 17559 15490 15933 15490 query12 163 105 104 104 query13 1550448 434 434 query14 10953 708869396939 query15 214 183 180 180 query16 7085460 455 455 query17 1012550 568 550 query18 1843294 293 293 query19 193 152 150 150 query20 118 111 110 110 query21 203 98 109 98 query22 4620436644174366 query23 34784 34192 34288 34192 query24 6016281728492817 query25 522 401 409 401 query26 658 165 165 165 query27 1657294 290 290 query28 4197248824372437 query29 657 400 411 400 query30 231 151 147 147 query31 982 761 843 761 query32 67 54 56 54 query33 432 262 261 261 query34 936 508 528 508 query35 865 730 733 730 query36 1080958 967 958 query37 111 71 73 71 query38 4442430942374237 query39 1487144714061406 query40 191 94 97 94 query41 45 41 43 41 query42 110 97 96 96 query43 552 504 507 504 query44 1173807 826 807 query45 179 160 160 160 query46 1105725 681 681 query47 1926188218591859 query48 414 318 316 316 query49 715 394 386 386 query50 815 389 418 389 query51 7302717970317031 query52 97 90 87 87 query53 270 182 180 180 query54 525 395 401 395 query55 77 77 76 76 query56 258 230 241 230 query57 1280121811631163 query58 212 210 198 198 query59 3241314629162916 query60 279 250 246 246 query61 98 98 103 98 query62 798 672 682 672 query63 216 191 197 191 query64 1348617 627 617 query65 3269325832503250 query66 720 296 333 296 query67 15966 15523 15815 15523 query68 2741591 606 591 query69 404 255 250 250 query70 1177116411451145 query71 318 253 257 253 query72 5462411840534053 query73 760 366 363 363 query74 9659892591838925 query75 3414264426752644 query76 1615102511481025 query77 522 280 280 280 query78 10319 944994199419 query79 1367606 589 589 query80 817 431 441 431 query81 493 251 243 243 query82 1257118 113 113 query83 212 147 139 139 query84 270 72 70 70 query85 846 292 283 283 query86 348 286 276 276 query87 4895471448544714 query88 3318222321722172 query89 411 299 297 297 query90 1977185 186 185 query91 137 104 96 96 query92 60 49 49 49 query93 1297536 542 536 query94 767 281 284 281 query95 348 243 244 243 query96 607 272 286 272 query97 2898270527282705 query98 215 209 190 190 query99 1583132313231323 Total cold run time: 315656 ms Total hot run time: 196276 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
doris-robot commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2451304982 ClickBench: Total hot run time: 33.03 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit f1e405f3e40ba131d6e3e9c1f58b0067abdfc3c7, data reload: false query1 0.030.030.03 query2 0.070.030.03 query3 0.230.060.06 query4 1.640.110.11 query5 0.420.420.42 query6 1.140.650.67 query7 0.010.020.01 query8 0.040.030.05 query9 0.560.510.51 query10 0.560.560.55 query11 0.140.100.10 query12 0.140.110.11 query13 0.610.610.61 query14 2.862.842.71 query15 0.890.830.82 query16 0.390.380.37 query17 1.081.071.06 query18 0.200.200.19 query19 1.981.902.02 query20 0.010.000.01 query21 15.39 0.590.58 query22 2.762.011.88 query23 17.03 0.920.82 query24 2.831.342.26 query25 0.160.180.05 query26 0.570.130.14 query27 0.040.040.04 query28 9.661.081.07 query29 12.58 3.273.25 query30 0.240.070.06 query31 2.860.390.37 query32 3.270.460.44 query33 2.963.053.06 query34 17.13 4.484.45 query35 4.524.504.45 query36 0.670.480.51 query37 0.080.060.06 query38 0.050.030.03 query39 0.030.020.02 query40 0.150.130.12 query41 0.090.020.02 query42 0.040.020.02 query43 0.030.030.03 Total cold run time: 106.14 s Total hot run time: 33.03 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
doris-robot commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2451291227 TPC-H: Total hot run time: 41452 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit f1e405f3e40ba131d6e3e9c1f58b0067abdfc3c7, data reload: false -- Round 1 -- q1 17575 775172877287 q2 2055168 176 168 q3 10541 110912171109 q4 10549 858 884 858 q5 7775311030553055 q6 235 148 149 148 q7 1029621 614 614 q8 9341200419961996 q9 6642643464686434 q10 7109245824712458 q11 482 273 264 264 q12 410 215 214 214 q13 17788 301330033003 q14 264 208 222 208 q15 574 533 515 515 q16 689 609 597 597 q17 976 492 501 492 q18 7373674867256725 q19 1343102710841027 q20 495 187 185 185 q21 3979331730813081 q22 1104101710141014 Total cold run time: 108328 ms Total hot run time: 41452 ms - Round 2, with runtime_filter_mode=off - q1 7262724172337233 q2 325 224 230 224 q3 3002296530212965 q4 2115192617971797 q5 5748578457775777 q6 232 154 147 147 q7 2251189918141814 q8 3384355234483448 q9 8914897688648864 q10 3608355435663554 q11 608 513 510 510 q12 825 645 645 645 q13 9082320931683168 q14 308 285 273 273 q15 589 523 531 523 q16 695 637 626 626 q17 1879165216121612 q18 8505789176487648 q19 1708154715151515 q20 2133188418811881 q21 5558539454565394 q22 1162109910411041 Total cold run time: 69893 ms Total hot run time: 60659 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
feiniaofeiafei commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2451236612 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
feiniaofeiafei commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2448925407 run cloud_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
feiniaofeiafei commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2446949317 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
xzj7019 commented on code in PR #42199:
URL: https://github.com/apache/doris/pull/42199#discussion_r1820894518
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##
@@ -325,8 +343,8 @@ private ImmutableSet
getAvailableExpressions(Set predica
return ImmutableSet.copyOf(newPredicates);
}
-private boolean hasAgg(Expression expression) {
-return expression.anyMatch(AggregateFunction.class::isInstance);
+private boolean supportPullUpAgg(Expression expr) {
Review Comment:
Does it mean the original hasAgg judgement actually contains any unexpected
pulled up agg cases, after this restriction?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
feiniaofeiafei commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2434155845 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
doris-robot commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2432267537 ClickBench: Total hot run time: 33.29 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 07b17d30d410bd73069d6b6b2ff1a7f70eb3aeff, data reload: false query1 0.030.030.03 query2 0.070.030.02 query3 0.220.060.06 query4 1.650.100.10 query5 0.510.510.51 query6 1.130.730.72 query7 0.020.020.01 query8 0.040.030.03 query9 0.560.500.51 query10 0.550.560.55 query11 0.150.110.11 query12 0.140.110.11 query13 0.610.610.59 query14 2.832.752.71 query15 0.910.840.83 query16 0.400.380.37 query17 1.011.011.05 query18 0.200.200.20 query19 1.951.882.00 query20 0.010.010.01 query21 15.35 0.620.61 query22 3.122.682.40 query23 17.14 0.940.88 query24 3.310.880.90 query25 0.270.220.05 query26 0.440.140.13 query27 0.040.030.03 query28 10.63 1.101.07 query29 12.52 3.313.30 query30 0.240.070.06 query31 2.840.380.38 query32 3.260.470.46 query33 3.013.003.04 query34 17.17 4.464.53 query35 4.474.464.47 query36 0.680.480.49 query37 0.080.060.06 query38 0.050.030.03 query39 0.030.030.02 query40 0.160.120.13 query41 0.080.020.03 query42 0.040.020.02 query43 0.030.040.02 Total cold run time: 107.95 s Total hot run time: 33.29 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
doris-robot commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2432247596 TPC-DS: Total hot run time: 192714 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 07b17d30d410bd73069d6b6b2ff1a7f70eb3aeff, data reload: false query1 955 381 384 381 query2 5355221121462146 query3 4664216 226 216 query4 33280 23714 23579 23579 query5 3594473 501 473 query6 237 169 158 158 query7 4032299 300 299 query8 306 237 228 228 query9 8663271727602717 query10 441 301 286 286 query11 17718 15158 15189 15158 query12 152 106 103 103 query13 1472439 427 427 query14 9627713071367130 query15 266 175 175 175 query16 7373460 459 459 query17 1340577 562 562 query18 1818322 308 308 query19 279 152 148 148 query20 127 116 108 108 query21 216 109 103 103 query22 4722423443664234 query23 35102 34487 34281 34281 query24 10723 276328152763 query25 691 412 409 409 query26 1711160 173 160 query27 2619284 285 284 query28 7400246724672467 query29 1018440 432 432 query30 334 166 156 156 query31 1038813 855 813 query32 80 57 60 57 query33 698 290 305 290 query34 954 505 525 505 query35 961 755 765 755 query36 1130946 963 946 query37 246 91 92 91 query38 4163390539523905 query39 1496143314931433 query40 279 103 105 103 query41 50 48 47 47 query42 121 99 101 99 query43 550 516 500 500 query44 1257825 821 821 query45 206 170 173 170 query46 1161715 706 706 query47 1922182418221822 query48 433 326 324 324 query49 1258452 443 443 query50 831 389 408 389 query51 7168703470167016 query52 102 94 93 93 query53 259 187 181 181 query54 842 440 451 440 query55 81 79 80 79 query56 289 270 275 270 query57 1332118111691169 query58 242 283 287 283 query59 3498304330903043 query60 305 292 287 287 query61 154 100 107 100 query62 862 691 661 661 query63 217 186 185 185 query64 4602656 615 615 query65 3277318132483181 query66 1311318 304 304 query67 16038 15952 15636 15636 query68 4256574 550 550 query69 534 296 297 296 query70 1217115111911151 query71 364 283 265 265 query72 6667395440243954 query73 784 363 375 363 query74 9579911891039103 query75 3405264227002642 query76 3341876 924 876 query77 411 320 305 305 query78 10468 967896559655 query79 1136598 617 598 query80 2040474 453 453 query81 579 243 245 243 query82 349 141 144 141 query83 282 136 136 136 query84 268 70 73 70 query85 1360296 280 280 query86 394 307 305 305 query87 4581443745164437 query88 3479223922072207 query89 392 289 291 289 query90 2149194 183 183 query91 143 101 101 101 query92 74 50 48 48 query93 1095558 544 544 query94 1134283 294 283 query95 349 253 258 253 query96 612 279 287 279 query97 3294315130963096 query98 214 195 199 195 query99 1503130713011301 Total cold run time: 292101 ms Total hot run time: 192714 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
doris-robot commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2432194653 TPC-H: Total hot run time: 41601 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 07b17d30d410bd73069d6b6b2ff1a7f70eb3aeff, data reload: false -- Round 1 -- q1 17597 747073047304 q2 2067169 166 166 q3 10564 117011881170 q4 10230 819 832 819 q5 7743309331183093 q6 238 151 152 151 q7 1040621 602 602 q8 9354194419551944 q9 6676645964766459 q10 7114243824502438 q11 457 253 253 253 q12 585 226 230 226 q13 17783 303130383031 q14 250 215 218 215 q15 571 524 509 509 q16 655 595 594 594 q17 994 530 545 530 q18 7399688968606860 q19 1375990 1036990 q20 469 191 185 185 q21 4175335730813081 q22 11221014981 981 Total cold run time: 108458 ms Total hot run time: 41601 ms - Round 2, with runtime_filter_mode=off - q1 7302742672777277 q2 328 231 234 231 q3 2960280028172800 q4 1975170017011700 q5 5479548455265484 q6 233 149 148 148 q7 2161172417611724 q8 3227341034023402 q9 8543861586318615 q10 3514350934733473 q11 573 479 489 479 q12 804 583 600 583 q13 12541 300730463007 q14 301 265 264 264 q15 565 509 510 509 q16 687 635 643 635 q17 1840162215691569 q18 7864754176267541 q19 1666152914921492 q20 2045181918171817 q21 5413520452735204 q22 1125102110081008 Total cold run time: 71146 ms Total hot run time: 58962 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
feiniaofeiafei commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2432125148 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
feiniaofeiafei commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2432022450 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
doris-robot commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2426277680 TPC-DS: Total hot run time: 191978 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit f003cfa34ac896360edc7152f6b5e51293237326, data reload: false query1 922 384 401 384 query2 6267213221142114 query3 8705193 211 193 query4 34205 23724 23466 23466 query5 3543476 465 465 query6 281 180 172 172 query7 4192295 293 293 query8 301 244 228 228 query9 9605273127412731 query10 459 269 280 269 query11 17809 15199 15152 15152 query12 146 106 99 99 query13 1574433 406 406 query14 9727748971907190 query15 251 175 176 175 query16 7284461 444 444 query17 1632648 593 593 query18 1528315 337 315 query19 376 156 178 156 query20 132 121 120 120 query21 209 108 107 107 query22 4781472446574657 query23 35135 34182 34160 34160 query24 10870 281027322732 query25 616 434 396 396 query26 1142161 164 161 query27 2202286 293 286 query28 7364246324362436 query29 716 435 436 435 query30 293 155 162 155 query31 1089807 833 807 query32 97 57 54 54 query33 748 293 304 293 query34 914 534 489 489 query35 899 738 752 738 query36 1125972 969 969 query37 148 88 89 88 query38 4143390840283908 query39 1470143714081408 query40 214 97 98 97 query41 48 47 46 46 query42 122 102 100 100 query43 543 514 492 492 query44 1266812 810 810 query45 202 165 168 165 query46 1142698 708 698 query47 1959186418851864 query48 433 315 322 315 query49 1002441 431 431 query50 813 391 394 391 query51 7100696669736966 query52 104 94 93 93 query53 269 180 180 180 query54 1199450 435 435 query55 78 74 76 74 query56 259 255 245 245 query57 1290120911541154 query58 230 230 235 230 query59 3212323830513051 query60 286 267 259 259 query61 106 103 103 103 query62 863 656 653 653 query63 222 188 187 187 query64 4014634 603 603 query65 3266323032263226 query66 823 302 337 302 query67 16133 15617 15741 15617 query68 3514582 568 568 query69 506 297 294 294 query70 1222106110601060 query71 345 279 298 279 query72 7292397638313831 query73 775 354 378 354 query74 10123 922389448944 query75 3460264326322632 query76 2963917 922 917 query77 614 311 298 298 query78 10451 964095589558 query79 2010588 603 588 query80 1049451 445 445 query81 584 241 241 241 query82 649 136 139 136 query83 276 134 132 132 query84 272 68 70 68 query85 1309299 294 294 query86 414 284 301 284 query87 4518442142914291 query88 3052223021902190 query89 407 287 294 287 query90 1947184 189 184 query91 134 103 101 101 query92 62 50 48 48 query93 1795537 538 537 query94 933 292 292 292 query95 349 246 249 246 query96 620 274 291 274 query97 3282310730903090 query98 217 198 192 192 query99 1586132912921292 Total cold run time: 296828 ms Total hot run time: 191978 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
doris-robot commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2426288913 ClickBench: Total hot run time: 32.26 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit f003cfa34ac896360edc7152f6b5e51293237326, data reload: false query1 0.040.040.03 query2 0.060.030.03 query3 0.230.060.06 query4 1.670.100.10 query5 0.520.490.50 query6 1.130.730.73 query7 0.020.030.01 query8 0.040.030.03 query9 0.560.510.49 query10 0.560.550.56 query11 0.160.120.11 query12 0.140.110.11 query13 0.610.590.60 query14 2.842.842.73 query15 0.900.830.84 query16 0.380.380.39 query17 1.061.070.99 query18 0.190.190.19 query19 1.931.872.05 query20 0.010.010.01 query21 15.36 0.610.56 query22 2.471.771.51 query23 17.14 0.960.76 query24 2.580.872.20 query25 0.200.180.10 query26 0.590.140.14 query27 0.040.040.04 query28 10.16 1.101.07 query29 12.55 3.253.27 query30 0.240.060.05 query31 2.890.390.36 query32 3.280.450.46 query33 3.023.083.05 query34 16.92 4.524.46 query35 4.514.494.54 query36 0.670.490.50 query37 0.090.050.06 query38 0.050.040.03 query39 0.040.020.02 query40 0.170.120.13 query41 0.080.030.02 query42 0.040.020.02 query43 0.040.020.02 Total cold run time: 106.18 s Total hot run time: 32.26 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
doris-robot commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2426253041 TPC-H: Total hot run time: 41433 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit f003cfa34ac896360edc7152f6b5e51293237326, data reload: false -- Round 1 -- q1 17654 769172687268 q2 2024295 278 278 q3 12375 108211631082 q4 10565 837 868 837 q5 7757310931023102 q6 239 155 149 149 q7 1031624 606 606 q8 9359198119911981 q9 6660647963966396 q10 7070241724152415 q11 451 241 245 241 q12 428 221 228 221 q13 17801 304530213021 q14 243 210 213 210 q15 576 520 507 507 q16 643 595 590 590 q17 986 470 456 456 q18 7213682368476823 q19 1355914 1062914 q20 490 187 186 186 q21 4020333731623162 q22 11051016988 988 Total cold run time: 110045 ms Total hot run time: 41433 ms - Round 2, with runtime_filter_mode=off - q1 7301728173077281 q2 331 246 245 245 q3 3083298129902981 q4 2091175518311755 q5 5749580758205807 q6 232 149 149 149 q7 2294187018791870 q8 3409343035433430 q9 8965892989848929 q10 3621358236213582 q11 595 487 506 487 q12 847 674 627 627 q13 8713322932663229 q14 311 273 272 272 q15 574 512 534 512 q16 707 665 643 643 q17 1850161215911591 q18 8340776676147614 q19 1736160615321532 q20 2116187618721872 q21 5803544654825446 q22 1189109110771077 Total cold run time: 69857 ms Total hot run time: 60931 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
feiniaofeiafei commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2426098980 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
doris-robot commented on PR #42199: URL: https://github.com/apache/doris/pull/42199#issuecomment-2426098755 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
