Re: [PR] [fix/feature](kill) fix kill operation and support kill by trace id [doris]

2025-05-25 Thread via GitHub


morningman merged PR #50791:
URL: https://github.com/apache/doris/pull/50791


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix/feature](kill) fix kill operation and support kill by trace id [doris]

2025-05-23 Thread via GitHub


github-actions[bot] commented on PR #50791:
URL: https://github.com/apache/doris/pull/50791#issuecomment-2906329105

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix/feature](kill) fix kill operation and support kill by trace id [doris]

2025-05-23 Thread via GitHub


github-actions[bot] commented on PR #50791:
URL: https://github.com/apache/doris/pull/50791#issuecomment-2906329096

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix/feature](kill) fix kill operation and support kill by trace id [doris]

2025-05-20 Thread via GitHub


doris-robot commented on PR #50791:
URL: https://github.com/apache/doris/pull/50791#issuecomment-2896481130

   
   
   ClickBench: Total hot run time: 29.42 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 81bdbd1f25755b62605662c810b23ca785cfc6cd, 
data reload: false
   
   query1   0.040.040.03
   query2   0.120.100.11
   query3   0.270.200.19
   query4   1.600.200.19
   query5   0.440.440.43
   query6   1.150.660.66
   query7   0.030.020.02
   query8   0.040.040.04
   query9   0.600.510.51
   query10  0.580.580.56
   query11  0.150.110.11
   query12  0.140.110.11
   query13  0.610.590.60
   query14  0.790.820.80
   query15  0.870.840.87
   query16  0.390.390.38
   query17  1.021.021.04
   query18  0.220.210.21
   query19  1.941.791.88
   query20  0.020.010.01
   query21  15.42   0.910.54
   query22  0.751.110.93
   query23  14.72   1.380.69
   query24  6.811.900.93
   query25  0.490.320.05
   query26  0.550.160.15
   query27  0.050.050.06
   query28  9.890.870.45
   query29  12.57   3.973.28
   query30  0.260.090.06
   query31  2.820.590.39
   query32  3.230.550.47
   query33  3.073.053.04
   query34  15.69   5.134.50
   query35  4.504.524.52
   query36  0.680.490.47
   query37  0.090.060.06
   query38  0.050.040.04
   query39  0.030.020.03
   query40  0.170.130.13
   query41  0.090.030.02
   query42  0.030.030.02
   query43  0.040.030.02
   Total cold run time: 103.02 s
   Total hot run time: 29.42 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix/feature](kill) fix kill operation and support kill by trace id [doris]

2025-05-20 Thread via GitHub


doris-robot commented on PR #50791:
URL: https://github.com/apache/doris/pull/50791#issuecomment-2896475174

   
   
   TPC-DS: Total hot run time: 193501 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 81bdbd1f25755b62605662c810b23ca785cfc6cd, 
data reload: false
   
   query1   1390110410821082
   query2   6250186319151863
   query3   11020   449644414441
   query4   54439   24384   23282   23282
   query5   5087496 467 467
   query6   339 208 197 197
   query7   4877513 311 311
   query8   323 261 248 248
   query9   5241265626662656
   query10  442 333 284 284
   query11  14947   15077   14813   14813
   query12  154 116 110 110
   query13  1030548 443 443
   query14  10191   636363706363
   query15  212 198 171 171
   query16  7137665 514 514
   query17  1079750 584 584
   query18  1572426 318 318
   query19  195 190 175 175
   query20  134 126 119 119
   query21  207 129 110 110
   query22  4329445842924292
   query23  34412   33716   33703   33703
   query24  6634247323922392
   query25  465 468 421 421
   query26  677 287 158 158
   query27  2291529 347 347
   query28  3179218921722172
   query29  582 560 448 448
   query30  280 221 207 207
   query31  872 896 788 788
   query32  75  65  74  65
   query33  472 377 321 321
   query34  788 857 553 553
   query35  840 840 746 746
   query36  940 1029910 910
   query37  112 97  72  72
   query38  4235441442764276
   query39  1499144314771443
   query40  212 118 112 112
   query41  54  52  51  51
   query42  125 116 117 116
   query43  512 535 503 503
   query44  1313850 836 836
   query45  185 173 173 173
   query46  863 1027653 653
   query47  1838184817801780
   query48  422 447 336 336
   query49  673 528 425 425
   query50  683 719 431 431
   query51  4192437342174217
   query52  117 110 105 105
   query53  232 253 187 187
   query54  583 585 529 529
   query55  88  91  87  87
   query56  318 306 310 306
   query57  1166119811541154
   query58  274 273 285 273
   query59  2925296827762776
   query60  351 344 326 326
   query61  129 123 126 123
   query62  738 756 692 692
   query63  235 195 196 195
   query64  15001025670 670
   query65  4313422542424225
   query66  709 389 300 300
   query67  15853   15612   15617   15612
   query68  5653886 536 536
   query69  513 317 283 283
   query70  1206112910931093
   query71  443 320 300 300
   query72  5482477547924775
   query73  1329623 356 356
   query74  8934918988048804
   query75  3486319627022702
   query76  36841264763 763
   query77  555 386 277 277
   query78  10241   10553   92599259
   query79  1825884 571 571
   query80  829 517 456 456
   query81  504 268 222 222
   query82  397 127 93  93
   query83  260 248 237 237
   query84  296 106 83  83
   query85  758 355 314 314
   query86  342 300 287 287
   query87  4512449144874487
   query88  2953232822992299
   query89  407 323 293 293
   query90  1728211 207 207
   query91  136 140 110 110
   query92  66  62  55  55
   query93  1802957 581 581
   query94  614 420 299 299
   query95  368 295 290 290
   query96  517 567 287 287
   query97  2695271926452645
   query98  235 223 208 208
   query99  1365136912711271
   Total cold run time: 293686 ms
   Total hot run time: 193501 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go 

Re: [PR] [fix/feature](kill) fix kill operation and support kill by trace id [doris]

2025-05-20 Thread via GitHub


doris-robot commented on PR #50791:
URL: https://github.com/apache/doris/pull/50791#issuecomment-2896462190

   
   
   TPC-H: Total hot run time: 33940 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 81bdbd1f25755b62605662c810b23ca785cfc6cd, 
data reload: false
   
   -- Round 1 --
   q1   25973   507649714971
   q2   2063281 185 185
   q3   10390   1260699 699
   q4   10224   1035557 557
   q5   7535231323642313
   q6   186 162 134 134
   q7   919 753 647 647
   q8   9343129911061106
   q9   6832506650905066
   q10  6879228418831883
   q11  506 290 293 290
   q12  355 363 218 218
   q13  17815   367931183118
   q14  226 241 213 213
   q15  533 502 470 470
   q16  435 436 386 386
   q17  611 857 383 383
   q18  7578706870587058
   q19  1529967 556 556
   q20  333 327 224 224
   q21  3672317524732473
   q22  10231005990 990
   Total cold run time: 114960 ms
   Total hot run time: 33940 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   5116509050465046
   q2   253 322 238 238
   q3   2167265323042304
   q4   1371176913311331
   q5   4441439144104391
   q6   217 166 127 127
   q7   1973193817551755
   q8   2611250225932502
   q9   7305716869626962
   q10  3086321927532753
   q11  578 502 495 495
   q12  692 749 603 603
   q13  3508385232543254
   q14  293 291 275 275
   q15  533 487 476 476
   q16  449 486 429 429
   q17  1140150214211421
   q18  7722753974797479
   q19  823 825 993 825
   q20  2012209218641864
   q21  4764452443514351
   q22  1081106410551055
   Total cold run time: 52135 ms
   Total hot run time: 49936 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix/feature](kill) fix kill operation and support kill by trace id [doris]

2025-05-20 Thread via GitHub


morningman commented on PR #50791:
URL: https://github.com/apache/doris/pull/50791#issuecomment-2896405239

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix/feature](kill) fix kill operation and support kill by trace id [doris]

2025-05-12 Thread via GitHub


doris-robot commented on PR #50791:
URL: https://github.com/apache/doris/pull/50791#issuecomment-2873174443

   
   
   ClickBench: Total hot run time: 29.07 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 586acadf5cd80b514a5735db3ddea64a3467310b, 
data reload: false
   
   query1   0.040.040.03
   query2   0.120.100.11
   query3   0.250.190.18
   query4   1.590.190.18
   query5   0.600.580.59
   query6   1.190.720.73
   query7   0.030.020.02
   query8   0.040.040.04
   query9   0.580.530.52
   query10  0.580.590.56
   query11  0.160.110.10
   query12  0.160.110.12
   query13  0.610.600.60
   query14  0.790.810.82
   query15  0.880.840.85
   query16  0.410.380.39
   query17  1.041.041.04
   query18  0.230.210.21
   query19  1.901.861.86
   query20  0.010.010.01
   query21  15.40   0.890.56
   query22  0.761.180.64
   query23  14.99   1.380.62
   query24  6.872.050.62
   query25  0.450.140.16
   query26  0.730.160.14
   query27  0.060.050.05
   query28  9.080.890.43
   query29  12.56   3.983.34
   query30  0.250.100.07
   query31  2.820.580.38
   query32  3.240.570.48
   query33  3.003.143.01
   query34  15.63   5.104.43
   query35  4.514.514.49
   query36  0.660.500.47
   query37  0.090.060.06
   query38  0.050.040.03
   query39  0.030.020.02
   query40  0.180.130.12
   query41  0.080.030.03
   query42  0.030.020.03
   query43  0.040.030.03
   Total cold run time: 102.72 s
   Total hot run time: 29.07 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix/feature](kill) fix kill operation and support kill by trace id [doris]

2025-05-12 Thread via GitHub


doris-robot commented on PR #50791:
URL: https://github.com/apache/doris/pull/50791#issuecomment-2873156728

   
   
   TPC-DS: Total hot run time: 193066 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 586acadf5cd80b514a5735db3ddea64a3467310b, 
data reload: false
   
   query1   1423110310401040
   query2   6116185218211821
   query3   10961   462644974497
   query4   55770   25062   23036   23036
   query5   5100501 436 436
   query6   340 192 192 192
   query7   4969499 293 293
   query8   325 267 239 239
   query9   5975265926372637
   query10  450 334 269 269
   query11  15120   15204   14819   14819
   query12  157 117 109 109
   query13  1107511 421 421
   query14  10142   629663126296
   query15  221 211 182 182
   query16  7199672 483 483
   query17  1075777 612 612
   query18  1641416 337 337
   query19  205 207 171 171
   query20  130 126 118 118
   query21  208 129 106 106
   query22  4467461344354435
   query23  3   33455   33143   33143
   query24  6438246124392439
   query25  459 478 420 420
   query26  684 276 165 165
   query27  2273507 345 345
   query28  2893213721382137
   query29  597 580 454 454
   query30  266 229 190 190
   query31  863 839 822 822
   query32  74  62  68  62
   query33  467 381 301 301
   query34  761 879 534 534
   query35  776 836 737 737
   query36  927 1006916 916
   query37  109 101 71  71
   query38  4302431343494313
   query39  1514146114411441
   query40  218 121 112 112
   query41  54  57  50  50
   query42  127 111 110 110
   query43  486 510 468 468
   query44  1314823 852 823
   query45  184 180 180 180
   query46  851 1017656 656
   query47  1874189817951795
   query48  411 435 337 337
   query49  686 530 456 456
   query50  657 700 420 420
   query51  4250421541984198
   query52  112 107 101 101
   query53  221 263 188 188
   query54  618 590 531 531
   query55  82  84  85  84
   query56  299 308 305 305
   query57  1190124211301130
   query58  269 264 260 260
   query59  2655278126312631
   query60  352 338 312 312
   query61  130 123 128 123
   query62  743 736 655 655
   query63  219 189 187 187
   query64  16981019670 670
   query65  4383437143084308
   query66  776 406 309 309
   query67  16902   15690   15832   15690
   query68  7589834 520 520
   query69  542 319 265 265
   query70  1208108810751075
   query71  494 332 291 291
   query72  5469478247084708
   query73  1382589 352 352
   query74  9036920590369036
   query75  3848322927172717
   query76  41951178759 759
   query77  623 356 289 289
   query78  10011   10168   93579357
   query79  2195823 596 596
   query80  573 598 451 451
   query81  484 249 221 221
   query82  473 125 92  92
   query83  258 249 235 235
   query84  295 96  88  88
   query85  796 344 309 309
   query86  387 275 300 275
   query87  4471454143234323
   query88  3919229222842284
   query89  404 328 276 276
   query90  1816201 218 201
   query91  138 141 114 114
   query92  73  62  58  58
   query93  1910943 574 574
   query94  655 408 307 307
   query95  366 300 286 286
   query96  509 562 285 285
   query97  3207326031483148
   query98  228 210 193 193
   query99  1391136912531253
   Total cold run time: 301654 ms
   Total hot run time: 193066 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go 

Re: [PR] [fix/feature](kill) fix kill operation and support kill by trace id [doris]

2025-05-12 Thread via GitHub


doris-robot commented on PR #50791:
URL: https://github.com/apache/doris/pull/50791#issuecomment-2873120071

   
   
   TPC-H: Total hot run time: 34100 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 586acadf5cd80b514a5735db3ddea64a3467310b, 
data reload: false
   
   -- Round 1 --
   q1   25939   500849954995
   q2   2070295 191 191
   q3   10369   1245679 679
   q4   10234   993 510 510
   q5   7530232223622322
   q6   192 157 128 128
   q7   902 733 600 600
   q8   9313124110471047
   q9   6724511951235119
   q10  6878232218981898
   q11  576 288 277 277
   q12  344 354 222 222
   q13  17991   382831713171
   q14  232 225 222 222
   q15  533 477 482 477
   q16  438 443 375 375
   q17  644 858 400 400
   q18  7693725972827259
   q19  1720953 556 556
   q20  345 361 227 227
   q21  3940270524422442
   q22  10381007983 983
   Total cold run time: 115645 ms
   Total hot run time: 34100 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   5109510650405040
   q2   229 326 226 226
   q3   2155264622752275
   q4   1391179912971297
   q5   4384436143674361
   q6   219 173 135 135
   q7   1993193117801780
   q8   2556263425762576
   q9   7175714270127012
   q10  2967320427662766
   q11  582 515 500 500
   q12  694 765 601 601
   q13  3474391733243324
   q14  314 305 283 283
   q15  524 513 484 484
   q16  458 474 440 440
   q17  1131155813721372
   q18  7687741974187418
   q19  817 788 889 788
   q20  1976197118651865
   q21  5222479346764676
   q22  11051039971 971
   Total cold run time: 52162 ms
   Total hot run time: 50190 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix/feature](kill) fix kill operation and support kill by trace id [doris]

2025-05-12 Thread via GitHub


morningman commented on PR #50791:
URL: https://github.com/apache/doris/pull/50791#issuecomment-2872983186

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix/feature](kill) fix kill operation and support kill by trace id [doris]

2025-05-11 Thread via GitHub


morningman commented on code in PR #50791:
URL: https://github.com/apache/doris/pull/50791#discussion_r2083749224


##
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##
@@ -6116,14 +6116,15 @@ public LogicalPlan 
visitShowConvertLsc(ShowConvertLscContext ctx) {
 
 @Override
 public LogicalPlan visitKillQuery(KillQueryContext ctx) {

Review Comment:
   > > No, there are 2 ways to kill query:
   > > 
   > > 1. Kill query by query id: `KILL QUERY "query_id";`
   > > 2. Kill query by connection id: `KILL QUERY connection_id`, where 
connection_id is an integer, not a string.
   > 
   > the grammer is very weird. `KILL QUERY` but need a params of 
connection_id. could lead to misunderstand for people not read doc very 
carefully.
   
   This is compatible with [MySQL Kill 
Statement](https://dev.mysql.com/doc/refman/8.4/en/kill.html)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix/feature](kill) fix kill operation and support kill by trace id [doris]

2025-05-11 Thread via GitHub


morrySnow commented on code in PR #50791:
URL: https://github.com/apache/doris/pull/50791#discussion_r2083748486


##
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##
@@ -6116,14 +6116,15 @@ public LogicalPlan 
visitShowConvertLsc(ShowConvertLscContext ctx) {
 
 @Override
 public LogicalPlan visitKillQuery(KillQueryContext ctx) {

Review Comment:
   > No, there are 2 ways to kill query:
   > 
   > 1. Kill query by query id: `KILL QUERY "query_id";`
   > 2. Kill query by connection id: `KILL QUERY connection_id`, where 
connection_id is an integer, not a string.
   
   the grammer is very weird. `KILL QUERY` but need a params of connection_id. 
could lead to misunderstand for people not read doc very carefully.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix/feature](kill) fix kill operation and support kill by trace id [doris]

2025-05-11 Thread via GitHub


morningman commented on code in PR #50791:
URL: https://github.com/apache/doris/pull/50791#discussion_r2083746554


##
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##
@@ -6116,14 +6116,15 @@ public LogicalPlan 
visitShowConvertLsc(ShowConvertLscContext ctx) {
 
 @Override
 public LogicalPlan visitKillQuery(KillQueryContext ctx) {

Review Comment:
   No, there are 2 ways to kill query:
   1. Kill query by query id: `KILL QUERY "query_id";`
   2. Kill query by connection id: `KILL QUERY connection_id`, where 
connection_id is an integer, not a string.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix/feature](kill) fix kill operation and support kill by trace id [doris]

2025-05-11 Thread via GitHub


starocean999 commented on code in PR #50791:
URL: https://github.com/apache/doris/pull/50791#discussion_r2083744923


##
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##
@@ -6116,14 +6116,15 @@ public LogicalPlan 
visitShowConvertLsc(ShowConvertLscContext ctx) {
 
 @Override
 public LogicalPlan visitKillQuery(KillQueryContext ctx) {

Review Comment:
   based on old planner, if specify QUERY KEYWORD, it always means to kill 
query, and the query id is whatever INTEGER_VALUE or STRING_LITERAL. Looks like 
the behavior is changed in this pr?
   ```
   kill_stmt ::=
   KW_KILL INTEGER_LITERAL:value
   {:
   RESULT = new KillStmt(true, value.intValue());
   :}
   | KW_KILL KW_CONNECTION INTEGER_LITERAL:value
   {:
   RESULT = new KillStmt(true, value.intValue());
   :}
   | KW_KILL KW_QUERY INTEGER_LITERAL:value
   {:
   RESULT = new KillStmt(false, value.intValue());
   :}
   | KW_KILL KW_QUERY STRING_LITERAL:value
   {:
   RESULT = new KillStmt(value);
   :}
   ;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix/feature](kill) fix kill operation and support kill by trace id [doris]

2025-05-11 Thread via GitHub


doris-robot commented on PR #50791:
URL: https://github.com/apache/doris/pull/50791#issuecomment-2870023274

   
   
   ClickBench: Total hot run time: 29.34 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit cb392aa966a95746d46155c3ce850a1220a52ee9, 
data reload: false
   
   query1   0.040.040.04
   query2   0.120.100.12
   query3   0.250.200.19
   query4   1.600.190.19
   query5   0.600.570.60
   query6   1.180.730.72
   query7   0.020.020.02
   query8   0.040.040.03
   query9   0.580.530.52
   query10  0.550.590.57
   query11  0.160.110.12
   query12  0.140.120.12
   query13  0.620.600.60
   query14  0.780.820.81
   query15  0.870.850.87
   query16  0.390.370.39
   query17  1.051.021.07
   query18  0.230.220.22
   query19  2.011.921.77
   query20  0.010.010.02
   query21  15.44   0.930.56
   query22  0.781.130.72
   query23  14.92   1.370.64
   query24  7.111.540.82
   query25  0.490.070.18
   query26  0.600.170.13
   query27  0.050.040.05
   query28  9.480.880.48
   query29  12.52   4.003.30
   query30  0.250.090.06
   query31  2.810.620.39
   query32  3.230.550.47
   query33  3.093.033.14
   query34  15.89   5.194.51
   query35  4.544.564.49
   query36  0.660.490.48
   query37  0.080.060.06
   query38  0.050.040.04
   query39  0.030.020.02
   query40  0.160.130.13
   query41  0.080.030.02
   query42  0.030.020.03
   query43  0.030.030.03
   Total cold run time: 103.56 s
   Total hot run time: 29.34 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix/feature](kill) fix kill operation and support kill by trace id [doris]

2025-05-11 Thread via GitHub


doris-robot commented on PR #50791:
URL: https://github.com/apache/doris/pull/50791#issuecomment-2870021460

   
   
   TPC-DS: Total hot run time: 194326 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit cb392aa966a95746d46155c3ce850a1220a52ee9, 
data reload: false
   
   query1   1369110410471047
   query2   6313181017981798
   query3   11123   463346034603
   query4   54463   24725   23361   23361
   query5   5016553 456 456
   query6   376 213 203 203
   query7   4911523 290 290
   query8   303 248 235 235
   query9   5365264226392639
   query10  458 339 269 269
   query11  15038   15064   15255   15064
   query12  163 110 108 108
   query13  1054517 405 405
   query14  10226   629964226299
   query15  213 199 179 179
   query16  7160682 511 511
   query17  1092772 601 601
   query18  1689414 327 327
   query19  203 194 172 172
   query20  137 131 138 131
   query21  243 126 109 109
   query22  4442452244784478
   query23  33977   33508   33767   33508
   query24  6521243424302430
   query25  487 494 416 416
   query26  697 275 154 154
   query27  2319505 346 346
   query28  2998216021672160
   query29  581 560 436 436
   query30  284 230 194 194
   query31  879 857 816 816
   query32  75  70  65  65
   query33  459 377 314 314
   query34  767 871 565 565
   query35  788 817 738 738
   query36  928 1020901 901
   query37  111 105 75  75
   query38  4233434143454341
   query39  1488147914661466
   query40  225 120 114 114
   query41  55  55  56  55
   query42  128 108 109 108
   query43  496 507 488 488
   query44  1360846 875 846
   query45  191 171 166 166
   query46  856 1047660 660
   query47  1895189018311831
   query48  401 428 311 311
   query49  687 517 433 433
   query50  686 699 408 408
   query51  4262421641224122
   query52  120 112 106 106
   query53  237 251 185 185
   query54  598 594 524 524
   query55  94  86  80  80
   query56  304 311 306 306
   query57  1181121211461146
   query58  271 266 257 257
   query59  2764291526362636
   query60  345 337 316 316
   query61  131 141 131 131
   query62  739 742 701 701
   query63  234 191 189 189
   query64  18491077721 721
   query65  4307421641984198
   query66  695 405 305 305
   query67  15896   15712   15489   15489
   query68  7615894 518 518
   query69  537 304 281 281
   query70  1223117611131113
   query71  508 330 312 312
   query72  5937486049354860
   query73  1527677 358 358
   query74  8912915090399039
   query75  3909323827492749
   query76  41351190749 749
   query77  609 371 285 285
   query78  10122   10114   93229322
   query79  3220823 588 588
   query80  640 529 453 453
   query81  497 264 230 230
   query82  480 126 99  99
   query83  416 250 245 245
   query84  292 109 79  79
   query85  783 347 311 311
   query86  379 309 297 297
   query87  4443439243554355
   query88  3762231122962296
   query89  407 316 285 285
   query90  1912211 214 211
   query91  148 144 115 115
   query92  77  62  56  56
   query93  2411950 577 577
   query94  675 493 313 313
   query95  376 301 293 293
   query96  498 571 280 280
   query97  3174331131243124
   query98  232 215 209 209
   query99  1435141512821282
   Total cold run time: 301247 ms
   Total hot run time: 194326 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go 

Re: [PR] [fix/feature](kill) fix kill operation and support kill by trace id [doris]

2025-05-11 Thread via GitHub


doris-robot commented on PR #50791:
URL: https://github.com/apache/doris/pull/50791#issuecomment-2870016994

   
   
   TPC-H: Total hot run time: 33848 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit cb392aa966a95746d46155c3ce850a1220a52ee9, 
data reload: false
   
   -- Round 1 --
   q1   26453   503049574957
   q2   2071290 186 186
   q3   10513   1270686 686
   q4   10232   995 532 532
   q5   7765237223482348
   q6   196 160 130 130
   q7   913 741 613 613
   q8   9326130510601060
   q9   6848512551535125
   q10  6880232518901890
   q11  498 323 280 280
   q12  341 348 214 214
   q13  17768   367430773077
   q14  235 246 216 216
   q15  543 483 482 482
   q16  424 435 387 387
   q17  603 862 383 383
   q18  7712708871057088
   q19  1761944 590 590
   q20  354 343 230 230
   q21  3982334824062406
   q22  10731023968 968
   Total cold run time: 116491 ms
   Total hot run time: 33848 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   5150501150615011
   q2   242 324 226 226
   q3   2175263123102310
   q4   1347175314011401
   q5   4461442844334428
   q6   212 174 127 127
   q7   1984190917581758
   q8   2599263025802580
   q9   7342724470737073
   q10  3042320627582758
   q11  559 504 501 501
   q12  671 745 628 628
   q13  3495386833243324
   q14  291 311 300 300
   q15  531 486 465 465
   q16  455 496 441 441
   q17  1137158714341434
   q18  7853756175097509
   q19  787 843 988 843
   q20  2036200418451845
   q21  5118468946214621
   q22  1100107210531053
   Total cold run time: 52587 ms
   Total hot run time: 50636 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix/feature](kill) fix kill operation and support kill by trace id [doris]

2025-05-11 Thread via GitHub


morningman commented on PR #50791:
URL: https://github.com/apache/doris/pull/50791#issuecomment-2869937017

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix/feature](kill) fix kill operation and support kill by trace id [doris]

2025-05-11 Thread via GitHub


Thearas commented on PR #50791:
URL: https://github.com/apache/doris/pull/50791#issuecomment-2869633090

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting 
information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it 
now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and 
after the optimization?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org