Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
starocean999 merged PR #44755: URL: https://github.com/apache/doris/pull/44755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
doris-robot commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2709750452 TPC-DS: Total hot run time: 192233 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit b15cfa0f21d4a82bc1e0db3624c40d7c82e190fd, data reload: false query1 14011026995 995 query2 6239192918701870 query3 11134 467545634563 query4 54308 26220 23065 23065 query5 5258546 462 462 query6 348 187 175 175 query7 4963508 300 300 query8 330 239 225 225 query9 6200263026392630 query10 413 320 274 274 query11 15277 14972 14850 14850 query12 154 106 103 103 query13 1107499 403 403 query14 10177 642264136413 query15 222 194 186 186 query16 7108676 510 510 query17 1073713 589 589 query18 1628418 329 329 query19 198 190 167 167 query20 129 129 127 127 query21 213 128 108 108 query22 4617465444064406 query23 34012 33400 33212 33212 query24 6581249925042499 query25 453 461 403 403 query26 680 274 156 156 query27 2217506 340 340 query28 2995248924892489 query29 582 558 425 425 query30 277 223 191 191 query31 867 860 805 805 query32 69 68 61 61 query33 456 374 311 311 query34 772 883 513 513 query35 818 856 756 756 query36 980 985 913 913 query37 120 102 83 83 query38 4243438842084208 query39 1492143514371435 query40 230 117 108 108 query41 52 54 50 50 query42 129 110 111 110 query43 507 510 466 466 query44 1337830 843 830 query45 187 176 164 164 query46 851 1041664 664 query47 1854187017721772 query48 385 419 317 317 query49 708 505 431 431 query50 714 774 439 439 query51 4329431542644264 query52 118 111 101 101 query53 235 260 192 192 query54 497 506 437 437 query55 91 83 82 82 query56 288 278 247 247 query57 1176119110721072 query58 253 255 258 255 query59 2594278826162616 query60 305 319 261 261 query61 125 123 117 117 query62 714 754 684 684 query63 236 193 197 193 query64 15331054697 697 query65 4584448644434443 query66 726 398 305 305 query67 15938 15472 15229 15229 query68 5704890 510 510 query69 539 299 263 263 query70 1166115211181118 query71 444 294 285 285 query72 5793366838733668 query73 1067757 355 355 query74 8919920590729072 query75 3233318327272727 query76 38251197750 750 query77 548 376 292 292 query78 10155 10022 92929292 query79 2500815 595 595 query80 650 523 508 508 query81 494 263 225 225 query82 606 125 95 95 query83 186 174 159 159 query84 289 93 75 75 query85 774 363 312 312 query86 403 309 282 282 query87 4434438443314331 query88 3471229822962296 query89 412 320 277 277 query90 1806226 220 220 query91 143 143 110 110 query92 75 62 56 56 query93 24961063586 586 query94 690 412 314 314 query95 355 284 267 267 query96 489 582 276 276 query97 3338343733243324 query98 230 207 200 200 query99 1358138212971297 Total cold run time: 297399 ms Total hot run time: 192233 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
doris-robot commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2709762546 ClickBench: Total hot run time: 31.58 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit b15cfa0f21d4a82bc1e0db3624c40d7c82e190fd, data reload: false query1 0.040.040.04 query2 0.070.030.04 query3 0.230.060.06 query4 1.630.100.11 query5 0.560.560.55 query6 1.200.710.72 query7 0.020.010.01 query8 0.040.040.03 query9 0.580.530.52 query10 0.590.610.58 query11 0.150.100.10 query12 0.150.120.11 query13 0.630.610.60 query14 2.652.812.69 query15 0.940.850.84 query16 0.390.380.37 query17 1.021.021.02 query18 0.210.200.20 query19 1.912.081.86 query20 0.010.010.01 query21 15.38 0.900.54 query22 0.771.280.95 query23 14.71 1.390.61 query24 6.492.091.25 query25 0.480.180.13 query26 0.520.160.14 query27 0.050.060.05 query28 9.400.820.43 query29 12.54 4.003.31 query30 0.240.080.06 query31 2.840.590.38 query32 3.230.550.46 query33 3.012.993.01 query34 15.75 5.104.48 query35 4.534.574.56 query36 0.660.500.50 query37 0.090.060.06 query38 0.050.040.04 query39 0.030.020.03 query40 0.170.130.12 query41 0.090.030.02 query42 0.040.020.03 query43 0.030.030.03 Total cold run time: 104.12 s Total hot run time: 31.58 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
doris-robot commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2709724596 TPC-H: Total hot run time: 32728 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit b15cfa0f21d4a82bc1e0db3624c40d7c82e190fd, data reload: false -- Round 1 -- q1 17638 521751235123 q2 2047296 171 171 q3 10404 1243761 761 q4 10211 1032541 541 q5 7539238423812381 q6 189 165 134 134 q7 927 754 618 618 q8 9313132911321132 q9 4914466546334633 q10 6836230418931893 q11 474 286 265 265 q12 355 364 221 221 q13 17769 373431423142 q14 233 229 210 210 q15 532 480 494 480 q16 609 621 574 574 q17 604 908 354 354 q18 6917643964066406 q19 2036976 574 574 q20 324 325 187 187 q21 2911217019471947 q22 10681034981 981 Total cold run time: 103850 ms Total hot run time: 32728 ms - Round 2, with runtime_filter_mode=off - q1 5303517751835177 q2 236 339 232 232 q3 2202270823302330 q4 1466185813841384 q5 4248413141404131 q6 204 169 125 125 q7 1920190417541754 q8 2656270626712671 q9 7271724571747174 q10 3065324828012801 q11 617 512 498 498 q12 695 746 597 597 q13 3547393733243324 q14 272 302 280 280 q15 546 494 484 484 q16 642 713 659 659 q17 1189166413291329 q18 7814749277497492 q19 862 852 897 852 q20 2013205619091909 q21 5574504948564856 q22 1157108510201020 Total cold run time: 53499 ms Total hot run time: 51079 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
morrySnow commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2709587361 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
LiBinfeng-01 commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2614171573 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
github-actions[bot] commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2607239924 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
github-actions[bot] commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2607239844 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
doris-robot commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2606481972 ClickBench: Total hot run time: 30.13 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 90209ad5163e52c71f9daf8bb2e9fbac44f04d77, data reload: false query1 0.040.040.06 query2 0.080.030.03 query3 0.240.070.07 query4 1.630.100.10 query5 0.440.420.40 query6 1.170.650.67 query7 0.020.020.02 query8 0.040.030.04 query9 0.590.500.51 query10 0.560.570.55 query11 0.140.100.10 query12 0.150.110.11 query13 0.620.600.59 query14 2.712.722.79 query15 0.880.820.84 query16 0.380.380.38 query17 1.071.071.00 query18 0.220.220.21 query19 1.981.852.02 query20 0.020.010.02 query21 15.35 0.920.57 query22 0.760.900.63 query23 15.24 1.410.54 query24 3.021.390.50 query25 0.250.120.06 query26 0.250.150.13 query27 0.060.070.05 query28 13.26 1.000.43 query29 12.56 3.903.25 query30 0.250.080.06 query31 2.830.600.38 query32 3.240.550.46 query33 3.003.023.00 query34 16.61 5.174.57 query35 4.564.584.55 query36 0.640.480.50 query37 0.090.060.05 query38 0.050.040.03 query39 0.040.020.02 query40 0.170.140.13 query41 0.080.020.02 query42 0.030.020.02 query43 0.040.030.02 Total cold run time: 105.36 s Total hot run time: 30.13 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
doris-robot commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2606474452 TPC-DS: Total hot run time: 188201 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 90209ad5163e52c71f9daf8bb2e9fbac44f04d77, data reload: false query1 967 392 374 374 query2 6518205720222022 query3 6791219 209 209 query4 33502 23400 23141 23141 query5 4394645 480 480 query6 294 234 195 195 query7 4594503 304 304 query8 282 231 228 228 query9 9362258525872585 query10 475 316 249 249 query11 17893 15182 15230 15182 query12 174 114 108 108 query13 1654549 408 408 query14 9267773870107010 query15 248 194 181 181 query16 8110629 451 451 query17 1615729 547 547 query18 2119394 286 286 query19 216 178 153 153 query20 117 107 105 105 query21 206 129 104 104 query22 4196431341754175 query23 33971 33349 32606 32606 query24 6465233723342334 query25 488 452 385 385 query26 1196274 156 156 query27 2016467 337 337 query28 5316242724152415 query29 753 553 414 414 query30 231 186 164 164 query31 953 868 809 809 query32 92 63 61 61 query33 544 357 300 300 query34 746 847 517 517 query35 804 810 753 753 query36 10051042924 924 query37 117 107 81 81 query38 4097422741584158 query39 1425141814161416 query40 210 120 102 102 query41 53 54 52 52 query42 120 104 100 100 query43 506 518 483 483 query44 1293813 811 811 query45 183 170 167 167 query46 870 1044653 653 query47 1819184517861786 query48 383 391 314 314 query49 789 485 428 428 query50 624 659 396 396 query51 6916697569526952 query52 103 103 94 94 query53 226 253 188 188 query54 487 492 419 419 query55 80 84 81 81 query56 275 274 245 245 query57 1202116810841084 query58 254 232 236 232 query59 3127295430182954 query60 288 272 254 254 query61 122 120 117 117 query62 780 724 667 667 query63 233 189 190 189 query64 46321113768 768 query65 3242314831893148 query66 1071430 336 336 query67 15890 15724 15368 15368 query68 4296857 546 546 query69 463 317 269 269 query70 1216113211221122 query71 387 294 260 260 query72 5927381138463811 query73 661 755 363 363 query74 9912917989048904 query75 3171319226742674 query76 32041195772 772 query77 474 376 300 300 query78 10033 999293569356 query79 3984805 583 583 query80 697 530 461 461 query81 521 298 240 240 query82 706 158 121 121 query83 180 172 154 154 query84 247 91 84 84 query85 807 365 303 303 query86 404 311 280 280 query87 4604454245054505 query88 4904215021422142 query89 401 332 284 284 query90 1768195 203 195 query91 136 144 108 108 query92 69 56 54 54 query93 2652921 529 529 query94 698 386 298 298 query95 342 281 266 266 query96 489 623 283 283 query97 2788284227582758 query98 234 205 201 201 query99 1316141912601260 Total cold run time: 286682 ms Total hot run time: 188201 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
doris-robot commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2606457471 TPC-H: Total hot run time: 32375 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 90209ad5163e52c71f9daf8bb2e9fbac44f04d77, data reload: false -- Round 1 -- q1 17615 556354025402 q2 2054311 169 169 q3 10409 1331747 747 q4 10227 975 547 547 q5 7558239622172217 q6 190 172 135 135 q7 897 776 603 603 q8 9242137711501150 q9 5274491149064906 q10 6837233519181918 q11 459 277 255 255 q12 346 358 219 219 q13 1 370730913091 q14 241 245 231 231 q15 511 463 460 460 q16 622 636 600 600 q17 574 862 340 340 q18 7261646363316331 q19 1231945 537 537 q20 314 329 191 191 q21 2801221520112011 q22 373 328 315 315 Total cold run time: 102813 ms Total hot run time: 32375 ms - Round 2, with runtime_filter_mode=off - q1 5495552055155515 q2 250 335 237 237 q3 2300265823922392 q4 1411185513741374 q5 4329475747874757 q6 179 169 133 133 q7 2105197919011901 q8 2635277727072707 q9 7326725772627257 q10 3013328027982798 q11 592 507 501 501 q12 700 776 619 619 q13 3512398333413341 q14 292 291 273 273 q15 547 476 462 462 q16 665 697 644 644 q17 1199171512641264 q18 7687749372957295 q19 755 110010831083 q20 2015204718941894 q21 5794522848204820 q22 614 610 590 590 Total cold run time: 53415 ms Total hot run time: 51857 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
LiBinfeng-01 commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2606421296 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
morrySnow commented on code in PR #44755:
URL: https://github.com/apache/doris/pull/44755#discussion_r1924760996
##
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##
@@ -864,41 +864,38 @@ public LogicalPlan
visitCreateScheduledJob(DorisParser.CreateScheduledJobContext
return new CreateJobCommand(createJobInfo);
}
+private void checkJobNameKey(String key, String keyFormat,
DorisParser.SupportedJobStatementContext parseContext) {
+if (key.isEmpty() || !key.equalsIgnoreCase(keyFormat)) {
+throw new ParseException(keyFormat + " should be: '" + keyFormat +
"'", parseContext);
+}
+}
+
@Override
public LogicalPlan visitPauseJob(DorisParser.PauseJobContext ctx) {
-Expression wildWhere = null;
-if (ctx.wildWhere() != null) {
-wildWhere = getWildWhere(ctx.wildWhere());
-}
-return new PauseJobCommand(wildWhere);
+checkJobNameKey(stripQuotes(ctx.jobNameKey.getText()), "jobName", ctx);
Review Comment:
not use magic word, let `"jobName"` be a static variable.
```suggestion
private static String JOB_NAME = "jobName";
...
checkJobNameKey(stripQuotes(ctx.jobNameKey.getText()), JOB_NAME,
ctx);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
doris-robot commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2606208202 ClickBench: Total hot run time: 30.9 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit a783a59232f8054169d663bbc2925fdcf9b9274c, data reload: false query1 0.040.040.03 query2 0.070.040.03 query3 0.240.070.07 query4 1.610.110.11 query5 0.410.410.42 query6 1.150.650.65 query7 0.020.010.02 query8 0.040.040.03 query9 0.590.500.51 query10 0.550.570.54 query11 0.140.100.11 query12 0.130.110.11 query13 0.620.610.60 query14 2.722.802.85 query15 0.890.830.81 query16 0.380.390.38 query17 1.001.021.02 query18 0.220.210.21 query19 1.811.811.99 query20 0.020.010.01 query21 15.38 0.970.57 query22 0.750.980.73 query23 15.05 1.390.51 query24 2.601.151.95 query25 0.130.150.14 query26 0.260.150.14 query27 0.050.060.04 query28 14.18 1.010.42 query29 12.66 3.923.25 query30 0.250.100.06 query31 2.810.610.38 query32 3.230.560.45 query33 3.143.023.09 query34 16.27 5.174.49 query35 4.614.544.58 query36 0.660.500.48 query37 0.090.060.05 query38 0.050.040.04 query39 0.040.020.02 query40 0.160.130.13 query41 0.080.030.02 query42 0.040.020.03 query43 0.040.030.02 Total cold run time: 105.18 s Total hot run time: 30.9 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
doris-robot commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2606203668 TPC-DS: Total hot run time: 188210 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit a783a59232f8054169d663bbc2925fdcf9b9274c, data reload: false query1 977 374 381 374 query2 6527205619541954 query3 6783223 217 217 query4 33471 23798 23286 23286 query5 4324614 436 436 query6 266 186 205 186 query7 4605493 309 309 query8 293 232 213 213 query9 9639258325792579 query10 476 314 266 266 query11 18038 15312 15314 15312 query12 156 107 102 102 query13 1641502 382 382 query14 9134760375687568 query15 272 196 190 190 query16 8038626 475 475 query17 1633757 563 563 query18 2059396 305 305 query19 219 185 157 157 query20 116 110 119 110 query21 215 123 103 103 query22 4379417340784078 query23 34085 32947 33119 32947 query24 6448231323722313 query25 535 520 376 376 query26 1191276 153 153 query27 1993462 334 334 query28 5385240623972397 query29 717 548 407 407 query30 232 187 159 159 query31 950 900 792 792 query32 85 64 59 59 query33 522 368 301 301 query34 813 838 507 507 query35 798 828 732 732 query36 10021017962 962 query37 117 103 79 79 query38 4146415840374037 query39 1456144116021441 query40 211 115 108 108 query41 54 51 53 51 query42 143 103 105 103 query43 514 504 491 491 query44 1305812 813 812 query45 178 181 162 162 query46 861 1057640 640 query47 1813185017751775 query48 378 396 311 311 query49 791 479 395 395 query50 621 661 377 377 query51 7026694966456645 query52 102 106 95 95 query53 222 249 183 183 query54 497 485 426 426 query55 87 80 81 80 query56 289 261 259 259 query57 1159115310701070 query58 250 229 257 229 query59 3085306028822882 query60 273 262 244 244 query61 121 117 113 113 query62 816 724 647 647 query63 227 191 190 190 query64 44361010646 646 query65 3239322731643164 query66 1083415 314 314 query67 16213 15667 15519 15519 query68 4725832 535 535 query69 467 296 267 267 query70 1184110611121106 query71 399 281 271 271 query72 5804384738283828 query73 648 755 367 367 query74 10288 923287958795 query75 3242317326442644 query76 32131178771 771 query77 457 380 284 284 query78 995310077 93849384 query79 2895792 607 607 query80 662 528 422 422 query81 506 280 237 237 query82 223 151 123 123 query83 178 173 150 150 query84 247 101 69 69 query85 738 412 312 312 query86 400 325 292 292 query87 4564454044014401 query88 5104215021002100 query89 395 335 304 304 query90 2003188 188 188 query91 130 134 105 105 query92 67 60 59 59 query93 2362896 523 523 query94 664 415 293 293 query95 326 267 253 253 query96 494 622 280 280 query97 2760287526992699 query98 239 202 205 202 query99 1305134812471247 Total cold run time: 286372 ms Total hot run time: 188210 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
doris-robot commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2606192962 TPC-H: Total hot run time: 32409 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit a783a59232f8054169d663bbc2925fdcf9b9274c, data reload: false -- Round 1 -- q1 17608 565154415441 q2 2050303 171 171 q3 10565 1280743 743 q4 10294 977 535 535 q5 8757244821712171 q6 198 166 137 137 q7 906 773 622 622 q8 9235137712381238 q9 5313490848484848 q10 6834235518831883 q11 481 281 267 267 q12 352 365 224 224 q13 17774 375831003100 q14 239 224 218 218 q15 512 476 462 462 q16 627 605 587 587 q17 586 875 326 326 q18 7101651963926392 q19 3137965 538 538 q20 309 328 190 190 q21 2946225920032003 q22 369 335 313 313 Total cold run time: 106193 ms Total hot run time: 32409 ms - Round 2, with runtime_filter_mode=off - q1 5655545955025459 q2 247 343 243 243 q3 2275267723442344 q4 1427182814091409 q5 4314479849324798 q6 183 162 131 131 q7 2059204718221822 q8 2632276927382738 q9 7261719571767176 q10 3006329628192819 q11 582 520 485 485 q12 677 789 613 613 q13 3576397032683268 q14 270 300 277 277 q15 514 489 458 458 q16 657 710 661 661 q17 1290174513041304 q18 7646746173487348 q19 821 117610481048 q20 2025211018801880 q21 5767529349024902 q22 625 598 575 575 Total cold run time: 53509 ms Total hot run time: 51758 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
LiBinfeng-01 commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2606170022 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
LiBinfeng-01 commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2560791949 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
LiBinfeng-01 commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2560786934 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
morrySnow commented on code in PR #44755:
URL: https://github.com/apache/doris/pull/44755#discussion_r1889578249
##
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##
@@ -770,41 +770,38 @@ public LogicalPlan
visitCreateScheduledJob(DorisParser.CreateScheduledJobContext
return new CreateJobCommand(createJobInfo);
}
+private void checkJobNameKey(String key, String keyFormat) {
+if (key.isEmpty() || !key.equalsIgnoreCase(keyFormat)) {
Review Comment:
why add key.isEmpty()?
##
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##
@@ -770,41 +770,38 @@ public LogicalPlan
visitCreateScheduledJob(DorisParser.CreateScheduledJobContext
return new CreateJobCommand(createJobInfo);
}
+private void checkJobNameKey(String key, String keyFormat) {
+if (key.isEmpty() || !key.equalsIgnoreCase(keyFormat)) {
+throw new ParseException(keyFormat + " should be: '" + keyFormat +
"'");
Review Comment:
error message is not very clear, we should use ParseException with Origin,
or different statement use different error message to let user could know the
error reason easily
##
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##
@@ -770,41 +770,38 @@ public LogicalPlan
visitCreateScheduledJob(DorisParser.CreateScheduledJobContext
return new CreateJobCommand(createJobInfo);
}
+private void checkJobNameKey(String key, String keyFormat) {
+if (key.isEmpty() || !key.equalsIgnoreCase(keyFormat)) {
+throw new ParseException(keyFormat + " should be: '" + keyFormat +
"'");
+}
+}
+
@Override
public LogicalPlan visitPauseJob(DorisParser.PauseJobContext ctx) {
-Expression wildWhere = null;
-if (ctx.wildWhere() != null) {
-wildWhere = getWildWhere(ctx.wildWhere());
-}
-return new PauseJobCommand(wildWhere);
+checkJobNameKey(stripQuotes(ctx.jobNameKey.getText()), "jobName");
+return new PauseJobCommand(stripQuotes(ctx.jobNameValue.getText()));
}
@Override
public LogicalPlan visitDropJob(DorisParser.DropJobContext ctx) {
-Expression wildWhere = null;
-if (ctx.wildWhere() != null) {
-wildWhere = getWildWhere(ctx.wildWhere());
-}
+checkJobNameKey(stripQuotes(ctx.jobNameKey.getText()), "jobName");
boolean ifExists = ctx.EXISTS() != null;
-return new DropJobCommand(wildWhere, ifExists);
+return new DropJobCommand(stripQuotes(ctx.jobNameValue.getText()),
ifExists);
}
@Override
public LogicalPlan visitResumeJob(DorisParser.ResumeJobContext ctx) {
-Expression wildWhere = null;
-if (ctx.wildWhere() != null) {
-wildWhere = getWildWhere(ctx.wildWhere());
-}
-return new ResumeJobCommand(wildWhere);
+checkJobNameKey(stripQuotes(ctx.jobNameKey.getText()), "jobName");
+return new ResumeJobCommand(stripQuotes(ctx.jobNameValue.getText()));
}
@Override
public LogicalPlan visitCancelJobTask(DorisParser.CancelJobTaskContext
ctx) {
-Expression wildWhere = null;
-if (ctx.wildWhere() != null) {
-wildWhere = getWildWhere(ctx.wildWhere());
-}
-return new CancelJobTaskCommand(wildWhere);
+checkJobNameKey(stripQuotes(ctx.jobNameKey.getText()), "jobName");
+checkJobNameKey(stripQuotes(ctx.taskIdKey.getText()), "taskId");
Review Comment:
i don't think must write jobName before taskId is a good idea. since we use
where here, we should support `jobName = xxx and taskId = xx` and `taskId = xx
and jobName = xxx`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
LiBinfeng-01 commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2547971360 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
doris-robot commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2540447076 ClickBench: Total hot run time: 32.4 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 6022e5c5a00b647192f2f56bd283325dfde102c8, data reload: false query1 0.040.030.05 query2 0.080.040.03 query3 0.230.070.07 query4 1.610.100.10 query5 0.420.400.42 query6 1.140.650.66 query7 0.020.020.01 query8 0.040.030.03 query9 0.580.520.51 query10 0.550.590.55 query11 0.140.110.10 query12 0.140.100.11 query13 0.600.610.60 query14 2.672.712.84 query15 0.890.820.82 query16 0.390.390.40 query17 1.061.081.06 query18 0.230.220.21 query19 1.881.731.94 query20 0.020.010.02 query21 15.39 0.600.61 query22 2.622.521.76 query23 17.13 1.060.74 query24 2.681.261.03 query25 0.170.160.07 query26 0.570.140.12 query27 0.050.050.04 query28 10.70 1.091.06 query29 12.58 3.223.25 query30 0.250.060.06 query31 2.880.380.38 query32 3.300.450.46 query33 3.013.093.07 query34 17.32 4.464.44 query35 4.564.474.51 query36 0.660.490.48 query37 0.100.060.06 query38 0.040.040.03 query39 0.030.020.03 query40 0.170.130.12 query41 0.080.030.02 query42 0.040.020.02 query43 0.040.030.03 Total cold run time: 107.1 s Total hot run time: 32.4 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
doris-robot commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2540441848 TPC-DS: Total hot run time: 196128 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 6022e5c5a00b647192f2f56bd283325dfde102c8, data reload: false query1 12641026929 929 query2 6225213820372037 query3 10998 423443454234 query4 66707 29288 23529 23529 query5 4908439 469 439 query6 425 186 175 175 query7 5656309 299 299 query8 332 244 234 234 query9 9325272127162716 query10 459 252 255 252 query11 17202 15033 15779 15033 query12 161 105 103 103 query13 1553447 428 428 query14 10416 663372066633 query15 226 191 197 191 query16 7117467 429 429 query17 1252590 575 575 query18 1867305 301 301 query19 192 151 165 151 query20 124 112 120 112 query21 210 102 102 102 query22 4705456245614561 query23 34449 34103 34135 34103 query24 5540252425062506 query25 485 389 394 389 query26 658 152 155 152 query27 1868285 297 285 query28 4470250725082507 query29 663 422 413 413 query30 209 157 158 157 query31 993 848 862 848 query32 61 54 52 52 query33 410 280 294 280 query34 977 524 533 524 query35 844 771 737 737 query36 1085946 989 946 query37 122 75 71 71 query38 4388430244964302 query39 1501146714411441 query40 201 99 96 96 query41 43 44 42 42 query42 108 97 95 95 query43 551 500 505 500 query44 1212877 840 840 query45 183 172 162 162 query46 1159733 726 726 query47 1984190518741874 query48 430 320 329 320 query49 734 389 403 389 query50 849 409 401 401 query51 7445725471727172 query52 95 85 88 85 query53 257 186 177 177 query54 524 411 411 411 query55 80 76 73 73 query56 248 236 239 236 query57 1217113211051105 query58 215 208 226 208 query59 3430326832583258 query60 267 244 241 241 query61 104 110 104 104 query62 808 668 686 668 query63 216 187 197 187 query64 1354661 634 634 query65 3263323031733173 query66 705 292 299 292 query67 16061 15665 15619 15619 query68 3984592 561 561 query69 417 255 251 251 query70 1182110811281108 query71 365 249 257 249 query72 6420404740434043 query73 775 358 356 356 query74 10109 890190508901 query75 3442267828182678 query76 1830106011511060 query77 474 281 277 277 query78 10580 941296069412 query79 1343602 598 598 query80 851 435 441 435 query81 489 225 227 225 query82 1218119 113 113 query83 254 138 134 134 query84 276 76 69 69 query85 862 308 306 306 query86 336 306 303 303 query87 45594819 query88 3452220521942194 query89 420 293 291 291 query90 2001190 185 185 query91 139 118 107 107 query92 72 47 54 47 query93 1598550 559 550 query94 828 300 287 287 query95 352 249 251 249 query96 608 276 286 276 query97 2865267126772671 query98 233 193 200 193 query99 1584132012911291 Total cold run time: 317708 ms Total hot run time: 196128 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
doris-robot commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2540430344 TPC-H: Total hot run time: 39880 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 6022e5c5a00b647192f2f56bd283325dfde102c8, data reload: false -- Round 1 -- q1 17566 742972117211 q2 2042180 165 165 q3 10600 106011991060 q4 10573 763 773 763 q5 7563267926322632 q6 235 145 143 143 q7 981 613 606 606 q8 9452185919381859 q9 6582641964546419 q10 6979230123222301 q11 461 248 261 248 q12 434 226 224 224 q13 17767 305530203020 q14 239 215 204 204 q15 565 516 521 516 q16 641 580 598 580 q17 968 515 546 515 q18 7284684868196819 q19 1350947 917 917 q20 467 180 180 180 q21 3996349031853185 q22 381 324 313 313 Total cold run time: 107126 ms Total hot run time: 39880 ms - Round 2, with runtime_filter_mode=off - q1 7193719872007198 q2 325 229 233 229 q3 2876279629252796 q4 2111177217351735 q5 5648565556385638 q6 223 137 139 137 q7 2271183918601839 q8 3380355734773477 q9 8878907990059005 q10 3569352835353528 q11 604 505 506 505 q12 852 609 598 598 q13 11634 325132613251 q14 300 284 281 281 q15 586 516 531 516 q16 680 639 645 639 q17 1851162216101610 q18 8371775677187718 q19 2293155716201557 q20 2084186418691864 q21 5682544855255448 q22 634 565 580 565 Total cold run time: 72045 ms Total hot run time: 60134 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
LiBinfeng-01 commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2540385252 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
LiBinfeng-01 commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2538198282 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
doris-robot commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2534186137 ClickBench: Total hot run time: 31.59 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit c32dabf8f29b5036de748bf9afe6d7add2249863, data reload: false query1 0.030.030.04 query2 0.070.030.04 query3 0.240.070.07 query4 1.630.100.10 query5 0.430.420.39 query6 1.150.670.65 query7 0.030.020.01 query8 0.040.030.03 query9 0.570.500.51 query10 0.550.590.56 query11 0.140.110.10 query12 0.140.110.12 query13 0.610.610.61 query14 2.712.802.76 query15 0.920.820.82 query16 0.390.380.38 query17 1.041.050.99 query18 0.230.220.22 query19 1.881.832.02 query20 0.010.010.01 query21 15.35 0.600.58 query22 2.672.661.44 query23 16.81 1.290.86 query24 3.201.790.37 query25 0.170.210.16 query26 0.580.130.14 query27 0.050.040.04 query28 10.62 1.101.07 query29 12.50 3.233.17 query30 0.250.060.06 query31 2.860.380.36 query32 3.280.460.48 query33 2.973.203.01 query34 17.01 4.414.44 query35 4.524.474.48 query36 0.660.490.49 query37 0.090.060.06 query38 0.050.040.04 query39 0.030.020.03 query40 0.160.130.12 query41 0.080.020.03 query42 0.030.020.02 query43 0.040.030.03 Total cold run time: 106.79 s Total hot run time: 31.59 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
doris-robot commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2534119695 TPC-DS: Total hot run time: 196157 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit c32dabf8f29b5036de748bf9afe6d7add2249863, data reload: false query1 1286946 957 946 query2 6237201820712018 query3 10987 440544564405 query4 33056 23448 23378 23378 query5 3556450 434 434 query6 272 172 169 169 query7 3977308 298 298 query8 298 241 239 239 query9 9363271327132713 query10 465 241 245 241 query11 17783 15173 15296 15173 query12 137 98 102 98 query13 1561414 410 410 query14 9036757368036803 query15 273 227 200 200 query16 8200510 494 494 query17 1676634 591 591 query18 2164312 320 312 query19 398 165 171 165 query20 126 118 115 115 query21 220 107 114 107 query22 4675467746264626 query23 35053 34021 33977 33977 query24 10481 247125372471 query25 599 377 416 377 query26 1157148 153 148 query27 2698273 283 273 query28 7922250825172508 query29 826 427 426 426 query30 238 152 157 152 query31 1055829 897 829 query32 96 54 55 54 query33 799 303 315 303 query34 1098509 512 509 query35 948 763 772 763 query36 1131954 962 954 query37 139 71 72 71 query38 4486449243534353 query39 1520147414391439 query40 200 126 96 96 query41 44 43 45 43 query42 112 97 96 96 query43 528 508 493 493 query44 1286817 827 817 query45 191 179 171 171 query46 1196763 714 714 query47 2031195019141914 query48 428 331 349 331 query49 962 392 391 391 query50 847 384 397 384 query51 7475735872737273 query52 100 87 93 87 query53 258 185 191 185 query54 1309407 416 407 query55 100 74 78 74 query56 261 224 237 224 query57 1266107111131071 query58 228 218 205 205 query59 3396294829382938 query60 264 245 250 245 query61 107 106 108 106 query62 875 683 671 671 query63 211 189 181 181 query64 4994661 708 661 query65 3272317131893171 query66 1394302 297 297 query67 15992 15637 15513 15513 query68 4903550 533 533 query69 429 251 245 245 query70 1215112411641124 query71 333 256 246 246 query72 6341400039973997 query73 772 353 357 353 query74 10090 890189998901 query75 3414261926932619 query76 2641116111221122 query77 375 271 260 260 query78 10401 960994399439 query79 2226590 614 590 query80 1070416 420 416 query81 546 237 239 237 query82 843 120 120 120 query83 225 140 142 140 query84 236 72 69 69 query85 1457305 297 297 query86 456 296 309 296 query87 4794458045864580 query88 3559225921802180 query89 427 290 282 282 query90 1997186 184 184 query91 133 104 100 100 query92 65 46 48 46 query93 2188531 532 531 query94 953 279 283 279 query95 357 242 252 242 query96 630 280 286 280 query97 2859264926232623 query98 223 188 192 188 query99 1549133713541337 Total cold run time: 303026 ms Total hot run time: 196157 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
doris-robot commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2533973182 TPC-H: Total hot run time: 39707 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit c32dabf8f29b5036de748bf9afe6d7add2249863, data reload: false -- Round 1 -- q1 17590 744772467246 q2 2050173 162 162 q3 10608 110211711102 q4 10573 736 700 700 q5 7589267827022678 q6 240 146 145 145 q7 995 631 596 596 q8 9255182418971824 q9 6603649964496449 q10 7033231122622262 q11 475 253 258 253 q12 424 234 223 223 q13 17797 298630252986 q14 243 221 214 214 q15 567 536 505 505 q16 685 577 577 577 q17 969 570 560 560 q18 7145659065376537 q19 1339990 929 929 q20 472 185 173 173 q21 4264328233233282 q22 377 304 310 304 Total cold run time: 107293 ms Total hot run time: 39707 ms - Round 2, with runtime_filter_mode=off - q1 7245720171977197 q2 336 231 230 230 q3 2859281229172812 q4 2109178718281787 q5 5730565956585658 q6 224 139 139 139 q7 2310180218381802 q8 3376352834953495 q9 8898901989928992 q10 3592355135303530 q11 606 510 502 502 q12 816 603 615 603 q13 12103 325932443244 q14 303 269 284 269 q15 579 516 519 516 q16 709 638 656 638 q17 1851164116191619 q18 8171766076177617 q19 2354155215861552 q20 2086194319071907 q21 5730553255155515 q22 640 556 564 556 Total cold run time: 72627 ms Total hot run time: 60180 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
morrySnow commented on code in PR #44755:
URL: https://github.com/apache/doris/pull/44755#discussion_r1879462882
##
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##
@@ -772,39 +772,25 @@ public LogicalPlan
visitCreateScheduledJob(DorisParser.CreateScheduledJobContext
@Override
public LogicalPlan visitPauseJob(DorisParser.PauseJobContext ctx) {
-Expression wildWhere = null;
-if (ctx.wildWhere() != null) {
-wildWhere = getWildWhere(ctx.wildWhere());
-}
-return new PauseJobCommand(wildWhere);
+return new PauseJobCommand(stripQuotes(ctx.jobNameValue.getText()));
Review Comment:
so we do not check jobNameKey?
##
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##
@@ -772,39 +772,25 @@ public LogicalPlan
visitCreateScheduledJob(DorisParser.CreateScheduledJobContext
@Override
public LogicalPlan visitPauseJob(DorisParser.PauseJobContext ctx) {
-Expression wildWhere = null;
-if (ctx.wildWhere() != null) {
-wildWhere = getWildWhere(ctx.wildWhere());
-}
-return new PauseJobCommand(wildWhere);
+return new PauseJobCommand(stripQuotes(ctx.jobNameValue.getText()));
}
@Override
public LogicalPlan visitDropJob(DorisParser.DropJobContext ctx) {
-Expression wildWhere = null;
-if (ctx.wildWhere() != null) {
-wildWhere = getWildWhere(ctx.wildWhere());
-}
boolean ifExists = ctx.EXISTS() != null;
-return new DropJobCommand(wildWhere, ifExists);
+return new DropJobCommand(stripQuotes(ctx.jobNameValue.getText()),
ifExists);
}
@Override
public LogicalPlan visitResumeJob(DorisParser.ResumeJobContext ctx) {
-Expression wildWhere = null;
-if (ctx.wildWhere() != null) {
-wildWhere = getWildWhere(ctx.wildWhere());
-}
-return new ResumeJobCommand(wildWhere);
+return new ResumeJobCommand(stripQuotes(ctx.jobNameValue.getText()));
}
@Override
public LogicalPlan visitCancelJobTask(DorisParser.CancelJobTaskContext
ctx) {
-Expression wildWhere = null;
-if (ctx.wildWhere() != null) {
-wildWhere = getWildWhere(ctx.wildWhere());
-}
-return new CancelJobTaskCommand(wildWhere);
+String jobName = stripQuotes(ctx.jobNameValue.getText());
+Long taskId = Long.valueOf(ctx.taskIdValue.getText());
Review Comment:
what will happen if sql like `cancel task where task_id = '123' and job_name
= 123`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
LiBinfeng-01 commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2533758958 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
doris-robot commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2531112283 ClickBench: Total hot run time: 33.37 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 1f92321d8079a4d6f13a0b11b981af3fd47f8323, data reload: false query1 0.040.030.03 query2 0.060.030.03 query3 0.230.080.07 query4 1.590.100.10 query5 0.430.390.41 query6 1.170.650.65 query7 0.020.010.01 query8 0.040.030.04 query9 0.580.510.51 query10 0.560.550.56 query11 0.130.100.11 query12 0.130.110.11 query13 0.600.600.60 query14 2.802.822.70 query15 0.900.820.83 query16 0.400.390.38 query17 1.041.050.98 query18 0.230.210.22 query19 1.961.842.03 query20 0.010.020.01 query21 15.36 0.600.60 query22 2.302.532.37 query23 17.32 0.840.80 query24 3.451.261.22 query25 0.320.210.25 query26 0.440.140.13 query27 0.030.040.04 query28 10.07 1.101.06 query29 12.60 3.273.28 query30 0.240.060.06 query31 2.860.390.37 query32 3.280.460.46 query33 2.993.033.03 query34 17.01 4.434.46 query35 4.534.424.49 query36 0.660.480.48 query37 0.090.060.06 query38 0.050.040.03 query39 0.040.020.02 query40 0.170.130.14 query41 0.070.020.03 query42 0.040.020.02 query43 0.040.030.02 Total cold run time: 106.88 s Total hot run time: 33.37 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
doris-robot commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2531096471 TPC-DS: Total hot run time: 189460 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 1f92321d8079a4d6f13a0b11b981af3fd47f8323, data reload: false query1 960 384 370 370 query2 6521207220162016 query3 6711216 212 212 query4 34060 23637 23450 23450 query5 4398458 440 440 query6 282 180 202 180 query7 4646291 311 291 query8 299 243 214 214 query9 9751266926912669 query10 467 243 242 242 query11 18235 15245 15177 15177 query12 147 99 105 99 query13 1640396 377 377 query14 9625641863726372 query15 254 172 182 172 query16 8042469 431 431 query17 1617571 546 546 query18 2113297 300 297 query19 233 159 155 155 query20 120 111 118 111 query21 213 102 102 102 query22 4384439743424342 query23 34811 33790 34342 33790 query24 11329 242725762427 query25 692 407 395 395 query26 1751154 155 154 query27 2933281 287 281 query28 8071243824322432 query29 1028421 442 421 query30 303 149 148 148 query31 1015826 833 826 query32 97 54 56 54 query33 772 285 284 284 query34 1004491 514 491 query35 888 806 753 753 query36 1122955 923 923 query37 162 79 70 70 query38 4364417742244177 query39 1468140014281400 query40 286 99 96 96 query41 47 42 43 42 query42 111 96 98 96 query43 527 486 488 486 query44 1299817 798 798 query45 187 162 173 162 query46 1153708 704 704 query47 1966188618691869 query48 394 303 327 303 query49 1262378 380 378 query50 807 387 370 370 query51 7339713469956995 query52 99 90 91 90 query53 254 185 180 180 query54 1195402 395 395 query55 79 75 73 73 query56 264 228 248 228 query57 1239109911491099 query58 235 214 210 210 query59 3287287329912873 query60 260 255 240 240 query61 113 106 111 106 query62 909 669 662 662 query63 215 187 182 182 query64 5234647 619 619 query65 3285319032923190 query66 1429294 310 294 query67 15915 15794 15751 15751 query68 4949539 527 527 query69 429 251 265 251 query70 1240107811311078 query71 335 251 243 243 query72 6419402538773877 query73 765 351 363 351 query74 10444 909490249024 query75 3451266026452645 query76 2915108310651065 query77 426 261 263 261 query78 10380 939194479391 query79 1616592 586 586 query80 1090427 419 419 query81 518 239 235 235 query82 937 120 166 120 query83 240 142 145 142 query84 232 71 71 71 query85 1308294 295 294 query86 363 303 304 303 query87 4740459045294529 query88 3504219621662166 query89 402 289 292 289 query90 2063188 183 183 query91 138 101 103 101 query92 57 51 54 51 query93 1094568 522 522 query94 1043291 294 291 query95 341 240 243 240 query96 610 287 274 274 query97 2843265326522652 query98 223 191 188 188 query99 1559130913111309 Total cold run time: 302592 ms Total hot run time: 189460 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
doris-robot commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2531063517 TPC-H: Total hot run time: 39688 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 1f92321d8079a4d6f13a0b11b981af3fd47f8323, data reload: false -- Round 1 -- q1 17572 745072487248 q2 2055180 166 166 q3 10551 114211221122 q4 10230 745 688 688 q5 7614264726342634 q6 236 147 145 145 q7 993 623 616 616 q8 9262185319411853 q9 6726650864416441 q10 6966227823042278 q11 456 264 249 249 q12 402 216 224 216 q13 17772 306630453045 q14 245 202 214 202 q15 569 534 528 528 q16 633 583 603 583 q17 982 599 530 530 q18 7405666166146614 q19 1335999 927 927 q20 473 180 178 178 q21 4175331731023102 q22 391 323 327 323 Total cold run time: 107043 ms Total hot run time: 39688 ms - Round 2, with runtime_filter_mode=off - q1 7243726672077207 q2 335 232 232 232 q3 2902276029452760 q4 2116185518281828 q5 5533565556195619 q6 221 140 138 138 q7 2223179118081791 q8 3352357034873487 q9 8992898189618961 q10 3613357035323532 q11 621 509 496 496 q12 830 626 592 592 q13 12805 327132063206 q14 296 268 273 268 q15 573 525 529 525 q16 670 615 623 615 q17 1774156615651565 q18 7862745874277427 q19 1647155915681559 q20 2028184017941794 q21 5418517652195176 q22 633 588 588 588 Total cold run time: 71687 ms Total hot run time: 59366 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
LiBinfeng-01 commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2531017790 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
doris-robot commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2519025847 ClickBench: Total hot run time: 32.34 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 1941723cb7d4adf1b62f0731847cd492e1db01b6, data reload: false query1 0.030.030.03 query2 0.070.030.04 query3 0.240.080.07 query4 1.610.100.11 query5 0.420.420.38 query6 1.170.650.66 query7 0.020.020.02 query8 0.030.040.03 query9 0.570.500.52 query10 0.560.550.54 query11 0.140.100.10 query12 0.160.120.11 query13 0.610.610.60 query14 2.742.742.78 query15 0.900.830.83 query16 0.380.400.40 query17 1.091.061.01 query18 0.230.210.21 query19 1.932.061.91 query20 0.020.010.01 query21 15.35 0.560.56 query22 2.391.721.79 query23 17.25 0.940.86 query24 3.221.600.65 query25 0.280.050.07 query26 0.470.150.14 query27 0.070.040.04 query28 10.54 1.101.09 query29 12.58 3.223.25 query30 0.260.070.07 query31 2.860.390.40 query32 3.240.460.46 query33 3.013.053.04 query34 17.10 4.494.50 query35 4.504.594.49 query36 0.670.480.49 query37 0.090.060.06 query38 0.050.040.04 query39 0.030.020.03 query40 0.170.140.13 query41 0.080.020.02 query42 0.040.020.03 query43 0.040.030.03 Total cold run time: 107.21 s Total hot run time: 32.34 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
doris-robot commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2519020761 TPC-DS: Total hot run time: 191123 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 1941723cb7d4adf1b62f0731847cd492e1db01b6, data reload: false query1 1196390 390 390 query2 6537208219741974 query3 6711213 214 213 query4 34014 23927 23453 23453 query5 4398463 454 454 query6 302 196 188 188 query7 4631294 299 294 query8 314 250 221 221 query9 9466268726872687 query10 468 242 241 241 query11 18176 15187 15277 15187 query12 151 104 99 99 query13 1648403 386 386 query14 10157 726774367267 query15 270 180 177 177 query16 7624492 477 477 query17 1691595 578 578 query18 1483307 321 307 query19 368 150 152 150 query20 114 108 107 107 query21 209 99 99 99 query22 4605438742144214 query23 34966 34061 34282 34061 query24 10356 237924702379 query25 631 371 376 371 query26 1220152 151 151 query27 2612289 280 280 query28 7797244524362436 query29 791 396 411 396 query30 292 151 150 150 query31 1045813 827 813 query32 90 55 55 55 query33 758 328 285 285 query34 934 503 524 503 query35 847 753 741 741 query36 1092938 963 938 query37 148 76 73 73 query38 4408419241894189 query39 1479147014101410 query40 198 101 97 97 query41 46 42 43 42 query42 110 101 104 101 query43 538 507 476 476 query44 1270802 790 790 query45 192 173 163 163 query46 1149678 707 678 query47 1931187618361836 query48 394 317 313 313 query49 1157413 381 381 query50 812 383 377 377 query51 7226694869856948 query52 97 90 87 87 query53 255 181 179 179 query54 1116394 415 394 query55 82 79 79 79 query56 278 249 263 249 query57 1249113011041104 query58 236 231 241 231 query59 3117294930242949 query60 301 250 250 250 query61 111 109 109 109 query62 870 679 683 679 query63 222 187 181 181 query64 4593688 640 640 query65 3330321332353213 query66 1347318 319 318 query67 16000 15698 15665 15665 query68 4067568 560 560 query69 415 251 242 242 query70 1200115211571152 query71 326 258 244 244 query72 6456434242124212 query73 776 363 371 363 query74 10069 909689008900 query75 3392261626502616 query76 2678108910971089 query77 446 265 289 265 query78 10339 947695719476 query79 2551605 616 605 query80 1149429 518 429 query81 541 245 229 229 query82 680 116 113 113 query83 246 143 141 141 query84 236 67 75 67 query85 1497308 299 299 query86 458 304 300 300 query87 4720451147014511 query88 3959223521872187 query89 411 308 297 297 query90 2102188 182 182 query91 145 105 111 105 query92 67 52 53 52 query93 1445545 545 545 query94 985 283 280 280 query95 343 252 250 250 query96 615 275 291 275 query97 2828272327042704 query98 263 191 191 191 query99 1597131913571319 Total cold run time: 299228 ms Total hot run time: 191123 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
doris-robot commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2519010126 TPC-H: Total hot run time: 40163 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 1941723cb7d4adf1b62f0731847cd492e1db01b6, data reload: false -- Round 1 -- q1 17713 746873097309 q2 2096185 172 172 q3 10691 113012281130 q4 10422 769 693 693 q5 7597276727562756 q6 238 149 157 149 q7 1022672 622 622 q8 9260186619681866 q9 6676651665196516 q10 7045228422832283 q11 472 266 258 258 q12 413 222 230 222 q13 17768 308430833083 q14 254 217 214 214 q15 565 540 521 521 q16 659 593 590 590 q17 989 534 586 534 q18 7517668866056605 q19 1363101010551010 q20 475 180 186 180 q21 4153314233983142 q22 382 308 318 308 Total cold run time: 107770 ms Total hot run time: 40163 ms - Round 2, with runtime_filter_mode=off - q1 7361728672827282 q2 323 228 233 228 q3 2934292931142929 q4 2130181518331815 q5 5582572556455645 q6 223 142 143 142 q7 180218471802 q8 3390350135383501 q9 8990903291109032 q10 3600357935313531 q11 595 505 525 505 q12 816 625 608 608 q13 12280 315932303159 q14 304 275 255 255 q15 558 519 509 509 q16 674 626 629 626 q17 1828160215561556 q18 7764750372997299 q19 1656148515691485 q20 2068180918231809 q21 5483527053255270 q22 628 560 559 559 Total cold run time: 71409 ms Total hot run time: 59547 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
LiBinfeng-01 commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2518985612 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
CalvinKirs commented on code in PR #44755:
URL: https://github.com/apache/doris/pull/44755#discussion_r1868806172
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/CancelJobTaskCommand.java:
##
@@ -59,36 +44,9 @@ public R accept(PlanVisitor visitor, C context)
{
@Override
public void run(ConnectContext ctx, StmtExecutor executor) throws
Exception {
-validate();
Review Comment:
Did we miss the permission check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
LiBinfeng-01 commented on code in PR #44755:
URL: https://github.com/apache/doris/pull/44755#discussion_r1868814111
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/CancelJobTaskCommand.java:
##
@@ -59,36 +44,9 @@ public R accept(PlanVisitor visitor, C context)
{
@Override
public void run(ConnectContext ctx, StmtExecutor executor) throws
Exception {
-validate();
Review Comment:
yes, mistoken delete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
doris-robot commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2516170793 ClickBench: Total hot run time: 32.78 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 5feed090d94b480e6db76d73aa2ac26a3e5f2260, data reload: false query1 0.040.030.02 query2 0.070.030.03 query3 0.230.070.07 query4 1.630.110.10 query5 0.410.390.42 query6 1.160.650.65 query7 0.020.020.02 query8 0.040.030.04 query9 0.580.510.53 query10 0.560.550.56 query11 0.140.100.11 query12 0.140.110.11 query13 0.600.610.60 query14 2.822.882.82 query15 0.900.830.84 query16 0.380.380.37 query17 1.051.011.08 query18 0.230.210.21 query19 1.981.892.00 query20 0.010.010.01 query21 15.38 0.570.60 query22 2.702.241.66 query23 17.27 0.850.76 query24 3.211.291.59 query25 0.350.120.08 query26 0.520.130.14 query27 0.040.040.04 query28 9.811.101.09 query29 12.54 3.203.23 query30 0.250.070.07 query31 2.870.400.38 query32 3.270.470.46 query33 3.043.013.04 query34 17.10 4.454.42 query35 4.534.524.52 query36 0.660.500.49 query37 0.090.060.05 query38 0.050.030.03 query39 0.030.020.02 query40 0.170.130.12 query41 0.070.020.02 query42 0.030.020.02 query43 0.030.040.03 Total cold run time: 107 s Total hot run time: 32.78 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
doris-robot commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2516165762 TPC-DS: Total hot run time: 197336 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 5feed090d94b480e6db76d73aa2ac26a3e5f2260, data reload: false query1 1264956 965 956 query2 6258205120702051 query3 10938 436946034369 query4 67377 28543 23548 23548 query5 5001470 444 444 query6 403 188 189 188 query7 5520307 298 298 query8 314 225 224 224 query9 8727273727182718 query10 450 248 248 248 query11 16933 15169 16017 15169 query12 163 108 105 105 query13 1444459 443 443 query14 9801725775037257 query15 229 199 190 190 query16 7132488 500 488 query17 1071580 613 580 query18 1832349 322 322 query19 205 165 163 163 query20 122 112 112 112 query21 216 146 102 102 query22 4697468245444544 query23 34635 34334 34495 34334 query24 5516253924432443 query25 506 384 379 379 query26 676 156 148 148 query27 2164283 289 283 query28 4506253324882488 query29 681 429 414 414 query30 211 144 147 144 query31 1004834 836 834 query32 68 60 55 55 query33 398 292 290 290 query34 924 516 539 516 query35 907 776 771 771 query36 1092963 969 963 query37 128 76 73 73 query38 454342554255 query39 1669146715051467 query40 205 102 98 98 query41 48 44 43 43 query42 119 104 100 100 query43 555 509 501 501 query44 1179852 844 844 query45 195 169 170 169 query46 1198741 748 741 query47 2050193119301930 query48 429 331 362 331 query49 747 397 400 397 query50 877 401 406 401 query51 7435724071287128 query52 99 85 87 85 query53 258 183 178 178 query54 507 396 397 396 query55 79 79 75 75 query56 247 241 240 240 query57 1218113911101110 query58 205 209 220 209 query59 3200283929132839 query60 272 244 239 239 query61 110 106 104 104 query62 797 657 676 657 query63 212 189 189 189 query64 1414654 644 644 query65 3264325132843251 query66 663 299 303 299 query67 16083 15754 15857 15754 query68 3765580 581 580 query69 447 250 240 240 query70 1170112911231123 query71 336 250 257 250 query72 6413404440684044 query73 776 357 357 357 query74 10301 888790418887 query75 3408264626742646 query76 1872110810761076 query77 487 278 272 272 query78 10542 949894509450 query79 2132613 610 610 query80 1383428 422 422 query81 503 247 237 237 query82 1125124 118 118 query83 168 152 157 152 query84 274 72 70 70 query85 1002298 361 298 query86 382 297 293 293 query87 4661453246644532 query88 3655223321802180 query89 422 297 292 292 query90 2008187 192 187 query91 132 103 111 103 query92 65 50 51 50 query93 2629542 540 540 query94 812 287 342 287 query95 338 252 251 251 query96 627 289 277 277 query97 2859270726732673 query98 213 204 194 194 query99 1601131713281317 Total cold run time: 319898 ms Total hot run time: 197336 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
doris-robot commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2516151537 TPC-H: Total hot run time: 40235 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 5feed090d94b480e6db76d73aa2ac26a3e5f2260, data reload: false -- Round 1 -- q1 17579 746073147314 q2 2041183 170 170 q3 10558 109311691093 q4 10449 723 689 689 q5 7635271227442712 q6 248 151 149 149 q7 997 631 599 599 q8 9250185718661857 q9 6731656765646564 q10 7051233123792331 q11 467 283 269 269 q12 432 226 223 223 q13 17781 306129892989 q14 260 212 212 212 q15 587 547 535 535 q16 650 567 579 567 q17 1003586 571 571 q18 7344675967876759 q19 1343972 927 927 q20 462 178 182 178 q21 4290323732253225 q22 387 325 302 302 Total cold run time: 107545 ms Total hot run time: 40235 ms - Round 2, with runtime_filter_mode=off - q1 7229728472317231 q2 330 243 234 234 q3 2927288628942886 q4 2064180318171803 q5 5702567556805675 q6 229 143 147 143 q7 2241188317841784 q8 3447356935163516 q9 8996908290319031 q10 3619362435593559 q11 606 513 514 513 q12 813 582 609 582 q13 11529 327432093209 q14 307 296 275 275 q15 579 530 529 529 q16 705 641 643 641 q17 1879167116301630 q18 8258780075927592 q19 1715157116491571 q20 2082189518591859 q21 5622544454825444 q22 662 578 559 559 Total cold run time: 71541 ms Total hot run time: 60266 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
LiBinfeng-01 commented on code in PR #44755: URL: https://github.com/apache/doris/pull/44755#discussion_r1868642780 ## fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4: ## @@ -118,10 +118,10 @@ supportedJobStatement (AT (atTime=STRING_LITERAL | CURRENT_TIMESTAMP))) commentSpec? DO supportedDmlStatement #createScheduledJob - | PAUSE JOB wildWhere? #pauseJob - | DROP JOB (IF EXISTS)? wildWhere? #dropJob - | RESUME JOB wildWhere? #resumeJob - | CANCEL TASK wildWhere? #cancelJobTask + | PAUSE JOB WHERE (jobNameKey=STRING_LITERAL) EQ (jobNameValue=STRING_LITERAL) #pauseJob Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
LiBinfeng-01 commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2516051871 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
morrySnow commented on code in PR #44755: URL: https://github.com/apache/doris/pull/44755#discussion_r1867818156 ## fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4: ## @@ -118,10 +118,10 @@ supportedJobStatement (AT (atTime=STRING_LITERAL | CURRENT_TIMESTAMP))) commentSpec? DO supportedDmlStatement #createScheduledJob - | PAUSE JOB wildWhere? #pauseJob - | DROP JOB (IF EXISTS)? wildWhere? #dropJob - | RESUME JOB wildWhere? #resumeJob - | CANCEL TASK wildWhere? #cancelJobTask + | PAUSE JOB WHERE (jobNameKey=STRING_LITERAL) EQ (jobNameValue=STRING_LITERAL) #pauseJob Review Comment: jobNameKey is not a string literal. should be identifier -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
doris-robot commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2514581005 TPC-DS: Total hot run time: 191193 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 2816bc2db0afd9121be898f05e80ea8f8a47a207, data reload: false query1 977 377 362 362 query2 6516207320342034 query3 6706209 215 209 query4 33985 23556 23696 23556 query5 4342477 482 477 query6 285 194 193 193 query7 4620291 302 291 query8 298 236 230 230 query9 9513269426882688 query10 482 276 260 260 query11 18278 15242 15189 15189 query12 140 99 101 99 query13 1644399 411 399 query14 9122712271427122 query15 254 175 178 175 query16 8126430 460 430 query17 1610559 560 559 query18 2123281 285 281 query19 338 154 138 138 query20 113 119 107 107 query21 204 99 105 99 query22 4692446242824282 query23 35505 34306 34278 34278 query24 10562 240123682368 query25 636 383 376 376 query26 1468148 153 148 query27 2838276 266 266 query28 7985240724232407 query29 915 406 398 398 query30 294 148 152 148 query31 1000799 864 799 query32 96 61 57 57 query33 777 282 272 272 query34 985 502 515 502 query35 854 728 724 724 query36 1090905 959 905 query37 141 87 73 73 query38 4221413442114134 query39 1524142114211421 query40 276 97 98 97 query41 46 43 44 43 query42 110 104 96 96 query43 532 490 481 481 query44 1281795 791 791 query45 179 167 167 167 query46 1166708 715 708 query47 1961188918631863 query48 425 315 317 315 query49 1171400 392 392 query50 817 389 380 380 query51 7272720871947194 query52 99 98 87 87 query53 265 180 174 174 query54 1065403 401 401 query55 82 76 75 75 query56 260 223 240 223 query57 1272109511101095 query58 232 206 215 206 query59 3163301929302930 query60 268 242 270 242 query61 120 108 110 108 query62 866 676 683 676 query63 216 188 190 188 query64 5431761 733 733 query65 3311321232603212 query66 1312336 321 321 query67 16008 15813 15564 15564 query68 4903548 535 535 query69 413 249 251 249 query70 11621113 query71 319 265 268 265 query72 6462412241114111 query73 762 352 352 352 query74 10070 896089998960 query75 3397267226742672 query76 2758995 1033995 query77 392 274 339 274 query78 10378 952495029502 query79 2488592 602 592 query80 1198474 423 423 query81 529 228 229 228 query82 928 126 120 120 query83 236 146 143 143 query84 235 68 67 67 query85 1254298 300 298 query86 416 291 294 291 query87 4647461944294429 query88 3986219622062196 query89 416 302 304 302 query90 1904186 186 186 query91 134 103 106 103 query92 74 51 53 51 query93 1673540 542 540 query94 796 286 298 286 query95 346 246 241 241 query96 609 277 276 276 query97 2834267227132672 query98 219 192 193 192 query99 1540132913131313 Total cold run time: 301943 ms Total hot run time: 191193 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
doris-robot commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2514593784 ClickBench: Total hot run time: 32.95 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 2816bc2db0afd9121be898f05e80ea8f8a47a207, data reload: false query1 0.030.040.03 query2 0.060.030.03 query3 0.240.080.07 query4 1.620.100.11 query5 0.420.420.43 query6 1.160.670.66 query7 0.020.010.01 query8 0.040.030.03 query9 0.580.510.52 query10 0.560.560.56 query11 0.140.100.10 query12 0.130.120.11 query13 0.610.610.59 query14 2.842.722.76 query15 0.900.830.84 query16 0.390.380.38 query17 1.071.071.05 query18 0.230.200.20 query19 1.921.831.96 query20 0.020.010.02 query21 15.42 0.600.59 query22 2.502.212.38 query23 17.04 0.840.79 query24 2.580.941.52 query25 0.220.360.11 query26 0.320.140.14 query27 0.040.040.04 query28 10.59 1.101.08 query29 12.59 3.263.21 query30 0.250.060.05 query31 2.880.380.38 query32 3.280.480.47 query33 3.062.973.04 query34 16.79 4.484.44 query35 4.484.534.49 query36 0.680.500.51 query37 0.090.060.06 query38 0.040.030.04 query39 0.030.020.02 query40 0.160.120.12 query41 0.080.020.03 query42 0.030.020.02 query43 0.040.030.03 Total cold run time: 106.17 s Total hot run time: 32.95 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
doris-robot commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2514553346 TPC-H: Total hot run time: 39869 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 2816bc2db0afd9121be898f05e80ea8f8a47a207, data reload: false -- Round 1 -- q1 17675 749172707270 q2 2049172 165 165 q3 10636 112712451127 q4 10226 693 745 693 q5 7623269126802680 q6 236 149 143 143 q7 994 626 611 611 q8 9238180519341805 q9 6626646664356435 q10 6955228923122289 q11 454 266 254 254 q12 410 219 218 218 q13 17761 303229862986 q14 245 215 213 213 q15 564 526 541 526 q16 644 586 590 586 q17 989 604 518 518 q18 7278666867686668 q19 1341979 990 979 q20 471 185 182 182 q21 4387321432743214 q22 385 307 313 307 Total cold run time: 107187 ms Total hot run time: 39869 ms - Round 2, with runtime_filter_mode=off - q1 7280723371937193 q2 329 228 231 228 q3 2886275130262751 q4 2121186817711771 q5 5597569556505650 q6 217 139 141 139 q7 2196174818741748 q8 3392352634673467 q9 8983899991538999 q10 3583353535173517 q11 587 501 489 489 q12 836 629 639 629 q13 12846 320331663166 q14 295 261 266 261 q15 586 528 516 516 q16 694 640 630 630 q17 1788161115331533 q18 7955738174147381 q19 1642155814921492 q20 2053182118311821 q21 5405528554295285 q22 636 548 555 548 Total cold run time: 71907 ms Total hot run time: 59214 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
LiBinfeng-01 commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2514511546 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
doris-robot commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2511647335 TPC-H: Total hot run time: 39831 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 00c6e5be060294635b33ce2fe8980f8b8dbf508f, data reload: false -- Round 1 -- q1 17613 745773237323 q2 2060175 175 175 q3 10860 111611991116 q4 10570 747 781 747 q5 7607273026752675 q6 235 148 149 148 q7 999 671 598 598 q8 9236180418711804 q9 6650643364636433 q10 6983232823712328 q11 461 252 261 252 q12 427 225 224 224 q13 17794 301230823012 q14 238 210 225 210 q15 581 528 524 524 q16 676 583 600 583 q17 971 588 534 534 q18 7176684167286728 q19 1343999 1038999 q20 472 180 182 180 q21 4048324729302930 q22 372 320 308 308 Total cold run time: 107372 ms Total hot run time: 39831 ms - Round 2, with runtime_filter_mode=off - q1 7237726472147214 q2 342 224 225 224 q3 2911280229522802 q4 2080184619191846 q5 5647566556335633 q6 232 147 150 147 q7 2273184818101810 q8 3418351635093509 q9 8960899089878987 q10 3594358235373537 q11 614 502 497 497 q12 835 628 613 613 q13 12169 326432223222 q14 301 289 277 277 q15 582 525 537 525 q16 706 635 633 633 q17 1883164316091609 q18 8172793175947594 q19 1691163716301630 q20 2139191419021902 q21 5663545155655451 q22 646 577 551 551 Total cold run time: 72095 ms Total hot run time: 60213 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
doris-robot commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2511678049 TPC-DS: Total hot run time: 197890 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 00c6e5be060294635b33ce2fe8980f8b8dbf508f, data reload: false query1 1241947 948 947 query2 6242204220612042 query3 10977 451244974497 query4 66844 29184 23537 23537 query5 4982471 461 461 query6 396 187 171 171 query7 5522308 286 286 query8 317 247 252 247 query9 8731271226882688 query10 442 244 263 244 query11 17248 15279 16066 15279 query12 156 106 110 106 query13 1465428 415 415 query14 11028 748668836883 query15 225 193 189 189 query16 6665487 461 461 query17 1221574 578 574 query18 1337296 306 296 query19 207 145 145 145 query20 120 111 146 111 query21 205 107 101 101 query22 4711464446714644 query23 35159 34796 34774 34774 query24 5591248825192488 query25 478 388 382 382 query26 651 147 156 147 query27 2045278 284 278 query28 4375243524362435 query29 668 407 417 407 query30 205 155 156 155 query31 1025865 844 844 query32 64 53 58 53 query33 417 293 299 293 query34 940 506 535 506 query35 908 797 768 768 query36 1087974 984 974 query37 122 74 71 71 query38 4481448443814381 query39 1524151214951495 query40 198 107 102 102 query41 45 41 43 41 query42 108 93 100 93 query43 553 490 487 487 query44 1179819 814 814 query45 224 175 176 175 query46 1175721 726 721 query47 2033196519181918 query48 391 341 319 319 query49 741 395 383 383 query50 833 381 385 381 query51 7457720671077107 query52 107 88 90 88 query53 255 177 177 177 query54 487 396 382 382 query55 78 76 73 73 query56 254 239 231 231 query57 1248110011221100 query58 227 228 217 217 query59 3050301930453019 query60 273 230 234 230 query61 100 101 101 101 query62 806 681 672 672 query63 208 192 179 179 query64 1331689 622 622 query65 3266323032723230 query66 700 295 309 295 query67 15921 15698 15672 15672 query68 3784563 552 552 query69 430 249 247 247 query70 1233113211241124 query71 362 248 245 245 query72 6308408340194019 query73 771 362 359 359 query74 9565910891469108 query75 3426266726422642 query76 1827117911161116 query77 518 311 281 281 query78 10459 944594339433 query79 1670578 592 578 query80 873 420 437 420 query81 497 237 225 225 query82 1313132 124 124 query83 252 142 141 141 query84 289 69 67 67 query85 885 301 287 287 query86 335 295 313 295 query87 4666463546334633 query88 3526219822282198 query89 412 296 291 291 query90 2006192 192 192 query91 140 112 104 104 query92 66 56 52 52 query93 1938540 533 533 query94 741 276 269 269 query95 345 247 253 247 query96 631 275 297 275 query97 2912272727252725 query98 215 195 201 195 query99 1849135313091309 Total cold run time: 317514 ms Total hot run time: 197890 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
doris-robot commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2511692206 ClickBench: Total hot run time: 33.14 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 00c6e5be060294635b33ce2fe8980f8b8dbf508f, data reload: false query1 0.030.030.03 query2 0.070.030.03 query3 0.240.080.07 query4 1.610.100.10 query5 0.410.420.42 query6 1.140.650.65 query7 0.020.010.02 query8 0.040.030.03 query9 0.590.510.50 query10 0.550.560.55 query11 0.150.110.10 query12 0.140.120.11 query13 0.610.610.59 query14 2.702.702.77 query15 0.910.830.83 query16 0.390.380.38 query17 1.071.060.97 query18 0.230.210.21 query19 1.881.711.83 query20 0.020.010.01 query21 15.37 0.590.59 query22 2.342.611.61 query23 17.02 1.180.91 query24 2.841.802.09 query25 0.300.060.05 query26 0.640.140.14 query27 0.050.060.04 query28 9.771.101.08 query29 12.61 3.243.21 query30 0.250.070.07 query31 2.860.380.38 query32 3.280.470.48 query33 3.033.093.06 query34 17.29 4.444.44 query35 4.484.504.47 query36 0.650.490.49 query37 0.090.060.06 query38 0.040.040.04 query39 0.030.020.02 query40 0.160.130.13 query41 0.080.030.03 query42 0.030.030.02 query43 0.040.030.03 Total cold run time: 106.05 s Total hot run time: 33.14 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
LiBinfeng-01 commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2511553106 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
morrySnow commented on code in PR #44755:
URL: https://github.com/apache/doris/pull/44755#discussion_r1862284778
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/CancelJobTaskCommand.java:
##
@@ -79,14 +80,17 @@ private void validate() throws AnalysisException {
throw new AnalysisException("JobName value must is string");
}
this.jobName = ((StringLikeLiteral)
expr.child(0).child(1)).getStringValue();
-String taskIdInput = ((StringLikeLiteral)
expr.child(1).child(0)).getStringValue();
+if (!(expr.child(1).child(0) instanceof UnboundSlot)) {
Review Comment:
maybe u should use get text from identifier to keep it same as legacy planner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
morrySnow commented on code in PR #44755:
URL: https://github.com/apache/doris/pull/44755#discussion_r1862283494
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/CancelJobTaskCommand.java:
##
@@ -79,14 +80,17 @@ private void validate() throws AnalysisException {
throw new AnalysisException("JobName value must is string");
}
this.jobName = ((StringLikeLiteral)
expr.child(0).child(1)).getStringValue();
-String taskIdInput = ((StringLikeLiteral)
expr.child(1).child(0)).getStringValue();
+if (!(expr.child(1).child(0) instanceof UnboundSlot)) {
Review Comment:
if jobName must string, i think we should change syntax to ensure it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fix cancel task jobs failed [doris]
doris-robot commented on PR #44755: URL: https://github.com/apache/doris/pull/44755#issuecomment-2506079770 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
