Re: [PR] [fix](be) Stop extra operator work after cancellation [doris]
zclllyybb merged PR #64077: URL: https://github.com/apache/doris/pull/64077 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) Stop extra operator work after cancellation [doris]
github-actions[bot] commented on PR #64077: URL: https://github.com/apache/doris/pull/64077#issuecomment-4645391946 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) Stop extra operator work after cancellation [doris]
zclllyybb commented on PR #64077: URL: https://github.com/apache/doris/pull/64077#issuecomment-4637611442 /review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) Stop extra operator work after cancellation [doris]
hello-stephen commented on PR #64077: URL: https://github.com/apache/doris/pull/64077#issuecomment-4635941145 # BE Regression && UT Coverage Report Increment line coverage `95.45% (21/22)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/64077_1549bbdd5107677611767cdc5b323063759dc9e6_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/64077_1549bbdd5107677611767cdc5b323063759dc9e6_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 73.73% (28207/38259) | | Line Coverage | 57.73% (306750/531311) | | Region Coverage | 54.67% (257493/471023) | | Branch Coverage | 55.98% (111535/199250) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) Stop extra operator work after cancellation [doris]
hello-stephen commented on PR #64077: URL: https://github.com/apache/doris/pull/64077#issuecomment-4635735523 # BE Regression && UT Coverage Report Increment line coverage `95.45% (21/22)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/64077_1549bbdd5107677611767cdc5b323063759dc9e6_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/64077_1549bbdd5107677611767cdc5b323063759dc9e6_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 73.76% (28220/38259) | | Line Coverage | 57.77% (306963/531311) | | Region Coverage | 54.67% (257531/471023) | | Branch Coverage | 56.02% (111616/199250) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) Stop extra operator work after cancellation [doris]
hello-stephen commented on PR #64077: URL: https://github.com/apache/doris/pull/64077#issuecomment-4635693158 # BE Regression && UT Coverage Report Increment line coverage `95.45% (21/22)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/64077_1549bbdd5107677611767cdc5b323063759dc9e6_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/64077_1549bbdd5107677611767cdc5b323063759dc9e6_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 73.72% (28205/38259) | | Line Coverage | 57.77% (306943/531311) | | Region Coverage | 54.68% (257543/471023) | | Branch Coverage | 56.02% (111620/199250) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) Stop extra operator work after cancellation [doris]
hello-stephen commented on PR #64077: URL: https://github.com/apache/doris/pull/64077#issuecomment-4635646412 # BE Regression && UT Coverage Report Increment line coverage `95.45% (21/22)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/64077_1549bbdd5107677611767cdc5b323063759dc9e6_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/64077_1549bbdd5107677611767cdc5b323063759dc9e6_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 71.80% (27470/38259) | | Line Coverage | 55.36% (294124/531311) | | Region Coverage | 52.12% (245511/471023) | | Branch Coverage | 53.24% (106079/199250) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) Stop extra operator work after cancellation [doris]
hello-stephen commented on PR #64077: URL: https://github.com/apache/doris/pull/64077#issuecomment-4635327424 # BE Regression && UT Coverage Report Increment line coverage `95.45% (21/22)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/64077_1549bbdd5107677611767cdc5b323063759dc9e6_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/64077_1549bbdd5107677611767cdc5b323063759dc9e6_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 71.80% (27470/38259) | | Line Coverage | 55.36% (294124/531311) | | Region Coverage | 52.12% (245511/471023) | | Branch Coverage | 53.24% (106079/199250) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) Stop extra operator work after cancellation [doris]
hello-stephen commented on PR #64077: URL: https://github.com/apache/doris/pull/64077#issuecomment-4634982642 TPC-DS: Total hot run time: 168913 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 1549bbdd5107677611767cdc5b323063759dc9e6, data reload: false query5 4351628 472 472 query6 445 194 175 175 query7 4896583 313 313 query8 366 212 216 212 query9 8782403640064006 query10 450 316 260 260 query11 5904237021262126 query12 160 104 101 101 query13 1265627 451 451 query14 6397538950655065 query14_14390440943544354 query15 205 193 177 177 query16 1039444 424 424 query17 1134705 555 555 query18 2477464 330 330 query19 199 184 146 146 query20 120 108 105 105 query21 215 141 114 114 query22 13624 13698 13434 13434 query23 17220 16512 16006 16006 query23_116322 16296 16276 16276 query24 7662179113021302 query24_11320130112891289 query25 542 462 378 378 query26 1314294 175 175 query27 2673564 313 313 query28 4487203619991999 query29 1082619 498 498 query30 322 236 205 205 query31 11091088950 950 query32 109 66 62 62 query33 557 339 264 264 query34 11651173649 649 query35 768 791 709 709 query36 1385136612681268 query37 158 111 94 94 query38 3179315530833083 query39 923 921 914 914 query39_1880 877 881 877 query40 224 126 105 105 query41 72 68 66 66 query42 98 99 95 95 query43 317 318 275 275 query44 query45 199 221 180 180 query46 10871173723 723 query47 2405236022542254 query48 408 421 299 299 query49 636 483 355 355 query50 966 354 257 257 query51 4338430043184300 query52 85 88 76 76 query53 250 264 192 192 query54 269 213 213 213 query55 77 74 68 68 query56 238 226 223 223 query57 1408142213121312 query58 246 217 214 214 query59 1590164314191419 query60 298 251 229 229 query61 163 158 157 157 query62 690 667 584 584 query63 232 180 185 180 query64 2559793 639 639 query65 query66 1814461 342 342 query67 29749 29703 29536 29536 query68 query69 432 304 263 263 query70 987 955 931 931 query71 317 225 213 213 query72 3055270624242424 query73 857 754 431 431 query74 5069492547564756 query75 2649256022602260 query76 23411158766 766 query77 346 365 276 276 query78 12295 12268 11820 11820 query79 12561037753 753 query80 545 473 385 385 query81 453 280 241 241 query82 236 168 126 126 query83 259 280 247 247 query84 297 142 113 113 query85 831 511 445 445 query86 335 298 280 280 query87 3358339131603160 query88 3563273927322732 query89 419 380 340 340 query90 2185177 181 177 query91 175 166 137 137 query92 67 63 56 56 query93 14631426886 886 query94 537 352 299 299 query95 691 365 437 365 query96 1095770 353 353 query97 2680268225662566 query98 207 204 203 203 query99 1177117510421042 Total cold run time: 250427 ms Total hot run time: 168913 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:
Re: [PR] [fix](be) Stop extra operator work after cancellation [doris]
hello-stephen commented on PR #64077: URL: https://github.com/apache/doris/pull/64077#issuecomment-4634902770 TPC-H: Total hot run time: 29242 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 1549bbdd5107677611767cdc5b323063759dc9e6, data reload: false -- Round 1 -- orders Doris NULLNULL0 0 0 NULL0 NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8 NULLNULL q1 17658 401739993999 q2 q3 10787 1485788 788 q4 4687479 342 342 q5 7580886 594 594 q6 183 174 139 139 q7 791 873 637 637 q8 9513171515811581 q9 6452452845124512 q10 6779181715201520 q11 435 270 259 259 q12 636 443 310 310 q13 18221 338028122812 q14 270 261 239 239 q15 q16 819 774 706 706 q17 1006985 918 918 q18 6930579656075607 q19 1686132510231023 q20 505 404 261 261 q21 6193290826712671 q22 445 364 324 324 Total cold run time: 101576 ms Total hot run time: 29242 ms - Round 2, with runtime_filter_mode=off - orders Doris NULLNULL15000 42 6422171781 NULL22778155NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8 NULLNULL q1 5196500648914891 q2 q3 5052521946714671 q4 2155221613731373 q5 4864485948024802 q6 237 186 138 138 q7 1863173115161516 q8 2567230421582158 q9 7473745674327432 q10 4721466942054205 q11 555 407 359 359 q12 739 742 534 534 q13 3019339427582758 q14 271 278 246 246 q15 q16 681 706 617 617 q17 1275128212881282 q18 7669702868186818 q19 1122109310971093 q20 2238221619411941 q21 5291456744394439 q22 540 469 407 407 Total cold run time: 57528 ms Total hot run time: 51680 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) Stop extra operator work after cancellation [doris]
zclllyybb commented on PR #64077: URL: https://github.com/apache/doris/pull/64077#issuecomment-4634574492 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) Stop extra operator work after cancellation [doris]
hello-stephen commented on PR #64077: URL: https://github.com/apache/doris/pull/64077#issuecomment-4624535708 # BE Regression && UT Coverage Report Increment line coverage `95.45% (21/22)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/64077_1549bbdd5107677611767cdc5b323063759dc9e6_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/64077_1549bbdd5107677611767cdc5b323063759dc9e6_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 71.80% (27467/38253) | | Line Coverage | 55.37% (294154/531222) | | Region Coverage | 52.14% (245550/470930) | | Branch Coverage | 53.27% (106112/199208) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) Stop extra operator work after cancellation [doris]
hello-stephen commented on PR #64077: URL: https://github.com/apache/doris/pull/64077#issuecomment-4623416348 TPC-DS: Total hot run time: 169637 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 1549bbdd5107677611767cdc5b323063759dc9e6, data reload: false query5 4354646 504 504 query6 440 204 178 178 query7 4828584 305 305 query8 363 220 243 220 query9 8748413841194119 query10 497 323 270 270 query11 5952232921462146 query12 149 112 106 106 query13 1278613 454 454 query14 6388547151375137 query14_14391442944144414 query15 200 194 175 175 query16 1029442 422 422 query17 1115704 572 572 query18 2479480 341 341 query19 202 191 149 149 query20 114 105 104 104 query21 217 142 126 126 query22 13645 13549 13405 13405 query23 17192 16529 16202 16202 query23_116243 16360 16280 16280 query24 7474181113101310 query24_11320134313201320 query25 541 492 413 413 query26 1291351 180 180 query27 2658595 347 347 query28 4495208020732073 query29 1102640 498 498 query30 322 252 208 208 query31 11291086961 961 query32 119 67 63 63 query33 546 338 261 261 query34 12131141679 679 query35 761 802 699 699 query36 1406135312531253 query37 162 112 96 96 query38 3231316530543054 query39 948 933 897 897 query39_1892 908 890 890 query40 225 133 109 109 query41 86 82 82 82 query42 106 99 97 97 query43 328 326 284 284 query44 query45 204 188 187 187 query46 11371261753 753 query47 2337239122082208 query48 410 411 322 322 query49 660 503 380 380 query50 1118358 266 266 query51 4373437842434243 query52 94 95 80 80 query53 253 287 203 203 query54 291 236 229 229 query55 85 82 73 73 query56 249 237 230 230 query57 1455138713171317 query58 281 230 224 224 query59 1640170114831483 query60 292 264 251 251 query61 187 187 183 183 query62 745 666 586 586 query63 239 188 187 187 query64 2567795 649 649 query65 query66 1782476 343 343 query67 29878 29796 29040 29040 query68 query69 437 313 261 261 query70 967 999 927 927 query71 289 229 211 211 query72 3071271024392439 query73 873 752 437 437 query74 5128499647844784 query75 2675261022572257 query76 23271196787 787 query77 359 392 289 289 query78 12339 12571 11898 11898 query79 14351048797 797 query80 720 466 397 397 query81 466 286 244 244 query82 589 165 125 125 query83 351 274 251 251 query84 262 150 119 119 query85 910 548 444 444 query86 421 297 285 285 query87 3415336232343234 query88 3719280627922792 query89 437 383 325 325 query90 1890186 188 186 query91 177 166 140 140 query92 67 64 57 57 query93 14881478874 874 query94 631 367 313 313 query95 701 393 351 351 query96 1093791 394 394 query97 2713268825482548 query98 211 207 209 207 query99 1152117610281028 Total cold run time: 252229 ms Total hot run time: 169637 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:
Re: [PR] [fix](be) Stop extra operator work after cancellation [doris]
hello-stephen commented on PR #64077: URL: https://github.com/apache/doris/pull/64077#issuecomment-4623322588 TPC-H: Total hot run time: 29082 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 1549bbdd5107677611767cdc5b323063759dc9e6, data reload: false -- Round 1 -- orders Doris NULLNULL0 0 0 NULL0 NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8 NULLNULL q1 17887 419740504050 q2 q3 10813 1390843 843 q4 4689494 350 350 q5 7548893 589 589 q6 181 173 140 140 q7 803 867 651 651 q8 9772155815511551 q9 6150443844644438 q10 6830184415301530 q11 443 276 259 259 q12 644 435 297 297 q13 18129 338827982798 q14 269 262 233 233 q15 q16 826 779 699 699 q17 1007841 957 841 q18 7069574754885488 q19 1326132411501150 q20 529 408 259 259 q21 6226283126002600 q22 442 378 316 316 Total cold run time: 101583 ms Total hot run time: 29082 ms - Round 2, with runtime_filter_mode=off - orders Doris NULLNULL15000 42 6422171781 NULL22778155NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8 NULLNULL q1 4975479349404793 q2 q3 5074518846644664 q4 2109222814281428 q5 4901475648244756 q6 239 177 128 128 q7 1923175516811681 q8 2463217220162016 q9 7435747374527452 q10 4734469642414241 q11 537 391 363 363 q12 738 753 523 523 q13 3025335028092809 q14 286 281 255 255 q15 q16 683 693 606 606 q17 1305128412751275 q18 7346695768656865 q19 1119110411031103 q20 2240222019611961 q21 5284459044624462 q22 515 461 406 406 Total cold run time: 56931 ms Total hot run time: 51787 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) Stop extra operator work after cancellation [doris]
zclllyybb commented on PR #64077: URL: https://github.com/apache/doris/pull/64077#issuecomment-4622983657 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) Stop extra operator work after cancellation [doris]
hello-stephen commented on PR #64077: URL: https://github.com/apache/doris/pull/64077#issuecomment-4616687149 # BE Regression && UT Coverage Report Increment line coverage `95.45% (21/22)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/64077_6c02f8534f7984b0d5211f5848a9de1d9ad8b979_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/64077_6c02f8534f7984b0d5211f5848a9de1d9ad8b979_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 71.95% (27500/38221) | | Line Coverage | 55.48% (294317/530537) | | Region Coverage | 52.26% (245739/470235) | | Branch Coverage | 53.42% (106219/198841) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) Stop extra operator work after cancellation [doris]
github-actions[bot] commented on code in PR #64077:
URL: https://github.com/apache/doris/pull/64077#discussion_r3351606400
##
be/src/exec/operator/spill_utils.h:
##
@@ -78,8 +78,10 @@ struct SpillContext {
// small utility to run the provided callbacks and forward cancellation.
inline Status run_spill_task(RuntimeState* state, std::function
exec_func,
std::function fin_cb = {}) {
+RETURN_IF_CANCELLED(state);
RETURN_IF_ERROR(exec_func());
Review Comment:
This pre-callback cancellation check can skip cleanup that current callers
perform inside `exec_func` after they have already changed shared state. For
example, `PartitionedAggSinkLocalState::_revoke_memory()` increments
`task_controller()->increase_revoking_tasks_count()` before calling
`run_spill_task()`, and the matching decrement is in the callback's `Defer`; if
the query is cancelled in that window, this new check returns before the
callback and leaks the revoking task count. Similarly,
`MultiCastDataStreamer::_trigger_spill_if_need()` blocks `_write_dependency`
before `_start_spill_task()`, while `_start_spill_task()` relies on its
callback to call `_write_dependency->set_ready()`. Please keep caller
cleanup/accounting guaranteed, e.g. do not skip `exec_func` after caller setup,
or move such cleanup outside the callback before adding this helper-level early
return.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) Stop extra operator work after cancellation [doris]
hello-stephen commented on PR #64077: URL: https://github.com/apache/doris/pull/64077#issuecomment-4615740633 TPC-DS: Total hot run time: 170131 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 6c02f8534f7984b0d5211f5848a9de1d9ad8b979, data reload: false query5 4335645 494 494 query6 448 205 186 186 query7 4833583 326 326 query8 375 214 200 200 query9 8769416741644164 query10 448 323 258 258 query11 5975236421832183 query12 158 105 105 105 query13 1286652 453 453 query14 6361541750875087 query14_14418441744234417 query15 204 199 176 176 query16 1031484 433 433 query17 1156737 597 597 query18 2723498 361 361 query19 215 191 150 150 query20 112 114 119 114 query21 225 153 119 119 query22 13730 13633 13508 13508 query23 17452 16557 16146 16146 query23_116225 16300 16321 16300 query24 7574179113251325 query24_11348134413181318 query25 547 443 389 389 query26 1343329 168 168 query27 2612559 367 367 query28 4411224421902190 query29 1069621 497 497 query30 319 239 197 197 query31 11201079955 955 query32 105 61 59 59 query33 527 310 251 251 query34 11601095643 643 query35 758 779 690 690 query36 1366136012491249 query37 153 108 89 89 query38 3192310230533053 query39 933 950 890 890 query39_1882 883 919 883 query40 227 121 101 101 query41 66 63 62 62 query42 98 97 95 95 query43 319 331 281 281 query44 query45 197 183 178 178 query46 11231229773 773 query47 2384235422352235 query48 395 386 274 274 query49 626 475 370 370 query50 992 344 270 270 query51 4320433042394239 query52 89 89 78 78 query53 252 271 197 197 query54 269 213 203 203 query55 78 75 70 70 query56 236 242 236 236 query57 1404139613061306 query58 241 229 218 218 query59 1576162914481448 query60 291 246 243 243 query61 183 188 186 186 query62 706 656 578 578 query63 241 190 192 190 query64 2622863 701 701 query65 query66 1816489 366 366 query67 29934 29624 29546 29546 query68 query69 438 322 282 282 query70 962 983 971 971 query71 313 242 221 221 query72 3124265123962396 query73 852 719 415 415 query74 5158497347954795 query75 2657259022342234 query76 23151178778 778 query77 357 395 307 307 query78 12173 12380 11876 11876 query79 14771127811 811 query80 1188480 409 409 query81 508 284 243 243 query82 566 154 129 129 query83 341 273 249 249 query84 257 139 109 109 query85 940 564 438 438 query86 431 288 270 270 query87 3400332831963196 query88 3653277427412741 query89 434 376 331 331 query90 1801175 177 175 query91 177 165 138 138 query92 60 60 56 56 query93 15681488918 918 query94 666 356 300 300 query95 665 469 349 349 query96 1029758 342 342 query97 2692269825692569 query98 211 216 201 201 query99 1153117910411041 Total cold run time: 252453 ms Total hot run time: 170131 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:
Re: [PR] [fix](be) Stop extra operator work after cancellation [doris]
hello-stephen commented on PR #64077: URL: https://github.com/apache/doris/pull/64077#issuecomment-4615655563 TPC-H: Total hot run time: 28620 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 6c02f8534f7984b0d5211f5848a9de1d9ad8b979, data reload: false -- Round 1 -- orders Doris NULLNULL0 0 0 NULL0 NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8 NULLNULL q1 17992 402239803980 q2 q3 10740 1422818 818 q4 4687478 348 348 q5 7548889 575 575 q6 190 170 134 134 q7 786 847 640 640 q8 9807161915971597 q9 6371451644564456 q10 6855183515191519 q11 442 277 253 253 q12 657 422 286 286 q13 18186 337927502750 q14 266 260 240 240 q15 q16 813 776 706 706 q17 1172874 991 874 q18 6896579356065606 q19 1251121110421042 q20 530 407 265 265 q21 5554260822242224 q22 434 363 307 307 Total cold run time: 101177 ms Total hot run time: 28620 ms - Round 2, with runtime_filter_mode=off - orders Doris NULLNULL15000 42 6422171781 NULL22778155NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8 NULLNULL q1 4330423342204220 q2 q3 4533499143364336 q4 2071221413681368 q5 4432428643284286 q6 228 171 130 130 q7 1750162819781628 q8 256521552155 q9 7927794879057905 q10 4794473342814281 q11 569 427 367 367 q12 768 772 553 553 q13 3361363628762876 q14 303 324 300 300 q15 q16 730 733 677 677 q17 1355132913371329 q18 8028726771427142 q19 1146108411291084 q20 2209221620152015 q21 5248456544054405 q22 507 445 399 399 Total cold run time: 56854 ms Total hot run time: 51456 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
