Re: [PR] [fix](cloud) fix misuse of file_cache_evict_in_advance_batch_bytes [doris]
doris-robot commented on PR #49336: URL: https://github.com/apache/doris/pull/49336#issuecomment-2750677353 # BE UT Coverage Report Increment line coverage `100.00% (5/5)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/5f977fffed734044f3f9660620eec4f234ea0ac8_5f977fffed734044f3f9660620eec4f234ea0ac8/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/5f977fffed734044f3f9660620eec4f234ea0ac8_5f977fffed734044f3f9660620eec4f234ea0ac8/report/index.html) | Category | Coverage | |---|| | Function Coverage | 50.52% (13517/26758) | | Line Coverage | 39.93% (117218/293548) | | Region Coverage | 38.58% (59494/154190) | | Branch Coverage | 33.62% (29996/89216) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](cloud) fix misuse of file_cache_evict_in_advance_batch_bytes [doris]
gavinchou merged PR #49336: URL: https://github.com/apache/doris/pull/49336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](cloud) fix misuse of file_cache_evict_in_advance_batch_bytes [doris]
github-actions[bot] commented on PR #49336: URL: https://github.com/apache/doris/pull/49336#issuecomment-2753095067 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](cloud) fix misuse of file_cache_evict_in_advance_batch_bytes [doris]
github-actions[bot] commented on PR #49336: URL: https://github.com/apache/doris/pull/49336#issuecomment-2753095089 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](cloud) fix misuse of file_cache_evict_in_advance_batch_bytes [doris]
doris-robot commented on PR #49336: URL: https://github.com/apache/doris/pull/49336#issuecomment-2750396234 ClickBench: Total hot run time: 31.03 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 5f977fffed734044f3f9660620eec4f234ea0ac8, data reload: false query1 0.040.040.03 query2 0.130.110.10 query3 0.250.190.19 query4 1.590.200.19 query5 0.600.580.60 query6 1.210.710.72 query7 0.020.020.02 query8 0.040.030.04 query9 0.560.530.54 query10 0.560.600.57 query11 0.150.100.11 query12 0.140.110.11 query13 0.610.600.59 query14 2.672.682.66 query15 0.930.850.84 query16 0.390.390.39 query17 1.031.021.01 query18 0.210.190.19 query19 1.861.931.88 query20 0.020.010.01 query21 15.36 0.880.55 query22 0.761.130.61 query23 15.04 1.360.60 query24 7.111.470.65 query25 0.490.220.08 query26 0.540.160.13 query27 0.050.050.05 query28 9.970.890.45 query29 12.56 3.973.27 query30 0.260.100.06 query31 2.820.580.39 query32 3.220.550.50 query33 3.083.043.08 query34 15.83 5.204.56 query35 4.594.594.58 query36 0.670.490.48 query37 0.080.060.06 query38 0.040.040.03 query39 0.030.020.02 query40 0.170.130.12 query41 0.080.020.02 query42 0.040.020.03 query43 0.040.030.03 Total cold run time: 105.84 s Total hot run time: 31.03 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](cloud) fix misuse of file_cache_evict_in_advance_batch_bytes [doris]
doris-robot commented on PR #49336: URL: https://github.com/apache/doris/pull/49336#issuecomment-2750385894 TPC-DS: Total hot run time: 194821 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 5f977fffed734044f3f9660620eec4f234ea0ac8, data reload: false query1 1413108710501050 query2 6130192619471926 query3 11171 452547664525 query4 25869 24033 23289 23289 query5 5199708 514 514 query6 319 217 217 217 query7 3997491 284 284 query8 372 304 296 296 query9 8530256425622562 query10 518 328 271 271 query11 15746 15067 14862 14862 query12 171 117 109 109 query13 1577522 402 402 query14 9581617562166175 query15 204 189 173 173 query16 7625657 519 519 query17 1124776 606 606 query18 2072423 330 330 query19 209 203 175 175 query20 139 127 127 127 query21 223 130 112 112 query22 4519452345914523 query23 34532 33580 33668 33580 query24 8476246524372437 query25 558 499 452 452 query26 1255280 148 148 query27 2784519 344 344 query28 4941243824252425 query29 727 613 467 467 query30 287 228 197 197 query31 908 884 807 807 query32 79 76 68 68 query33 580 405 335 335 query34 855 889 512 512 query35 814 831 768 768 query36 965 1011916 916 query37 122 111 85 85 query38 4138418942494189 query39 1503156514541454 query40 240 126 119 119 query41 72 66 65 65 query42 128 108 112 108 query43 524 521 478 478 query44 1338834 845 834 query45 191 182 177 177 query46 879 1073652 652 query47 1892189918251825 query48 391 426 308 308 query49 777 555 454 454 query50 733 745 437 437 query51 4290432842914291 query52 111 113 102 102 query53 233 262 182 182 query54 512 515 446 446 query55 87 80 85 80 query56 314 290 266 266 query57 1185121811391139 query58 270 248 261 248 query59 2623290926902690 query60 305 296 287 287 query61 174 159 158 158 query62 777 733 682 682 query63 222 183 190 183 query64 43271219858 858 query65 4517436444494364 query66 1063439 355 355 query67 16677 15554 15477 15477 query68 6639881 506 506 query69 476 320 276 276 query70 1220104410491044 query71 406 299 268 268 query72 5854493849964938 query73 652 631 355 355 query74 9201900792289007 query75 3291330427532753 query76 31811191747 747 query77 520 385 307 307 query78 993410224 93979397 query79 1975809 566 566 query80 734 580 499 499 query81 501 257 306 257 query82 202 123 101 101 query83 191 180 169 169 query84 253 104 83 83 query85 830 440 397 397 query86 365 316 280 280 query87 4482450243524352 query88 3020226622642264 query89 396 314 282 282 query90 2045214 222 214 query91 237 164 130 130 query92 81 58 62 58 query93 22961042572 572 query94 685 414 327 327 query95 365 315 275 275 query96 499 554 277 277 query97 3120321231583158 query98 237 204 200 200 query99 1343141312661266 Total cold run time: 280315 ms Total hot run time: 194821 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [fix](cloud) fix misuse of file_cache_evict_in_advance_batch_bytes [doris]
doris-robot commented on PR #49336: URL: https://github.com/apache/doris/pull/49336#issuecomment-2750361375 TPC-H: Total hot run time: 34364 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 5f977fffed734044f3f9660620eec4f234ea0ac8, data reload: false -- Round 1 -- q1 26363 515450545054 q2 2067278 168 168 q3 10413 1241702 702 q4 10227 1023544 544 q5 7517284423732373 q6 196 162 133 133 q7 908 768 621 621 q8 9334133311631163 q9 6919512851535128 q10 6864228719111911 q11 497 268 259 259 q12 352 357 220 220 q13 17775 367230943094 q14 227 235 212 212 q15 540 495 484 484 q16 633 626 594 594 q17 598 883 353 353 q18 7705730871787178 q19 1691964 551 551 q20 314 320 198 198 q21 4261255124312431 q22 10941029993 993 Total cold run time: 116495 ms Total hot run time: 34364 ms - Round 2, with runtime_filter_mode=off - q1 5238516651485148 q2 240 323 235 235 q3 2195267423012301 q4 1435189114981498 q5 4477448744024402 q6 219 169 135 135 q7 1973193217901790 q8 2617257425302530 q9 7327702073117020 q10 2996317027522752 q11 590 489 494 489 q12 691 755 609 609 q13 3472390533773377 q14 287 297 275 275 q15 515 474 481 474 q16 676 703 654 654 q17 1170153314241424 q18 7852755674467446 q19 846 829 972 829 q20 1899197418471847 q21 5261493048094809 q22 1116109910161016 Total cold run time: 53092 ms Total hot run time: 51060 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](cloud) fix misuse of file_cache_evict_in_advance_batch_bytes [doris]
freemandealer commented on PR #49336: URL: https://github.com/apache/doris/pull/49336#issuecomment-2750163422 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](cloud) fix misuse of file_cache_evict_in_advance_batch_bytes [doris]
doris-robot commented on PR #49336: URL: https://github.com/apache/doris/pull/49336#issuecomment-2750009294 ClickBench: Total hot run time: 31.34 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit cc04f3e8b98acf39520d368126f6c938a8851aaf, data reload: false query1 0.040.040.03 query2 0.110.100.11 query3 0.250.200.20 query4 1.590.190.19 query5 0.600.590.58 query6 1.180.720.71 query7 0.020.020.02 query8 0.040.040.03 query9 0.580.540.53 query10 0.570.590.57 query11 0.150.120.11 query12 0.150.110.12 query13 0.620.590.61 query14 2.662.682.68 query15 0.940.850.85 query16 0.390.400.39 query17 1.021.021.04 query18 0.230.210.20 query19 1.921.961.81 query20 0.020.020.01 query21 15.35 0.930.56 query22 0.751.060.73 query23 14.98 1.390.66 query24 6.771.020.79 query25 0.470.330.06 query26 0.570.160.13 query27 0.070.050.05 query28 9.650.940.42 query29 12.71 3.933.33 query30 0.260.090.06 query31 2.820.600.38 query32 3.230.530.48 query33 2.993.073.05 query34 15.67 5.134.54 query35 4.624.584.55 query36 0.670.490.49 query37 0.090.060.07 query38 0.050.040.04 query39 0.030.020.02 query40 0.180.140.14 query41 0.080.020.02 query42 0.030.020.03 query43 0.030.030.03 Total cold run time: 105.15 s Total hot run time: 31.34 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](cloud) fix misuse of file_cache_evict_in_advance_batch_bytes [doris]
doris-robot commented on PR #49336: URL: https://github.com/apache/doris/pull/49336#issuecomment-2750003579 TPC-DS: Total hot run time: 193840 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit cc04f3e8b98acf39520d368126f6c938a8851aaf, data reload: false query1 1386109510481048 query2 6279191519581915 query3 11186 460948874609 query4 25611 23475 23130 23130 query5 3656644 491 491 query6 310 188 190 188 query7 3976494 277 277 query8 289 242 243 242 query9 8493256125722561 query10 436 309 274 274 query11 15400 15178 14925 14925 query12 162 109 114 109 query13 1572538 404 404 query14 8449618961876187 query15 204 197 169 169 query16 7157665 508 508 query17 1206703 570 570 query18 2011434 332 332 query19 206 191 172 172 query20 128 130 125 125 query21 209 128 114 114 query22 4672476344294429 query23 34485 33763 33445 33445 query24 8545245224412441 query25 519 474 403 403 query26 1228271 148 148 query27 2993505 332 332 query28 4666246224612461 query29 786 568 451 451 query30 279 227 202 202 query31 897 871 780 780 query32 74 64 62 62 query33 540 375 305 305 query34 793 892 518 518 query35 840 834 785 785 query36 969 983 912 912 query37 121 103 75 75 query38 4226427142424242 query39 1487144214601442 query40 217 121 105 105 query41 54 52 51 51 query42 115 104 111 104 query43 513 526 496 496 query44 1355809 828 809 query45 189 178 170 170 query46 884 1026661 661 query47 1842191518291829 query48 387 420 322 322 query49 790 525 412 412 query50 719 765 435 435 query51 4314435342454245 query52 108 111 100 100 query53 233 259 189 189 query54 535 523 442 442 query55 86 86 91 86 query56 316 331 283 283 query57 1186120911201120 query58 252 244 240 240 query59 2772292126042604 query60 287 289 254 254 query61 132 132 126 126 query62 764 748 648 648 query63 223 184 183 183 query64 41081049668 668 query65 4576444145484441 query66 1197404 310 310 query67 16209 15923 15583 15583 query68 9594915 506 506 query69 496 307 268 268 query70 1189114410591059 query71 455 305 266 266 query72 5304501449114911 query73 692 547 350 350 query74 8983913791099109 query75 4339324627052705 query76 42931207769 769 query77 967 374 280 280 query78 10193 10307 93259325 query79 2023803 550 550 query80 591 514 426 426 query81 488 256 286 256 query82 477 131 93 93 query83 178 176 162 162 query84 241 98 78 78 query85 787 356 333 333 query86 381 290 299 290 query87 4354447343754375 query88 3537218822002188 query89 392 311 283 283 query90 1807208 208 208 query91 134 139 109 109 query92 70 58 57 57 query93 16801055573 573 query94 653 418 314 314 query95 359 268 345 268 query96 492 561 270 270 query97 3356343432993299 query98 230 207 198 198 query99 1489139112631263 Total cold run time: 281033 ms Total hot run time: 193840 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [fix](cloud) fix misuse of file_cache_evict_in_advance_batch_bytes [doris]
doris-robot commented on PR #49336: URL: https://github.com/apache/doris/pull/49336#issuecomment-2749989818 TPC-H: Total hot run time: 34319 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit cc04f3e8b98acf39520d368126f6c938a8851aaf, data reload: false -- Round 1 -- q1 26932 510050675067 q2 2074310 177 177 q3 10433 1237698 698 q4 10224 1031546 546 q5 7648237523992375 q6 188 166 136 136 q7 925 745 608 608 q8 9329129410691069 q9 6889522151855185 q10 6862229719131913 q11 489 283 263 263 q12 352 355 223 223 q13 17765 371231463146 q14 234 231 218 218 q15 546 481 485 481 q16 621 648 598 598 q17 595 856 349 349 q18 7811747769976997 q19 1971985 574 574 q20 315 319 198 198 q21 4012342025082508 q22 10281024990 990 Total cold run time: 117243 ms Total hot run time: 34319 ms - Round 2, with runtime_filter_mode=off - q1 5231512652575126 q2 240 332 236 236 q3 2177267922662266 q4 1449198214761476 q5 4506449244204420 q6 220 175 134 134 q7 2006195318031803 q8 2656259325632563 q9 7335700873147008 q10 3017318627502750 q11 567 514 488 488 q12 690 729 607 607 q13 3555398034243424 q14 295 293 283 283 q15 522 485 489 485 q16 639 701 640 640 q17 1157152314261426 q18 7789752375477523 q19 856 833 883 833 q20 1928197318621862 q21 5458508648644864 q22 1100109410351035 Total cold run time: 53393 ms Total hot run time: 51252 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](cloud) fix misuse of file_cache_evict_in_advance_batch_bytes [doris]
dataroaring commented on PR #49336: URL: https://github.com/apache/doris/pull/49336#issuecomment-2749844104 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](cloud) fix misuse of file_cache_evict_in_advance_batch_bytes [doris]
gavinchou commented on code in PR #49336:
URL: https://github.com/apache/doris/pull/49336#discussion_r2006891992
##
be/src/io/cache/block_file_cache.cpp:
##
@@ -1889,7 +1889,9 @@ void BlockFileCache::run_background_evict_in_advance() {
batch = config::file_cache_evict_in_advance_batch_bytes;
// Skip if eviction not needed or too many pending recycles
-if (!_need_evict_cache_in_advance || _recycle_keys.size_approx() >=
(batch * 10)) {
+if (!_need_evict_cache_in_advance ||
+_recycle_keys.size_approx() >=
Review Comment:
is it coverted by UT? it seems not or the case is not sufficient, we need to
cover it with UT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [fix](cloud) fix misuse of file_cache_evict_in_advance_batch_bytes [doris]
hello-stephen commented on PR #49336: URL: https://github.com/apache/doris/pull/49336#issuecomment-2741324842 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
