Re: [PR] [fix](cloud) potential data race when retrying prepare/commit rowset for load [doris]
liaoxin01 merged PR #51129: URL: https://github.com/apache/doris/pull/51129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) potential data race when retrying prepare/commit rowset for load [doris]
github-actions[bot] commented on PR #51129: URL: https://github.com/apache/doris/pull/51129#issuecomment-2921585469 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) potential data race when retrying prepare/commit rowset for load [doris]
github-actions[bot] commented on PR #51129: URL: https://github.com/apache/doris/pull/51129#issuecomment-2921585392 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) potential data race when retrying prepare/commit rowset for load [doris]
doris-robot commented on PR #51129: URL: https://github.com/apache/doris/pull/51129#issuecomment-2918429104 ClickBench: Total hot run time: 29.94 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit c0b1ad831bb9d9a3bdca0434ea296a9140a3958e, data reload: false query1 0.040.030.03 query2 0.150.100.11 query3 0.350.200.20 query4 1.600.200.08 query5 0.420.400.41 query6 1.170.650.67 query7 0.020.020.02 query8 0.060.050.07 query9 0.630.520.51 query10 0.590.590.58 query11 0.250.120.13 query12 0.250.130.13 query13 0.630.630.62 query14 0.790.820.83 query15 0.940.880.87 query16 0.370.380.37 query17 1.041.081.05 query18 0.190.180.18 query19 2.001.901.88 query20 0.020.010.01 query21 15.40 0.970.67 query22 0.941.050.85 query23 14.71 1.540.77 query24 5.240.600.30 query25 0.160.090.09 query26 0.560.220.19 query27 0.080.090.08 query28 10.99 1.260.59 query29 12.58 4.153.46 query30 0.270.080.06 query31 2.810.620.44 query32 3.240.600.51 query33 3.063.093.13 query34 16.32 5.124.48 query35 4.514.534.53 query36 0.630.510.50 query37 0.210.180.17 query38 0.160.170.15 query39 0.050.040.04 query40 0.210.170.16 query41 0.100.050.06 query42 0.070.050.05 query43 0.060.040.04 Total cold run time: 103.87 s Total hot run time: 29.94 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) potential data race when retrying prepare/commit rowset for load [doris]
doris-robot commented on PR #51129: URL: https://github.com/apache/doris/pull/51129#issuecomment-2918420150 TPC-DS: Total hot run time: 193639 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit c0b1ad831bb9d9a3bdca0434ea296a9140a3958e, data reload: false query1 1416110310841084 query2 6288189818941894 query3 11156 460444504450 query4 54836 24723 23537 23537 query5 5216538 477 477 query6 360 218 236 218 query7 4883512 296 296 query8 289 228 208 208 query9 5608266126582658 query10 444 334 277 277 query11 15091 15051 14822 14822 query12 168 113 109 109 query13 1039528 417 417 query14 10157 639864246398 query15 210 198 178 178 query16 7087693 479 479 query17 1065743 571 571 query18 1538405 299 299 query19 206 204 171 171 query20 135 120 121 120 query21 221 125 106 106 query22 4430447342874287 query23 34323 33472 33610 33472 query24 6570244524522445 query25 486 469 406 406 query26 692 286 157 157 query27 2264498 345 345 query28 3372220121952195 query29 638 607 456 456 query30 280 221 190 190 query31 853 872 782 782 query32 73 64 63 63 query33 465 373 321 321 query34 784 883 554 554 query35 800 812 767 767 query36 972 1020911 911 query37 115 105 86 86 query38 4344432843094309 query39 1549144014811440 query40 221 127 143 127 query41 68 66 58 58 query42 126 111 117 111 query43 530 517 501 501 query44 1430869 849 849 query45 184 174 171 171 query46 847 1028655 655 query47 1821186517671767 query48 428 444 323 323 query49 675 506 409 409 query50 670 717 415 415 query51 4261426642374237 query52 111 109 104 104 query53 238 271 193 193 query54 607 596 520 520 query55 89 92 85 85 query56 319 318 334 318 query57 1152116811181118 query58 264 258 262 258 query59 2733288427752775 query60 344 336 312 312 query61 126 134 147 134 query62 716 739 651 651 query63 229 193 183 183 query64 14721037719 719 query65 4274415541214121 query66 742 424 320 320 query67 15936 15447 15444 15444 query68 5534924 535 535 query69 532 321 273 273 query70 1215115010641064 query71 471 328 308 308 query72 6086491448654865 query73 1293675 360 360 query74 8861888491148884 query75 3323321827012701 query76 38051209790 790 query77 546 380 292 292 query78 10161 10284 95019501 query79 2753797 688 688 query80 759 517 451 451 query81 497 251 215 215 query82 568 135 98 98 query83 273 262 239 239 query84 309 113 87 87 query85 834 355 309 309 query86 455 298 274 274 query87 4435442843184318 query88 3774231522942294 query89 417 360 290 290 query90 1774214 214 214 query91 139 138 113 113 query92 77 62 56 56 query93 2630958 584 584 query94 728 406 310 310 query95 375 301 290 290 query96 498 579 283 283 query97 2727272626542654 query98 240 205 202 202 query99 1337139812641264 Total cold run time: 298462 ms Total hot run time: 193639 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [fix](cloud) potential data race when retrying prepare/commit rowset for load [doris]
doris-robot commented on PR #51129: URL: https://github.com/apache/doris/pull/51129#issuecomment-2918397424 TPC-H: Total hot run time: 34142 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit c0b1ad831bb9d9a3bdca0434ea296a9140a3958e, data reload: false -- Round 1 -- q1 26135 514250565056 q2 1959275 180 180 q3 10403 1253715 715 q4 10235 998 527 527 q5 7656241823602360 q6 195 164 132 132 q7 933 730 611 611 q8 9299128911131113 q9 6827513251125112 q10 6880232619321932 q11 499 284 274 274 q12 351 347 218 218 q13 17797 372131803180 q14 231 230 215 215 q15 549 491 474 474 q16 438 439 371 371 q17 604 875 377 377 q18 7727726671207120 q19 21031036593 593 q20 342 351 217 217 q21 3883316423812381 q22 10551024984 984 Total cold run time: 116101 ms Total hot run time: 34142 ms - Round 2, with runtime_filter_mode=off - q1 5317513354775133 q2 232 319 225 225 q3 2187266023082308 q4 1411180414771477 q5 4474441744284417 q6 221 171 130 130 q7 2055190517491749 q8 2560256224972497 q9 7273708069636963 q10 3052321027572757 q11 583 503 500 500 q12 693 776 650 650 q13 35783917 q14 278 298 287 287 q15 543 473 486 473 q16 467 470 441 441 q17 1128148514861485 q18 7879757674947494 q19 880 820 954 820 q20 2016209918581858 q21 4819464946474647 q22 1118106810041004 Total cold run time: 52764 ms Total hot run time: 50648 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) potential data race when retrying prepare/commit rowset for load [doris]
hello-stephen commented on PR #51129: URL: https://github.com/apache/doris/pull/51129#issuecomment-2918260570 # Cloud UT Coverage Report Increment line coverage `66.15% (43/65)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/c0b1ad831bb9d9a3bdca0434ea296a9140a3958e_c0b1ad831bb9d9a3bdca0434ea296a9140a3958e_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/c0b1ad831bb9d9a3bdca0434ea296a9140a3958e_c0b1ad831bb9d9a3bdca0434ea296a9140a3958e_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 83.27% (1115/1339) | | Line Coverage | 66.49% (18852/28352) | | Region Coverage | 66.16% (9353/14136) | | Branch Coverage | 56.05% (5047/9004) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) potential data race when retrying prepare/commit rowset for load [doris]
liaoxin01 commented on PR #51129: URL: https://github.com/apache/doris/pull/51129#issuecomment-2918216819 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) potential data race when retrying prepare/commit rowset for load [doris]
gavinchou commented on code in PR #51129:
URL: https://github.com/apache/doris/pull/51129#discussion_r2106435175
##
cloud/src/meta-service/meta_service.cpp:
##
@@ -990,6 +990,66 @@ static void fill_schema_from_dict(MetaServiceCode& code,
std::string& msg,
existed_rowset_meta->CopyFrom(metas.Get(0));
}
+/**
+* Check if the transaction status is as expected.
+* If the transaction is not in the expected state, return false and set the
error code and message.
+*
+* @param expect_status The expected transaction status.
+* @param txn Pointer to the transaction object.
+* @param instance_id The instance ID associated with the transaction.
+* @param txn_id The transaction ID to check.
+* @param code Reference to the error code to be set in case of failure.
+* @param msg Reference to the error message to be set in case of failure.
+* @return true if the transaction status matches the expected status, false
otherwise.
+ */
+static bool check_transaction_status(TxnStatusPB expect_status, Transaction*
txn,
+ const std::string& instance_id, int64_t
txn_id,
+ MetaServiceCode& code, std::string& msg) {
+// Get db id with txn id
+std::string index_val;
+const std::string index_key = txn_index_key({instance_id, txn_id});
+TxnErrorCode err = txn->get(index_key, &index_val);
+if (err != TxnErrorCode::TXN_OK) {
+code = cast_as(err);
+msg = fmt::format("failed to get db id, txn_id={} err={}", txn_id,
err);
+return false;
+}
+
+TxnIndexPB index_pb;
+if (!index_pb.ParseFromString(index_val)) {
+code = MetaServiceCode::PROTOBUF_PARSE_ERR;
+msg = fmt::format("failed to parse txn_index_pb, txn_id={}", txn_id);
+return false;
+}
+
+DCHECK(index_pb.has_tablet_index() == true);
Review Comment:
also return false and log for these checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) potential data race when retrying prepare/commit rowset for load [doris]
hello-stephen commented on PR #51129: URL: https://github.com/apache/doris/pull/51129#issuecomment-2907928724 # BE Regression && UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/51129_490a438f754c71776b603193cf2bfe6bdca3d54d_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/51129_490a438f754c71776b603193cf2bfe6bdca3d54d_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 79.58% (20872/26227) | | Line Coverage | 72.79% (215741/296378) | | Region Coverage | 70.99% (126807/178626) | | Branch Coverage | 64.79% (65811/101570) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) potential data race when retrying prepare/commit rowset for load [doris]
doris-robot commented on PR #51129: URL: https://github.com/apache/doris/pull/51129#issuecomment-2907926209 # BE UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/490a438f754c71776b603193cf2bfe6bdca3d54d_490a438f754c71776b603193cf2bfe6bdca3d54d/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/490a438f754c71776b603193cf2bfe6bdca3d54d_490a438f754c71776b603193cf2bfe6bdca3d54d/report/index.html) | Category | Coverage | |---|| | Function Coverage | 56.00% (14920/26644) | | Line Coverage | 44.82% (132841/296391) | | Region Coverage | 43.90% (66777/152119) | | Branch Coverage | 38.52% (34265/88944) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) potential data race when retrying prepare/commit rowset for load [doris]
doris-robot commented on PR #51129: URL: https://github.com/apache/doris/pull/51129#issuecomment-2906888637 # Cloud UT Coverage Report Increment line coverage `72.41% (42/58)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/490a438f754c71776b603193cf2bfe6bdca3d54d_490a438f754c71776b603193cf2bfe6bdca3d54d_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/490a438f754c71776b603193cf2bfe6bdca3d54d_490a438f754c71776b603193cf2bfe6bdca3d54d_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 83.26% (1114/1338) | | Line Coverage | 66.17% (18713/28282) | | Region Coverage | 65.87% (9293/14108) | | Branch Coverage | 55.68% (5003/8986) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) potential data race when retrying prepare/commit rowset for load [doris]
doris-robot commented on PR #51129: URL: https://github.com/apache/doris/pull/51129#issuecomment-2906926959 TPC-DS: Total hot run time: 192763 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 490a438f754c71776b603193cf2bfe6bdca3d54d, data reload: false query1 1437105610511051 query2 6202178717931787 query3 11057 464243124312 query4 55607 25185 23244 23244 query5 5296521 465 465 query6 357 221 197 197 query7 4942501 298 298 query8 339 268 243 243 query9 6075261026252610 query10 428 349 272 272 query11 14994 15045 14858 14858 query12 163 106 104 104 query13 1035524 417 417 query14 10147 652963586358 query15 198 206 185 185 query16 7110670 496 496 query17 1094769 643 643 query18 1566432 316 316 query19 207 194 189 189 query20 137 133 127 127 query21 215 132 116 116 query22 4414440943424342 query23 34243 33620 33588 33588 query24 7283243424482434 query25 456 474 407 407 query26 680 274 153 153 query27 2265518 376 376 query28 3177218121402140 query29 579 575 436 436 query30 273 223 195 195 query31 857 858 783 783 query32 81 65 70 65 query33 461 364 317 317 query34 797 861 532 532 query35 809 824 741 741 query36 953 1026899 899 query37 113 96 78 78 query38 4284425742144214 query39 1530146614641464 query40 222 121 115 115 query41 53 52 50 50 query42 124 113 115 113 query43 514 502 478 478 query44 1359854 861 854 query45 187 175 170 170 query46 872 1039656 656 query47 1833190718201820 query48 416 435 341 341 query49 683 524 432 432 query50 688 694 414 414 query51 4214430742004200 query52 117 111 105 105 query53 236 263 204 204 query54 606 594 519 519 query55 86 84 82 82 query56 313 315 292 292 query57 1203120711291129 query58 276 261 261 261 query59 2765281626442644 query60 375 339 326 326 query61 135 123 134 123 query62 757 736 640 640 query63 224 186 191 186 query64 14531036709 709 query65 4326420642044204 query66 725 410 297 297 query67 15947 15610 15562 15562 query68 7072894 531 531 query69 536 305 268 268 query70 1115117111151115 query71 501 331 301 301 query72 5958483948674839 query73 1385676 363 363 query74 8986910286518651 query75 3822327926472647 query76 41731194780 780 query77 652 367 274 274 query78 10175 10269 94319431 query79 2242789 574 574 query80 612 509 432 432 query81 482 260 222 222 query82 460 122 95 95 query83 256 245 239 239 query84 345 101 79 79 query85 780 356 309 309 query86 400 323 302 302 query87 4519451143624362 query88 3730232623242324 query89 401 316 285 285 query90 1795208 215 208 query91 147 171 122 122 query92 72 64 60 60 query93 1899931 584 584 query94 676 413 310 310 query95 373 291 289 289 query96 497 565 282 282 query97 2716272726232623 query98 235 213 204 204 query99 1359139212801280 Total cold run time: 300941 ms Total hot run time: 192763 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [fix](cloud) potential data race when retrying prepare/commit rowset for load [doris]
doris-robot commented on PR #51129: URL: https://github.com/apache/doris/pull/51129#issuecomment-2906928955 ClickBench: Total hot run time: 29.73 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 490a438f754c71776b603193cf2bfe6bdca3d54d, data reload: false query1 0.030.030.04 query2 0.150.110.10 query3 0.340.200.20 query4 1.590.220.20 query5 0.490.450.44 query6 1.170.650.66 query7 0.020.010.02 query8 0.050.050.04 query9 0.630.530.52 query10 0.580.580.58 query11 0.260.140.13 query12 0.250.140.13 query13 0.630.620.62 query14 0.800.820.84 query15 0.960.870.89 query16 0.360.380.37 query17 1.031.061.05 query18 0.200.200.18 query19 1.951.831.86 query20 0.020.020.01 query21 15.40 0.970.67 query22 0.930.980.77 query23 14.74 1.490.76 query24 5.250.580.30 query25 0.170.100.09 query26 0.550.230.18 query27 0.090.080.09 query28 11.08 1.130.58 query29 12.55 4.153.38 query30 0.270.080.06 query31 2.820.630.45 query32 3.220.600.51 query33 3.073.073.16 query34 16.42 5.174.43 query35 4.514.474.48 query36 0.640.510.50 query37 0.200.180.17 query38 0.180.150.16 query39 0.050.040.05 query40 0.200.180.15 query41 0.100.050.05 query42 0.070.060.05 query43 0.060.040.04 Total cold run time: 104.08 s Total hot run time: 29.73 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) potential data race when retrying prepare/commit rowset for load [doris]
doris-robot commented on PR #51129: URL: https://github.com/apache/doris/pull/51129#issuecomment-2906919268 TPC-H: Total hot run time: 33880 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 490a438f754c71776b603193cf2bfe6bdca3d54d, data reload: false -- Round 1 -- q1 26381 507550115011 q2 2078296 199 199 q3 10472 1245682 682 q4 10229 1008512 512 q5 7648234323452343 q6 180 162 138 138 q7 919 729 613 613 q8 9343126811091109 q9 6860533450905090 q10 6862229019031903 q11 484 294 279 279 q12 337 345 216 216 q13 17804 369030643064 q14 233 226 217 217 q15 533 493 490 490 q16 416 434 378 378 q17 620 863 375 375 q18 7594729571317131 q19 1998958 563 563 q20 334 338 226 226 q21 3786319423502350 q22 10501020991 991 Total cold run time: 116161 ms Total hot run time: 33880 ms - Round 2, with runtime_filter_mode=off - q1 5233504750625047 q2 235 326 234 234 q3 2161268423242324 q4 1334175713961396 q5 4451448244244424 q6 217 167 130 130 q7 2039195917871787 q8 2583250925002500 q9 7319713471237123 q10 3006318827922792 q11 570 518 499 499 q12 698 798 634 634 q13 3468388433563356 q14 300 289 263 263 q15 516 474 484 474 q16 451 503 430 430 q17 1166160713651365 q18 7732777373657365 q19 798 952 941 941 q20 1945197318351835 q21 4861442843254325 q22 1096106810101010 Total cold run time: 52179 ms Total hot run time: 50254 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) potential data race when retrying prepare/commit rowset for load [doris]
liaoxin01 commented on PR #51129: URL: https://github.com/apache/doris/pull/51129#issuecomment-2906877925 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) potential data race when retrying prepare/commit rowset for load [doris]
liaoxin01 commented on PR #51129: URL: https://github.com/apache/doris/pull/51129#issuecomment-2906857080 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) potential data race when retrying prepare/commit rowset for load [doris]
hello-stephen commented on PR #51129: URL: https://github.com/apache/doris/pull/51129#issuecomment-2903321576 # BE Regression && UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/51129_08c3697b2e7e31492e183bdcbbc67d922f889c7c_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/51129_08c3697b2e7e31492e183bdcbbc67d922f889c7c_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 79.56% (20864/26223) | | Line Coverage | 72.74% (215514/296263) | | Region Coverage | 70.89% (126646/178653) | | Branch Coverage | 64.66% (65664/101558) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) potential data race when retrying prepare/commit rowset for load [doris]
hello-stephen commented on PR #51129: URL: https://github.com/apache/doris/pull/51129#issuecomment-2903250448 # BE UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/08c3697b2e7e31492e183bdcbbc67d922f889c7c_08c3697b2e7e31492e183bdcbbc67d922f889c7c/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/08c3697b2e7e31492e183bdcbbc67d922f889c7c_08c3697b2e7e31492e183bdcbbc67d922f889c7c/report/index.html) | Category | Coverage | |---|| | Function Coverage | 56.00% (14918/26640) | | Line Coverage | 44.79% (132703/296276) | | Region Coverage | 43.85% (66705/152109) | | Branch Coverage | 38.48% (34215/88920) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) potential data race when retrying prepare/commit rowset for load [doris]
doris-robot commented on PR #51129: URL: https://github.com/apache/doris/pull/51129#issuecomment-2903159129 ClickBench: Total hot run time: 29.95 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 08c3697b2e7e31492e183bdcbbc67d922f889c7c, data reload: false query1 0.030.030.03 query2 0.140.100.11 query3 0.360.200.20 query4 1.590.200.20 query5 0.470.450.47 query6 1.150.660.67 query7 0.020.020.02 query8 0.050.050.05 query9 0.620.520.52 query10 0.580.580.59 query11 0.260.130.12 query12 0.250.140.13 query13 0.630.620.64 query14 0.810.840.82 query15 0.980.890.87 query16 0.380.370.38 query17 1.071.071.02 query18 0.190.190.18 query19 1.961.901.84 query20 0.010.020.01 query21 15.42 0.970.67 query22 0.941.020.86 query23 14.67 1.520.78 query24 5.400.580.29 query25 0.170.090.08 query26 0.560.220.18 query27 0.090.090.09 query28 11.02 1.210.59 query29 12.55 4.093.49 query30 0.290.090.08 query31 2.810.620.44 query32 3.240.600.51 query33 3.103.133.09 query34 16.50 5.124.42 query35 4.454.524.44 query36 0.650.500.50 query37 0.200.180.17 query38 0.170.150.15 query39 0.050.040.04 query40 0.200.150.16 query41 0.100.070.05 query42 0.060.050.05 query43 0.050.040.04 Total cold run time: 104.24 s Total hot run time: 29.95 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) potential data race when retrying prepare/commit rowset for load [doris]
doris-robot commented on PR #51129: URL: https://github.com/apache/doris/pull/51129#issuecomment-2903153694 TPC-DS: Total hot run time: 193674 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 08c3697b2e7e31492e183bdcbbc67d922f889c7c, data reload: false query1 1400109310781078 query2 6249181017841784 query3 11042 450445894504 query4 54177 26001 23674 23674 query5 5180599 452 452 query6 378 205 193 193 query7 5006532 284 284 query8 316 247 221 221 query9 5891270226862686 query10 447 342 276 276 query11 15084 15101 14778 14778 query12 167 111 104 104 query13 1101543 414 414 query14 10190 637665136376 query15 205 204 187 187 query16 7118665 508 508 query17 1110774 615 615 query18 1558431 347 347 query19 208 206 187 187 query20 134 121 121 121 query21 204 135 114 114 query22 4433446644644464 query23 34281 33527 33927 33527 query24 6609243524942435 query25 485 463 405 405 query26 729 281 154 154 query27 2355516 351 351 query28 3143221321852185 query29 604 555 459 459 query30 276 219 192 192 query31 873 850 789 789 query32 71 64 67 64 query33 464 421 306 306 query34 814 866 545 545 query35 812 863 754 754 query36 928 1030910 910 query37 124 108 82 82 query38 4357426442094209 query39 1701149214811481 query40 211 129 111 111 query41 57 54 55 54 query42 124 111 115 111 query43 507 535 512 512 query44 1411877 847 847 query45 186 185 173 173 query46 861 1040650 650 query47 1826187017931793 query48 413 453 351 351 query49 676 529 446 446 query50 698 709 405 405 query51 4340436242194219 query52 116 114 97 97 query53 229 264 183 183 query54 607 608 520 520 query55 87 82 94 82 query56 336 316 316 316 query57 1206117711421142 query58 274 281 271 271 query59 2715285525742574 query60 356 336 333 333 query61 129 129 124 124 query62 722 729 663 663 query63 225 185 186 185 query64 18081019668 668 query65 4325422342344223 query66 732 401 304 304 query67 15987 15819 15508 15508 query68 6589909 539 539 query69 545 313 286 286 query70 1192114711021102 query71 520 321 302 302 query72 5954477348194773 query73 1439620 358 358 query74 9178891387948794 query75 4097321827952795 query76 42621183745 745 query77 743 392 297 297 query78 10179 10175 92979297 query79 2408807 574 574 query80 627 539 453 453 query81 476 264 221 221 query82 433 135 99 99 query83 306 258 245 245 query84 291 112 98 98 query85 789 354 316 316 query86 366 298 280 280 query87 4486440444264404 query88 3530231323302313 query89 411 331 303 303 query90 1902218 215 215 query91 141 140 114 114 query92 73 60 60 60 query93 1829974 580 580 query94 672 414 288 288 query95 379 303 289 289 query96 500 588 281 281 query97 2715279726782678 query98 245 208 203 203 query99 1449138312921292 Total cold run time: 300114 ms Total hot run time: 193674 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [fix](cloud) potential data race when retrying prepare/commit rowset for load [doris]
doris-robot commented on PR #51129: URL: https://github.com/apache/doris/pull/51129#issuecomment-2903140679 TPC-H: Total hot run time: 33958 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 08c3697b2e7e31492e183bdcbbc67d922f889c7c, data reload: false -- Round 1 -- q1 26553 518651335133 q2 2087281 192 192 q3 10446 1282709 709 q4 10236 1052517 517 q5 7529245123292329 q6 190 162 135 135 q7 978 735 614 614 q8 9307137210681068 q9 6895509250975092 q10 6882232318891889 q11 491 291 272 272 q12 350 354 232 232 q13 17801 369530973097 q14 233 229 211 211 q15 534 487 475 475 q16 440 436 380 380 q17 630 887 378 378 q18 7731727770857085 q19 1624970 596 596 q20 334 346 233 233 q21 3934318123522352 q22 10601000969 969 Total cold run time: 116265 ms Total hot run time: 33958 ms - Round 2, with runtime_filter_mode=off - q1 5250513751425137 q2 245 324 240 240 q3 2187270422922292 q4 1412182815131513 q5 4505442044604420 q6 225 170 130 130 q7 2030194317821782 q8 2614249726112497 q9 7297717472087174 q10 3003316427842784 q11 603 522 513 513 q12 728 784 604 604 q13 3532397034073407 q14 279 305 263 263 q15 519 464 476 464 q16 449 498 442 442 q17 1199154614101410 q18 7851765476427642 q19 884 857 966 857 q20 2000204118661866 q21 4900450143454345 q22 1143108010121012 Total cold run time: 52855 ms Total hot run time: 50794 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) potential data race when retrying prepare/commit rowset for load [doris]
liaoxin01 commented on PR #51129: URL: https://github.com/apache/doris/pull/51129#issuecomment-2903043346 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) potential data race when retrying prepare/commit rowset for load [doris]
doris-robot commented on PR #51129: URL: https://github.com/apache/doris/pull/51129#issuecomment-2900304582 TPC-DS: Total hot run time: 192328 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 12c02b7923e43c1a78827b10dba0bbc3eb1607fa, data reload: false query1 1431108610541054 query2 6360187118681868 query3 10998 460545664566 query4 55639 25386 23135 23135 query5 5179530 460 460 query6 362 208 217 208 query7 4914511 284 284 query8 311 241 242 241 query9 5903262026252620 query10 427 321 258 258 query11 15168 15020 14850 14850 query12 151 109 105 105 query13 1061536 404 404 query14 10217 621662976216 query15 214 199 180 180 query16 7075650 480 480 query17 1091746 582 582 query18 1564427 328 328 query19 205 197 175 175 query20 135 126 119 119 query21 214 128 131 128 query22 4605459842934293 query23 34528 33842 33638 33638 query24 7150244524492445 query25 499 461 404 404 query26 696 279 152 152 query27 2333505 342 342 query28 3241217921532153 query29 580 568 438 438 query30 282 228 195 195 query31 894 866 780 780 query32 79 60 63 60 query33 442 373 322 322 query34 778 861 528 528 query35 803 865 748 748 query36 974 990 902 902 query37 112 101 82 82 query38 4309425741904190 query39 1505146614321432 query40 216 127 114 114 query41 56 54 51 51 query42 128 114 111 111 query43 502 515 495 495 query44 1338828 823 823 query45 183 174 164 164 query46 836 1041662 662 query47 1881185618401840 query48 401 428 313 313 query49 700 515 433 433 query50 662 694 415 415 query51 4252424641984198 query52 113 112 98 98 query53 224 260 186 186 query54 590 590 514 514 query55 93 84 93 84 query56 332 297 297 297 query57 1202123011551155 query58 269 267 259 259 query59 2705284027782778 query60 349 328 316 316 query61 133 127 132 127 query62 734 733 684 684 query63 228 197 190 190 query64 17621032696 696 query65 4317424942374237 query66 722 400 304 304 query67 16116 15684 15314 15314 query68 7268872 518 518 query69 539 307 279 279 query70 1200109810491049 query71 510 332 292 292 query72 5943479848154798 query73 1416644 351 351 query74 9042900186748674 query75 3775320427152715 query76 41671186768 768 query77 637 362 289 289 query78 10166 10172 92789278 query79 2324810 576 576 query80 684 510 439 439 query81 477 260 226 226 query82 444 123 95 95 query83 258 250 244 244 query84 294 108 81 81 query85 777 348 313 313 query86 406 345 298 298 query87 4353445243344334 query88 3514228022612261 query89 399 312 281 281 query90 1786218 212 212 query91 146 146 117 117 query92 71 63 55 55 query93 1988919 577 577 query94 676 395 314 314 query95 375 291 291 291 query96 505 571 282 282 query97 2754277726322632 query98 227 204 203 203 query99 1431139412631263 Total cold run time: 302025 ms Total hot run time: 192328 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [fix](cloud) potential data race when retrying prepare/commit rowset for load [doris]
doris-robot commented on PR #51129: URL: https://github.com/apache/doris/pull/51129#issuecomment-2900316471 ClickBench: Total hot run time: 29.58 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 12c02b7923e43c1a78827b10dba0bbc3eb1607fa, data reload: false query1 0.040.040.03 query2 0.150.100.11 query3 0.340.200.20 query4 1.590.190.19 query5 0.480.450.45 query6 1.160.650.66 query7 0.020.010.01 query8 0.060.050.05 query9 0.610.530.51 query10 0.570.580.57 query11 0.260.130.12 query12 0.250.130.14 query13 0.630.620.63 query14 0.800.830.83 query15 0.960.880.86 query16 0.370.360.37 query17 1.091.021.08 query18 0.170.190.18 query19 1.991.831.88 query20 0.020.020.01 query21 15.42 1.000.67 query22 0.931.090.79 query23 14.70 1.550.75 query24 5.190.650.31 query25 0.170.100.08 query26 0.560.220.18 query27 0.090.090.08 query28 11.08 1.230.59 query29 12.52 4.153.39 query30 0.270.080.06 query31 2.820.630.42 query32 3.230.590.50 query33 3.053.143.10 query34 16.71 5.084.38 query35 4.504.414.49 query36 0.640.500.48 query37 0.210.170.17 query38 0.170.160.16 query39 0.050.040.04 query40 0.190.160.16 query41 0.110.060.05 query42 0.060.040.05 query43 0.060.050.05 Total cold run time: 104.29 s Total hot run time: 29.58 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) potential data race when retrying prepare/commit rowset for load [doris]
doris-robot commented on PR #51129: URL: https://github.com/apache/doris/pull/51129#issuecomment-2900262169 TPC-H: Total hot run time: 33716 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 12c02b7923e43c1a78827b10dba0bbc3eb1607fa, data reload: false -- Round 1 -- q1 26583 501249754975 q2 2059310 196 196 q3 10366 1253735 735 q4 10237 1003527 527 q5 7589233223352332 q6 188 162 131 131 q7 913 774 609 609 q8 9321128810691069 q9 6913507450625062 q10 6867232418971897 q11 487 284 283 283 q12 349 364 209 209 q13 17758 366630513051 q14 239 240 213 213 q15 528 476 491 476 q16 431 439 378 378 q17 613 860 362 362 q18 7594713370667066 q19 1808961 548 548 q20 337 346 225 225 q21 3812315224032403 q22 1078981 969 969 Total cold run time: 116070 ms Total hot run time: 33716 ms - Round 2, with runtime_filter_mode=off - q1 5186506150335033 q2 237 327 230 230 q3 2188264122702270 q4 1357176813311331 q5 4483440344204403 q6 223 169 130 130 q7 2054192017681768 q8 2613262826042604 q9 7363733870197019 q10 3054317227202720 q11 580 515 511 511 q12 688 781 624 624 q13 3533388332823282 q14 285 317 292 292 q15 528 477 474 474 q16 437 474 441 441 q17 1158151314301430 q18 7909757576197575 q19 836 837 970 837 q20 2000196318191819 q21 4906457646404576 q22 1121107210321032 Total cold run time: 52739 ms Total hot run time: 50401 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) potential data race when retrying prepare/commit rowset for load [doris]
liaoxin01 commented on PR #51129: URL: https://github.com/apache/doris/pull/51129#issuecomment-2900163561 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) potential data race when retrying prepare/commit rowset for load [doris]
liaoxin01 commented on PR #51129: URL: https://github.com/apache/doris/pull/51129#issuecomment-2900061801 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
