Re: [PR] [fix](create tablet)Increase the upper limit of tablet creation for a… [doris]
gavinchou commented on code in PR #51617:
URL: https://github.com/apache/doris/pull/51617#discussion_r2142573318
##
be/src/agent/task_worker_pool.cpp:
##
@@ -1563,48 +1616,27 @@ void create_tablet_callback(StorageEngine& engine,
const TAgentTaskRequest& req)
}
});
DorisMetrics::instance()->create_tablet_requests_total->increment(1);
-VLOG_NOTICE << "start to create tablet " << create_tablet_req.tablet_id;
-
std::vector finish_tablet_infos;
-VLOG_NOTICE << "create tablet: " << create_tablet_req;
-Status status = engine.create_tablet(create_tablet_req, profile);
+Status status = check_tablet_limit();
+if (status.ok()) {
+VLOG_NOTICE << "start to create tablet " << create_tablet_req;
+status =
+create_tablet_and_get_info(engine, create_tablet_req, profile,
finish_tablet_infos);
+}
+
if (!status.ok()) {
DorisMetrics::instance()->create_tablet_requests_failed->increment(1);
-LOG_WARNING("failed to create tablet, reason={}", status.to_string())
+LOG_WARNING("failed to create tablet: {}", status.to_string())
.tag("signature", req.signature)
.tag("tablet_id", create_tablet_req.tablet_id)
.error(status);
} else {
-increase_report_version();
-// get path hash of the created tablet
-TabletSharedPtr tablet;
-{
-SCOPED_TIMER(ADD_TIMER(profile, "GetTablet"));
-tablet =
engine.tablet_manager()->get_tablet(create_tablet_req.tablet_id);
-}
-DCHECK(tablet != nullptr);
-TTabletInfo tablet_info;
-tablet_info.tablet_id = tablet->table_id();
-tablet_info.schema_hash = tablet->schema_hash();
-tablet_info.version = create_tablet_req.version;
-// Useless but it is a required field in TTabletInfo
-tablet_info.version_hash = 0;
-tablet_info.row_count = 0;
-tablet_info.data_size = 0;
-tablet_info.__set_path_hash(tablet->data_dir()->path_hash());
-tablet_info.__set_replica_id(tablet->replica_id());
-finish_tablet_infos.push_back(tablet_info);
-LOG_INFO("successfully create tablet")
+LOG_INFO("successfully created tablet")
Review Comment:
also print some useful info like tablet id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [fix](create tablet)Increase the upper limit of tablet creation for a… [doris]
gavinchou commented on code in PR #51617:
URL: https://github.com/apache/doris/pull/51617#discussion_r2142573318
##
be/src/agent/task_worker_pool.cpp:
##
@@ -1563,48 +1616,27 @@ void create_tablet_callback(StorageEngine& engine,
const TAgentTaskRequest& req)
}
});
DorisMetrics::instance()->create_tablet_requests_total->increment(1);
-VLOG_NOTICE << "start to create tablet " << create_tablet_req.tablet_id;
-
std::vector finish_tablet_infos;
-VLOG_NOTICE << "create tablet: " << create_tablet_req;
-Status status = engine.create_tablet(create_tablet_req, profile);
+Status status = check_tablet_limit();
+if (status.ok()) {
+VLOG_NOTICE << "start to create tablet " << create_tablet_req;
+status =
+create_tablet_and_get_info(engine, create_tablet_req, profile,
finish_tablet_infos);
+}
+
if (!status.ok()) {
DorisMetrics::instance()->create_tablet_requests_failed->increment(1);
-LOG_WARNING("failed to create tablet, reason={}", status.to_string())
+LOG_WARNING("failed to create tablet: {}", status.to_string())
.tag("signature", req.signature)
.tag("tablet_id", create_tablet_req.tablet_id)
.error(status);
} else {
-increase_report_version();
-// get path hash of the created tablet
-TabletSharedPtr tablet;
-{
-SCOPED_TIMER(ADD_TIMER(profile, "GetTablet"));
-tablet =
engine.tablet_manager()->get_tablet(create_tablet_req.tablet_id);
-}
-DCHECK(tablet != nullptr);
-TTabletInfo tablet_info;
-tablet_info.tablet_id = tablet->table_id();
-tablet_info.schema_hash = tablet->schema_hash();
-tablet_info.version = create_tablet_req.version;
-// Useless but it is a required field in TTabletInfo
-tablet_info.version_hash = 0;
-tablet_info.row_count = 0;
-tablet_info.data_size = 0;
-tablet_info.__set_path_hash(tablet->data_dir()->path_hash());
-tablet_info.__set_replica_id(tablet->replica_id());
-finish_tablet_infos.push_back(tablet_info);
-LOG_INFO("successfully create tablet")
+LOG_INFO("successfully created tablet")
Review Comment:
also print some useful info like tablet id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [fix](create tablet)Increase the upper limit of tablet creation for a… [doris]
hello-stephen commented on PR #51617: URL: https://github.com/apache/doris/pull/51617#issuecomment-2961350669 # BE UT Coverage Report Increment line coverage `0.00% (0/55)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/91bedd7a4a48a769c4368008c74a50ff1d62a4bb_91bedd7a4a48a769c4368008c74a50ff1d62a4bb/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/91bedd7a4a48a769c4368008c74a50ff1d62a4bb_91bedd7a4a48a769c4368008c74a50ff1d62a4bb/report/index.html) | Category | Coverage | |---|| | Function Coverage | 56.38% (15074/26736) | | Line Coverage | 45.14% (134657/298331) | | Region Coverage | 44.23% (67749/153161) | | Branch Coverage | 38.78% (34737/89564) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](create tablet)Increase the upper limit of tablet creation for a… [doris]
github-actions[bot] commented on PR #51617: URL: https://github.com/apache/doris/pull/51617#issuecomment-2961038740 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](create tablet)Increase the upper limit of tablet creation for a… [doris]
github-actions[bot] commented on PR #51617: URL: https://github.com/apache/doris/pull/51617#issuecomment-2961038789 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](create tablet)Increase the upper limit of tablet creation for a… [doris]
hello-stephen commented on PR #51617: URL: https://github.com/apache/doris/pull/51617#issuecomment-2958919204 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](create tablet)Increase the upper limit of tablet creation for a… [doris]
deardeng commented on PR #51617: URL: https://github.com/apache/doris/pull/51617#issuecomment-2958919787 wait regression case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](create tablet)Increase the upper limit of tablet creation for a… [doris]
deardeng commented on PR #51617: URL: https://github.com/apache/doris/pull/51617#issuecomment-2958919282 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
