Re: [PR] [fix](fe) Avoid offset path for map element cardinality [doris]
hello-stephen commented on PR #63229: URL: https://github.com/apache/doris/pull/63229#issuecomment-4450016472 # FE Regression Coverage Report Increment line coverage ` 6.03% (71/1177)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/63229_3def0fe48b47678ee4aac89f153ea706c5ce53e9_merge_fe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/63229_3def0fe48b47678ee4aac89f153ea706c5ce53e9_merge_fe/report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](fe) Avoid offset path for map element cardinality [doris]
hello-stephen commented on PR #63229: URL: https://github.com/apache/doris/pull/63229#issuecomment-4448986191 # FE UT Coverage Report Increment line coverage ` 78.89% (71/90)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/63229_3def0fe48b47678ee4aac89f153ea706c5ce53e9/fe_increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/63229_3def0fe48b47678ee4aac89f153ea706c5ce53e9/fe_report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](fe) Avoid offset path for map element cardinality [doris]
hello-stephen commented on PR #63229: URL: https://github.com/apache/doris/pull/63229#issuecomment-4448680733 TPC-DS: Total hot run time: 171088 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 3def0fe48b47678ee4aac89f153ea706c5ce53e9, data reload: false query5 4347667 523 523 query6 350 244 211 211 query7 4230592 306 306 query8 340 242 227 227 query9 8861410240474047 query10 459 354 312 312 query11 5795242621802180 query12 178 135 132 132 query13 1297613 451 451 query14 6788536850545054 query14_14395439143724372 query15 217 205 190 190 query16 1007453 453 453 query17 1376765 641 641 query18 2763501 377 377 query19 266 212 169 169 query20 143 135 130 130 query21 219 146 118 118 query22 13681 13589 13330 13330 query23 17227 16491 16034 16034 query23_116175 16196 16280 16196 query24 7362172613481348 query24_11369135013481348 query25 559 489 444 444 query26 1168333 168 168 query27 2644590 347 347 query28 4342196919421942 query29 1003639 523 523 query30 310 252 201 201 query31 11501057936 936 query32 97 89 87 87 query33 550 362 300 300 query34 11701097641 641 query35 769 806 657 657 query36 1333135911581158 query37 160 103 93 93 query38 3216312530433043 query39 943 931 880 880 query39_1879 894 879 879 query40 234 154 139 139 query41 66 62 65 62 query42 113 113 108 108 query43 323 330 297 297 query44 query45 211 198 198 198 query46 10861176721 721 query47 2293238021572157 query48 392 403 302 302 query49 641 533 435 435 query50 712 286 217 217 query51 4276436442834283 query52 107 103 101 101 query53 252 271 202 202 query54 330 270 279 270 query55 92 91 84 84 query56 309 301 303 301 query57 1438139013021302 query58 305 267 264 264 query59 1550164214861486 query60 349 331 324 324 query61 161 155 156 155 query62 677 640 559 559 query63 257 209 201 201 query64 2122817 691 691 query65 query66 1640531 397 397 query67 30360 30002 29832 29832 query68 query69 444 346 304 304 query70 1000938 944 938 query71 297 269 279 269 query72 2954268724452445 query73 816 768 417 417 query74 5084490547334733 query75 2798266423142314 query76 22701115769 769 query77 416 416 340 340 query78 12939 12900 12287 12287 query79 1515986 739 739 query80 1044590 500 500 query81 507 275 241 241 query82 1344163 131 131 query83 350 280 253 253 query84 266 145 109 109 query85 953 513 453 453 query86 435 353 315 315 query87 3439335432113211 query88 3502264326472643 query89 446 387 337 337 query90 1797179 183 179 query91 181 168 139 139 query92 80 77 77 77 query93 950 941 552 552 query94 659 340 281 281 query95 676 465 344 344 query96 971 766 331 331 query97 2717268825662566 query98 246 233 230 230 query99 11191118992 992 Total cold run time: 254547 ms Total hot run time: 171088 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]
Re: [PR] [fix](fe) Avoid offset path for map element cardinality [doris]
hello-stephen commented on PR #63229: URL: https://github.com/apache/doris/pull/63229#issuecomment-4448604302 TPC-H: Total hot run time: 29619 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 3def0fe48b47678ee4aac89f153ea706c5ce53e9, data reload: false -- Round 1 -- orders Doris NULLNULL0 0 0 NULL0 NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8 NULLNULL q1 17691 395442313954 q2 q3 10712 865 605 605 q4 4661454 349 349 q5 7442131511411141 q6 188 168 142 142 q7 908 957 731 731 q8 9563142512441244 q9 6332539353205320 q10 6330207218091809 q11 473 267 257 257 q12 681 413 297 297 q13 18268 346927382738 q14 300 281 268 268 q15 q16 897 864 796 796 q17 11171009784 784 q18 6460561655695569 q19 1675126710801080 q20 512 397 258 258 q21 5303238719401940 q22 470 384 337 337 Total cold run time: 99983 ms Total hot run time: 29619 ms - Round 2, with runtime_filter_mode=off - orders Doris NULLNULL15000 42 6422171781 NULL22778155NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8 NULLNULL q1 4733459546164595 q2 q3 4650477342094209 q4 2132218114151415 q5 5005507152665071 q6 199 168 140 140 q7 2087179116151615 q8 3444313031173117 q9 8445872384598459 q10 4474447642314231 q11 637 424 399 399 q12 719 765 530 530 q13 3257360328992899 q14 310 309 273 273 q15 q16 761 807 684 684 q17 1355130512541254 q18 8022733172977297 q19 1145116711751167 q20 227619881988 q21 6259548148944894 q22 514 470 395 395 Total cold run time: 60424 ms Total hot run time: 54632 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](fe) Avoid offset path for map element cardinality [doris]
hello-stephen commented on PR #63229: URL: https://github.com/apache/doris/pull/63229#issuecomment-4448602169 TPC-DS: Total hot run time: 171114 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 3a42147372e5b716c501775404c79cb586e0100f, data reload: false query5 4307659 508 508 query6 342 221 197 197 query7 4217559 295 295 query8 315 234 211 211 query9 8824397640103976 query10 465 327 300 300 query11 6013240422292229 query12 181 126 138 126 query13 1297598 415 415 query14 6868534750565056 query14_14391438643164316 query15 222 207 185 185 query16 1010467 430 430 query17 1397800 624 624 query18 2759486 353 353 query19 311 193 162 162 query20 141 130 129 129 query21 214 137 117 117 query22 13582 14055 14476 14055 query23 17316 16474 16163 16163 query23_116407 16241 16218 16218 query24 8297183713531353 query24_11367139814061398 query25 553 488 438 438 query26 1144330 165 165 query27 2657569 325 325 query28 4306191219161912 query29 1003635 495 495 query30 289 229 193 193 query31 11071085930 930 query32 79 70 71 70 query33 523 353 279 279 query34 11341147628 628 query35 794 776 656 656 query36 1410135911521152 query37 146 100 83 83 query38 3208309930753075 query39 909 913 876 876 query39_1898 872 881 872 query40 234 155 134 134 query41 62 60 60 60 query42 109 106 103 103 query43 320 321 282 282 query44 query45 209 203 190 190 query46 10451143710 710 query47 2295228321882188 query48 406 402 294 294 query49 632 522 420 420 query50 710 282 225 225 query51 4312425042574250 query52 102 106 102 102 query53 261 275 205 205 query54 311 285 250 250 query55 90 86 81 81 query56 292 308 305 305 query57 1416139313061306 query58 307 281 268 268 query59 1596157913791379 query60 338 331 311 311 query61 164 159 154 154 query62 671 622 565 565 query63 249 202 210 202 query64 2131802 678 678 query65 query66 1634507 404 404 query67 30128 29248 29716 29248 query68 query69 463 344 310 310 query70 1057997 1002997 query71 303 282 273 273 query72 3181290926332633 query73 810 747 433 433 query74 5056492647194719 query75 2812269123342334 query76 23011173760 760 query77 410 414 341 341 query78 12876 12947 12336 12336 query79 1477953 712 712 query80 1367588 486 486 query81 525 284 238 238 query82 948 160 118 118 query83 353 294 266 266 query84 277 142 135 135 query85 894 520 433 433 query86 450 319 308 308 query87 3393334431953195 query88 3501265826702658 query89 434 384 338 338 query90 1973183 178 178 query91 182 164 138 138 query92 77 77 71 71 query93 1094974 576 576 query94 714 341 289 289 query95 673 376 439 376 query96 1026750 320 320 query97 2699270125732573 query98 238 224 249 224 query99 11211112976 976 Total cold run time: 255927 ms Total hot run time: 171114 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]
Re: [PR] [fix](fe) Avoid offset path for map element cardinality [doris]
hello-stephen commented on PR #63229: URL: https://github.com/apache/doris/pull/63229#issuecomment-4448532332 TPC-H: Total hot run time: 29372 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 3a42147372e5b716c501775404c79cb586e0100f, data reload: false -- Round 1 -- orders Doris NULLNULL0 0 0 NULL0 NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8 NULLNULL q1 17686 387138823871 q2 q3 10718 868 606 606 q4 4659448 352 352 q5 7457131111351135 q6 193 169 136 136 q7 901 951 733 733 q8 9493138812431243 q9 5987541853245324 q10 6315210718271827 q11 481 265 254 254 q12 686 422 299 299 q13 18165 331426962696 q14 287 282 259 259 q15 q16 895 876 793 793 q17 938 977 702 702 q18 6458569756215621 q19 1394129510901090 q20 511 390 259 259 q21 4633227718681868 q22 412 357 304 304 Total cold run time: 98269 ms Total hot run time: 29372 ms - Round 2, with runtime_filter_mode=off - orders Doris NULLNULL15000 42 6422171781 NULL22778155NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8 NULLNULL q1 4197409840924092 q2 q3 4628475841644164 q4 2064217913751375 q5 4925499552184995 q6 193 163 132 132 q7 2040175020061750 q8 3469327131803180 q9 8468847983898389 q10 4460447842404240 q11 593 428 409 409 q12 701 747 563 563 q13 3224360529622962 q14 301 315 275 275 q15 q16 776 830 687 687 q17 1329131212471247 q18 8221722570337033 q19 1112113211551132 q20 2233223419471947 q21 6078543348764876 q22 547 524 431 431 Total cold run time: 59559 ms Total hot run time: 53879 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](fe) Avoid offset path for map element cardinality [doris]
englefly commented on PR #63229: URL: https://github.com/apache/doris/pull/63229#issuecomment-4448408554 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](fe) Avoid offset path for map element cardinality [doris]
englefly commented on PR #63229: URL: https://github.com/apache/doris/pull/63229#issuecomment-4448382295 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](fe) Avoid offset path for map element cardinality [doris]
hello-stephen commented on PR #63229: URL: https://github.com/apache/doris/pull/63229#issuecomment-676835 # FE Regression Coverage Report Increment line coverage ` 33.33% (2/6)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/63229_338bf528a61228449828028d0375b3e03b2eff4a_merge_fe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/63229_338bf528a61228449828028d0375b3e03b2eff4a_merge_fe/report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](fe) Avoid offset path for map element cardinality [doris]
github-actions[bot] commented on code in PR #63229:
URL: https://github.com/apache/doris/pull/63229#discussion_r3236608463
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/AccessPathExpressionCollector.java:
##
@@ -245,6 +247,11 @@ public Void visitCardinality(Cardinality cardinality,
CollectorContext context)
return visit(cardinality, context);
}
+private boolean isMapElementAccessResult(Expression arg) {
+return arg instanceof ElementAt
+&& ((ElementAt)
arg).getArguments().get(0).getDataType().isMapType();
Review Comment:
This only catches a bare `ElementAt`. If the map lookup is wrapped in a
no-op cast, for example `cardinality(CAST(element_at(struct_element(s, 'm'),
'null') AS ARRAY>))`, `visitCardinality`
still takes the offset-only branch because the argument type is `ARRAY` and the
argument itself is `Cast`, not `ElementAt`. Then `visitCast` forwards the
`OFFSET` suffix to `visitElementAt`, producing the same invalid `s.m.*.OFFSET`
access path this PR is trying to avoid. Please detect map-element access
through transparent wrappers (or avoid pushing `OFFSET` once traversal reaches
a map `ElementAt`) and add coverage for that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [fix](fe) Avoid offset path for map element cardinality [doris]
hello-stephen commented on PR #63229: URL: https://github.com/apache/doris/pull/63229#issuecomment-4443620524 TPC-DS: Total hot run time: 170201 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 338bf528a61228449828028d0375b3e03b2eff4a, data reload: false query5 4358673 519 519 query6 338 220 209 209 query7 4220564 300 300 query8 327 235 224 224 query9 8828400340374003 query10 475 350 294 294 query11 58082427 query12 179 129 121 121 query13 1299581 495 495 query14 6315531150255025 query14_14318434643054305 query15 210 204 184 184 query16 1005458 444 444 query17 1116744 617 617 query18 2746481 346 346 query19 218 201 161 161 query20 137 135 129 129 query21 214 137 115 115 query22 13632 13501 13258 13258 query23 17131 16430 16009 16009 query23_116131 16179 16196 16179 query24 7576175113411341 query24_11346132313521323 query25 553 494 445 445 query26 1309327 169 169 query27 2753615 353 353 query28 4420195719381938 query29 998 639 503 503 query30 312 242 208 208 query31 11271064933 933 query32 80 75 78 75 query33 550 357 289 289 query34 11811179655 655 query35 766 795 666 666 query36 1300133211461146 query37 156 102 84 84 query38 3196314030353035 query39 929 938 922 922 query39_1886 865 864 864 query40 234 155 139 139 query41 69 75 61 61 query42 109 107 105 105 query43 321 332 293 293 query44 query45 219 203 198 198 query46 11321200714 714 query47 2299237622702270 query48 421 437 305 305 query49 668 549 466 466 query50 705 294 216 216 query51 4366425842974258 query52 116 108 99 99 query53 261 292 216 216 query54 338 287 273 273 query55 95 97 91 91 query56 314 357 336 336 query57 1469145913231323 query58 314 283 281 281 query59 1582159213711371 query60 388 347 333 333 query61 183 184 179 179 query62 694 635 564 564 query63 251 209 212 209 query64 2401885 741 741 query65 query66 1758524 416 416 query67 29917 29891 29850 29850 query68 query69 468 350 316 316 query70 1018995 996 995 query71 305 292 278 278 query72 3136271223842384 query73 872 722 442 442 query74 5032491847214721 query75 2781263823162316 query76 23011144753 753 query77 406 412 361 361 query78 13015 12863 12230 12230 query79 1484992 737 737 query80 1182586 526 526 query81 495 276 235 235 query82 1318157 126 126 query83 365 284 249 249 query84 265 144 111 111 query85 917 516 440 440 query86 444 351 331 331 query87 3399334432183218 query88 3566268526532653 query89 440 382 337 337 query90 1793181 180 180 query91 178 173 138 138 query92 83 78 74 74 query93 967 961 560 560 query94 608 349 326 326 query95 659 457 341 341 query96 1022779 343 343 query97 2705270525532553 query98 256 233 232 232 query99 11471109982 982 Total cold run time: 254520 ms Total hot run time: 170201 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]
Re: [PR] [fix](fe) Avoid offset path for map element cardinality [doris]
hello-stephen commented on PR #63229: URL: https://github.com/apache/doris/pull/63229#issuecomment-4443536479 TPC-H: Total hot run time: 29523 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 338bf528a61228449828028d0375b3e03b2eff4a, data reload: false -- Round 1 -- orders Doris NULLNULL0 0 0 NULL0 NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8 NULLNULL q1 17637 391939393919 q2 q3 10717 868 649 649 q4 4652459 355 355 q5 7469131511341134 q6 191 171 144 144 q7 902 953 752 752 q8 9296138712521252 q9 6030535453065306 q10 6316213918021802 q11 478 264 260 260 q12 673 413 296 296 q13 18186 349227012701 q14 287 282 260 260 q15 q16 901 860 778 778 q17 10071001739 739 q18 6484556956485569 q19 1307132810801080 q20 515 404 255 255 q21 4979234019471947 q22 481 385 325 325 Total cold run time: 98508 ms Total hot run time: 29523 ms - Round 2, with runtime_filter_mode=off - orders Doris NULLNULL15000 42 6422171781 NULL22778155NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8 NULLNULL q1 4638455445444544 q2 q3 4663474842074207 q4 2140217914221422 q5 4994501252865012 q6 222 173 134 134 q7 2027179116721672 q8 3367309330943093 q9 8400857184038403 q10 4470449242524252 q11 576 419 398 398 q12 694 760 519 519 q13 3214358029242924 q14 317 312 291 291 q15 q16 769 797 705 705 q17 1345132013051305 q18 7984708570637063 q19 1161117011521152 q20 2256224419471947 q21 6190541050725072 q22 520 479 408 408 Total cold run time: 59947 ms Total hot run time: 54523 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](fe) Avoid offset path for map element cardinality [doris]
github-actions[bot] commented on PR #63229: URL: https://github.com/apache/doris/pull/63229#issuecomment-4443251497 OpenCode automated review failed and did not complete. Error: Review step was skipped (possibly timeout or cancelled) Workflow run: https://github.com/apache/doris/actions/runs/25805360151 Please inspect the workflow logs and rerun the review after the underlying issue is resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](fe) Avoid offset path for map element cardinality [doris]
englefly commented on PR #63229: URL: https://github.com/apache/doris/pull/63229#issuecomment-4442954862 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](fe) Avoid offset path for map element cardinality [doris]
englefly commented on PR #63229: URL: https://github.com/apache/doris/pull/63229#issuecomment-4442953658 /review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](fe) Avoid offset path for map element cardinality [doris]
hello-stephen commented on PR #63229: URL: https://github.com/apache/doris/pull/63229#issuecomment-4442787859 # FE UT Coverage Report Increment line coverage ` 40.00% (2/5)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/63229_3fe5debf3dc36d70d3a10316bf4cbdc783b388db/fe_increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/63229_3fe5debf3dc36d70d3a10316bf4cbdc783b388db/fe_report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](fe) Avoid offset path for map element cardinality [doris]
hello-stephen commented on PR #63229: URL: https://github.com/apache/doris/pull/63229#issuecomment-4442360716 TPC-DS: Total hot run time: 170352 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 3fe5debf3dc36d70d3a10316bf4cbdc783b388db, data reload: false query5 4314661 506 506 query6 325 221 203 203 query7 4215548 313 313 query8 329 234 221 221 query9 8798399739973997 query10 466 345 303 303 query11 5790236421862186 query12 181 129 120 120 query13 1288611 410 410 query14 5955535450545054 query14_14355436643294329 query15 211 205 184 184 query16 1002462 440 440 query17 1144783 618 618 query18 2440480 355 355 query19 219 205 178 178 query20 145 139 133 133 query21 219 141 120 120 query22 13566 13821 14677 13821 query23 17244 16520 16210 16210 query23_116344 16386 16303 16303 query24 7414177713401340 query24_11356136213361336 query25 606 512 472 472 query26 1304320 177 177 query27 2692550 342 342 query28 4450197019491949 query29 1033652 549 549 query30 306 234 201 201 query31 11011067953 953 query32 97 75 75 75 query33 539 359 298 298 query34 11591102624 624 query35 773 771 672 672 query36 1323136411461146 query37 149 102 90 90 query38 3225316630993099 query39 932 903 924 903 query39_1869 854 874 854 query40 234 153 144 144 query41 62 59 61 59 query42 115 106 108 106 query43 323 320 279 279 query44 query45 211 194 189 189 query46 10841204734 734 query47 2318233322022202 query48 414 422 301 301 query49 648 517 448 448 query50 680 280 227 227 query51 4277429042254225 query52 108 105 92 92 query53 246 273 198 198 query54 307 274 257 257 query55 92 87 85 85 query56 289 318 314 314 query57 1411138613051305 query58 298 277 258 258 query59 1560159713471347 query60 353 333 325 325 query61 162 153 155 153 query62 660 618 559 559 query63 236 201 202 201 query64 2514817 676 676 query65 query66 1741516 395 395 query67 30027 29363 29925 29363 query68 query69 465 342 304 304 query70 1008973 971 971 query71 311 299 274 274 query72 2919267125052505 query73 810 766 423 423 query74 5068495347294729 query75 2762266423292329 query76 23361117759 759 query77 424 435 345 345 query78 12873 12977 12387 12387 query79 1529985 735 735 query80 1364567 501 501 query81 514 283 237 237 query82 1001157 116 116 query83 354 278 247 247 query84 252 141 107 107 query85 917 499 445 445 query86 454 326 349 326 query87 3403337232083208 query88 3529267726452645 query89 444 383 337 337 query90 1937184 172 172 query91 182 172 134 134 query92 76 75 73 73 query93 1208944 555 555 query94 725 351 297 297 query95 663 478 346 346 query96 1023781 342 342 query97 2674267226042604 query98 233 232 228 228 query99 11251109971 971 Total cold run time: 253811 ms Total hot run time: 170352 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]
Re: [PR] [fix](fe) Avoid offset path for map element cardinality [doris]
hello-stephen commented on PR #63229: URL: https://github.com/apache/doris/pull/63229#issuecomment-4442237792 TPC-H: Total hot run time: 29771 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 3fe5debf3dc36d70d3a10316bf4cbdc783b388db, data reload: false -- Round 1 -- orders Doris NULLNULL0 0 0 NULL0 NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8 NULLNULL q1 17632 403539463946 q2 q3 10715 869 614 614 q4 4658455 348 348 q5 7456134511571157 q6 192 176 157 157 q7 924 945 767 767 q8 9305141912841284 q9 5683532853395328 q10 6243208818201820 q11 461 269 263 263 q12 624 412 289 289 q13 18093 332627862786 q14 289 286 268 268 q15 q16 890 853 784 784 q17 985 1043747 747 q18 6407569555295529 q19 1175125411251125 q20 524 401 263 263 q21 4531243019721972 q22 481 435 324 324 Total cold run time: 97268 ms Total hot run time: 29771 ms - Round 2, with runtime_filter_mode=off - orders Doris NULLNULL15000 42 6422171781 NULL22778155NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8 NULLNULL q1 4834479352574793 q2 q3 4686482242244224 q4 2243222914771477 q5 5027506253335062 q6 211 182 143 143 q7 2066178616141614 q8 3394311731393117 q9 8398854884748474 q10 4506450742734273 q11 637 444 429 429 q12 705 745 526 526 q13 3310362229262926 q14 310 323 283 283 q15 q16 964 803 678 678 q17 1395138113301330 q18 8099713972477139 q19 1177118511571157 q20 2240225719511951 q21 6346579450965096 q22 576 540 436 436 Total cold run time: 61124 ms Total hot run time: 55128 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](fe) Avoid offset path for map element cardinality [doris]
hello-stephen commented on PR #63229: URL: https://github.com/apache/doris/pull/63229#issuecomment-4441997655 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](fe) Avoid offset path for map element cardinality [doris]
englefly commented on PR #63229: URL: https://github.com/apache/doris/pull/63229#issuecomment-4441999369 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](fe) Avoid offset path for map element cardinality [doris]
englefly commented on PR #63229: URL: https://github.com/apache/doris/pull/63229#issuecomment-4441998581 /review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
