Re: [PR] [fix](nereids) Fix the expr id are same but different expr when agg table with random distribute [doris]
starocean999 merged PR #52993: URL: https://github.com/apache/doris/pull/52993 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](nereids) Fix the expr id are same but different expr when agg table with random distribute [doris]
github-actions[bot] commented on PR #52993: URL: https://github.com/apache/doris/pull/52993#issuecomment-3087196711 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](nereids) Fix the expr id are same but different expr when agg table with random distribute [doris]
github-actions[bot] commented on PR #52993: URL: https://github.com/apache/doris/pull/52993#issuecomment-3087196405 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](nereids) Fix the expr id are same but different expr when agg table with random distribute [doris]
hello-stephen commented on PR #52993: URL: https://github.com/apache/doris/pull/52993#issuecomment-3051549641 # FE UT Coverage Report Increment line coverage ` 100.00% (2/2)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/52993_bf922e703b4553d8c3b34d106fbef86efe16d694/fe_increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/52993_bf922e703b4553d8c3b34d106fbef86efe16d694/fe_report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](nereids) Fix the expr id are same but different expr when agg table with random distribute [doris]
doris-robot commented on PR #52993: URL: https://github.com/apache/doris/pull/52993#issuecomment-3051432672 TPC-DS: Total hot run time: 186196 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit bf922e703b4553d8c3b34d106fbef86efe16d694, data reload: false query1 1007391 386 386 query2 6497166216591659 query3 6736207 208 207 query4 26174 23306 23604 23306 query5 4359576 440 440 query6 314 217 196 196 query7 4622493 285 285 query8 269 224 221 221 query9 8611265326592653 query10 481 324 268 268 query11 15682 15082 14881 14881 query12 152 108 105 105 query13 1654521 402 402 query14 9245585858335833 query15 209 190 171 171 query16 7668446 267 267 query17 1302717 596 596 query18 2011411 314 314 query19 198 191 163 163 query20 129 120 116 116 query21 210 121 102 102 query22 4128427441434143 query23 34139 33267 33024 33024 query24 8473232823752328 query25 531 472 411 411 query26 1232258 146 146 query27 2776495 340 340 query28 4289212221182118 query29 725 571 441 441 query30 285 221 196 196 query31 982 820 750 750 query32 71 66 64 64 query33 551 328 290 290 query34 803 848 528 528 query35 606 655 550 550 query36 950 982 889 889 query37 115 103 73 73 query38 4178419941804180 query39 1498142414541424 query40 214 119 106 106 query41 56 54 55 54 query42 125 116 119 116 query43 517 501 494 494 query44 1299824 824 824 query45 173 169 171 169 query46 837 1027628 628 query47 1751183217181718 query48 377 417 324 324 query49 747 481 403 403 query50 645 691 419 419 query51 4136429042374237 query52 105 113 97 97 query53 225 251 182 182 query54 568 557 510 510 query55 83 76 84 76 query56 301 316 305 305 query57 1220119811281128 query58 259 262 264 262 query59 2502265725272527 query60 322 326 310 310 query61 129 128 125 125 query62 804 713 631 631 query63 224 186 188 186 query64 44001180854 854 query65 4256417841654165 query66 1072405 312 312 query67 15960 15713 15550 15550 query68 8317873 527 527 query69 497 306 275 275 query70 1174111310481048 query71 490 347 309 309 query72 5654470847254708 query73 697 576 348 348 query74 8911911289688968 query75 3859317326862686 query76 37011141690 690 query77 767 355 277 277 query78 10984 11054 10139 10139 query79 2329876 593 593 query80 605 511 438 438 query81 472 262 222 222 query82 467 124 97 97 query83 248 251 235 235 query84 245 105 86 86 query85 824 367 315 315 query86 387 311 290 290 query87 445243464346 query88 3503231322742274 query89 385 316 289 289 query90 1897217 211 211 query91 140 143 111 111 query92 76 57 55 55 query93 1673947 587 587 query94 676 317 203 203 query95 376 298 295 295 query96 490 568 279 279 query97 2691276225992599 query98 231 217 219 217 query99 1445142313011301 Total cold run time: 275824 ms Total hot run time: 186196 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [fix](nereids) Fix the expr id are same but different expr when agg table with random distribute [doris]
doris-robot commented on PR #52993: URL: https://github.com/apache/doris/pull/52993#issuecomment-3051446933 ClickBench: Total hot run time: 29.67 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit bf922e703b4553d8c3b34d106fbef86efe16d694, data reload: false query1 0.040.040.03 query2 0.080.040.04 query3 0.240.070.07 query4 1.600.110.11 query5 0.430.420.43 query6 1.160.680.66 query7 0.020.020.02 query8 0.040.040.04 query9 0.620.530.51 query10 0.570.570.56 query11 0.160.100.11 query12 0.160.120.11 query13 0.630.600.61 query14 0.790.810.82 query15 0.920.890.86 query16 0.390.390.41 query17 1.081.081.07 query18 0.230.210.21 query19 2.001.871.87 query20 0.020.020.02 query21 15.38 0.880.53 query22 0.761.150.62 query23 15.01 1.400.65 query24 6.981.360.77 query25 0.450.150.11 query26 0.630.180.13 query27 0.070.060.06 query28 9.570.880.46 query29 12.58 3.933.32 query30 0.240.090.07 query31 2.830.600.39 query32 3.240.550.50 query33 3.033.113.11 query34 16.09 5.364.76 query35 4.784.864.84 query36 0.720.510.50 query37 0.100.070.07 query38 0.050.040.04 query39 0.030.020.02 query40 0.170.140.14 query41 0.080.030.03 query42 0.030.020.02 query43 0.040.030.03 Total cold run time: 104.04 s Total hot run time: 29.67 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](nereids) Fix the expr id are same but different expr when agg table with random distribute [doris]
doris-robot commented on PR #52993: URL: https://github.com/apache/doris/pull/52993#issuecomment-3051403155 TPC-H: Total hot run time: 33745 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit bf922e703b4553d8c3b34d106fbef86efe16d694, data reload: false -- Round 1 -- q1 17591 512151175117 q2 1934286 183 183 q3 10310 1299759 759 q4 10229 1047569 569 q5 7660235524262355 q6 182 165 131 131 q7 913 775 622 622 q8 9314139311361136 q9 6807507951325079 q10 6917235119591959 q11 491 288 288 288 q12 341 364 232 232 q13 17774 367832043204 q14 223 229 220 220 q15 555 476 476 476 q16 442 431 397 397 q17 607 879 349 349 q18 7631728270847084 q19 12181108578 578 q20 337 346 223 223 q21 4035326824832483 q22 364 339 301 301 Total cold run time: 105875 ms Total hot run time: 33745 ms - Round 2, with runtime_filter_mode=off - q1 5151529951385138 q2 245 327 212 212 q3 2157269922672267 q4 1408182013491349 q5 4282442245774422 q6 213 170 123 123 q7 2055197017551755 q8 2709247326952473 q9 7382726772247224 q10 3112329028602860 q11 581 553 485 485 q12 743 781 658 658 q13 3793396133623362 q14 288 315 282 282 q15 515 472 522 472 q16 491 520 454 454 q17 1178156114571457 q18 7892811475307530 q19 853 889 1011889 q20 2069196218061806 q21 4905441443514351 q22 627 628 555 555 Total cold run time: 52649 ms Total hot run time: 50124 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](nereids) Fix the expr id are same but different expr when agg table with random distribute [doris]
morrySnow commented on code in PR #52993:
URL: https://github.com/apache/doris/pull/52993#discussion_r2194182051
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindRelation.java:
##
@@ -292,8 +292,8 @@ private LogicalPlan
preAggForRandomDistribution(LogicalOlapScan olapScan) {
if (function == null) {
return olapScan;
}
-Alias alias = new Alias(exprId, ImmutableList.of(function),
col.getName(),
-olapScan.qualified(), true);
+Alias alias = new Alias(StatementScopeIdGenerator.newExprId(),
ImmutableList.of(function),
Review Comment:
add a new ctor for Alias accept four args as children, name, qualifier and
nameFromChild
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [fix](nereids) Fix the expr id are same but different expr when agg table with random distribute [doris]
Thearas commented on PR #52993: URL: https://github.com/apache/doris/pull/52993#issuecomment-3051308539 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](nereids) Fix the expr id are same but different expr when agg table with random distribute [doris]
seawinde commented on PR #52993: URL: https://github.com/apache/doris/pull/52993#issuecomment-3051309400 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
