Re: [PR] [fix](nereids) set CompoundPredicate.nullableFromNereids after flattern and/or [doris]

2025-08-10 Thread via GitHub


englefly merged PR #54353:
URL: https://github.com/apache/doris/pull/54353


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](nereids) set CompoundPredicate.nullableFromNereids after flattern and/or [doris]

2025-08-10 Thread via GitHub


github-actions[bot] commented on PR #54353:
URL: https://github.com/apache/doris/pull/54353#issuecomment-3173137282

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](nereids) set CompoundPredicate.nullableFromNereids after flattern and/or [doris]

2025-08-07 Thread via GitHub


doris-robot commented on PR #54353:
URL: https://github.com/apache/doris/pull/54353#issuecomment-3166773918

   
   
   ClickBench: Total hot run time: 33.2 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 5c7e1f244e99acfe291fabbe969cba403fef0ab7, 
data reload: false
   
   query1   0.040.040.03
   query2   0.080.040.04
   query3   0.250.070.08
   query4   1.620.110.11
   query5   0.420.410.43
   query6   1.170.680.68
   query7   0.020.020.02
   query8   0.050.030.04
   query9   0.540.480.47
   query10  0.520.520.54
   query11  0.160.110.11
   query12  0.150.110.11
   query13  0.650.660.65
   query14  0.961.061.18
   query15  0.900.890.90
   query16  0.380.390.42
   query17  1.091.071.07
   query18  0.220.200.20
   query19  1.991.991.97
   query20  0.020.010.01
   query21  15.38   0.860.56
   query22  0.791.200.69
   query23  14.83   1.130.66
   query24  6.801.180.51
   query25  0.520.280.06
   query26  0.660.150.13
   query27  0.060.050.05
   query28  10.00   0.850.46
   query29  12.60   3.893.35
   query30  3.043.002.95
   query31  2.820.560.40
   query32  3.250.570.49
   query33  3.013.193.24
   query34  16.24   5.335.03
   query35  4.915.044.95
   query36  0.700.520.51
   query37  0.100.080.07
   query38  0.070.050.04
   query39  0.030.030.03
   query40  0.180.140.14
   query41  0.080.040.03
   query42  0.040.030.03
   query43  0.040.040.03
   Total cold run time: 107.38 s
   Total hot run time: 33.2 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](nereids) set CompoundPredicate.nullableFromNereids after flattern and/or [doris]

2025-08-07 Thread via GitHub


doris-robot commented on PR #54353:
URL: https://github.com/apache/doris/pull/54353#issuecomment-3166763108

   
   
   TPC-DS: Total hot run time: 160349 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 5c7e1f244e99acfe291fabbe969cba403fef0ab7, 
data reload: false
   
   reason   Doris   NULLNULL0   0   0   NULL0   
NULLNULL2023-12-26 22:43:56 2023-12-26 22:44:01 NULLutf-8   
NULLNULL
   
   query1   995 380 440 380
   query2   6529183316611661
   query3   6747232 227 227
   query4   27161   23164   22919   22919
   query5   4363638 535 535
   query6   323 240 238 238
   query7   4635525 289 289
   query8   297 259 216 216
   query9   8558299829762976
   query10  470 341 289 289
   query11  15987   14962   14717   14717
   query12  182 134 133 133
   query13  1656565 452 452
   query14  8599583957535753
   query15  209 196 169 169
   query16  7280671 487 487
   query17  1241787 634 634
   query18  2191444 336 336
   query19  264 254 188 188
   query20  155 143 139 139
   query21  216 128 113 113
   query22  3864410440004000
   query23  34484   34472   34136   34136
   query24  8164244824652448
   query25  564 538 445 445
   query26  1236293 170 170
   query27  2634502 357 357
   query28  4243234823312331
   query29  804 633 500 500
   query30  296 228 197 197
   query31  920 783 749 749
   query32  88  79  78  78
   query33  565 409 375 375
   query34  811 869 519 519
   query35  798 838 762 762
   query36  10451049962 962
   query37  133 116 94  94
   query38  3948393238953895
   query39  1460139313711371
   query40  239 144 131 131
   query41  67  56  88  56
   query42  147 134 131 131
   query43  531 522 478 478
   query44  1411879 896 879
   query45  203 192 183 183
   query46  955 1061665 665
   query47  1808182417751775
   query48  415 425 323 323
   query49  728 505 408 408
   query50  680 694 415 415
   query51  4205423940914091
   query52  126 130 126 126
   query53  256 295 215 215
   query54  652 644 566 566
   query55  93  88  90  88
   query56  360 378 361 361
   query57  1187120211401140
   query58  348 348 355 348
   query59  2615257025462546
   query60  431 424 409 409
   query61  154 146 150 146
   query62  801 744 696 696
   query63  250 224 217 217
   query64  44321165851 851
   query65  4235413940924092
   query66  1175456 339 339
   query67  query68 17603   623 595 595
   query69  1010334 290 290
   query70  1438111811071107
   query71  687 351 351 351
   query72  9170230323492303
   query73  4088659 350 350
   query74  9049896485158515
   query75  7302314126662666
   query76  85821242802 802
   query77  1201429 344 344
   query78  query79 17198   612 577 577
   query80  1844583 484 484
   query81  561 271 244 244
   query82  461 162 121 121
   query83  346 284 266 266
   query84  297 101 82  82
   query85  1687408 342 342
   query86  349 333 315 315
   query87  4225419040694069
   query88  5546221922102210
   query89  506 371 316 316
   query90  2582240 229 229
   query91  150 138 114 114
   query92  87  75  67  67
   query93  6978999 648 648
   query94  1144399 356 356
   query95  424 331 312 312
   query96  499 585 280 280
   query97  2693271525532553
   query98  259 223 226 223
   query99  1551134413031303
   Total cold run time: 302136 ms
   Total hot run time: 160349 ms
   ```

Re: [PR] [fix](nereids) set CompoundPredicate.nullableFromNereids after flattern and/or [doris]

2025-08-07 Thread via GitHub


doris-robot commented on PR #54353:
URL: https://github.com/apache/doris/pull/54353#issuecomment-3166737056

   
   
   TPC-H: Total hot run time: 33958 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 5c7e1f244e99acfe291fabbe969cba403fef0ab7, 
data reload: false
   
   -- Round 1 --
   q1   17577   524651435143
   q2   1958298 187 187
   q3   10269   1462722 722
   q4   10216   1027555 555
   q5   7491231222942294
   q6   177 165 134 134
   q7   890 748 639 639
   q8   9295129310791079
   q9   6820504351055043
   q10  6912237519671967
   q11  466 283 274 274
   q12  346 366 239 239
   q13  17794   350029682968
   q14  247 248 222 222
   q15  525 478 465 465
   q16  439 415 385 385
   q17  562 740 453 453
   q18  7921701870177017
   q19  1942984 557 557
   q20  325 321 219 219
   q21  3334315223792379
   q22  1052101810171017
   Total cold run time: 106558 ms
   Total hot run time: 33958 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   5371529153185291
   q2   234 313 218 218
   q3   2052260021652165
   q4   1285170512981298
   q5   4125407740304030
   q6   214 174 129 129
   q7   1798179316691669
   q8   2452235323202320
   q9   6824680568016801
   q10  3033321727732773
   q11  537 502 485 485
   q12  651 729 572 572
   q13  3206345030603060
   q14  268 302 270 270
   q15  494 447 437 437
   q16  429 454 422 422
   q17  1112136612871287
   q18  13337   763569746974
   q19  9737860 867 860
   q20  1930189518071807
   q21  14944   425043144250
   q22  1013105410011001
   Total cold run time: 75046 ms
   Total hot run time: 48119 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](nereids) set CompoundPredicate.nullableFromNereids after flattern and/or [doris]

2025-08-07 Thread via GitHub


feiniaofeiafei commented on PR #54353:
URL: https://github.com/apache/doris/pull/54353#issuecomment-3166734378

   can add related pr #44574  in description


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](nereids) set CompoundPredicate.nullableFromNereids after flattern and/or [doris]

2025-08-07 Thread via GitHub


englefly commented on PR #54353:
URL: https://github.com/apache/doris/pull/54353#issuecomment-3166701223

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](nereids) set CompoundPredicate.nullableFromNereids after flattern and/or [doris]

2025-08-07 Thread via GitHub


github-actions[bot] commented on PR #54353:
URL: https://github.com/apache/doris/pull/54353#issuecomment-3166481993

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](nereids) set CompoundPredicate.nullableFromNereids after flattern and/or [doris]

2025-08-07 Thread via GitHub


github-actions[bot] commented on PR #54353:
URL: https://github.com/apache/doris/pull/54353#issuecomment-3166481882

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](nereids) set CompoundPredicate.nullableFromNereids after flattern and/or [doris]

2025-08-06 Thread via GitHub


hello-stephen commented on PR #54353:
URL: https://github.com/apache/doris/pull/54353#issuecomment-3157984014

   # FE UT Coverage Report
   Increment line coverage `  27.27% (3/11)` :tada:
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/54353_a50a2965e48be5fbdcdc89e430f0a8b054f08b67/fe_increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/54353_a50a2965e48be5fbdcdc89e430f0a8b054f08b67/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](nereids) set CompoundPredicate.nullableFromNereids after flattern and/or [doris]

2025-08-06 Thread via GitHub


doris-robot commented on PR #54353:
URL: https://github.com/apache/doris/pull/54353#issuecomment-3157780580

   
   
   ClickBench: Total hot run time: 33.65 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit a50a2965e48be5fbdcdc89e430f0a8b054f08b67, 
data reload: false
   
   query1   0.040.040.03
   query2   0.090.040.04
   query3   0.250.070.07
   query4   1.630.110.12
   query5   0.410.400.44
   query6   1.140.660.64
   query7   0.030.020.02
   query8   0.050.040.03
   query9   0.540.490.47
   query10  0.520.520.52
   query11  0.160.100.10
   query12  0.140.100.10
   query13  0.660.650.62
   query14  0.901.111.23
   query15  0.950.860.89
   query16  0.390.380.38
   query17  1.031.091.07
   query18  0.220.200.20
   query19  1.981.801.92
   query20  0.020.010.02
   query21  15.37   0.850.55
   query22  0.791.210.73
   query23  14.84   1.160.60
   query24  6.831.241.39
   query25  0.490.250.21
   query26  0.520.150.13
   query27  0.050.060.06
   query28  9.630.840.47
   query29  12.59   3.873.31
   query30  3.002.962.93
   query31  2.820.560.40
   query32  3.230.550.49
   query33  2.993.253.20
   query34  16.01   5.305.00
   query35  4.905.004.89
   query36  0.730.520.50
   query37  0.090.070.07
   query38  0.060.040.05
   query39  0.040.030.02
   query40  0.170.140.14
   query41  0.080.030.03
   query42  0.040.030.02
   query43  0.040.040.04
   Total cold run time: 106.46 s
   Total hot run time: 33.65 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](nereids) set CompoundPredicate.nullableFromNereids after flattern and/or [doris]

2025-08-06 Thread via GitHub


doris-robot commented on PR #54353:
URL: https://github.com/apache/doris/pull/54353#issuecomment-3157749151

   
   
   TPC-DS: Total hot run time: 169465 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit a50a2965e48be5fbdcdc89e430f0a8b054f08b67, 
data reload: false
   
   
   query1   1021381 399 381
   query2   6515177216961696
   query3   6743239 219 219
   query4   26625   23337   22810   22810
   query5   4390616 514 514
   query6   330 232 216 216
   query7   4648516 294 294
   query8   273 235 223 223
   query9   8574297029592959
   query10  502 354 290 290
   query11  15728   15085   14771   14771
   query12  190 136 133 133
   query13  1659555 414 414
   query14  8603597358815881
   query15  231 211 187 187
   query16  7143632 444 444
   query17  970 758 637 637
   query18  2001444 331 331
   query19  238 211 188 188
   query20  198 150 143 143
   query21  225 120 109 109
   query22  3860415839503950
   query23  34454   34167   34301   34167
   query24  8157239124072391
   query25  539 507 422 422
   query26  903 290 159 159
   query27  2722510 348 348
   query28  4501232323082308
   query29  751 607 489 489
   query30  305 238 196 196
   query31  911 800 704 704
   query32  85  82  78  78
   query33  599 414 390 390
   query34  803 855 510 510
   query35  787 815 752 752
   query36  10321012931 931
   query37  140 109 94  94
   query38  3968392039553920
   query39  1437139113871387
   query40  245 146 129 129
   query41  62  60  55  55
   query42  139 120 125 120
   query43  514 506 492 492
   query44  1392893 863 863
   query45  200 188 186 186
   query46  957 1059709 709
   query47  1796185517441744
   query48  407 432 311 311
   query49  695 517 419 419
   query50  655 705 420 420
   query51  4122417441344134
   query52  123 140 117 117
   query53  262 286 218 218
   query54  648 652 551 551
   query55  94  89  94  89
   query56  358 354 349 349
   query57  1184123011271127
   query58  326 329 324 324
   query59  2572261625832583
   query60  401 416 426 416
   query61  128 140 120 120
   query62  804 739 649 649
   query63  265 220 217 217
   query64  34991086778 778
   query65  4201414641644146
   query66  1028447 334 334
   query67  query68 17706   880 852 852
   query69  1113269 275 269
   query70  1557113111271127
   query71  681 315 338 315
   query72  9130226021162116
   query73  3506684 356 356
   query74  8864899887048704
   query75  7436308226722672
   query76  86691220812 812
   query77  1161415 345 345
   query78  945410320   91789178
   query79  14054   603 582 582
   query80  1175554 501 501
   query81  549 258 214 214
   query82  422 153 114 114
   query83  350 287 270 270
   query84  310 99  81  81
   query85  822 375 411 375
   query86  370 357 303 303
   query87  4208418240484048
   query88  5177232022442244
   query89  466 352 316 316
   query90  2548233 225 225
   query91  143 153 114 114
   query92  91  74  71  71
   query93  5828994 655 655
   query94  972 414 277 277
   query95  399 331 316 316
   query96  508 603 283 283
   query97  2734268025962596
   query98  248 237 231 231
   query99  1448142212671267
   Total cold run time: 301937 ms
   Total hot run time: 169465 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo

Re: [PR] [fix](nereids) set CompoundPredicate.nullableFromNereids after flattern and/or [doris]

2025-08-06 Thread via GitHub


doris-robot commented on PR #54353:
URL: https://github.com/apache/doris/pull/54353#issuecomment-3157706361

   
   
   TPC-H: Total hot run time: 33602 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit a50a2965e48be5fbdcdc89e430f0a8b054f08b67, 
data reload: false
   
   -- Round 1 --
   q1   17579   518951865186
   q2   2014292 184 184
   q3   10227   1367691 691
   q4   10231   1032545 545
   q5   7519240123072307
   q6   175 162 134 134
   q7   894 767 604 604
   q8   9293125010461046
   q9   6809503350245024
   q10  6888234319811981
   q11  457 281 263 263
   q12  354 363 230 230
   q13  17764   349530133013
   q14  231 242 217 217
   q15  528 466 463 463
   q16  413 421 369 369
   q17  571 824 343 343
   q18  7387701370167013
   q19  1256992 542 542
   q20  323 312 215 215
   q21  3382302822512251
   q22  10241054981 981
   Total cold run time: 105319 ms
   Total hot run time: 33602 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   5294536754215367
   q2   238 304 218 218
   q3   2095255722062206
   q4   1284172413211321
   q5   4106425645274256
   q6   216 176 130 130
   q7   2014192417831783
   q8   2484255324952495
   q9   7304738674667386
   q10  3215332129012901
   q11  563 514 478 478
   q12  715 760 611 611
   q13  374532783278
   q14  318 302 296 296
   q15  504 452 447 447
   q16  447 511 444 444
   q17  2061154013761376
   q18  7860766277417662
   q19  13209   962 915 915
   q20  3620207318501850
   q21  15655   466143224322
   q22  1108102310061006
   Total cold run time: 77643 ms
   Total hot run time: 50748 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](nereids) set CompoundPredicate.nullableFromNereids after flattern and/or [doris]

2025-08-06 Thread via GitHub


englefly commented on PR #54353:
URL: https://github.com/apache/doris/pull/54353#issuecomment-3157648178

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](nereids) set CompoundPredicate.nullableFromNereids after flattern and/or [doris]

2025-08-06 Thread via GitHub


englefly commented on code in PR #54353:
URL: https://github.com/apache/doris/pull/54353#discussion_r2256064850


##
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/ExpressionTranslator.java:
##
@@ -367,6 +367,11 @@ private Expr toBalancedTree(int low, int high, List 
children,
 Expr left = children.get(l);
 Expr right = children.get(h);
 CompoundPredicate cp = new CompoundPredicate(op, left, 
right);
+boolean nullable = 
left.getNullableFromNereids().isPresent() && left.getNullableFromNereids().get()
+|| left.isNullable()
+|| right.getNullableFromNereids().isPresent() && 
right.getNullableFromNereids().get()
+|| right.isNullable();
+cp.setNullableFromNereids(nullable);

Review Comment:
   done
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](nereids) set CompoundPredicate.nullableFromNereids after flattern and/or [doris]

2025-08-05 Thread via GitHub


morrySnow commented on code in PR #54353:
URL: https://github.com/apache/doris/pull/54353#discussion_r2255778152


##
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/ExpressionTranslator.java:
##
@@ -367,6 +367,11 @@ private Expr toBalancedTree(int low, int high, List 
children,
 Expr left = children.get(l);
 Expr right = children.get(h);
 CompoundPredicate cp = new CompoundPredicate(op, left, 
right);
+boolean nullable = 
left.getNullableFromNereids().isPresent() && left.getNullableFromNereids().get()
+|| left.isNullable()
+|| right.getNullableFromNereids().isPresent() && 
right.getNullableFromNereids().get()
+|| right.isNullable();
+cp.setNullableFromNereids(nullable);

Review Comment:
   i think we should only rely on `NullableFromNereids`. in which case 
NullableFromNereids is not present?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](nereids) set CompoundPredicate.nullableFromNereids after flattern and/or [doris]

2025-08-05 Thread via GitHub


hello-stephen commented on PR #54353:
URL: https://github.com/apache/doris/pull/54353#issuecomment-3157225460

   # FE UT Coverage Report
   Increment line coverage `  27.27% (3/11)` :tada:
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/54353_030a8bef4a13bc9edd91eed98a264e053cc69693/fe_increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/54353_030a8bef4a13bc9edd91eed98a264e053cc69693/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](nereids) set CompoundPredicate.nullableFromNereids after flattern and/or [doris]

2025-08-05 Thread via GitHub


doris-robot commented on PR #54353:
URL: https://github.com/apache/doris/pull/54353#issuecomment-3157173544

   
   
   ClickBench: Total hot run time: 32.81 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 030a8bef4a13bc9edd91eed98a264e053cc69693, 
data reload: false
   
   query1   0.040.040.04
   query2   0.080.040.05
   query3   0.240.070.07
   query4   1.610.110.11
   query5   0.430.400.42
   query6   1.150.660.66
   query7   0.030.020.02
   query8   0.050.040.04
   query9   0.560.480.47
   query10  0.520.520.52
   query11  0.150.100.11
   query12  0.150.110.11
   query13  0.660.630.65
   query14  0.931.170.99
   query15  0.940.900.89
   query16  0.390.400.40
   query17  1.071.081.06
   query18  0.220.210.20
   query19  2.041.881.81
   query20  0.020.010.01
   query21  15.42   0.860.55
   query22  0.781.140.60
   query23  15.02   1.240.63
   query24  6.441.930.63
   query25  0.520.200.06
   query26  0.530.170.13
   query27  0.060.060.05
   query28  9.990.860.44
   query29  12.58   3.783.28
   query30  3.032.983.00
   query31  2.820.560.40
   query32  3.240.580.51
   query33  3.033.223.26
   query34  16.10   5.334.97
   query35  4.924.915.00
   query36  0.700.530.51
   query37  0.100.080.07
   query38  0.050.040.05
   query39  0.040.030.03
   query40  0.170.140.14
   query41  0.090.040.03
   query42  0.040.030.03
   query43  0.050.040.03
   Total cold run time: 107 s
   Total hot run time: 32.81 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](nereids) set CompoundPredicate.nullableFromNereids after flattern and/or [doris]

2025-08-05 Thread via GitHub


doris-robot commented on PR #54353:
URL: https://github.com/apache/doris/pull/54353#issuecomment-3157166213

   
   
   TPC-DS: Total hot run time: 170899 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 030a8bef4a13bc9edd91eed98a264e053cc69693, 
data reload: false
   
   
   query1   1005384 416 384
   query2   6509175016701670
   query3   6747227 227 227
   query4   26865   23850   23178   23178
   query5   4385639 530 530
   query6   334 245 222 222
   query7   4631519 303 303
   query8   283 241 232 232
   query9   8603297029932970
   query10  460 343 316 316
   query11  15790   15043   14749   14749
   query12  195 138 130 130
   query13  1665569 431 431
   query14  8605599158905890
   query15  211 204 172 172
   query16  7142675 492 492
   query17  995 771 636 636
   query18  2023449 326 326
   query19  225 212 195 195
   query20  157 141 143 141
   query21  217 126 111 111
   query22  4056404438853885
   query23  34718   34234   34411   34234
   query24  8172239924452399
   query25  574 523 458 458
   query26  1227292 162 162
   query27  2720503 344 344
   query28  4388234823462346
   query29  803 602 488 488
   query30  300 239 204 204
   query31  892 788 746 746
   query32  88  76  84  76
   query33  621 431 378 378
   query34  816 843 521 521
   query35  822 831 764 764
   query36  10381055921 921
   query37  151 109 94  94
   query38  3968398638833883
   query39  1440137113531353
   query40  248 137 129 129
   query41  62  60  54  54
   query42  140 123 130 123
   query43  499 511 484 484
   query44  1410880 863 863
   query45  199 183 183 183
   query46  951 1069686 686
   query47  1790185017281728
   query48  422 445 308 308
   query49  728 531 422 422
   query50  671 683 409 409
   query51  4251416142944161
   query52  130 135 119 119
   query53  262 289 216 216
   query54  653 647 555 555
   query55  87  91  91  91
   query56  350 359 362 359
   query57  1211121811671167
   query58  333 335 345 335
   query59  2635262525902590
   query60  403 393 379 379
   query61  126 123 163 123
   query62  835 720 649 649
   query63  256 219 212 212
   query64  43911110792 792
   query65  4247414041634140
   query66  1170447 333 333
   query67  query68 18412   891 989 891
   query69  990 282 308 282
   query70  1402111511271115
   query71  646 324 324 324
   query72  90432272
   query73  4645698 362 362
   query74  9028894589628945
   query75  6825313627812781
   query76  83531234828 828
   query77  1158429 353 353
   query78  971311462   94229422
   query79  15433   585 581 581
   query80  1530590 480 480
   query81  563 262 235 235
   query82  470 151 118 118
   query83  371 284 266 266
   query84  301 99  87  87
   query85  989 398 339 339
   query86  364 314 282 282
   query87  4152418541354135
   query88  5517227522992275
   query89  486 363 310 310
   query90  2585231 232 231
   query91  148 155 112 112
   query92  90  71  66  66
   query93  64381022658 658
   query94  1138396 286 286
   query95  415 334 330 330
   query96  508 587 284 284
   query97  2681271625942594
   query98  249 233 222 222
   query99  1477141613121312
   Total cold run time: 308421 ms
   Total hot run time: 170899 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo

Re: [PR] [fix](nereids) set CompoundPredicate.nullableFromNereids after flattern and/or [doris]

2025-08-05 Thread via GitHub


doris-robot commented on PR #54353:
URL: https://github.com/apache/doris/pull/54353#issuecomment-3157150521

   
   
   TPC-H: Total hot run time: 33499 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 030a8bef4a13bc9edd91eed98a264e053cc69693, 
data reload: false
   
   -- Round 1 --
   q1   17597   528351315131
   q2   1908274 179 179
   q3   10342   1380718 718
   q4   10216   1014531 531
   q5   7557232222972297
   q6   178 166 130 130
   q7   860 762 613 613
   q8   9293118310551055
   q9   6762505550685055
   q10  6903238119671967
   q11  452 284 260 260
   q12  351 369 222 222
   q13  17778   350729882988
   q14  226 247 232 232
   q15  532 456 466 456
   q16  428 426 371 371
   q17  556 821 345 345
   q18  7360700469476947
   q19  1431976 545 545
   q20  316 316 218 218
   q21  3546302322572257
   q22  10621064982 982
   Total cold run time: 105654 ms
   Total hot run time: 33499 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   5564529353695293
   q2   252 318 220 220
   q3   2131255121762176
   q4   1307170213241324
   q5   4110430644554306
   q6   252 179 133 133
   q7   1991190818131813
   q8   2480240824212408
   q9   7341733071267126
   q10  3486336728972897
   q11  554 488 503 488
   q12  738 789 658 658
   q13  3387371232833283
   q14  305 316 290 290
   q15  498 454 503 454
   q16  477 514 470 470
   q17  1270146714751467
   q18  8930752778607527
   q19  12279   864 863 863
   q20  3571198118391839
   q21  15441   485042214221
   q22  11321028996 996
   Total cold run time: 77496 ms
   Total hot run time: 50252 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](nereids) set CompoundPredicate.nullableFromNereids after flattern and/or [doris]

2025-08-05 Thread via GitHub


englefly commented on PR #54353:
URL: https://github.com/apache/doris/pull/54353#issuecomment-3157119766

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](nereids) set CompoundPredicate.nullableFromNereids after flattern and/or [doris]

2025-08-05 Thread via GitHub


hello-stephen commented on PR #54353:
URL: https://github.com/apache/doris/pull/54353#issuecomment-3154884595

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting 
information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it 
now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and 
after the optimization?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]