Re: [PR] [fix](s3) Add anonymous credential fallback for S3 TVF on public buckets [doris]

2026-02-04 Thread via GitHub 


Copilot commented on code in PR #60515:
URL: https://github.com/apache/doris/pull/60515#discussion_r2766781614


##
fe/fe-core/src/main/java/org/apache/doris/tablefunction/S3TableValuedFunction.java:
##
@@ -57,8 +60,69 @@ public S3TableValuedFunction(Map properties) 
throws AnalysisExce
 // Fixme wait to be done  #50320
 // FileSystemFactory.get(storageProperties);
 } else {
-parseFile();
+try {
+parseFile();
+} catch (AnalysisException e) {
+if (shouldRetryWithAnonymous(e)) {
+LOG.info("S3 TVF got 403 with no explicit credentials, 
retrying with anonymous access");

Review Comment:
   The code uses LOG (at lines 67 and 71) which is inherited from the parent 
class ExternalFileTableValuedFunction. This means log messages will be 
associated with the parent class name rather than S3TableValuedFunction. For 
consistency with other table-valued functions in the codebase (e.g., 
HdfsTableValuedFunction defines its own LOG at line 38), consider adding a 
static LOG field specific to this class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](s3) Add anonymous credential fallback for S3 TVF on public buckets [doris]

2026-02-04 Thread via GitHub 


hello-stephen commented on PR #60515:
URL: https://github.com/apache/doris/pull/60515#issuecomment-3850715324

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting 
information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it 
now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and 
after the optimization?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]