Re: [PR] [fix](tablet io error) fix tablet not increase _io_error_times in some cases. [doris]
dataroaring merged PR #42208: URL: https://github.com/apache/doris/pull/42208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tablet io error) fix tablet not increase _io_error_times in some cases. [doris]
yujun777 commented on PR #42208: URL: https://github.com/apache/doris/pull/42208#issuecomment-2431761611 run cloud_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tablet io error) fix tablet not increase _io_error_times in some cases. [doris]
yujun777 commented on PR #42208: URL: https://github.com/apache/doris/pull/42208#issuecomment-2431761023 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tablet io error) fix tablet not increase _io_error_times in some cases. [doris]
yujun777 commented on PR #42208: URL: https://github.com/apache/doris/pull/42208#issuecomment-2431759577 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tablet io error) fix tablet not increase _io_error_times in some cases. [doris]
github-actions[bot] commented on PR #42208: URL: https://github.com/apache/doris/pull/42208#issuecomment-2431200323 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tablet io error) fix tablet not increase _io_error_times in some cases. [doris]
doris-robot commented on PR #42208: URL: https://github.com/apache/doris/pull/42208#issuecomment-2431184467 TeamCity be ut coverage result: Function Coverage: 37.49% (9710/25903) Line Coverage: 28.76% (80593/280262) Region Coverage: 28.17% (41671/147901) Branch Coverage: 24.72% (21167/85628) Coverage Report: http://coverage.selectdb-in.cc/coverage/fdb10b0c99326a608f62c138a3097fd25a8ffb4c_fdb10b0c99326a608f62c138a3097fd25a8ffb4c/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tablet io error) fix tablet not increase _io_error_times in some cases. [doris]
yujun777 commented on PR #42208: URL: https://github.com/apache/doris/pull/42208#issuecomment-2431127687 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tablet io error) fix tablet not increase _io_error_times in some cases. [doris]
yujun777 commented on PR #42208: URL: https://github.com/apache/doris/pull/42208#issuecomment-2431085270 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tablet io error) fix tablet not increase _io_error_times in some cases. [doris]
doris-robot commented on PR #42208: URL: https://github.com/apache/doris/pull/42208#issuecomment-2430887908 TeamCity be ut coverage result: Function Coverage: 37.47% (9710/25912) Line Coverage: 28.75% (80590/280352) Region Coverage: 28.16% (41660/147964) Branch Coverage: 24.71% (21164/85640) Coverage Report: http://coverage.selectdb-in.cc/coverage/f336a11c51b3632a41a40229c346c77bfa881b42_f336a11c51b3632a41a40229c346c77bfa881b42/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tablet io error) fix tablet not increase _io_error_times in some cases. [doris]
yujun777 commented on PR #42208: URL: https://github.com/apache/doris/pull/42208#issuecomment-2430799284 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tablet io error) fix tablet not increase _io_error_times in some cases. [doris]
yujun777 commented on PR #42208: URL: https://github.com/apache/doris/pull/42208#issuecomment-2430749801 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tablet io error) fix tablet not increase _io_error_times in some cases. [doris]
yujun777 commented on PR #42208: URL: https://github.com/apache/doris/pull/42208#issuecomment-2428812327 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tablet io error) fix tablet not increase _io_error_times in some cases. [doris]
yujun777 commented on PR #42208: URL: https://github.com/apache/doris/pull/42208#issuecomment-2428670717 run beut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tablet io error) fix tablet not increase _io_error_times in some cases. [doris]
github-actions[bot] commented on PR #42208: URL: https://github.com/apache/doris/pull/42208#issuecomment-2428626591 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tablet io error) fix tablet not increase _io_error_times in some cases. [doris]
github-actions[bot] commented on PR #42208: URL: https://github.com/apache/doris/pull/42208#issuecomment-2428626678 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tablet io error) fix tablet not increase _io_error_times in some cases. [doris]
yujun777 commented on PR #42208: URL: https://github.com/apache/doris/pull/42208#issuecomment-2428560502 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tablet io error) fix tablet not increase _io_error_times in some cases. [doris]
doris-robot commented on PR #42208: URL: https://github.com/apache/doris/pull/42208#issuecomment-2426591875 TeamCity be ut coverage result: Function Coverage: 37.46% (9700/25891) Line Coverage: 28.71% (80549/280536) Region Coverage: 28.15% (41680/148059) Branch Coverage: 24.71% (21179/85706) Coverage Report: http://coverage.selectdb-in.cc/coverage/58faebf163eeefcf4f6918146056c636b98bbb89_58faebf163eeefcf4f6918146056c636b98bbb89/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tablet io error) fix tablet not increase _io_error_times in some cases. [doris]
yujun777 commented on PR #42208: URL: https://github.com/apache/doris/pull/42208#issuecomment-2426503563 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tablet io error) fix tablet not increase _io_error_times in some cases. [doris]
github-actions[bot] commented on PR #42208: URL: https://github.com/apache/doris/pull/42208#issuecomment-2426411610 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tablet io error) fix tablet not increase _io_error_times in some cases. [doris]
yujun777 commented on PR #42208: URL: https://github.com/apache/doris/pull/42208#issuecomment-2426402543 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tablet io error) fix tablet not increase _io_error_times in some cases. [doris]
doris-robot commented on PR #42208: URL: https://github.com/apache/doris/pull/42208#issuecomment-2426358535 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tablet io error) fix tablet not increase _io_error_times in some cases. [doris]
github-actions[bot] commented on code in PR #42208: URL: https://github.com/apache/doris/pull/42208#discussion_r1808579502 ## be/src/runtime/load_stream.cpp: ## @@ -31,11 +31,14 @@ #include #include "bvar/bvar.h" +#include "cloud/config.h" #include "common/signal_handler.h" #include "exec/tablet_info.h" #include "gutil/ref_counted.h" +#include "olap/tablet.h" #include "olap/tablet_fwd.h" #include "olap/tablet_schema.h" +#include "runtime/exec_env.h" Review Comment: warning: duplicate include [readability-duplicate-include] be/src/runtime/load_stream.cpp:39: ```diff - #include "olap/tablet_schema.h" - #include "runtime/exec_env.h" + #include "olap/tablet_schema.h" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org