Re: [PR] [fix](thrift) Reserve frontend service field ids [doris]

2026-05-17 Thread via GitHub


starocean999 merged PR #63239:
URL: https://github.com/apache/doris/pull/63239


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](thrift) Reserve frontend service field ids [doris]

2026-05-15 Thread via GitHub


hello-stephen commented on PR #63239:
URL: https://github.com/apache/doris/pull/63239#issuecomment-4459399460

   # FE Regression Coverage Report
   Increment line coverage `  0.00% (0/1214)` :tada:
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/63239_cb96f3374cc92ee770a2bcc2136567ba4e687362_merge_fe/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/63239_cb96f3374cc92ee770a2bcc2136567ba4e687362_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](thrift) Reserve frontend service field ids [doris]

2026-05-15 Thread via GitHub


hello-stephen commented on PR #63239:
URL: https://github.com/apache/doris/pull/63239#issuecomment-4459325112

   # BE Regression && UT Coverage Report
   Increment line coverage `100% (0/0)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/63239_cb96f3374cc92ee770a2bcc2136567ba4e687362_merge/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/63239_cb96f3374cc92ee770a2bcc2136567ba4e687362_merge/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 73.77% (27814/37705) |
   | Line Coverage | 57.63% (301347/522872) |
   | Region Coverage   | 54.83% (251436/458559) |
   | Branch Coverage   | 56.38% (108804/192998) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](thrift) Reserve frontend service field ids [doris]

2026-05-14 Thread via GitHub


hello-stephen commented on PR #63239:
URL: https://github.com/apache/doris/pull/63239#issuecomment-4448881430

   # FE Regression Coverage Report
   Increment line coverage `  0.00% (0/18)` :tada:
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/63239_cb96f3374cc92ee770a2bcc2136567ba4e687362_merge_fe/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/63239_cb96f3374cc92ee770a2bcc2136567ba4e687362_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](thrift) Reserve frontend service field ids [doris]

2026-05-14 Thread via GitHub


hello-stephen commented on PR #63239:
URL: https://github.com/apache/doris/pull/63239#issuecomment-4448815728

   # BE Regression && UT Coverage Report
   Increment line coverage `100% (0/0)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/63239_cb96f3374cc92ee770a2bcc2136567ba4e687362_merge/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/63239_cb96f3374cc92ee770a2bcc2136567ba4e687362_merge/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 73.77% (27814/37705) |
   | Line Coverage | 57.63% (301331/522872) |
   | Region Coverage   | 54.83% (251411/458559) |
   | Branch Coverage   | 56.37% (108799/192998) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](thrift) Reserve frontend service field ids [doris]

2026-05-13 Thread via GitHub


hello-stephen commented on PR #63239:
URL: https://github.com/apache/doris/pull/63239#issuecomment-4448304283

   
   
   TPC-DS: Total hot run time: 171249 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit cb96f3374cc92ee770a2bcc2136567ba4e687362, 
data reload: false
   
   query5   4319672 515 515
   query6   330 245 242 242
   query7   4260586 306 306
   query8   327 244 235 235
   query9   8880411640934093
   query10  459 358 298 298
   query11  5838245822722272
   query12  188 131 128 128
   query13  1287661 437 437
   query14  6589537951025102
   query14_14419447944284428
   query15  215 204 189 189
   query16  1048503 440 440
   query17  1131754 621 621
   query18  2726498 348 348
   query19  211 202 169 169
   query20  138 139 133 133
   query21  214 141 117 117
   query22  13672   13581   13513   13513
   query23  17347   16474   16124   16124
   query23_116213   16125   16197   16125
   query24  7395175413651365
   query24_11394139813751375
   query25  568 492 432 432
   query26  1341322 177 177
   query27  2696582 348 348
   query28  4346202919761976
   query29  994 640 521 521
   query30  309 243 201 201
   query31  11581071941 941
   query32  96  81  75  75
   query33  534 365 283 283
   query34  11811143664 664
   query35  790 809 683 683
   query36  1319135711601160
   query37  155 103 97  97
   query38  3221315330643064
   query39  930 911 896 896
   query39_1874 898 868 868
   query40  260 170 150 150
   query41  73  67  70  67
   query42  114 113 115 113
   query43  335 331 294 294
   query44  
   query45  221 208 203 203
   query46  10981241790 790
   query47  2306228921482148
   query48  426 399 318 318
   query49  659 538 467 467
   query50  739 301 234 234
   query51  4286435342144214
   query52  111 114 102 102
   query53  270 299 217 217
   query54  335 302 268 268
   query55  97  94  92  92
   query56  329 328 331 328
   query57  1410137312791279
   query58  304 293 281 281
   query59  1519163014181418
   query60  350 360 330 330
   query61  177 179 177 177
   query62  669 620 555 555
   query63  255 211 213 211
   query64  2440879 771 771
   query65  
   query66  1685524 400 400
   query67  29891   29898   29732   29732
   query68  
   query69  457 359 300 300
   query70  1040103810001000
   query71  310 284 275 275
   query72  2934274824202420
   query73  856 773 439 439
   query74  5094492047504750
   query75  2780266723232323
   query76  22691165805 805
   query77  434 424 362 362
   query78  12951   13091   12384   12384
   query79  15121051735 735
   query80  1380627 489 489
   query81  510 276 244 244
   query82  1365159 126 126
   query83  346 286 257 257
   query84  266 145 116 116
   query85  1065525 451 451
   query86  434 328 300 300
   query87  3432338231973197
   query88  3624270226732673
   query89  454 388 341 341
   query90  1845183 186 183
   query91  182 179 146 146
   query92  81  80  79  79
   query93  1002995 574 574
   query94  647 345 319 319
   query95  676 477 343 343
   query96  1031790 359 359
   query97  2685267325962596
   query98  244 230 227 227
   query99  11121096976 976
   Total cold run time: 255430 ms
   Total hot run time: 171249 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

Re: [PR] [fix](thrift) Reserve frontend service field ids [doris]

2026-05-13 Thread via GitHub


hello-stephen commented on PR #63239:
URL: https://github.com/apache/doris/pull/63239#issuecomment-4448232906

   
   
   TPC-H: Total hot run time: 29906 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit cb96f3374cc92ee770a2bcc2136567ba4e687362, 
data reload: false
   
   -- Round 1 --
   orders   Doris   NULLNULL0   0   0   NULL0   
NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8   
NULLNULL
   
   q1   17814   398240263982
   q2   q3  10763   899 624 624
   q4   4727468 349 349
   q5   8003133811391139
   q6   320 175 141 141
   q7   958 961 764 764
   q8   11009   143113171317
   q9   7465557653105310
   q10  6394206518381838
   q11  468 274 256 256
   q12  694 420 311 311
   q13  18188   333827612761
   q14  293 285 261 261
   q15  q16 897 871 789 789
   q17  936 1031723 723
   q18  6506561056385610
   q19  1210136011201120
   q20  546 456 264 264
   q21  4834238220002000
   q22  467 384 347 347
   Total cold run time: 102492 ms
   Total hot run time: 29906 ms
   
   - Round 2, with runtime_filter_mode=off -
   orders   Doris   NULLNULL15000   42  6422171781  
NULL22778155NULLNULL2023-12-26 18:27:23 2023-12-26 
18:42:55 NULLutf-8   NULLNULL
   
   q1   4958497245924592
   q2   q3  4662477841994199
   q4   2124216713871387
   q5   4956500652915006
   q6   199 175 140 140
   q7   1995177716321632
   q8   3348309532133095
   q9   8480858183998399
   q10  4471452242684268
   q11  614 411 399 399
   q12  693 747 543 543
   q13  3215382628852885
   q14  301 300 266 266
   q15  q16 776 812 694 694
   q17  1389130412841284
   q18  7951714570927092
   q19  1156116011521152
   q20  2237221119531953
   q21  6176550649104910
   q22  564 505 414 414
   Total cold run time: 60265 ms
   Total hot run time: 54310 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](thrift) Reserve frontend service field ids [doris]

2026-05-13 Thread via GitHub


github-actions[bot] commented on PR #63239:
URL: https://github.com/apache/doris/pull/63239#issuecomment-4448126021

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](thrift) Reserve frontend service field ids [doris]

2026-05-13 Thread via GitHub


github-actions[bot] commented on PR #63239:
URL: https://github.com/apache/doris/pull/63239#issuecomment-4448125844

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](thrift) Reserve frontend service field ids [doris]

2026-05-13 Thread via GitHub


morrySnow commented on PR #63239:
URL: https://github.com/apache/doris/pull/63239#issuecomment-4448123806

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](thrift) Reserve frontend service field ids [doris]

2026-05-13 Thread via GitHub


seawinde commented on PR #63239:
URL: https://github.com/apache/doris/pull/63239#issuecomment-4447516408

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](thrift) Reserve frontend service field ids [doris]

2026-05-13 Thread via GitHub


hello-stephen commented on PR #63239:
URL: https://github.com/apache/doris/pull/63239#issuecomment-4447515031

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting 
information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it 
now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and 
after the optimization?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]