Re: [PR] [improvement](parser) Skip hidden tokens in internal SQL parsing [doris]

2026-09-03 Thread via GitHub


hello-stephen commented on PR #67434:
URL: https://github.com/apache/doris/pull/67434#issuecomment-5523027388

   # FE Regression Coverage Report
   Increment line coverage `  51.85% (14/27)` :tada:
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/67434_89eb5688fdc10575b5fe9057df5373c82f998a86_merge_fe/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/67434_89eb5688fdc10575b5fe9057df5373c82f998a86_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [improvement](parser) Skip hidden tokens in internal SQL parsing [doris]

2026-09-03 Thread via GitHub


morrySnow merged PR #67434:
URL: https://github.com/apache/doris/pull/67434


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [improvement](parser) Skip hidden tokens in internal SQL parsing [doris]

2026-09-02 Thread via GitHub


hello-stephen commented on PR #67434:
URL: https://github.com/apache/doris/pull/67434#issuecomment-5520165568

   
   
   ClickBench: Total hot run time: 14.56 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 89eb5688fdc10575b5fe9057df5373c82f998a86, 
data reload: false
   
   query1   0.010.000.01
   query2   0.070.040.04
   query3   0.250.110.11
   query4   1.600.090.09
   query5   0.180.150.16
   query6   1.240.720.67
   query7   0.030.000.01
   query8   0.040.030.03
   query9   0.280.210.22
   query10  0.350.360.35
   query11  0.160.110.12
   query12  0.150.120.12
   query13  0.300.310.31
   query14  0.460.450.47
   query15  0.350.350.34
   query16  0.210.220.22
   query17  0.680.670.62
   query18  0.170.150.17
   query19  1.201.161.16
   query20  0.020.010.01
   query21  15.44   0.150.11
   query22  5.070.040.04
   query23  16.18   0.250.10
   query24  2.930.310.27
   query25  0.130.030.03
   query26  0.800.170.12
   query27  0.040.040.03
   query28  3.640.530.25
   query29  12.48   3.122.55
   query30  0.250.110.13
   query31  2.760.350.17
   query32  3.550.320.23
   query33  1.361.611.43
   query34  15.44   2.221.75
   query35  1.721.741.72
   query36  0.450.300.29
   query37  0.060.040.04
   query38  0.040.020.02
   query39  0.020.020.02
   query40  0.120.070.08
   query41  0.080.030.02
   query42  0.030.030.03
   query43  0.030.020.03
   Total cold run time: 90.37 s
   Total hot run time: 14.56 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [improvement](parser) Skip hidden tokens in internal SQL parsing [doris]

2026-09-02 Thread via GitHub


hello-stephen commented on PR #67434:
URL: https://github.com/apache/doris/pull/67434#issuecomment-5520130347

   
   
   TPC-DS: Total hot run time: 81828 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 89eb5688fdc10575b5fe9057df5373c82f998a86, 
data reload: false
   
   query5   4230416 355 355
   query6   401 140 121 121
   query7   4923398 244 244
   query8   309 124 113 113
   query9   8707285328482848
   query10  384 218 187 187
   query11  53961028893 893
   query12  117 71  69  69
   query13  1189445 321 321
   query14  6059220620742074
   query14_11960194819541948
   query15  175 118 113 113
   query16  930 373 362 362
   query17  808 475 399 399
   query18  2340330 244 244
   query19  179 137 110 110
   query20  89  78  68  68
   query21  205 101 86  86
   query22  5348552851945194
   query23  6626625261116111
   query23_16192605061376050
   query24  72581106791 791
   query24_1790 765 759 759
   query25  436 307 272 272
   query26  1236223 130 130
   query27  2796416 260 260
   query28  4673150115201501
   query29  948 460 361 361
   query30  242 156 132 132
   query31  824 394 326 326
   query32  128 77  74  74
   query33  469 225 195 195
   query34  1007820 460 460
   query35  408 409 338 338
   query36  573 571 512 512
   query37  122 84  74  74
   query38  1014858 812 812
   query39  512 484 477 477
   query39_1446 434 450 434
   query40  208 93  80  80
   query41  58  56  57  56
   query42  75  73  72  72
   query43  239 239 210 210
   query44  1037543 551 543
   query45  111 110 115 110
   query46  769 854 548 548
   query47  753 759 708 708
   query48  296 306 231 231
   query49  532 244 183 183
   query50  718 260 191 191
   query51  8039807280288028
   query52  66  66  67  66
   query53  185 197 148 148
   query54  229 184 158 158
   query55  74  62  54  54
   query56  192 155 169 155
   query57  679 672 681 672
   query58  198 165 153 153
   query59  1236123111271127
   query60  247 171 170 170
   query61  134 125 124 124
   query62  341 212 174 174
   query63  195 142 141 141
   query64  2721675 611 611
   query65  1607158415671567
   query66  1910269 215 215
   query67  9764955096929550
   query68  30161236679 679
   query69  349 223 201 201
   query70  685 622 584 584
   query71  252 203 169 169
   query72  2372177715471547
   query73  621 594 338 338
   query74  2015122211241124
   query75  11941106954 954
   query76  2382715 541 541
   query77  259 259 209 209
   query78  3796371131733173
   query79  2197840 610 610
   query80  1599316 279 279
   query81  493 153 146 146
   query82  631 122 95  95
   query83  284 210 191 191
   query84  301 111 89  89
   query85  792 359 305 305
   query86  395 167 162 162
   query87  1016975 904 904
   query88  2763211821002100
   query89  287 196 172 172
   query90  1990128 121 121
   query91  135 123 100 100
   query92  71  69  71  69
   query93  13351059732 732
   query94  627 259 211 211
   query95  519 335 220 220
   query96  816 633 280 280
   query97  1031106010601060
   query98  141 136 129 129
   query99  415 349 310 310
   Total cold run time: 177252 ms
   Total hot run time: 81828 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific 

Re: [PR] [improvement](parser) Skip hidden tokens in internal SQL parsing [doris]

2026-09-02 Thread via GitHub


hello-stephen commented on PR #67434:
URL: https://github.com/apache/doris/pull/67434#issuecomment-5520080238

   
   
   TPC-H: Total hot run time: 16617 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 89eb5688fdc10575b5fe9057df5373c82f998a86, 
data reload: false
   
   -- Round 1 --
   
   q1   17560   305330273027
   q2   2144269 237 237
   q3   10176   880 517 517
   q4   4684244 196 196
   q5   7684585 390 390
   q6   135 112 91  91
   q7   530 491 381 381
   q8   9236848 865 848
   q9   3469237423552355
   q10  6517845 726 726
   q11  390 202 177 177
   q12  607 259 200 200
   q13  18151   152111441144
   q14  154 149 137 137
   q15  q16 434 395 373 373
   q17  1347914 812 812
   q18  3104223322252225
   q19  1269860 745 745
   q20  378 280 195 195
   q21  5562161717731617
   q22  330 260 224 224
   Total cold run time: 93861 ms
   Total hot run time: 16617 ms
   
   - Round 2, with runtime_filter_mode=off -
   
   q1   3416334733093309
   q2   496 383 360 360
   q3   2184230721472147
   q4   11701163894 894
   q5   2152208820732073
   q6   169 116 86  86
   q7   1072907 852 852
   q8   1582140614131406
   q9   3112308430883084
   q10  1849176115851585
   q11  351 273 249 249
   q12  451 426 332 332
   q13  1493152411441144
   q14  164 175 157 157
   q15  q16 395 394 370 370
   q17  3541327932453245
   q18  4763437146904371
   q19  845 790 821 790
   q20  1155995 816 816
   q21  3868308833623088
   q22  394 340 318 318
   Total cold run time: 34622 ms
   Total hot run time: 30676 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [improvement](parser) Skip hidden tokens in internal SQL parsing [doris]

2026-09-02 Thread via GitHub


morrySnow commented on PR #67434:
URL: https://github.com/apache/doris/pull/67434#issuecomment-5519619555

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [improvement](parser) Skip hidden tokens in internal SQL parsing [doris]

2026-09-02 Thread via GitHub


hello-stephen commented on PR #67434:
URL: https://github.com/apache/doris/pull/67434#issuecomment-5513697611

   # FE Regression Coverage Report
   Increment line coverage `  17.33% (13/75)` :tada:
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/67434_5ef28695247744992e354071e683656aea30a5fe_merge_fe/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/67434_5ef28695247744992e354071e683656aea30a5fe_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [improvement](parser) Skip hidden tokens in internal SQL parsing [doris]

2026-09-02 Thread via GitHub


hello-stephen commented on PR #67434:
URL: https://github.com/apache/doris/pull/67434#issuecomment-5509906678

   # FE Regression Coverage Report
   Increment line coverage `  50.00% (13/26)` :tada:
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/67434_5ef28695247744992e354071e683656aea30a5fe_merge_fe/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/67434_5ef28695247744992e354071e683656aea30a5fe_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [improvement](parser) Skip hidden tokens in internal SQL parsing [doris]

2026-09-02 Thread via GitHub


hello-stephen commented on PR #67434:
URL: https://github.com/apache/doris/pull/67434#issuecomment-5508302548

   
   
   ClickBench: Total hot run time: 14.62 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 5ef28695247744992e354071e683656aea30a5fe, 
data reload: false
   
   query1   0.000.000.00
   query2   0.080.040.04
   query3   0.260.100.08
   query4   1.600.100.10
   query5   0.190.160.16
   query6   1.220.680.68
   query7   0.040.010.00
   query8   0.060.030.03
   query9   0.280.210.21
   query10  0.370.340.34
   query11  0.180.120.12
   query12  0.140.120.12
   query13  0.300.300.29
   query14  0.450.440.44
   query15  0.360.350.34
   query16  0.240.220.22
   query17  0.660.700.68
   query18  0.190.170.17
   query19  1.151.161.17
   query20  0.010.020.01
   query21  15.44   0.160.11
   query22  5.010.040.04
   query23  16.20   0.250.10
   query24  3.120.320.25
   query25  0.100.040.04
   query26  0.740.160.13
   query27  0.040.030.02
   query28  3.500.590.28
   query29  12.41   3.142.56
   query30  0.250.110.12
   query31  2.760.360.16
   query32  3.510.320.24
   query33  1.441.381.47
   query34  15.36   2.221.79
   query35  1.701.731.72
   query36  0.460.300.28
   query37  0.060.040.03
   query38  0.050.030.03
   query39  0.040.020.02
   query40  0.120.080.08
   query41  0.080.030.02
   query42  0.030.020.02
   query43  0.030.020.02
   Total cold run time: 90.23 s
   Total hot run time: 14.62 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [improvement](parser) Skip hidden tokens in internal SQL parsing [doris]

2026-09-02 Thread via GitHub


hello-stephen commented on PR #67434:
URL: https://github.com/apache/doris/pull/67434#issuecomment-5508249599

   
   
   TPC-DS: Total hot run time: 81388 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 5ef28695247744992e354071e683656aea30a5fe, 
data reload: false
   
   query5   4262404 335 335
   query6   394 132 121 121
   query7   4963429 235 235
   query8   295 128 120 120
   query9   8705288928572857
   query10  395 241 191 191
   query11  53951049916 916
   query12  126 71  74  71
   query13  1197476 321 321
   query14  6072218420702070
   query14_11961193719361936
   query15  171 120 119 119
   query16  920 394 352 352
   query17  823 454 379 379
   query18  2331338 260 260
   query19  188 128 100 100
   query20  67  65  66  65
   query21  197 97  82  82
   query22  5529537253845372
   query23  6717613358965896
   query23_15986586258755862
   query24  72861052766 766
   query24_1761 765 773 765
   query25  402 271 233 233
   query26  1246225 132 132
   query27  2796393 256 256
   query28  4748150514751475
   query29  917 415 329 329
   query30  249 153 126 126
   query31  802 386 320 320
   query32  148 74  69  69
   query33  451 218 169 169
   query34  1002836 498 498
   query35  397 386 341 341
   query36  571 569 539 539
   query37  128 75  67  67
   query38  1049831 788 788
   query39  493 460 459 459
   query39_1454 469 482 469
   query40  210 88  74  74
   query41  54  56  53  53
   query42  73  72  72  72
   query43  235 242 215 215
   query44  1028537 541 537
   query45  103 99  94  94
   query46  809 826 525 525
   query47  748 764 718 718
   query48  325 310 227 227
   query49  531 237 174 174
   query50  770 269 196 196
   query51  8188801279787978
   query52  75  69  63  63
   query53  199 199 146 146
   query54  228 187 182 182
   query55  79  62  65  62
   query56  214 184 189 184
   query57  674 649 674 649
   query58  227 173 172 172
   query59  1226125210981098
   query60  273 187 172 172
   query61  114 115 114 114
   query62  365 211 187 187
   query63  177 141 143 141
   query64  2825657 595 595
   query65  1564161416161614
   query66  1921250 200 200
   query67  9721967398229673
   query68  29921266686 686
   query69  358 215 196 196
   query70  664 608 618 608
   query71  254 172 168 168
   query72  2379176515471547
   query73  693 575 366 366
   query74  2000119611201120
   query75  11621089964 964
   query76  2378735 534 534
   query77  267 244 216 216
   query78  4158363131593159
   query79  2781810 582 582
   query80  1585328 289 289
   query81  523 151 129 129
   query82  743 130 94  94
   query83  279 210 185 185
   query84  304 111 87  87
   query85  826 397 300 300
   query86  477 174 163 163
   query87  1005984 891 891
   query88  2963211821112111
   query89  297 200 182 182
   query90  2111119 130 119
   query91  136 124 100 100
   query92  100 70  71  70
   query93  19411090680 680
   query94  726 275 214 214
   query95  535 248 234 234
   query96  796 565 282 282
   query97  10241027968 968
   query98  186 139 131 131
   query99  424 355 309 309
   Total cold run time: 180099 ms
   Total hot run time: 81388 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific 

Re: [PR] [improvement](parser) Skip hidden tokens in internal SQL parsing [doris]

2026-09-02 Thread via GitHub


hello-stephen commented on PR #67434:
URL: https://github.com/apache/doris/pull/67434#issuecomment-5508174960

   
   
   TPC-H: Total hot run time: 16770 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 5ef28695247744992e354071e683656aea30a5fe, 
data reload: false
   
   -- Round 1 --
   
   q1   17624   308730613061
   q2   2174257 227 227
   q3   10176   868 504 504
   q4   4671252 205 205
   q5   7671566 383 383
   q6   133 113 93  93
   q7   518 491 388 388
   q8   9245851 890 851
   q9   3429239923402340
   q10  6487854 689 689
   q11  393 194 182 182
   q12  603 264 209 209
   q13  18112   151511631163
   q14  157 150 141 141
   q15  q16 426 385 356 356
   q17  1346928 835 835
   q18  3117222622562226
   q19  1263933 798 798
   q20  378 290 203 203
   q21  5621168718731687
   q22  328 272 229 229
   Total cold run time: 93872 ms
   Total hot run time: 16770 ms
   
   - Round 2, with runtime_filter_mode=off -
   
   q1   3422337033393339
   q2   510 403 367 367
   q3   2235223121272127
   q4   11791167895 895
   q5   2164208121172081
   q6   170 118 89  89
   q7   1020960 876 876
   q8   1599142514111411
   q9   3101307931243079
   q10  1829178415881588
   q11  357 271 258 258
   q12  455 425 350 350
   q13  1481153911451145
   q14  167 181 163 163
   q15  q16 393 396 359 359
   q17  3618322431653165
   q18  4772438846904388
   q19  868 788 919 788
   q20  1005961 808 808
   q21  3881312333063123
   q22  397 345 308 308
   Total cold run time: 34623 ms
   Total hot run time: 30707 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [improvement](parser) Skip hidden tokens in internal SQL parsing [doris]

2026-09-02 Thread via GitHub


hello-stephen commented on PR #67434:
URL: https://github.com/apache/doris/pull/67434#issuecomment-5507996538

   # FE UT Coverage Report
   Increment line coverage `  92.86% (13/14)` :tada:
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/67434_5ef28695247744992e354071e683656aea30a5fe/fe_increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/67434_5ef28695247744992e354071e683656aea30a5fe/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [improvement](parser) Skip hidden tokens in internal SQL parsing [doris]

2026-09-02 Thread via GitHub


morrySnow commented on PR #67434:
URL: https://github.com/apache/doris/pull/67434#issuecomment-5506504834

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [improvement](parser) Skip hidden tokens in internal SQL parsing [doris]

2026-09-02 Thread via GitHub


hello-stephen commented on PR #67434:
URL: https://github.com/apache/doris/pull/67434#issuecomment-5505877489

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting 
information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it 
now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and 
after the optimization?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]